Re: [Mingw-w64-public] [PATCH] Remove executable bits

2017-08-25 Thread JonY via Mingw-w64-public
On 08/26/2017 03:33 AM, Martin Storsjö wrote: > On Sat, 26 Aug 2017, JonY via Mingw-w64-public wrote: > >> Patch OK? >> > > OK for me > > // Martin > Pushed. signature.asc Description: OpenPGP digital signature -- Ch

Re: [Mingw-w64-public] [PATCH] Remove executable bits

2017-08-25 Thread Martin Storsjö
On Sat, 26 Aug 2017, JonY via Mingw-w64-public wrote: Patch OK? OK for me // Martin -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot

[Mingw-w64-public] [PATCH] Remove executable bits

2017-08-25 Thread JonY via Mingw-w64-public
Patch OK? From b84b3d71e87a863bcf6794521d3f1fa0797fa166 Mon Sep 17 00:00:00 2001 From: Jonathan Yong <10wa...@gmail.com> Date: Sat, 26 Aug 2017 01:35:13 + Subject: [PATCH] Remove executable bit from source and text files Signed-off-by: Jonathan Yong <10wa...@gmail.com> --- mingw-w64-crt/math/

Re: [Mingw-w64-public] [PATCH] crt: Include _strftime_l in msvcrt.def.in

2017-08-25 Thread Martin Storsjö
On Fri, 25 Aug 2017, JonY via Mingw-w64-public wrote: On 08/25/2017 11:53 AM, Martin Storsjö wrote: This fixes linking of libc++, which uses this function. libc++ needs a msvcrt new enough to provide this function (present since msvcr90 in the numbered msvcrt DLLs). Patch OK. Pushed // Ma

Re: [Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h

2017-08-25 Thread Martin Storsjö
On Fri, 25 Aug 2017, Martin Storsjö wrote: On Fri, 25 Aug 2017, Mateusz Mikuła wrote: No problem, it was left forgotten there. Yes I was making clang able to host itself at MSYS2 and ran into this error on 64bit builds. If Lio says C-style cast is fine then I'm OK with that. I'm 80% sure I'v

Re: [Mingw-w64-public] [PATCH] crt: Build libwinspool.a for arm32 and arm64 as well

2017-08-25 Thread Martin Storsjö
On Fri, 25 Aug 2017, Martin Storsjö wrote: On Fri, 25 Aug 2017, JonY via Mingw-w64-public wrote: On 08/25/2017 11:53 AM, Martin Storsjö wrote: Use the lib64 version of the def file for this - nothing in the def file seems like it would be architecture specific. CMake has some linking tests w

Re: [Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h

2017-08-25 Thread Martin Storsjö
On Fri, 25 Aug 2017, Mateusz Mikuła wrote: No problem, it was left forgotten there. Yes I was making clang able to host itself at MSYS2 and ran into this error on 64bit builds. If Lio says C-style cast is fine then I'm OK with that. I'm 80% sure I've seen this in another project as well and GC

Re: [Mingw-w64-public] [PATCH] crt: Build libwinspool.a for arm32 and arm64 as well

2017-08-25 Thread Martin Storsjö
On Fri, 25 Aug 2017, JonY via Mingw-w64-public wrote: On 08/25/2017 11:53 AM, Martin Storsjö wrote: Use the lib64 version of the def file for this - nothing in the def file seems like it would be architecture specific. CMake has some linking tests where it by default links a number of "standar

Re: [Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h

2017-08-25 Thread JonY via Mingw-w64-public
On 08/25/2017 09:12 AM, Martin Storsjö wrote: > When building libcxx, a version of wcschr that returns const > is provided, breaking compilation here since the return from > wcschr is returned directly as if it were a const pointer. > By adding these casts, compilation succeeds. > > This matches t

Re: [Mingw-w64-public] [PATCH] crt: Include _strftime_l in msvcrt.def.in

2017-08-25 Thread JonY via Mingw-w64-public
On 08/25/2017 11:53 AM, Martin Storsjö wrote: > This fixes linking of libc++, which uses this function. libc++ > needs a msvcrt new enough to provide this function (present > since msvcr90 in the numbered msvcrt DLLs). > Patch OK. signature.asc Description: OpenPGP digital signature --

Re: [Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h

2017-08-25 Thread Mateusz Mikuła
No problem, it was left forgotten there. Yes I was making clang able to host itself at MSYS2 and ran into this error on 64bit builds. If Lio says C-style cast is fine then I'm OK with that. I'm 80% sure I've seen this in another project as well and GCC allowed it but your description is better a

Re: [Mingw-w64-public] [PATCH] crt: Build libwinspool.a for arm32 and arm64 as well

2017-08-25 Thread JonY via Mingw-w64-public
On 08/25/2017 11:53 AM, Martin Storsjö wrote: > Use the lib64 version of the def file for this - nothing in the > def file seems like it would be architecture specific. > > CMake has some linking tests where it by default links a number of > "standard libraries", and -lwinspool are among them. Mak

Re: [Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h

2017-08-25 Thread Liu Hao
On 2017/8/25 19:09, Mateusz Mikuła wrote: There was discussion if this should be done via cast or union, both versions were attached at some point of [1] discussion. [1] https://sourceforge.net/p/mingw-w64/mailman/message/35923114/ C-style casts shall suffice. I don't see why we have to introdu

[Mingw-w64-public] [PATCH] crt: Build libwinspool.a for arm32 and arm64 as well

2017-08-25 Thread Martin Storsjö
Use the lib64 version of the def file for this - nothing in the def file seems like it would be architecture specific. CMake has some linking tests where it by default links a number of "standard libraries", and -lwinspool are among them. Make sure this library at least exists, in order not to fai

[Mingw-w64-public] [PATCH] crt: Include _strftime_l in msvcrt.def.in

2017-08-25 Thread Martin Storsjö
This fixes linking of libc++, which uses this function. libc++ needs a msvcrt new enough to provide this function (present since msvcr90 in the numbered msvcrt DLLs). Signed-off-by: Martin Storsjö --- mingw-w64-crt/lib-common/msvcrt.def.in | 1 + 1 file changed, 1 insertion(+) diff --git a/ming

Re: [Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h

2017-08-25 Thread Martin Storsjö
On Fri, 25 Aug 2017, Mateusz Mikuła wrote: There was discussion if this should be done via cast or union, both versions were attached at some point of [1] discussion. [1] https://sourceforge.net/p/mingw-w64/mailman/message/35923114/ Oh, I see - sorry for missing that. I don't mind whichever

Re: [Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h

2017-08-25 Thread Mateusz Mikuła
There was discussion if this should be done via cast or union, both versions were attached at some point of [1] discussion. [1] https://sourceforge.net/p/mingw-w64/mailman/message/35923114/ 2017-08-25 11:12 GMT+02:00 Martin Storsjö : > When building libcxx, a version of wcschr that returns const

Re: [Mingw-w64-public] [PATCH 04/17] headers: Skip the inline interlocked functions for arm64 (as on all other non-i386 archs)

2017-08-25 Thread Martin Storsjö
On Thu, 24 Aug 2017, Zebediah Figura wrote: On 08/19/2017 04:25 PM, Martin Storsjö wrote: These are skipped on x86_64, arm and arm64 - in practice the condition maybe should be inverted to only include i386. Would it be worth adding a configure check for these? I didn't actually investigat

[Mingw-w64-public] [PATCH] headers: Add casts in ua_wcs*chr in stralign.h

2017-08-25 Thread Martin Storsjö
When building libcxx, a version of wcschr that returns const is provided, breaking compilation here since the return from wcschr is returned directly as if it were a const pointer. By adding these casts, compilation succeeds. This matches the calls to uaw_wcschr and uaw_wcsrchr directly below, hav