> I personally like a variant of the Go formatting rules, which are
basically "don't worry about line length".
This sound like good approach for an an auto- formatter.
I think we have two external limits for code length, the historical 80
columns and the 115 columns in GitHub pull requests.
Our
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
https://bugs.launchpad.net/mixxx/+bug/1463677
On Tue, 09 Jun 2015 16:44:19 + "Sean M. Pappalardo - D.J.
Pegasus" wrote:
>On 06/08/2015 09:24 PM, re-cy...@hushmail.com wrote:
>> Is there any framework currently or on the horizon for *any* of
>the
My username being under three characters was the issue. The registration
form was fooled because I put a period after two letters, but when I
logged in it showed the user as "be" without the period at the end. I
reproduced the issue with other usernames with two characters and a
period. I regis
I agree that 80 columns is restrictive with 4-space tabs. I personally
like a variant of the Go formatting rules, which are basically "don't
worry about line length". I aim for 100, but if something is a few
characters over, I let it go long. No one wants to scroll horizontally,
but I also disli
I did do an update to LateNight to add Aux controls and toggleable EQ.
The AUX controls are really needed or else there's no way to use them,
and I think being able to save more vertical space in the mixer is
valuable.
I do appreciate any feedback, especially from users with small screens,
since t
If auto line breaking is done, I could support 120+. The old 80 char limit
doesn't make sense anymore.
On Tue, Jun 9, 2015, 3:03 PM Daniel Schürmann wrote:
> After skimming though the PR, I can see my objections confirmed
> regarding auto formated line breaks.
> On the other hand I see that mos
After skimming though the PR, I can see my objections confirmed
regarding auto formated line breaks.
On the other hand I see that most other issues are handled well.
I think I will support such mass refactoring, if it does not introduce
line breaks.
For my feeling we have no readability issues w
Example:
https://github.com/mixxxdj/mixxx/pull/616
On Tue, Jun 9, 2015 at 4:52 PM, Max Linke wrote:
>
>
> On 06/09/2015 10:08 PM, RJ Ryan wrote:
>
>> I'm for this -- we waste too much time arguing about code style and spend
>> way too much time cleaning up code.
>>
>> We do differ from Google C+
On 06/09/2015 10:08 PM, RJ Ryan wrote:
I'm for this -- we waste too much time arguing about code style and spend
way too much time cleaning up code.
We do differ from Google C++ style in certain ways. I'm for eliminating
most of the differences.
+1
But I also attach the clang-format file I
On Tue, Jun 9, 2015 at 4:43 PM, RJ Ryan wrote:
> I can remember that RJs biggest issue in the clang autotransformer was the
> alignment
> with the open parenthesis. If we set it just to double indent most issues
> should be solved (sove-able)
>
FWIW this was Emacs code formatting, not clang-form
On Tue, Jun 9, 2015 at 4:37 PM, Daniel Schürmann wrote:
>
> Hi
>
> I have very bad experience in a similar size closed source project.
> The code was cluttered and the source control blame feature broken
>
When a line is auto-formatted you can just blame from that revision to find
the real line
Hi
I have very bad experience in a similar size closed source project.
The code was cluttered and the source control blame feature broken
We finally revert all the auto formated stuff.
IMHO a code style checker will help to get around the noise in the PRs.
We can also provide an auto-formater f
On 06/09/2015 01:08 PM, RJ Ryan wrote:
It looks like reformatting the world will change about 32k lines. That's
a small price to pay for never having to worry about this again.
Well shoot, let's do it in master tomorrow. Seriously.
Sincerely,
Sean M. Pappalardo
"D.J. Pegasus"
Mixxx Develope
I'm for this -- we waste too much time arguing about code style and spend
way too much time cleaning up code.
We do differ from Google C++ style in certain ways. I'm for eliminating
most of the differences.
We should do a 1-step reformat-the-world and then distribute a commit hook
to reformat. Th
Is mentioned earlier - I don't want (you) to clutter LateNight with
dozens of configs. I think the proposed one should get another skin.
LateNight as it is now is much more structured and easier to understand
for new users than the suggested approach is - even if it has some
advantages.
Just wante
On 06/08/2015 09:24 PM, re-cy...@hushmail.com wrote:
Is there any framework currently or on the horizon for *any* of the
various scrollbars to be midi-scriptable?
Perhaps with the control system redesign we've been planning for awhile
now. Please file a wishlist bug on this so we can track i
At this point we've reached the end of the road for how flexible
LateNight can be. It's fairly flexible already, and every bit of
flexibility I try to add beyond that is causing ripple effects for other
layouts. So for now, if you want to experiment with other options, I'd
suggest you fork the sk
17 matches
Mail list logo
