Re: [Mixxx-devel] 1.12 release progress

2015-07-23 Thread Owen Williams
Streaming instability: I agree that this is a blocker bug. We have a lot of users that rely on Mixxx for their streaming radio stations and it would be a huge problem if the new version makes their streams unlistenable. This is a bug I think we should focus on. We should either determine that t

Re: [Mixxx-devel] 1.12 release progress

2015-07-23 Thread Owen Williams
Thanks for all the PRs :). I will go through them as soon as I can. On Wed, 2015-07-22 at 17:02 -0400, Owen Williams wrote: > For PRs that people think are ready and would like to merge in, can you > list the actual numbers? Our PR list is very dense and fast-moving. > > I am willing to take

Re: [Mixxx-devel] 1.12 release progress

2015-07-23 Thread Max Linke
On 07/23/2015 01:29 AM, Sébastien Blaisot wrote: > > Le 22/07/2015 23:02, Owen Williams a écrit : >> For PRs that people think are ready and would like to merge in, can you >> list the actual numbers? Our PR list is very dense and fast-moving. >> >> I am willing to take a look at the PRs that ar

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread re-cycle
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 22 Jul 2015 23:49:13 + "Sébastien Blaisot" wrote: >I agree, we should wait post 1.12 release to discuss this. at >first, i >wanted to wait for 1.12 release before talking about that, but >todays >discussion let me at least disappointed.

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Be
PR 638 and PR 657 are ready. On 07/22/2015 05:30 PM, Be wrote: > PR 649 is ready. I'll finish up PR 638 tonight. > > On 07/22/2015 04:02 PM, Owen Williams wrote: >> For PRs that people think are ready and would like to merge in, can you >> list the actual numbers? Our PR list is very dense and fa

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Sébastien Blaisot
Le 22/07/2015 23:02, Owen Williams a écrit : > For PRs that people think are ready and would like to merge in, can you > list the actual numbers? Our PR list is very dense and fast-moving. > > I am willing to take a look at the PRs that are in flight, but I can't > guarantee that I will agree tha

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Sébastien Blaisot
I agree, we should wait post 1.12 release to discuss this. at first, i wanted to wait for 1.12 release before talking about that, but todays discussion let me at least disappointed. for the windows specific issue, absolutely no build env is needed because one PR targets the installer, the othe

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Be
PR 649 is ready. I'll finish up PR 638 tonight. On 07/22/2015 04:02 PM, Owen Williams wrote: > For PRs that people think are ready and would like to merge in, can you > list the actual numbers? Our PR list is very dense and fast-moving. > > I am willing to take a look at the PRs that are in fligh

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Ferran Pujol Camins
Well, you've already reviewed PR #639 , you might want to check one more time. The only issue I see to it is that sometimes the show library option on the view menu does nothing. But, AFAIK, the skin has no way to tell Mixxx when this option should be gray

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Owen Williams
For PRs that people think are ready and would like to merge in, can you list the actual numbers? Our PR list is very dense and fast-moving. I am willing to take a look at the PRs that are in flight, but I can't guarantee that I will agree that everything is low risk or ready to merge. If peopl

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread re-cycle
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 22 Jul 2015 17:28:17 + "Sébastien BLAISOT" wrote: >Hi, > >I strongly disagree with you. We have a wonderfull new feature >with >resizable skins and this new feature is ruined by our windows >installer >because if you install 1.12 on top

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Sean M. Pappalardo - D.J. Pegasus
On 07/22/2015 08:24 AM, RJ Ryan wrote: The manual still needs a fair bit of work -- if a section looks like it was updated for 1.12 then it's probably safe to translate that. RJ, since you have the most knowledge of who worked on what new 1.12 features, can you post such a list here so we ca

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Be
I agree. I think we should discuss these issues in detail after 1.12 is released. For now, let's focus on getting those active PRs merged and the manual. The long review time for Windows-specific issues is a problem. For me, the issue is how much of a hassle it is to compile on Windows. I'd be

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Sébastien BLAISOT
Hi, I strongly disagree with you. We have a wonderfull new feature with resizable skins and this new feature is ruined by our windows installer because if you install 1.12 on top of 1.11, you get the old skins :( Upgrade is not rare. We already discussed about that, I proposed a PR which is wa

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Be
Most of the issues listed by Sebastian and I are low risk and pretty much ready to merge. The points that aren't being addressed yet are the flaky broadcasting connection, Opus crash, and library search bar focus issue. I'd be fine merging the key sorting as is without polishing it for the Lanc

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread RJ Ryan
The manual still needs a fair bit of work -- if a section looks like it was updated for 1.12 then it's probably safe to translate that. On Wed, Jul 22, 2015 at 10:44 AM, Ferran Pujol Camins < ferranpujolcam...@gmail.com> wrote: > Are the manual sources updated? I can translate to Spanish and Cata

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Be
On 07/22/2015 01:28 AM, Daniel Schürmann wrote: > Everyone can already use 1.12 beta. What is the difference to a 1.12 > release? > IMHO it is all the shiny stuff that makes the difference from a project > to a product. > It is marketing, design, manual, advertising texts, screen shots and so on.

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread RJ Ryan
Daniel/RAWRR are right -- the goal posts are moving slightly and we're scope creeping. Active, trivial / low-risk PRs can merge if they are ready but shouldn't be blocking. For me, the final blocker is the manual and website / press material -- which we simply can't launch without. :) Best regar

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Ferran Pujol Camins
Are the manual sources updated? I can translate to Spanish and Catalan but I'd like to wait until I know the sources won't change anymore (or change very slightly). 2015-07-22 16:12 GMT+02:00 RJ Ryan : > Daniel/RAWRR are right -- the goal posts are moving slightly and we're > scope creeping. > >

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread Ferran Pujol Camins
>From my point of view, marketing wise, we could consider 1.12 a modest release. Because despite the huge amount of work there's behind it, every review out there will essentially say "it is great and finally have FX, but the built in FX are weak". So my modest opinion is the same that Daniel. El

Re: [Mixxx-devel] 1.12 release progress

2015-07-22 Thread re-cycle
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Wed, 22 Jul 2015 06:28:38 + "Daniel Schürmann" wrote: >Hi, > >We have to be careful to consider what is a release blocker. >Mixxx 1.12 beta is already so much better than 1.11 that it is not >worth to >block it at all from this point of view.

Re: [Mixxx-devel] 1.12 release progress

2015-07-21 Thread Daniel Schürmann
Hi, We have to be careful to consider what is a release blocker. Mixxx 1.12 beta is already so much better than 1.11 that it is not worth to block it at all from this point of view. Of cause we should try to fix all critical bugs before a release date, but in this stage I consider a release block

Re: [Mixxx-devel] 1.12 release progress

2015-07-21 Thread Be
On 07/22/2015 12:00 AM, Sébastien BLAISOT wrote: > Hi all, > > Some more blockers : > > * (win) installing 1.12 on top of a previous version installation > (lp:1457618) => PR621 is *still* waiting for merge. Please review and > discuss if we move version to beta2 > > * (win) Eject symbol not show

Re: [Mixxx-devel] 1.12 release progress

2015-07-21 Thread Sébastien BLAISOT
Hi all, Some more blockers : * (win) installing 1.12 on top of a previous version installation (lp:1457618) => PR621 is *still* waiting for merge. Please review and discuss if we move version to beta2 * (win) Eject symbol not shown in LateNight skin (lp:1454649) => PR627 is *still* waiting