Re: [Mixxx-devel] AutoDJ Enhancement : Bug #971429

2015-01-03 Thread Daniel Schürmann
Hi DKdennis, Thank you for all the work! I have just tested your branch, and .. it works! I can't see the issue you have described. I have set a breakpoint to slotAddRandomTrack() and it breaks only once. For future review request, you should just do a GitHub Pull request and add a comment

[Mixxx-devel] Would you prefer Doxygen or QDoc?

2015-01-03 Thread Ferran Pujol Camins
I'm missing code documentation for Mixxx. I understand that flooding source or header files with formatted comments will annoy almost everyone, so I've quickly set-up doxygen to read the source code as-is and then also read special *.doxydoc files placed away from the source code in a separate

Re: [Mixxx-devel] Would you prefer Doxygen or QDoc?

2015-01-03 Thread Daniel Schürmann
Hi Ferran, we have discussed the doxygen topic some time ago. https://www.mail-archive.com/mixxx-devel@lists.sourceforge.net/msg03894.html There was also a Doxygen docu online, provided from a contributor. Time has passed and probably the view on this has changed in the team. So we may discuss

Re: [Mixxx-devel] Would you prefer Doxygen or QDoc?

2015-01-03 Thread RJ Ryan
I've never used Doxygen in the way you mention where we have separate documentation files but that sounds like a recipe for code going out of date with the documentation. The comments should definitely be in-line with the code. As Daniel mentions, we aren't providing an API to others so we don't

Re: [Mixxx-devel] Would you prefer Doxygen or QDoc?

2015-01-03 Thread Ferran Pujol Camins
Personally I also prefer to have documentation comments in the code files themselves but I wanted to remember there are alternatives, just in case that was what pulled Mixxx's documentation back. I've also agree that there's no point in providing a doxygen generated documentation that just comes

Re: [Mixxx-devel] Would you prefer Doxygen or QDoc?

2015-01-03 Thread Ferran Pujol Camins
Sorry, ignore previous incomplete mail: 2015-01-03 21:44 GMT+01:00 Ferran Pujol Camins ferranpujolcam...@gmail.com : Personally I also prefer to have documentation comments in the code files themselves but I wanted to remember there are alternatives, just in case that was what pulled Mixxx's

Re: [Mixxx-devel] Would you prefer Doxygen or QDoc?

2015-01-03 Thread Ferran Pujol Camins
I hate gmail, sorry: Personally I also prefer to have documentation comments in the code files themselves but I wanted to remember there are alternatives, just in case that was what pulled Mixxx's documentation back. I've also agree that there's no point in providing a doxygen generated