From: Jacopo Mondi
Unless there is a good reason to do so, naming variable with double
underscore is generally not a good idea.
Rename the (mostly unused) __fh argument to ioctl handlers to fh.
Signed-off-by: Jacopo Mondi
Signed-off-by: Laurent Pinchart
---
drivers/media/pci/zoran
to a void
pointer, without being every accessed. Drop it.
Fixes: 83f89a8bcbc3 ("media: zoran: convert to vb2")
Signed-off-by: Jacopo Mondi
Signed-off-by: Laurent Pinchart
---
drivers/media/pci/zoran/zoran.h| 6 --
drivers/media/pci/zoran/zoran_driver.c | 3 +--
2 files change
From: Jacopo Mondi
Unless there is a good reason to do so, naming variable with double
underscore is generally not a good idea.
Rename the (mostly unused) __fh argument to ioctl handlers to fh.
Signed-off-by: Jacopo Mondi
Signed-off-by: Laurent Pinchart
---
drivers/media/pci/zoran
to a void
pointer, without being every accessed. Drop it.
Fixes: 83f89a8bcbc3 ("media: zoran: convert to vb2")
Signed-off-by: Jacopo Mondi
Signed-off-by: Laurent Pinchart
---
drivers/media/pci/zoran/zoran.h| 6 --
drivers/media/pci/zoran/zoran_driver.c | 3 +--
2 files change
From: Laurent Pinchart
Hello,
This patch series refactors v4l2_fh support to make the API easier to
use, simplify drivers, and overall improve consistency through the whole
subsystem.
In V4L2, drivers that need to store per file handle data allocate their
per file handle data structure in the
le
media: st: delta: Access v4l2_fh from file
media: stm32: dma2d: Access v4l2_fh from file
media: omap3isp: Access v4l2_fh from file
media: cx18: Access v4l2_fh from file
media: ivtv: Access v4l2_fh from file
media: usb: hdpvr: Access v4l2_fh from file
media: usb: uvc: Access v4l2_fh
On Wed, Aug 06, 2025 at 02:45:14PM +0200, Hans Verkuil wrote:
> On 02/08/2025 11:22, Jacopo Mondi wrote:
> > From: Laurent Pinchart
> >
> > Multiple drivers that use v4l2_fh and call v4l2_fh_del() manually reset
> > the file->private_data pointer to NULL in their vi
struct v4l2_format *fmt)
> > {
> > struct zoran *zr = video_drvdata(file);
> > - struct zoran_fh *fh = __fh;
> > int i;
> > int res = 0;
> >
> > if (fmt->fmt.pix.pixelformat == V4L2_PIX_FMT_MJPEG)
> > -
Hi Hans,
On Wed, Aug 06, 2025 at 10:16:37AM +0200, Hans Verkuil wrote:
> On 02/08/2025 11:22, Jacopo Mondi wrote:
> > From: Laurent Pinchart
> >
> > Accessing file->private_data manually to retrieve the v4l2_fh pointer is
> > error-prone, as the field is
Hi Hans,
On Thu, Aug 07, 2025 at 09:58:34AM +0200, Hans Verkuil wrote:
> On 07/08/2025 09:26, Hans Verkuil wrote:
> > On 02/08/2025 11:23, Jacopo Mondi wrote:
> >> From: Laurent Pinchart
> >>
> >> Now that all drivers access the v4l2_fh from the file structu
Hi Sakari,
On Thu, Aug 07, 2025 at 09:07:13AM +, Sakari Ailus wrote:
> On Sat, Aug 02, 2025 at 11:23:26AM +0200, Jacopo Mondi wrote:
> > From: Laurent Pinchart
> >
> > The V4L2_FL_USES_V4L2_FH flag is set by v4l2_fh_init(). It is not meant
> > to be set manually b
On Thu, Aug 07, 2025 at 10:51:27PM +0200, Hans Verkuil wrote:
> On 07/08/2025 22:25, Laurent Pinchart wrote:
> > On Thu, Aug 07, 2025 at 08:00:06PM +0300, Laurent Pinchart wrote:
> >> On Thu, Aug 07, 2025 at 11:50:07AM +0300, Laurent Pinchart wrote:
> >>> On Wed, Au
On Thu, Aug 07, 2025 at 11:50:07AM +0300, Laurent Pinchart wrote:
> On Wed, Aug 06, 2025 at 02:45:14PM +0200, Hans Verkuil wrote:
> > On 02/08/2025 11:22, Jacopo Mondi wrote:
> > > From: Laurent Pinchart
> > >
> > > Multiple drivers that use v4l2_fh a
On Thu, Aug 07, 2025 at 08:00:06PM +0300, Laurent Pinchart wrote:
> On Thu, Aug 07, 2025 at 11:50:07AM +0300, Laurent Pinchart wrote:
> > On Wed, Aug 06, 2025 at 02:45:14PM +0200, Hans Verkuil wrote:
> > > On 02/08/2025 11:22, Jacopo Mondi wrote:
> > &g
On Thu, Aug 07, 2025 at 10:55:59PM +0200, Hans Verkuil wrote:
> On 07/08/2025 22:33, Laurent Pinchart wrote:
> > On Thu, Aug 07, 2025 at 09:58:34AM +0200, Hans Verkuil wrote:
> >> On 07/08/2025 09:26, Hans Verkuil wrote:
> >>> On 02/08/2025 11:23, Jacopo Mondi wrote:
to assume to be the maintainer if needed.
That would be great ! I used to own a DC10 a long time ago, and the
zoran driver was the first one I tried to hack when I moved to Linux.
I'd love to see it getting maintained. Please let us know if you need
any help getting st
ng for an event (waitqueue) with a timeout.
Laurent Pinchart
pgp0TzgKZjy6z.pgp
Description: signature
tile custom logic (I thought all the FPGAs where
volatile), and could be used as a base PCI interface to let the driver upload
the firmware to the other FPGA. If this is the case, we are probably screwed.
Laurent Pinchart
---
This SF.net email
Forgot to add that the output of lspci -v might help to identify the chip.
Laurent Pinchart
---
This SF.net email is sponsored by: IBM Linux Tutorials.
Become an expert in LINUX or just sharpen your skills. Sign up for IBM's
Free
so it
might be easy to write one (or adapt the existing one) for the 7187.
> and one beneath the coolblock, which I couldn't identify ...
That will probably be the PCI interface. We need to know what chip it is. Can
you remove the coolblock with
at. For more information about the
different YUV formats, have a look at http://www.fourcc.org.
Laurent Pinchart
---
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive? Does it
help you c
> No, RedHat uses the default devfs names. However, due to devfs horror
> (that's a pleonasm), /dev/video/ contains other non-v4l video entries,
> such as the dxr3 (em8300)
Ouch.
> Fortunately, devfs is now marked obsolete.
What will it be replaced by ? Last time I checked sysfs, I didn't find a
video).
If so, you can tell lavrec where your video device is by setting
LAV_VIDEO_DEV:
export LAV_VIDEO_DEV=/dev/video/video0
lavrec [options]
Laurent Pinchart
---
This SF.net email is sponsored by: SF.net Giveback Program.
Does Source
(but not impossible I suppose) for that to be the problem. As an
> experiment you might try y4mscaler and see if the symptoms are
> different - if it does fail it might do so in a different way that
> would shed some light on what's going wrong.
I'll tr
> My superquick $.02 here:
>
> I bet some errant printf() in mplayer is writing UI crap to stdout instead
> of stderr
MPlayer outputs to a file or a named pipe, not to stdout.
Laurent Pinchart
---
This SF.net email is
> If you really do have a progressive stream it's valid. Otherwise
> the interlace tag 'Ip' is wrong. It should be either It (top
> field first) or 'Ib' (bottom field first). Most DVDs that I
> have looked at are 'It' while DV (from a analog->DV capture) is
> alway
Hi,
Could anyone tell me how yuvscaler handles interlaced material ? Does it
deinterlace it before applying the scaling ? If so, is there a way to turn
that off for progressive input ? And if not, doesn't it have an impact on
quality ?
Laurent Pin
w if anyone has ever
profiled mpeg2enc to find where the performance bottleneck is. I don't expect
mpeg2enc to give me real-time encoding performances (quality comes at a
cost), but 3fps seems very low compared to 25fps.
Laurent Pinchart
-
CVS sometimes to see if that was fixed. If not, it should be pretty
straightforward.
Laurent Pinchart
---
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive? Does it
help you cre
trying with -x mpeg2,null (or even with no -x at
all), which was why I had problems.
Laurent Pinchart
---
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productive? Does it
help you create better
ber 12
INFO: [yuvscaler] Frame number 13
INFO: [yuvscaler] Frame number 14
INFO: [yuvscaler] Couldn't read FRAME header: bad header magic!
**ERROR: [yuvscaler] Couldn't read frame number 15!
Laurent Pinchart
---
This SF.n
ns about not being able to open VIDEO_TS.IFO. If I copy VTS_03_0.IFO
to VIDEO_TS.IFO, MPlayer segfaults.
Are you sure that the -dvd-device option can be used to read from a DVD dump ?
From the man page it seems that it is used to specify the DVD devi
> > What is the best way to convert the DVD dump ? I can use tccat | mplayer
> > | yuvscaler | mpeg2enc, but using programs from 3 different projects
> > (transcode, mplayer and mjpegtools) seems a bit complicated to do the
> > simple operation I'm trying to achieve.
> >
> > Any help will be greatl
ls) seems a bit complicated to do the simple
operation I'm trying to achieve.
Any help will be greatly appreciated.
Laurent Pinchart
---
This SF.net email is sponsored by: SF.net Giveback Program.
Does SourceForge.net help you be more productiv
nk it may be an task of the authoring program
> to insert subs, isn't it?
I'll have a look at dvdauthor too. I just found out that it includes a program
called submux that creates DVD, CVD and SVCD streams from a '.sub' file, and
multiplexes them with an m
nd CC, are there other ones ?), so any information is
welcome.
Any help with the mplex code will also be very appreciated.
Laurent Pinchart
---
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open
be nice to use them, as moving the
subtitles off the picture will improve compression, and will allow the user
(me :-) to switch them off.
Any help would be appreciated.
Laurent Pinchart
---
This sf.net email is sponsored by:ThinkGeek
Welco
rocfs.c:34:
> /usr/src/linux-2.4.21-0.13mdk/include/linux/module.h:300:
> parse error before "UTS_RELEASE"
[...]
It looks like you haven't configured your kernel tree (make config or make
menuconfig). You should also ru
> Redhat 9.0 can be made to work with a DC10+ out of the box. After having
> problems compiling the zoran drivers I found that kudzu will find the
> DC10+ and then you can modprobe the right modules. I managed to get it to
> capture perfectly. Though thinking about it it wasn;t quite out of the box
d share his/her experience with me.
2) I get very similar results using libjpeg-mmx and libjpeg on a P3-800 (both
optimized for i686). Is this normal ? I would have expected libjpeg-mmx to be
faster.
Thanks for your help.
Laurent Pinchart
efined thing), I'll use __FUNCTION__ instead - that always works.
Here's a patch which uses __func__ along with %s in the printk's. The debug
output in vpx3220.c should probably be rewritten, but as I'm not sure yet
which of vpx3220.c and vpx32xx.c will be kept, I won'
FUNCTION__ the same way as __func__. __func__ is defined by th!
e ISO
standard C99.\"I thus suggest that we change printk(KERN_INFO \"%s: \" __func__ \" - blabla \", zr->name);toprintk(KERN_INFO \"%s: %s - blabla \", zr->name, __func__ );which would work for b
o help out (i.e. develop) with getting the JPEG recording
> running (the code is basically there, something is just wrong in the
> JPEG codec or VFE settings or so - we don't receive interrupts), please
> consider yourself invited! If you plan to just wait, I'd advise to
> subscr
g2enc actually uses MMX, but configures reports that MMX is enabled and
HAVE_ASM_MMX is set to 1 in config.h).
Laurent Pinchart
---
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
___
n "${1%.avi}.mp2"
mplex -f 4 dogma.mp2 dogma.m2v -o "${1%.avi}%02d.mpg"
Does anyone have any idea about what went wrong with the encoding process ?
Thanks for your help.
Laurent Pinchart
---
This sf.net email is sp
d with the meaning of the
binary prefixes. Most of (*most of*, not *all*) the time the decimal prefix
is a binary prefix in the context of memory (RAM, HD, ...), and a true
decimal prefix in the context of bandwidth.
It would be nice to make use of the binary prefixes in the mjpegtools...
L
. Using -f 5 -b 2500 gives me exactly the same results as -f
4.
Could anyone help me ?
Thanks in advance.
Laurent Pinchart
---
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility
Learn to use your power at OSD
(about 1.5fps on a P3 933MHz).
Could someone tell me if I'm doing something wrong ? Or if there's another way
to achieve my goal ?
Thanks in advance for your help.
Laurent Pinchart
---
This sf.net email is sponsored by:
Wi
48 matches
Mail list logo
