Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Bernhard Praschinger
Hallo Christian Ebert wrote: > * Trent Piepho on Friday, October 15, 2010 at 11:33:01 -0700 >> On Fri, Oct 15, 2010 at 10:58 AM, Christian Ebertwrote: >>> Index: yuvdenoise/main.c >>> === >>> RCS file: /cvsroot/mjpeg/mjpeg_play/yuvden

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Trent Piepho on Friday, October 15, 2010 at 11:33:01 -0700 > On Fri, Oct 15, 2010 at 10:58 AM, Christian Ebert wrote: >> Index: yuvdenoise/main.c >> === >> RCS file: /cvsroot/mjpeg/mjpeg_play/yuvdenoise/main.c,v >> retrieving revisio

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Trent Piepho
On Fri, Oct 15, 2010 at 10:58 AM, Christian Ebert wrote: > No! Trent nudged me in the right direction I believe. By applying > the same fix to the other asm volatile line I was able to build > it here as well. This change makes it build, but of course I've > no idea what I was doing: > > Index: yu

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Christian Ebert on Friday, October 15, 2010 at 19:49:02 +0200 > With this change, yuvdenoise builds again, but someone in the > know should check whether I've broken other stuff: And I did break it, but this seems to work: Index: yuvdenoise/main.c ===

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Christian Ebert on Friday, October 15, 2010 at 19:58:28 +0200 > * Bernhard Praschinger on Friday, October 15, 2010 at 19:17:13 +0200 >> I have at home a OSX 10.4.11 (PowerPC) and 10.6.4 (Intel) with gcc 4.2.1 >> and it compiles without problems on both computers. >> >> I did a "make clean" in t

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Bernhard Praschinger on Friday, October 15, 2010 at 19:17:13 +0200 >>> I tested your better version. And it compiles here on my linux and Intel >>> osx box. I did also a quick test with the new version on the linux box. >>> And it works well. >>> >>> So I would appreciate a feedback if it works

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Trent Piepho on Friday, October 15, 2010 at 10:19:20 -0700 > On Fri, Oct 15, 2010 at 12:40 AM, Christian Ebert wrote: > >> * Trent Piepho on Thursday, October 14, 2010 at 17:38:39 -0700 >>> Looks like you didn't actually change the needed lines. >> >> No, I didn't but Bernhard did: >> + >> #if

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Trent Piepho
On Fri, Oct 15, 2010 at 12:40 AM, Christian Ebert wrote: > * Trent Piepho on Thursday, October 14, 2010 at 17:38:39 -0700 > > On Thu, Oct 14, 2010 at 2:43 PM, Christian Ebert > wrote: > > Easy fix would just be the change the sse detection asm to save and > restore ebx. > > >>

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Bernhard Praschinger
Hallo >> I tested your better version. And it compiles here on my linux and Intel >> osx box. I did also a quick test with the new version on the linux box. >> And it works well. >> >> So I would appreciate a feedback if it works on a mac. > > Thanks for looking into this, but I get: > > gcc -DHA

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-15 Thread Christian Ebert
* Trent Piepho on Thursday, October 14, 2010 at 17:38:39 -0700 > On Thu, Oct 14, 2010 at 2:43 PM, Christian Ebert wrote: > >> * Bernhard Praschinger on Thursday, October 14, 2010 at 19:06:33 +0200 Oh yeah, this isn't on Linux. OSX probably has some kind of API for checking if sse2 is a

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-14 Thread Trent Piepho
On Thu, Oct 14, 2010 at 2:43 PM, Christian Ebert wrote: > * Bernhard Praschinger on Thursday, October 14, 2010 at 19:06:33 +0200 > >> Oh yeah, this isn't on Linux. OSX probably has some kind of API for > >> checking if sse2 is available. Using CPUID isn't enough, because sse > >> requires OS su

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-14 Thread Christian Ebert
* Christian Ebert on Thursday, October 14, 2010 at 23:43:20 +0200 > * Bernhard Praschinger on Thursday, October 14, 2010 at 19:06:33 +0200 >>> Oh yeah, this isn't on Linux. OSX probably has some kind of API for >>> checking if sse2 is available. Using CPUID isn't enough, because sse >>> requires

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-14 Thread Christian Ebert
* Bernhard Praschinger on Thursday, October 14, 2010 at 19:06:33 +0200 >> Oh yeah, this isn't on Linux. OSX probably has some kind of API for >> checking if sse2 is available. Using CPUID isn't enough, because sse >> requires OS support that might not be there. I.e., the cpu supports >> sse2 but

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-14 Thread Bernhard Praschinger
Hallo > Oh yeah, this isn't on Linux. OSX probably has some kind of API for > checking if sse2 is available. Using CPUID isn't enough, because sse > requires OS support that might not be there. I.e., the cpu supports > sse2 but you're not actually able to use it. Probably not much of issue > o

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-13 Thread Trent Piepho
On Wed, Oct 13, 2010 at 12:11 AM, Christian Ebert wrote: > * Trent Piepho on Tuesday, October 12, 2010 at 12:06:45 -0700 > > It looks like the only use of ebx is in the code to detect CPU features > > using cpuid. A better way to do it would be to read the /proc/cpuinfo > file > > and look for th

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-13 Thread Christian Ebert
* sfrase6 on Tuesday, October 12, 2010 at 18:06:17 + >> gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../utils -O3 -funroll-all-loops >> -ffast-math -march=nocona -mtune=nocona -g -O2 -I/sw/include -no-cpp-precomp >> -D_THREAD_SAFE -Wall -Wunused -MT main.o -MD -MP -MF .deps/main.Tpo -c -o >> main.

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-13 Thread Christian Ebert
* Trent Piepho on Tuesday, October 12, 2010 at 12:06:45 -0700 > It looks like the only use of ebx is in the code to detect CPU features > using cpuid. A better way to do it would be to read the /proc/cpuinfo file > and look for the sse2 or whatever flag. There is no /proc/ directory on MacOS X.

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-12 Thread Trent Piepho
hristian Ebert" > To: mjpeg-users@lists.sourceforge.net > Sent: Tuesday, October 12, 2010 6:17:56 AM > Subject: Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch > > > gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../utils -O3 -funroll-all-loops > -ffast-math

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-12 Thread sfrase6
- Original Message - From: "Christian Ebert" To: mjpeg-users@lists.sourceforge.net Sent: Tuesday, October 12, 2010 6:17:56 AM Subject: Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch > gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../utils -O3 -funroll-all-loops

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-12 Thread Christian Ebert
* Christian Ebert on Sunday, October 10, 2010 at 14:51:22 +0100 > * Bernhard Praschinger on Sunday, October 10, 2010 at 15:14:35 +0200 >> I have tested your patch and sent it to CVS. So it will appear in the >> next version. > > However, it breaks building on MacOS 10.5.8: > > gcc -DHAVE_CONFIG_

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-10 Thread Christian Ebert
* Bernhard Praschinger on Sunday, October 10, 2010 at 15:14:35 +0200 > I have tested your patch and sent it to CVS. So it will appear in the > next version. However, it breaks building on MacOS 10.5.8: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../utils -O3 -funroll-all-loops -ffast-math -march=noco

Re: [Mjpeg-users] [Mjpeg-developer] yuvdenoise performance patch

2010-10-10 Thread Bernhard Praschinger
Hallo > On Sat, 02 Oct 2010 07:12:39 +0200 Bernhard Praschinger >> There are still people that monitor the list :) >> My main problem is finding time to answer mails and do tests. > I see, same here. I didn't know whether the project was still alive, > since there's quite little traffic on this li