Re: [PATCH] iface-modem-time: don't hold a ref while waiting to be registered

On Tue, 2018-05-15 at 11:27 +0200, Aleksander Morgado wrote: > The logic implementing the network timezone loading was holding a > strong reference to the modem (inside the GTask) while waiting to > be registered. > > This was triggering some possible memory leaks as the modem object > could have

Re: [PATCH] include: add more 3GPP errors

On Tue, 2018-05-22 at 19:26 +0200, Aleksander Morgado wrote: > On Tue, May 22, 2018 at 7:05 PM, Dan Williams <d...@redhat.com> > wrote: > > From 3GPP TS 27.007 version 11.6.0 Release 11, sections 9.2.1, > > 9.2.2.1, 9.2.2.2, and 9.2.2.3. > > --- > > NOTE: if

Re: [PATCH] filter: pci and sdio ports under the platform driver filter

On Wed, 2018-05-23 at 08:51 +0200, Aleksander Morgado wrote: > On Tue, May 22, 2018 at 11:22 PM, Dan Williams <d...@redhat.com> > wrote: > > On Tue, 2018-05-22 at 11:39 -0500, Dan Williams wrote: > > > On Tue, 2018-05-22 at 17:40 +0200, Aleksander Morgado wrote: > &

Re: [PATCH] filter: pci and sdio ports under the platform driver filter

On Tue, 2018-05-22 at 11:39 -0500, Dan Williams wrote: > On Tue, 2018-05-22 at 17:40 +0200, Aleksander Morgado wrote: > > On Tue, May 22, 2018 at 3:49 PM, Dan Williams <d...@redhat.com> > > wrote: > > > On Tue, 2018-05-22 at 12:31 +0200, Aleksander Morgado wrote: >

[PATCH] include: add more 3GPP errors

From 3GPP TS 27.007 version 11.6.0 Release 11, sections 9.2.1, 9.2.2.1, 9.2.2.2, and 9.2.2.3. --- NOTE: if this looks OK I'll push a follow-up to fix the spacing. include/ModemManager-errors.h | 50 +++ 1 file changed, 50 insertions(+) diff --git

Re: [PATCH] iface-modem-3gpp: ignore initial registration check result when enabling

> where a registration check update may prematurely transition the > > modem > > to the 'enabled' state while the modem is still being enabled. > > > > The issue is identified by Dan Williams <d...@redhat.com>. More > > details > > can be found in https://

Re: [PATCH] filter: pci and sdio ports under the platform driver filter

On Tue, 2018-05-22 at 17:40 +0200, Aleksander Morgado wrote: > On Tue, May 22, 2018 at 3:49 PM, Dan Williams <d...@redhat.com> > wrote: > > On Tue, 2018-05-22 at 12:31 +0200, Aleksander Morgado wrote: > > > Do not automatically probe serial ports under the 'pci' or 's

Re: [PATCH] filter: pci and sdio ports under the platform driver filter

On Tue, 2018-05-22 at 12:31 +0200, Aleksander Morgado wrote: > Do not automatically probe serial ports under the 'pci' or 'sdio' > platform drivers unless explicitly tagged with > ID_MM_PLATFORM_DRIVER_PROBE. Hmm, now I have to dig out my Nozomi card to make sure we don't break that one... It's

Re: u-blox TOBY-R200 Intermittent Long Registration on Simple Connect

On Mon, 2018-04-30 at 20:09 +, Matthew Starr wrote: > > -Original Message- > > From: Aleksander Morgado [mailto:aleksan...@aleksander.es] > > > > > > > > I don't understand why there is a 20 second timeout. Couldn't > > > you just test > > > > the AT interface right away with 'AT'

Re: [PATCH] broadband-bearer: allow matching empty APN when looking for PDP CID

On Sat, 2018-04-28 at 10:38 +0200, Aleksander Morgado wrote: > The PDP contexts that are found with an empty APN configured are > right > now used as placeholders that can be overwritten with the user > provided APN if no direct match is found. > > We want to keep that logic in place, but for the

Re: Try to detect broken AT-control based modems

On Mon, 2018-04-30 at 13:11 +0200, Aleksander Morgado wrote: > A short series of patches to improve the detection of broken modems. > In this case, we try to detect modems that are still exposed in the > USB layer but which don't reply to any of our AT commands. > > The first patch is a small

Re: Old ZTE and Huawei devices forbidden in strict filter

On Fri, 2018-04-27 at 12:13 +0200, Aleksander Morgado wrote: > Hey, > > Distributions have started to ship 1.8 RC1 and RC2 versions, and we > already have some reports about the strict filter not picking up some > ZTE and Huawei devices: > > https://bugs.freedesktop.org/show_bug.cgi?id=106234 >

Re: Old ZTE and Huawei devices forbidden in strict filter

On Fri, 2018-04-27 at 12:10 -0500, Dan Williams wrote: > On Fri, 2018-04-27 at 12:13 +0200, Aleksander Morgado wrote: > > Hey, > > > > Distributions have started to ship 1.8 RC1 and RC2 versions, and we > > already have some reports about the strict filter not

Re: [PATCH 1/2] modem: allow periodic signal check to be disabled

On Mon, 2018-04-23 at 16:24 -0700, Ben Chan wrote: > ModemManager decides to disable periodic signal check if either > load_signal_quality is not implemented or load_signal_quality returns > an > unsupported error. However, in some cases, we want to use > load_signal_quality to query the initial

Re: [PATCH] build: allow configuring filter policy to be used in the init files

On Wed, 2018-04-11 at 10:15 +0200, Aleksander Morgado wrote: > On Wed, Apr 11, 2018 at 4:10 AM, Dan Williams <d...@redhat.com> > wrote: > > On Tue, 2018-04-10 at 15:08 +0200, Aleksander Morgado wrote: > > > Distributions wanting to use a different filter policy than

Re: [PATCH] u-blox: ignore non-AT ttyACM interfaces

On Wed, 2018-04-11 at 13:27 +, Matthew Starr wrote: > > -Original Message- > > From: Reinhard Speyerer [mailto:rs...@arcor.de] > > Sent: Tuesday, April 10, 2018 4:23 PM > > To: Matthew Starr > > Cc: Dan Williams; modemmanager-devel@lists.freedesktop.org &

Re: [PATCH] build: allow configuring filter policy to be used in the init files

On Tue, 2018-04-10 at 15:08 +0200, Aleksander Morgado wrote: > Distributions wanting to use a different filter policy than the > DEFAULT one were advised to patch themselves the corresponding init > files. > > We now allow doing this directly at configure time by using a new >

Re: [PATCH] u-blox: ignore non-AT ttyACM interfaces

On Tue, 2018-04-10 at 19:58 +, Matthew Starr wrote: > > -Original Message- > > From: Dan Williams [mailto:d...@redhat.com] > > Sent: Tuesday, April 10, 2018 1:17 PM > > To: Matthew Starr; modemmanager-devel@lists.freedesktop.org > > Subject: Re: [PATCH

Re: [PATCH] u-blox: ignore non-AT ttyACM interfaces

On Tue, 2018-04-10 at 17:30 +, Matthew Starr wrote: > For the TOBY-R2, LISA-R2, and LARA-R2, the only valid AT ports are > ttyACM0, ttyACM1, and ttyACM2. All other ttyACM ports cause MM to > wait 20-30 seconds probing the port on startup. > > Ignoring the non-AT ttyACM ports allows MM to not

Re: u-blox TOBY-R200 Intermittent Long Registration on Simple Connect

On Thu, 2018-04-05 at 18:32 +, Matthew Starr wrote: > > -Original Message- > > From: Dan Williams [mailto:d...@redhat.com] > > Sent: Thursday, April 05, 2018 1:22 PM > > To: Matthew Starr; modemmanager-devel@lists.freedesktop.org > > Subject: Re: u-bl

Re: u-blox TOBY-R200 Intermittent Long Registration on Simple Connect

On Tue, 2018-04-03 at 21:19 +, Matthew Starr wrote: > I have a u-blox TOBY-R200 running on an embedded Linux device with > the ModemManager 1.8-rc2 build, plus the patch for "ublox: fix 'any' > mode building". On this device there seems to be an issue between > the automatic registration of

Re: [PATCH] ublox: fix 'any' mode building

On Tue, 2018-04-03 at 00:37 +0200, Aleksander Morgado wrote: > The 'any' mode refers to the mode which includes most access > technologies and where none of them is preferred. > > Fix the logic so that all combinations with one technology preferred > over the others are ignored, instead of the

Re: Huawei ME909s-120 registration denied

On Tue, 2018-03-27 at 14:28 +0100, Hugh Warrington wrote: > On 16 March 2018 at 22:51, Dan Williams <d...@redhat.com> wrote: > > > On Wed, 2018-03-14 at 16:41 +, Hugh Warrington wrote: > > > 1. Is registration denied a recoverable error -- and if so

Re: Huawei ME909s-120 registration denied

On Wed, 2018-03-14 at 16:41 +, Hugh Warrington wrote: > Hello! > > I am using network-manager 1.2.6-0ubuntu0.16.04.2, > modemmanager 1.6.4-1ubuntu0.16.04.1 with a Huawei ME909s-120, > firmware 11.617.01.00.00. > > We're using a SIM card from EE M2M here in the UK. > > Intermittently when I

Re: [PATCH] iface-modem: allow power off from any state

On Fri, 2018-03-09 at 18:45 +0100, Aleksander Morgado wrote: > We shouldn't be limiting the power off state from a non-enabled one > only, in the same way we always allow doing a reset from any state. LGTM > --- > src/mm-iface-modem.c | 53 +- > --

Re: Both QMI and MM are not able to create connection

On Wed, 2018-03-14 at 15:12 +0530, Subramonia Pillai wrote: > Hi, > > Sorry for sharing all the details including syslogs. I am not getting > any > clue, where I am making mistake. Could anyone please point me, thanks > a > lot. Subbu > > > 1. Antenna Signal Quality is giving an error (could

Re: Getting MC7455 static-ip to work

On Mon, 2018-03-05 at 17:56 +0100, Aleksander Morgado wrote: > > > > > > Was the wwan0 interface down while you executed simple-connect? > > > > wwan0 being up is the most likely cause. But seeing the debug logs > > to > > confirm this would be good. > > > > I started thinking about solving

Re: [PATCH] mm-base-manager: ref MMDevice before releasing port

On Wed, 2018-02-21 at 13:49 -0800, Eric Caruso wrote: > Releasing the port on the device looks benign but because it emits > a signal, it could call device_context_port_released and unref the > MMDevice in port_context_unref. This means the MMDevice might be > disposed before we get to the

Re: [PATCH] Update EPS registration state for LTE qmi modems

On Tue, 2018-02-13 at 10:38 +0100, Alfonso Sánchez-Beato wrote: > MM was not updating the EPS registration status for qmi modems. This > led to LTE-only modems never having 'registered' status. This was > happening for Quectel EC21-V modem. Pushed to git master and mm-1-6, thanks! Dan > --- >

Re: Quectel EC21-V modem not showing the right registering state

On Mon, 2018-02-12 at 17:07 +0100, Alfonso Sanchez-Beato wrote: > Hi, > > I found that a Quectel EC21-V modem was not showing the right state. > This is an LTE-only modem, so the only supported network is EPS, but > mm-broadband-modem-qmi.c was never calling >

Re: Re[4]: GPS problem with mmcli

On Tue, 2018-02-06 at 17:36 +0100, Mbortolazzo wrote: > Thanks for the information. > > > > > This is usb-device of Huawei ME906S: Ok, so this one is in AT + ether mode. Which means it may have GPS NMEA on one of the option-driven ports, but we don't know which one. To find out we need the

Re: Re[2]: GPS problem with mmcli

> > - Messaggio Originale - > > Da: "Aleksander Morgado" <aleksan...@aleksander.es> > > A: "Dan Williams" <d...@redhat.com> > > Cc: "ModemManager (development)" <modemmanager-devel@lists.freedesk > > top.o

Re: Using u-blox TOBY-R200, ModemManager not detecting already registered with network

Try this patch instead... Dan --- src/mm-iface-modem-3gpp.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/mm-iface-modem-3gpp.c b/src/mm-iface-modem-3gpp.c index baf743fb..77b502c0 100644 --- a/src/mm-iface-modem-3gpp.c +++

Re: Using u-blox TOBY-R200, ModemManager not detecting already registered with network

On Mon, 2018-02-05 at 17:47 +, Matthew Starr wrote: > > On Mon, 2018-02-05 at 15:45 +, Matthew Starr wrote: > > > > On Thu, 2018-02-01 at 22:09 +, Matthew Starr wrote: > > > > > I am using a TOBY-R200 which does not support USB Ethernet > > > > > like > > > > > TOBY- > > > > > L2

Re: [PATCH] API: don't depend on GLib in ModemManager headers

On Mon, 2018-02-05 at 09:53 +0100, Aleksander Morgado wrote: > We should only depend on GLib on the libmm-glib headers. Otherwise, > packages using just the core headers (e.g. ModemManagerQt) would also > need to build-depend on GLib and we don't want to enforce that. > > cd

Re: Novatel USB551L Verizon lte

On Fri, 2018-02-02 at 09:33 -0600, John Chiasson wrote: > Hi, > > I'm having little success with this modem under ubuntu 17.10 x64. I > did manage to get it to connect once while running both managers in > foreground debug mode, but am unable to connect running as services. > Debug logs are

Re: [PATCH 1/3] bearer-mbim: remove a unnecessary MbimMessage variable

On Wed, 2018-01-31 at 21:57 -0800, Ben Chan wrote: > --- > src/mm-bearer-mbim.c | 1 - > 1 file changed, 1 deletion(-) All three pushed to git master and mm-1-6. The backport to 1.6 required undoing the GTask stuff, so maybe take a quick look and see if it all looks OK to you? Thanks! Dan >

Re: GPS problem with mmcli

On Thu, 2018-02-01 at 14:39 +0100, Mbortolazzo wrote: > I have a problem with mmcli to control GPS nmea on two different > Modem: Sierra EM7455 and Huawei ME906S. GPS functionality is highly dependent on the modem model and firmware and what mode the modem is in (eg MBIM, AT+ether, QMI, etc).

Re: Using u-blox TOBY-R200, ModemManager not detecting already registered with network

On Thu, 2018-02-01 at 22:09 +, Matthew Starr wrote: > I am using a TOBY-R200 which does not support USB Ethernet like TOBY- > L2 models, but only supports AT interface over USB serial. When I > use a NetworkManager profile to start a 3G/4G connection using > ModemManager with the TOBY-R200,

Re: [PATCH] filter: cdc-acm protocols 1 through 6 are all AT-capable

On Thu, 2018-01-18 at 16:33 +0100, Aleksander Morgado wrote: > As per USB-IF "Class definitions for Communication Devices 1.2" docs. LGTM. Dan > Reported-by: Iván Sánchez Ortega > --- > src/mm-filter.c | 20 ++-- > 1 file changed, 18 insertions(+), 2

Re: UE mode of operation for EPS

On Thu, 2017-12-28 at 18:41 +0100, Aleksander Morgado wrote: > Hey, > > The following two patches implement support for loading and updating > the UE mode of operation for EPS, as defined by 3GPP TS 27.007 and > 3GPP TS 24.301. > > Comments? Patches look OK to me. I wonder what this knob is

Re: Initial signal quality query on MBIM modems

On Fri, 2018-01-05 at 06:57 +, Ben Chan wrote: > Hi Aleksander and Dan > > ModemManager currently relies on unsolicited MBIM_CID_SIGNAL_STATE > notification to obtain signal quality updates, and it doesn't query > the > initial signal quality. I've observed that some MBIM modems issue a >

Re: [PATCH] ublox: wait for READY URCs during port probing

On Mon, 2017-12-25 at 20:02 +0100, Aleksander Morgado wrote: > The AT control TTYs in the u-blox modems may take some time to be > usable. In order to handle this issue, we configured some longer > timeouts during AT probing, but that may not be always enough. > > The u-blox TTYs will report

Re: Equipment info without SIM installed

On Tue, 2017-12-05 at 09:08 -0600, Dan Williams wrote: > On Tue, 2017-12-05 at 10:54 +0100, Aleksander Morgado wrote: > > Hey Dan, > > > > > > > > > > > > > > In the case above none of the commands we have was > > > > > > su

Re: Can't connect to the network of my ISP via ModemManager 1.4.0-1/Debian Jessie

to use networks of eplus, when > o2  > isn't available or is it that what the allown-romaing flag will do? > > On 12/05/2017 12:22 AM, Dan Williams wrote: > > On Mon, 2017-12-04 at 22:15 +0100, Dennis Heddicke wrote: > > > Hello, > > > i have a problem wi

Re: Equipment info without SIM installed

On Tue, 2017-12-05 at 10:54 +0100, Aleksander Morgado wrote: > Hey Dan, > > > > > > > > > > > In the case above none of the commands we have was successful > > > > > determining capabilities :/ But we could improve the +CPIN? > > > > > check and > > > > > also assume that if it's telling us "SIM

Re: Can't connect to the network of my ISP via ModemManager 1.4.0-1/Debian Jessie

On Mon, 2017-12-04 at 22:15 +0100, Dennis Heddicke wrote: > Hello, > i have a problem with my Debian 8/Jessie, because I can't connect to > the  > network of my ISP. The log says my modem wasn't be registered and > the  > Errors says, that it could not connect/register the modem. Correct. The

Re: Roadmap for next stable 1.8?

On Fri, 2017-11-03 at 09:55 +0100, Aleksander Morgado wrote: > Hey, > > It's been already a while since we released 1.6.0, and there are a > lot > of things in git master that haven't been released yet, so maybe it's > time for a 1.8.0 release. > > I see two big pending things that could get

Re: Quectel EC25 tty layout and GPS

On Mon, 2017-10-09 at 23:37 +0200, Aleksander Morgado wrote: > Hey, > > The Quectel EC25 exposes 4 TTYs and 1 QMI/wwan pair. > > ttyUSB2 and ttyUSB3 are AT-capable ports; does anyone know what > ttyUSB0 and ttyUSB1 are? E.g. is ttyUSB0 the GPS NMEA port? For the UC15, UC20, EC20, EC21, and

Re: MC/EM7455

On Sat, 2017-10-07 at 14:08 +0200, Bjørn Mork wrote: > Thomas Schäfer writes: > > > Hi, > > > > SWI9X30C_02.08.02.00 r5428 CARMD-EV-FRMWR2 2016/01/06 20:38:53 > > > > defaults to qmi and some problems with two devices, raw-ip mode and > > other things.  > > But it in the

Re: Debian discussion to disable automatic TTY probing

On Thu, 2017-09-28 at 21:08 +0200, Aleksander Morgado wrote: > > > Got told today that Debian is discussing whether to disable > > > automatic > > > probing of TTY devices in MM, some links: > > > > > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877024 > > >

Re: Debian discussion to disable automatic TTY probing

On Thu, 2017-09-28 at 19:16 +0200, Bjørn Mork wrote: > Just one other idea: Why not look at the kernel driver? It should > give > you a pretty good idea about which devices are modems. > > 'option', 'sierra', 'qcserial' are all pretty much guaranteed to be > modems. 'pl2303', 'ftdi_sio',

Re: Debian discussion to disable automatic TTY probing

On Thu, 2017-09-28 at 17:58 +0200, Aleksander Morgado wrote: > Hey! > > FYI > > Got told today that Debian is discussing whether to disable automatic > probing of TTY devices in MM, some links: > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=877024 >

Re: [PATCH] libmm-glib,sms: fix get|dup_data() introspection annotations

On Tue, 2017-09-26 at 16:15 +0100, Colin Helliwell wrote: > > On 26 September 2017 at 16:08 Colin Helliwell > ystems.com> wrote: > > > > > On 26 September 2017 at 14:23 Aleksander Morgado > > sander.es> wrote: > > > > > > We need to specify explicitly

Re: Received SMS with python

On Fri, 2017-09-22 at 14:26 +0100, Colin Helliwell wrote: > > On 21 September 2017 at 11:54 Colin Helliwell > ystems.com> wrote: > > > > > On 19 September 2017 at 17:39 Aleksander Morgado > > sander.es> wrote: > > > > > > ... > > > > > > Another

Re: [review] https://github.com/cbchan/ModemManager/tree/modem-hardware-revision

On Mon, 2017-09-18 at 21:38 -0700, Aleksander Morgado wrote: > On Mon, Sep 18, 2017 at 8:13 AM, Ben Chan > wrote: > > Similar to firmware revision, hardware revision is useful > > information > > for identifying characteristics about a modem module. Both MBIM and > > QMI

Re: [PATCH 2/2] broadband-modem-mbim: fix preservation logic for PIN1 unlock retries

On Mon, 2017-09-18 at 21:30 -0700, Aleksander Morgado wrote: > On Mon, Sep 18, 2017 at 9:10 AM, Ben Chan > wrote: > > This patches fixes commit 334273979 "broadband-modem-mbim: preserve > > unlock retries for PIN1 when appropriate", which doesn't correctly > > propagate the

Re: Basic ublox TOBY-L4 support (v2)

On Thu, 2017-09-14 at 22:00 -0700, Aleksander Morgado wrote: > Hey, > > This updated patch series to support the TOBY-L4 also includes > support for modifying currently selected bands with AT+UACT, instead > of AT+UBANDSEL, as the latter is deprecated. Additionally, > AT+UAUTHREQ=? output is

Re: Python libmm problems

On Thu, 2017-09-14 at 15:35 +0100, Colin Helliwell wrote: > > On 13 September 2017 at 19:39 Dan Williams <d...@redhat.com> wrote: > > > > ... > > > > The two major patterns for doing all of this are (a) threads and > > (b) > > event-driven progr

Re: Python libmm problems

On Wed, 2017-09-13 at 18:41 +0100, Colin Helliwell wrote: > > On 13 September 2017 at 17:57 Dan Williams <d...@redhat.com> wrote: > > > > On Wed, 2017-09-13 at 17:23 +0100, colin.helliw...@ln-systems.com > > wrote: > > > > > I'm trying to

Re: Python libmm problems

On Wed, 2017-09-13 at 17:23 +0100, colin.helliw...@ln-systems.com wrote: > I'm trying to write some python to get the operator id off the > modem.  > Due to limited knowledge of such things, I'm *not* using any > notifcation > callbacks etc, but simply trying to poll things. > I've wrapped the

[PATCH 1.6] bearer-mbim: ensure session is disconnected before trying to connect

If a suspend/resume cycle happens or ModemManager is restarted (e.g. after a crash) the modem may be left with a given session id connected. With this change we're forcing a session disconnection before we attempt a session connection. https://bugs.freedesktop.org/show_bug.cgi?id=102231 (cherry

Re: [PATCH] bearer-mbim: ensure session is disconnected before trying to connect

On Fri, 2017-08-25 at 13:12 +0200, Aleksander Morgado wrote: > If a suspend/resume cycle happens or ModemManager is restarted (e.g. > after a crash) the modem may be left with a given session id > connected. With this change we're forcing a session disconnection > before we attempt a session

Re: problem with dell latitude

On Tue, 2017-09-12 at 15:53 +0200, Bartłomiej Knabel wrote: > Hi, > > I don't know why, but I've tried to run it today and wasn't working - > so > I've decided to install ModemManager from Your PPA and nothing > better: > > # apt-get install modemmanager > Reading package lists... Done >

Re: GPS support using Quectel EC21

On Mon, 2017-09-11 at 17:11 +0200, Aleksander Morgado wrote: > Hey, > > > > > I am trying to use ModemManager with the Quectel EC21 modem to get > > GPS data. > > > > By default this modem uses QMI, but I see the following message > > when > > starting ModemManager: > > > > [1504793139.991929]

Re: Setting IP-addresses without NetworkManager?

ou get for "rfkill list"? Dan >  > On 8.9.2017 19:22, Dan Williams wrote: > > On Fri, 2017-09-08 at 18:13 +0300, Ossi wrote: > > > Hi, > > >  > > > I run a very minimal Gentoo installation on the latest X1 Carbon > > > with > > > EM7455 modem. I

Re: Setting IP-addresses without NetworkManager?

On Fri, 2017-09-08 at 18:13 +0300, Ossi wrote: > Hi, > > I run a very minimal Gentoo installation on the latest X1 Carbon with > EM7455 modem. I do all the networking related config with netifrc > scripts. I can initialize the modem using ModemManager, running > 'mmcli > -m 0

Re: QMI disconnection errors detection in Netgear AC341U

On Wed, 2017-09-06 at 09:44 +0200, Aleksander Morgado wrote: > On Tue, Sep 5, 2017 at 11:10 PM, Dan Williams <d...@redhat.com> > wrote: > > On Tue, 2017-09-05 at 22:26 +0200, Aleksander Morgado wrote: > > > Hey, > > > > > > The Netgear AC341

Re: API updates for modem frequency band definitions (v2)

On Mon, 2017-08-21 at 12:39 +0200, Aleksander Morgado wrote: > Hey, > > This updated series includes also new LTE bands, and due to that I > ended up moving the new UMTS bands to values > 200. This and the plugin updates LGTM. Dan >   [PATCH v2 1/6] api: don't use intermediate variables for >

Re: [PATCH] build: import gtk-doc support

On Mon, 2017-08-28 at 12:59 +0200, Aleksander Morgado wrote: > Remove the need to run `gtkdocize' when building from git; this > should > be an operation done by the maintainer when modernizing the gtk-doc > setup (think of e.g. gettextize), no need to do it unconditionally. > > This makes it

Re: [PATCH v4] i18n: deprecate intltool and use only gettext 0.19.8

On Sun, 2017-09-03 at 22:23 +0200, Aleksander Morgado wrote: > Instead of mixing both intltool and gettext, which not always work > correctly together, this patch obsoletes intltool and uses only > gettext, which includes support for translating XML files with ITS > rules. > > See migration steps

Re: QMI disconnection errors detection in Netgear AC341U

On Tue, 2017-09-05 at 22:26 +0200, Aleksander Morgado wrote: > Hey, > > The Netgear AC341U is a QMI device that comes with autoconnect > enabled (and disabling it doesn't look possible, firmware may even > crash and power cycle itself). I suspect that due to autoconnect > being enabled, the

Re: primary device changing from boot to boot

On Tue, 2017-09-05 at 09:38 -0700, Tim Harvey wrote: > On Fri, Sep 1, 2017 at 1:22 PM, Dan Williams <d...@redhat.com> wrote: > > On Fri, 2017-09-01 at 13:01 -0700, Tim Harvey wrote: > > > Greetings, > > > > > > I've got a Sierra Wireless HL7588 modem w

Re: primary device changing from boot to boot

On Fri, 2017-09-01 at 13:01 -0700, Tim Harvey wrote: > Greetings, > > I've got a Sierra Wireless HL7588 modem which exposes three ttyACM > devs via the cdc_acm driver. The device appears to work fine with > ModemManager (1.6.8) but occasionally mm detects the primary device > as > ttyACM2 instead

Re: Watching for registration with python

On Fri, 2017-09-01 at 17:59 +0100, Colin Helliwell wrote: > > On 01 September 2017 at 17:17 Dan Williams <d...@redhat.com> wrote: > > > > On Fri, 2017-09-01 at 10:51 -0500, Dan Williams wrote: > > > > > On Fri, 2017-09-01 at 14:26 +0100, col

Re: Watching for registration with python

On Fri, 2017-09-01 at 10:51 -0500, Dan Williams wrote: > On Fri, 2017-09-01 at 14:26 +0100, colin.helliw...@ln-systems.com > wrote: > > I've been having a look at the modem-watcher-python example, and > > would like > > to do something similar - namely wait until the

Re: Watching for registration with python

On Fri, 2017-09-01 at 14:26 +0100, colin.helliw...@ln-systems.com wrote: > I've been having a look at the modem-watcher-python example, and > would like > to do something similar - namely wait until the modem has registered > on the > network and then grab the MCC/MNC. > Is there some sort of

Re: [PATCH] charsets: simplify check to see if conversion to charset possible

On Tue, 2017-08-15 at 23:25 +0200, Aleksander Morgado wrote: > Instead of having a method that returns the expected length after the > conversion and the amount of input UTF-8 characters that couldn't be > converted to the given charset, simplify the logic and just define a > method that returns a

Re: [PATCH] charset: only update length if char conversion succeeded

On Tue, 2017-08-15 at 10:06 +0200, Aleksander Morgado wrote: > The methods that convert from a gunichar to a specific encoding may > update the output 'clen' value unconditionally, regardless of whether > the conversion is going to be successful or not. Avoid that by > updating the length only if

Re: [PATCH] libmm-glib,cdma: fix potential NULL dereference

On Fri, 2017-08-11 at 14:19 -0700, Ben Chan wrote: > This patch fixes a potential NULL referenece issue in > mm_cdma_manual_activation_properties_get_prl() where it accesses > `self->priv->prl->data' when `self->priv->prl' could be potentially > NULL. Thanks, pushed to git master and mm-1-6. Dan

Re: [PATCH] plugin: fix forbidden_product_strings check in apply_post_probing_filters

On Fri, 2017-08-11 at 11:23 -0700, Ben Chan wrote: > This patch fixes a bug in apply_post_probing_filters() where it > iterates > through `self->priv->forbidden_product_strings' but incorrectly > accesses > `self->priv->product_strings[i]' inside the loop. >

Re: [PATCH v2] libmm-glib,sms-properties: fix potential NULL dereference

On Fri, 2017-08-11 at 14:16 -0700, Ben Chan wrote: > This patch fixes a potential NULL referenece issue in > mm_sms_properties_get_data() where it accesses `self->priv->data- > >data' > when `self->priv->data' could be potentially NULL. Thanks, pushed to git master and mm-1-6. Dan > --- >  

Re: [PATCH] charset: fix mm_charset_get_encoded_len

On Fri, 2017-08-11 at 13:27 -0700, Ben Chan wrote: > The while loop in mm_charset_get_encoded_len() iterates through each > valid UTF-8 encoded character in the given NULL-terminated UTF-8 > string. > It uses g_utf8_find_next_char() to find the position of the next > character. In case,

Re: [PATCH] broadband-modem-mbim: explicitly remove notification handler on unref

On Fri, 2017-08-11 at 17:04 +0200, Aleksander Morgado wrote: > When we remove the last object reference, make sure the notification > handler is also removed, or we may end up using an already freed > object. > > https://retrace.fedoraproject.org/faf/reports/1815001/ Good catch; any time we

Re: [PATCH] bearer-mbim: refactor disconnect_set_ready()

On Fri, 2017-08-04 at 14:00 +0200, Aleksander Morgado wrote: > Try to make it more clear which are the different branches in the > logic, and jump out as soon as the branch is finished. > --- > > Hey, > > How about something like this? LGTM > Cheers! > > --- >  src/mm-bearer-mbim.c | 96

Re: [PATCH] broadband-modem-qmi: fix potential use-after-freed issues

On Thu, 2017-08-03 at 13:25 -0700, Ben Chan wrote: > This patch fixes some potential use-after-freed issues in > dms_get_ids_ready(). When an invalid ESN / MEID is retrieved, > `ctx->self->priv->esn' / `ctx->self->priv->meid' is freed but not > reset > to NULL. If no IMEI is retrieved, `str' can

Re: [PATCH] bearer-mbim: avoid accessing invalid session_id and nw_error

On Thu, 2017-08-03 at 13:24 -0700, Ben Chan wrote: > This patch fixes an issue in disconnect_set_ready(). If > mbim_message_connect_response_parse(), `session_id' and `nw_error' > are > not set to a valid value, and thus shouldn't be used. LGTM; kinda convoluted function, but I can't think of a

Re: [PATCH] broadband-bearer: run init sequence after flashing in disconnection

On Tue, 2017-07-25 at 14:31 +0100, Tim Small wrote: > On 25/07/17 13:48, Aleksander Morgado wrote: > > What do you think of this change? It should clear up the mixup of > > commands sent while flashing is ongoing. > > Hi Aleksander, > > That patch looks reasonable, with the caveat that I don't

Re: Modem disconnect - serial breaks etc.

On Mon, 2017-07-24 at 18:09 +0100, Tim Small wrote: > I'm seeing an issue where the ppp connection exits, but the modem > seems > to be left in connected state (I can verify that by sending mm > SIGSTOP, > then opening a serial terminal window - I'm able to then manually > hangup > the modem using

Re: Need help with Netgear 341u

On Wed, 2017-07-19 at 11:58 -0400, Neil Cherry wrote: > On 07/19/2017 04:14 AM, Aleksander Morgado wrote: > > On Wed, Jul 19, 2017 at 3:43 AM, Neil Cherry > > wrote: > > > I'm stuck at the beginning, I have this nice Netgear 341u and I > > > don't know > > > Any pointers? > >

Re: Telit LE910 failing to find network

On Tue, 2017-07-18 at 20:30 +0100, Kelvin wrote: > Hi, > > > > could you please attach the full debug logs, so we can have a > > complete > > picture of what's going on? > > > > Thanks a lot, the full syslog is here: https://pastebin.com/6X5K0gXU It shows the modem is using regular AT

Re: [PATCH] cinterion: check error returned by g_task_propagate_error instead

On Thu, 2017-07-06 at 12:35 -0700, Ben Chan wrote: > When returning an enum value via g_task_return_int, some code assumes > the enum value is always non-negative and thus considers that a > negative > value implies an error. This assumption could be invalidated if a > negative value is later

Re: Single RS232 port Telit and CMUX mode (GSM 27.010 / n_gsm)

On Mon, 2017-07-03 at 13:10 +0100, Tim Small wrote: > Hello, > > I'm trying to get a (GPRS / 2.5G) Telit GE910-Quad V3 working in CMUX > mode.  There's only a single RS232 port connection between the modem > and > the host computer, so I'd like to use GSM 27.010 ("CMUX") mode.  The > Telit module

Re: MC7455 'Call Failed'

On Thu, 2017-06-22 at 15:11 -0700, Tim Harvey wrote: > On Thu, Jun 22, 2017 at 2:59 PM, Dan Williams <d...@redhat.com> > wrote: > > On Thu, 2017-06-22 at 23:29 +0200, Aleksander Morgado wrote: > > > On Thu, Jun 22, 2017 at 10:11 PM, Tim Harvey <tharvey@gat

Re: MC7455 'Call Failed'

On Thu, 2017-06-22 at 23:29 +0200, Aleksander Morgado wrote: > On Thu, Jun 22, 2017 at 10:11 PM, Tim Harvey > wrote: > > > > Also, I'm unclear how to NetworkManager on the QMI devices: > > > > root@ventana:~# nmcli connection add type gsm ifname cdc-wdm1 > > > > con-name >

Re: Setup MC7455 connection to internet with modem manager

On Thu, 2017-06-15 at 10:52 +0200, Nassim Dahmani wrote: > NetworkManager[1949]: [1497516042.3228] > device[0x564bf34fc610] > (cdc-wdm1): unmanaged: flags set to > [user-settings,!sleeping,!loopback,!platform- > init=0x40/0x59/unmanaged/unrealized, > set-managed [sleeping=0x1]) The modem has

Re: [PATCH] broadband-modem-qmi: allow prefix match for Modem images ending with '?'

On Thu, 2017-06-15 at 00:36 +0200, Aleksander Morgado wrote: > On Wed, Jun 14, 2017 at 10:20 PM, Dan Williams <d...@redhat.com> > wrote: > > Assume that a modem image build_id "02.08.02.00_?" matches a pri > > build_id > > of "02.08.02.00_ATT" or

[PATCH] broadband-modem-qmi: allow prefix match for Modem images ending with '?'

Assume that a modem image build_id "02.08.02.00_?" matches a pri build_id of "02.08.02.00_ATT" or "02.08.02.00_GENERIC". --- src/mm-broadband-modem-qmi.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/mm-broadband-modem-qmi.c

Re: ModemManager with Sierra EM7305 and GPS

On Tue, 2017-06-13 at 11:17 +, Petr Kloc wrote: > Hi Dan > > My suspicion regarding incorrect device grabbing by modules proved > correct. Neither qcserial, nor qmi_wwan had my device (Vendor=0x1199, > Product=0x9063) in its internal list. I did modify > both  drivers/net/usb/qmi_wwan.c  and  

Re: ModemManager with Sierra EM7305 and GPS

he device IDs to the right kernel drivers. Thanks! Dan > In an attachment you can find logs from ModemManager for qcserial an > qmi_wwan respectively alongside the output of usb-devices.  > > Regards > Petr Kloc > > > > > > ---

<    1   2   3   4   5   >