Re: [Mono-dev] System.Json string handling

2014-09-22 Thread Miguel de Icaza
...@clevertrove.com Sent: ‎21/‎9/‎2014 3:13 To: Miguel de Icaza mig...@xamarin.com; 何子杰Hzj_jie hzj_...@hotmail.com Cc: Steffen Kieß steffen.ki...@ipvs.uni-stuttgart.de; mono-devel-list@lists.ximian.com Subject: RE: [Mono-dev] System.Json string handling From: mono-devel-list-boun

Re: [Mono-dev] System.Json string handling

2014-09-22 Thread Miguel de Icaza
Tru dat. However, when broken stuff doesn't get fixed, it drives users away. I'll cite myself as an example: We've had a pull request outstanding since April https://github.com/mono/mono/pull/1004, prior to which, SslStream is simply unusable (mono SslStream server is incompatible with

Re: [Mono-dev] System.Json string handling

2014-09-22 Thread Greg Young
Perhaps the best thing to do is to file a companion bug, and raise the priority of that bug to major whenever a patch is available, to trigger a review. How do you let many first time people this? On Mon, Sep 22, 2014 at 2:50 PM, Miguel de Icaza mig...@xamarin.com wrote: Tru dat. However,

Re: [Mono-dev] System.Json string handling

2014-09-22 Thread Edward Ned Harvey (mono)
From: Miguel de Icaza [mailto:mig...@xamarin.com] Sent: Monday, September 22, 2014 9:50 AM We've had a pull request outstanding since April https://github.com/mono/mono/pull/1004 Perhaps the best thing to do is to file a companion bug, and raise the priority of that bug to major

Re: [Mono-dev] System.Json string handling

2014-09-22 Thread Miguel de Icaza
That is ok, the pull request for the bug did not come until August. And then, it needs to be reviewed for security, because right now it is too aggressive protecting the user data, and we rather err on the side of safety, than have a security hole in our hands. Miguel On Mon, Sep 22, 2014 at

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread Martin Thwaites
...@hotmail.com Cc: Steffen Kieß steffen.ki...@ipvs.uni-stuttgart.de; mono-devel-list@lists.ximian.com Subject: RE: [Mono-dev] System.Json string handling From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list- boun...@lists.ximian.com] On Behalf Of Edward Ned Harvey (mono

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread Chris Rogus
Hzj_jie hzj_...@hotmail.com Cc: Steffen Kieß steffen.ki...@ipvs.uni-stuttgart.de; mono-devel-list@lists.ximian.com Subject: RE: [Mono-dev] System.Json string handling From: mono-devel-list-boun...@lists.ximian.com [mailto: mono-devel-list- boun...@lists.ximian.com] On Behalf Of Edward Ned

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread Andres G. Aragoneses
; mono-devel-list@lists.ximian.com mailto:mono-devel-list@lists.ximian.com Subject: RE: [Mono-dev] System.Json string handling From:mono-devel-list-boun...@lists.ximian.com mailto:mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread Edward Ned Harvey (mono)
From: Edward Ned Harvey (mono) even as Xamarin customers you can't get anyone to review your patches. As a tiny little baby step in the right direction, I think Xamarin could at least promise to review pull requests submitted by customers paying for support. (This is a little bit shy of

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread Edward Ned Harvey (mono)
From: mar...@my2cents.co.uk [mailto:mar...@my2cents.co.uk] On Behalf Of Martin Thwaites Agreed on all counts. I agree, as Miguel mentioned, that it's necessary to have quality control in place before accepting commits. As Martin says, don't let something get worse as a result of supposed

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread 何子杰Hzj_jie
...@xamarin.com; Steffen Kießmailto:steffen.ki...@ipvs.uni-stuttgart.de; mono-devel-list@lists.ximian.commailto:mono-devel-list@lists.ximian.com Subject: RE: [Mono-dev] System.Json string handling From: Edward Ned Harvey (mono) even as Xamarin customers you can't get anyone to review your

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread Andres G. Aragoneses
On 21/09/14 17:12, 何子杰Hzj_jie wrote: If the team does not want to let mono go worse. Then I would suggest to add more test cases, and a peer reviews. But if mono team is just simply ignoring pull requests out of core business, and trying to make mono close for other developers. Then just let

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread 何子杰Hzj_jie
-list@lists.ximian.com Subject: Re: [Mono-dev] System.Json string handling On 21/09/14 17:12, 何子杰Hzj_jie wrote: If the team does not want to let mono go worse. Then I would suggest to add more test cases, and a peer reviews. But if mono team is just simply ignoring pull requests out of core

Re: [Mono-dev] System.Json string handling

2014-09-21 Thread Andres G. Aragoneses
@lists.ximian.com Subject: Re: [Mono-dev] System.Json string handling On 21/09/14 17:12, 何子杰Hzj_jie wrote: If the team does not want to let mono go worse. Then I would suggest to add more test cases, and a peer reviews. But if mono team is just simply ignoring pull requests out of core business

Re: [Mono-dev] System.Json string handling

2014-09-20 Thread Edward Ned Harvey (mono)
From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list- boun...@lists.ximian.com] On Behalf Of Miguel de Icaza It is not easy to add people.   We can only add people that have shown the practices and skills that come with reviewing patches and working through the system.

Re: [Mono-dev] System.Json string handling

2014-09-20 Thread Edward Ned Harvey (mono)
From: mono-devel-list-boun...@lists.ximian.com [mailto:mono-devel-list- boun...@lists.ximian.com] On Behalf Of Edward Ned Harvey (mono) Tru dat. However, I guess I'm actually trying to say two separate things: * When broken stuff doesn't get fixed, it's a disincentive for usage adoption.

Re: [Mono-dev] System.Json string handling

2014-09-20 Thread 何子杰Hzj_jie
Icazamailto:mig...@xamarin.com; 何子杰Hzj_jiemailto:hzj_...@hotmail.com Cc: Steffen Kießmailto:steffen.ki...@ipvs.uni-stuttgart.de; mono-devel-list@lists.ximian.commailto:mono-devel-list@lists.ximian.com Subject: RE: [Mono-dev] System.Json string handling From: mono-devel-list-boun

[Mono-dev] System.Json string handling

2014-09-19 Thread Steffen Kieß
Hello, I've submitted a pull request https://github.com/mono/mono/pull/1155 some time ago. This pull request fixes some issues with string handling in System.Json: - Escape control characters, as required by JSON spec - Escape invalid surrogate pairs - Escape characters invalid in JavaScript

Re: [Mono-dev] System.Json string handling

2014-09-19 Thread 何子杰Hzj_jie
To: mono-devel-list@lists.ximian.commailto:mono-devel-list@lists.ximian.com Subject: [Mono-dev] System.Json string handling Hello, I've submitted a pull request https://github.com/mono/mono/pull/1155 some time ago. This pull request fixes some issues with string handling in System.Json: - Escape

Re: [Mono-dev] System.Json string handling

2014-09-19 Thread Miguel de Icaza
-list@lists.ximian.com Subject: [Mono-dev] System.Json string handling Hello, I've submitted a pull request https://github.com/mono/mono/pull/1155 some time ago. This pull request fixes some issues with string handling in System.Json: - Escape control characters, as required by JSON spec

Re: [Mono-dev] System.Json string handling

2014-09-19 Thread Bob Summerwill
-- From: Steffen Kieß steffen.ki...@ipvs.uni-stuttgart.de Sent: ‎19/‎9/‎2014 17:58 To: mono-devel-list@lists.ximian.com Subject: [Mono-dev] System.Json string handling Hello, I've submitted a pull request https://github.com/mono/mono/pull/1155 some time ago. This pull request fixes some