Increasing the module ref count at registration will block the module from
ever being unloaded. In fact, genetlink should not care about the owner at
all. This patch removes the owner field from the struct registered with
genetlink.
Signed-off-by: Per Liden [EMAIL PROTECTED]
---
Michael Buesch wrote:
We also have a function to burn (and read) the SPROM though a
private handler, atm. I consider this a very device specific task,
which does not really need a standard API. Noone will ever reflash
the SPROM, if he has no good good good reasons. ;)
The idea of an (WE
John W. Linville wrote:
What is WCONF_CMD_NICK for?
Just for users convenience, like the nick in WE.
Is it really useful?
No :)
Is the point here to support all current WEXT functionality?
It probably should be. For compatibility, we will likely need code
to translate the WEXT ioctls to
Andi Kleen [EMAIL PROTECTED] wrote:
Badness in ip_finish_output2 at
/home/lsrc/quilt/linux/net/ipv4/ip_output.c:203
Call Trace: 8034284f{ip_finish_output2+419}
80343dfa{ip_fragment+1512}
803426ac{ip_finish_output2+0}
Herbert Xu wrote:
Andi Kleen [EMAIL PROTECTED] wrote:
Badness in ip_finish_output2 at /home/lsrc/quilt/linux/net/ipv4/ip_output.c:203
Call Trace: 8034284f{ip_finish_output2+419}
80343dfa{ip_fragment+1512}
803426ac{ip_finish_output2+0}
On Thursday 12 January 2006 18:58, Andreas Mohr wrote:
Hi,
I'd like to ask some things about packet fragmentation (you remember I wanted
to work on this due to my very bad link quality?). I'm asking now since I
will probably have some time during the weekend to work on it.
Problem is that
Hello David and Herbert,
This patch introduces AES-XCBC-MAC.
I will send a glue for IPsec in another mail.
BTW, I could not fix the issue of single space line
so that I attach the patch. My thunderbird erases the line :-
Anyway this is for 2.6.15. please review and apply it.
Signed-off-by:
On Friday 13 January 2006 03:14, Shaun Pereira wrote:
Thank you for reviewing that bit of code.
I had a look at compat_sys_gettimeofday and sys32_gettimeofday codes.
They seem to work in a similar way, casting a pointer to the structure
from user space to a compat_timeval type.
The part
On Fri, Jan 13, 2006 at 08:17:49PM +0900, Kazunori Miyazawa wrote:
Anyway this is for 2.6.15. please review and apply it.
Signed-off-by: Kazunori MIYAZAWA [EMAIL PROTECTED]
Thanks for the patch Miyazawa-san!
Just a quick thought: HMAC is a bit of a misfit in the crypto directory.
It's
On Fri, 2006-01-13 at 10:25 +0100, Feyd wrote:
The all doesn't IMHO server the purpose. You will virtualy never want
to set something on all devices. You will want to set it on the minimal
subset that shares the resource instead, and want (to be able) to know
the subset
Ack. This needs to be
On Friday 13 January 2006 11:41, Herbert Xu wrote:
However, this is yet to be confirmed.
I tried to test yesterday. It ran for some short time, but then eventually
all hung (I think in IDE) because I didn't apply all workarounds for the
countless
bugs in current -git [Didn't have such an
* Michael Buesch [EMAIL PROTECTED] 2006-01-12 18:24
This is an attempt to rewrite the Wireless Extensions
userspace API, using netlink sockets.
There should also be a notification API, to inform
userspace for changes (config changes, state changes, etc).
It is not implemented, yet.
I'll only
I know it has already been fixed. My point was just to document it
somewhere so somebody else would avoid going through the same hassle. It
should be documented as a known problem. Not everybody can update their
kernel easily, especially in real-time embedded systems.
-Original
On Wed, Jan 11, 2006 at 01:58:58AM +, Alan Cox wrote:
On Mer, 2006-01-11 at 01:53 +0100, Andi Kleen wrote:
shaper is completely obsolete and it's probably best to just remove
all references to it and the kernel driver too.
I would agree with that but it nees to go through a proper
On Fri, 2006-13-01 at 09:27 +0100, Per Liden wrote:
Increasing the module ref count at registration will block the module from
ever being unloaded. In fact, genetlink should not care about the owner at
all. This patch removes the owner field from the struct registered with
genetlink.
On Fri, 13 Jan 2006, Kazunori Miyazawa wrote:
[it's better to send patches inline, so they can be reviewed inline with
proper quoting etc.]
+#ifdef CONFIG_CRYPTO_XCBC
+ ret = crypto_alloc_xcbc_block(tfm);
+#endif
}
...
+#ifdef CONFIG_CRYPTO_XCBC
+int
+
+ ops = (struct xcbc_ops*)kmalloc(sizeof(*ops) +
+ + crypto_tfm_alg_blocksize(tfm), GFP_KERNEL);
+
Don't cast the return of kmalloc().
+void crypto_free_xcbc_block(struct crypto_tfm *tfm)
+{
+ if (tfm-crt_cipher.cit_xcbc_block)
+
Why do you have this magic number for the blocksize, and limit the code to
this value?
int crypto_alloc_xcbc_block(struct crypto_tfm *tfm)
+{
+ struct xcbc_ops *ops;
+
+ BUG_ON(!crypto_tfm_alg_blocksize(tfm));
+ if (crypto_tfm_alg_blocksize(tfm) != 16)
+ return 0;
On Fri, 13 Jan 2006, Kazunori Miyazawa wrote:
+#ifdef CONFIG_CRYPTO_XCBC
+ mode = aalg_desc-desc.sadb_alg_id == SADB_X_AALG_AES_XCBC_MAC ?
+ CRYPTO_TFM_MODE_CBC : 0;
+#endif
+
ahp-key = x-aalg-alg_key;
ahp-key_len = (x-aalg-alg_key_len+7)/8;
- ahp-tfm =
...
I still have a patch in queue to improve usage of netif_carrier_{on,off}
but I had no possibility to test yet, so I did not send.
I'd be happy to test it out if you'd like.
Dan
Hi Dan,
here is the patch for testing.
The patch _should_ do the following:
1. Set the polling
* Patrick McHardy [EMAIL PROTECTED] 2006-01-12 06:25
David S. Miller wrote:
From: jamal [EMAIL PROTECTED]
Date: Tue, 10 Jan 2006 23:02:45 -0500
So it is an optimization - not a bug then, correct?
It is only an optimization in as much as it avoids duplicate
work during initialization.
* Per Liden [EMAIL PROTECTED] 2006-01-13 09:27
Increasing the module ref count at registration will block the module from
ever being unloaded. In fact, genetlink should not care about the owner at
all. This patch removes the owner field from the struct registered with
genetlink.
Why shouldn't
Hi,
A new version of radvd has been released. There hasn't been any major changes,
just regular maintenance and a one new feature (jumboframe support).
Get it at: http://www.litech.org/radvd/
There have been the following changes since 0.8:
* Clean up signed/unsigned values, add more
On 1/12/06, Andi Kleen [EMAIL PROTECTED] wrote:
On Friday 13 January 2006 01:51, Jeff Kirsher wrote:
Adds the ability to disability packet split at compile time and use the
legacy receive path on PCI express hardware.
Does this patch really do what you described?
-#ifdef
Hi,
On Thu, 12 Jan 2006, Linus Torvalds wrote:
Yes, I think that's much more Aunt-Nellie-friendly, but Roman considers it
abuse of the Kconfig system in ways which I never completely understood?
Hmm. If Roman dislikes it, he must dislike the fact that we already do
exactly this for a
On Thu, 12 Jan 2006 18:24:02 +0100
Michael Buesch [EMAIL PROTECTED] wrote:
This is an attempt to rewrite the Wireless Extensions
userspace API, using netlink sockets.
There should also be a notification API, to inform
userspace for changes (config changes, state changes, etc).
It is not
Hi Thomas,
On Fri, 13 Jan 2006, Thomas Graf wrote:
* Per Liden [EMAIL PROTECTED] 2006-01-13 09:27
Increasing the module ref count at registration will block the module from
ever being unloaded. In fact, genetlink should not care about the owner at
all. This patch removes the owner field
Jiri Benc [EMAIL PROTECTED] writes:
I think this is manageable.
We need real 802.11 devices - all of frames, including management ones,
end up in one queue (in one net_device). And we are not able to do
Ethernet-802.11 conversion then, because we don't know how (and storing
pointer to
Credit Dmitry Pervushin for the PNX010X platform support.
Signed-off-by: Lennert Buytenhek [EMAIL PROTECTED]
diff -urN linux-2.6.15-git8.orig/drivers/net/cs89x0.c
linux-2.6.15-git8/drivers/net/cs89x0.c
--- linux-2.6.15-git8.orig/drivers/net/cs89x0.c 2006-01-13 02:16:01.0
+0100
+++
cs89x0 inconsistently used 'int' and 'u32' for device register data.
As the cs89x0 is a 16-bit chip, change the I/O accessors over to 'u16'.
(Spotted by Deepak Saxena.)
Signed-off-by: Lennert Buytenhek [EMAIL PROTECTED]
diff -urN linux-2.6.15-git8.commit/drivers/net/cs89x0.c
Signed-off-by: Lennert Buytenhek [EMAIL PROTECTED]
diff -urN linux-2.6.15-git8.orig/drivers/net/cs89x0.c
linux-2.6.15-git8/drivers/net/cs89x0.c
--- linux-2.6.15-git8.orig/drivers/net/cs89x0.c 2006-01-13 02:53:21.0
+0100
+++ linux-2.6.15-git8/drivers/net/cs89x0.c 2006-01-13
On Thu, Jan 12 2006, Andrew Morton wrote:
Linus Torvalds [EMAIL PROTECTED] wrote:
On Thu, 12 Jan 2006, Jeff Garzik wrote:
dann frazier:
CONFIG_AIRO needs CONFIG_CRYPTO
I think this is done wrong.
It should select CRYPTO rather than depends on CRYPTO.
On Fri, Jan 13 2006, Sam Ravnborg wrote:
On Fri, Jan 13, 2006 at 08:23:16PM +0100, Jens Axboe wrote:
'select' is really cool as a concept, but when you can't figure out why
you cannot disable CONFIG_FOO because CONFIG_BAR selects it it's really
annoying. Would be nice to actually be able
From: Jamal Hadi Salim [EMAIL PROTECTED]
Date: Fri, 13 Jan 2006 09:30:27 -0500
On Fri, 2006-13-01 at 09:27 +0100, Per Liden wrote:
Increasing the module ref count at registration will block the module from
ever being unloaded. In fact, genetlink should not care about the owner at
all. This
@@ -151,6 +152,7 @@
/* index values for the variables in ipv6_devconf */
enum {
DEVCONF_FORWARDING = 0,
+ DEVCONF_RPFILTER = 0,
DEVCONF_HOPLIMIT,
DEVCONF_MTU6,
DEVCONF_ACCEPT_RA,
That doesn't look quite right :)
- z
-
To unsubscribe from this
On Fri, 13 Jan 2006, David S. Miller wrote:
From: Jamal Hadi Salim [EMAIL PROTECTED]
Date: Fri, 13 Jan 2006 09:30:27 -0500
On Fri, 2006-13-01 at 09:27 +0100, Per Liden wrote:
Increasing the module ref count at registration will block the module from
ever being unloaded. In fact,
From: Per Liden [EMAIL PROTECTED]
Date: Fri, 13 Jan 2006 21:56:53 +0100 (CET)
On Fri, 13 Jan 2006, David S. Miller wrote:
From: Jamal Hadi Salim [EMAIL PROTECTED]
Date: Fri, 13 Jan 2006 09:30:27 -0500
On Fri, 2006-13-01 at 09:27 +0100, Per Liden wrote:
Increasing the module ref
From: Per Liden [EMAIL PROTECTED]
Date: Fri, 13 Jan 2006 21:56:53 +0100 (CET)
Signed-off-by: Per Liden [EMAIL PROTECTED]
BTW, don't do this, it should be a perfectly functioning
email address so that people can contact you.
-
To unsubscribe from this list: send the line unsubscribe netdev in
On Fri, 13 Jan 2006, David S. Miller wrote:
From: Per Liden [EMAIL PROTECTED]
Date: Fri, 13 Jan 2006 21:56:53 +0100 (CET)
Signed-off-by: Per Liden [EMAIL PROTECTED]
BTW, don't do this, it should be a perfectly functioning
email address so that people can contact you.
Ok, sorry, I'll
On Mon, Jan 09, 2006 at 04:43:08AM +, Paul Janzen wrote:
Paul Janzen [EMAIL PROTECTED] writes:
In mv643xx_eth_start_xmit:
[...]
spin_lock_irqsave(mp-lock, flags);
[...]
/* Since hardware can't handle unaligned fragments smaller
* than 9 bytes, if we
My original post got eaten by the lists -- probably too big...
I'm reposting in sections. After this intro follow sections on
Configuration, Compatibility, Stack, Other Issues, and Actions.
Enjoy! :-)
---
WiFi-ers...
Here I am, still feeling up to the challenge... I have stopped
Dale Farnsworth [EMAIL PROTECTED] writes:
+if (has_tiny_unaligned_frags(skb)) {
+if ((skb_linearize(skb, GFP_ATOMIC) != 0)
+|| has_tiny_unaligned_frags(skb)) {
There is no way that skb_linearize can return without removing all frags
from the
There are errors and inconsistency in the display of NIP6 strings.
ie: net/ipv6/ip6_flowlabel.c
There are errors and inconsistency in the display of NIPQUAD strings too.
ie: net/netfilter/nf_conntrack_ftp.c
This patch:
adds NIP6_FMT to kernel.h
changes all code to
Configuration
=
Configuration seems to be coalescing around netlink. Among other
things, this technology provides for muliticast requests and
asynchronous event notification.
The kernel should provide generic handlers for netlink
configuraion messages, and there should be a
Other Issues
Radiotap headers make sense for an rfmon virtual device. I don't
think it makes sense for normal usage. Should there be an option
for radiotap headers on non-rfmon links?
Rfmon interferes w/ other interfaces, but may be handy to enter/leave
w/ little effort. Perhaps
Actions
===
I need to establish a public git tree for wireless. I would like for
this to be on kernel.org, but I haven't got an account established
there yet. I've been dragging my feet a little, hoping that the
kernel.org account would materialize.
I intend to get the sipsolutions softmac
From: Kris Katterjohn [EMAIL PROTECTED]
Date: Thu, 12 Jan 2006 13:05:54 -0800
This removes redundant comments, and moves one comment to a better location.
Signed-off-by: Kris Katterjohn [EMAIL PROTECTED]
Applied, thanks Kris.
-
To unsubscribe from this list: send the line unsubscribe netdev
From: Patrick McHardy [EMAIL PROTECTED]
Date: Thu, 12 Jan 2006 22:51:09 +0100
Great, here is a properly signed off patch without the extra
hunks.
Yeah, I noticed that bug fix snuck in there last time :-)
Applied, thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 13 Jan 2006 00:01:34 +0100
It seems to be a common mistake to use jiffies as clocksource, which
gives very bad results in most cases. This patch changes the default
to gettimeofday.
Applied, this is definitely an improvement.
I'd like to
On Fri, 2006-01-13 at 17:24 -0500, John W. Linville wrote:
Radiotap headers make sense for an rfmon virtual device. I don't
think it makes sense for normal usage. Should there be an option
for radiotap headers on non-rfmon links?
Yes. For hardware debugging.
Rfmon interferes w/ other
This is a re-send since the lists ate my reply. I've also
trimmed out all but netdev and lkml email addresses.
Do global config requests go to any associated wlan device?
Or must they be directed to the WiPHY device? Does it matter?
I think we should require global configuration to target
On Fri, 2006-01-13 at 23:35 +0100, Johannes Berg wrote:
On Fri, 2006-01-13 at 17:24 -0500, John W. Linville wrote:
Radiotap headers make sense for an rfmon virtual device. I don't
think it makes sense for normal usage. Should there be an option
for radiotap headers on non-rfmon links?
On Friday 13 January 2006 15:32, John W. Linville wrote:
Do we need to have both wireless-stable and wireless-devel kernels?
What about the suggestion of having both stacks in the kernel at once?
I'm not very excited about two in-kernel stacks. Still, consolidating
wireless drivers down to
On Pá 13-01-06 09:55:33, Stephen Hemminger wrote:
On Thu, 12 Jan 2006 18:24:02 +0100
4. What about non-ieee80211 devices? With the growth of (mostly proprietary)
cell phone carrier wireless, you don't want to shut out that.
Don't mix it here. Mobile phones normally talk using AT
On Sat, 2006-01-14 at 00:23 +0100, Pavel Machek wrote:
On Pá 13-01-06 09:55:33, Stephen Hemminger wrote:
On Thu, 12 Jan 2006 18:24:02 +0100
4. What about non-ieee80211 devices? With the growth of (mostly proprietary)
cell phone carrier wireless, you don't want to shut out that.
Hello.
Well, basic idea is okay. But...
In article [EMAIL PROTECTED] (at Fri, 13 Jan 2006 14:14:48 -0800), Joe
Perches [EMAIL PROTECTED] says:
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 7129d42..dfb4f14 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@
John W. Linville [EMAIL PROTECTED] writes:
Virtual devices will have a mode (e.g. station, AP, WDS, ad-hoc, rfmon,
raw?, other modes?) which defines its on the air behaviour. Should
this mode be fixed when the wlan device is created?
I think so. If needed one can delete and create.
Or
In article [EMAIL PROTECTED] (at Fri, 13 Jan 2006 14:29:24 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
changes all code to use NIP6_FMT
fixes net/ipv6/ip6_flowlabel.c
:
This looks good, applied, thanks Joe.
As I have commented in another mail, the original patch breaks
From: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Date: Sat, 14 Jan 2006 09:12:13 +0900 (JST)
In article [EMAIL PROTECTED] (at Fri, 13 Jan 2006 14:29:24 -0800 (PST)),
David S. Miller [EMAIL PROTECTED] says:
changes all code to use NIP6_FMT
fixes net/ipv6/ip6_flowlabel.c
:
This looks
The latest version of the Intel e1000 driver use an implementation which
is incompatible with netpoll when compiled as NAPI enabled.
The netpoll_poll routines uses the parent netdev structure as the device
that gets polled:
poll_napi:
if (test_bit(__LINK_STATE_RX_SCHED, np-dev-state)
On 1/13/06, Mark Huth [EMAIL PROTECTED] wrote:
1) Have netpoll:napi_poll walk the poll list like the normal dev.c code
does. This seems simplest. I am concerned that it lets too much
activity go on for kgdboe and netdump, since all devices get serviced
that are on the poll list at the time
No new networking features for 2.6.16, submit only bug fixes please.
Thank you.
I may open up a net-2.6.17 tree right before I leave for New Zealand
or while I'm there for linux.conf.au (I leave on Jan 20th), but I want
to defer that as much as possible to get folks to concentrate on bug
This patch contains the following possible cleanups:
- make needlessly global code static
- arcnet.c: remove the unneeded EXPORT_SYMBOL(arc_proto_null)
- arcnet.c: remove the unneeded EXPORT_SYMBOL(arcnet_dump_packet)
To make Jeff happy, arcnet.c still prints
arcnet: v3.93 BETA 2000/04/29 - by
This patch makes some needlessly global code static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
This patch was already sent on:
- 5 Jan 2006
drivers/net/s2io.c | 22 +++---
drivers/net/s2io.h | 17 +++--
2 files changed, 18 insertions(+), 21 deletions(-)
This patch moves some code only used in this file to net/ipx/af_ipx.c .
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
This version was slightly adapted to apply against Linus' current tree.
include/net/p8022.h | 13 -
net/802/Makefile | 14 ++---
net/802/p8022.c |
This patch contains an attempt to properly build hostap.o without
#include'ing C files.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
---
This patch was already sent on:
- 5 Jan 2006
drivers/net/wireless/hostap/Makefile |3
drivers/net/wireless/hostap/hostap.h | 37
On Fri, Jan 13, 2006 at 08:28:13PM +0100, Sam Ravnborg wrote:
On Fri, Jan 13, 2006 at 08:23:16PM +0100, Jens Axboe wrote:
'select' is really cool as a concept, but when you can't figure out why
you cannot disable CONFIG_FOO because CONFIG_BAR selects it it's really
annoying. Would be
On Sat, 14 Jan 2006 03:29:49 +0100 Adrian Bunk wrote:
On Fri, Jan 13, 2006 at 08:28:13PM +0100, Sam Ravnborg wrote:
On Fri, Jan 13, 2006 at 08:23:16PM +0100, Jens Axboe wrote:
'select' is really cool as a concept, but when you can't figure out why
you cannot disable CONFIG_FOO
68 matches
Mail list logo