[RFC 2/6] qed: Add iSCSI out of order packet handling.

2016-10-18 Thread manish.rangankar
From: Yuval Mintz This patch adds out of order packet handling for hardware offloaded iSCSI. Out of order packet handling requires driver buffer allocation and assistance. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz

[RFC 5/6] qedi: Add support for iSCSI session management.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for iscsi_transport LLD Login, Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing and Firmware async event handling support. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi

[RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar The QLogic FastLinQ Driver for iSCSI (qedi) is the iSCSI specific module for 41000 Series Converged Network Adapters by QLogic. This patch consists of following changes: - MAINTAINERS Makefile and Kconfig changes for qedi, - PCI driver

[RFC 6/6] qedi: Add support for data path.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for data path and TMF handling. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis

[RFC 1/6] qed: Add support for hardware offloaded iSCSI.

2016-10-18 Thread manish.rangankar
From: Yuval Mintz This adds the backbone required for the various HW initalizations which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[RFC 0/6] Add QLogic FastLinQ iSCSI (qedi) driver.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This series introduces hardware offload iSCSI initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by Qlogic. The overall driver design includes a common module ('qed') and protocol specific dependent modules ('qedi'

[RFC 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

2016-10-18 Thread manish.rangankar
From: Manish Rangankar This patch adds support for iscsiuio interface using Light L2 (LL2) qed interface. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis

Re: [RFC PATCH net-next] bpf: fix potential percpu map overcopy to user.

2016-10-18 Thread William Tu
> ... >> - if (copy_to_user(uvalue, value, value_size) != 0) >> + if (copy_to_user(uvalue, value, min_t(u32, usize, value_size)) != 0) >> goto free_value; > > I think such approach won't actually fix anything. User space > may lose some of the values and won't have any idea

Re: [PATCH net-next v12 1/9] openvswitch: use hard_header_len instead of hardcoded ETH_HLEN

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > On tx, use hard_header_len while deciding whether to refragment or drop the > packet. That way, all combinations are calculated correctly: > > * L2 packet going to L2 interface (the L2 header len is subtracted), > * L2 packet

Re: [PATCH net-next v12 9/9] openvswitch: use ipgre tunnel rather than gretap tunnel

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > From: Simon Horman > > This allows GRE tunnels to send and receive both > layer 2 packets (packets with an ethernet header) and > layer 3 packets (packets without an ethernet header). > >

Re: [PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Support receiving, extracting flow key and sending of L3 packets (packets > without an Ethernet header). > > Note that even after this patch, non-Ethernet interfaces are still not > allowed to be added to bridges. Similarly,

Re: [PATCH net-next v12 4/9] openvswitch: support MPLS push and pop for L3 packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Update Ethernet header only if there is one. > > Signed-off-by: Jiri Benc Acked-by: Pravin B Shelar

Re: [PATCH net-next v12 3/9] openvswitch: pass mac_proto to ovs_vport_send

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > We'll need it to alter packets sent to ARPHRD_NONE interfaces. > > Change do_output() to use the actual L2 header size of the packet when > deciding on the minimum cutlen. The assumption here is that what matters is > not the

Re: [PATCH net-next v12 2/9] openvswitch: add mac_proto field to the flow key

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > Use a hole in the structure. We support only Ethernet so far and will add > a support for L2-less packets shortly. We could use a bool to indicate > whether the Ethernet header is present or not but the approach with the >

Re: [PATCH net-next v12 0/9] openvswitch: support for layer 3 encapsulated packets

2016-10-18 Thread Pravin Shelar
On Mon, Oct 17, 2016 at 6:02 AM, Jiri Benc wrote: > At the core of this patch set is removing the assumption in Open vSwitch > datapath that all packets have Ethernet header. Support for layer 3 GRE > tunnels is also added by this patchset. > > The implementation relies on the

Re: tg3 BUG: spinlock lockup suspected

2016-10-18 Thread Siva Reddy Kallam
On Mon, Oct 17, 2016 at 6:35 PM, Meelis Roos wrote: >> > Now I reproduced the bug even with 4.7-rc1 so it is older than 4.7. Will >> > test further. >> >> It gets stranger and stranger - my old 4.7 image worked fine, freshly >> compiled 4.7 exhibits the same problem. >> >>

bad commit touching stmmac_ptp.c

2016-10-18 Thread Nicolas Pitre
Hello, I noticed a recently added commit 7086605a6a ("stmmac: fix error check when init ptp") to the mainline linux tree from you. This commit is wrong. The affected code now reads as: int stmmac_ptp_register(struct stmmac_priv *priv) { spin_lock_init(>ptp_lock);

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

2016-10-18 Thread Herbert Xu
On Mon, Oct 17, 2016 at 06:21:14PM +0100, Ard Biesheuvel wrote: > > Annoyingly, all this complication with scatterlists etc is for doing > asynchronous crypto via DMA capable crypto accelerators, and the > networking code (ipsec as well as mac80211, afaik) only allow > synchronous in the first

[PATCH net-next 5/6] net: use core MTU range checking in virt drivers

2016-10-18 Thread Jarod Wilson
hyperv_net: - set min/max_mtu virtio_net: - set min/max_mtu - remove virtnet_change_mtu vmxnet3: - set min/max_mtu CC: netdev@vger.kernel.org CC: virtualizat...@lists.linux-foundation.org CC: "K. Y. Srinivasan" CC: Haiyang Zhang CC: "Michael S.

[PATCH net-next 6/6] net: use core MTU range checking in misc drivers

2016-10-18 Thread Jarod Wilson
firewire-net: - set min/max_mtu - remove fwnet_change_mtu nes: - set max_mtu - clean up nes_netdev_change_mtu xpnet: - set min/max_mtu - remove xpnet_dev_change_mtu hippi: - set min/max_mtu - remove hippi_change_mtu batman-adv: - set max_mtu - remove batadv_interface_change_mtu -

Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-18 Thread Jarod Wilson
On Tue, Oct 18, 2016 at 06:28:20PM -0400, Jarod Wilson wrote: > On Tue, Oct 18, 2016 at 11:33:27AM -0400, David Miller wrote: > > From: Jarod Wilson > > Date: Mon, 17 Oct 2016 16:29:43 -0400 > > > > > On Mon, Oct 17, 2016 at 04:03:41PM -0400, David Miller wrote: > > >> From:

[PATCH net-next 4/6] net: use core MTU range checking in core net infra

2016-10-18 Thread Jarod Wilson
geneve: - Merge __geneve_change_mtu back into geneve_change_mtu, set max_mtu - This one isn't quite as straight-forward as others, could use some closer inspection and testing macvlan: - set min/max_mtu tun: - set min/max_mtu, remove tun_net_change_mtu vxlan: - Merge __vxlan_change_mtu back

[PATCH net-next 2/6] net: use core MTU range checking in wireless drivers

2016-10-18 Thread Jarod Wilson
- set max_mtu in wil6210 driver - set max_mtu in atmel driver - set min/max_mtu in cisco airo driver, remove airo_change_mtu - set min/max_mtu in ipw2100/ipw2200 drivers, remove libipw_change_mtu - set min/max_mtu in p80211netdev, remove wlan_change_mtu CC: netdev@vger.kernel.org CC:

[PATCH net-next 3/6] net: use core MTU range checking in WAN drivers

2016-10-18 Thread Jarod Wilson
- set min/max_mtu in all hdlc drivers, remove hdlc_change_mtu - sent max_mtu in lec driver, remove lec_change_mtu CC: netdev@vger.kernel.org CC: Krzysztof Halasa CC: Krzysztof Halasa CC: Jan "Yenya" Kasprzak CC: Francois Romieu

[PATCH net-next 1/6] net: use core MTU range checking in USB NIC drivers

2016-10-18 Thread Jarod Wilson
- Remove stale new_mtu <= 0 check in usbnet.c - Set appropriate max_mtu for different r8152 driven variants - Set max_mtu in lan78xx driver CC: netdev@vger.kernel.org CC: Woojung Huh CC: Microchip Linux Driver Support CC: Hayes Wang

[PATCH net-next 0/6] net: use core MTU range checking everywhere

2016-10-18 Thread Jarod Wilson
This stack of patches should get absolutely everything in the kernel converted from doing their own MTU range checking to the core MTU range checking. Jarod Wilson (6): net: use core MTU range checking in USB NIC drivers net: use core MTU range checking in wireless drivers net: use core MTU

Re: [patch net] rtnetlink: Add rtnexthop offload flag to compare mask

2016-10-18 Thread Andy Gospodarek
On Tue, Oct 18, 2016 at 12:59 PM, Jiri Pirko wrote: > From: Jiri Pirko > > The offload flag is a status flag and should not be used by > FIB semantics for comparison. This is definitely needed. > > Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag

[PATCH net] tipc: Guard against tiny MTU in tipc_msg_build()

2016-10-18 Thread Ben Hutchings
Qian Zhang (张谦) reported a potential socket buffer overflow in tipc_msg_build(). The minimum fragment length needs to be checked against the maximum packet size, which is based on the link MTU. Reported-by: Qian Zhang (张谦) Signed-off-by: Ben Hutchings

Re: [PATCH 1/8] tools lib bpf: add error functions

2016-10-18 Thread Wangnan (F)
On 2016/10/19 6:52, Joe Stringer wrote: On 16 October 2016 at 14:18, Eric Leblond wrote: The include of err.h is not explicitely needed in exported functions and it was causing include conflict with some existing code due to redefining some macros. To fix this, let's have

Re: [RFC PATCH net-next] bpf: fix potential percpu map overcopy to user.

2016-10-18 Thread Alexei Starovoitov
On Sun, Oct 16, 2016 at 09:41:28AM -0700, William Tu wrote: > When running bpf_map_lookup on percpu elements, the bytes copied to > userspace depends on num_possible_cpus() * value_size, which could > potentially be larger than memory allocated from user, which depends > on

Hi

2016-10-18 Thread Sydney
I want to discuss with you please reply

Need help parsing dropwatch results

2016-10-18 Thread Timur Tabi
Using iperf3 and dropwatch, I discovered that my EMAC driver is dropping packets, a lot of them. This driver is based on an internal version (written by someone else) that does not have this problem, so obviously there's a bug in my driver. Unfortunately, I need help understanding where in

Re: [PATCH net] sched, cls: don't dump kernel addr into tc monitors on delete event

2016-10-18 Thread Cong Wang
On Tue, Oct 18, 2016 at 2:21 PM, Jamal Hadi Salim wrote: > I was sitting on this patch I was going to send ;-> > Does this resolve it? Your patch makes more sense to me. Maybe we can remove the event != RTM_DELTFILTER special case too?

Re: [PATCH 1/8] tools lib bpf: add error functions

2016-10-18 Thread Joe Stringer
On 16 October 2016 at 14:18, Eric Leblond wrote: > The include of err.h is not explicitely needed in exported > functions and it was causing include conflict with some existing > code due to redefining some macros. > > To fix this, let's have error handling functions provided by

Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-18 Thread Jarod Wilson
On Tue, Oct 18, 2016 at 11:33:27AM -0400, David Miller wrote: > From: Jarod Wilson > Date: Mon, 17 Oct 2016 16:29:43 -0400 > > > On Mon, Oct 17, 2016 at 04:03:41PM -0400, David Miller wrote: > >> From: Jarod Wilson > >> Date: Mon, 17 Oct 2016 15:54:02 -0400 >

Re: [PATCH net] sched, cls: don't dump kernel addr into tc monitors on delete event

2016-10-18 Thread Daniel Borkmann
On 10/19/2016 12:18 AM, Jamal Hadi Salim wrote: On 16-10-18 05:59 PM, Daniel Borkmann wrote: [...] Ahh sure, looks good to me. All other RTM_DELTFILTER events would be for the entire tcf_proto and 'enforced' destroy, so zero handle would indicate that then as opposed to a individual cls delete

Re: [PATCH net] sched, cls: don't dump kernel addr into tc monitors on delete event

2016-10-18 Thread Jamal Hadi Salim
On 16-10-18 05:59 PM, Daniel Borkmann wrote: Ahh sure, looks good to me. All other RTM_DELTFILTER events would be for the entire tcf_proto and 'enforced' destroy, so zero handle would indicate that then as opposed to a individual cls delete with non-zero handle. Seems fine. Ok, thanks. I will

Re: [PATCH net] sched, cls: don't dump kernel addr into tc monitors on delete event

2016-10-18 Thread Daniel Borkmann
On 10/18/2016 11:21 PM, Jamal Hadi Salim wrote: [...] I was sitting on this patch I was going to send ;-> Does this resolve it? Ahh sure, looks good to me. All other RTM_DELTFILTER events would be for the entire tcf_proto and 'enforced' destroy, so zero handle would indicate that then as

Re: [PATCH net] sched, cls: don't dump kernel addr into tc monitors on delete event

2016-10-18 Thread Jamal Hadi Salim
On 16-10-18 04:18 PM, Daniel Borkmann wrote: While trying out [1][2], I noticed that tc monitor doesn't show the correct handle on delete: $ tc monitor qdisc clsact : dev eno1 parent :fff1 filter dev eno1 ingress protocol all pref 49152 bpf handle 0x2a [...] deleted filter dev

[PATCH net] tcp: do not export sysctl_tcp_low_latency

2016-10-18 Thread Eric Dumazet
From: Eric Dumazet Since commit b2fb4f54ecd4 ("tcp: uninline tcp_prequeue()") we no longer access sysctl_tcp_low_latency from a module. Signed-off-by: Eric Dumazet --- net/ipv4/tcp_ipv4.c |1 - 1 file changed, 1 deletion(-) diff --git

[PATCH net] sched, cls: don't dump kernel addr into tc monitors on delete event

2016-10-18 Thread Daniel Borkmann
While trying out [1][2], I noticed that tc monitor doesn't show the correct handle on delete: $ tc monitor qdisc clsact : dev eno1 parent :fff1 filter dev eno1 ingress protocol all pref 49152 bpf handle 0x2a [...] deleted filter dev eno1 ingress protocol all pref 49152 bpf handle

Re: [PATCH net-next] openvswitch: remove unnecessary EXPORT_SYMBOLs

2016-10-18 Thread Pravin Shelar
On Tue, Oct 18, 2016 at 4:47 AM, Jiri Benc wrote: > Many symbols exported to other modules are really used only by > openvswitch.ko. Remove the exports. > > Tested by loading all 4 openvswitch modules, nothing breaks. > > Signed-off-by: Jiri Benc > --- >

Re: [PATCH net-next] bnx2x: ethtool -x full support

2016-10-18 Thread Eric Dumazet
On Tue, 2016-10-18 at 10:08 -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Implement ethtool -x full support, so that rss key can be fetched > instead of assuming it matches /proc/sys/net/core/netdev_rss_key > content. I'll send a V2, tested with CONFIG_BNX2X_SRIOV=y

Re: [PATCH v2 net-next 0/5] Interrupt support for mv88e6xxx

2016-10-18 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> mv88e6xxx_g1_* should've been moved to global1.c, I'll move them >> later. > > Hi Vivian > > I did consider that, but at the moment, there are only access > functions in there. But the code should be easy to move. True, looks good to me like

Re: [PATCH v2 net-next 0/5] Interrupt support for mv88e6xxx

2016-10-18 Thread Andrew Lunn
> mv88e6xxx_g1_* should've been moved to global1.c, I'll move them later. Hi Vivian I did consider that, but at the moment, there are only access functions in there. But the code should be easy to move. Andrew

Re: [PATCH v2 net-next 0/5] Interrupt support for mv88e6xxx

2016-10-18 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > This patchset add interrupt controller support to the MV88E6xxx. This > allows access to the interrupts the internal PHY generate. These > interrupts can then be associated to a PHY device in the device tree > and used by the PHY lib, rather

Re: iproute: ss truncates abstract unix domain socket embedding null

2016-10-18 Thread Isaac Boukris
Hi again, On Sun, Oct 16, 2016 at 11:43 PM, Isaac Boukris wrote: > Hello, > > The unix(7) man page says that null have no special meaning in > abstract unix domain socket address (the length is specified > therefore). > > However, when such name (embedding null) is used, ss

Re: [PATCH v3 net-next 8/8] net: qualcomm: add QCA7000 UART driver

2016-10-18 Thread David Miller
From: Stefan Wahren Date: Tue, 18 Oct 2016 13:27:34 +0200 > +void > +qca_tty_receive(struct tty_struct *tty, const unsigned char *cp, char *fp, > + int count) > +{ > + struct qcauart *qca = tty->disc_data; > + struct net_device_stats *n_stats =

Re: [PATCH v3 net-next 5/8] net: qualcomm: move MTU handling to qca_common

2016-10-18 Thread David Miller
From: Stefan Wahren Date: Tue, 18 Oct 2016 13:27:31 +0200 > The MTU of the QCA7000 is independent from it's host interface (UART,SPI). > So move the change_mtu function to qca_common. > > Signed-off-by: Stefan Wahren > --- >

Re: [PATCH v3 net-next 3/8] net: qualcomm: move qcaspi_tx_cmd to qca_spi.c

2016-10-18 Thread David Miller
From: Stefan Wahren Date: Tue, 18 Oct 2016 13:27:29 +0200 > diff --git a/drivers/net/ethernet/qualcomm/qca_7k.h > b/drivers/net/ethernet/qualcomm/qca_7k.h > index 1cad851..b390b1f 100644 > --- a/drivers/net/ethernet/qualcomm/qca_7k.h > +++

Re: [PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check

2016-10-18 Thread David Miller
From: Jiri Bohac Date: Tue, 18 Oct 2016 17:01:54 +0200 > Commit 76506a986dc31394fd1f2741db037d29c7e57843 (IPv6: fix > DESYNC_FACTOR) introduced a buggy check for underflow of > tmp_prefered_lft. tmp_prefered_lft is unsigned, so the condition > is always false. > > Signed-off-by:

Re: [PATCH net-next] r8152: add new products of Lenovo

2016-10-18 Thread David Miller
From: Hayes Wang Date: Tue, 18 Oct 2016 11:41:48 +0800 > Add the following four products of Lenovo and sort the order of the list. > > VID PID > 0x17ef 0x3062 > 0x17ef 0x3069 > 0x17ef 0x720c > 0x17ef

Re: [PATCH 2/3 net] ibmvnic: Fix GFP_KERNEL allocation in interrupt context

2016-10-18 Thread David Miller
From: Thomas Falcon Date: Mon, 17 Oct 2016 15:28:09 -0500 > Signed-off-by: Thomas Falcon Applied.

Re: [PATCH 1/1] net: vlan: Use sizeof instead of literal number

2016-10-18 Thread David Miller
From: f...@ikuai8.com Date: Tue, 18 Oct 2016 08:44:02 +0800 > From: Gao Feng > > Use sizeof variable instead of literal number to enhance the readability. > > Signed-off-by: Gao Feng Applied.

Re: [PATCH 20/28] net: bcm63xx: avoid referencing uninitialized variable

2016-10-18 Thread David Miller
From: Arnd Bergmann Date: Tue, 18 Oct 2016 00:16:08 +0200 > gcc found a reference to an uninitialized variable in the error handling > of bcm_enet_open, introduced by a recent cleanup: > > drivers/net/ethernet/broadcom/bcm63xx_enet.c: In function 'bcm_enet_open' >

Re: [PATCH 21/28] net/hyperv: avoid uninitialized variable

2016-10-18 Thread David Miller
From: Arnd Bergmann Date: Tue, 18 Oct 2016 00:16:09 +0200 > The hdr_offset variable is only if we deal with a TCP or UDP packet, > but as the check surrounding its usage tests for skb_is_gso() > instead, the compiler has no idea if the variable is initialized > or not at that

Re: [PATCH 27/28] rocker: fix maybe-uninitialized warning

2016-10-18 Thread David Miller
From: Arnd Bergmann Date: Tue, 18 Oct 2016 00:16:15 +0200 > In some rare configurations, we get a warning about the 'index' variable > being used without an initialization: > > drivers/net/ethernet/rocker/rocker_ofdpa.c: In function > ‘ofdpa_port_fib_ipv4.isra.16.constprop’: >

Re: [PATCH net] soreuseport: do not export reuseport_add_sock()

2016-10-18 Thread David Miller
From: Eric Dumazet Date: Mon, 17 Oct 2016 14:22:48 -0700 > From: Eric Dumazet > > reuseport_add_sock() is not used from a module, > no need to export it. > > Signed-off-by: Eric Dumazet Applied, thanks Eric.

Re: [PATCH 3/3 net] ibmvnic: Update MTU after device initialization

2016-10-18 Thread David Miller
From: Thomas Falcon Date: Mon, 17 Oct 2016 15:28:10 -0500 > It is possible for the MTU to be changed during the initialization > process with the VNIC Server. Ensure that the net device is updated > to reflect the new MTU. > > Signed-off-by: Thomas Falcon

Re: [PATCH 1/3 net v2] ibmvnic: Driver Version 1.0.1

2016-10-18 Thread David Miller
From: Thomas Falcon Date: Mon, 17 Oct 2016 15:56:29 -0500 > Increment driver version to reflect features that have > been added since release. > > Signed-off-by: Thomas Falcon Applied.

Re: [PATCH v3 0/4] support smc91x on mainstone and devicetree

2016-10-18 Thread David Miller
From: Robert Jarzmik Date: Mon, 17 Oct 2016 21:45:28 +0200 > This serie aims at bringing support to mainstone board on a device-tree based > build, as what is already in place for legacy mainstone. > > The bulk of the mainstone "specific" behavior is that a u16 write

Re: [PATCH v3 net-next 0/7] udp: Flow dissection for tunnels

2016-10-18 Thread David Miller
From: Tom Herbert Date: Tue, 18 Oct 2016 10:02:36 -0700 > v3: > - Fix build issues with modules that call IPv6 functions and > CONFIG_INET is not set. > - Fix compilation error in init'ing .flow_dissect in IPv6 UDP > offload. Still doesn't build:

Re: [PATCH net-next] ethernet/sfc: use core min/max MTU checking

2016-10-18 Thread David Miller
From: Bert Kenward Date: Tue, 18 Oct 2016 17:47:45 +0100 > Fixes: 61e84623 ("net: centralize net_device min/max MTU checking") > Signed-off-by: Bert Kenward Applied with Fixes tag fixed up to use a 12 character SHA1-ID.

Re: [PATCH net v2] bridge: multicast: restore perm router ports on multicast enable

2016-10-18 Thread David Miller
From: Nikolay Aleksandrov Date: Tue, 18 Oct 2016 18:09:48 +0200 > Satish reported a problem with the perm multicast router ports not getting > reenabled after some series of events, in particular if it happens that the > multicast snooping has been disabled and the

[PATCH net-next] bpf: Detect identical PTR_TO_MAP_VALUE_OR_NULL registers

2016-10-18 Thread Thomas Graf
A BPF program is required to check the return register of a map_elem_lookup() call before accessing memory. The verifier keeps track of this by converting the type of the result register from PTR_TO_MAP_VALUE_OR_NULL to PTR_TO_MAP_VALUE after a conditional jump ensures safety. This check is

Re: [PATCH net-next] ethernet/sfc: use core min/max MTU checking

2016-10-18 Thread Sergei Shtylyov
On 10/18/2016 07:47 PM, Bert Kenward wrote: Fixes: 61e84623 ("net: centralize net_device min/max MTU checking") The commit SHA1 should be at least 12 digits here. Signed-off-by: Bert Kenward [...] MBR, Sergei

Re: [PATCH -next] qed: Remove useless set memory to zero use memset()

2016-10-18 Thread Sergei Shtylyov
On 10/18/2016 06:54 PM, Wei Yongjun wrote: From: Wei Yongjun The memory return by kzalloc() has already be set to zero, so Returned? remove useless memset(0). Signed-off-by: Wei Yongjun [...] MBR, Sergei

[PATCH net-next] bnx2x: ethtool -x full support

2016-10-18 Thread Eric Dumazet
From: Eric Dumazet Implement ethtool -x full support, so that rss key can be fetched instead of assuming it matches /proc/sys/net/core/netdev_rss_key content. We might add "ethtool --rxfh" support later to set a different rss key. Tested: lpk51:~# ethtool --show-rxfh eth0

[PATCH v3 net-next 7/7] fou: Support flow dissection

2016-10-18 Thread Tom Herbert
This patch performs flow dissection for GUE and FOU. This is an optional feature on the receiver and is set by FOU_ATTR_DEEP_HASH netlink configuration. When enable the UDP socket flow_dissect function is set to fou_flow_dissect or gue_flow_dissect as appropriate. These functions return

[PATCH v3 net-next 6/7] udp: UDP tunnel flow dissection infrastructure

2016-10-18 Thread Tom Herbert
Add infrastructure to allow UDP tunnels to setup flow dissecion. Signed-off-by: Tom Herbert --- include/net/udp_tunnel.h | 5 + net/ipv4/udp_tunnel.c| 5 + 2 files changed, 10 insertions(+) diff --git a/include/net/udp_tunnel.h b/include/net/udp_tunnel.h index

[PATCH v3 net-next 5/7] udp: Add UDP flow dissection functions to IPv4 and IPv6

2016-10-18 Thread Tom Herbert
Add per protocol offload callbacks for flow_dissect to UDP for IPv4 and IPv6. The callback functions extract the port number information and with the packet addresses (given in an argument with type flow_dissector_key_addrs) it performs a lookup on the UDP socket. If a socket is found and

[PATCH v3 net-next 2/7] flow_dissector: Limit processing of next encaps and extensions

2016-10-18 Thread Tom Herbert
Flow dissector does not limit the number of encapsulated packets or IPv6 header extensions that will be processed. This could easily be suceptible to DOS attack-- for instance a 1500 byte packet could contain 75 IPIP headers. This patch places limits on the number of encapsulations and IPv6

[PATCH v3 net-next 1/7] ipv6: Fix Makefile conditional to use CONFIG_INET

2016-10-18 Thread Tom Herbert
ipv6 directory was being built based on CONFIG_NET not CONFIG_INET. Signed-off-by: Tom Herbert --- drivers/net/usb/cdc_mbim.c | 4 include/net/ipv6.h | 15 +++ include/net/net_namespace.h | 2 ++ net/Makefile| 2 +- 4 files

[PATCH v3 net-next 4/7] udp: UDP flow dissector

2016-10-18 Thread Tom Herbert
Add infrastructure for performing per protocol flow dissection and support flow dissection in UDP payloads (e.g. flow dissection on a UDP encapsulated tunnel. The per protocol flow dissector is called by flow_dissect function in the offload_callbacks of a protocol. The arguments of this function

[PATCH v3 net-next 0/7] udp: Flow dissection for tunnels

2016-10-18 Thread Tom Herbert
Now that we have a means to perform a UDP socket lookup without taking a reference, it is feasible to have flow dissector crack open UDP encapsulated packets. Generally, we would expect that the UDP source port or the flow label in IPv6 would contain enough entropy about the encapsulated flow.

[PATCH v3 net-next 3/7] udp: Add socket lookup functions with noref

2016-10-18 Thread Tom Herbert
Create udp4_lib_lookup_noref and udp6_lib_lookup_noref. These perfrom a socket lookup on addresses and ports without taking a reference. Signed-off-by: Tom Herbert --- include/net/udp.h | 8 net/ipv4/udp.c| 8 net/ipv6/udp.c| 10 ++ 3

[patch net] rtnetlink: Add rtnexthop offload flag to compare mask

2016-10-18 Thread Jiri Pirko
From: Jiri Pirko The offload flag is a status flag and should not be used by FIB semantics for comparison. Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload") Signed-off-by: Jiri Pirko --- Please queue-up to stable as well. Thanks.

Re: [patch net 1/6] switchdev: Execute bridge ndos only for bridge ports

2016-10-18 Thread Jiri Pirko
That's it. Only one patch :)

[patch net 1/6] switchdev: Execute bridge ndos only for bridge ports

2016-10-18 Thread Jiri Pirko
From: Ido Schimmel We recently got the following warning after setting up a vlan device on top of an offloaded bridge and executing 'bridge link': WARNING: CPU: 0 PID: 18566 at drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c:81

[PATCH net-next] ethernet/sfc: use core min/max MTU checking

2016-10-18 Thread Bert Kenward
Fixes: 61e84623 ("net: centralize net_device min/max MTU checking") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/sfc/efx.c

Re: [PATCH v3 4/4] net: smsc91x: add u16 workaround for pxa platforms

2016-10-18 Thread Rob Herring
On Mon, Oct 17, 2016 at 09:45:32PM +0200, Robert Jarzmik wrote: > Add a workaround for mainstone, idp and stargate2 boards, for u16 writes > which must be aligned on 32 bits addresses. > > Signed-off-by: Robert Jarzmik > Cc: Jeremy Linton > --- >

[PATCH net v2] bridge: multicast: restore perm router ports on multicast enable

2016-10-18 Thread Nikolay Aleksandrov
Satish reported a problem with the perm multicast router ports not getting reenabled after some series of events, in particular if it happens that the multicast snooping has been disabled and the port goes to disabled state then it will be deleted from the router port list, but if it moves into

Re: [PATCH net v2 0/3] Tunneling fixes

2016-10-18 Thread Juerg Haefliger
> This series fixes a problem that was reported where encapsulated packets > do not have their encapsulation offload markers stripped off when being > decapsulated. This causes a significant performance drop if the packets > are later retransmitted. > > Fixing this revealed two other bugs which

Re: [PATCH v3 net-next 00/11] net: Fix netdev adjacency tracking

2016-10-18 Thread David Ahern
On 10/18/16 9:46 AM, David Miller wrote: > Series applied, but the recursion is disappointing. > > If we run into problems due to kernel stack depth because of this with > some configurations (reasonable or not, if we allow it then it can't > crash the kernel), we will either need to find a way

Re: [PATCH v5 0/4] Add support for led triggers on phy link state change

2016-10-18 Thread David Miller
From: Zach Brown Date: Mon, 17 Oct 2016 10:49:51 -0500 > Fix skge driver that declared enum contants that conflicted with enum > constants in linux/leds.h > > Create function that encapsulates actions taken during the adjust phy link > step > of phy state changes. > >

Re: [PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warning

2016-10-18 Thread Andrew Lunn
On Tue, Oct 18, 2016 at 03:53:37PM +, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/dsa/mv88e6xxx/chip.c:2866:5: warning: > symbol 'mv88e6xxx_g1_set_switch_mac' was not declared. Should it be static? > >

[PATCH -next] qed: Remove useless set memory to zero use memset()

2016-10-18 Thread Wei Yongjun
From: Wei Yongjun The memory return by kzalloc() has already be set to zero, so remove useless memset(0). Signed-off-by: Wei Yongjun --- drivers/net/ethernet/qlogic/qed/qed_roce.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH -next] net: dsa: mv88e6xxx: fix non static symbol warning

2016-10-18 Thread Wei Yongjun
From: Wei Yongjun Fixes the following sparse warning: drivers/net/dsa/mv88e6xxx/chip.c:2866:5: warning: symbol 'mv88e6xxx_g1_set_switch_mac' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/dsa/mv88e6xxx/chip.c

Re: [PATCH v2 net-next 0/7] udp: Flow dissection for tunnels

2016-10-18 Thread David Miller
From: David Miller Date: Tue, 18 Oct 2016 11:48:37 -0400 (EDT) > Series applied, thanks Tom. Actually, reverted. Tom, would you mind build testing with ipv6 enabled? :-) net/ipv6/udp_offload.c:208:19: error: initialization from incompatible pointer type

Re: [PATCH v2 net-next 0/7] udp: Flow dissection for tunnels

2016-10-18 Thread David Miller
From: Tom Herbert Date: Mon, 17 Oct 2016 12:41:55 -0700 > Now that we have a means to perform a UDP socket lookup without taking > a reference, it is feasible to have flow dissector crack open UDP > encapsulated packets. Generally, we would expect that the UDP source > port

Re: [PATCH v3 net-next 00/11] net: Fix netdev adjacency tracking

2016-10-18 Thread David Miller
From: David Ahern Date: Mon, 17 Oct 2016 19:15:42 -0700 > The netdev adjacency tracking is failing to create proper dependencies > for some topologies. For example this topology ... > hits 1 of 2 problems depending on the order of enslavement. The base set of >

Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-18 Thread David Miller
From: Jarod Wilson Date: Mon, 17 Oct 2016 15:54:02 -0400 > Now that the network stack core min/max MTU checking infrastructure is in > place, time to start making drivers use it. We'll start with the easiest > ones, the ethernet drivers, split roughly by vendor, with a

Re: [PATCH net-next 0/2] Move to BPF selftests

2016-10-18 Thread David Miller
From: Daniel Borkmann Date: Mon, 17 Oct 2016 14:28:34 +0200 > This set improves the test_verifier and test_maps suite and moves > it over to a new BPF selftest directory, so we can keep improving > it under kernel selftest umbrella. This also integrates a test > script for

Re: [PATCH net-next 00/15] ethernet: use core min/max MTU checking

2016-10-18 Thread David Miller
From: Jarod Wilson Date: Mon, 17 Oct 2016 16:29:43 -0400 > On Mon, Oct 17, 2016 at 04:03:41PM -0400, David Miller wrote: >> From: Jarod Wilson >> Date: Mon, 17 Oct 2016 15:54:02 -0400 >> >> > For the most part, every patch does the same essential thing:

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-18 Thread Michal Hocko
On Thu 13-10-16 01:20:10, Lorenzo Stoakes wrote: > This patch series adjusts functions in the get_user_pages* family such that > desired FOLL_* flags are passed as an argument rather than implied by flags. > > The purpose of this change is to make the use of FOLL_FORCE explicit so it is > easier

Re: [PATCH 01/28] [v2] netfilter: nf_tables: avoid uninitialized variable warning

2016-10-18 Thread Pablo Neira Ayuso
On Tue, Oct 18, 2016 at 12:05:30AM +0200, Arnd Bergmann wrote: > The newly added nft_range_eval() function handles the two possible > nft range operations, but as the compiler warning points out, > any unexpected value would lead to the 'mismatch' variable being > used without being initialized: >

Re: [PATCH net-next 09/15] ethernet/dlink: use core min/max MTU checking

2016-10-18 Thread Jarod Wilson
On Tue, Oct 18, 2016 at 04:45:51PM +0300, Denis Kirjanov wrote: > On 10/17/16, Jarod Wilson wrote: > > dl2k: min_mtu 68, max_mtu 1536 or 8000, depending on hardware > > - Removed change_mtu, does nothing productive anymore > > > > sundance: min_mtu 68, max_mtu 8191 > > > > CC:

[PATCH] ipv6: fix signedness of tmp_prefered_lft underflow check

2016-10-18 Thread Jiri Bohac
Commit 76506a986dc31394fd1f2741db037d29c7e57843 (IPv6: fix DESYNC_FACTOR) introduced a buggy check for underflow of tmp_prefered_lft. tmp_prefered_lft is unsigned, so the condition is always false. Signed-off-by: Jiri Bohac Reported-by: Julia Lawall Fixes:

Re: [PATCH v5 4/4] net: phy: leds: add support for led triggers on phy link state change

2016-10-18 Thread Zach Brown
On Tue, Oct 18, 2016 at 09:13:50AM +0200, Andrew Lunn wrote: > On Mon, Oct 17, 2016 at 10:49:55AM -0500, Zach Brown wrote: > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will create a > > set of led triggers for each instantiated PHY device. There is one LED > > trigger per

Re: [PATCH v4 0/4] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm

2016-10-18 Thread David Miller
From: Mugunthan V N Date: Tue, 18 Oct 2016 16:50:16 +0530 > Add support for configurable impedance control for TI dp83867 > phy via devicetree. More documentation in [1]. > CPSW second ethernet is not working, fix it by enabling > impedance configuration on the phy. Series

  1   2   >