Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-22 Thread Zong Li
2018-02-23 3:57 GMT+08:00 Anders Roxell : > On 22 February 2018 at 12:53, Zong Li wrote: >> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig >> to ease disabling it all")', the make kselftest-merge cannot merge the >> config

[PATCH bpf-next] bpf: NULL pointer check is not needed in BPF_CGROUP_RUN_PROG_INET_SOCK

2018-02-22 Thread Yafang Shao
sk is already allocated in inet_create/inet6_create, hence when BPF_CGROUP_RUN_PROG_INET_SOCK is executed sk will never be NULL. The logic is as bellow, sk = sk_alloc(); if (!sk) goto out; BPF_CGROUP_RUN_PROG_INET_SOCK(sk); Signed-off-by: Yafang Shao

[PATCH net-next] net/ncsi: Add generic netlink family

2018-02-22 Thread Samuel Mendoza-Jonas
Add a generic netlink family for NCSI. This supports two commands; NCSI_CMD_PKG_INFO which returns information on packages and their associated channels, and NCSI_CMD_SET_INTERFACE which allows a specific package or package/channel combination to be set as the preferred choice. Signed-off-by:

[PATCH v2 net] net_sched: gen_estimator: fix broken estimators based on percpu stats

2018-02-22 Thread Eric Dumazet
From: Eric Dumazet pfifo_fast got percpu stats lately, uncovering a bug I introduced last year in linux-4.10. I missed the fact that we have to clear our temporary storage before calling __gnet_stats_copy_basic() in the case of percpu stats. Without this fix, rate

Re: [PATCH net] net_sched: gen_estimator: fix broken estimators based on percpu stats

2018-02-22 Thread Eric Dumazet
On Thu, 2018-02-22 at 19:36 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > pfifo_fast got percpu stats lately, uncovering a bug I introduced last > year in linux-4.10. > > I missed the fact that we have to clear our temporary storage > before calling

[PATCH net] net_sched: gen_estimator: fix broken estimators based on percpu stats

2018-02-22 Thread Eric Dumazet
From: Eric Dumazet pfifo_fast got percpu stats lately, uncovering a bug I introduced last year in linux-4.10. I missed the fact that we have to clear our temporary storage before calling __gnet_stats_copy_basic() in the case of percpu stats. Without this fix, rate

Re: [PATCH V7 2/4] sctp: Add ip option support

2018-02-22 Thread Marcelo Ricardo Leitner
On Thu, Feb 22, 2018 at 06:08:05PM -0500, Paul Moore wrote: > On Wed, Feb 21, 2018 at 3:45 PM, Paul Moore wrote: > > On February 21, 2018 9:33:51 AM Marcelo Ricardo Leitner > > wrote: > >> On Tue, Feb 20, 2018 at 07:15:27PM +, Richard Haines

Re: [pull request][for-next 0/7] Mellanox, mlx5 shared code updates 2018-02-21

2018-02-22 Thread Doug Ledford
On Thu, 2018-02-22 at 14:39 -0500, David Miller wrote: > From: Saeed Mahameed > Date: Wed, 21 Feb 2018 12:13:47 -0800 > > > This series includes shared code updates for mlx5 core driver for both > > netdev and rdma subsystems. This series should be pulled to both > > trees

Re: [PATCH net v3 2/2] tuntap: correctly add the missing xdp flush

2018-02-22 Thread Jason Wang
On 2018年02月23日 01:46, Jesper Dangaard Brouer wrote: On Thu, 22 Feb 2018 17:36:46 +0800 Jason Wang wrote: Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and

pull-request: bpf 2018-02-22

2018-02-22 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) two urgent fixes for bpf_tail_call logic for x64 and arm64 JITs, from Daniel. 2) cond_resched points in percpu array alloc/free paths, from Eric. 3) lockdep and other minor fixes, from

Re: [PATCH bpf] bpf, arm64: fix out of bounds access in tail call

2018-02-22 Thread Alexei Starovoitov
On Fri, Feb 23, 2018 at 01:03:43AM +0100, Daniel Borkmann wrote: > I recently noticed a crash on arm64 when feeding a bogus index > into BPF tail call helper. The crash would not occur when the > interpreter is used, but only in case of JIT. Output looks as > follows: > > [ 347.007486] Unable

Re: [for-next 7/7] IB/mlx5: Implement fragmented completion queue (CQ)

2018-02-22 Thread Santosh Shilimkar
Hi Saeed On 2/21/2018 12:13 PM, Saeed Mahameed wrote: From: Yonatan Cohen The current implementation of create CQ requires contiguous memory, such requirement is problematic once the memory is fragmented or the system is low in memory, it causes for failures in

[PATCH bpf] bpf, arm64: fix out of bounds access in tail call

2018-02-22 Thread Daniel Borkmann
I recently noticed a crash on arm64 when feeding a bogus index into BPF tail call helper. The crash would not occur when the interpreter is used, but only in case of JIT. Output looks as follows: [ 347.007486] Unable to handle kernel paging request at virtual address fffb850e96492510 [...]

Re: [PATCH net-next] rds: rds_msg_zcopy should return error of null rm->data.op_mmp_znotifier

2018-02-22 Thread Santosh Shilimkar
On 2/22/2018 1:40 PM, Sowmini Varadhan wrote: if either or both of MSG_ZEROCOPY and SOCK_ZEROCOPY have not been specified, the rm->data.op_mmp_znotifier allocation will be skipped. In this case, it is invalid ot pass down a cmsghdr with RDS_CMSG_ZCOPY_COOKIE, so return EINVAL from rds_msg_zcopy

Re: [PATCH net-next v2 1/1] net: Allow a rule to track originating protocol

2018-02-22 Thread David Ahern
On 2/22/18 10:20 AM, David Ahern wrote: >> This breaks my scripts: >> # ip -4 rule show >> 0: from all lookup local >> 32766: from all lookup main >> 32767: from all lookup default >> >> # ip -4 rule del pref 0 >> RTNETLINK answers: No such file or directory >> >> Using iproute 4.15 in

[PATCH v8 0/3] netdev: octeon-ethernet: Add Cavium Octeon III support.

2018-02-22 Thread David Daney
We are adding the Cavium OCTEON-III network driver. Since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. The four patch set to add this prerequisite code has been split out to a seperate patch

Re: [PATCH bpf v2] bpf, x64: implement retpoline for tail call

2018-02-22 Thread Alexei Starovoitov
On Thu, Feb 22, 2018 at 03:12:53PM +0100, Daniel Borkmann wrote: > Implement a retpoline [0] for the BPF tail call JIT'ing that converts > the indirect jump via jmp %rax that is used to make the long jump into > another JITed BPF image. Since this is subject to speculative execution, > we need to

[PATCH v8 1/3] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2018-02-22 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Acked-by: Rob Herring Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

[PATCH v8 3/3] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2018-02-22 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a7f76eadae9..b36371ae590f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3259,6 +3259,12 @@ W: http://www.cavium.com S:

[PATCH v8 0/4] Prerequisites for Cavium OCTEON-III network driver.

2018-02-22 Thread David Daney
We want to add the Cavium OCTEON-III network driver. But since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. Aren't SoCs nice in this way? These are the prerequisite patches that are needed

[PATCH v8 2/4] MIPS: Octeon: Automatically provision CVMSEG space.

2018-02-22 Thread David Daney
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate the amount of CVMSEG space needed. 1st 128-bytes: Use by IOBDMA 2nd 128-bytes: Reserved by kernel for scratch/TLS emulation. 3rd 128-bytes: OCTEON-III LMTLINE New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions

[PATCH v8 3/4] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2018-02-22 Thread David Daney
Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by the change. Acked-by: Greg Kroah-Hartman Signed-off-by: David Daney ---

[PATCH v8 1/4] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2018-02-22 Thread David Daney
From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O device. * LMTDMA operations can send an address and a variable length (up to 128) of data

Re: [PATCH V7 2/4] sctp: Add ip option support

2018-02-22 Thread Paul Moore
On Wed, Feb 21, 2018 at 3:45 PM, Paul Moore wrote: > On February 21, 2018 9:33:51 AM Marcelo Ricardo Leitner > wrote: >> On Tue, Feb 20, 2018 at 07:15:27PM +, Richard Haines wrote: >>> Add ip option support to allow LSM security modules to

[PATCH v8 4/4] MIPS: Octeon: Add a global resource manager.

2018-02-22 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J.

Re: [PATCH iproute2 net-next] ss: print skmeminfo for packet sockets

2018-02-22 Thread David Ahern
On 2/21/18 10:37 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > before: > $ss --packet -p -m > p_raw0 0*:eth0 > users:(("lldpd",pid=2240,fd=11)) > > after: > $ss --packet -p -m > p_raw0 0

Re: [PATCH iproute2-next v1] rdma: Add batch command support

2018-02-22 Thread David Ahern
On 2/22/18 12:28 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > Implement an option (-b) to execute RDMAtool commands > from supplied file. This follows the same model as > in use for ip and devlink tools, by expecting > every new command to be on new line. > >

Re: [PATCH net-next] rds: rds_msg_zcopy should return error of null rm->data.op_mmp_znotifier

2018-02-22 Thread Willem de Bruijn
On Thu, Feb 22, 2018 at 4:40 PM, Sowmini Varadhan wrote: > if either or both of MSG_ZEROCOPY and SOCK_ZEROCOPY have not been > specified, the rm->data.op_mmp_znotifier allocation will be skipped. > In this case, it is invalid ot pass down a cmsghdr with >

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-22 Thread Jason A. Donenfeld
Thanks! Jason

RE: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Bryan.Whitehead
> On Thu, Feb 22, 2018 at 10:45:34PM +0100, Andrew Lunn wrote: > > > Also I'm allocating interrupt resources on interface up, and freeing > > > resources on interface down. So if there is an up, down, up sequence > > > then the driver will allocate resources twice. In order for devm to > > > work

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Florian Fainelli
On 02/21/2018 11:06 AM, Bryan Whitehead wrote: > Add main source files for new lan743x driver. > > Signed-off-by: Bryan Whitehead > --- > +lan743x-objs := lan743x_main.o Should we assume that you have additional object files you would like to contribute at a

Re: [RFC PATCH V2] virtio_pci: Add SR-IOV support

2018-02-22 Thread Rustad, Mark D
> On Feb 22, 2018, at 10:26 AM, Christoph Hellwig wrote: > > Can we move this into common code as a a generic_sriov_configure > helper? Nothing is really virtio specific, and it seems like > some other drivers could also use it, e.g. ena or nvme. That seems like a good idea

[PATCH net-next] rds: rds_msg_zcopy should return error of null rm->data.op_mmp_znotifier

2018-02-22 Thread Sowmini Varadhan
if either or both of MSG_ZEROCOPY and SOCK_ZEROCOPY have not been specified, the rm->data.op_mmp_znotifier allocation will be skipped. In this case, it is invalid ot pass down a cmsghdr with RDS_CMSG_ZCOPY_COOKIE, so return EINVAL from rds_msg_zcopy for this case. Reported-by:

[PATCH 2/2] arm: mvebu: 370-rd: Enable PHY interrupt handling

2018-02-22 Thread Andrew Lunn
The Ethernet switch has an embedded interrupt controller. Interrupts from the embedded PHYs are part of this interrupt controller. Explicitly list the MDIO bus the embedded PHYs are on, and wire up the interrupts. Signed-off-by: Andrew Lunn ---

[PATCH 0/2] mv88e6xxx: Poll when no interrupt defined

2018-02-22 Thread Andrew Lunn
Not all boards using the mv88e6xxx switches have the interrupt output connected to a GPIO. On these boards phylib has to poll the PHYs, rather than use interrupts. Have the driver poll the interrupt status register, which is more efficient than having phylib do it. And it enables other switch

[PATCH 1/2] net: dsa: mv88e6xxx: Poll when no interrupt defined

2018-02-22 Thread Andrew Lunn
Not all boards have the interrupt output from the switch connected to a GPIO line. In such cases, phylib has to poll the internal PHYs, rather than receive an interrupt when there is a change in the link state. phylib polls once per second, and per PHY reads around 4 words. With a switch typically

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-22 Thread David Ahern
On 2/22/18 1:55 PM, Ido Schimmel wrote: > On Thu, Feb 22, 2018 at 12:27:35PM -0700, David Ahern wrote: >> Ido: >> >> IPv4 works at boot; IPv6 requires the mcast snooping disable. For this >> vlan-unaware bridges can that be set automatically? > > Can you please try the following patch? > ... >

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Andrew Lunn
On Thu, Feb 22, 2018 at 10:45:34PM +0100, Andrew Lunn wrote: > > Also I'm allocating interrupt resources on interface up, and freeing > > resources > > on interface down. So if there is an up, down, up sequence then the driver > > will allocate resources twice. In order for devm to work properly,

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Andrew Lunn
> Also I'm allocating interrupt resources on interface up, and freeing resources > on interface down. So if there is an up, down, up sequence then the driver > will allocate resources twice. In order for devm to work properly, should I > move all resource allocation into the probe function? Hi

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Florian Fainelli
On 02/22/2018 01:31 PM, bryan.whiteh...@microchip.com wrote: >>> +static void lan743x_intr_unregister_isr(struct lan743x_adapter *adapter, >>> + int vector_index) >>> +{ >>> + struct lan743x_vector *vector = >intr.vector_list >>> +

RE: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Bryan.Whitehead
> > +static void lan743x_intr_unregister_isr(struct lan743x_adapter *adapter, > > + int vector_index) > > +{ > > + struct lan743x_vector *vector = >intr.vector_list > > + [vector_index]; > > + > > +

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-22 Thread Alexander Duyck
On Thu, Feb 22, 2018 at 12:11 AM, Jiri Pirko wrote: > Wed, Feb 21, 2018 at 09:57:09PM CET, alexander.du...@gmail.com wrote: >>On Wed, Feb 21, 2018 at 11:38 AM, Jiri Pirko wrote: >>> Wed, Feb 21, 2018 at 06:56:35PM CET, alexander.du...@gmail.com wrote: On

Re: [PATCH v2 iproute2-next 2/3] ip: Display ip rule protocol used

2018-02-22 Thread David Ahern
On 2/21/18 7:12 PM, Donald Sharp wrote: > diff --git a/ip/iprule.c b/ip/iprule.c > index 00a6c26a..39008768 100644 > --- a/ip/iprule.c > +++ b/ip/iprule.c > @@ -47,6 +47,7 @@ static void usage(void) > "[ iif STRING ] [ oif STRING ] [ pref NUMBER ] [ > l3mdev ]\n" >

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-22 Thread Ido Schimmel
On Thu, Feb 22, 2018 at 12:27:35PM -0700, David Ahern wrote: > Ido: > > IPv4 works at boot; IPv6 requires the mcast snooping disable. For this > vlan-unaware bridges can that be set automatically? Can you please try the following patch? diff --git

Re: [PATCH] dsa: ptp; mark dummy helpers as 'inline'

2018-02-22 Thread David Miller
From: Arnd Bergmann Date: Thu, 22 Feb 2018 12:44:40 +0100 > Declaring a static function in a header leads to a warning every > time that header gets included without the function being used: > > In file included from drivers/net/dsa/mv88e6xxx/chip.c:42: >

[PATCH net-next] r8169: simplify and improve check for dash

2018-02-22 Thread Heiner Kallweit
r8168_check_dash() returns false anyway for all chip versions not supporting dash. So we can simplify the check conditions. In addition change the check functions to return bool instead of int, because they actually return a bool value. Signed-off-by: Heiner Kallweit ---

Re: [PATCH net] net: aquantia: Fix error handling in aq_pci_probe()

2018-02-22 Thread David Miller
From: Dan Carpenter Date: Thu, 22 Feb 2018 12:11:55 +0300 > We should check "self->aq_hw" for allocation failure, and also we should > free it on the error paths. > > Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") > Signed-off-by: Dan Carpenter

Re: [PATCH] bpf: add schedule points in percpu arrays management

2018-02-22 Thread Daniel Borkmann
[ +Dennis for mm/pcpu ] On 02/22/2018 05:33 PM, Eric Dumazet wrote: > From: Eric Dumazet > > syszbot managed to trigger RCU detected stalls in > bpf_array_free_percpu() > > It takes time to allocate a huge percpu map, but even more time to free > it. > > Since we run in

Re: [PATCH bpf v2] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread Daniel Borkmann
On 02/22/2018 07:10 PM, Yonghong Song wrote: > Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback > function") > fixed a memory leak and removed unnecessary locks in map_free callback > function. > Unfortrunately, it introduced a lockdep warning. When lockdep checking is >

Re: [PATCH net-next 0/3] nfp: build and FW initramfs updates

2018-02-22 Thread David Miller
From: Jakub Kicinski Date: Wed, 21 Feb 2018 19:50:04 -0800 > This set brings empty makefiles to allow building single object files > (useful for build-testing), Kbuild does not cater to this use case > too well. There are two ethernet drivers right now which suffer

[PATCH net-next] r8169: disable WOL per default

2018-02-22 Thread Heiner Kallweit
Currently, if BIOS enables WOL in the chip, settings are inconsistent because the device isn't marked as wakeup-enabled (if not done explicitly via userspace tools). This causes issues with suspend/ resume because mdio_bus_phy_may_suspend() checks whether device is wakeup-enabled. In detail MDIO

Re: pull-request: mac80211-next 2018-02-22

2018-02-22 Thread Johannes Berg
On Thu, 2018-02-22 at 15:19 -0500, David Miller wrote: > From: Johannes Berg > Date: Thu, 22 Feb 2018 21:16:18 +0100 > > > Wireless is slow ... but we're preparing for HE (802.11ax), > > so I guess soon we'll have a big chunk of work coming :-) > > I wondered where

Re: pull-request: mac80211-next 2018-02-22

2018-02-22 Thread David Miller
From: Johannes Berg Date: Thu, 22 Feb 2018 21:16:18 +0100 > Wireless is slow ... but we're preparing for HE (802.11ax), > so I guess soon we'll have a big chunk of work coming :-) I wondered where you guys have been hiding :-) > Please pull and let me know if there's

Re: pull-request: mac80211 2018-02-22

2018-02-22 Thread David Miller
From: Johannes Berg Date: Thu, 22 Feb 2018 21:08:39 +0100 > A bunch of fixes, including the nla_put_string() issue > just in from Kees. Otherwise nothing really super urgent > or interesting. > > Please pull and let me know if there's any problem. Pulled. Thanks for

pull-request: mac80211-next 2018-02-22

2018-02-22 Thread Johannes Berg
Hi Dave, Wireless is slow ... but we're preparing for HE (802.11ax), so I guess soon we'll have a big chunk of work coming :-) Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 91e6dd8284256ef62b43b78da6e7684e4f06ac2f: ipmr: Fix

pull-request: mac80211 2018-02-22

2018-02-22 Thread Johannes Berg
Hi Dave, A bunch of fixes, including the nla_put_string() issue just in from Kees. Otherwise nothing really super urgent or interesting. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit ba804bb4b72e57374b5f567b783aa0298fba0ce6: Merge

Re: [PATCH net-next] ibmvnic: Split counters for scrq/pools/napi

2018-02-22 Thread David Miller
From: Nathan Fontenot Date: Wed, 21 Feb 2018 21:33:56 -0600 > The approach of one counter to rule them all when tracking the number > of active sub-crqs, pools, and napi has problems handling some failover > scenarios. This is due to the split in initializing the sub

Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-22 Thread Anders Roxell
On 22 February 2018 at 12:53, Zong Li wrote: > Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig > to ease disabling it all")', the make kselftest-merge cannot merge the > config dependencies of kselftest to the existing .config file. > > These config

Re: nla_put_string() vs NLA_STRING

2018-02-22 Thread Johannes Berg
On Tue, 2018-02-20 at 22:00 -0800, Kees Cook wrote: > It seems that in at least one case[1], nla_put_string() is being used > on an NLA_STRING, which lacks a NULL terminator, which leads to > silliness when nla_put_string() uses strlen() to figure out the size: Fun! I'm not a big fan of the

Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-22 Thread Luis R. Rodriguez
On Thu, Feb 22, 2018 at 07:53:07PM +0800, Zong Li wrote: > Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig > to ease disabling it all")', the make kselftest-merge cannot merge the > config dependencies of kselftest to the existing .config file. > > These config dependencies

Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: scratch registers and external MDIO pins

2018-02-22 Thread David Miller
From: Andrew Lunn Date: Thu, 22 Feb 2018 01:51:49 +0100 > MV88E6352 and later switches support GPIO control through the "Scratch > & Misc" global2 register. Two of the pins controlled this way on the > mv88e6390 family are the external MDIO pins. They can either by used > as part

Re: [PATCH net] ibmvnic: Fix early release of login buffer

2018-02-22 Thread David Miller
From: Thomas Falcon Date: Wed, 21 Feb 2018 18:18:30 -0600 > The login buffer is released before the driver can perform > sanity checks between resources the driver requested and what > firmware will provide. Don't release the login buffer until > the sanity check is

Re: [PATCH net-next] ibmvnic: Fix TX descriptor tracking

2018-02-22 Thread David Miller
From: Thomas Falcon Date: Wed, 21 Feb 2018 18:21:10 -0600 > With the recent change, transmissions that only needed > one descriptor were being missed. The result is that such > packets were tracked as outstanding transmissions but never > removed when its completion

Re: [PATCH] net/smc9194: Remove bogus CONFIG_MAC reference

2018-02-22 Thread David Miller
From: Finn Thain Date: Thu, 22 Feb 2018 09:24:59 +1100 (AEDT) > AFAIK the only version of smc9194.c with Mac support is the one in the > linux-mac68k CVS repo, which never made it to the mainline. > > Despite that, from v2.3.45, arch/m68k/config.in listed

Re: [PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-22 Thread David Miller
From: David Ahern Date: Thu, 22 Feb 2018 12:31:01 -0700 > On 2/22/18 12:27 PM, David Miller wrote: >> From: David Ahern >> Date: Wed, 21 Feb 2018 10:49:47 -0800 >> >>> Patch 5 adds the L4 hash support. >> >> Please address Ido's feedback about how the

Re: [pull request][for-next 0/7] Mellanox, mlx5 shared code updates 2018-02-21

2018-02-22 Thread David Miller
From: Saeed Mahameed Date: Wed, 21 Feb 2018 12:13:47 -0800 > This series includes shared code updates for mlx5 core driver for both > netdev and rdma subsystems. This series should be pulled to both > trees so we can continue netdev and rdma specific submissions separately.

[PATCH next-queue 3/3] ixgbe: remove unneeded ipsec state free callback

2018-02-22 Thread Shannon Nelson
With commit 7f05b467a735 ("xfrm: check for xdo_dev_state_free") we no longer need to add an empty callback function to the driver, so now let's remove the useless code. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 13 -

Re: [PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-22 Thread David Ahern
On 2/22/18 12:27 PM, David Miller wrote: > From: David Ahern > Date: Wed, 21 Feb 2018 10:49:47 -0800 > >> Patch 5 adds the L4 hash support. > > Please address Ido's feedback about how the ports aren't actually being > taken into consideration because they aren't present in

Re: [PATCH net] net: ipv4: Set addr_type in hash_keys for forwarded case

2018-02-22 Thread David Miller
From: David Ahern Date: Wed, 21 Feb 2018 11:00:54 -0800 > The result of the skb flow dissect is copied from keys to hash_keys to > ensure only the intended data is hashed. The original L4 hash patch > overlooked setting the addr_type for this case; add it. > > Fixes:

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-22 Thread David Ahern
On 2/22/18 11:58 AM, David Miller wrote: > From: David Ahern > Date: Wed, 21 Feb 2018 11:16:35 -0700 > >> On 2/20/18 12:45 AM, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> Up until now we only allowed VLAN devices to be put in a VLAN-unaware >>>

Re: [PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-22 Thread David Miller
From: David Ahern Date: Wed, 21 Feb 2018 10:49:47 -0800 > Patch 5 adds the L4 hash support. Please address Ido's feedback about how the ports aren't actually being taken into consideration because they aren't present in the flow information being used. Thanks.

Re: [PATCH net] tcp_bbr: better deal with suboptimal GSO

2018-02-22 Thread David Miller
From: Eric Dumazet Date: Wed, 21 Feb 2018 06:43:03 -0800 > From: Eric Dumazet > > BBR uses tcp_tso_autosize() in an attempt to probe what would be the > burst sizes and to adjust cwnd in bbr_target_cwnd() with following > gold formula : > > /*

[PATCH next-queue 2/3] ixgbe: fix ipsec trailer length

2018-02-22 Thread Shannon Nelson
Fix up the Tx trailer length calculation. We can't believe the trailer len from the xstate information because it was calculated before the packet was put together and padding added. This bit of code finds the padding value in the trailer, adds it to the authentication length, and saves it so

[PATCH next-queue 0/3] ixgbe: ipsec fixups

2018-02-22 Thread Shannon Nelson
These are a couple of updates for the ixgbe IPsec offload support. Shannon Nelson (3): ixgbe: check for 128-bit authentication ixgbe: fix ipsec trailer length ixgbe: remove unneeded ipsec state free callback drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 53 +-

[PATCH next-queue 1/3] ixgbe: check for 128-bit authentication

2018-02-22 Thread Shannon Nelson
Make sure the Security Association is using a 128-bit authentication, since that's the only size that the hardware offload supports. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 16 +++-

Re: [PATCH net-next 2/5] net/smc: fix structure size

2018-02-22 Thread David Miller
From: Ursula Braun Date: Wed, 21 Feb 2018 12:32:32 +0100 > diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h > index ab240b37ad11..d2012fd22100 100644 > --- a/net/smc/smc_cdc.h > +++ b/net/smc/smc_cdc.h > @@ -48,7 +48,7 @@ struct smc_cdc_msg { > struct

Re: nla_put_string() vs NLA_STRING

2018-02-22 Thread David Miller
From: Kees Cook Date: Tue, 20 Feb 2018 22:00:26 -0800 > So, this specific problem needs fixing (in at least two places calling > nla_put_string(msg, NL80211_ATTR_REG_ALPHA2, ...)). While I suspect > it's only ever written an extra byte from the following variable in > the

[PATCH net] gianfar: simplify FCS handling and fix memory leak

2018-02-22 Thread Andy Spencer
Previously, buffer descriptors containing only the frame check sequence (FCS) were skipped and not added to the skb. However, the page reference count was still incremented, leading to a memory leak. Fixing this inside gfar_add_rx_frag() is difficult due to reserved memory handling and page

Re: [PATCH] Carrier detect ok, don't turn off negotiation

2018-02-22 Thread David Miller
From: Denis Du Date: Wed, 21 Feb 2018 03:35:31 + (UTC) > How  is your thinking about this patch? I cannot apply a patch which has been corrupted by your email client like this. Please send it properly again, plain ASCII text, and no trasnformations by your email

Re: [PATCH net] smsc75xx: fix smsc75xx_set_features()

2018-02-22 Thread David Miller
From: Eric Dumazet Date: Tue, 20 Feb 2018 21:42:26 -0800 > From: Eric Dumazet > > If an attempt is made to disable RX checksums, USB adapter is changed > but netdev->features is not, because smsc75xx_set_features() returns a > non zero value. > >

Re: [PATCH] netlink: put module reference if dump start fails

2018-02-22 Thread David Miller
From: "Jason A. Donenfeld" Date: Wed, 21 Feb 2018 04:41:59 +0100 > Before, if cb->start() failed, the module reference would never be put, > because cb->cb_running is intentionally false at this point. Users are > generally annoyed by this because they can no longer unload

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-22 Thread David Miller
From: David Ahern Date: Wed, 21 Feb 2018 11:16:35 -0700 > On 2/20/18 12:45 AM, Jiri Pirko wrote: >> From: Ido Schimmel >> >> Up until now we only allowed VLAN devices to be put in a VLAN-unaware >> bridge, but some users need the ability to enslave

Re: nft/bpf interpreters and spectre2. Was: [PATCH RFC 0/4] net: add bpfilter

2018-02-22 Thread Jann Horn
[resend as plaintext, apparently mobile gmail will send HTML mails] On Thu, Feb 22, 2018 at 3:20 AM, Alexei Starovoitov wrote: > On Wed, Feb 21, 2018 at 01:13:03PM +0100, Florian Westphal wrote: >> >> Obvious candidates are: meta, numgen, limit, objref, quota,

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-22 Thread Denys Fedoryshchenko
On 2018-02-22 20:30, Guillaume Nault wrote: On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote: On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: >> On 2018-02-15 17:55, Guillaume Nault

Re: [PATCH bpf v2] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread David Miller
From: Yonghong Song Date: Thu, 22 Feb 2018 10:10:35 -0800 > Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback > function") > fixed a memory leak and removed unnecessary locks in map_free callback > function. > Unfortrunately, it introduced a lockdep warning.

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-22 Thread Guillaume Nault
On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote: > On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault > wrote: > > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: > >> On 2018-02-15 17:55, Guillaume Nault wrote: > >> > On Thu, Feb 15, 2018 at

Re: [RFC PATCH V2] virtio_pci: Add SR-IOV support

2018-02-22 Thread Christoph Hellwig
Can we move this into common code as a a generic_sriov_configure helper? Nothing is really virtio specific, and it seems like some other drivers could also use it, e.g. ena or nvme.

Re: [PATCH bpf v2] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread Eric Dumazet
On Thu, 2018-02-22 at 10:10 -0800, Yonghong Song wrote: > Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback > function") > fixed a memory leak and removed unnecessary locks in map_free callback > function. > Unfortrunately, it introduced a lockdep warning. When lockdep

[PATCH bpf v2] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread Yonghong Song
Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback function") fixed a memory leak and removed unnecessary locks in map_free callback function. Unfortrunately, it introduced a lockdep warning. When lockdep checking is turned on, running

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread kbuild test robot
Hi Bryan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Bryan-Whitehead/lan743x-Add-new-lan743x-driver/20180222-225510 reproduce: # apt-get install sparse make ARCH=x86_64

[RFC PATCH] lan743x: lan743x_csr_read() can be static

2018-02-22 Thread kbuild test robot
Fixes: 896121de80db ("lan743x: Add main source files for new lan743x driver") Signed-off-by: Fengguang Wu --- lan743x_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c

[Crypto v7 06/12] cxgb4: LLD driver changes to enable TLS

2018-02-22 Thread Atul Gupta
Read FW capability. Read key area size. Dump the TLS record count. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32 +--- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 ++ drivers/net/ethernet/chelsio/cxgb4/sge.c| 98

[Crypto v7 12/12] Makefile Kconfig

2018-02-22 Thread Atul Gupta
Entry for Inline TLS as another driver dependent on cxgb4 and chcr Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/Kconfig| 11 +++ drivers/crypto/chelsio/Makefile | 1 + drivers/crypto/chelsio/chtls/Makefile | 4 3 files changed, 16

[Crypto v7 08/12] chtls: Key program

2018-02-22 Thread Atul Gupta
Program the tx and rx key on chip. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 394 1 file changed, 394 insertions(+) create mode 100644 drivers/crypto/chelsio/chtls/chtls_hw.c diff --git

[Crypto v7 05/12] cxgb4: Inline TLS FW Interface

2018-02-22 Thread Atul Gupta
Key area size in hw-config file. CPL struct for TLS request and response. Work request for Inline TLS. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 121 ++- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 +

[Crypto v7 10/12] chtls: Inline crypto request Tx/Rx

2018-02-22 Thread Atul Gupta
TLS handler for record transmit and receive. Create Inline TLS work request and post to FW. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 1867 +++ 1 file changed, 1867 insertions(+) create mode 100644

[RFC PATCH V2] virtio_pci: Add SR-IOV support

2018-02-22 Thread Mark Rustad
Hardware-realized virtio-pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio-net PF and virtio-net VFs. These are hardware realizations of what has been up to now been a software interface. The device in

[Crypto v7 11/12] chtls: Register chtls Inline TLS with net tls

2018-02-22 Thread Atul Gupta
Register chtls as Inline TLS driver, chtls is ULD to cxgb4. Setsockopt to program (tx/rx) keys on chip. Support AES GCM of key size 128. Support both Inline Rx and Tx. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 600

[Crypto v7 09/12] chtls: CPL handler definition

2018-02-22 Thread Atul Gupta
CPL handlers for TLS session, record transmit and receive. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2041 +++ net/ipv4/tcp_minisocks.c|1 + 2 files changed, 2042 insertions(+) create mode

[Crypto v7 07/12] chcr: Key Macro

2018-02-22 Thread Atul Gupta
Define macro for TLS Key context Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.h | 42 + drivers/crypto/chelsio/chcr_core.h | 55 +- 2 files changed, 96 insertions(+), 1 deletion(-) diff

  1   2   >