Re: tcp hang when socket fills up ?

2018-04-16 Thread Eric Dumazet
On 04/16/2018 08:52 PM, Dominique Martinet wrote: > Thank you for the hints. Out of order reply. > > Florian Westphal wrote on Mon, Apr 16, 2018: >> echo 1 > /proc/sys/net/netfilter/nf_conntrack_tcp_be_liberal >> >> which stops conntrack from marking packets with out-of-window >> acks as

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Michael Karcher
[Andrew, sorry for the dup. I did hit reply-to-auhor instead of reply-to-all first.] Andrew Lunn schrieb: >> > This should really be fixed in the PHY driver, not the MAC. >> >> OK - do you want this separate, or as part of this series? Might have >> a few side effects on more commonly used

[PATCH bpf-next 1/2] bpf: add helper for getting xfrm states

2018-04-16 Thread Eyal Birger
This commit introduces a helper which allows fetching xfrm state parameters by eBPF programs attached to TC. Prototype: bpf_skb_get_xfrm_state(skb, index, xfrm_state, size, flags) skb: pointer to skb index: the index in the skb xfrm_state secpath array xfrm_state: pointer to 'struct

[PATCH bpf-next 2/2] samples/bpf: extend test_tunnel_bpf.sh with xfrm state test

2018-04-16 Thread Eyal Birger
Add a test for fetching xfrm state parameters from a tc program running on ingress. Signed-off-by: Eyal Birger --- samples/bpf/tcbpf2_kern.c | 15 +++ samples/bpf/test_tunnel_bpf.sh| 71 +++

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit (fwd)

2018-04-16 Thread Julia Lawall
Line 1814 frees something that is dereferenced on the next line. julia -- Forwarded message -- Date: Tue, 17 Apr 2018 10:32:17 +0800 From: kbuild test robot To: kbu...@01.org Cc: Julia Lawall Subject: Re: [PATCH net-next 2/2] openvswitch:

[PATCH bpf-next 0/2] bpf: add helper for getting xfrm states

2018-04-16 Thread Eyal Birger
This patchset adds support for fetching XFRM state information from an eBPF program called from TC. The first patch introduces a helper for fetching an XFRM state from the skb's secpath. The XFRM state is modeled using a new virtual struct which contains the SPI, peer address, and reqid values of

[PATCH RESEND net-next] net/ncsi: Refactor MAC, VLAN filters

2018-04-16 Thread Samuel Mendoza-Jonas
The NCSI driver defines a generic ncsi_channel_filter struct that can be used to store arbitrarily formatted filters, and several generic methods of accessing data stored in such a filter. However in both the driver and as defined in the NCSI specification there are only two actual filters: VLAN

general protection fault in encode_rpcb_string

2018-04-16 Thread syzbot
Hello, syzbot hit the following crash on bpf-next commit 5d1365940a68dd57b031b6e3c07d7d451cd69daf (Thu Apr 12 18:09:05 2018 +) Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net syzbot dashboard link: https://syzkaller.appspot.com/bug?extid=4b98281f2401ab849f4b So far this

Re: [PATCH net-next 3/5] ipv4: support sport, dport and ip protocol in RTM_GETROUTE

2018-04-16 Thread Roopa Prabhu
On Mon, Apr 16, 2018 at 3:58 PM, David Miller wrote: > From: Roopa Prabhu > Date: Mon, 16 Apr 2018 13:41:36 -0700 > >> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h >> index 9b15005..7947252 100644 >> ---

[PATCH][net-next] net: ip tos cgroup

2018-04-16 Thread Li RongQing
ip tos segment can be changed by setsockopt(IP_TOS), or by iptables; this patch creates a new method to change socket tos segment of processes based on cgroup The usage: 1. mount ip_tos cgroup, and setting tos value mount -t cgroup -o ip_tos ip_tos /cgroups/tos echo tos_value

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Tiwei Bie
On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: > On 2018年04月13日 15:15, Tiwei Bie wrote: > > On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: > > > On 2018年04月01日 22:12, Tiwei Bie wrote: [...] > > > > +static int detach_buf_packed(struct vring_virtqueue *vq, unsigned int >

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Michael S. Tsirkin
On Tue, Apr 17, 2018 at 10:24:32AM +0800, Jason Wang wrote: > > > On 2018年04月17日 10:17, Michael S. Tsirkin wrote: > > On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: > > > > > > On 2018年04月13日 15:15, Tiwei Bie wrote: > > > > On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang

[PATCH] samples/bpf: correct comment in sock_example.c

2018-04-16 Thread Wang Sheng-Hui
The program run against loopback interace "lo", not "eth0". Correct the comment. Signed-off-by: Wang Sheng-Hui --- samples/bpf/sock_example.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/bpf/sock_example.c b/samples/bpf/sock_example.c index

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Jason Wang
On 2018年04月17日 10:17, Michael S. Tsirkin wrote: On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: On 2018年04月13日 15:15, Tiwei Bie wrote: On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: On 2018年04月01日 22:12, Tiwei Bie wrote: Hello everyone, This RFC implements packed

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Michael S. Tsirkin
On Tue, Apr 17, 2018 at 10:11:58AM +0800, Jason Wang wrote: > > > On 2018年04月13日 15:15, Tiwei Bie wrote: > > On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: > > > On 2018年04月01日 22:12, Tiwei Bie wrote: > > > > Hello everyone, > > > > > > > > This RFC implements packed ring support

Re: [PATCH net,stable] tun: fix vlan packet truncation

2018-04-16 Thread Jason Wang
On 2018年04月17日 06:00, Bjørn Mork wrote: Bogus trimming in tun_net_xmit() causes truncated vlan packets. skb->len is correct whether or not skb_vlan_tag_present() is true. There is no more reason to adjust the skb length on xmit in this driver than any other driver. tun_put_user() adds 4 bytes

Re: [RFC v2] virtio: support packed ring

2018-04-16 Thread Jason Wang
On 2018年04月13日 15:15, Tiwei Bie wrote: On Fri, Apr 13, 2018 at 12:30:24PM +0800, Jason Wang wrote: On 2018年04月01日 22:12, Tiwei Bie wrote: Hello everyone, This RFC implements packed ring support for virtio driver. The code was tested with DPDK vhost (testpmd/vhost-PMD) implemented by Jens

Re: SRIOV switchdev mode BoF minutes

2018-04-16 Thread Samudrala, Sridhar
On 4/16/2018 5:39 AM, Andy Gospodarek wrote: On Sun, Apr 15, 2018 at 09:01:16AM +0300, Or Gerlitz wrote: On Sat, Apr 14, 2018 at 2:03 AM, Samudrala, Sridhar wrote: I meant between PFs on 2 compute nodes. If the PF serves as uplink rep, it functions as a switch

[PATCH v2 4/8] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-16 Thread Michael Schmitz
Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz

[PATCH v2 0/8] New network driver for Amiga X-Surf 100 (m68k)

2018-04-16 Thread Michael Schmitz
This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me.

[PATCH v2 2/8] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher

[PATCH v2 7/8] net: ax88796: release platform device drvdata on probe error and module remove

2018-04-16 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2

[PATCH v2 3/8] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher

[PATCH v2 6/8] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael

[PATCH v2 8/8] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-16 Thread Michael Schmitz
Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. This driver will have to be loaded before loading the ax88796 module, or compiled as built-in. Signed-off-by: Michael Karcher

[PATCH v2 5/8] net: ax88796: add interrupt status callback to platform data

2018-04-16 Thread Michael Schmitz
To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the previous behaviour). Signed-off-by: Michael Karcher

[PATCH v2 1/8] net: ax88796: Fix MAC address reading

2018-04-16 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by:

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Andrew Lunn
> > This should really be fixed in the PHY driver, not the MAC. > > OK - do you want this separate, or as part of this series? Might have > a few side effects on more commonly used hardware, perhaps? Hi Michael What PHY driver is used? In the driver you can implement a .soft_reset function

RE: [next-queue PATCH] igb: Fix the transmission mode of queue 0 for Qav mode

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:28 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org;

RE: [next-queue PATCH v7 10/10] igb: Add support for adding offloaded clsflower filters

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:25 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org;

RE: [Intel-wired-lan] [next-queue PATCH v7 09/10] igb: Add the skeletons for tc-flower offloading

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:23 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 09/10] igb:

RE: [next-queue PATCH v7 08/10] igb: Add MAC address support for ethtool nftuple filters

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:23 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org;

RE: [next-queue PATCH v7 07/10] igb: Enable nfc filters to specify MAC addresses

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:22 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org;

RE: [Intel-wired-lan] [next-queue PATCH v7 06/10] igb: Allow filters to be added for the local MAC address

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:20 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 06/10] igb:

RE: [Intel-wired-lan] [next-queue PATCH v7 05/10] igb: Add support for enabling queue steering in filters

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:20 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 05/10] igb:

RE: [Intel-wired-lan] [next-queue PATCH v7 03/10] igb: Enable the hardware traffic class feature bit for igb models

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:18 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 03/10] igb:

RE: [next-queue PATCH v7 04/10] igb: Add support for MAC address filters specifying source addresses

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:19 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org;

RE: [next-queue PATCH v7 01/10] igb: Fix not adding filter elements to the list

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:17 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: Gomes, Vinicius ; Kirsher, Jeffrey T > ; netdev@vger.kernel.org;

RE: [Intel-wired-lan] [next-queue PATCH v7 02/10] igb: Fix queue selection on MAC filters on i210

2018-04-16 Thread Brown, Aaron F
> From: Brown, Aaron F > Sent: Friday, April 13, 2018 7:18 PM > To: 'Vinicius Costa Gomes' ; intel-wired- > l...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: RE: [Intel-wired-lan] [next-queue PATCH v7 02/10] igb:

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Michael Schmitz
Hi Andrew, On Tue, Apr 17, 2018 at 11:12 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: >> From: John Paul Adrian Glaubitz >> >> The AX88796B as installed on the X-Surf-100 does not recognize a MII reset >>

Re: [PATCH iproute2] utils: Do not reset family for default, any, all addresses

2018-04-16 Thread Stephen Hemminger
On Fri, 13 Apr 2018 09:36:33 -0700 David Ahern wrote: > Thomas reported a change in behavior with respect to autodectecting > address families. Specifically, 'ip ro add default via fe80::1' > syntax was failing to treat fe80::1 as an IPv6 address as it did in > prior releases.

Re: [PATCH net-next 2/2] openvswitch: Support conntrack zone limit

2018-04-16 Thread Gregory Rose
On 4/16/2018 11:15 AM, Yi-Hung Wei wrote: Currently, nf_conntrack_max is used to limit the maximum number of conntrack entries in the conntrack table for every network namespace. For the VMs and containers that reside in the same namespace, they share the same conntrack table, and the total # of

Re: [iproute PATCH] iproute: Abort if nexthop cannot be parsed

2018-04-16 Thread Stephen Hemminger
On Wed, 11 Apr 2018 11:43:11 +0200 Jakub Sitnicki wrote: > Attempt to add a multipath route where a nexthop definition refers to a > non-existent device causes 'ip' to crash and burn due to stack buffer > overflow: > > # ip -6 route add fd00::1/64 nexthop dev fake1 > Cannot

Re: [PATCH bpf-next 1/3] bpftool: Add missing prog types and attach types

2018-04-16 Thread Andrey Ignatov
Jakub Kicinski [Mon, 2018-04-16 16:53 -0700]: > On Mon, 16 Apr 2018 14:41:57 -0700, Andrey Ignatov wrote: > > diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c > > index cae32a6..8689916 100644 > > --- a/tools/bpf/bpftool/cgroup.c > > +++

Re: [PATCH 02/10] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
Hi Andrew, thank you for reviewing this series! On Tue, Apr 17, 2018 at 10:59 AM, Andrew Lunn wrote: > On Tue, Apr 17, 2018 at 10:04:37AM +1200, Michael Schmitz wrote: >> From: Michael Karcher >> >> Call ax_mii_init in ax_open(), and

Re: [PATCH net-next 1/2] openvswitch: Add conntrack limit netlink definition

2018-04-16 Thread Gregory Rose
On 4/16/2018 11:15 AM, Yi-Hung Wei wrote: Define netlink messages and attributes to support user kernel communication that using conntrack limit feature. s/using/uses the/ Signed-off-by: Yi-Hung Wei --- include/uapi/linux/openvswitch.h | 62

Re: [PATCH bpf-next 1/3] bpftool: Add missing prog types and attach types

2018-04-16 Thread Jakub Kicinski
On Mon, 16 Apr 2018 14:41:57 -0700, Andrey Ignatov wrote: > diff --git a/tools/bpf/bpftool/cgroup.c b/tools/bpf/bpftool/cgroup.c > index cae32a6..8689916 100644 > --- a/tools/bpf/bpftool/cgroup.c > +++ b/tools/bpf/bpftool/cgroup.c > @@ -16,15 +16,28 @@ > #define HELP_SPEC_ATTACH_FLAGS

Re: [PATCH 1/5] dt-bindings: allow dwmac-sun8i to use other devices' exported regmap

2018-04-16 Thread Icenowy Zheng
于 2018年4月17日 GMT+08:00 上午2:47:45, Rob Herring 写到: >On Wed, Apr 11, 2018 at 10:16:37PM +0800, Icenowy Zheng wrote: >> On some Allwinner SoCs the EMAC clock register needed by dwmac-sun8i >is >> in another device's memory space. In this situation dwmac-sun8i can >use >> a regmap

Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Andrew Lunn
On Tue, Apr 17, 2018 at 10:04:43AM +1200, Michael Schmitz wrote: > From: John Paul Adrian Glaubitz > > The AX88796B as installed on the X-Surf-100 does not recognize a MII reset > request if the previous write to the MII control register also was a reset > request.

Re: [PATCH net-next] net: Remove unused tcp_set_state tracepoint

2018-04-16 Thread David Miller
From: Andrey Ignatov Date: Mon, 16 Apr 2018 15:07:13 -0700 > This tracepoint was replaced by inet_sock_set_state in 563e0bb and not > used anywhere in the kernel anymore. Remove it. > > Signed-off-by: Andrey Ignatov Applied, thank you.

Re: [PATCH 02/10] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Andrew Lunn
On Tue, Apr 17, 2018 at 10:04:37AM +1200, Michael Schmitz wrote: > From: Michael Karcher > > Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources > in ax_close(). > > This is needed to be able to unload the module, as the module is busy >

Re: [PATCH net-next 3/5] ipv4: support sport, dport and ip protocol in RTM_GETROUTE

2018-04-16 Thread David Miller
From: Roopa Prabhu Date: Mon, 16 Apr 2018 13:41:36 -0700 > diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h > index 9b15005..7947252 100644 > --- a/include/uapi/linux/rtnetlink.h > +++ b/include/uapi/linux/rtnetlink.h > @@ -327,6 +327,9 @@

Re: [PATCH net-next 0/2] PCI: add two more values for PCIe Max_Read_Request_Size and initially use them in r8169 network driver

2018-04-16 Thread David Miller
From: Heiner Kallweit Date: Mon, 16 Apr 2018 21:35:42 +0200 > In r8169 network driver I stumbled across a magic number translating > to PCI MRRS size 4K. The PCI core is still missing constants for > values 2K and 4K (as defined in PCI standard). > > So let's add these two

Re: [PATCH] textsearch: fix kernel-doc warnings and add kernel-api section

2018-04-16 Thread David Miller
From: Randy Dunlap Date: Mon, 16 Apr 2018 12:32:55 -0700 > From: Randy Dunlap > > Make lib/textsearch.c usable as kernel-doc. > Add textsearch() function family to kernel-api documentation. > Fix kernel-doc warnings in : >

Re: [PATCH net-next 0/5] net: stmmac: Stop using hard-coded callbacks

2018-04-16 Thread David Miller
From: Jose Abreu Date: Mon, 16 Apr 2018 16:08:11 +0100 > This a starting point for a cleanup and re-organization of stmmac. > > In this series we stop using hard-coded callbacks along the code and use > instead helpers which are defined in a single place ("hwif.h"). >

Re: [PATCH net-next 0/5] tcp: add zero copy receive

2018-04-16 Thread David Miller
From: Eric Dumazet Date: Mon, 16 Apr 2018 10:33:34 -0700 > This patch series add mmap() support to TCP sockets for RX zero copy. > > While tcp_mmap() patch itself is quite small (~100 LOC), optimal support > for asynchronous mmap() required better SO_RCVLOWAT behavior, and

Re: [PATCH net-next 1/1] tc-testing: add sample action tests

2018-04-16 Thread David Miller
From: Roman Mashak Date: Mon, 16 Apr 2018 12:06:04 -0400 > Signed-off-by: Roman Mashak Applied to net-next.

Re: [PATCH] ipv6: remove unnecessary check in addrconf_prefix_rcv_add_addr()

2018-04-16 Thread David Miller
From: Lorenzo Bianconi Date: Mon, 16 Apr 2018 17:52:59 +0200 > Remove unnecessary check on update_lft variable in > addrconf_prefix_rcv_add_addr routine since it is always set to 0. > Moreover remove update_lft re-initialization to 0 > > Signed-off-by: Lorenzo

Re: [PATCH v2] net: ipv6: xfrm6_state: remove VLA usage

2018-04-16 Thread Stefano Brivio
Andreas, On Sat, 10 Mar 2018 09:40:44 +0200 Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed[1]. > Instead of dynamic allocation, just use XFRM_MAX_DEPTH > as already done for the "class" array, but as per feedback, > I will not

Re: [PATCH net 0/2] tipc: Better check user provided attributes

2018-04-16 Thread David Miller
From: Jon Maloy Date: Mon, 16 Apr 2018 19:21:44 + > Acked-by: Jon Maloy > > Thank you, Eric. Series applied and patch #1 queued up for -stable, thanks Eric.

[PATCH net-next] net: Remove unused tcp_set_state tracepoint

2018-04-16 Thread Andrey Ignatov
This tracepoint was replaced by inet_sock_set_state in 563e0bb and not used anywhere in the kernel anymore. Remove it. Signed-off-by: Andrey Ignatov --- include/trace/events/tcp.h | 47 -- 1 file changed, 47 deletions(-) diff --git

[PATCH 07/10] net: ax88796: unregister mdiobus on ax_mii_init() fail

2018-04-16 Thread Michael Schmitz
From: Michael Schmitz Unregister and free up mdiobus resources if ax_mii_init() failed. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |6 +- 1 files

Re: [PATCH net-next 1/2] PCI: Add two more values for PCIe Max_Read_Request_Size

2018-04-16 Thread David Miller
From: Bjorn Helgaas Date: Mon, 16 Apr 2018 16:42:04 -0500 > On Mon, Apr 16, 2018 at 09:37:13PM +0200, Heiner Kallweit wrote: >> This patch adds missing values for the max read request size. >> E.g. network driver r8169 uses a value of 4K. >> >> Signed-off-by: Heiner Kallweit

[PATCH 04/10] net: ax88796: Add block_input/output hooks to ax_plat_data

2018-04-16 Thread Michael Schmitz
Add platform specific hooks for block transfer reads/writes of packet buffer data, superseding the default provided ax_block_input/output. Currently used for m68k Amiga XSurf100. Signed-off-by: Michael Karcher Signed-off-by: Michael Schmitz

[PATCH 05/10] net: ax88796: add interrupt status callback to platform data

2018-04-16 Thread Michael Schmitz
To be able to tell the ax88796 driver whether it is sensible to enter the 8390 interrupt handler, an "is this interrupt caused by the 88796" callback has been added to the ax_plat_data structure (with NULL being compatible to the previous behaviour). Signed-off-by: Michael Karcher

[PATCH 02/10] net: ax88796: Attach MII bus only when open

2018-04-16 Thread Michael Schmitz
From: Michael Karcher Call ax_mii_init in ax_open(), and unregister/remove mdiobus resources in ax_close(). This is needed to be able to unload the module, as the module is busy while the MII bus is attached. Signed-off-by: Michael Karcher

[PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz The AX88796B as installed on the X-Surf-100 does not recognize a MII reset request if the previous write to the MII control register also was a reset request. So a dummy write to the control register makes the soft reset in the PHY

[PATCH 06/10] net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz On the Amiga X-Surf100, the network card interrupt is shared with many other interrupt sources, so requires the IRQF_SHARED flag to register. Signed-off-by: Michael Karcher Signed-off-by: Michael

[PATCH 09/10] net: ax88796: release platform device drvdata on probe error and module remove

2018-04-16 Thread Michael Schmitz
The net device struct pointer is stored as platform device drvdata on module probe - clear the drvdata entry on probe fail there, as well as when unloading the module. Signed-off-by: Michael Schmitz --- drivers/net/ethernet/8390/ax88796.c |2 ++ 1 files changed, 2

[PATCH 01/10] net: ax88796: Fix MAC address reading

2018-04-16 Thread Michael Schmitz
From: Michael Karcher To read the MAC address from the (virtual) SAprom, the remote DMA unit needs to be set up like for every other process access to card-local memory. Signed-off-by: Michael Karcher Signed-off-by:

[PATCH 00/10] New network driver for Amiga X-Surf 100 (m68k)

2018-04-16 Thread Michael Schmitz
This patch series adds support for the Individual Computers X-Surf 100 network card for m68k Amiga, a network adapter based on the AX88796 chip set. The driver was originally written for kernel version 3.19 by Michael Karcher (see CC:), and adapted to 4.16 for submission to netdev by me.

[PATCH 03/10] net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()).

2018-04-16 Thread Michael Schmitz
From: John Paul Adrian Glaubitz This complements the fix in 82533ad9a1c that removed the free_irq call in the error path of probe, to also not call free_irq when remove is called to revert the effects of probe. Signed-off-by: Michael Karcher

[PATCH 10/10] net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k)

2018-04-16 Thread Michael Schmitz
Add platform device driver to populate the ax88796 platform data from information provided by the XSurf100 zorro device driver. This driver will have to be loaded before loading the ax88796 module, or compiled as built-in. Signed-off-by: Michael Karcher

[PATCH net,stable] tun: fix vlan packet truncation

2018-04-16 Thread Bjørn Mork
Bogus trimming in tun_net_xmit() causes truncated vlan packets. skb->len is correct whether or not skb_vlan_tag_present() is true. There is no more reason to adjust the skb length on xmit in this driver than any other driver. tun_put_user() adds 4 bytes to the total for tagged packets because it

[PATCH bpf-next 3/3] libbpf: Type functions for raw tracepoints

2018-04-16 Thread Andrey Ignatov
Add missing pieces for BPF_PROG_TYPE_RAW_TRACEPOINT in libbpf: * is- and set- functions; * support guessing prog type. Signed-off-by: Andrey Ignatov --- tools/lib/bpf/libbpf.c | 2 ++ tools/lib/bpf/libbpf.h | 2 ++ 2 files changed, 4 insertions(+) diff --git

[PATCH bpf-next 1/3] bpftool: Add missing prog types and attach types

2018-04-16 Thread Andrey Ignatov
Add missing prog types to `bpftool prog` and missing attach types to `bpftool cgroup`. Signed-off-by: Andrey Ignatov --- tools/bpf/bpftool/cgroup.c | 19 --- tools/bpf/bpftool/prog.c | 3 +++ 2 files changed, 19 insertions(+), 3 deletions(-) diff --git

[PATCH bpf-next 2/3] libbpf: Support guessing post_bind{4,6} progs

2018-04-16 Thread Andrey Ignatov
libbpf can guess prog type and expected attach type based on section name. Add hints for "cgroup/post_bind4" and "cgroup/post_bind6" section names. Existing "cgroup/sock" is not changed, i.e. expected_attach_type for it is not set to `BPF_CGROUP_INET_SOCK_CREATE`, for backward compatibility.

[PATCH bpf-next 0/3] Add missing types to bpftool, libbpf

2018-04-16 Thread Andrey Ignatov
Add support for various BPF prog types and attach types that have been added to kernel recently but not to bpftool or libbpf yet. Andrey Ignatov (3): bpftool: Add missing prog types and attach types libbpf: Support guessing post_bind{4,6} progs libbpf: Type functions for raw tracepoints

Re: [PATCH net-next 1/2] PCI: Add two more values for PCIe Max_Read_Request_Size

2018-04-16 Thread Bjorn Helgaas
On Mon, Apr 16, 2018 at 09:37:13PM +0200, Heiner Kallweit wrote: > This patch adds missing values for the max read request size. > E.g. network driver r8169 uses a value of 4K. > > Signed-off-by: Heiner Kallweit I'd prefer a subject line with more details, e.g., PCI:

[PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

2018-04-16 Thread Eric Biggers
From: Eric Biggers Adding a dns_resolver key whose payload contains a very long option name resulted in that string being printed in full. This hit the WARN_ONCE() in set_precision() during the printk(), because printk() only supports a precision of up to 32767 bytes:

Re: [PATCH v2] KEYS: DNS: limit the length of option strings

2018-04-16 Thread Eric Biggers
On Mon, Apr 02, 2018 at 12:20:35PM -0700, Eric Biggers wrote: > On Fri, Mar 23, 2018 at 01:21:22PM -0700, Eric Biggers wrote: > > On Mon, Mar 12, 2018 at 10:57:07AM -0700, Eric Biggers wrote: > > > On Wed, Mar 07, 2018 at 03:54:37PM +, David Howells wrote: > > > > Eric Biggers

Proposal

2018-04-16 Thread MS Zeliha Omer Faruk
Hello Greeetings to you please did you get my previous email regarding my investment proposal last week friday ? MS.Zeliha ömer faruk zeliha.omer.fa...@gmail.com

Re: [PATCH net] net: Fix one possible memleak in ip_setup_cork

2018-04-16 Thread Eric Dumazet
On 04/16/2018 09:58 AM, David Miller wrote: > From: gfree.w...@vip.163.com > Date: Mon, 16 Apr 2018 10:16:45 +0800 > >> From: Gao Feng >> >> It would allocate memory in this function when the cork->opt is NULL. But >> the memory isn't freed if failed in the latter rt

Re: XDP performance regression due to CONFIG_RETPOLINE Spectre V2

2018-04-16 Thread Jesper Dangaard Brouer
On Mon, 16 Apr 2018 05:27:06 -0700 Christoph Hellwig wrote: > Can you try the following hack which avoids indirect calls entirely > for the fast path direct mapping case? > > --- > From b256a008c1b305e6a1c2afe7c004c54ad2e96d4b Mon Sep 17 00:00:00 2001 > From: Christoph

Re: [RFC net-next 1/2] net: net-porcfs: Reduce rcu lock critical section

2018-04-16 Thread Eric Dumazet
On 04/16/2018 01:50 PM, Saeed Mahameed wrote: > > Dave, Eric, I would like to know whether it is ok to have this change > in the kernel (make get_stats ndo "might sleep")? I really didn't get > any convincing feedback to not do this change. Fact that you were not convinced does not mean you

[PATCH net-next] selftest: tc_flower: add testcase for 'ip_flags'

2018-04-16 Thread Davide Caratti
Signed-off-by: Davide Caratti --- .../testing/selftests/net/forwarding/tc_flower.sh | 70 ++ 1 file changed, 70 insertions(+) diff --git a/tools/testing/selftests/net/forwarding/tc_flower.sh b/tools/testing/selftests/net/forwarding/tc_flower.sh index

Re: [RFC net-next 1/2] net: net-porcfs: Reduce rcu lock critical section

2018-04-16 Thread Saeed Mahameed
On Thu, 2018-04-12 at 19:12 +, Saeed Mahameed wrote: > On Wed, 2018-04-11 at 19:59 -0700, Eric Dumazet wrote: > > > > On 04/11/2018 04:47 PM, Saeed Mahameed wrote: > > > > > > Well if we allow devices to access HW counters via FW command > > > interfaces in ndo_get_stats and by testing mlx5

Re: tcp hang when socket fills up ?

2018-04-16 Thread Marcelo Ricardo Leitner
On Sat, Apr 14, 2018 at 03:55:15AM +0200, Dominique Martinet wrote: > 16:49:26.724457 IP .31872 > .13317: Flags > [.], ack 25134, win 646, options [nop,nop,TS val 1617129467 ecr 1313937599], > length 0 > 16:49:26.726081 IP .31872 > .13317: Flags > [.], ack 26508, win 669, options [nop,nop,TS

[PATCH net-next 2/5] net: fib_rules: add extack support

2018-04-16 Thread Roopa Prabhu
From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- include/net/fib_rules.h | 3 ++- net/core/fib_rules.c| 55 + net/decnet/dn_rules.c | 7 +-- net/ipv4/fib_rules.c| 7 +--

[PATCH net-next 4/5] ipv6: support sport, dport and ip protocol in RTM_GETROUTE

2018-04-16 Thread Roopa Prabhu
From: Roopa Prabhu This is a followup to fib6 rules sport, dport and ip proto match support. Having them supported in getroute makes it easier to test fib6 rule lookups. Used by fib6 rule self tests. Signed-off-by: Roopa Prabhu ---

[PATCH net-next 3/5] ipv4: support sport, dport and ip protocol in RTM_GETROUTE

2018-04-16 Thread Roopa Prabhu
From: Roopa Prabhu This is a followup to fib rules sport, dport and ip proto match support. Having them supported in getroute makes it easier to test fib rule lookups. Used by fib rule self tests. Signed-off-by: Roopa Prabhu ---

[PATCH net-next 5/5] selftests: net: initial fib rule tests

2018-04-16 Thread Roopa Prabhu
From: Roopa Prabhu This adds a first set of tests for fib rule match/action for ipv4 and ipv6. Initial tests only cover action table. can be extended to cover other actions in the future. Uses ip route get to validate the rule lookup. Signed-off-by: Roopa Prabhu

[PATCH net-next 1/5] fib_rules: move common handling of newrule delrule msgs into fib_nl2rule

2018-04-16 Thread Roopa Prabhu
From: Roopa Prabhu This reduces code duplication in the fib rule add and del paths. Get rid of validate_rulemsg. This became obvious when adding duplicate extack support in fib newrule/delrule error paths. Signed-off-by: Roopa Prabhu ---

[PATCH net-next 0/5] fib rules extack support and selftest

2018-04-16 Thread Roopa Prabhu
From: Roopa Prabhu The first patch refactors some fib rule common add del netlink processing code. fibrule selftest uses route get, so this patch extends route get with a few matches. Roopa Prabhu (5): fib_rules: move common handling of newrule delrule msgs into

Re: [PATCH bpf-next v3 00/10] BTF: BPF Type Format

2018-04-16 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 16, 2018 at 12:33:17PM -0700, Martin KaFai Lau escreveu: > This patch introduces BPF Type Format (BTF). > > BTF (BPF Type Format) is the meta data format which describes > the data types of BPF program/map. Hence, it basically focus > on the C programming language which the modern

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77965 SoC

2018-04-16 Thread jacopo mondi
Hi David, On Mon, Apr 16, 2018 at 10:17:55AM -0400, David Miller wrote: > From: Jacopo Mondi > Date: Mon, 16 Apr 2018 15:55:17 +0200 > > > Add documentation for r8a77965 compatible string to renesas ravb device > > tree bindings documentation. > > > > Signed-off-by:

Re: [PATCH net-next 07/21] net/ipv6: Save route type in rt6_info

2018-04-16 Thread David Miller
From: David Ahern Date: Mon, 16 Apr 2018 13:50:07 -0600 > Added this to the commit message: > > fc_type is set in current users based on the algorithm in rt6_fill_node: > - rt6i_flags contains RTF_LOCAL: fc_type = RTN_LOCAL > - rt6i_flags contains RTF_ANYCAST: fc_type =

Re: [PATCH net-next 07/21] net/ipv6: Save route type in rt6_info

2018-04-16 Thread David Ahern
On 4/16/18 1:20 PM, David Miller wrote: > From: David Ahern > Date: Mon, 16 Apr 2018 08:22:41 -0700 > >> @@ -2394,6 +2395,7 @@ static void addrconf_add_mroute(struct net_device *dev) >> .fc_ifindex = dev->ifindex, >> .fc_dst_len = 8, >>

Re: net: hang in unregister_netdevice: waiting for lo to become free

2018-04-16 Thread Dan Streetman
On Mon, Apr 16, 2018 at 3:35 AM, Dmitry Vyukov wrote: > On Fri, Apr 13, 2018 at 5:54 PM, Dmitry Vyukov wrote: >> On Fri, Apr 13, 2018 at 2:43 PM, Dan Streetman wrote: >>> On Thu, Apr 12, 2018 at 8:15 AM, Dmitry Vyukov

[PATCH net-next 1/2] PCI: Add two more values for PCIe Max_Read_Request_Size

2018-04-16 Thread Heiner Kallweit
This patch adds missing values for the max read request size. E.g. network driver r8169 uses a value of 4K. Signed-off-by: Heiner Kallweit --- include/uapi/linux/pci_regs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/pci_regs.h

  1   2   3   >