[PATCH net-next] net: ethernet: mediatek: get out of potential invalid pointer access

2016-09-22 Thread sean.wang
From: Sean Wang Potential dangerous invalid pointer might be accessed if the error happens when couple phy_device to net_device so cleanup the error path. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 6 -- 1

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

2016-09-22 Thread Pablo Neira Ayuso
On Wed, Sep 21, 2016 at 08:48:27PM +0200, Thomas Graf wrote: > On 09/21/16 at 05:45pm, Pablo Neira Ayuso wrote: > > On Tue, Sep 20, 2016 at 06:43:35PM +0200, Daniel Mack wrote: > > > The point is that from an application's perspective, restricting the > > > ability to bind a port and dropping

[PATCH] ipvlan: fix building without netfilter

2016-09-22 Thread Arnd Bergmann
The new l3s mode in ipvlan relies on netfilter interfaces, but the ipvlan driver can be configured when CONFIG_NETFILTER is disabled, leading to a build error: drivers/net/ipvlan/ipvlan.h:132:22: error: 'struct nf_hook_state' declared inside parameter list will not be visible outside of this

Re: [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls

2016-09-22 Thread Jiri Pirko
Thu, Sep 22, 2016 at 08:51:02AM CEST, ido...@idosch.org wrote: >On Wed, Sep 21, 2016 at 01:53:11PM +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Until now, in order to offload a FIB entry to HW we use switchdev op. >> However that has limits. Mainly in case we need to

RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 22 September 2016 11:39 > To: Paul Durrant ; xen-de...@lists.xenproject.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org > Cc: Wei Liu > Subject: Re:

[PATCH iproute2] misc/ss: tcp cwnd should be unsigned

2016-09-22 Thread Hangbin Liu
tcp->snd_cwd is a u32, but ss treats it like a signed int. This may results in negative bandwidth calculations. Signed-off-by: Hangbin Liu --- misc/ss.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 3b268d9..f67557a

Re: [PATCH iproute2 2/2] ip rule: add selector support

2016-09-22 Thread Phil Sutter
On Thu, Sep 22, 2016 at 02:28:49PM +0800, Hangbin Liu wrote: [...] > diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8 > index 3508d80..ec0e31d 100644 > --- a/man/man8/ip-rule.8 > +++ b/man/man8/ip-rule.8 > @@ -15,7 +15,8 @@ ip-rule \- routing policy database management > > .ti -8 > .B ip

[PATCH resend 2] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Juergen Gross
Instead of open coding it use the threaded irq mechanism in xen-netback. Signed-off-by: Juergen Gross --- resend due to missing netdev list in first attempt and wrong address in second. --- drivers/net/xen-netback/common.h| 4 +--- drivers/net/xen-netback/interface.c | 38

[PATCH net-next V3 5/5] net/mlx4: Add VF vlan protocol 802.1ad support

2016-09-22 Thread Tariq Toukan
From: Moshe Shemesh Move the vf to VST 802.1ad mode (mlx4 VST QinQ mode) by setting vf vlan protocol to 802.1ad. VST 802.1ad mode in mlx4, is used for STAG strip/insertion by PF, while the CTAG is set by the VF. Read current vlan protocol as part of the vf configuration

[PATCH net-next V3 4/5] net: Update API for VF vlan protocol 802.1ad support

2016-09-22 Thread Tariq Toukan
From: Moshe Shemesh Introduce new rtnl UAPI that exposes a list of vlans per VF, giving the ability for user-space application to specify it for the VF, as an option to support 802.1ad. We adjusted IP Link tool to support this option. For future use cases, the new UAPI

[PATCH net-next V3 3/5] net/mlx4_en: Disable vlan HW acceleration when in VF vlan protocol 802.1ad mode

2016-09-22 Thread Tariq Toukan
From: Moshe Shemesh In Ethernet VF, disable vlan HW acceleration on VF while it is set to VF vlan protocol 802.1ad mode. Signed-off-by: Moshe Shemesh Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c |

[PATCH net-next V3 2/5] net/mlx4_core: Preparation for VF vlan protocol 802.1ad

2016-09-22 Thread Tariq Toukan
From: Moshe Shemesh Check device capability to support VF vlan protocol 802.1ad mode. Add vport attribute vlan protocol. Init vport vlan protocol by default to 802.1Q. Add update QP support for VF vlan protocol 802.1ad. Add func capability vlan_offload_disable to disable all

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Paolo Abeni
Hi Eric, On Wed, 2016-09-21 at 16:31 -0700, Eric Dumazet wrote: > Also does inet_diag properly give the forward_alloc to user ? > > $ ss -mua > State Recv-Q Send-Q Local Address:Port Peer Addres > s:Port > UNCONN 51584 0 *:52460 *:* >

Re: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Juergen Gross
On 22/09/16 12:31, Paul Durrant wrote: >> -Original Message- >> From: Juergen Gross [mailto:jgr...@suse.com] >> Sent: 22 September 2016 11:17 >> To: Paul Durrant ; xen-de...@lists.xenproject.org; >> net...@vger.kernel.orga ; linux- >>

RE: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Paul Durrant
> -Original Message- > From: Juergen Gross [mailto:jgr...@suse.com] > Sent: 22 September 2016 11:17 > To: Paul Durrant ; xen-de...@lists.xenproject.org; > net...@vger.kernel.orga ; linux- > ker...@vger.kernel.org > Cc: Wei Liu

Re: [PATCH resend 2] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Wei Liu
On Thu, Sep 22, 2016 at 11:06:25AM +0200, Juergen Gross wrote: > Instead of open coding it use the threaded irq mechanism in > xen-netback. > > Signed-off-by: Juergen Gross Acked-by: Wei Liu

[PATCH net-next 2/9] rxrpc: Add re-sent Tx annotation [ver #2]

2016-09-22 Thread David Howells
Add a Tx-phase annotation for packet buffers to indicate that a buffer has already been retransmitted. This will be used by future congestion management. Re-retransmissions of a packet don't affect the congestion window managment in the same way as initial retransmissions. Signed-off-by: David

[PATCH net-next 6/9] rxrpc: Add ktime_sub_ms() [ver #2]

2016-09-22 Thread David Howells
Add a ktime_sub_ms() to go with ktime_add_ms() and co. for use in AF_RXRPC RTT determination. Signed-off-by: David Howells --- include/linux/ktime.h |5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/ktime.h b/include/linux/ktime.h index

Re: [PATCH iproute2] misc/ss: tcp cwnd should be unsigned

2016-09-22 Thread Phil Sutter
On Thu, Sep 22, 2016 at 04:40:28PM +0800, Hangbin Liu wrote: > tcp->snd_cwd is a u32, but ss treats it like a signed int. This may > results in negative bandwidth calculations. > > Signed-off-by: Hangbin Liu Acked-by: Phil Sutter

[PATCH 1/2] net: thunderx: Fix issue with IRQ namimg

2016-09-22 Thread sunil . kovvuri
From: Sunil Goutham This patch fixes a regression caused by previous commit 'Use netdev's name for naming VF's interrupts' where irq name exceeds 20 byte array if interface's name size is large. Signed-off-by: Sunil Goutham ---

[PATCH iproute2 net-next] tc: m_vlan: Add vlan modify action

2016-09-22 Thread Shmulik Ladkani
The 'vlan modify' action allows to replace an existing 802.1q tag according to user provided settings. It accepts same arguments as the 'vlan push' action. For example, this replaces vid 6 with vid 5: # tc filter add dev veth0 parent : pref 1 protocol 802.1q \ basic match 'meta(vlan

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

2016-09-22 Thread Thomas Graf
On 09/22/16 at 11:21am, Pablo Neira Ayuso wrote: > I have a hard time to buy this new specific hook, I think we should > shift focus of this debate, this is my proposal to untangle this: > > You add a net/netfilter/nft_bpf.c expression that allows you to run > bpf programs from nf_tables. This

[PATCH net-next] net: ethernet: mediatek: use [get|set]_link_ksettings

2016-09-22 Thread sean.wang
From: Sean Wang 1) use new api [get|set]_link_ksettings instead of [get|set]_settings old ones. 2) dev->phydev is sure being ready before calling these callbacks, so removing all the sanity check if it is existing. Signed-off-by: Sean Wang ---

[PATCH net-next V3 1/5] net/mlx4_core: Fix QUERY FUNC CAP flags

2016-09-22 Thread Tariq Toukan
From: Moshe Shemesh Separate QUERY_FUNC_CAP flags0 from QUERY_FUNC_CAP flags, as 'flags' is already used for another set of flags in FUNC CAP, while phv bit should be part of a different set of flags. Remove QUERY_FUNC_CAP port_flags field, as it is not in use. Fixes:

[PATCH net-next V3 0/5] mlx4 VF vlan protocol 802.1ad support

2016-09-22 Thread Tariq Toukan
Hi Dave, This patchset adds VF VLAN protocol 802.1ad support to the mlx4 driver. We extended the VF VLAN API with an additional parameter for VLAN protocol, and kept 802.1Q as drivers' default. We prepared a userspace support (ip link tool). The patch will be submitted to the iproute2 mailing

Re: [PATCH] net: fec: set mac address unconditionally

2016-09-22 Thread Uwe Kleine-König
On Thu, Sep 22, 2016 at 08:08:36AM +0200, Uwe Kleine-König wrote: > Acked-by: Uwe Kleine-König huch, cut and paste borkage: This should be Acked-by: Uwe Kleine-König of course. Uwe -- Pengutronix e.K.

Re: [patch net-next 1/6] fib: introduce FIB notification infrastructure

2016-09-22 Thread Jiri Pirko
Thu, Sep 22, 2016 at 07:13:50AM CEST, ido...@idosch.org wrote: >On Wed, Sep 21, 2016 at 01:53:09PM +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This allows to pass information about added/deleted FIB entries/rules to >> whoever is interested. This is done in a very

Re: XDP (eXpress Data Path) documentation

2016-09-22 Thread Jesper Dangaard Brouer
On Wed, 21 Sep 2016 17:03:24 -0700 Tom Herbert wrote: > On Tue, Sep 20, 2016 at 2:08 AM, Jesper Dangaard Brouer > wrote: > > Hi all, > > > > As promised, I've started documenting the XDP eXpress Data Path): > > > > [1] > >

[PATCH net-next] net: ethernet: mediatek: use phydev from struct net_device

2016-09-22 Thread sean.wang
From: Sean Wang reuse phydev already in struct net_device instead of creating another new one in private structure. Signed-off-by: Sean Wang --- drivers/net/ethernet/mediatek/mtk_eth_soc.c | 73 ++---

Re: [PATCH] L2TP:Adjust intf MTU, add underlay L3, overlay L2

2016-09-22 Thread Derek Fawcus
On Wed, Sep 21, 2016 at 02:11:04pm -0700, R. Parameswaran wrote: > [snip] > @@ -206,6 +209,46 @@ static void l2tp_eth_show(struct seq_file *m, void > *arg) > } > #endif [snip] > + > static int l2tp_eth_create(struct net *net, u32 tunnel_id, u32 session_id, > u32 peer_session_id, struct

[PATCH 2/2] net: thunderx: Support for byte queue limits

2016-09-22 Thread sunil . kovvuri
From: Sunil Goutham This patch adds support for byte queue limits Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 11 ++-- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 30 ++ 2

[PATCH 0/2] BQL support and fix for a regression issue

2016-09-22 Thread sunil . kovvuri
From: Sunil Goutham These patches add byte queue limit support and also fixes a regression issue introduced by commit 'net: thunderx: Use netdev's name for naming VF's interrupts' Sunil Goutham (2): net: thunderx: Fix issue with IRQ namimg net: thunderx: Support for

Re: [Xen-devel] [PATCH resend] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread Juergen Gross
On 22/09/16 11:09, Paul Durrant wrote: >> -Original Message- >> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of >> Juergen Gross >> Sent: 22 September 2016 10:03 >> To: xen-de...@lists.xenproject.org; net...@vger.kernel.orga; linux- >> ker...@vger.kernel.org >> Cc:

Re: [PATCH v2] fs/select: add vmalloc fallback for select(2)

2016-09-22 Thread Vlastimil Babka
On 09/22/2016 07:07 PM, Eric Dumazet wrote: On Thu, 2016-09-22 at 18:56 +0200, Vlastimil Babka wrote: On 09/22/2016 06:49 PM, Eric Dumazet wrote: > On Thu, 2016-09-22 at 18:43 +0200, Vlastimil Babka wrote: >> The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows >> with

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-22 Thread Shmulik Ladkani
On Thu, 22 Sep 2016 07:54:13 -0700 Eric Dumazet wrote: > Hmm... we probably need to apply the full rcu protection before this > patch. > > https://patchwork.ozlabs.org/patch/667680/ Are you referring to order of application into net-next? This patch seems to present no

Re: [PATCH v3 2/2] netfilter: Create revision 2 of xt_hashlimit to support higher pps rates

2016-09-22 Thread Vishwanath Pai
Thanks for pointing this out, I will reorder the fields to: struct hashlimit_cfg2 { __u64 avg;/* Average secs between packets * scale */ __u64 burst; __u32 mode; /* bitmask of XT_HASHLIMIT_HASH_* */ This should fix the hole and avoid padding. -Vishwanath On

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 21:27 +0300, Shmulik Ladkani wrote: > On Thu, 22 Sep 2016 07:54:13 -0700 Eric Dumazet > wrote: > > Hmm... we probably need to apply the full rcu protection before this > > patch. > > > > https://patchwork.ozlabs.org/patch/667680/ > > Are you

Re: [PATCH iproute2 net-next] tc: m_vlan: Add vlan modify action

2016-09-22 Thread Shmulik Ladkani
On Thu, 22 Sep 2016 09:05:04 -0700 Stephen Hemminger wrote: > On Thu, 22 Sep 2016 12:31:10 +0300 > Shmulik Ladkani wrote: > > > + > > +static const char *action_name(int action) > > +{ > > + static const char * const names[] = {

Re: [PATCH 2/2] net: thunderx: Support for byte queue limits

2016-09-22 Thread Florian Fainelli
On 09/22/2016 02:05 AM, sunil.kovv...@gmail.com wrote: > From: Sunil Goutham > > This patch adds support for byte queue limits > > Signed-off-by: Sunil Goutham Where is the code that calls netdev_tx_reset_queue()? This is needed in the function that

[PATCH v3] tcp: fix wrong checksum calculation on MTU probing

2016-09-22 Thread Douglas Caetano dos Santos
With TCP MTU probing enabled and offload TX checksumming disabled, tcp_mtu_probe() calculated the wrong checksum when a fragment being copied into the probe's SKB had an odd length. This was caused by the direct use of skb_copy_and_csum_bits() to calculate the checksum, as it pads the fragment

[PATCH v2 iproute2 net-next] tc: m_vlan: Add vlan modify action

2016-09-22 Thread Shmulik Ladkani
The 'vlan modify' action allows to replace an existing 802.1q tag according to user provided settings. It accepts same arguments as the 'vlan push' action. For example, this replaces vid 6 with vid 5: # tc filter add dev veth0 parent : pref 1 protocol 802.1q \ basic match 'meta(vlan

[PATCH][V2] cxgb4: fix signed wrap around when decrementing index idx

2016-09-22 Thread Colin King
From: Colin Ian King Change predecrement compare to post decrement compare to avoid an unsigned integer wrap-around comparison when decrementing idx in the while loop. For example, when idx is zero, the current situation will predecrement idx in the while loop,

Re: XDP (eXpress Data Path) documentation

2016-09-22 Thread Jesper Dangaard Brouer
On Tue, 20 Sep 2016 11:08:44 +0200 Jesper Dangaard Brouer wrote: > As promised, I've started documenting the XDP eXpress Data Path): > > [1] > https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/index.html > > IMHO the documentation have reached a stage

[PATCH v1] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Mickaël Salaün
This fix a pointer leak when an unprivileged eBPF program read a pointer value from the context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value containing an address is then allowed to leak. Moreover, this prevented

Re: [PATCH] ipvlan: fix building without netfilter

2016-09-22 Thread David Miller
From: Arnd Bergmann Date: Thu, 22 Sep 2016 11:40:52 +0200 > The new l3s mode in ipvlan relies on netfilter interfaces, but > the ipvlan driver can be configured when CONFIG_NETFILTER is disabled, > leading to a build error: > > drivers/net/ipvlan/ipvlan.h:132:22: error: 'struct

[PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Hannes Frederic Sowa
Signed-off-by: Hannes Frederic Sowa --- net/core/net_namespace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 2c2eb1b629b11d..a2ace299f28355 100644 --- a/net/core/net_namespace.c +++

pull-request: can 2016-09-22

2016-09-22 Thread Marc Kleine-Budde
7e32b44361abc77fbc01f2b97b045c405b2583e5: tcp: properly account Fast Open SYN-ACK retrans (2016-09-22 03:33:01 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-4.8-20160922 for you to fetch changes up

[PATCH] can: dev: fix deadlock reported after bus-off

2016-09-22 Thread Marc Kleine-Budde
From: Sergei Miroshnichenko A timer was used to restart after the bus-off state, leading to a relatively large can_restart() executed in an interrupt context, which in turn sets up pinctrl. When this happens during system boot, there is a high probability of grabbing the

Re: [patch net-next 5/6] switchdev: remove FIB offload infrastructure

2016-09-22 Thread Jiri Pirko
Thu, Sep 22, 2016 at 09:25:19AM CEST, ido...@idosch.org wrote: >On Wed, Sep 21, 2016 at 01:53:13PM +0200, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Since this is now taken care of by FIB notifier, remove the code, with >> all unused dependencies. >> >> Signed-off-by: Jiri

Re: [PATCH v2] tcp: fix wrong checksum calculation on MTU probing

2016-09-22 Thread Sergei Shtylyov
Hello. On 9/21/2016 9:26 PM, Douglas Caetano dos Santos wrote: With TCP MTU probing enabled and offload TX checksumming disabled, tcp_mtu_probe() calculated the wrong checksum when a fragment being copied into the probe's SKB had an odd length. This was caused by the direct use of

Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0

2016-09-22 Thread Sergei Shtylyov
Hello. On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: From: Sean Wang Add the dts property for the capability if TRGMII supported on GAMC0 Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/net/mediatek-net.txt | 5 - 1

Re: [PATCH net-next] net: ethernet: mediatek: use phydev from struct net_device

2016-09-22 Thread David Miller
From: Date: Thu, 22 Sep 2016 16:33:35 +0800 > From: Sean Wang > > reuse phydev already in struct net_device instead of creating > another new one in private structure. > > Signed-off-by: Sean Wang Applied.

Re: [PATCH 0/2] BQL support and fix for a regression issue

2016-09-22 Thread David Miller
From: sunil.kovv...@gmail.com Date: Thu, 22 Sep 2016 14:35:19 +0530 > From: Sunil Goutham > > These patches add byte queue limit support and also fixes a regression > issue introduced by commit > 'net: thunderx: Use netdev's name for naming VF's interrupts' The correct way

Re: [PATCH resend 2] xen-netback: switch to threaded irq for control ring

2016-09-22 Thread David Miller
From: Juergen Gross Date: Thu, 22 Sep 2016 11:06:25 +0200 > Instead of open coding it use the threaded irq mechanism in > xen-netback. > > Signed-off-by: Juergen Gross Applied to net-next, thanks.

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

2016-09-22 Thread Sergei Shtylyov
Hello. On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: From: Sean Wang adds PHY-mode "trgmii" as an extension for the operation mode of the PHY interface for PHY_INTERFACE_MODE_TRGMII. and adds a variable trgmii inside mtk_mac as the indication to make the

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

2016-09-22 Thread Pablo Neira Ayuso
On Thu, Sep 22, 2016 at 11:54:11AM +0200, Thomas Graf wrote: > On 09/22/16 at 11:21am, Pablo Neira Ayuso wrote: > > I have a hard time to buy this new specific hook, I think we should > > shift focus of this debate, this is my proposal to untangle this: > > > > You add a net/netfilter/nft_bpf.c

Re: [PATCH net-next 0/9] rxrpc: Preparation for slow-start algorithm [ver #2]

2016-09-22 Thread David Miller
From: David Howells <dhowe...@redhat.com> Date: Thu, 22 Sep 2016 09:22:00 +0100 > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160922-v2 Pulled, thanks David.

Re: [PATCH net-next] net: ethernet: mediatek: get out of potential invalid pointer access

2016-09-22 Thread David Miller
From: Date: Thu, 22 Sep 2016 16:44:16 +0800 > From: Sean Wang > > Potential dangerous invalid pointer might be accessed if > the error happens when couple phy_device to net_device so > cleanup the error path. > > Signed-off-by: Sean Wang

Re: [PATCH net-next] net: ethernet: mediatek: use [get|set]_link_ksettings

2016-09-22 Thread David Miller
From: Date: Thu, 22 Sep 2016 16:42:03 +0800 > From: Sean Wang > > 1) use new api [get|set]_link_ksettings instead > of [get|set]_settings old ones. > > 2) dev->phydev is sure being ready before calling > these callbacks, so removing all the

Re: [PATCH net-next] net: ethernet: mediatek: remove superfluous local variable for phy address

2016-09-22 Thread David Miller
From: Date: Thu, 22 Sep 2016 16:36:15 +0800 > From: Sean Wang > > remove the unused variable for parsing PHY address > and the related logic for sanity test which would > be all already handled done when of_mdiobus_register > was called > >

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

2016-09-22 Thread David Miller
From: Date: Thu, 22 Sep 2016 10:33:53 +0800 > By default, GMAC0 is connected to built-in switch called > MT7530 through the proprietary interface called Turbo RGMII > (TRGMII). TRGMII also supports well for RGMII as generic external > PHY uses but requires some slight

Re: [PATCH] ipvlan: fix building without netfilter

2016-09-22 Thread Arnd Bergmann
On Thursday, September 22, 2016 8:32:05 AM CEST David Miller wrote: > From: Arnd Bergmann > Date: Thu, 22 Sep 2016 11:40:52 +0200 > > > The new l3s mode in ipvlan relies on netfilter interfaces, but > > the ipvlan driver can be configured when CONFIG_NETFILTER is disabled, > >

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Paolo Abeni
On Thu, 2016-09-22 at 16:21 +0100, Edward Cree wrote: > On 22/09/16 11:33, Paolo Abeni wrote: > > Hi Eric, > > > > On Wed, 2016-09-21 at 16:31 -0700, Eric Dumazet wrote: > >> Also does inet_diag properly give the forward_alloc to user ? > >> > >> $ ss -mua > >> State Recv-Q Send-Q Local

[PATCH net-next] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-22 Thread sean.wang
From: Sean Wang fix typo in mediatek-net.txt and add phy-mode "trgmii" to ethernet.txt Cc: devicet...@vger.kernel.org Reported-by: Sergei Shtylyov Signed-off-by: Sean Wang ---

[PATCH net-next] sfc: check async completer is !NULL before calling

2016-09-22 Thread Bert Kenward
Add a NULL check before calling asynchronous MCDI completion functions during device removal. Fixes: 7014d7f6 ("sfc: allow asynchronous MCDI without completion function") Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/mcdi.c | 3 ++- 1 file changed, 2

Re: [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls

2016-09-22 Thread David Ahern
On 9/21/16 5:53 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Until now, in order to offload a FIB entry to HW we use switchdev op. > However that has limits. Mainly in case we need to make the HW aware of > all route prefixes configured in kernel. HW needs to know those in

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

2016-09-22 Thread Daniel Borkmann
On 09/22/2016 02:05 PM, Pablo Neira Ayuso wrote: On Thu, Sep 22, 2016 at 11:54:11AM +0200, Thomas Graf wrote: On 09/22/16 at 11:21am, Pablo Neira Ayuso wrote: I have a hard time to buy this new specific hook, I think we should shift focus of this debate, this is my proposal to untangle this:

Re: [PATCH v6 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

2016-09-22 Thread Daniel Mack
On 09/22/2016 05:12 PM, Daniel Borkmann wrote: > On 09/22/2016 02:05 PM, Pablo Neira Ayuso wrote: >> Benefits are, rewording previous email: >> >> * You get access to all of the existing netfilter hooks in one go >>to run bpf programs. No need for specific redundant hooks. This >>provides

[PATCH net-next] net_sched: sch_fq: account for schedule/timers drifts

2016-09-22 Thread Eric Dumazet
From: Eric Dumazet It looks like the following patch can make FQ very precise, even in VM or stressed hosts. It matters at high pacing rates. We take into account the difference between the time that was programmed when last packet was sent, and current time (a drift of

Re: [PATCH iproute2 net-next] tc: m_vlan: Add vlan modify action

2016-09-22 Thread Stephen Hemminger
On Thu, 22 Sep 2016 12:31:10 +0300 Shmulik Ladkani wrote: > + > +static const char *action_name(int action) > +{ > + static const char * const names[] = { > + [TCA_VLAN_ACT_POP] = "pop", > + [TCA_VLAN_ACT_PUSH] = "push", > +

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 16:21 +0300, Shmulik Ladkani wrote: > From: Shmulik Ladkani > > Up until now, 'action mirred' supported only egress actions (either > TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). > > This patch implements the corresponding ingress actions >

Re: [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls

2016-09-22 Thread Jiri Pirko
Thu, Sep 22, 2016 at 04:58:20PM CEST, d...@cumulusnetworks.com wrote: >On 9/21/16 5:53 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Until now, in order to offload a FIB entry to HW we use switchdev op. >> However that has limits. Mainly in case we need to make the HW aware

Re: [PATCH] net: VRF: Fix receiving multicast traffic

2016-09-22 Thread David Ahern
On 9/21/16 10:13 PM, Mark Tomlinson wrote: > The previous patch to ensure that the original iif was used when > checking for forwarding also meant that this same interface was used to > determine whether multicast packets should be received or not. This was > incorrect, and would cause multicast

[PATCH] fs/select: add vmalloc fallback for select(2)

2016-09-22 Thread Vlastimil Babka
The select(2) syscall performs a kmalloc(size, GFP_KERNEL) where size grows with the number of fds passed. We had a customer report page allocation failures of order-4 for this allocation. This is a costly order, so it might easily fail, as the VM expects such allocation to have a lower-order

Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 15:41 +0200, Hannes Frederic Sowa wrote: > I found this during working on the file and actually saw no live issues > (belonged to another series which I just split up). > > I don't think it is a big issue but wanted the writes to the > rtnl_msg_handlers array to be strictly

Re: [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls

2016-09-22 Thread David Ahern
On 9/22/16 9:05 AM, Jiri Pirko wrote: > Thu, Sep 22, 2016 at 04:58:20PM CEST, d...@cumulusnetworks.com wrote: >> On 9/21/16 5:53 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Until now, in order to offload a FIB entry to HW we use switchdev op. >>> However that has limits.

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Edward Cree
On 22/09/16 11:33, Paolo Abeni wrote: > Hi Eric, > > On Wed, 2016-09-21 at 16:31 -0700, Eric Dumazet wrote: >> Also does inet_diag properly give the forward_alloc to user ? >> >> $ ss -mua >> State Recv-Q Send-Q Local Address:Port Peer Addres >> s:Port >> UNCONN 51584 0

Re: [PATCH net-next v2 3/3] net: ethernet: mediatek: add the dts property to set if TRGMII supported on GMAC0

2016-09-22 Thread Sean Wang
Date: Thu, 22 Sep 2016 14:28:36 +0300, Sergei Shtylyov wrote: >Hello. > >On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: > >> From: Sean Wang >> >> Add the dts property for the capability if TRGMII supported on GAMC0 >> >>

Fwd: Re: nfs broken on Fedora-24, 32-bit?

2016-09-22 Thread Ben Greear
This is probably not an NFS specific issue, though I guess possibly it is. Forwarding to netdev in case someone wants to take a look at it. Thanks, Ben Forwarded Message Subject: Re: nfs broken on Fedora-24, 32-bit? Date: Fri, 16 Sep 2016 16:31:51 -0700 From: Ben Greear

[RFC] net: store port/representative id in metadata_dst

2016-09-22 Thread Jakub Kicinski
Switches and modern SR-IOV enabled NICs may multiplex traffic from representators and control messages over single set of hardware queues. Control messages and muxed traffic may need ordered delivery. Those requirements make it hard to comfortably use TC infrastructure today unless we have a way

Re: [PATCH net] net: rtnl_register in net_ns_init need rtnl_lock

2016-09-22 Thread Hannes Frederic Sowa
On Thu, Sep 22, 2016, at 19:20, Cong Wang wrote: > > I don't think it is a big issue but wanted the writes to the > > rtnl_msg_handlers array to be strictly serialized. I was working on > > adding this to other places, too. Maybe better for net-next even? > > But they are called during boot, why

CONGRATULATIONS !!!

2016-09-22 Thread Cheveron Texaco
Attention Winner, Congratulations !!! Your email Address has won you a substantial amount of 1 Million United States dollars in the just concluded Chevron Texaco Promo-Lottery. You are to contact your claim agent for claims process at Email: chevron.claimsagent1...@gmail.com Best

Re: [PATCH v1] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Daniel Borkmann
On 09/22/2016 08:35 PM, Mickaël Salaün wrote: This fix a pointer leak when an unprivileged eBPF program read a pointer value from the context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value containing an address is then

Re: [PATCH v1] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Mickaël Salaün
On 22/09/2016 21:41, Daniel Borkmann wrote: > On 09/22/2016 08:35 PM, Mickaël Salaün wrote: >> This fix a pointer leak when an unprivileged eBPF program read a pointer >> value from the context. Even if is_valid_access() returns a pointer >> type, the eBPF verifier replace it with UNKNOWN_VALUE.

[PATCH v2] bpf: Set register type according to is_valid_access()

2016-09-22 Thread Mickaël Salaün
This fix a pointer leak when an unprivileged eBPF program read a pointer value from the context. Even if is_valid_access() returns a pointer type, the eBPF verifier replace it with UNKNOWN_VALUE. The register value containing an address is then allowed to leak. Moreover, this prevented

[PATCH net v2] L2TP:Adjust intf MTU,factor underlay L3,overlay L2

2016-09-22 Thread R. Parameswaran
>From ed585bdd6d3d2b3dec58d414f514cd764d89159d Mon Sep 17 00:00:00 2001 From: "R. Parameswaran" Date: Thu, 22 Sep 2016 13:19:25 -0700 Subject: [PATCH] L2TP:Adjust intf MTU,factor underlay L3,overlay L2 Take into account all of the tunnel encapsulation headers when setting

[PATCH net-next 4/4] net: dsa: mv88e6xxx: implement DSA port fast ageing

2016-09-22 Thread Vivien Didelot
Now that the DSA layer handles port fast ageing on correct STP change, simplify _mv88e6xxx_port_state and implement mv88e6xxx_port_fast_age. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 45 1

[PATCH net-next 3/4] net: dsa: b53: implement DSA port fast ageing

2016-09-22 Thread Vivien Didelot
Remove the fast ageing logic from b53_br_set_stp_state and implement the new DSA switch port_fast_age operation instead. Signed-off-by: Vivien Didelot --- drivers/net/dsa/b53/b53_common.c | 31 +++ 1 file changed, 11

[PATCH net-next 2/4] net: dsa: add port fast ageing

2016-09-22 Thread Vivien Didelot
Today the DSA drivers are in charge of flushing the MAC addresses associated to a port when its STP state changes from Learning or Forwarding, to Disabled or Blocking or Listening. This makes the drivers more complex and hides the generic switch logic. Introduce a new optional port_fast_age

[PATCH net-next 1/4] net: dsa: add port STP state helper

2016-09-22 Thread Vivien Didelot
Add a void helper to set the STP state of a port, checking first if the required routine is provided by the driver. Signed-off-by: Vivien Didelot --- net/dsa/slave.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

[PATCH net-next 0/4] net: dsa: add port fast ageing

2016-09-22 Thread Vivien Didelot
Today the DSA drivers are in charge of flushing the MAC addresses associated to a port when its STP state changes from Learning or Forwarding, to Disabled or Blocking or Listening. This makes the drivers more complex and hides this generic switch logic. This patchset introduces a new optional

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Paolo Abeni
On Thu, 2016-09-22 at 09:30 -0700, Eric Dumazet wrote: > On Thu, 2016-09-22 at 18:14 +0200, Paolo Abeni wrote: > > > I think that the idea behind using atomic ops directly on > > sk_forward_alloc is to avoid adding other fields to the udp_socket. > > > > If we can add some fields to the

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 22:27 +0200, Paolo Abeni wrote: > On Thu, 2016-09-22 at 09:30 -0700, Eric Dumazet wrote: > > On Thu, 2016-09-22 at 18:14 +0200, Paolo Abeni wrote: > > > > > I think that the idea behind using atomic ops directly on > > > sk_forward_alloc is to avoid adding other fields to

Re: [PATCH net-next 2/3] udp: implement memory accounting helpers

2016-09-22 Thread Eric Dumazet
On Thu, 2016-09-22 at 13:34 -0700, Eric Dumazet wrote: > On Thu, 2016-09-22 at 22:27 +0200, Paolo Abeni wrote: > > On Thu, 2016-09-22 at 09:30 -0700, Eric Dumazet wrote: > > > On Thu, 2016-09-22 at 18:14 +0200, Paolo Abeni wrote: > > > > > > > I think that the idea behind using atomic ops

[PATCH net] i40e: disable MSI-X interrupts if we cannot reserve enough vectors

2016-09-22 Thread Guilherme G. Piccoli
If we fail on allocating enough MSI-X interrupts, we should disable them since they were previously enabled in this point of code. Not disabling them can lead to WARN_ON() being triggered and subsequent failure in enabling MSI as a fallback; the below message was shown without this patch while we

[PATCH net 1/2] act_ife: Fix external mac header on encode

2016-09-22 Thread Yotam Gigi
On ife encode side, external mac header is copied from the original packet and may be overridden if the user requests. Before, the mac header copy was done from memory region that might not be accessible anymore, as skb_cow_head might free it and copy the packet. This led to random values in the

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

2016-09-22 Thread Jesper Dangaard Brouer
On Wed, 21 Sep 2016 21:56:58 +0200 Jesper Dangaard Brouer wrote: > > > I'm not opposed to running non-BPF code at XDP. I'm against adding > > > a linked list of hook consumers. > > I also worry about the performance impact of a linked list. We should > simple benchmark it

[PATCH net-next 2/4] net/sched: act_mirred: Refactor detection whether dev needs xmit at mac header

2016-09-22 Thread Shmulik Ladkani
From: Shmulik Ladkani Move detection logic that tests whether device expects skb data to point to mac_header upon xmit into a function. Signed-off-by: Shmulik Ladkani --- net/sched/act_mirred.c | 28 +++- 1 file

[PATCH net-next 1/4] net/sched: act_mirred: Rename tcfm_ok_push to tcfm_mac_header_xmit

2016-09-22 Thread Shmulik Ladkani
From: Shmulik Ladkani 'tcfm_ok_push' specifies whether a mac_len sized push is needed upon egress to the target device (if action is performed at ingress). Rename it to 'tcfm_mac_header_xmit' as this is actually an attribute of the target device. This allows to

Re: [RFC v2 06/12] qedr: Add support for QP verbs

2016-09-22 Thread Leon Romanovsky
On Wed, Sep 21, 2016 at 02:15:39PM +, Amrani, Ram wrote: > > > include/uapi/rdma/providers/qedr-abi.h | 35 + > > > > Please be aware that the last version for ABI header files doesn't have > > "provider" > > name in directory path (include/uapi/rdma/qedr-abi.h) > > OK. Note that I was

<    1   2   3   >