Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

2016-10-13 Thread Cyrill Gorcunov
On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote: > From: Cyrill Gorcunov > Date: Wed, 12 Oct 2016 09:53:29 +0300 > > > I can't rename the field, neither a can use union. > > Remind me again what is wrong with using an anonymous union? Anon union would be a preferred but Eric pointe

Re: [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

2016-10-13 Thread Jiri Pirko
Wed, Oct 12, 2016 at 10:51:50PM CEST, d...@cumulusnetworks.com wrote: >This patch introduces netdev_walk_all_upper_dev_rcu, >netdev_walk_all_lower_dev and netdev_walk_all_lower_dev_rcu. These >functions recursively walk the adj_list of devices to determine all upper >and lower devices. > >The funct

Re: [PATCH net-next 00/11] net: Fix netdev adjacency tracking

2016-10-13 Thread Jiri Pirko
Wed, Oct 12, 2016 at 10:51:48PM CEST, d...@cumulusnetworks.com wrote: >The netdev adjacency tracking is failing to create proper dependencies >for some topologies. For example this topology > >++ >| myvrf | >++ > || > | +-+ >

[patch] tipc: info leak in __tipc_nl_add_udp_addr()

2016-10-13 Thread Dan Carpenter
We should clear out the padding and unused struct members so that we don't expose stack information to userspace. Fixes: fdb3accc2c15 ('tipc: add the ability to get UDP options via netlink') Signed-off-by: Dan Carpenter --- This goes into the net tree. diff --git a/net/tipc/udp_media.c b/net/tip

Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART driver

2016-10-13 Thread Greg Kroah-Hartman
On Thu, Oct 13, 2016 at 10:09:09AM +0200, Stefan Wahren wrote: > > > Stefan Wahren hat am 26. September 2016 um 13:07 > > geschrieben: > > > > > > The Qualcomm QCA7000 HomePlug GreenPHY supports two interfaces: > > UART and SPI. This patch series adds the missing support for UART. > > > > This

Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART driver

2016-10-13 Thread Stefan Wahren
> Stefan Wahren hat am 26. September 2016 um 13:07 > geschrieben: > > > The Qualcomm QCA7000 HomePlug GreenPHY supports two interfaces: > UART and SPI. This patch series adds the missing support for UART. > > This driver based on the Qualcomm code [1], but contains some changes: > * use random

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-13 Thread Eric Dumazet
On Wed, 2016-10-12 at 09:36 -0700, Cong Wang wrote: > On Sun, Oct 9, 2016 at 8:25 PM, Eric Dumazet wrote: > > + if (unicast) > > + return netlink_unicast(net->rtnl, skb, portid, > > MSG_DONTWAIT); > > Nit: rtnl_unicast() is simpler. I copied code in rtnetlink_send(), I guess

[patch -next] net: rtnl: info leak in rtnl_fill_vfinfo()

2016-10-13 Thread Dan Carpenter
The "vf_vlan_info" struct ends with a 2 byte struct hole so we have to memset it to ensure that no stack information is revealed to user space. Fixes: 79aab093a0b5 ('net: Update API for VF vlan protocol 802.1ad support') Signed-off-by: Dan Carpenter diff --git a/net/core/rtnetlink.c b/net/core/r

Re: [patch net-next RFC 0/6] Add support for offloading packet-sampling

2016-10-13 Thread Jiri Pirko
Thu, Oct 13, 2016 at 09:29:57AM CEST, ro...@cumulusnetworks.com wrote: >On 10/12/16, 5:41 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Add the sample tc action, which allows to sample packet matching >> a classifier. The sample action peeks randomly packets, duplicates them, >> truncates them a

Re: slab corruption with current -git

2016-10-13 Thread Markus Trippelsdorf
On 2016.10.13 at 08:02 +0200, Markus Trippelsdorf wrote: > On 2016.10.11 at 04:57 -0400, David Miller wrote: > > From: Linus Torvalds > > Date: Mon, 10 Oct 2016 22:47:50 -0700 > > > > > On Mon, Oct 10, 2016 at 10:39 PM, Linus Torvalds > > > wrote: > > >> > > >> I guess I will have to double-chec

[patch] liquidio: CN23XX: fix a loop timeout

2016-10-13 Thread Dan Carpenter
This is supposed to loop 1000 times and then give up. The problem is it's a post-op and after the loop we test if "loop" is zero when really it would be -1. Fix this by making it a pre-op. Fixes: 1b7c55c4538b ("liquidio: CN23XX queue manipulation") Signed-off-by: Dan Carpenter diff --git a/dri

Re: [PATCH] iwlwifi: pcie: reduce "unsupported splx" to a warning

2016-10-13 Thread Luca Coelho
On Wed, 2016-10-12 at 12:50 -0500, Chris Rorvick wrote: > Hi Luca, > > FYI, It seems that Google does not like your email as I'm not > receiving any of your messages in gmail. Some responses below: That's odd. It works for me. Replied privately to try to sort this out. > On Wed, 2016-10-12 a

Re: [PATCH iproute2] tc: cls_bpf: handle skip_sw and skip_hw flags

2016-10-13 Thread Simon Horman
On Wed, Oct 12, 2016 at 06:03:19PM +0200, Daniel Borkmann wrote: > On 10/12/2016 05:46 PM, Jakub Kicinski wrote: > >Add support for controling hardware offload using (now standard) > >skip_sw and skip_hw flags in cls_bpf. > > > >Signed-off-by: Jakub Kicinski > > Acked-by: Daniel Borkmann Review

Re: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Arnd Bergmann
On Thursday, October 13, 2016 8:50:21 AM CEST Mintz, Yuval wrote: > > config INFINIBAND_QEDR > > - tristate "QLogic qede RoCE sources [debug]" > > + bool "QLogic qede RoCE sources [debug]" > > Given that the qedr submission is going to turn this back into a tristate, > are you certain this is

RE: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Mintz, Yuval
> config INFINIBAND_QEDR > - tristate "QLogic qede RoCE sources [debug]" > + bool "QLogic qede RoCE sources [debug]" Given that the qedr submission is going to turn this back into a tristate, are you certain this is a good thing [from compilation coverage perspective]? > - if

Possible regression on NSFv3/sunrpc timeouts when using NFS_CS_DISCRTRY

2016-10-13 Thread Stefano Panella
Hi all, I think there has been a change in the net/sunrpc code introduced with commit 9cbc94fb06f98de0e8d393eaff09c790f4c3ba46 Author: Trond Myklebust Date: Sun Feb 8 15:50:27 2015 -0500 SUNRPC: Remove TCP socket linger code Now that we no longer use the partial shutdown code when c

Re: [patch net-next RFC 0/6] Add support for offloading packet-sampling

2016-10-13 Thread Roopa Prabhu
On 10/12/16, 5:41 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Add the sample tc action, which allows to sample packet matching > a classifier. The sample action peeks randomly packets, duplicates them, > truncates them and adds informative metadata on the packet, for example, > the input interfac

Re: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Arnd Bergmann
On Thursday, October 13, 2016 9:34:41 AM CEST Mintz, Yuval wrote: > > > > > - if (cond) > > > > + if (IS_ENABLED(CONFIG_INFINIBAND_QEDR) && cond) > > > > qed_rdma_dpm_bar(p_hwfn, p_ptt); > > > > > > Why not simply fix the qed_roce.h empty implementation?

[PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
From: Luca Coelho The SPLC data parsing is too restrictive and was not trying find the correct element for WiFi. This causes problems with some BIOSes where the SPLC method exists, but doesn't have a WiFi entry on the first element of the list. The domain type values are also incorrect accordin

RE: igb driver can cause cache invalidation of non-owned memory?

2016-10-13 Thread David Laight
From: Alexander Duyck > Sent: 12 October 2016 19:30 > On Wed, Oct 12, 2016 at 11:12 AM, Nikita Yushchenko > wrote: > >> It would make more sense to update the DMA API for > >> __dma_page_cpu_to_dev on ARM so that you don't invalidate the cache if > >> the direction is DMA_FROM_DEVICE. > > > > No,

RE: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Mintz, Yuval
> > > > While I don't mind, you could have argued is that we're not > > > > removing enough, not too much. > > > > I.e., perhaps the rdma_msix_* fields should also have been > > > > ifdef-ed instead. [in which case this solution would not have > > > > worked] > > > > > > That would add even more #i

Re: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Arnd Bergmann
On Thursday, October 13, 2016 10:44:36 AM CEST Mintz, Yuval wrote: > > > > > While I don't mind, you could have argued is that we're not > > > > > removing enough, not too much. > > > > > I.e., perhaps the rdma_msix_* fields should also have been > > > > > ifdef-ed instead. [in which case this solu

RE: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-13 Thread Koehrer Mathias (ETAS/ESW5)
Hi all! > > Hi Julia, > > thanks for the detailed analysis! > > > > [...] > > Okay, we finally received our wakeup event. We were expecting to be > > woken up at 10024735653388ns, but were actually woken up at > 10024735682387ns. > > > > 10024735682387 - 10024735653388 = 28999ns > > > > Our ti

Re: igb driver can cause cache invalidation of non-owned memory?

2016-10-13 Thread Nikita Yushchenko
>>> It would make more sense to update the DMA API for >>> __dma_page_cpu_to_dev on ARM so that you don't invalidate the cache if >>> the direction is DMA_FROM_DEVICE. >> >> No, in generic case it's unsafe. >> >> If CPU issued a write to a location, and sometime later that location is >> used as DM

RE: [PATCH] qede: fix CONFIG_INFINIBAND_QEDR=m build error

2016-10-13 Thread Mintz, Yuval
> > > - if (cond) > > > + if (IS_ENABLED(CONFIG_INFINIBAND_QEDR) && cond) > > > qed_rdma_dpm_bar(p_hwfn, p_ptt); > > > > Why not simply fix the qed_roce.h empty implementation? > > Mainly for consistency: we have a couple of interfaces that are called from > the

RE: [PATCH V2 for-next 0/8] Bug Fixes and Code Improvement in HNS driver

2016-10-13 Thread Salil Mehta
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, September 30, 2016 6:34 AM > To: Salil Mehta > Cc: dledf...@redhat.com; Zhuangyuzeng (Yisen); Huwei (Xavier); oulijun; > mehta.salil@gmail.com; linux-r...@vger.kernel.org; > netdev@vger.kernel.org; li

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
Luca, On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Paul Bolle Not that this test was worth a lot: it builds cleanly (on top of 4.8.1), the error at b

[PATCH] net: axienet: Remove unused parameter from __axienet_device_reset

2016-10-13 Thread Tobias Klauser
The dev parameter passed to __axienet_device_reset() is not used inside the function, so remove it. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/xilinx/xili

Re: [PATCH iproute2 1/1] tc filters: add support to get individual filters by handle

2016-10-13 Thread Jamal Hadi Salim
On 16-10-12 12:46 PM, Cong Wang wrote: On Mon, Oct 10, 2016 at 9:45 AM, Jamal Hadi Salim wrote: tc/tc_filter.c | 185 + 1 file changed, 175 insertions(+), 10 deletions(-) Please update man/man8/tc.8 too, but can be a separated patch. ;)

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 13:27 +0200, Paul Bolle wrote: > Luca, > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Paul Bolle > > Not that this

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-13 Thread Jamal Hadi Salim
On 16-10-13 03:46 AM, Eric Dumazet wrote: On Wed, 2016-10-12 at 09:36 -0700, Cong Wang wrote: On Sun, Oct 9, 2016 at 8:25 PM, Eric Dumazet wrote: + if (unicast) + return netlink_unicast(net->rtnl, skb, portid, MSG_DONTWAIT); Nit: rtnl_unicast() is simpler. I copied code

Re: [PATCH v4 net-next 1/4] net/sched: act_mirred: Rename tcfm_ok_push to tcfm_mac_header_xmit and make it a bool

2016-10-13 Thread Jamal Hadi Salim
On 16-10-13 02:06 AM, Shmulik Ladkani wrote: 'tcfm_ok_push' specifies whether a mac_len sized push is needed upon egress to the target device (if action is performed at ingress). Rename it to 'tcfm_mac_header_xmit' as this is actually an attribute of the target device (and use a bool instead of

Re: [PATCH v4 net-next 2/4] net/sched: act_mirred: Refactor detection whether dev needs xmit at mac header

2016-10-13 Thread Jamal Hadi Salim
On 16-10-13 02:06 AM, Shmulik Ladkani wrote: Move detection logic that tests whether device expects skb data to point at mac_header upon xmit into a function. Signed-off-by: Shmulik Ladkani Acked-by: Jamal Hadi Salim

Re: [PATCH V2 for-next 0/8] Bug Fixes and Code Improvement in HNS driver

2016-10-13 Thread Doug Ledford
On 10/13/2016 7:26 AM, Salil Mehta wrote: >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Friday, September 30, 2016 6:34 AM >> To: Salil Mehta >> Cc: dledf...@redhat.com; Zhuangyuzeng (Yisen); Huwei (Xavier); oulijun; >> mehta.salil@gmail.com; linux-r.

[PATCH v2 net-next 2/7] qede: GSO support for tunnels with outer csum

2016-10-13 Thread Manish Chopra
From: Manish Chopra This patch adds GSO support for GRE and UDP tunnels where outer checksums are enabled. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 1 + drivers/net/ethernet/qlogic/qede/qede_main.c | 26 +++

[PATCH v2 net-next 1/7] qed: Pass MAC hints to VFs

2016-10-13 Thread Manish Chopra
From: Yuval Mintz Some hypervisors can support MAC hints to their VFs. Even though we don't have such a hypervisor API in linux, we add sufficient logic for the VF to be able to receive such hints and set the mac accordingly - as long as the VF has not been set with a MAC already. Signed-off-by:

[PATCH v2 net-next 4/7] qed*: Allow unicast filtering

2016-10-13 Thread Manish Chopra
From: Yuval Mintz Apparently qede fails to set IFF_UNICAST_FLT, and as a result is not actually performing unicast MAC filtering. While we're at it - relax a hard-coded limitation that limits each interface into using at most 15 unicast MAC addresses before turning promiscuous. Instead utilize th

[PATCH v2 net-next 3/7] qede: Prevent GSO on long Geneve headers

2016-10-13 Thread Manish Chopra
From: Manish Chopra Due to hardware limitation, when transmitting a geneve-encapsulated packet with more than 32 bytes worth of geneve options the hardware would not be able to crack the packet and consider it a regular UDP packet. This implements the ndo_features_check() in qede in order to pre

[PATCH v2 net-next 6/7] qed: Handle malicious VFs events

2016-10-13 Thread Manish Chopra
From: Yuval Mintz Malicious VFs might be caught in several different methods: - Misusing their bar permission and being blocked by hardware. - Misusing their fastpath logic and being blocked by firmware. - Misusing their interaction with their PF via hw-channel, and being blocked by PF

[PATCH v2 net-next 5/7] qed: Allow chance for fast ramrod completions

2016-10-13 Thread Manish Chopra
From: Yuval Mintz Whenever a ramrod is being sent for some device configuration, the driver is going to sleep at least 5ms between each iteration of polling on the completion of the ramrod. However, in almost every configuration scenario the firmware would be able to comply and complete the ramr

[PATCH v2 net-next 7/7] qed: Fix possible race when reading firmware return code.

2016-10-13 Thread Manish Chopra
From: Manish Chopra While handling SPQ ramrod completion, there is a possible race where driver might not read updated fw return code based on ramrod completion done. This patch ensures that fw return code is written first and then completion done flag is updated using appropriate memory barriers

Re: [PATCH v4 net-next 3/4] net/sched: tc_mirred: Rename public predicates 'is_tcf_mirred_redirect' and 'is_tcf_mirred_mirror'

2016-10-13 Thread Jamal Hadi Salim
On 16-10-13 02:06 AM, Shmulik Ladkani wrote: These accessors are used in various drivers that support tc offloading, to detect properties of a given 'tc_action'. 'is_tcf_mirred_redirect' tests that the action is TCA_EGRESS_REDIR. 'is_tcf_mirred_mirror' tests that the action is TCA_EGRESS_MIRROR.

[PATCH v2 net-next 0/7] qed*: driver updates

2016-10-13 Thread Manish Chopra
From: Manish Chopra Hi David, There are several new additions in this series; Most are connected to either Tx offloading or Rx classifications [either fastpath changes or supporting configuration]. In addition, there's a single IOV enhancement. Please consider applying this series to `net-next

Re: [PATCH v4 net-next 4/4] net/sched: act_mirred: Implement ingress actions

2016-10-13 Thread Jamal Hadi Salim
On 16-10-13 02:06 AM, Shmulik Ladkani wrote: Up until now, 'action mirred' supported only egress actions (either TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). This patch implements the corresponding ingress actions TCA_INGRESS_REDIR and TCA_INGRESS_MIRROR. This allows attaching filters whose target i

Re: [patch net-next RFC 0/6] Add support for offloading packet-sampling

2016-10-13 Thread Jiri Pirko
Thu, Oct 13, 2016 at 01:49:07PM CEST, j...@mojatatu.com wrote: >On 16-10-13 04:48 AM, Jiri Pirko wrote: >> Thu, Oct 13, 2016 at 09:29:57AM CEST, ro...@cumulusnetworks.com wrote: >> > On 10/12/16, 5:41 AM, Jiri Pirko wrote: >> > > From: Jiri Pirko >> > > >[..] >> > >> > we spoke with yotam about

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > I forgot to say... could you load the iwlwifi module with debug=0x01 > (module parameter), so we can see the messages the driver is printing > when it doesn't find a proper structure? That makes a lot of noise! Here's the first 100 lines or s

Re: [patch net-next RFC 0/6] Add support for offloading packet-sampling

2016-10-13 Thread Jamal Hadi Salim
On 16-10-13 08:10 AM, Jiri Pirko wrote: Thu, Oct 13, 2016 at 01:49:07PM CEST, j...@mojatatu.com wrote: On 16-10-13 04:48 AM, Jiri Pirko wrote: [..] Roopa, did you mean eth1 as the new device or did you mean just in general config requiring a device to be specified or did you mean a new cpu ne

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 14:36 +0200, Paul Bolle wrote: > On Thu, 2016-10-13 at 14:30 +0300, Luca Coelho wrote: > > I forgot to say... could you load the iwlwifi module with debug=0x01 > > (module parameter), so we can see the messages the driver is printing > > when it doesn't find a proper structure

Re: [patch net-next RFC 0/6] Add support for offloading packet-sampling

2016-10-13 Thread Jiri Pirko
Thu, Oct 13, 2016 at 02:30:19PM CEST, j...@mojatatu.com wrote: >On 16-10-13 08:10 AM, Jiri Pirko wrote: >> Thu, Oct 13, 2016 at 01:49:07PM CEST, j...@mojatatu.com wrote: >> > On 16-10-13 04:48 AM, Jiri Pirko wrote: > >[..] >> > Roopa, did you mean eth1 as the new device or did you mean just in >> >

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Paul Bolle
On Thu, 2016-10-13 at 15:44 +0300, Luca Coelho wrote: >  Even though there is apparently something wrong with this part of the > ACPI table on you laptop, since it doesn't match our specifications. >  In any case, it's mostly harmless. Would a correct implementation by Dell have any benefits for t

Re: [patch net-next RFC 0/6] Add support for offloading packet-sampling

2016-10-13 Thread Jamal Hadi Salim
On 16-10-13 04:48 AM, Jiri Pirko wrote: Thu, Oct 13, 2016 at 09:29:57AM CEST, ro...@cumulusnetworks.com wrote: On 10/12/16, 5:41 AM, Jiri Pirko wrote: From: Jiri Pirko [..] we spoke with yotam about this at netdev1.2. and also remember speaking about this on our switchdev calls: Today our

Re: [PATCH RFC v2 net-next 0/8] net: qualcomm: add QCA7000 UART driver

2016-10-13 Thread Greg Kroah-Hartman
On Thu, Oct 13, 2016 at 10:09:09AM +0200, Stefan Wahren wrote: > > > Stefan Wahren hat am 26. September 2016 um 13:07 > > geschrieben: > > > > > > The Qualcomm QCA7000 HomePlug GreenPHY supports two interfaces: > > UART and SPI. This patch series adds the missing support for UART. > > > > This

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-13 Thread Christian König
Am 13.10.2016 um 02:20 schrieb Lorenzo Stoakes: This patch series adjusts functions in the get_user_pages* family such that desired FOLL_* flags are passed as an argument rather than implied by flags. The purpose of this change is to make the use of FOLL_FORCE explicit so it is easier to grep fo

[PATCH net] net: bridge: add the multicast_flood flag attribute to brport_attrs

2016-10-13 Thread Nikolay Aleksandrov
When I added the multicast flood control flag, I also added an attribute for it for sysfs similar to other flags, but I forgot to add it to brport_attrs. Fixes: b6cb5ac8331b ("net: bridge: add per-port multicast flood flag") Signed-off-by: Nikolay Aleksandrov --- net/bridge/br_sysfs_if.c | 1 +

Re: [PATCH v3 net-next 0/2] net: centralize net_device MTU bounds checking

2016-10-13 Thread David Miller
From: Jarod Wilson Date: Fri, 7 Oct 2016 22:04:32 -0400 > While looking into an MTU issue with sfc, I started noticing that almost > every NIC driver with an ndo_change_mtu function implemented almost > exactly the same range checks, and in many cases, that was the only > practical thing their n

Re: [PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-10-13 Thread LABBE Corentin
On Mon, Oct 10, 2016 at 10:13:35AM -0500, Rob Herring wrote: > On Fri, Oct 07, 2016 at 10:25:50AM +0200, Corentin Labbe wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: Corentin Labbe > > --- > > .../bindings/net/al

Re: [PATCH] vmxnet3: avoid assumption about invalid dma_pa in vmxnet3_set_mc()

2016-10-13 Thread David Miller
From: Alexey Khoroshilov Date: Fri, 7 Oct 2016 22:53:43 -0400 > vmxnet3_set_mc() still assumes zero is invalid pa: > it assumes dma_mapping_error(...,0) returns true if vmxnet3_copy_mc() fails; > it calls dma_unmap_single() iff new_table_pa is not zero. > > The patch adds an explicit variab

Re: [PATCH net-next] sctp: remove the old ttl expires policy

2016-10-13 Thread David Miller
From: Xin Long Date: Sat, 8 Oct 2016 11:40:16 +0800 > The prsctp polices include ttl expires policy already, we should remove > the old ttl expires codes, and just adjust the new polices' codes to be > compatible with the old one for users. > > This patch is to remove all the old expires codes,

Re: [PATCH net-next] sctp: reuse sent_count to avoid retransmitted chunks for RTT measurements

2016-10-13 Thread David Miller
From: Xin Long Date: Sat, 8 Oct 2016 11:36:05 +0800 > Now sctp uses chunk->resent to record if a chunk is retransmitted, for > RTT measurements with retransmitted DATA chunks. chunk->sent_count was > introduced to record how many times one chunk has been sent for prsctp > RTX policy before. We a

Re: [PATCH v2 1/3] net: smc91x: isolate u16 writes alignment workaround

2016-10-13 Thread David Miller
From: Robert Jarzmik Date: Sun, 9 Oct 2016 22:33:45 +0200 > Writes to u16 has a special handling on 3 PXA platforms, where the > hardware wiring forces these writes to be u32 aligned. > > This patch isolates this handling for PXA platforms as before, but > enables this "workaround" to be set up

Re: [PATCH v2] qed: Fix to use list_for_each_entry_safe() when delete items

2016-10-13 Thread David Miller
From: Wei Yongjun Date: Mon, 10 Oct 2016 14:08:28 + > From: Wei Yongjun > > Since we will remove items off the list using list_del() we need > to use a safe version of the list_for_each_entry() macro aptly named > list_for_each_entry_safe(). > > Signed-off-by: Wei Yongjun > Acked-by: Yuva

Re: [PATCH] qed: Fix to use list_for_each_entry_safe() when delete items

2016-10-13 Thread David Miller
From: Wei Yongjun Date: Sun, 9 Oct 2016 13:32:22 + > From: Wei Yongjun > > Since we will remove items off the list using list_del() we need > to use a safe version of the list_for_each_entry() macro aptly named > list_for_each_entry_safe(). > > Fixes: 0a7fb11c23c0 ("qed: Add Light L2 supp

Re: [PATCH] qed: fix old-style function definition

2016-10-13 Thread David Miller
From: Arnd Bergmann Date: Mon, 10 Oct 2016 13:59:16 +0200 > The definition of qed_get_rdma_ops() is not a prototype unless > we add 'void' here, as indicated by this W=1 warning: > > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’: > drivers/net/ethernet/qlogic/qed/qed

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Chris Rorvick
Hi Luca, > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > Could you please give this a spin? I have tested it with some handmade > ACPI tables in QEMU and it seems to work fine now. Tested-by: Chris Rorvick I think the debug output looks as expected, see below for the first 20 lines or

Re: [PATCH] tlan: avoid unused label with PCI=n

2016-10-13 Thread David Miller
From: Arnd Bergmann Date: Mon, 10 Oct 2016 14:41:10 +0200 > While build testing with randconfig on x86, I ran into this warning > that appears to have been around forever > > drivers/net/ethernet/ti/tlan.c: In function ‘tlan_probe1’: > drivers/net/ethernet/ti/tlan.c:614:1: error: label ‘err_out’

Re: [PATCH net] xen-netback: (re-)create a debugfs node for hash information

2016-10-13 Thread David Miller
From: Paul Durrant Date: Mon, 10 Oct 2016 09:30:53 +0100 > From: Paul Durrant > > It is useful to be able to see the hash configuration when running tests. > This patch adds a debugfs node for that purpose. > > The original version of this patch (commit c0c64c152389) was reverted due > to buil

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
On (10/13/16 08:02), Johannes Berg wrote: > On Wed, 2016-10-12 at 22:39 -0700, Andy Lutomirski wrote: > > > In a pinch, I have these patches sitting around: > > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=x86/vmap_stack&id=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd > >

Re: [PATCH net] net_sched: do not broadcast RTM_GETTFILTER result

2016-10-13 Thread David Miller
From: Eric Dumazet Date: Sun, 09 Oct 2016 20:25:55 -0700 > From: Eric Dumazet > > There are two ways to get tc filters from kernel to user space. > > 1) Full dump (tc_dump_tfilter()) > 2) RTM_GETTFILTER to get one precise filter, reducing overhead. > > The second operation is unfortunately br

Re: [PATCH net 0/3] openvswitch: vlan fixes

2016-10-13 Thread David Miller
From: Jiri Benc Date: Mon, 10 Oct 2016 17:02:41 +0200 > Fix three issues introduced by the 802.1AD patchset. Series applied, thanks Jiri.

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
On (10/13/16 22:42), Sergey Senozhatsky wrote: > > On (10/13/16 08:02), Johannes Berg wrote: > > On Wed, 2016-10-12 at 22:39 -0700, Andy Lutomirski wrote: > > > > > In a pinch, I have these patches sitting around: > > > > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=

Re: [PATCH net-next v10 1/1] net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.

2016-10-13 Thread David Miller
From: "Allan W. Nielsen" Date: Mon, 10 Oct 2016 16:13:45 +0200 > Edge-Rate cleanup include the following: > - Updated device tree bindings documentation for edge-rate > - The edge-rate is now specified as a "slowdown", meaning that it is now > being specified as positive values instead of negat

Re: [PATCH net] qmi_wwan: add support for Quectel EC21 and EC25

2016-10-13 Thread David Miller
From: Bjørn Mork Date: Mon, 10 Oct 2016 21:12:49 +0200 > The Quectel EC21 and EC25 need the same "set DTR" request as devices > based on the MDM9230 chipset, but has no USB3 support. Our best guess > is that the "set DTR" functionality depends on chipset and/or > baseband firmware generation. But

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Johannes Berg
On Thu, 2016-10-13 at 22:42 +0900, Sergey Senozhatsky wrote: >  > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commi > > > t/?h=x86/vmap_stack&id=0a39cfa6fbb5d5635c85253cc7d6b44b54822afd > > > https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commi > > > t/?h=x86/vmap_s

Re: [PATCH] drivers/ptp: Fix kernel memory disclosure

2016-10-13 Thread David Miller
From: Vlad Tsyrklevich Date: Tue, 11 Oct 2016 15:02:47 +0200 > The reserved field precise_offset->rsv is not cleared before being > copied to user space, leaking kernel stack memory. Clear the struct > before it's copied. > > Signed-off-by: Vlad Tsyrklevich Applied and queued up for -stable, t

Re: [PATCH V2 net-next] net/mlx5: Add MLX5_ARRAY_SET64 to fix BUILD_BUG_ON

2016-10-13 Thread David Miller
From: Saeed Mahameed Date: Wed, 12 Oct 2016 04:57:10 +0300 > From: Tom Herbert > > I am hitting this in mlx5: > > drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c: In function > reclaim_pages_cmd.clone.0: > drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:346: error: call > to __compilet

Re: [PATCHv1 net] xen-netback: fix guest Rx stall detection (after guest Rx refactor)

2016-10-13 Thread David Miller
From: David Vrabel Date: Tue, 11 Oct 2016 16:48:27 +0100 > If a VIF has been ready for rx_stall_timeout (60s by default) and an > Rx ring is drained of all requests an Rx stall will be incorrectly > detected. When this occurs and the guest Rx queue is empty, the Rx > ring's event index will not

Re: [PATCH 4/6] fjes: Implement debug mode for fjes driver

2016-10-13 Thread David Miller
From: Taku Izumi Date: Tue, 11 Oct 2016 17:55:20 +0900 > This patch implements debug mode for fjes driver. > You can get firmware activity information by enabling > debug mode. This is useful for debugging. > > To enable debug mode, write value of debugging mode to > debug_mode file in debugfs:

Re: [PATCH] iwlwifi: pcie: fix SPLC structure parsing

2016-10-13 Thread Luca Coelho
On Thu, 2016-10-13 at 08:56 -0500, Chris Rorvick wrote: > Hi Luca, > > > On Thu, 2016-10-13 at 13:21 +0300, Luca Coelho wrote: > > Could you please give this a spin? I have tested it with some handmade > > ACPI tables in QEMU and it seems to work fine now. > > > Tested-by: Chris Rorvick > > I

RE: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

2016-10-13 Thread David Laight
From: Koehrer Mathias > Sent: 13 October 2016 11:57 .. > > The time between my trace points 700 and 701 is about 30us, the time > > between my > > trace points 600 and 601 is even 37us!! > > The code in between is > > tsyncrxctl = rd32(E1000_TSYNCRXCTL); resp. > > lvmmc = rd32(E1000_LVMM

Re: [PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"

2016-10-13 Thread David Miller
From: Stephen Hemminger Date: Tue, 11 Oct 2016 13:04:09 -0700 > This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5. > > The code has been in kernel since 4.4 but there are no in tree > code that uses. Unused code is broken code, remove it. > > Signed-off-by: Stephen Hemminger Tom if

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header,Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread David Miller
From: Doug Ledford Date: Thu, 13 Oct 2016 10:35:35 -0400 > On 10/13/2016 10:24 AM, David Miller wrote: >> From: Paolo Abeni >> Date: Tue, 11 Oct 2016 19:15:44 +0200 >> >>> After the commit 9207f9d45b0a ("net: preserve IP control block >>> during GSO segmentation"), the GSO CB and the IPoIB CB c

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread Doug Ledford
On 10/13/2016 10:24 AM, David Miller wrote: > From: Paolo Abeni > Date: Tue, 11 Oct 2016 19:15:44 +0200 > >> After the commit 9207f9d45b0a ("net: preserve IP control block >> during GSO segmentation"), the GSO CB and the IPoIB CB conflict. >> That destroy the IPoIB address information cached ther

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread David Miller
From: Zach Brown Date: Tue, 11 Oct 2016 15:26:20 -0500 > From: Josh Cartwright > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > create a set of led triggers for each instantiated PHY device. There is > one LED trigger per link-speed, per-phy. > > This allows for a user to

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread David Miller
From: Paolo Abeni Date: Tue, 11 Oct 2016 19:15:44 +0200 > After the commit 9207f9d45b0a ("net: preserve IP control block > during GSO segmentation"), the GSO CB and the IPoIB CB conflict. > That destroy the IPoIB address information cached there, > causing a severe performance regression, as bett

Re: [PATCH net] netvsc: fix checksum on UDP IPV6

2016-10-13 Thread David Miller
From: Stephen Hemminger Date: Tue, 11 Oct 2016 14:03:07 -0700 > The software calculation of UDP checksum in Netvsc driver was > only handling IPv4 case. By using skb_checksum_help() instead > all protocols can be handled. Rearrange code to eliminate goto > and look like other drivers. > > This i

Re: [PATCH net-next v2] bridge: add address and vlan to fdb warning messages

2016-10-13 Thread David Miller
From: Roopa Prabhu Date: Tue, 11 Oct 2016 16:12:56 -0700 > From: Roopa Prabhu > > This patch adds vlan and address to warning messages printed > in the bridge fdb code for debuggability. > > Signed-off-by: Roopa Prabhu Applied, thanks Roopa.

Re: [PATCH] qed: fix old-style function definition

2016-10-13 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 13 Oct 2016 14:15:51 + >> > The definition of qed_get_rdma_ops() is not a prototype unless we add >> > 'void' here, as indicated by this W=1 warning: >> > >> > drivers/net/ethernet/qlogic/qed/qed_roce.c: In function ‘qed_get_rdma_ops’: >> > drivers/net/ethernet

Re: [Patch net] net_sched: reorder pernet ops and act ops registrations

2016-10-13 Thread David Miller
From: Cong Wang Date: Tue, 11 Oct 2016 10:56:45 -0700 > Krister reported a kernel NULL pointer dereference after > tcf_action_init_1() invokes a_o->init(), it is a race condition > where one thread calling tcf_register_action() to initialize > the netns data after putting act ops in the global li

Re: [PATCH] qed: Fix to use list_for_each_entry_safe() when delete items

2016-10-13 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 13 Oct 2016 14:14:40 + >> > Since we will remove items off the list using list_del() we need to >> > use a safe version of the list_for_each_entry() macro aptly named >> > list_for_each_entry_safe(). >> > >> > Fixes: 0a7fb11c23c0 ("qed: Add Light L2 support") >

Re: [PATCH] net: axienet: Remove unused parameter from __axienet_device_reset

2016-10-13 Thread Tobias Klauser
On 2016-10-13 at 14:23:49 +0200, Michal Simek wrote: > On 13.10.2016 13:28, Tobias Klauser wrote: > > The dev parameter passed to __axienet_device_reset() is not used inside > > the function, so remove it. > > > > Signed-off-by: Tobias Klauser > > --- > > drivers/net/ethernet/xilinx/xilinx_axie

Re: [PATCH net 0/3] s390 network driver patches

2016-10-13 Thread David Miller
From: Ursula Braun Date: Wed, 12 Oct 2016 12:38:48 +0200 > here are 3 small patches for the s390 network drivers netiucv and lcs. > They are built for the net-tree. Series applied, thanks.

Re: [PATCH (net.git) 1/2] stmmac: fix ptp init for gmac4

2016-10-13 Thread David Miller
From: Giuseppe Cavallaro Date: Wed, 12 Oct 2016 15:42:03 +0200 > The gmac 4.x version has not extended descriptors > (that are available on 3.x instead of). > While initializing the PTP module, the advanced PTP was > enabled in case of extended descriptors. This cannot be > applied for 4.x versio

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
: kernel: Oops: [#1] PREEMPT SMP kernel: Modules linked in: nls_iso8859_1 nls_cp437 vfat fat mousedev psmouse serio_raw atkbd libps2 i915 coretemp i2c_algo_bit hwmon crc32c_intel mxm_wmi drm_kms_helper cfbfillrect syscopyarea cfbimgblt sysfillrect iwlmvm sysimgblt fb_sys_fops i2c_

Re: [PATCH (net.git) 2/2] stmmac: fix error check when init ptp

2016-10-13 Thread David Miller
From: Giuseppe Cavallaro Date: Wed, 12 Oct 2016 15:42:04 +0200 > This patch fixes a problem when propagated the > failure of ptp_clock_register to open function. > > Signed-off-by: Giuseppe Cavallaro Applied.

[PATCH net-next] Documentation/networking: update git urls to use https over http

2016-10-13 Thread Alexander Alemayhu
This fixes the following errors when trying to clone the urls: Cloning into 'net'... fatal: repository 'http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/' not found Cloning into 'net-next'... fatal: repository 'http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/' not found C

Re: [PATCH] xen-netback: fix type mismatch warning

2016-10-13 Thread David Miller
From: Arnd Bergmann Date: Wed, 12 Oct 2016 16:54:01 +0200 > Wiht the latest rework of the xen-netback driver, we get a warning > on ARM about the types passed into min(): > > drivers/net/xen-netback/rx.c: In function 'xenvif_rx_next_chunk': > include/linux/kernel.h:739:16: error: comparison of d

Re: [PATCH net] Revert "net: Add driver helper functions to determine checksum offloadability"

2016-10-13 Thread Jonathan Cooper
On 13/10/16 15:35, David Miller wrote: From: Stephen Hemminger Date: Tue, 11 Oct 2016 13:04:09 -0700 This reverts commit 6ae23ad36253a8033c5714c52b691b84456487c5. The code has been in kernel since 4.4 but there are no in tree code that uses. Unused code is broken code, remove it. Signed-off-

Re: [PATCH] IB/ipoib: move back the IB LL address into the hard header

2016-10-13 Thread Paolo Abeni
On Thu, 2016-10-13 at 10:24 -0400, David Miller wrote: > From: Paolo Abeni > Date: Tue, 11 Oct 2016 19:15:44 +0200 > > > After the commit 9207f9d45b0a ("net: preserve IP control block > > during GSO segmentation"), the GSO CB and the IPoIB CB conflict. > > That destroy the IPoIB address informati

Re: [mac80211] BUG_ON with current -git (4.8.0-11417-g24532f7)

2016-10-13 Thread Sergey Senozhatsky
On (10/14/16 00:00), Sergey Senozhatsky wrote: > kernel: [] ieee80211_crypto_ccmp_decrypt+0x204/0x298 > kernel: [] ieee80211_rx_handlers+0x7df/0x1c1d > kernel: [] ieee80211_prepare_and_rx_handle+0xdc2/0xe79 > kernel: [] ? ieee80211_rx_napi+0x168/0x7b6 > kernel: [] ieee80211_rx_napi+0x48b/0x7b6

Re: [PATCH net-next 00/11] net: Fix netdev adjacency tracking

2016-10-13 Thread David Ahern
On 10/13/16 1:34 AM, Jiri Pirko wrote: > > Although I didn't like the "all-list" idea when Veaceslav pushed it > because it looked to me like a big hammer, it turned out to be very handy > and quick for traversing neighbours. Why it cannot be fixed? > > The walks with possibly hundreds of functio

  1   2   >