Re: [NETPOLL] netconsole: fix soft lockup when removing module

2007-07-02 Thread Jarek Poplawski
On Sun, Jul 01, 2007 at 09:35:58PM +0400, Oleg Nesterov wrote: Jarek Poplawski wrote: #1 Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work() required a work function should always (unconditionally) rearm with delay 0 - otherwise it would endlessly loop. This

[PATCH] Re: [NETPOLL] netconsole: fix soft lockup when removing module

2007-07-02 Thread Jarek Poplawski
From my recent patch: #1 Until kernel ver. 2.6.21 (including) cancel_rearming_delayed_work() required a work function should always (unconditionally) rearm with delay 0 - otherwise it would endlessly loop. This patch replaces this function with cancel_delayed_work().

Re: quirk_e100_interrupt() called too early

2007-07-02 Thread Nils Rennebarth
Bjorn Helgaas wrote: On Thursday 28 June 2007 10:01:08 am Kok, Auke wrote: I copied Nils Rennebarth, who originally reported the bug: http://bugzilla.kernel.org/show_bug.cgi?id=5918 in case he can test your patch. Most of the embedded boards we now work with appear to exhibit the same

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-07-02 Thread Johannes Berg
On Sat, 2007-06-30 at 11:32 -0400, jamal wrote: +static void genl_unregister_mc_group(struct genl_multicast_group *grp) +{ + /* +* TODO: fix multicast group re-use by clearing the bit +* for this group in all genetlink sockets. +*/ + clear_bit(grp-id,

Re: [PATCH] Re: [NETPOLL] netconsole: fix soft lockup when removing module

2007-07-02 Thread Oleg Nesterov
On 07/02, Jarek Poplawski wrote: diff -Nurp 2.6.22-rc7-/net/core/netpoll.c 2.6.22-rc7/net/core/netpoll.c --- 2.6.22-rc7-/net/core/netpoll.c2007-07-02 09:03:27.0 +0200 +++ 2.6.22-rc7/net/core/netpoll.c 2007-07-02 09:32:34.0 +0200 @@ -72,8 +72,7 @@ static void

Re: [NETPOLL] netconsole: fix soft lockup when removing module

2007-07-02 Thread Oleg Nesterov
On 07/02, Jarek Poplawski wrote: --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -72,7 +72,8 @@ static void queue_process(struct work_struct *work) netif_tx_unlock(dev); local_irq_restore(flags); -

[PATCH 2/2][NETPOLL] netconsole: delete flush_scheduled_work

2007-07-02 Thread Jarek Poplawski
On Mon, Jul 02, 2007 at 12:59:49PM +0400, Oleg Nesterov wrote: ... While you are here, could you also delete this flush_scheduled_work() ? It is not needed any longer. Yes. I've thought about this, and even planned to mention, but then forgotten... Of course, you are right, but since it stayed

Re: sky2 hangs without any messages

2007-07-02 Thread Daniel J Blueman
Hi Stephen, Tino Keitel [EMAIL PROTECTED] wrote: in the last 2 days, I had 2 outages of the NIC of my Mac mini Core Duo. I checked the kernel log but I found nothing sky2 related. After reloading the module, the interface worked again. There is a reproducible hang (due to missed IRQ) in

Re: r8169 2.2LK: Low link speed after suspend

2007-07-02 Thread Jens Stroebel
Francois Romieu wrote: Francois Romieu [EMAIL PROTECTED] : [...] The patch will not apply directly against 2.6.21.5. Is it an option for you to try 2.6.22-rc6 or are you stuck with 2.6.21.5 ? If you feel adventurous, you will find a compile-tested-only patchkit for 2.6.21.5 here:

Re: [NETPOLL] netconsole: fix soft lockup when removing module

2007-07-02 Thread Jarek Poplawski
On Mon, Jul 02, 2007 at 01:24:08PM +0400, Oleg Nesterov wrote: On 07/02, Jarek Poplawski wrote: --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -72,7 +72,8 @@ static void queue_process(struct work_struct *work) netif_tx_unlock(dev);

Re: r8169 2.2LK: Low link speed after suspend

2007-07-02 Thread Jens Stroebel
Jens Stroebel wrote: Francois Romieu wrote: Francois Romieu [EMAIL PROTECTED] : [...] The patch will not apply directly against 2.6.21.5. Is it an option for you to try 2.6.22-rc6 or are you stuck with 2.6.21.5 ? If you feel adventurous, you will find a compile-tested-only patchkit for

[PATCH/RESENT] ehea: Whitespace cleanup

2007-07-02 Thread Jan-Bernd Themann
This patch fixes several whitespace issues. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h index c0f81b5..abaf3ac 100644 --- a/drivers/net/ehea/ehea.h +++ b/drivers/net/ehea/ehea.h @@ -39,7 +39,7 @@ #include asm/io.h

Re: Please pull 'libertas-fixes' branch of wireless-2.6

2007-07-02 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 189548642c5962e60c3667bdb3a703fe0bed12a6: Linus Torvalds (1): Linus 2.6.22-rc6 are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git libertas-fixes Dan Williams (4):

Re: Please pull from 'from_linus' branch

2007-07-02 Thread Jeff Garzik
Kumar Gala wrote: Please pull from 'for_linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git for_linus to receive the following updates: drivers/net/gianfar.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Kumar Gala (1): gianfar: Fix typo

Re: [PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

2007-07-02 Thread Jeff Garzik
Veena Parat wrote: 1.Removed MSI support from driver - unused feature 2.Removed pci_request_regions call to allocate bar2 as it is not used in driver 3.Removed pci_release_regions since pci_request_regions is not done This is wrong. pci_request_regions() grabs all the regions for the

Re: [PATCH 2.6.22 1/4]S2IO: Adding checks to check the return value of pci mapping function

2007-07-02 Thread Jeff Garzik
Veena Parat wrote: Adding checks to check the return value of pci mapping function Signed-off-by: Veena Parat [EMAIL PROTECTED] --- diff -urpN org/drivers/net/s2io.c patch_1/drivers/net/s2io.c --- org/drivers/net/s2io.c 2007-05-17 20:35:39.0 +0530 +++ patch_1/drivers/net/s2io.c

Re: [PATCH] myri10ge: SET_NETDEV_DEV()

2007-07-02 Thread Jeff Garzik
Maik Hampel wrote: SET_NETDEV_DEV() in myri10ge to create the /sys/class/net/if/device symlink. Signed-off-by: Maik Hampel [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch] starfire list alpha as 64 bit arch

2007-07-02 Thread Jeff Garzik
maximilian attems wrote: instead of: This driver has not been ported to this 64-bit architecture yet. the driver is said to work on alpha, see http://bugs.debian.org/305330 Signed-off-by: maximilian attems [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] dm9601: HW header size shouldn't be included in packet length

2007-07-02 Thread Jeff Garzik
Peter Korsgaard wrote: The dm9601 driver was including the 2 byte hardware header in the packet length, causing the HW to send 2 extra bytes of garbage on tx. Signed-off-by: Peter Korsgaard [EMAIL PROTECTED] --- drivers/net/usb/dm9601.c |5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH] usbnet: Zero padding byte if there is tail room in skb

2007-07-02 Thread Jeff Garzik
Peter Korsgaard wrote: Usbnet adds a padding byte if a 0 byte USB packet would be sent. Zero padding byte if there is tail room in skb. Signed-of-by: Peter Korsgaard [EMAIL PROTECTED] Acked-by: David Brownell [EMAIL PROTECTED] --- drivers/net/usb/usbnet.c |9 ++--- 1 file changed, 6

Re: [PATCH] Update MAINTAINERS for USB network devices

2007-07-02 Thread Jeff Garzik
Peter Korsgaard wrote: Greg == Greg KH [EMAIL PROTECTED] writes: Greg Yeah, this is the cdc_acm driver that is still in the USB drivers/ Greg directory tree as it is a USB class driver that shows up as a tty device Greg to userspace. It should not be moved to the networking list unless no

Re: [PATCH] dm9601: Return 0 from bind() on success

2007-07-02 Thread Jeff Garzik
Peter Korsgaard wrote: Fixup dm9601_bind() so it returns 0 on success rather than just a positive number, as otherwise usbnet doesn't init the status handler. Signed-off-by: Peter Korsgaard [EMAIL PROTECTED] --- drivers/net/usb/dm9601.c |6 ++ 1 file changed, 2 insertions(+), 4

Re: RESEND [PATCH 1/3] NetXen: Fix issue of MSI not working correctly

2007-07-02 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: NetXen driver uses PCI function 0 to provide the functionality of MSI. The patch makes driver check the bus master bit for function 0 and enable it after the card initialization. Signed-off-by: Dhananjay Phadke[EMAIL PROTECTED] Signed-off-by: Milan Bag [EMAIL PROTECTED]

Re: [2.6 patch] drivers/net/ns83820.c: fix a check-after-use

2007-07-02 Thread Jeff Garzik
Adrian Bunk wrote: This patch fixes a check-after-use spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] ps3: gigabit ethernet driver for PS3, take2

2007-07-02 Thread Jeff Garzik
MOKUNO Masakazu wrote: Hi, This is the second submission of the network driver for PS3. This version have been updated to address issues raised in the review. Please apply for 2.6.23. From: Masakazu Mokuno [EMAIL PROTECTED] Add Gigabit Ethernet support for the PS3 game console. The module

Re: [PATCH 3/9] pasemi_mac: Abstract out register access

2007-07-02 Thread Jeff Garzik
Olof Johansson wrote: Abstract out the PCI config read/write accesses into reg read/write ones, still calling the pci accessors on the back end. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: netdev-2.6/drivers/net/pasemi_mac.c

Re: [PATCH 2/9] pasemi_mac: Clean TX ring in poll

2007-07-02 Thread Jeff Garzik
Olof Johansson wrote: Clean the TX ring in the poll call, to avoid sitting on mapped buffers for a long time. NFS doesn't seem to like it much, for example. Signed-off-by: Olof Johansson [EMAIL PROTECTED] Index: netdev-2.6/drivers/net/pasemi_mac.c

Re: [PATCH] spidernet: Replace literal with const

2007-07-02 Thread Jeff Garzik
Linas Vepstas wrote: Replace literal with const; add bit definitions. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote: A follow-up patch needs to remove the above magic numbers (==numeric constants), replacing them with named

Re: [PATCH 1/9] pasemi_mac: Fix TX interrupt threshold

2007-07-02 Thread Jeff Garzik
Olof Johansson wrote: It was mistakenly set to interrupt on the second packet instead of first, causing some interesting latency behaviour. Signed-off-by: Olof Johansson [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH/RESENT] ehea: Whitespace cleanup

2007-07-02 Thread Jeff Garzik
Jan-Bernd Themann wrote: This patch fixes several whitespace issues. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2.6.21.5] 8139cp: dev-tx_timeout

2007-07-02 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: This patch implements the missing dev-tx_timeout for 8139cp driver Signed-off-by: Mika Lansirinne [EMAIL PROTECTED] does not seem to apply to current kernel. please resend against netdev-2.6.git#upstream or 2.6.22-rc7. - To unsubscribe from this list: send the

Re: [PATCH UPDATE #2] Extract chip specific code out of lasi_82596.c

2007-07-02 Thread Jeff Garzik
applied both patches. Please provide an update that does at Andrew requested -- rather than #include'ing lib82596.c, you should update the Makefile for relevant drivers to look like obj-$(CONFIG_FOO_BAR) += lib82596.o foo_bar_82596.o and make sure it exports everything to make lib82596 a

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Ayyappan Veeraiyan wrote: +#define IXGBE_TX_FLAGS_CSUM0x0001 +#define IXGBE_TX_FLAGS_VLAN0x0002 +#define IXGBE_TX_FLAGS_TSO 0x0004 +#define IXGBE_TX_FLAGS_IPV40x0008 +#define IXGBE_TX_FLAGS_VLAN_MASK 0x +#define

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-07-02 Thread Patrick McHardy
Johannes Berg wrote: On Sat, 2007-06-30 at 11:32 -0400, jamal wrote: +NLA_PUT_U32(skb, CTRL_ATTR_MCAST_GRP_ID, grp-id); +NLA_PUT_STRING(skb, CTRL_ATTR_MCAST_GRP_NAME, + grp-name); + Consider my earlier suggestion to

[PATCH 2.6.21.1] nfs-root: added possibility to override default MTU (for UDP jumbo frames)

2007-07-02 Thread manio
To use a NFS-root for UDP jumbo frames the kernel on the client need to bring up interface with MTU set to 9000 bytes - otherwise it cannot contact server with jumbo frames enabled (nfs server not responding, still trying) and cannot boot. Added a kernel parameter named 'ipmtu' which can be used

Re: [PATCH 2.6.21.1] nfs-root: added possibility to override default MTU (for UDP jumbo frames)

2007-07-02 Thread Peter Staubach
[EMAIL PROTECTED] wrote: To use a NFS-root for UDP jumbo frames the kernel on the client need to bring up interface with MTU set to 9000 bytes - otherwise it cannot contact server with jumbo frames enabled (nfs server not responding, still trying) and cannot boot. Added a kernel parameter named

sky2 silicon bugs and workarounds...

2007-07-02 Thread Daniel J Blueman
Hi Stephen, When the sky2 driver initialises, it sets the the ISR timer register (STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the vendor sk98lin driver sets it to 400, irrespective of the clockspeed of the NIC processor. I guess you found more performance/stability from this value...? I've

Re: [PATCH UPDATE #2] Extract chip specific code out of lasi_82596.c

2007-07-02 Thread Thomas Bogendoerfer
On Mon, Jul 02, 2007 at 08:43:04AM -0400, Jeff Garzik wrote: applied both patches. Please provide an update that does at Andrew requested -- rather than #include'ing lib82596.c, you should update the Makefile for relevant drivers to look like I got the impression that Andrew is fine with

[patch] dgrs romove Kconfig option

2007-07-02 Thread maximilian attems
nobody objected to adrian's rfc dropping dgrs on netdev back in dec. 2006. - http://marc.info/?l=linux-netdevm=116507999803538w=2 as bonus points this will get rid of a prorpietary licensed firmware. so now be a bit more serious and remove the Kconfig entries and see if anyone shouts. if no voice

Re: [PATCH UPDATE #2] Extract chip specific code out of lasi_82596.c

2007-07-02 Thread Jeff Garzik
Thomas Bogendoerfer wrote: On Mon, Jul 02, 2007 at 08:43:04AM -0400, Jeff Garzik wrote: applied both patches. Please provide an update that does at Andrew requested -- rather than #include'ing lib82596.c, you should update the Makefile for relevant drivers to look like I got the

[PATCH 2.6.22-rc7] 8139cp: dev-tx_timeout

2007-07-02 Thread Mika . Lansirinne
(Resending the patch against 2.6.22-rc7) This patch implements the missing dev-tx_timeout for 8139cp driver Signed-off-by: Mika Lansirinne [EMAIL PROTECTED] --- diff -uprN linux-2.6.22-rc7/drivers/net/8139cp.c linux-2.6.22-rc7_8139cp-tx_timeout/drivers/net/8139cp.c ---

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Arjan van de Ven
+u32 alloc_rx_buff_failed; +struct { +unsigned int rx_csum_enabled:1; +unsigned int msi_capable:1; +unsigned int msi_enabled:1; +unsigned int msix_capable:1; +unsigned int msix_enabled:1; +unsigned int imir_enabled

Re: 2.6.22-rc6: local_bh_enable warning

2007-07-02 Thread Patrick McHardy
Russell King wrote: Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following. Looks like netfilter is calling local_bh_enable() with IRQs disabled, which would appear to be illegal. Thankfully, this is a warn-once warning. WARNING: at

Re: [PATCH 2.6.21.1] nfs-root: added possibility to override default MTU (for UDP jumbo frames)

2007-07-02 Thread Krzysztof Halasa
[EMAIL PROTECTED] writes: To use a NFS-root for UDP jumbo frames the kernel on the client need to bring up interface with MTU set to 9000 bytes - otherwise it cannot contact server with jumbo frames enabled (nfs server not responding, still trying) and cannot boot. Added a kernel parameter

Re: 2.6.22-rc6: local_bh_enable warning

2007-07-02 Thread Jeff Garzik
Patrick McHardy wrote: Russell King wrote: Having upgraded from 2.6.16 to 2.6.22-rc6, I'm now seeing the following. Looks like netfilter is calling local_bh_enable() with IRQs disabled, which would appear to be illegal. Thankfully, this is a warn-once warning. WARNING: at

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Arjan van de Ven wrote: +u32 alloc_rx_buff_failed; +struct { +unsigned int rx_csum_enabled:1; +unsigned int msi_capable:1; +unsigned int msi_enabled:1; +unsigned int msix_capable:1; +unsigned int msix_enabled:1; +

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Arjan van de Ven
Jeff Garzik wrote: always avoid bitfields. They generate horrible code, and endian problems abound (though no endian problems are apparent here). they generate no worse code than open coding the checks for these feature flags... That would be the logical assumption, but reality does not

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Arjan van de Ven
Jeff Garzik wrote: I'm not sure whether gcc is confused about ABI alignment or such, on various platforms, but every time I look at the asm generated it is /not/ equivalent to open-coded feature flags and bitwise logic. Often it is demonstrably worse. (I can imagine this being different if

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-07-02 Thread Johannes Berg
On Mon, 2007-07-02 at 14:56 +0200, Patrick McHardy wrote: For information that belongs together logically a struct is fine. Ok. The main reason to use nested attributes is when you only have a single attribute to store your data in (for example TCA_OPTIONS for qdiscs). In that case a nested

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-07-02 Thread Patrick McHardy
Johannes Berg wrote: On Mon, 2007-07-02 at 14:56 +0200, Patrick McHardy wrote: The main reason to use nested attributes is when you only have a single attribute to store your data in (for example TCA_OPTIONS for qdiscs). In that case a nested attribute should be used to allow to extend it in

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Arjan van de Ven wrote: Jeff Garzik wrote: always avoid bitfields. They generate horrible code, and endian problems abound (though no endian problems are apparent here). they generate no worse code than open coding the checks for these feature flags... That would be the logical

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Arjan van de Ven
Jeff Garzik wrote: It's simple logic: using machine integers are the easiest for the compiler to Do The Right Thing, the easiest way to eliminate endian problems, the easiest way for programmers to read and understand struct alignment. using integers pure is obviously natural.. but using

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

2007-07-02 Thread Johannes Berg
On Mon, 2007-07-02 at 16:38 +0200, Patrick McHardy wrote: Do I understand you correctly in that you prefer the way I did it now? Yes. Alright, then I'll rework the event generation to not include the whole family info and repost with that tomorrow or so. If I find time I might actually

[info] What's in netdev-2.6.git?

2007-07-02 Thread Jeff Garzik
This is what is currently queued for 2.6.23. There are a few patches in my mbox not yet applied to the git tree, but this is most of them. The following is found in the 'upstream' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git Akinobu Mita (1): softmac:

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Kok, Auke
Jeff Garzik wrote: Arjan van de Ven wrote: Jeff Garzik wrote: always avoid bitfields. They generate horrible code, and endian problems abound (though no endian problems are apparent here). they generate no worse code than open coding the checks for these feature flags... That would be the

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Kok, Auke wrote: Maybe this is not most important for ixgbe, where we only have 8 or so flags, but the new e1000 driver that I posted this weekend currently has 63 (you wanted flags ;)) of them. Do you want me to use 63 integers or just 2 ? Don't be silly. We are talking about single-bit

[PATCH] Cleanup usbnet_probe() return value handling

2007-07-02 Thread Peter Korsgaard
usbnet_probe() handles a positive return value from the driver bind() function as success, but will later only setup the status handler if the return value was zero, leading to confusion. Patch adjusts this to only accept 0 as success in both checks. Signed-off-by: Peter Korsgaard [EMAIL

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Andrew Morton wrote: On Mon, 02 Jul 2007 11:32:41 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Bitfields are to be avoided for many reasons: * more difficult, in general, for a compiler to generate optimal code * in particular, known to generate worse code on various architectures * often causes

Re: sky2 silicon bugs and workarounds...

2007-07-02 Thread Daniel J Blueman
On 02/07/07, Stephen Hemminger [EMAIL PROTECTED] wrote: On Mon, 2 Jul 2007 14:37:06 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: When the sky2 driver initialises, it sets the the ISR timer register (STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the vendor sk98lin driver sets it to 400,

Re: [PATCH] Cleanup usbnet_probe() return value handling

2007-07-02 Thread David Brownell
On Monday 02 July 2007, Peter Korsgaard wrote: usbnet_probe() handles a positive return value from the driver bind() function as success, but will later only setup the status handler if the return value was zero, leading to confusion. Patch adjusts this to only accept 0 as success in both

Re: sky2 silicon bugs and workarounds...

2007-07-02 Thread Stephen Hemminger
On Mon, 2 Jul 2007 14:37:06 +0100 Daniel J Blueman [EMAIL PROTECTED] wrote: Hi Stephen, When the sky2 driver initialises, it sets the the ISR timer register (STAT_ISR_TIMER_INI) to 125 * 20 = 2500, whereas the vendor sk98lin driver sets it to 400, irrespective of the clockspeed of the NIC

Re: [info] What's in netdev-2.6.git?

2007-07-02 Thread Ben Dooks
On Mon, Jul 02, 2007 at 11:08:26AM -0400, Jeff Garzik wrote: This is what is currently queued for 2.6.23. There are a few patches in my mbox not yet applied to the git tree, but this is most of them. I sent driver support for the AX88796 a few weeks ago with no feedback, should I re-send

Re: [PATCH 2.6.21.1] nfs-root: added possibility to override default MTU (for UDP jumbo frames)

2007-07-02 Thread manio
Peter Staubach wrote: [EMAIL PROTECTED] wrote: To use a NFS-root for UDP jumbo frames the kernel on the client need to bring up interface with MTU set to 9000 bytes - otherwise it cannot contact server with jumbo frames enabled (nfs server not responding, still trying) and cannot boot. Added

Re: [info] What's in netdev-2.6.git?

2007-07-02 Thread Jeff Garzik
Ben Dooks wrote: On Mon, Jul 02, 2007 at 11:08:26AM -0400, Jeff Garzik wrote: This is what is currently queued for 2.6.23. There are a few patches in my mbox not yet applied to the git tree, but this is most of them. I sent driver support for the AX88796 a few weeks ago with no feedback,

RE: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Veeraiyan, Ayyappan
On 7/2/07, Jeff Garzik [EMAIL PROTECTED] wrote: Ayyappan Veeraiyan wrote: +#define IXGBE_TX_FLAGS_VLAN_MASK 0x +#define IXGBE_TX_FLAGS_VLAN_SHIFT16 defining bits using the form (1 n) is preferred. Makes it easier to read, by eliminating the requirement of the human brain

Re: [2.6 patch] the overdue eepro100 removal

2007-07-02 Thread Bill Davidsen
Adrian Bunk wrote: This patch contains the overdue removal of the eepro100 driver. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] The hardware supported by this driver is still in use, thanks. It's probably easier to leave the eepro100 driver in than find anyone who wants to investigate why

Re: quirk_e100_interrupt() called too early

2007-07-02 Thread Kok, Auke
Nils Rennebarth wrote: Bjorn Helgaas wrote: On Thursday 28 June 2007 10:01:08 am Kok, Auke wrote: I copied Nils Rennebarth, who originally reported the bug: http://bugzilla.kernel.org/show_bug.cgi?id=5918 in case he can test your patch. Most of the embedded boards we now work with appear to

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Ayyappan Veeraiyan
On 7/2/07, Veeraiyan, Ayyappan [EMAIL PROTECTED] wrote: Thanks for the feedback. I will post another version shortly (except the feature flags change and the ring struct name members) which fixes my Just to clarify this, I will wait some more time for feature flags discussion and the ring

Re: [patch] dgrs romove Kconfig option

2007-07-02 Thread Andres Salomon
On Mon, 2 Jul 2007 15:52:01 +0200 maximilian attems [EMAIL PROTECTED] wrote: nobody objected to adrian's rfc dropping dgrs on netdev back in dec. 2006. - http://marc.info/?l=linux-netdevm=116507999803538w=2 as bonus points this will get rid of a prorpietary licensed firmware. so now be a

Re: [2.6 patch] the overdue eepro100 removal

2007-07-02 Thread Kok, Auke
Bill Davidsen wrote: Adrian Bunk wrote: This patch contains the overdue removal of the eepro100 driver. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] The hardware supported by this driver is still in use, thanks. It's probably easier to leave the eepro100 driver in than find anyone who wants

Re: r8169 2.2LK: Low link speed after suspend

2007-07-02 Thread Francois Romieu
Peter Missel [EMAIL PROTECTED] : [...] Unfortunately I couldn't get NFS to work with the updated kernel, so I had to revert to the original from SuSE 10.2. No NFS but networking or no networking at all ? -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Kok, Auke
Christoph Hellwig wrote: On Mon, Jul 02, 2007 at 02:09:58PM -0700, Stephen Hemminger wrote: The patch is close to ready for 2.6.24 when this driver will need to show up. If intel manages to fix up the reamining issues I'd rather see it appear in 2.6.23.. Since I know Intel will be forced to

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Kok, Auke wrote: I suppose I can fix those, but I really don't understand what all the fuzz is about here. We're only conserving memory and staying far away from the real risks of bitmasks, so forgive me if I don't grasp the problem. Be it machine ints or bitfields, you're not conserving

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Michael Buesch
On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote: well, FWIW when I started looking at adding these flags I looked in various subsystems in the kernel and picked an implementation that suited. Guess what pci.h has? ...: unsigned int msi_enabled:1; unsigned int msix_enabled:1;

Re: [git patches] net driver fixes

2007-07-02 Thread Adrian Bunk
On Mon, Jul 02, 2007 at 10:54:01AM -0400, Jeff Garzik wrote: ... maximilian attems (1): starfire list alpha as 64 bit arch ... --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@ -152,7 +152,7 @@ static int full_duplex[MAX_UNITS] = {0, }; * This SUCKS. * We need a much

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Michael Buesch wrote: On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote: well, FWIW when I started looking at adding these flags I looked in various subsystems in the kernel and picked an implementation that suited. Guess what pci.h has? ...: unsigned int msi_enabled:1;

Re: [git patches] net driver fixes

2007-07-02 Thread Stephen Hemminger
On Tue, 3 Jul 2007 00:13:29 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: On Mon, Jul 02, 2007 at 10:54:01AM -0400, Jeff Garzik wrote: ... maximilian attems (1): starfire list alpha as 64 bit arch ... --- a/drivers/net/starfire.c +++ b/drivers/net/starfire.c @@ -152,7 +152,7 @@

Re: [PATCH] Cleanup usbnet_probe() return value handling

2007-07-02 Thread Peter Korsgaard
David == David Brownell [EMAIL PROTECTED] writes: Hi, David I'd rather see the later test updated to match this one. David (Good catch!) David The return convention is negative means error. There's David code in USB which has multiple nonnegative success codes. Ok, updated patch does

RE: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Veeraiyan, Ayyappan
On 7/2/07, Stephen Hemminger [EMAIL PROTECTED] wrote: Fake netdevs are needed for doing the multiple Rx queues in NAPI mode. We are thinking to solve in 2 ways. Having netdev pointer in ring structure or having an array of netdev pointers in ixgbe_adatper struct which would be visible to

Re: [WIP][PATCHES] Network xmit batching - tg3 support

2007-07-02 Thread Michael Chan
On Mon, 2007-07-02 at 14:20 -0700, Matt Carlson wrote: Also, I think the count, max_per_txd, and nr_frags fields of the tg3_tx_cbdata struct are not needed. The count field is not needed also. +struct tg3_tx_cbdata { + u32 base_flags; + int count; + unsigned int

RE: [E1000-devel] e1000: backport ich9 support from 7.5.5 ?

2007-07-02 Thread Williams, Mitch A
Mark McLoughlin wrote: I disagree, we should not break the current e1000 driver in the kernel while there is a new driver coming up that introduces ich9 support without breaking (the old e1000) support for all other devices. This is why we want to drop a new version of the e1000

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Kok, Auke
Jeff Garzik wrote: Michael Buesch wrote: On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote: well, FWIW when I started looking at adding these flags I looked in various subsystems in the kernel and picked an implementation that suited. Guess what pci.h has? ...: unsigned int

RE: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Veeraiyan, Ayyappan
On 7/2/07, Christoph Hellwig [EMAIL PROTECTED] wrote: But that'll require the single receiver queue version I guess. The netdevice abuse is the only really major issue I see, although I'd of course really like to see the driver getting rid of the bitfield abuse aswell. The submitted driver

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Jeff Garzik
Kok, Auke wrote: but let's stay constructive here: ~/git/linux-2.6 $ grep -r 'unsigned int.*:1;' * | wc -l 748 Is anyone going to fix those? If we don't, someone will certainly again submit patches to add more of these bitfields, after all, some very prominent parts of the kernel still use

Re: [E1000-devel] e1000: backport ich9 support from 7.5.5 ?

2007-07-02 Thread Rick Jones
There seems to be a lot of concern over obsoleting the e1000 driver too quickly, and with confusing users (and startup scripts) about which driver to load. Yes. Obviously, we at Intel want to get e1000new into the kernel as quickly as possible, and to obsolete e1000 also as quickly as

Re: [PATCH] ixgbe: Introduce new 10GbE driver for Intel 82598 based PCI Express adapters...

2007-07-02 Thread Inaky Perez-Gonzalez
On Monday 02 July 2007, Kok, Auke wrote: Jeff Garzik wrote: Michael Buesch wrote: On Tuesday 03 July 2007 00:02:57 Kok, Auke wrote: well, FWIW when I started looking at adding these flags I looked in various subsystems in the kernel and picked an implementation that suited. Guess

[PATCH] ucc_geth.c, make PHY device optional.

2007-07-02 Thread Joakim Tjernlund
This patch makes the PHY optional for ucc_geth.c ethernet driver. This is useful to support a direct mii to mii connection to, for example, a onboard swicth. Signed-off-by: Joakim Tjernlund [EMAIL PROTECTED] [SNIP patch sent last Friday] Since this is my last week before vacation, I

Re: [PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets

2007-07-02 Thread Andrew Morton
On Tue, 26 Jun 2007 14:50:11 -0400 Ed L. Cashin [EMAIL PROTECTED] wrote: Use a dynamic pool of sk_buffs to keep up with fast targets. That's far too skimpy a description of what this patch is doing, what it is for, what makes AOE need this functionality, etc. My initial thought is that if

Re: [PATCH 07/12] use a dynamic pool of sk_buffs to keep up with fast targets

2007-07-02 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Mon, 2 Jul 2007 21:36:36 -0700 My initial thought is that if there is a legitimate need for this new capability then it should be made available to other parts of the kernel rather than being private to the AEO driver. Absolutely. We even used to

Re: [PATCH 8/9] [TCP]: Reduce sacked_out with reno when purging write_queue

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:36:01 +0300 Previously TCP had a transitional state during which reno counted segments that are already below the current window into sacked_out, which is now prevented. Re-try now unconditional S+L catching (I wonder if we could

Re: [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 31 May 2007 19:31:21 +0300 (EEST) (i.e, how does it show up in oops if tcp_verify_left_out looks like this): #define tcp_verify_left_out(tp) BUG_ON(...) ...does it still point to the tcp.h line then or to the tcp_sync_left_out(tp) @

Re: Suspicious fackets_out handling

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 1 Jun 2007 15:17:00 +0300 (EEST) On Thu, 31 May 2007, David Miller wrote: Is it possible to update fastpath_cnt_hint properly perhaps? I think that would be valid and even accurate as it can checks skb's seq against fastpath_skb_hint-seq.

Re: [PATCH tcp-2.6 1/3] [TCP]: Add tcp_dec_pcount_approx int variant

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 15 Jun 2007 14:10:28 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied to tcp-2.6 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH] [TCP]: Fix logic breakage due to DSACK separation

2007-07-02 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 16 Jun 2007 02:04:25 +0300 (EEST) There are still some things I must think carefully in sacktag processing since it does not validate start_seq and end_seq at all which can be abused currently at least in tcp-2.6. ...I would rather put end to

Re: [PATCH] mac80211: Set low initial rate in rc80211_simple

2007-07-02 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Mon, 11 Jun 2007 21:24:11 -0400 From: Larry Finger [EMAIL PROTECTED] The initial rate for STA's using rc80211_simple is set to the last rate in the rate table. For situations for which the signal is weak, the rate may be too high for

Re: [PATCH] mac80211: Add support for SIOCGIWRATE ioctl to provide rate information

2007-07-02 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Mon, 11 Jun 2007 21:23:19 -0400 From: Larry Finger [EMAIL PROTECTED] At present, transmission rate information for mac80211 is available only if verbose debugging is turned on, and then only in the logs. This patch implements the SIOCGIWRATE

Re: [PATCH] pktgen IPSEC 1/4: Centralize pktgen packet overhead management

2007-07-02 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 12 Jun 2007 08:00:28 -0400 commit 38477d7ddfa58f58cce99bc902b4c18883647a71 Author: Jamal Hadi Salim [EMAIL PROTECTED] Date: Tue Jun 12 06:43:00 2007 -0400 [PKTGEN] Centralize packet overhead tracking Track the extra packet overhead for

Re: Resend: [PATCH] pktgen IPSEC 3/4: Introduce xfrm SAD only lookup

2007-07-02 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 12 Jun 2007 19:06:03 -0400 commit 4fe3190756589ef8155eb97fe725f2564f1fc77d Author: Jamal Hadi Salim [EMAIL PROTECTED] Date: Tue Jun 12 12:35:39 2007 -0400 [XFRM] Introduce standalone SAD lookup This allows other in-kernel functions to do

Re: Resend: [PATCH] pktgen IPSEC 4/4: Add IPSEC support to pktgen

2007-07-02 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 12 Jun 2007 19:08:39 -0400 commit bfd389bba7654aa118f0949ff0de45a3bce9700c Author: Jamal Hadi Salim [EMAIL PROTECTED] Date: Tue Jun 12 18:59:33 2007 -0400 [PKTGEN] IPSEC support Added transport mode ESP support for starters. I will

Re: [NET_SCHED 01/04]: Remove CONFIG_NET_ESTIMATOR option

2007-07-02 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 17:02:19 +0200 (MEST) [NET_SCHED]: Remove CONFIG_NET_ESTIMATOR option The generic estimator is always built in anways and all the config options does is prevent including a minimal amount of code for setting it up. Additionally

  1   2   >