Re: sky2: Use seq_putc() in sky2_debug_show()

On Mon, 8 May 2017 19:42:46 +0200 SF Markus Elfring wrote: > > Which issue do you mean? I dont see any issue you fix here. > > Are the run time characteristics a bit nicer for the function “seq_putc” > in comparison to the function “seq_puts” for printing a

[PATCH] net: fec: select queue depending on VLAN priority

Since the addition of the multi queue code with commit 59d0f7465644 ("net: fec: init multi queue date structure") the queue selection has been handelt by the default transmit queue selection implementation which tries to evenly distribute the traffic across all available queues. This selection

Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code

"Gustavo A. R. Silva" writes: > The name of an array used by itself will always return the array's address. > So these tests will always evaluate as false and therefore the _return_ > will never be executed. > > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH RFC net-next 3/6] net: Introduce IFF_LWT_NETDEV flag

On Mon, May 8, 2017 at 5:57 PM, David Ahern wrote: > On 5/8/17 1:11 PM, David Miller wrote: >> From: Johannes Berg >> Date: Mon, 08 May 2017 10:55:12 +0200 >> >>> +static inline bool netif_is_lwd(struct net_device *dev) +{ + return

Re: [PATCH 0/4] TI Bluetooth serdev support

Hi Rob, On Mon, May 08, 2017 at 04:12:16PM -0500, Rob Herring wrote: > On Fri, May 5, 2017 at 9:51 AM, Adam Ford wrote: > > On Sun, Apr 30, 2017 at 11:04 AM, Sebastian Reichel wrote: > >> On Sun, Apr 30, 2017 at 10:14:20AM -0500, Adam Ford wrote: > >>> On

[PATCH] wcn36xx: Close SMD channel on device removal

The SMD channel is not the primary WCNSS channel and must explicitly be closed as the device is removed, or the channel will already by open on a subsequent probe call in e.g. the case of reloading the kernel module. This issue was introduced because I simplified the underlying SMD implementation

[PATCH] net: wireless: ath: ath10k: remove unnecessary code

The name of an array used by itself will always return the array's address. So these tests will always evaluate as false and therefore the _return_ will never be executed. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath10k/wmi.c | 9 - 1 file

[PATCH] net: wireless: ath: ath9k: remove unnecessary code

The name of an array used by itself will always return the array's address. So this test will always evaluate as true. Addresses-Coverity-ID: 1364903 Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath9k/eeprom.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

2017-05-09 3:59 GMT+08:00 David Miller : > From: Hangbin Liu > Date: Mon, 8 May 2017 19:11:03 +0800 > >> After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH >> or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it.

Re: [Patch net] ipv4: restore rt->fi for reference counting

From: Eric Dumazet Date: Mon, 08 May 2017 19:18:22 -0700 > Keeping fib (and their reference to netdev) is apparently too much, > we probably need to implement a refcount on the metrics themselves, > being stand alone objects. I think I see the problem, when we flush the

Re: [Patch net] ipv4: restore rt->fi for reference counting

On Mon, 2017-05-08 at 21:22 -0400, David Miller wrote: > From: Eric Dumazet > Date: Mon, 08 May 2017 17:01:20 -0700 > > > On Mon, 2017-05-08 at 14:35 -0400, David Miller wrote: > >> From: Cong Wang > >> Date: Thu, 4 May 2017 14:54:17 -0700 > >>

iproute2 ss outputs duplicate tcp sockets info on kernel 3.10.105

i'm using v4.11.0 release of iproute2 and kernel 3.10.105, simply running $ ss Netid State Recv-Q Send-Q Local Address:Port Peer Address:Port tcpCLOSE-WAIT 4340 10.0.0.1:47931 65.49.18.136:https tcpCLOSE-WAIT

Re: [Patch net] ipv4: restore rt->fi for reference counting

From: Eric Dumazet Date: Mon, 08 May 2017 17:01:20 -0700 > On Mon, 2017-05-08 at 14:35 -0400, David Miller wrote: >> From: Cong Wang >> Date: Thu, 4 May 2017 14:54:17 -0700 >> >> > IPv4 dst could use fi->fib_metrics to store metrics but

Re: [PATCH RFC net-next 3/6] net: Introduce IFF_LWT_NETDEV flag

On 5/8/17 1:11 PM, David Miller wrote: > From: Johannes Berg > Date: Mon, 08 May 2017 10:55:12 +0200 > >> >>> +static inline bool netif_is_lwd(struct net_device *dev) >>> +{ >>> + return !!(dev->priv_flags & IFF_LWT_NETDEV); >>> +} >> >> Am I the only one who thinks

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

| From: Alexander Duyck | Date: Saturday, May 6, 2017 11:07 AM | | | From: Ding Tianhong | | Date: Fri, May 5, 2017 at 8:08 PM | | | | According the suggestion, I could only think of this code: | | .. | | This is a bit simplistic but it is

Re: [PATCH] net: dsa: loop: Check for memory allocation failure

On Mon, 8 May 2017, Florian Fainelli wrote: > On 05/08/2017 04:46 PM, Julia Lawall wrote: > > > > > > On Mon, 8 May 2017, Joe Perches wrote: > > > >> On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote: > >>> > >>> On Mon, 8 May 2017, David Laight wrote: > >>> > From: Christophe JAILLET

Re: [PATCH] net: dsa: loop: Check for memory allocation failure

On 05/08/2017 04:46 PM, Julia Lawall wrote: > > > On Mon, 8 May 2017, Joe Perches wrote: > >> On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote: >>> >>> On Mon, 8 May 2017, David Laight wrote: >>> From: Christophe JAILLET > Sent: 06 May 2017 06:30 > If 'devm_kzalloc' fails, a

RE: [PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison

Use time_after() for time comparison with the new fix. Signed-off-by: Karim Eshapa --- drivers/net/wimax/i2400m/i2400m-usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wimax/i2400m/i2400m-usb.h b/drivers/net/wimax/i2400m/i2400m-usb.h

Re: [Patch net] ipv4: restore rt->fi for reference counting

On Mon, 2017-05-08 at 14:35 -0400, David Miller wrote: > From: Cong Wang > Date: Thu, 4 May 2017 14:54:17 -0700 > > > IPv4 dst could use fi->fib_metrics to store metrics but fib_info > > itself is refcnt'ed, so without taking a refcnt fi and > > fi->fib_metrics could

Re: [PATCH] net: dsa: loop: Check for memory allocation failure

On Mon, 8 May 2017, Joe Perches wrote: > On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote: > > > > On Mon, 8 May 2017, David Laight wrote: > > > > > From: Christophe JAILLET > > > > Sent: 06 May 2017 06:30 > > > > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > > > > Return

Re: [PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison

On 5/8/17 2:26 PM, David Miller wrote: From: Karim Eshapa Date: Mon, 8 May 2017 18:58:02 +0200 diff --git a/drivers/net/wimax/i2400m/i2400m-usb.h b/drivers/net/wimax/i2400m/i2400m-usb.h index 649ecad..6fc941c 100644 --- a/drivers/net/wimax/i2400m/i2400m-usb.h +++

[PATCH] drivers: net: wireless: rsi: rsi_91x_core: Use time_after time comparison

Use time_after kernel macro for time comparison. Signed-off-by: Karim Eshapa --- drivers/net/wireless/rsi/rsi_91x_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rsi/rsi_91x_core.c b/drivers/net/wireless/rsi/rsi_91x_core.c

[PATCH] DECnet: Use container_of() for embedded struct

Instead of a direct cross-type cast, use conatiner_of() to locate the embedded structure, even in the face of future struct layout randomization. Signed-off-by: Kees Cook --- net/decnet/dn_neigh.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path

From: Jon Mason Date: Mon, 8 May 2017 17:48:35 -0400 > If an error is encountered in mdio_mux_init(), the error path will call > mdiobus_free(). Since mdiobus_register() has been called prior to > mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This >

Re: [PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path

On 05/08/2017 02:48 PM, Jon Mason wrote: > If an error is encountered in mdio_mux_init(), the error path will call > mdiobus_free(). Since mdiobus_register() has been called prior to > mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This > causes a BUG_ON() in mdiobus_free().

[PATCH] net: mdio-mux: bcm-iproc: call mdiobus_free() in error path

If an error is encountered in mdio_mux_init(), the error path will call mdiobus_free(). Since mdiobus_register() has been called prior to mdio_mux_init(), the bus->state will not be MDIOBUS_UNREGISTERED. This causes a BUG_ON() in mdiobus_free(). To correct this issue, add an error path for

Re: [PATCH RFC net-next 3/6] net: Introduce IFF_LWT_NETDEV flag

On Mon, May 8, 2017 at 1:11 PM, David Miller wrote: > From: Johannes Berg > Date: Mon, 08 May 2017 10:55:12 +0200 > >> >>> +static inline bool netif_is_lwd(struct net_device *dev) >>> +{ >>> +return !!(dev->priv_flags & IFF_LWT_NETDEV); >>> +}

Re: [Patch net v3] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

From: Cong Wang Date: Mon, 8 May 2017 10:12:13 -0700 > For each netns (except init_net), we initialize its null entry > in 3 places: > > 1) The template itself, as we use kmemdup() > 2) Code around dst_init_metrics() in ip6_route_net_init() > 3)

Re: [PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison

From: Karim Eshapa Date: Mon, 8 May 2017 18:58:02 +0200 > diff --git a/drivers/net/wimax/i2400m/i2400m-usb.h > b/drivers/net/wimax/i2400m/i2400m-usb.h > index 649ecad..6fc941c 100644 > --- a/drivers/net/wimax/i2400m/i2400m-usb.h > +++

Re: [PATCH 0/4] TI Bluetooth serdev support

On Fri, May 5, 2017 at 9:51 AM, Adam Ford wrote: > On Sun, Apr 30, 2017 at 11:04 AM, Sebastian Reichel wrote: >> Hi, >> >> On Sun, Apr 30, 2017 at 10:14:20AM -0500, Adam Ford wrote: >>> On Wed, Apr 5, 2017 at 1:30 PM, Rob Herring wrote: >>>

Re: [PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

On Mon, May 8, 2017 at 4:11 AM, Hangbin Liu wrote: > After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH > or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it. Are you sure we really don't need to handle NDISC_REDIRECT here? I can't

Re: [PATCH net-next] geneve: add rtnl changelink support

From: Girish Moodalbail Date: Mon, 8 May 2017 13:08:24 -0700 > This patch adds changelink rtnl operation support for geneve devices. > Code changes involve: > - refactor geneve_newlink into geneve_nl2info to be used by both > geneve_newlink and

[PATCH net-next] geneve: add rtnl changelink support

This patch adds changelink rtnl operation support for geneve devices. Code changes involve: - refactor geneve_newlink into geneve_nl2info to be used by both geneve_newlink and geneve_changelink - geneve_nl2info takes a changelink boolean argument to isolate changelink checks and

Re: [PATCH RFC net-next 3/6] net: Introduce IFF_LWT_NETDEV flag

From: Johannes Berg Date: Mon, 08 May 2017 10:55:12 +0200 > >> +static inline bool netif_is_lwd(struct net_device *dev) >> +{ >> +return !!(dev->priv_flags & IFF_LWT_NETDEV); >> +} > > Am I the only one who thinks that this "LWT_NETDEV" vs "LWD" is a bit >

Re: pull-request: mac80211 2017-05-08

From: Johannes Berg Date: Mon, 8 May 2017 16:46:21 +0200 > Thanks for merging the rate fix quickly the other day. I've got a > few more fixes lined up, so this time as a pull request. > > Please pull and let me know if there's any problem. Pulled, thanks.

Re: [PATCH V2 1/1] net: cdc_ncm: Fix TX zero padding

From: Jim Baxter Date: Mon, 8 May 2017 13:49:57 +0100 > The zero padding that is added to NTB's does > not zero the memory correctly. > This is because the skb_put modifies the value > of skb_out->len which results in the memset > command not setting any memory to zero as

Re: [PATCH net] ip6_tunnel: remove unreachable ICMP_REDIRECT code

From: Hangbin Liu Date: Mon, 8 May 2017 19:11:03 +0800 > After call ip6_tnl_err(), the rel_type will be ether ICMPV6_DEST_UNREACH > or ICMPV6_PKT_TOOBIG. We will never reach ICMP_REDIRECT. So remove it. > > Signed-off-by: Hangbin Liu Your patches

Re: [PATCH] net: dsa: loop: Check for memory allocation failure

On Mon, 2017-05-08 at 20:32 +0800, Julia Lawall wrote: > > On Mon, 8 May 2017, David Laight wrote: > > > From: Christophe JAILLET > > > Sent: 06 May 2017 06:30 > > > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > > > Return -ENOMEM instead, as done for some other memory

Re: SSE instructions for fast packet copy?

On 2017/05/04 22:50, Tom Herbert wrote: > Hi, > > I am thinking about the possibility of using SSE in kernel for > speeding up the kernel memcpy particularly for copy to userspace > emeory, and maybe even using the string instructions (like if we > supported regex in something like eBPF). AFAIK

Re: [PATCH] net/fsl: remove func xgmac_wait_until_free() as duplicate

From: Alexandru Ardelean Date: Mon, 8 May 2017 14:31:18 +0300 > Looking at xgmac_wait_until_done() and xgmac_wait_until_free() > functions, they seem to have turned out completely identical. > > Though, judging from the git history it seems they > initially weren't. >

[PATCH] net: ethernet: ti: cpsw: adjust cpsw fifos depth for fullduplex flow control

When users set flow control using ethtool the bits are set properly in the CPGMAC_SL MACCONTROL register, but the FIFO depth in the respective Port n Maximum FIFO Blocks (Pn_MAX_BLKS) registers remains set to the minimum size reset value. When receive flow control is enabled on a port, the port's

Re: [PATCH RFC] net: Fix inconsistent teardown and release of private netdev state.

From: Stephen Hemminger Date: Mon, 8 May 2017 12:13:59 -0700 > Thanks for addressing a confusing and messy semantic. If you merge > this then it would be good to update the documentation in > Doucmentation/networking to describe how drivers are supposed to > behave.

Re: [PATCH v1 0/4] stmmac: pci: Fix crash on Intel Galileo Gen2

From: Andy Shevchenko Date: Mon, 8 May 2017 17:14:18 +0300 > Due to misconfiguration of PCI driver for Intel Quark the user will get > a kernel crash: > > # udhcpc -i eth0 > udhcpc: started, v1.26.2 > stmmaceth :00:14.6 eth0: device MAC address

Re: [PATCH RFC] net: Fix inconsistent teardown and release of private netdev state.

On Mon, 08 May 2017 12:52:43 -0400 (EDT) David Miller wrote: > Network devices can allocate reasources and private memory using > netdev_ops->ndo_init(). However, the release of these resources > can occur in one of two different places. > > Either netdev_ops->ndo_uninit()

Re: [PATCH v2 net] vti: check nla_put_* return value

From: Hangbin Liu Date: Mon, 8 May 2017 17:57:13 +0800 > Signed-off-by: Hangbin Liu Applied.

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

Hello, On Mon, 8 May 2017 16:28:21 +0200, Giuseppe CAVALLARO wrote: > > I just see that GMAC_CONTROL and MAC_CTRL_REG are the same, so why not > > create a custom adjust_link for each dwmac type ? > > This will permit to call it instead of set_ps() and remove lots of if > > (has_gmac) and co

Re: [PATCH net] bpf: don't let ldimm64 leak map addresses on unprivileged

From: Daniel Borkmann Date: Mon, 8 May 2017 00:04:09 +0200 > The patch fixes two things at once: > > 1) It checks the env->allow_ptr_leaks and only prints the map address to >the log if we have the privileges to do so, otherwise it just dumps 0 >as we would when

Re: [PATCH 0/4] TI Bluetooth serdev support

Hi, On Fri, May 05, 2017 at 09:51:33AM -0500, Adam Ford wrote: > On Sun, Apr 30, 2017 at 11:04 AM, Sebastian Reichel wrote: > > On Sun, Apr 30, 2017 at 10:14:20AM -0500, Adam Ford wrote: > >> On Wed, Apr 5, 2017 at 1:30 PM, Rob Herring wrote: > >> > This series

Re: [PATCH net v2] Check for skb_put_padto return value

From: Peter Heise Date: Sun, 7 May 2017 17:15:26 + > Return value of skb_put_padto is now checked as > reported by Dan Carpenter. skb might be freed in > case of error in skb_put_padto. > --- > net/hsr/hsr_device.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [PATCH] net/hippi/rrunner: use memdup_user

From: Geliang Tang Date: Sat, 6 May 2017 23:42:16 +0800 > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH] yam: use memdup_user

From: Geliang Tang Date: Sat, 6 May 2017 23:42:22 +0800 > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang Applied.

Re: [PATCH net] cxgb4: avoid disabling FEC by default

From: Ganesh Goudar Date: Sat, 6 May 2017 14:25:06 +0530 > Recent Chelsio firmware started using few port capablity bits to > manage FEC and as driver was not aware of FEC changes those bits > were zeroed, consequently disabling FEC. > > Avoid zeroing those bits and

Re: [PATCH] net: dsa: loop: Check for memory allocation failure

From: Christophe JAILLET Date: Sat, 6 May 2017 07:29:45 +0200 > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > Return -ENOMEM instead, as done for some other memory allocation just a > few lines above. > > Fixes: 98cd1552ea27 ("net: dsa: Mock-up

Re: [PATCH] bonding: make multi if nla_put_failure check into one

From: Hangbin Liu Date: Sat, 6 May 2017 11:17:52 +0800 > Signed-off-by: Hangbin Liu Changes like this neither make the code better nor worse, so please avoid this kind of churn. I'm not applying this. Thank you.

Re: [PATCH] bonding: check nla_put_be32 return value

From: Hangbin Liu Date: Sat, 6 May 2017 11:17:06 +0800 > Signed-off-by: Hangbin Liu Applied.

Re: [PATCH] bna: ethtool: Avoid reading past end of buffer

From: Kees Cook Date: Fri, 5 May 2017 15:30:23 -0700 > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. Instead, use strncpy() which will fill the

Re: [PATCH] qlge: Avoid reading past end of buffer

From: Kees Cook Date: Fri, 5 May 2017 15:34:34 -0700 > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. Instead, use strncpy() which will fill the

Re: [PATCH] bna: Avoid reading past end of buffer

From: Kees Cook Date: Fri, 5 May 2017 15:25:32 -0700 > Using memcpy() from a string that is shorter than the length copied means > the destination buffer is being filled with arbitrary data from the kernel > rodata segment. Instead, use strncpy() which will fill the

Re: [PATCH v2] vlan: Keep NETIF_F_HW_CSUM similar to other software devices

From: Vladislav Yasevich Date: Fri, 5 May 2017 16:17:41 -0400 > Vlan devices, like all other software devices, enable > NETIF_F_HW_CSUM feature. However, unlike all the othe other > software devices, vlans will switch to using IP|IPV6_CSUM > features, if the underlying

Re: [PATCH net] tcp: make congestion control optionally skip slow start after idle

From: Wei Wang Date: Fri, 5 May 2017 12:53:23 -0700 > From: Wei Wang > > Congestion control modules that want full control over congestion > control behavior do not want the cwnd modifications controlled by > the sysctl_tcp_slow_start_after_idle code

Re: [Patch net] ipv4: restore rt->fi for reference counting

From: Cong Wang Date: Thu, 4 May 2017 14:54:17 -0700 > IPv4 dst could use fi->fib_metrics to store metrics but fib_info > itself is refcnt'ed, so without taking a refcnt fi and > fi->fib_metrics could be freed while dst metrics still points to > it. This triggers

Re: FEC on i.MX 7 transmit queue timeout

On 2017-05-07 19:13, Andy Duan wrote: > From: Andrew Lunn Sent: Friday, May 05, 2017 8:24 PM >>To: Andy Duan >>Cc: Stefan Agner ; feste...@gmail.com; >>netdev@vger.kernel.org; netdev-ow...@vger.kernel.org >>Subject: Re: FEC on i.MX 7 transmit

Re: [PATCH net-next 9/9] ipvlan: introduce individual MAC addresses

On Mon, 2017-05-08 at 15:29 +, Chiappero, Marco wrote: > > -Original Message- > > From: Jiri Benc [mailto:jb...@redhat.com] > > Sent: Thursday, May 4, 2017 5:44 PM > > To: Chiappero, Marco > > Cc: Dan Williams ; netdev@vger.kernel.org; David

Re: sky2: Use seq_putc() in sky2_debug_show()

> Which issue do you mean? I dont see any issue you fix here. Are the run time characteristics a bit nicer for the function “seq_putc” in comparison to the function “seq_puts” for printing a single line break here? Regards, Markus

Re: [PATCH RFC net-next 0/6] net: reducing memory footprint of network devices

On 05/06/2017 09:07 AM, David Ahern wrote: > As I have mentioned many times[1], at ~43+kB per instance the use of > net_devices does not scale for deployments needing 10,000+ devices. At > netconf 1.2 there was a discussion about using a net_device_common for > the minimal set of common attributes

Re: [PATCH v1 0/4] stmmac: pci: Fix crash on Intel Galileo Gen2

On 2017-05-08 16:14, Andy Shevchenko wrote: > Due to misconfiguration of PCI driver for Intel Quark the user will get > a kernel crash: > > # udhcpc -i eth0 > udhcpc: started, v1.26.2 > stmmaceth :00:14.6 eth0: device MAC address 98:4f:ee:05:ac:47 > Generic PHY stmmac-a6:01: attached PHY

Re: [PATCH RFC net-next 5/6] net: Delay initializations for lightweight devices

On 05/06/2017 09:07 AM, David Ahern wrote: > Delay ipv4 and ipv6 initializations on lightweight netdevices until an > address is added to the device. > > Skip sysctl initialization for neighbor path as well. Yeah, thanks for including the sysctl initialization. One thing that my earlier "L2

Re: bpf pointer alignment validation

On Fri, May 05, 2017 at 10:47:09PM -0400, David Miller wrote: > From: David Miller > Date: Fri, 05 May 2017 16:20:44 -0400 (EDT) > > > Anyways, I'll play with this design and see what happens... > > Feedback is of course welcome. > > Here is a prototype that works for me

[PATCH] qca_debug: Reduce function calls for sequence output in qcaspi_info_show()

From: Markus Elfring Date: Mon, 8 May 2017 19:21:27 +0200 A bit of data was put into a sequence by separate function calls. Print the same data together with adjusted seq_printf() calls instead. This issue was detected by using the Coccinelle software.

Re: [PATCH RFC net-next 4/6] net: Do not intialize kobject for lightweight netdevs

On 05/06/2017 09:07 AM, David Ahern wrote: > Lightweight netdevices are not added to sysfs; bypass kobject > initialization. I was wondering if we actually needed a flag to tell: this is a lightweight device, but still let it show up in /sys. All use cases that I have in mind (getting the

Re: [PATCH net] bpf: don't let ldimm64 leak map addresses on unprivileged

On Mon, May 08, 2017 at 12:04:09AM +0200, Daniel Borkmann wrote: > The patch fixes two things at once: > > 1) It checks the env->allow_ptr_leaks and only prints the map address to >the log if we have the privileges to do so, otherwise it just dumps 0 >as we would when kptr_restrict is

[Patch net v3] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

For each netns (except init_net), we initialize its null entry in 3 places: 1) The template itself, as we use kmemdup() 2) Code around dst_init_metrics() in ip6_route_net_init() 3) ip6_route_dev_notify(), which is supposed to initialize it after loopback registers Unfortunately the last one

Re: [PATCH] sky2: Use seq_putc() in sky2_debug_show()

Hi, On 08.05.2017 18:42, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 8 May 2017 18:38:17 +0200 > > A single character (line break) should be put into a sequence. Why? > Thus use the corresponding function "seq_putc". > > This issue was detected

[PATCH] drivers: net: wimax: i2400m: i2400m-usb: Use time_after for time comparison

cast timeframe variable with (unsigned long) then use time_after() kernel macro for time comparison. Signed-off-by: Karim Eshapa --- drivers/net/wimax/i2400m/i2400m-usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

From: Pavel Belous Date: Thu, 4 May 2017 23:10:56 +0300 > From: Pavel Belous > > This patch fixes the crash that happens when driver tries to collect > statistics > from already released "aq_vec" object. > If adapter is in "down" state we

[PATCH RFC] net: Fix inconsistent teardown and release of private netdev state.

Network devices can allocate reasources and private memory using netdev_ops->ndo_init(). However, the release of these resources can occur in one of two different places. Either netdev_ops->ndo_uninit() or netdev->destructor(). The decision of which operation frees the resources depends upon

[PATCH] sky2: Use seq_putc() in sky2_debug_show()

From: Markus Elfring Date: Mon, 8 May 2017 18:38:17 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [RFC iproute2 0/8] RDMA tool

> Several companies maintain embedded Linux > distributions and tools to build software images. These tools provide a user > interface that allows to select what packages go into such an image. The tools allow you to select what binary packages are placed into the image. You can build multiple

[PATCH] fm10k: Use seq_putc() in fm10k_dbg_desc_break()

From: Markus Elfring Date: Mon, 8 May 2017 18:10:39 +0200 Two single characters should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

Re: [PATCH] net: ipv4: add code comment for clarification

Hi David, Quoting David Miller : From: "Gustavo A. R. Silva" Date: Thu, 4 May 2017 14:44:16 -0500 @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct sk_buff *skb, nlmsg_flags, unlh,

Re: [RFC iproute2 0/8] RDMA tool

On 05/04/2017 03:42 PM, Leon Romanovsky wrote: On Thu, May 04, 2017 at 03:26:13PM -0400, Dennis Dalessandro wrote: On 05/04/2017 02:45 PM, Leon Romanovsky wrote: On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote: On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote: On Thu,

Re: [Patch net v2] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

From: David Ahern Date: Thu, 4 May 2017 13:41:15 -0600 > On 5/4/17 11:36 AM, Cong Wang wrote: >> For each netns (except init_net), we initialize its null entry >> in 3 places: >> >> 1) The template itself, as we use kmemdup() >> 2) Code around dst_init_metrics() in

Re: [PATCH] net: ipv4: add code comment for clarification

From: "Gustavo A. R. Silva" Date: Thu, 4 May 2017 14:44:16 -0500 > @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct sk_buff > *skb, > nlmsg_flags, unlh, net_admin); > } > > +/* > + * Ignore the position of the

Re: [RFC iproute2 0/8] RDMA tool

On Mon, 8 May 2017 15:19:28 + Bart Van Assche wrote: > On Sun, 2017-05-07 at 12:20 +0200, Jiri Pirko wrote: > > Sat, May 06, 2017 at 04:40:24PM CEST, bart.vanass...@sandisk.com wrote: > > > On Sat, 2017-05-06 at 12:40 +0200, Jiri Pirko wrote: > > > > Thu, May

RE: [PATCH net-next 9/9] ipvlan: introduce individual MAC addresses

> -Original Message- > From: Jiri Benc [mailto:jb...@redhat.com] > Sent: Thursday, May 4, 2017 5:44 PM > To: Chiappero, Marco > Cc: Dan Williams ; netdev@vger.kernel.org; David S . > Miller ; Kirsher, Jeffrey T >

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

On Mon, May 8, 2017 at 7:33 AM, Ding Tianhong wrote: > > > On 2017/5/7 2:07, Alexander Duyck wrote: >> On Fri, May 5, 2017 at 8:08 PM, Ding Tianhong >> wrote: >>> >>> >>> On 2017/5/5 22:04, Alexander Duyck wrote: On Thu, May 4, 2017 at 2:01

Re: [RFC iproute2 0/8] RDMA tool

On Sun, 2017-05-07 at 12:20 +0200, Jiri Pirko wrote: > Sat, May 06, 2017 at 04:40:24PM CEST, bart.vanass...@sandisk.com wrote: > > On Sat, 2017-05-06 at 12:40 +0200, Jiri Pirko wrote: > > > Thu, May 04, 2017 at 08:10:54PM CEST, bart.vanass...@sandisk.com wrote: > > > > On Thu, 2017-05-04 at 21:02

Re: bpf pointer alignment validation

From: Daniel Borkmann Date: Mon, 08 May 2017 12:49:25 +0200 > On 05/06/2017 04:47 AM, David Miller wrote: >> From: David Miller >> Date: Fri, 05 May 2017 16:20:44 -0400 (EDT) >> >>> Anyways, I'll play with this design and see what happens... >>>

Re: [PATCH net] ipv6: make sure dev is not NULL before call ip6_frag_reasm

On Mon, 2017-05-08 at 11:09 +0800, Hangbin Liu wrote: > Since ip6_frag_reasm() will call __in6_dev_get(dev), which will access > dev->ip6_ptr. We need to make sure dev is not NULL. > > Signed-off-by: Hangbin Liu > --- > net/ipv6/reassembly.c | 2 +- > 1 file changed, 1

Re: [PATCH net] tcp: init tcp_options before using it.

On Mon, 2017-05-08 at 17:57 +0800, Hangbin Liu wrote: > I searched 4308fc58dced ("tcp: Document use of undefined variable") in > archive list, but did not find the thread. So I'm not sure why we only > add a description about un-initialized value. > > Even we don't use tmp_opt.sack_ok, I think it

Re: [PATCH net-next ] tcp: add new parameter tcp_inherit_buffsize to control the initial buffer size for new passive connetion

On Mon, 2017-05-08 at 15:49 +0800, Shan Wei wrote: > Indeed, HZ=250. What is the problem about autotuning with HZ=250? > You might look at recent patches. commit 645f4c6f2ebd040688cc2a5f626ffc909e66ccf2 ("tcp: switch rcv_rtt_est and rcvq_space to high resolution timestamps") Thanks.

pull-request: mac80211 2017-05-08

Hi Dave, Thanks for merging the rate fix quickly the other day. I've got a few more fixes lined up, so this time as a pull request. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 4ac4d584886a4f47f8ff3bca0f32ff9a2987d3e5: Merge

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

On 2017/5/7 2:07, Alexander Duyck wrote: > On Fri, May 5, 2017 at 8:08 PM, Ding Tianhong wrote: >> >> >> On 2017/5/5 22:04, Alexander Duyck wrote: >>> On Thu, May 4, 2017 at 2:01 PM, Casey Leedom wrote: | From: Alexander Duyck

Re: [PATCH] net: ethernet: stmmac: properly set PS bit in MII configurations during reset

Hello On 5/3/2017 4:30 PM, Corentin Labbe wrote: On Wed, May 03, 2017 at 10:13:56AM +0200, Giuseppe CAVALLARO wrote: Hello Thomas this was initially set by using the hw->link.port; both the core_init and adjust callback should invoke the hook and tuning the PS bit according to the speed and

Re: [PATCH v1 1/4] stmmac: pci: set default number of rx and tx queues

On 5/8/2017 4:14 PM, Andy Shevchenko wrote: The commit 26d6851fd24e ("net: stmmac: set default number of rx and tx queues in stmmac_pci") missed Intel Quark configuration. Append it here. Fixes: 26d6851fd24e ("net: stmmac: set default number of rx and tx queues in stmmac_pci") Cc:

Re: [PATCH v1 4/4] stmmac: pci: split out common_default_data() helper

Às 3:14 PM de 5/8/2017, Andy Shevchenko escreveu: > New helper is added in order to prevent misconfiguration happened > for one of the platforms when configuration data is expanded. > > Signed-off-by: Andy Shevchenko > --- >

Re: [PATCH v1 3/4] stmmac: pci: RX queue routing configuration

Às 3:14 PM de 5/8/2017, Andy Shevchenko escreveu: > The commit abe80fdc6ee6 > > ("net: stmmac: RX queue routing configuration") > > missed Intel Quark configuration. Append it here. > > Fixes: abe80fdc6ee6 ("net: stmmac: RX queue routing configuration") > Cc: Joao Pinto

Re: [PATCH v1 2/4] stmmac: pci: TX and RX queue priority configuration

Às 3:14 PM de 5/8/2017, Andy Shevchenko escreveu: > The commit a8f5102af2a7 > > ("net: stmmac: TX and RX queue priority configuration") > > missed Intel Quark configuration. Append it here. > > Fixes: a8f5102af2a7 ("net: stmmac: TX and RX queue priority configuration") > Cc: Joao Pinto

Re: [PATCH v1 1/4] stmmac: pci: set default number of rx and tx queues

Às 3:14 PM de 5/8/2017, Andy Shevchenko escreveu: > The commit 26d6851fd24e > > ("net: stmmac: set default number of rx and tx queues in stmmac_pci") > > missed Intel Quark configuration. Append it here. > > Fixes: 26d6851fd24e ("net: stmmac: set default number of rx and tx queues in >

[PATCH v1 4/4] stmmac: pci: split out common_default_data() helper

New helper is added in order to prevent misconfiguration happened for one of the platforms when configuration data is expanded. Signed-off-by: Andy Shevchenko --- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 52 1 file changed,

  1   2   >