Re: atheros driver - desc
Mateusz Berezecki [EMAIL PROTECTED] writes: The driver is not yet fully working because I didn't finish kernel integration yet. Almost all driver I/O ops are reverse engineered independently of openbsd openhal which is missing just too much. Ok, enough talking. Most of the atheros 5212 hal is now open :) This is great news. An open source Atheros driver which could be included to Linux is really needed. But how was the reverse engineering done? I noticed that forcedeth driver was implemented using the clean room design[1] and Linux Broadcom 4301 driver project[2] seems to be using the same method. The reason I'm asking this is that I just wouldn't want see the same happening this with this driver as happened during reverse engineering of pwc Philips Webcam driver (some parts of the driver were removed from kernel, but I believe the situation is now solved). Actually, what are requirements to get a reverse engineered driver included to Linux? Is clean room design an absolute must? It seems that reverse engineering is needed if we want Linux support for most of the WLAN cards on the market :( [1] http://en.wikipedia.org/wiki/Clean_room_design [2] http://linux-bcom4301.sourceforge.net/go/progress -- Kalle Valo - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: atheros driver - desc
Harald Welte [EMAIL PROTECTED] writes: I don't want to turn this list into a list of legal discussion, but since I'm heavily dealing with exactly those issues during my gpl-violations.org efforts, I thought I share some of the facts. Thanks for your answer, it cleared up things. I also don't want to discuss legal things here, we can discuss it more privately. But I'll just ask one more question in public: So in general, at least if you're doing that kind of work within the EU, I wouldn't be worried all that much. That's good news. But what about inclusion to the official Linux kernel? Can a driver reverse-engineered in EU be included to the kernel? (Big part of Linux is developed in US, I guess.) -- Kalle Valo - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] hostap: Fix null pointer dereference in prism2_pccard_card_present()
With my Buffalo WLI-CF-S11G PC Card kernel oopses every time in
prism2_interrupt() when I try load the hostap module. local-hw_priv is null
during the first call to prism2_interrupt(). It feels like
interrupts are enabled too early, or something.
This patch fixes the symptom, but not the cause.
Signed-off-by: Kalle Valo [EMAIL PROTECTED]
---
drivers/net/wireless/hostap/hostap_cs.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
61413565b21cff0f0d69a1760f3558de021804da
diff --git a/drivers/net/wireless/hostap/hostap_cs.c
b/drivers/net/wireless/hostap/hostap_cs.c
--- a/drivers/net/wireless/hostap/hostap_cs.c
+++ b/drivers/net/wireless/hostap/hostap_cs.c
@@ -212,7 +212,7 @@ static int prism2_event(event_t event, i
static int prism2_pccard_card_present(local_info_t *local)
{
struct hostap_cs_priv *hw_priv = local-hw_priv;
- if (hw_priv-link != NULL
+ if (hw_priv != NULL hw_priv-link != NULL
((hw_priv-link-state (DEV_PRESENT | DEV_CONFIG)) ==
(DEV_PRESENT | DEV_CONFIG)))
return 1;
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] hostap: Fix null pointer dereference in prism2_pccard_card_present()
Jouni Malinen [EMAIL PROTECTED] writes: applied, but let us know when the root cause is found... local-hw_priv was initialized only after the interrupt handler was registered. This could trigger a NULL pointer dereference in prism2_pccard_card_present() that assumed that local-hw_priv is always set (and it should have been). Fix this by setting local-hw_priv before registering the interrupt handler. I was trying to test Jouni's patch but now I can't reproduce the oops with latest ieee80211-wifi branch and my NULL pointer check removed. Earlier I could reproduce it every time. Strange. -- Kalle Valo - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[wireless] add WIRELESS_EXTENSIONS to net/Kconfig
Hostap selects IEEE80211 and IEEE80211 selects NET_RADIO. This causes recursive dependencies: Warning! Found recursive dependency: HOSTAP IEEE80211 NET_RADIO HOSTAP IEEE80211_CRYPT_WEP CRYPTO CRYPTO_ANUBIS Warning! Found recursive dependency: HOSTAP IEEE80211 NET_RADIO HOSTAP IEEE80211_CRYPT_WEP CRYPTO CRYPTO_MD4 Warning! Found recursive dependency: HOSTAP IEEE80211 NET_RADIO HOSTAP IEEE80211_CRYPT_WEP CRYPTO CRYPTO_MD5 Warning! Found recursive dependency: HOSTAP IEEE80211 NET_RADIO HOSTAP IEEE80211_CRYPT_WEP CRYPTO CRYPTO_AES_X86_64 Warning! Found recursive dependency: NET_RADIO HOSTAP IEEE80211 NET_RADIO HERMES TMD_HERMES Warning! Found recursive dependency: HOSTAP IEEE80211 NET_RADIO HOSTAP HOSTAP_PCI Warning! Found recursive dependency: NET_RADIO HOSTAP IEEE80211 NET_RADIO WAVELAN My proposal is to separate WIRELESS_EXTENSIONS from NET_RADIO configuration and move it to net/Kconfig. I think it's more logical to have it in the networking menu than deep inside the device drivers menu. Also, this simplifies the dependencies with IEEE80211 subsystem because they would be now in the same menu. Now IEEE80211 wouldn't depend on something which is in the device drivers menu. But, most importantly, this way I have the means to break the recursive dependency. In my opinion, this change is compatible with old drivers because NET_RADIO selects WIRELESS_ENTENSIONS, but I haven't tested that. I have only tested the drivers in the netdev-2.6 branch. Signed-off-by: Kalle Valo [EMAIL PROTECTED] --- drivers/net/wireless/Kconfig | 16 ++-- net/Kconfig | 17 + net/core/dev.c |4 ++-- net/socket.c |4 ++-- 4 files changed, 23 insertions(+), 18 deletions(-) fd3fa402af51c24180c65f3191abc006ac6e28c1 diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig --- a/drivers/net/wireless/Kconfig +++ b/drivers/net/wireless/Kconfig @@ -6,24 +6,12 @@ menu Wireless LAN (non-hamradio) depends on NETDEVICES config NET_RADIO - bool Wireless LAN drivers (non-hamradio) Wireless Extensions + bool Wireless LAN drivers (non-hamradio) + select WIRELESS_EXTENSIONS ---help--- Support for wireless LANs and everything having to do with radio, but not with amateur radio or FM broadcasting. - Saying Y here also enables the Wireless Extensions (creates - /proc/net/wireless and enables iwconfig access). The Wireless - Extension is a generic API allowing a driver to expose to the user - space configuration and statistics specific to common Wireless LANs. - The beauty of it is that a single set of tool can support all the - variations of Wireless LANs, regardless of their type (as long as - the driver supports Wireless Extension). Another advantage is that - these parameters may be changed on the fly without restarting the - driver (or Linux). If you wish to use Wireless Extensions with - wireless PCMCIA (PC-) cards, you need to say Y here; you can fetch - the tools from - http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/Tools.html. - Some user-level drivers for scarab devices which don't require special kernel support are available from ftp://shadow.cabi.net/pub/Linux/. diff --git a/net/Kconfig b/net/Kconfig --- a/net/Kconfig +++ b/net/Kconfig @@ -215,6 +215,23 @@ endmenu source net/ax25/Kconfig source net/irda/Kconfig source net/bluetooth/Kconfig + +config WIRELESS_EXTENSIONS + bool Wireless Extensions + ---help--- + Saying Y here also enables the Wireless Extensions (creates + /proc/net/wireless and enables iwconfig access). The Wireless + Extension is a generic API allowing a driver to expose to the user + space configuration and statistics specific to common Wireless LANs. + The beauty of it is that a single set of tool can support all the + variations of Wireless LANs, regardless of their type (as long as + the driver supports Wireless Extension). Another advantage is that + these parameters may be changed on the fly without restarting the + driver (or Linux). If you wish to use Wireless Extensions with + wireless PCMCIA (PC-) cards, you need to say Y here; you can fetch + the tools from + http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/Tools.html. + source net/ieee80211/Kconfig endif # if NET diff --git a/net/core/dev.c b/net/core/dev.c --- a/net/core/dev.c +++ b/net/core/dev.c @@ -109,10 +109,10 @@ #include linux/netpoll.h #include linux/rcupdate.h #include linux/delay.h -#ifdef CONFIG_NET_RADIO +#ifdef CONFIG_WIRELESS_EXTENSIONS #include linux/wireless.h/* Note : will define WIRELESS_EXT */ #include net/iw_handler.h -#endif /* CONFIG_NET_RADIO */ +#endif /* CONFIG_WIRELESS_EXTENSIONS */ #include asm/current.h
[ieee80211] select WIRELESS_EXTENSIONS instead of NET_RADIO
This fixes the recursive dependency in hostap. Depends on my previous patch which added WIRELESS_EXTENSIONS. Signed-off-by: Kalle Valo [EMAIL PROTECTED] --- net/ieee80211/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) 0a96ef321308c0fce817b78e3d4666463baa286f diff --git a/net/ieee80211/Kconfig b/net/ieee80211/Kconfig --- a/net/ieee80211/Kconfig +++ b/net/ieee80211/Kconfig @@ -1,6 +1,6 @@ config IEEE80211 tristate Generic IEEE 802.11 Networking Stack - select NET_RADIO + select WIRELESS_EXTENSIONS ---help--- This option enables the hardware independent IEEE 802.11 networking stack. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [for,4.1] rtlwifi: rtl8192cu: Fix kernel deadlock
The USB mini-driver in rtlwifi, which is used by rtl8192cu, issues a call to usb_control_msg() with a timeout value of 0. In some instances where the interface is shutting down, this infinite wait results in a CPU deadlock. A one second timeout fixes this problem without affecting any normal operations. This bug is reported at https://bugzilla.novell.com/show_bug.cgi?id=927786. Reported-by: Bernhard Wiedemann bwiedem...@suse.com Tested-by: Bernhard Wiedemann bwiedem...@suse.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org Cc: Bernhard Wiedemann bwiedem...@suse.com Cc: Takashi Iwaiti...@suse.com Thanks, applied to wireless-drivers.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] iwl4965: Enable checking of format strings
Rasmus Villemoes li...@rasmusvillemoes.dk writes: Since these fmt_* variables are just const char*, and not const char[], gcc (and smatch) doesn't to type checking of the arguments to the printf functions. Since the linker knows perfectly well to merge identical string constants, there's no point in having three static pointers waste memory and give an extra level of indirection. This removes over 100 non-constant format argument warnings from smatch, accounting for about 20% of all such warnings in an allmodconfig. Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk So what's the conclusion, should I commit this patch or not? Full discussion here: https://patchwork.kernel.org/patch/5814811/ -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: mwifiex: do not return success when command times out
wait_event_interruptible_timeout() returns 0 upon timeout. We should convert it to a negative error code (such as -ETIMEDOUT) instead of returning it directly, as return code of 0 indicates that command was executed. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [5/9] wl1251: drop unneeded goto
From: Julia Lawall julia.law...@lip6.fr Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @r@ identifier l; @@ -if (...) goto l; -l: // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ray_cs: Change 1 to true for bool type variable.
The variable translate is bool type. So assigning true instead of 1. Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers-next 2015-06-18
Hi Dave, here's one more pull request I would like to get to 4.2 if possible. Nothing major this time, just small stuff all over. Please let me know if you have any problems. Kalle The following changes since commit c39c4c6abb89d24454b63798ccbae12b538206a5: tcp: double default TSQ output bytes limit (2015-06-04 01:09:36 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git tags/wireless-drivers-next-for-davem-2015-06-18 for you to fetch changes up to 40b503c76481aecf811a29a14a80c13b429b5e14: brcmfmac: make brcmf_p2p_detach() call conditional (2015-06-16 11:35:10 +0300) Major changes: mwifiex: * enhancements for AP mode: support verbose information in station dump command and also information about AP link. * enable power save by default brcmfmac: * fix module reload issue for PCIe * improving msgbuf protocol for PCIe devices * rework .get_station() cfg80211 callback operation * determine interface combinations upon device feature support ath9k: * ath9k_htc: add support of channel switch wil6210: * add modparam for bcast ring size * support hidden SSID * add per-MCS Rx stats Amitkumar Karwar (1): mwifiex: add missing break statement in switch case Arend van Spriel (10): brcmfmac: remove chipinfo debugfs entry brcmfmac: remove watchdog reset from brcmf_pcie_buscoreprep() brcmfmac: use debugfs_create_devm_seqfile() helper function brcmfmac: rework .get_station() callback brcmfmac: have sdio return -EIO when device communication is not possible brcmfmac: free ifp for non-netdev interface in p2p module brcmfmac: move p2p attach/detach functions brcmfmac: assure p2pdev is unregistered upon driver unload brcmfmac: fix double free of p2pdev interface brcmfmac: make brcmf_p2p_detach() call conditional Avinash Patil (12): mwifiex: verbose logging for association failure messages mwifiex: correct bss_type assignment mwifiex: support AP reset after bss_stop mwifiex: enable 11d after bss reset mwifiex: reset 11h active flag when chandef does not require dfs mwifiex: disable CAC upon radar detection event mwifiex: parse power constraint IE from Tail mwifiex: support downloading IEs from tail mwifiex: drop block-ack action frames mwifiex: advertise PS ON by default support to cfg80211 mwifiex: update AP WMM settings from BSS_START event mwifiex: update current config_band info in start_ap Brent Taylor (1): ath6kl: Fix multiple clients associating in AP mode Chun-Yeow Yeoh (1): ath9k_htc: add support of channel switch Chunfan Chen (1): mwifiex: handle BT coex event to adjust Rx BA window size Felix Fietkau (1): ath9k: fix DMA stop sequence for AR9003+ Hamad Kadmany (1): wil6210: Support hidden SSID Hans Ulli Kroll (1): rtlwifi: fix tm_trigger usage Hante Meuleman (1): brcmfmac: Update msgbuf read pointer quicker. Jakub Kicinski (5): mt7601u: unify paged and non-paged RX dma paths mt7601u: watch out for invalid-length frames mt7601u: don't cleanup device second time after .resume() mt7601u: set promiscous mode based on FIF_OTHER_BSS mt7601u: don't warn about devices without per-rate power table Julia Lawall (1): wl1251: drop unneeded goto Kalle Valo (1): Merge ath-next from ath.git Michal Kazior (9): ath10k: move cycle_count macro ath10k: handle cycle counter wraparound ath10k: fix inconsistent survey reports ath10k: add missing firmware declarations ath10k: fix possible ps sleep crash ath10k: fix ar-rx_channel updating logic ath10k: remove ath10k_chanctx struct ath10k: fix channel switching ath10k: prevent memory leak in wmi rx ops Pontus Fuchs (2): brcmfmac: Check if firmware supports p2p brcmfmac: Build wiphy mode and interface combinations dynamically Rafał Miłecki (6): brcmfmac: support NVRAMs containing pci devpaths (instead of pcie) brcmfmac: set wiphy perm_addr to hardware MAC address brcmfmac: use direct data pointer in NVRAM parser struct b43: fix support for 14e4:4321 PCI dev with BCM4321 chipset bcma: make calls to PCI hostmode functions config-safe bcma: lower dependency of BCMA_DRIVER_PCI_HOSTMODE Raja Mani (2): ath10k: free wmi mgmt event skb when parsing fails ath10k: remove unused variable 'id' in ath10k_pci_tx_pipe_cleanup() Rajkumar Manoharan (1): ath10k: bypass PLL setting on target init for QCA9888 Stanislaw Gruszka (2): MAINTAINERS: remove rt2x00.serialmonkey.com list and web page rt2800: fix assigning same WCID for different stations Taehee Yoo (8): rtlwifi: rtl8192cu: Fix performance issue
Re: [PATCH] ath10k: txrx: remove unreachable negative return check and fixup type
Nicholas Mc Guire hof...@osadl.org writes: wait_event_timeout(), introduced in 'commit 5e3dd157d7e7 (ath10k: mac80211 driver for Qualcomm Atheros 802.11ac CQA98xx devices)' never returns 0 so the only failure condition to be checked is == 0 (timeout). Further the return type is long not int - an appropriately named variable is added and the assignments fixed up. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ath10k: mac: remove unreachable negative return check
Nicholas Mc Guire hof...@osadl.org writes: wait_event_timeout(), introduced in 'commit 5e3dd157d7e7 (ath10k: mac80211 driver for Qualcomm Atheros 802.11ac CQA98xx devices)' never returns 0 so the only failure condition to be checked is ==0 (timeout). Further the return type is long not int - an appropriately named variable is added and the assignments fixed up. Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers 2015-06-01
Hi Dave, here are three more important fixes I'm hoping to get to 4.1 still, I hope I'm not too late with these. Please let me know if there are any problems. Kalle The following changes since commit aefa441b150279dd8d25658e018898a3fe9a6769: Merge tag 'iwlwifi-for-kalle-2015-05-21' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2015-05-22 10:47:02 +0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-06-01 for you to fetch changes up to 38fe44e61a894f1c7b3e60b0614030271070ea53: Merge tag 'iwlwifi-for-kalle-2015-05-28' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2015-05-28 16:28:03 +0300) iwlwifi: * fix OTP parsing 8260 * fix powersave handling for 8260 brcmfmac: * fix null pointer crash Arend van Spriel (1): brcmfmac: avoid null pointer access when brcmf_msgbuf_get_pktid() fails Ilan Peer (1): iwlwifi: pcie: fix tracking of cmd_in_flight Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-05-28' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Liad Kaufman (1): iwlwifi: nvm: fix otp parsing in 8000 hw family drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c | 12 +-- drivers/net/wireless/iwlwifi/iwl-nvm-parse.c |2 +- drivers/net/wireless/iwlwifi/pcie/internal.h |6 +++--- drivers/net/wireless/iwlwifi/pcie/trans.c|4 ++-- drivers/net/wireless/iwlwifi/pcie/tx.c | 23 +- 5 files changed, 20 insertions(+), 27 deletions(-) -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull-request: wireless-drivers-next 2015-05-21
David Miller da...@davemloft.net writes: From: Kalle Valo kv...@codeaurora.org Date: Thu, 21 May 2015 16:39:04 +0300 here's a wireless-drivers pull request for 4.2. This time please pay extra attention to this pull as there are two problems: First of all as you can see the diffstat from git-pull-request in the end is just weird. I was long and hard trying to check everything and to my understanding all the merges look ok and I cannot explain the reason for the diffstat, but of course I might be missing something. Maybe git-request-pull is just buggy? At least with gitk everything looks to be ok and the patch list below also looks valid. The diffstat doesn't look anything like that for me. It contained only your wireless changes. It may have helped that I merged 'net' into 'net-next' right before I pulled this. Good to hear. Secondly there's a non-trivial conflict in drivers/net/wireless/ath/ath10k/mac.c which is due to removal of FIF_PROMISC_IN_BSS in commit df1404650c. You need to remove more code than just the obvious conflicts shown by git. In the end of this mail I added a git diff output after I fixed the conflict, hopefully that helps you to fix it. The main points are that you remove ath10k_mac_should_disable_promisc() and the last ath10k_monitor_recalc() call from ath10k_vdev_start_restart() along with the obvious conflict fixes git points out. There's also a patch from Michal which will also help to fix the resolution. Michal, please double check the resolution proposal below so that I didn't miss anything. https://patchwork.kernel.org/patch/6387631/ Thanks, I think I got the conflict resolution correct, please have a look. Looks good, thanks for fixing it. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers 2015-05-25
Hi Dave, here's hopefully the last wireless-drivers pull request for 4.1. Mostly iwlwifi fixes this time. Please let me know if there are any problems. Kalle The following changes since commit f673821864899153142365aca888435815ac93f0: ath9k: fix per-packet tx power configuration (2015-05-03 23:54:38 +0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-05-25 for you to fetch changes up to aefa441b150279dd8d25658e018898a3fe9a6769: Merge tag 'iwlwifi-for-kalle-2015-05-21' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2015-05-22 10:47:02 +0300) iwlwifi: * fix firmware name and other things to enable 3165 * fix bad APMG configuration for 8000 (no AMPG on these devices) * fix MAC address assignment for 8000 * fix firmware debugging triggers (MLME) * fix several bugs in low power states code (net-detect, d0i3) ssb: * fix reboot after device reset for WRT350N v1 Avri Altman (1): iwlwifi: pcie: don't disable the busmaster DMA clock for family 8000 Eliad Peller (1): iwlwifi: mvm: avoid use-after-free on iwl_mvm_d0i3_enable_tx() Emmanuel Grumbach (4): iwlwifi: mvm: forbid MIMO on devices that don't support it iwlwifi: 7000: modify the firmware name for 3165 iwlwifi: mvm: fix MLME trigger iwlwifi: mvm: BT Coex - duplicate the command if sent ASYNC Haim Dreyfuss (1): iwlwifi: mvm: Free fw_status after use to avoid memory leak Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-05-21' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Liad Kaufman (1): iwlwifi: nvm: force mac from otp in case nvm mac is reserved Luciano Coelho (2): iwlwifi: mvm: take the UCODE_DOWN reference when resuming iwlwifi: mvm: clean net-detect info if device was reset during suspend Rafał Miłecki (1): ssb: extend fix for PCI related silent reboots to all chipsets drivers/net/wireless/iwlwifi/Kconfig|1 + drivers/net/wireless/iwlwifi/iwl-7000.c | 16 ++-- drivers/net/wireless/iwlwifi/iwl-eeprom-parse.c |5 drivers/net/wireless/iwlwifi/iwl-eeprom-parse.h |3 +++ drivers/net/wireless/iwlwifi/iwl-nvm-parse.c| 30 +-- drivers/net/wireless/iwlwifi/mvm/coex_legacy.c |2 +- drivers/net/wireless/iwlwifi/mvm/d3.c | 22 - drivers/net/wireless/iwlwifi/mvm/mac80211.c |3 --- drivers/net/wireless/iwlwifi/mvm/ops.c |6 +++-- drivers/net/wireless/iwlwifi/mvm/rs.c |3 +++ drivers/net/wireless/iwlwifi/pcie/trans.c |8 +++--- drivers/ssb/driver_pcicore.c|7 +++--- 12 files changed, 73 insertions(+), 33 deletions(-) -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ath9k_htc: wmi: match wait_for_completion_timeout return type
Nicholas Mc Guire der.h...@hofr.at writes: On Thu, 14 May 2015, Kalle Valo wrote: Nicholas Mc Guire hof...@osadl.org writes: Patch is against 4.1-rc3 (localversion-next is -next-20150514) BTW, this info should be under --- line so that it doesn't get stored to the actual commit log. that is where I had been putting it until ask by Josh Triplett and Steven Rostedt to put it above the --- line explicitly see: http://lkml.org/lkml/2015/5/11/552 So now I'm a bit lost where to actually put this buildtest info ? Different maintainers have different opinions, there is no one answer, but if Steven is okay to have this in the commit log so am I. So no need to change anything. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull-request: wireless-drivers-next 2015-05-21
Michal Kazior michal.kaz...@tieto.com writes:
On 21 May 2015 at 15:39, Kalle Valo kv...@codeaurora.org wrote:
Secondly there's a non-trivial conflict in
drivers/net/wireless/ath/ath10k/mac.c which is due to removal of
FIF_PROMISC_IN_BSS in commit df1404650c. You need to remove more code
than just the obvious conflicts shown by git. In the end of this mail I
added a git diff output after I fixed the conflict, hopefully that helps
you to fix it. The main points are that you remove
ath10k_mac_should_disable_promisc() and the last ath10k_monitor_recalc()
call from ath10k_vdev_start_restart() along with the obvious conflict
fixes git points out.
There's also a patch from Michal which will also help to fix the
resolution. Michal, please double check the resolution proposal below so
that I didn't miss anything.
https://patchwork.kernel.org/patch/6387631/
[...]
Looks good to me.
Thanks for checking.
There's still some code left which is unnecessary (see 2 last hunks on
patchwork) because due to FIF_PROMISC_IN_BSS removal entire commit
548462133d98 becomes obsolete. Since these 2 hunk leftovers don't
break anything functionally I guess this can be cleaned up in a follow
up patch after the merge. Just my 2cc.
Just to avoid any confusion, these are the hunks you mean (copypaste
from patchwork, whitespace damage likely):
@@ -1267,7 +1250,7 @@ static int ath10k_vdev_start_restart(struct ath10k_vif
*arvif,
{
struct ath10k *ar = arvif-ar;
struct wmi_vdev_start_request_arg arg = {};
- int ret = 0, ret2;
+ int ret = 0;
lockdep_assert_held(ar-conf_mutex);
@@ -1326,16 +1309,6 @@ static int ath10k_vdev_start_restart(struct ath10k_vif
*arvif,
ar-num_started_vdevs++;
ath10k_recalc_radar_detection(ar);
- ret = ath10k_monitor_recalc(ar);
- if (ret) {
- ath10k_warn(ar, mac failed to recalc monitor for vdev %i
restart %d: %d\n,
- arg.vdev_id, restart, ret);
- ret2 = ath10k_vdev_stop(arvif);
- if (ret2)
- ath10k_warn(ar, mac failed to stop vdev %i restart %d:
%d\n,
- arg.vdev_id, restart, ret2);
- }
-
return ret;
}
Yeah, these needs to be removed. For some reason 'git diff' doesn't show
these hunks after the conflicts are fixed.
+ static int ath10k_vdev_start_restart(struct ath10k_vif *arvif,
+const struct cfg80211_chan_def *chandef,
+bool restart)
{
struct ath10k *ar = arvif-ar;
- struct cfg80211_chan_def *chandef = ar-chandef;
struct wmi_vdev_start_request_arg arg = {};
- int ret = 0, ret2;
+ int ret = 0;
lockdep_assert_held(ar-conf_mutex);
Kalle, I'm not seeing this when I merge your pull tag on top of
net-next/master. Am I missing something?
You lost me, you are not seeing what? I think we have a misunderstanding
here, let me explain how I created that diff:
git clone --reference ~/linux-2.6/
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
cd net-next/
git pull
git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
tags/wireless-drivers-next-for-davem-2015-05-21
emacs drivers/net/wireless/ath/ath10k/mac.c
git diff resolution.txt
Anyway FYI ath10k_vdev_stop() was moved up in the code to avoid
forward declaration in 822b7e0b633b.
Didn't understand this either.
--
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3] brcmfmac: prohibit ACPI power management for brcmfmac driver
Fu, Zhonghui zhonghui...@linux.intel.com writes: ACPI will manage WiFi chip's power state during suspend/resume process on some tablet platforms(such as ASUS T100TA). This is not supported by brcmfmac driver now, and the context of WiFi chip will be damaged after resume. This patch informs ACPI not to manage WiFi chip's power state. Signed-off-by: Zhonghui Fu zhonghui...@linux.intel.com Acked-by: Arend van Spriel ar...@broadcom.com Thanks, applied to wireless-drivers-next.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: carl9170: match wait_for_completion_timeout return type
Return type of wait_for_completion_timeout is unsigned long not int. An appropriately named unsigned long is added, and the assignments as well as error checking fixed up. API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/net/wireless/ath/carl9170/usb.c:675 int return assigned to unsigned long Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, CONFIG_CARL9170=m Patch is against 4.1-rc3 (localversion-next is -next-20150512) Signed-off-by: Nicholas Mc Guire hof...@osadl.org Acked-by: Christian Lamparter chunk...@googlemail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: brcmfmac: avoid gcc-5.1 warning
gcc-5.0 gained a new warning in the fwsignal portion of the brcmfmac driver: drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c: In function 'brcmf_fws_txs_process': drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1478:8: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized] This is a false positive, and marking the brcmf_fws_hanger_poppkt function as 'static inline' makes the warning go away. I have checked the object file output and while a little code gets moved around, the size of the binary remains identical. Signed-off-by: Arnd Bergmann a...@arndb.de Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v2, 1/2] adm8211: fix checkpatch errors for indentation and new line
This patch fixes these checkpatch.pl errors around a single switch-case
block:
ERROR: switch and case should be at the same indent
ERROR: trailing statements should be on next line
More specifically, the fix has been applied to the five occurances of
the errors listed below.
ERROR: switch and case should be at the same indent
#1100: FILE: adm8211.c:1100:
+ switch (cline) {
[...]
+ default: reg |= (0x0 14);
ERROR: trailing statements should be on next line
#1101: FILE: adm8211.c:1101:
+ case 0x8: reg |= (0x1 14);
ERROR: trailing statements should be on next line
#1103: FILE: adm8211.c:1103:
+ case 0x16: reg |= (0x2 14);
ERROR: trailing statements should be on next line
#1105: FILE: adm8211.c:1105:
+ case 0x32: reg |= (0x3 14);
ERROR: trailing statements should be on next line
#1107: FILE: adm8211.c:1107:
+ default: reg |= (0x0 14);
Signed-off-by: Okash Khawaja okash.khaw...@gmail.com
Thanks, 2 patches applied to wireless-drivers-next.git:
f5c65f38912e adm8211: fix checkpatch errors for indentation and new line
fe0a483ecf44 adm8211: fixed the possible pci cache line sizes inside switch-case
Kalle Valo
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [NEXT] rtlwifi: btcoexist: Fix interference between rtl8723be andBluetooth
From: Daniel Drake dr...@endlessm.com During usage of the new Bluetooth driver for Realtek devices, it was found that BT scans were inhibited for the RTL8723BE when wireless was active. The exact cause of this interference is not known yet, but a satisfactory work around has been found that does not seem to have any visible side effects. Signed-off-by: Daniel Drake dr...@endlessm.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Shao Fu sha...@realtek.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [1/5] rtlwifi: Update regulatory database
From: Shao Fu sha...@realtek.com Driver rtlwifi maintains its own regulatory information, The Chrome Autotest (https://www.chromium.org/chromium-os/testing/autotest-user-doc) showed some errors. This patch adds the necessary information for rtlwifi. Signed-off-by: Shao Fu sha...@realtek.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Thanks, 5 patches applied to wireless-drivers-next.git: 02b5fffbe9e0 rtlwifi: Update regulatory database 852ce7805638 rtlwifi: rtl8188ee: Apply the new regulatory information 5620302484d4 rtlwifi: rtl8192ee: Apply the regulatory changes to driver b23cd22d3923 rtlwifi: rtl8723be: Update driver for regulatory changes d10101a60372 rtlwifi: rtl8821ae: Fix problem with regulatory information Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ath9k_htc: drv_init: match wait_for_completion_timeout return type
Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/net/wireless/ath/ath9k/htc_drv_init.c:81 int return assigned to unsigned long Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, CONFIG_ATH9K_HTC=m Patch is against 4.1-rc3 (localversion-next is -next-20150514) Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [V2] rtlwifi: misspelled code and comments corrected.
Signed-off-by: Cheolhyun Park pch851...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ath9k_htc: match wait_for_completion_timeout return type
Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/net/wireless/ath/ath9k/htc_hst.c:171 int return assigned to unsigned long ./drivers/net/wireless/ath/ath9k/htc_hst.c:277 int return assigned to unsigned long ./drivers/net/wireless/ath/ath9k/htc_hst.c:206 int return assigned to unsigned long Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, CONFIG_ATH9K_HTC=m Patch is against 4.1-rc3 (localversion-next is -next-20150514) Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive
There's already a generic implementation so use that instead. Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ath9k_htc: wmi: match wait_for_completion_timeout return type
Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/net/wireless/ath/ath9k/wmi.c:331 int return assigned to unsigned long Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, CONFIG_ATH9K_HTC=m Patch is against 4.1-rc3 (localversion-next is -next-20150514) Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: ath9k: match wait_for_completion_timeout return type
Return type of wait_for_completion_timeout is unsigned long not int. As time_left is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/net/wireless/ath/ath9k/link.c:197 int return assigned to unsigned long Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, Patch is against 4.1-rc3 (localversion-next is -next-20150514) Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] wil6210: match wait_for_completion_timeout return type
Nicholas Mc Guire hof...@osadl.org writes: Return type of wait_for_completion_timeout is unsigned long not int. As remain is exclusively used for wait_for_completion_timeout here its type is simply changed to unsigned long. API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/net/wireless/ath/wil6210/wmi.c:827 int return assigned to unsigned long Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m, CONFIG_WIL6210=m Patch is against 4.1-rc3 (localversion-next is -next-20150514) Signed-off-by: Nicholas Mc Guire hof...@osadl.org Thanks, applied to ath.git. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: rt2x00: adjust EEPROM_SIZE for rt2500usb
rt2500usb_validate_eeprom() read data up to 0x6e (EEPROM_CALIBRATE_OFFSET) but only 0x6a bytes has been allocated and read from the eeprom. This lead to out-of-bound accesses and invalid values for EEPROM_BBPTUNE_R17 and EEPROM_CALIBRATE_OFFSET. Change the EEPROM_SIZE to 0x6e in order to retrieve all the fields. Tested with a rt2570 device. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Acked-by: Stanislaw Gruszka sgrus...@redhat.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: pull-request: wireless-drivers-next 2015-08-19
Kalle Valo kv...@codeaurora.org writes: here's one more pull request for 4.3. More info in the signed tag below. This time I had to merge mac80211-next.git due to some iwlwifi dependencies and apparently that broke git-request-pull's diffstat again, it was showing changes which were not really coming from my tree. I think that's just a bug in my old git and really should update the tool. This time I just fixed the diffstat manually. But please be extra careful with this pull request and please let me know if you have any problems. Oh, I forgot to mention that I saw this build error when I did a test merge: net/ipv4/fib_semantics.c:553:3: error: implicit declaration of function lwtstate_free [-Werror=implicit-function-declaration] But I see that also with unmodified net-next so I'm assuming I didn't cause that :) -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers-next 2015-08-19
: make sure d3_suspend/resume ops exist wl18xx: update statistics acx and debugfs files Emmanuel Grumbach (10): iwlwifi: dvm: start HW before running FW iwlwifi: pcie: lock start_hw / start_fw / stop_device iwlwifi: pcie: cancel Tx timer upon firmware crash iwlwifi: pcie: add missing calls to synchronize_irq() iwlwifi: pcie: don't warn on long MPDUs when supported iwlwifi: pcie: dump RBs when FW error occurs Merge remote-tracking branch 'iwlwifi-fixes/master' into next Merge tag 'mac80211-next-for-davem-2015-08-14' into next iwlwifi: bump mvm firmware API to 16 iwlwifi: mvm: fix a race in D0i3 vs. Tx path Eyal Shapira (1): iwlwifi: mvm: rs: report last tx rate based on RSSI and caps Felix Fietkau (4): ath9k: add fast-xmit support ath9k: remove struct ath_atx_ac ath9k: remove the sched field in struct ath_atx_tid ath9k: fix build with CONFIG_ATH9K_STATION_STATISTICS=y Gregory Greenman (3): iwlwifi: mvm: add basic Time of Flight (802.11mc FTM) support iwlwifi: mvm: fix beacon filtering temperature thresholds for D0i3 iwlwifi: mvm: ignore CQM when setting beacon filtering in D0i3 enter flow Guy Mishol (3): wl18xx: add dynamic fw traces wlcore: add antenna diversity reading comments wl18xx: add diversity statistics Haim Dreyfuss (2): iwlwifi: pcie: Set scheduler to work on auto mode iwlwifi: pcie: provide a way to stop configuration if it is forbidden Hauke Mehrtens (1): bcma: fix access to host_pdev for PCIe devices Ilan Peer (2): iwlwifi: mvm: Do not sample the device time for session protection iwlwifi: mvm: Use the AP station for non_sta transmit Jakub Kicinski (4): mt7601u: fix dma from stack address mt7601u: use correct ieee80211_rx variant mt7601u: fix tx status reporting contexts mt7601u: lock out rx path and tx status reporting janusz.dzied...@tieto.com (4): ath9k: advertise p2p dev support when chanctx ath9k: handle RoC cancel correctly ath9k: setup rxfilter for all chanctx ath9k: setup rxfilter when offchannel Jes Sorensen (1): orinoco: Do not call wiphy_unregister() from free_orinocodev() Johannes Berg (12): iwlwifi: mvm: handle RX MPDUs separately iwlwifi: mvm: LRU-assign key offsets iwlwifi: dvm: move ADD_STA response handling to sync command iwlwifi: dvm: remove ADD_STA prints relying on station ID iwlwifi: dvm: remove command/return value from RX handlers iwlwifi: mvm: remove command/return value from RX handlers iwlwifi: remove command and return value from opmode RX iwlwifi: remove command header flags field iwlwifi: mvm: move existing UMAC commands to group 1 iwlwifi: mvm: move TX PN assignment for CCMP to the driver iwlwifi: pcie: support frag SKBs iwlwifi: pass NAPI struct from transport layer John Linville (1): mwl8k: refactor some conditionals for clarity Kalle Valo (4): Merge tag 'iwlwifi-next-for-kalle-2015-08-04' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git. Major changes in ath10k: Merge tag 'mac80211-next-for-davem-2015-08-14' mac80211-next.git Merge tag 'iwlwifi-next-for-kalle-2015-08-18' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Kevin Darbyshire-Bryant (1): ath10k: suppress 'failed to process fft' warning messages Larry Finger (7): rtlwifi: rtl8192ce: rtl8192cu: Fix endian issue rtlwifi: rtl8723ae: rtl8723be: rtl8723com: Fix firmware header endian issues rtlwifi: rtl8821ae: Fix firmware endian issues rtlwifi: rtl8192de: Fix firmware header endian issues rtlwifi: rtl888ee: Fix firmware header endian issues rtlwifi: rtl8192ee: Fix firmware header endian issues rtlwifi: rtl8192c-common: Fix two typos Linus Walleij (1): bcma: switch GPIO portions to use GPIOLIB_IRQCHIP Machani, Yaniv (1): wlcore/wl18xx : add time sync event handling Manikanta Pubbisetty (1): ath10k: add TCP/UDP Checksum offload support for QCA99x0 Maninder Singh (1): ath10k: fix wrong initialization of struct channel Matti Gottlieb (2): iwlwifi: mvm: Add FW paging mechanism for the UMAC on PCI iwlwifi: mvm: Add FW paging mechanism for the UMAC on SDIO Miaoqing Pan (1): ath9k: add correct MAC/BB name for ar9561 Michal Kazior (6): ath10k: remove futile fragmentation threshold config ath10k: reject 11b tx fragmentation configuration ath10k: initialize fw_features var ath10k: fix hw reconfig on wow failure ath10k: don't remove peer that doesn't exist ath10k: fix peer limit enforcement Nicholas Krause (1): iwlwifi: make various functions void in the file rs.c Nicholas Mc Guire (4): ath9k_htc: match wait_for_completion_timeout return type ath9k_htc: drv_init: match wait_for_completion_timeout return
pull-request: wireless-drivers-next 2015-07-31
Hi Dave, here's a pull request for 4.3. In this pull request there's I have one revert in commit 360d9bb5ee2d (Revert ath9k: export HW random number generator), the data doesn't seem to be random enough. Please let me know if you have any problems. Kalle The following changes since commit 9d7b372f0514d829b2f712aac5b85eaab2dc0cb2: Merge branch 'be2net-next' (2015-07-10 23:24:31 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git tags/wireless-drivers-next-for-davem-2015-07-31 for you to fetch changes up to 360d9bb5ee2db4d409448667de606c05b3914d53: Revert ath9k: export HW random number generator (2015-07-31 10:25:16 +0300) Major changes: mwifiex: * add TX DATA Pause support * add multichannel and TDLS channel switch support ath10k: * enable VHT for IBSS * initial work to support qca99x0 and the corresponding 10.4 firmware branch Andy Shevchenko (1): iwlegacy: convert hex_dump_to_buffer() to %*ph Aniket Nagarnaik (4): mwifiex: fix for p2p broken link mwifiex: add bss mode TLV to extended scan command mwifiex: use maximum ssid length as 0xfe for p2p mwifiex: correct p2p and station interface counters Antonio Borneo (1): wireless: cw1200: Remove redundant spi driver bus initialization Avinash Patil (10): mwifiex: add tx data pause support mwifiex: update domain_info upon band change in start_ap mwifiex: support for bypass tx queue mwifiex: enable traffic only when port is open mwifiex: extend tx_data pause to AP interface as well mwifiex: support to set multichannel policy to FW mwifiex: advertise multichannel support to cfg80211 mwifiex: separate interface combination for multichannel and DFS mwifiex: handle multichannel event MAINTAINERS: update for mwifiex driver maintainers Bartosz Markowski (1): ath10k: fix QCA61X4 boot up Christophe Jaillet (1): brcmsmac: Use kstrdup to simplify code Felix Fietkau (1): ath9k: make DMA stop related messages debug-only Guy Mishol (1): wlcore: add antenna diversity reading Hauke Mehrtens (1): bcma: fix build error when build as module Janusz Dziedzic (1): ath10k: enable VHT for IBSS John Linville (3): mwifiex: avoid freeing improper pointer in mwifiex_set_wowlan_mef_entry mwifiex: do not short circuit exit from mwifiex_set_mgmt_ies mwifiex: fix leak of gen_ie storage on exit from mwifiex_del_mgmt_ies Kalle Valo (2): Merge ath-next from ath.git. Revert ath9k: export HW random number generator Larry Finger (1): rtlwifi: rtl8821ae: Fix an expression that is always false Miaoqing Pan (2): ath9k: Fix register definitions for QCA956x ath9k: export HW random number generator Michal Kazior (10): ath10k: dump fw features during probing ath10k: print htt op_version upon driver boot ath10k: prevent debugfs mmio access crash kernel ath10k: don't set cck/ofdm scan flags ath10k: limit multi-vif ps more aggresivelly ath10k: fix hw roc expiration notifcation ath10k: update vdev ps state on start ath10k: fix per-vif queue locking ath10k: tweak interface combinations ath9k: fix moredata flag endianness in cabq tx Nicholas Mc Guire (3): ath10k: mac: remove unreachable negative return check ath10k: txrx: remove unreachable negative return check and fixup type ipw2100: fix timeout bug - always evaluated to 0 Nik Nyby (2): rtlwifi: fix typo in comments b43: Fix typo in function name Rafa? Mi?ecki (1): brcmfmac: set wiphy's addresses to provide valid MACs Rafał Miłecki (1): bcma: populate bus DT subnodes as platform_device-s Raja Mani (19): ath10k: remove unused variable hdr in ath10k_htt_rx_h_undecap() ath10k: include new wmi op version for 10.4 fw ath10k: add 10.4 fw wmi service bitmap definition ath10k: include 10.4 fw specific wmi cmd and event ids ath10k: set 10.4 fw exclusive wmi cmd as unsupported for other fw versions ath10k: add 10.4 fw wmi vdev cmd ids ath10k: add 10.4 fw wmi pdev cmd ids ath10k: fill 10.4 fw wmi init cmd default values ath10k: handle 10.4 fw wmi mgmt rx event ath10k: adjust default peer limits if qcache enabled in 10.4 fw ath10k: handle 10.4 fw wmi ready event ath10k: enhance swba event handler to adapt different size tim bitmap ath10k: handle 10.4 firmware wmi swba event ath10k: enable vdev and peer related operations for 10.4 fw ath10k: add scan support for 10.4 fw ath10k: add 10.4 fw specific htt msg definitions ath10k: advertise 10.4 fw ap and sta iface combination to mac80211 ath10k: set max spatial stream to 4 for 10.4 fw ath10k
Re: [v2] rsi: Fix failure to load firmware after memory leak fix and fixthe leak
Fixes commit eae79b4f3e82 (rsi: fix memory leak in rsi_load_ta_instructions()) which stopped the driver from functioning. Firmware data has been allocated using vmalloc(), resulting in memory that cannot be used for DMA. Hence the firmware was first copied to a buffer allocated with kmalloc() in the original code. This patch reverts the commit and only calls kfree() to release the buffer after sending the data. This fixes the memory leak without breaking the driver. Add a comment to the kmemdup() calls to explain why this is done, and abort if memory allocation fails. Tested on a Topic Miami-Florida board which contains the rsi SDIO chip. Also added the same kfree() call to the USB glue driver. This was not tested on actual hardware though, as I only have the SDIO version. Fixes: eae79b4f3e82 (rsi: fix memory leak in rsi_load_ta_instructions()) Signed-off-by: Mike Looijmans mike.looijm...@topic.nl Cc: sta...@vger.kernel.org Thanks, applied to wireless-drivers.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [V4.2] rtlwifi: Fix NULL dereference when PCI driver used as an AP
From: Luis Felipe Dominguez Vega lfdoming...@nauta.cu In commit 33511b157bbcebaef853cc1811992b664a2e5862 (rtlwifi: add support to send beacon frame), the mechanism for sending beacons was established. That patch works correctly for rtl8192cu, but there is a possibility of getting the following warnings in the PCI drivers: WARNING: CPU: 1 PID: 2439 at net/mac80211/driver-ops.h:12 ieee80211_bss_info_change_notify+0x179/0x1d0 [mac80211]() wlp5s0: Failed check-sdata-in-driver check, flags: 0x0 The warning is followed by a NULL pointer dereference as follows: BUG: unable to handle kernel NULL pointer dereference at 0006 IP: [c073998e] rtl_get_tcb_desc+0x5e/0x760 [rtlwifi] This problem was reported at http://thread.gmane.org/gmane.linux.kernel.wireless.general/138645, but no solution was found at that time. The problem was also reported at https://bugzilla.kernel.org/show_bug.cgi?id=9744 and this solution was developed and tested there. The USB driver works with a NULL final argument in the adapter_tx() callback; however, the PCI drivers need a struct rtl_tcb_desc in that position. Fixes: 33511b157bbc (rtlwifi: add support to send beacon frame.) Signed-off-by: Luis Felipe Dominguez Vega lfdoming...@nauta.cu Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org [3.19+] Thanks, applied to wireless-drivers.git. But I added Fixes line to make it clear what commit this fixes. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [-4.2] rtlwifi: rtl8723be: Add module parameter for MSI interrupts
The driver code allows for the disabling of MSI interrupts; however the module_parm line was missed and the option fails to show with modinfo. Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org [3.15+] Thanks, applied to wireless-drivers.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers 2015-08-04
Hi Dave, here are few small fixes I would like to get to 4.2. Please let me know if there are any problems. Kalle The following changes since commit df2cd4586f177acf9493dee079fc7d18268c5f54: Merge tag 'iwlwifi-for-kalle-2015-06-12' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2015-07-17 11:19:08 +0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-08-04 for you to fetch changes up to 741e3b9902d11585e18bfc7f8d47e913616bb070: rtlwifi: rtl8723be: Add module parameter for MSI interrupts (2015-08-03 11:26:24 +0300) iwlwifi: * a fix for the stuck TFD queue mechanism - it was producing noisy false alarms * a fix for the NIC prepare flow that prevented the driver from being able to access the device on certain systems * a fix for the scan prority handling which allows the regular scan to run even if a scheduled scan is already running rsi: * fix firmware load DMA regression b43: * fix extpa_gain check for 2GHz rtlwifi: * fix NULL dereference when PCI driver used as an AP * add missing module parameter declaration for rtl8723be_mod_params.msi_support Avraham Stern (1): iwlwifi: mvm: Fix regular scan priority Emmanuel Grumbach (2): iwlwifi: pcie: fix prepare card flow iwlwifi: pcie: fix stuck queue detection for sleeping clients Hauke Mehrtens (1): b43: fix extpa_gain check for 2GHz Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-07-30' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Larry Finger (1): rtlwifi: rtl8723be: Add module parameter for MSI interrupts Luis Felipe Dominguez Vega (1): rtlwifi: Fix NULL dereference when PCI driver used as an AP Mike Looijmans (1): rsi: Fix failure to load firmware after memory leak fix and fix the leak drivers/net/wireless/b43/tables_nphy.c |2 +- drivers/net/wireless/iwlwifi/mvm/scan.c |2 +- drivers/net/wireless/iwlwifi/pcie/trans.c | 22 +++--- drivers/net/wireless/iwlwifi/pcie/tx.c | 15 +-- drivers/net/wireless/rsi/rsi_91x_sdio_ops.c |8 +++- drivers/net/wireless/rsi/rsi_91x_usb_ops.c |4 drivers/net/wireless/rtlwifi/core.c |7 +-- drivers/net/wireless/rtlwifi/rtl8723be/sw.c |1 + 8 files changed, 51 insertions(+), 10 deletions(-) -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] iwlwifi: out-of-bounds access in iwl_init_sband_channels
Adrien Schildknecht adrien+...@schischi.me writes: Hi, On 08/14/2015 03:36 AM, Adrien Schildknecht wrote: Both loops of this function compare data from the 'chan' array and then check if the index is valid. The 2 conditions should be inverted to avoid an out-of-bounds access. Was that found by a static analyzer or any other automated tool, or was that the result of your very careful review? The error has been reported by KASan: == BUG: KASan: out of bounds access in iwl_init_sband_channels+0x207/0x260 [iwlwifi] at addr 8800c2d0aac8 Read of size 4 by task modprobe/329 == Always try to add information like this to the commit log, it's very useful. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive
Arend van Spriel ar...@broadcom.com writes: On 07/24/2015 07:22 PM, Vineet Gupta wrote: On Friday 24 July 2015 08:02 PM, Kalle Valo wrote: Vineet Gupta vineet.gup...@synopsys.com writes: There's already a generic implementation so use that instead. --- I'm not sure if the driver usage of atomic_or?() is correct in terms of storage size of @val for 64 bit arches. Assuming LP64 programming model for linux on say x86_64: atomic_or() callers in this driver use long (sana 64 bit) storage and pass it to atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ? --- Cc: Brett Rudley brud...@broadcom.com Cc: Arend van Spriel ar...@broadcom.com Cc: Franky (Zhenhui) Lin fran...@broadcom.com Cc: Hante Meuleman meule...@broadcom.com Cc: Kalle Valo kv...@codeaurora.org Cc: Pieter-Paul Giesberts piete...@broadcom.com Cc: Daniel Kim de...@broadcom.com Cc: linux-wirel...@vger.kernel.org Cc: brcm80211-dev-l...@broadcom.com Cc: Peter Zijlstra pet...@infradead.org Cc: Ingo Molnar mi...@kernel.org Cc: netdev@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Vineet Gupta vgu...@synopsys.com Signed-off-by: Vineet Gupta vgu...@synopsys.com What's the plan with this patch? Should I take it to my wireless-drivers-next tree or will someone else take it? Per last discussion on this topic, Arend wanted to discuss abt this with Hante. I'm not taking it anyways so feel free to pick it up if you want ! Well, that was before your timeline clarification about the generic function. One what tree is this patch based? Yeah, if this patch depends on another patch I need to know about it. Otherwise I might break something when I apply this patch. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] rsi: Fix failure to load firmware after memory leak fix and fix the leak
Mike Looijmans mike.looijm...@topic.nl writes: Fixes commit eae79b4f3e82ca63a53478a161b190a0d38fe526 (rsi: fix memory leak in rsi_load_ta_instructions()) which stopped the driver from functioning. You can abbreviate the commit id: Fixes commit eae79b4f3e82 (rsi: fix memory leak in rsi_load_ta_instructions()) which stopped the driver from functioning. Firmware data has been allocated using vmalloc(), resulting in memory that cannot be used for DMA. Hence the firmware was first copied to a buffer allocated with kmalloc() in the original code. This patch reverts the commit and only calls kfree() to release the buffer after sending the data. This fixes the memory leak without breaking the driver. Add a comment to the kmemdup() calls to explain why this is done. Tested on a Topic Miami-Florida board which contains the rsi SDIO chip. Also added the same kfree() call to the USB glue driver. This was not tested on actual hardware though, as I only have the SDIO version. Signed-off-by: Mike Looijmans mike.looijm...@topic.nl Add this before Signed-off-by line: Fixes: eae79b4f3e82 (rsi: fix memory leak in rsi_load_ta_instructions()) Cc: sta...@vger.kernel.org Also no need to send email to sta...@vger.kernel.org list, this line is enough and the stable team will pick the commit automatically. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel
Maninder Singh maninder...@samsung.com writes: chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com Thanks, applied. -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel
Maninder Singh maninder...@samsung.com writes: chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com How did you find this bug? Static anlysis reports this bug like coverity or any other static tool like cppcheck :- drivers/net/wireless/ath/ath10k/mac.c:839]: (error) Possible null pointer dereference: chandef Thanks. This is always good to add to the commit log so I did that: ath10k: fix wrong initialization of struct channel chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. Channel should be initialized after obtaining chandef. Found by cppcheck: ath/ath10k/mac.c:839]: (error) Possible null pointer dereference: chandef Signed-off-by: Maninder Singh maninder...@samsung.com Signed-off-by: Kalle Valo kv...@qca.qualcomm.com -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [2/2] iwlegacy: convert hex_dump_to_buffer() to %*ph
There is no need to use hex_dump_to_buffer() in the cases like this: hexdump_to_buffer(buf, len, 16, 1, outbuf, outlen, false); /* len = 16 */ sprintf(%s\n, outbuf); since it maybe easily converted to simple: sprintf(%*ph\n, len, buf); Note: it seems in the case the output is groupped by 2 bytes and looks like a typo. Thus, patch changes that to plain byte stream. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: rtlwifi: rtl8821ae: Fix an expression that is always false
In routine _rtl8821ae_set_media_status(), an incorrect mask results in a test for AP status to always be false. Similar bugs were fixed in rtl8192cu and rtl8192de, but this instance was missed at that time. Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Cc: Stable sta...@vger.kernel.org [3.18+] Cc: David Binderman dcb...@hotmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v2] brcmsmac: Use kstrdup to simplify code
Replace a kmalloc+strcpy by an equivalent kstrdup in order to improve readability. Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr Acked-by: Arend van Spriel ar...@broadcom.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] brcmfmac: dhd_sdio.c: use existing atomic_or primitive
Vineet Gupta vineet.gup...@synopsys.com writes: There's already a generic implementation so use that instead. --- I'm not sure if the driver usage of atomic_or?() is correct in terms of storage size of @val for 64 bit arches. Assuming LP64 programming model for linux on say x86_64: atomic_or() callers in this driver use long (sana 64 bit) storage and pass it to atomic_orr/atomic_or which downcasts it to 32 bits. Is that OK ? --- Cc: Brett Rudley brud...@broadcom.com Cc: Arend van Spriel ar...@broadcom.com Cc: Franky (Zhenhui) Lin fran...@broadcom.com Cc: Hante Meuleman meule...@broadcom.com Cc: Kalle Valo kv...@codeaurora.org Cc: Pieter-Paul Giesberts piete...@broadcom.com Cc: Daniel Kim de...@broadcom.com Cc: linux-wirel...@vger.kernel.org Cc: brcm80211-dev-l...@broadcom.com Cc: Peter Zijlstra pet...@infradead.org Cc: Ingo Molnar mi...@kernel.org Cc: netdev@vger.kernel.org Cc: linux-a...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Vineet Gupta vgu...@synopsys.com Signed-off-by: Vineet Gupta vgu...@synopsys.com What's the plan with this patch? Should I take it to my wireless-drivers-next tree or will someone else take it? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] rfkill-gpio: Add support for the Realtek 8723 BT
Johannes Berg johan...@sipsolutions.net writes: And while at it, please use links that include the message-id (e.g. mid.gmane.org) so it's searchable even if the archive disappears. BTW, I recently found out that kernel.org has a this type of service as well. From https://lkml.kernel.org/: http://lkml.kernel.org/r/message-id - for marc.info links http://lkml.kernel.org/g/message-id - for gmane.org links -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers 2015-07-20
Hi Dave, here are few fixes for 4.2, should not have anything out of ordinary. Please let me know if there are any issues. Kalle The following changes since commit 145c37084e3e6584b95f82361922965cc3af41bf: Doc: z8530book: Fix typo in API-z8530-sync-txdma-open.html (2015-07-10 23:45:31 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-07-20 for you to fetch changes up to df2cd4586f177acf9493dee079fc7d18268c5f54: Merge tag 'iwlwifi-for-kalle-2015-06-12' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2015-07-17 11:19:08 +0300) ath9k: * fix device ID check for AR956x iwlwifi: * bug fixes specific for 8000 series * fix a crash in time events * fix a crash in PCIe transport * fix BT Coex code that prevented association on certain devices (3160). * revert the new RBD allocation model because it introduced a bug when running on weak VM setups. * new device IDs Avraham Stern (1): iwlwifi: mvm: Add preemptive flag to scheulded scan Dreyfuss, Haim (1): iwlwifi: pcie: Fix bug in NIC's PM registers access Emmanuel Grumbach (4): iwlwifi: mvm: fix antenna selection when BT is active iwlwifi: pcie: don't panic if pcie transport alloc fails iwlwifi: pcie: prepare the device before accessing it Revert iwlwifi: pcie: New RBD allocation model Felix Fietkau (1): ath9k_hw: fix device ID check for AR956x Johannes Berg (1): iwlwifi: mvm: check time-event vif to avoid bad deletion Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-06-12' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes Liad Kaufman (1): iwlwifi: nvm: remove mac address byte swapping in 8000 family Matti Gottlieb (1): iwlwifi: mvm: Avoid accessing Null pointer when setting igtk Oren Givon (1): iwlwifi: edit the 3165 series and 8000 series PCI IDs drivers/net/wireless/ath/ath9k/hw.c|1 + drivers/net/wireless/iwlwifi/iwl-fh.h |6 + drivers/net/wireless/iwlwifi/iwl-nvm-parse.c | 12 +- drivers/net/wireless/iwlwifi/mvm/fw-api-scan.h |3 +- drivers/net/wireless/iwlwifi/mvm/scan.c|3 + drivers/net/wireless/iwlwifi/mvm/sta.c |3 +- drivers/net/wireless/iwlwifi/mvm/time-event.c |2 +- drivers/net/wireless/iwlwifi/mvm/tx.c |2 +- drivers/net/wireless/iwlwifi/pcie/drv.c|5 +- drivers/net/wireless/iwlwifi/pcie/internal.h | 51 +-- drivers/net/wireless/iwlwifi/pcie/rx.c | 414 +--- drivers/net/wireless/iwlwifi/pcie/trans.c | 52 +-- 12 files changed, 144 insertions(+), 410 deletions(-) -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel
Maninder Singh maninder...@samsung.com writes: chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh maninder...@samsung.com How did you find this bug? -- Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: mwifiex: usb: Fix double add error when submitting rx urb
There is an error that can occur where the driver adds the same URB to USB submission list twice. This happens since mwifiex_usb_submit_rem_rx can submit packets at same time as an rx urb complete callback. This causes list corruption and is fixed by not setting the skb to NULL when submitting an rx packet. [ 84.461242] WARNING: CPU: 1 PID: 748 at lib/list_debug.c:36 __list_add+0xcb/0xd0() [ 84.461245] list_add double add: new=8800c92b0c50, prev=8800c92b0c50, next=8800ced6c430. [ 84.461247] Modules linked in: rfcomm fuse cmac nf_conntrack_netbios_ns nf_conntrack_broadcast ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack bnep iptable_mangle iptable_security iptable_raw btusb btintel bluetooth mwifiex_usb mwifiex x86_pkg_temp_thermal cfg80211 coretemp r8712u(C) kvm_intel kvm hid_sensor_als hid_sensor_incl_3d hid_sensor_rotation hid_sensor_magn_3d hid_sensor_accel_3d hid_sensor_gyro_3d hid_sensor_trigger hid_sensor_iio_common industrialio_triggered_buffer kfifo_buf rfkill iTCO_wdt industrialio iTCO_vendor_support [ 84.461316] crc32_pclmul crc32c_intel ghash_clmulni_intel microcode snd_hda_codec_realtek vfat snd_hda_codec_generic fat snd_hda_codec_hdmi snd_hda_intel snd_hda_controller uvcvideo snd_hda_codec videobuf2_vmalloc videobuf2_memops snd_hwdep videobuf2_core snd_hda_core joydev v4l2_common videodev hid_sensor_hub snd_seq hid_multitouch media snd_seq_device snd_pcm snd_timer mei_me snd i2c_i801 lpc_ich mei soundcore tpm_infineon tpm_tis tpm i2c_hid i2c_designware_platform i2c_designware_core nfsd auth_rpcgss nfs_acl lockd grace sunrpc sch_fq_codel i915 i2c_algo_bit drm_kms_helper drm xhci_pci xhci_hcd ehci_pci sd_mod ehci_hcd video [ 84.461383] CPU: 1 PID: 748 Comm: kworker/u9:0 Tainted: G C 4.1.0-rc5+ #163 [ 84.461386] Hardware name: Microsoft Corporation Surface Pro 2/Surface Pro 2, BIOS 2.05.0250 04/10/2015 [ 84.461396] Workqueue: MWIFIEX_RX_WORK_QUEUE mwifiex_rx_work_queue [mwifiex] [ 84.461399] 81a8150e 8801174cf8e8 817df830 [ 84.461405] 8801174cf938 8801174cf928 810a54ba 8800c86bd750 [ 84.461410] 8800c92b0c50 8800c92b0c50 8800ced6c430 88010c057178 [ 84.461416] Call Trace: [ 84.461421] [817df830] dump_stack+0x4f/0x7b [ 84.461428] [810a54ba] warn_slowpath_common+0x8a/0xc0 [ 84.461432] [810a5536] warn_slowpath_fmt+0x46/0x50 [ 84.461436] [814109fb] __list_add+0xcb/0xd0 [ 84.461442] [815c551a] ? usb_hcd_link_urb_to_ep+0x2a/0xa0 [ 84.461446] [815c5570] usb_hcd_link_urb_to_ep+0x80/0xa0 [ 84.461459] [a004318a] prepare_transfer+0xaa/0x130 [xhci_hcd] [ 84.461470] [a0044cf7] xhci_queue_bulk_tx+0xb7/0x7a0 [xhci_hcd] [ 84.461480] [a003b67f] ? xhci_urb_enqueue+0x50f/0x660 [xhci_hcd] [ 84.461489] [a003b67f] ? xhci_urb_enqueue+0x50f/0x660 [xhci_hcd] [ 84.461498] [a003b735] xhci_urb_enqueue+0x5c5/0x660 [xhci_hcd] [ 84.461503] [815c7ad3] usb_hcd_submit_urb+0x93/0xa70 [ 84.461507] [8168dde8] ? __alloc_skb+0x78/0x1f0 [ 84.461511] [8168d301] ? __kmalloc_reserve.isra.26+0x31/0x90 [ 84.461515] [8168ddbc] ? __alloc_skb+0x4c/0x1f0 [ 84.461519] [8168ddfc] ? __alloc_skb+0x8c/0x1f0 [ 84.461523] [8168badd] ? skb_dequeue+0x5d/0x80 [ 84.461527] [815c987e] usb_submit_urb+0x42e/0x5f0 [ 84.461531] [816931d9] ? __alloc_rx_skb+0x39/0x100 [ 84.461536] [a05aa372] mwifiex_usb_submit_rx_urb+0xb2/0x170 [mwifiex_usb] [ 84.461542] [a05aa5f5] mwifiex_usb_submit_rem_rx_urbs+0x45/0x50 [mwifiex_usb] [ 84.461550] [a07094be] mwifiex_rx_work_queue+0x10e/0x140 [mwifiex] [ 84.461556] [810c4429] process_one_work+0x229/0x890 [ 84.461559] [810c438c] ? process_one_work+0x18c/0x890 [ 84.461565] [810c4ae3] worker_thread+0x53/0x470 [ 84.461569] [810c4a90] ? process_one_work+0x890/0x890 [ 84.461572] [810cb162] kthread+0xf2/0x110 [ 84.461577] [811031ad] ? trace_hardirqs_on+0xd/0x10 [ 84.461581] [810cb070] ? kthread_create_on_node+0x230/0x230 [ 84.461586] [817e9662] ret_from_fork+0x42/0x70 [ 84.461590] [810cb070] ? kthread_create_on_node+0x230/0x230 [ 84.461593] ---[ end trace 65103af5e6fb3444 ]--- Signed-off-by: Reyad Attiyat reyad.atti...@gmail.com Acked-by: Amitkumar Karwar akar...@marvell.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line
Re: [5/6] wireless: cw1200: Remove redundant spi driver bus initialization
In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo borneo.anto...@gmail.com To: Solomon Peachy pi...@shaftnet.org To: Kalle Valo kv...@codeaurora.org To: linux-wirel...@vger.kernel.org To: netdev@vger.kernel.org Cc: linux-ker...@vger.kernel.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0
punit vara <punitv...@gmail.com> writes: > Will my other patches which are already correct be added to wireless > tree ? or I have to resend everything ? Yes, please resend the whole patchset. I don't apply patches individually from a patchset, it's just too time consuming and error prone. Also, as you seem to be new here, I don't recommend sending big patchsets in the beginning. Start slow, send just few a patch or two at a time, and once you gain more experience send bigger patchsets. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers-next 2015-10-27
Hi Dave, here's a bigger pull request for 4.4. The diffstat looks scary as we created a new directory realtek for all realtek drivers. In the future I'm planning to create similar directories for all vendors, currently we just have ath, mediatek and realtek. This change has been in linux-next for a couple of weeks so it should be safe, but of course you never know. There's also a new driver rtl8xxxu for few realtek USB devices. This just made it to the last linux-next build. Otherwise there's nothing really special, more info below. If time permits, and it's ok for you, I'm hoping to send you a one more pull request this week. Kalle The following changes since commit 6623c60dc28ee966cd85c6f12aa2fc3c952d0179: bridge: vlan: enforce no pvid flag in vlan ranges (2015-10-12 19:59:15 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git tags/wireless-drivers-next-for-davem-2015-10-27 for you to fetch changes up to c0963772cbbf1b7dc9fad4497f3aba8526bb07d6: rtl8xxxu: fix unused rtl8192cu_fops compiler warning (2015-10-26 18:06:10 +0200) brcmfmac * using netdev carrier state * add and rework some cfg80211 callbacks mainly for AP mode * use devcoredump when triggered by firmware event realtek * create new directory drivers/net/wireless/realtek/ for all realtek drivers, not visible to users (no kconfig changes etc) * add rtl8xxxu, a new mac80211 driver for RTL8723AU, RTL8188CU, RTL8188RU, RTL8191CU, RTL8192CU and hopefully more in the future ath10k * add board 2 API support for automatically choosing correct board file * data path optimisations * disable PCI power save for qca988x and QCA99x0 due to interop reasons wil6210 * BlockAckReq support * firmware crashdump using devcoredump * capture all frames with sniffer Amitkumar Karwar (4): mwifiex: remove USB8897 chipset support mwifiex: correction in USB8997 chipset's product ID mwifiex: control WLAN and bluetooth coexistence modes mwifiex: add ndo_validate_addr netdev ops Anilkumar Kolli (1): ath10k: disable PCI PS for QCA988X and QCA99X0 Arend van Spriel (2): brcmfmac: expose device memory to devcoredump subsystem brcmfmac: remove conversational comment Colin Ian King (1): ath6kl: remove redundant null pointer check on send_pkt Eric Caruso (1): brcm80211: Add support for brcm4371 Franky Lin (1): brcmfmac: rename firmware_path to alternative_fw_path Ganapathi Bhat (1): mwifiex: fix AP VHT behaviour Geliang Tang (2): ath6kl: drop unlikely behind WARN_ON() mwifiex: fix a comment typo Hamad Kadmany (1): wil6210: Do no schedule firmware recovery during reset flow Hante Meuleman (8): brcmfmac: Fix race condition between USB probe/load and disconnect. brcmfmac: Rework p2p attach, use single method for p2p dev creation. brcmfmac: Fix station info rate information. brcmfmac: Add RSSI information to get_station. brcmfmac: Add dump_station support to cfg80221 ops. brcmfmac: Move brcmf_c_preinit_dcmds prototype to correct file. brcmfmac: Remove unused state AP creating. brcmfmac: Properly set carrier state of netdev. Jeff Johnson (1): ath10k: cleanup ath10k_mac_register() error handling Jes Sorensen (1): New driver: rtl8xxxu (mac80211) Kalle Valo (10): ath10k: fix checkpatch warning about logical continuations ath10k: indentation fixes ath10k: brace style fixes ath10k: remove void function return statements ath10k: fix whitespace usage ath10k: split an unnecessary long line ath10k: add a_sle32_to_cpu() Merge ath-next from ath.git rtl8xxxu: move devices supported by rtlwifi under UNTESTED config rtl8xxxu: fix unused rtl8192cu_fops compiler warning Larry Finger (1): rtlwifi: rtl818x: Move drivers into new realtek directory Maharaja Kennadyrajan (2): ath10k: implement debugfs interface for Transmit Power Control stats ath10k: increase pci wakeup timeout to 30 ms Manikanta Pubbisetty (3): ath10k: add board 2 API support ath10k: select board data based on BMI chip id and board id ath10k: make fw stats prints specific to firmware version Martin Blumenstingl (1): ath9k: Fix NF CCA limits for AR9287 and AR9227 Miaoqing Pan (2): ath9k: rename ini_modes_rxgain_5g_xlna to ini_modes_rxgain_xlna ath9k: fix QCA9561 XLNA rxgain initial Mohammed Shafi Shajakhan (1): ath10k: fix cleanup in ath10k_thermal_unregister Peter Oh (2): ath10k: use Rx decap mode configured when driver registered ath10k: use pre-allocated DMA buffer in Tx Priit Laes (1): rtlwifi: rtl8192cu: Add missing case in rtl92cu_get_hw_reg Rajkumar Manoharan (8): ath10k: optimize ce_lock on post rx
pull-request: wireless-drivers-next 2015-10-29
Hi Dave, here's hopefully my last pull request for 4.4. ssb had a new Kconfig entry and that's why this touches arch/mips/bcm47xx/Kconfig. ssb also did some code shuffling and moved code from b43 to ssb subsystem. Otherwise should be business as usual. While writing this I noticed that Fengwei Yin had a problem with the >From field and that's why you see "yfw" in the stats below. I considered that this isn't a big enough problem to justify rebasing my tree, but let me know if you think otherwise. Please let me know if there are any problems. Kalle The following changes since commit 6d08f617872cc048173d59f1ce4660b030bab5a6: net: hisilicon: updates HNS config and documents (2015-10-27 20:20:24 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git tags/wireless-drivers-next-for-davem-2015-10-29 for you to fetch changes up to 8aaa878de83a0de3833f5b00bc822dbcd403ec36: Merge ath-next from ath.git (2015-10-29 15:34:27 +0200) iwlwifi * bug fix for TDLS * fixes and cleanups in scan * support of several scan plans * improvements in FTM * fixes in FW API * improvements in the failure paths when the bus is dead * other various small things here and there ath10k * add QCA9377 support * fw_stats support for 10.4 firmware ath6kl * report antenna configuration to user space * implement ethtool stats ssb * add Kconfig SSB_HOST_SOC for compiling SoC related code * move functions specific to SoC hosted bus to separated file * pick PCMCIA host code support from b43 driver Alan Liu (1): ath10k: add FW API support to test mode Alexander Bondar (1): iwlwifi: rs: Remove workaround that disables MIMO on P2P Andrei Otcheretianski (1): iwlwifi: mvm: Implement per vif frame registration API Arik Nemtsov (2): iwlwifi: mvm: correctly request DTS-measure for new cards iwlwifi: mvm: disable TDLS ac queues correctly Assaf Krauss (1): iwlwifi: mvm: Allow setting ctrl-chnl-position in FTM responder Avraham Stern (1): iwlwifi: mvm: Add support for two scheduled scan plans Bartosz Markowski (1): ath10k: add QCA9377 chipset support Ben Greear (5): ath6kl: report antenna configuration ath6kl: add error message to explain lack of HT ath6kl: fix firmware version assignment ath6kl: break stats gathering code into separate method ath6kl: implement ethtool stats Bob Copeland (1): wcn36xx: introduce per-channel ring buffer locks Eliad Peller (2): iwlwifi: avoid read/write operations if the bus is dead iwlwifi: mvm: take scan ref only on success Emmanuel Grumbach (2): Merge remote-tracking branch 'mac80211-next/master' into next iwlwifi: pcie: fix (again) prepare card flow Hamad Kadmany (1): wil6210: Fix TSO overflow handling Johannes Berg (4): iwlwifi: mvm: use wowlan RX/TX timeouts in D0i3 iwlwifi: mvm: use short timeouts in P2P low latency if supported iwlwifi: mvm: clean up some whitespace in scan code iwlwifi: mvm: remove pointless scan plan checks John Linville (1): orinoco_usb: return error in ezusb_probe when alloc_orinocodev fails Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2015-10-25' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Luca Coelho (1): iwlwifi: mvm: let any command flag be passed to iwl_mvm_flushtx_path() Maharaja (1): ath10k: enable adaptive CCA Manikanta Pubbisetty (1): ath10k: add fw_stats support to 10.4 firmware Marty Faltesek (1): mwifiex: toggle carrier state in start_ap/stop_ap. Matti Gottlieb (1): iwlwifi: mvm: Dump FW's virtual image in the case of a NIC error Moshe Harel (1): iwlwifi: nvm: free old section data when reading nvm file Ondrej Zary (2): airo: Track APList_rid in struct airo_info airo: fix scan after SIOCSIWAP (airo_set_wap) Rafał Miłecki (3): ssb: pick PCMCIA host code support from b43 driver ssb: move functions specific to SoC hosted bus to separated file ssb: add Kconfig entry for compiling SoC related code Rajkumar Manoharan (8): ath10k: use local memory instead of shadow descriptor in ce_send ath10k: remove send completion validation in diag read/write ath10k: cleanup copy engine send completion ath10k: remove shadow copy of CE descriptors for source ring ath10k: remove supported chain mask ath10k: fill HT/VHT MCS rateset only for configured chainmask ath10k: move static HT/VHT capability setup functions ath10k: reload HT/VHT capabilities on antenna change Vladimir Kondratiev (3): wil6210: ignore selected WMI events wil6210: fix device ready detection wil6210: handle failure in Tx vring config Zefir Kurtisi (1):
Re: mwifiex: fix a comment typo
> Just fix a typo in the code comment. > > Signed-off-by: Geliang Tang <geliangt...@163.com> > Acked-by: Amitkumar Karwar <akar...@marvell.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers 2015-10-17
Hi Dave, few small fixes I would like to get to 4.3 still. Please let me know if there are any problems. Kalle The following changes since commit 76d164f582150fd0259ec0fcbc485470bcd8033e: ath10k: fix DMA related firmware crashes on multiple devices (2015-09-26 20:48:25 +0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-10-17 for you to fetch changes up to de28a05ee28e36fa1fc68fcfc7c6cc1c6f7c270c: Merge tag 'iwlwifi-for-kalle-2015-10-05' of git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2015-10-07 11:12:01 +0300) iwlwifi: * mvm: flush fw_dump_wk when mvm fails to start * mvm: init card correctly on ctkill exit check * pci: add a few more PCI subvendor IDs for the 7265 series * fix firmware filename for 3160 * mvm: clear csa countdown when AP is stopped * mvm: fix D3 firmware PN programming * dvm: fix D3 firmware PN programming * mvm: fix D3 CCMP TX PN assignment rtlwifi: * rtl8821ae: Fix system lockups on boot Andrei Otcheretianski (1): iwlwifi: mvm: flush fw_dump_wk when mvm fails to start Arik Nemtsov (1): iwlwifi: mvm: init card correctly on ctkill exit check Avraham Stern (1): iwlwifi: mvm: clear csa countdown when AP is stopped Johannes Berg (4): iwlwifi: mvm: fix D3 CCMP TX PN assignment iwlwifi: dvm: fix D3 firmware PN programming iwlwifi: mvm: fix D3 firmware PN programming iwlwifi: fix firmware filename for 3160 Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-10-05' of git://git.kernel.org/.../iwlwifi/iwlwifi-fixes Larry Finger (1): rtlwifi: rtl8821ae: Fix system lockups on boot Luca Coelho (1): iwlwifi: pci: add a few more PCI subvendor IDs for the 7265 series drivers/net/wireless/iwlwifi/dvm/lib.c |2 +- drivers/net/wireless/iwlwifi/iwl-7000.c |2 +- drivers/net/wireless/iwlwifi/mvm/d3.c | 27 +++ drivers/net/wireless/iwlwifi/mvm/fw.c |4 ++-- drivers/net/wireless/iwlwifi/mvm/mac80211.c |1 + drivers/net/wireless/iwlwifi/mvm/mvm.h |5 + drivers/net/wireless/iwlwifi/mvm/ops.c |1 + drivers/net/wireless/iwlwifi/pcie/drv.c |5 + drivers/net/wireless/rtlwifi/pci.h |2 ++ drivers/net/wireless/rtlwifi/rtl8821ae/hw.c | 17 + drivers/net/wireless/rtlwifi/rtl8821ae/sw.c |5 + drivers/net/wireless/rtlwifi/wifi.h |3 +++ 12 files changed, 54 insertions(+), 20 deletions(-) -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] ath6kl: drop unlikely behind WARN_ON()
Geliang Tang <geliangt...@163.com> writes: > WARN_ON() already contain an unlikely compiler flag. Drop it. > > Signed-off-by: Geliang Tang <geliangt...@163.com> Applied, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ath6kl: remove redundant null pointer check on send_pkt
Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > The check for send_pkt being NULL is redundant before the call > to htc_reclaim_txctrl_buf, therefore it should be removed. This was > detected by static analysis by cppcheck. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Applied, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers-next 2015-10-09
-power functions. brcmfmac: Only assign primary netdev to if2bss array. brcmfmac: Inform p2p module about p2pon through API brcmfmac: Fix bug in flowring management. brcmfmac: Make p2pon module param always available. brcmfmac: Workaround in change vif for wpa_supplicant support. brcmfmac: Deleting of p2p device is leaking memory. brcmfmac: Only handle p2p_stop_device if vif is valid brcmfmac: Fix p2p bug for older firmwares. brcmfmac: Add module parameter to disable features. brcmfmac: Fix race condition bug when deleting p2p interface. brcmfmac: Add support for the BCM4365 and BCM4366 PCIE devices. brcmfmac: Fix TDLS setup by properly handling p2p noif. brcmfmac: Accept events when TDLS is used in combination with p2p. Hauke Mehrtens (2): brcmfmac: include linux/atomic.h bcma: add support for population subnodes also when build as module Hiroaki KAWAI (1): carl9170: fix bad rssi reading Ilan Peer (1): iwlwifi: mvm: Correctly update MAC context on add/del station Jan Kaisrlik (1): ath9k: Add support for OCB mode Janusz Dziedzic (1): ath10k: fix MSI-X registering for qca99x0 Joe Perches (1): mwifiex: Make mwifiex_dbg a function, reduce object size Johannes Berg (19): iwlwifi: mvm: don't NUL-terminate low-latency debugfs file iwlwifi: mvm: make sure AP is operating for ToF iwlwifi: mvm: remove useless debug message from RX iwlwifi: mvm: remove pointless cfg_phy_cnt length check iwlwifi: mvm: remove some unused defines from RX API iwlwifi: mvm: move RX API into its own file iwlwifi: mvm: correct skip-over-DTIM implementation MAINTAINERS: iwlwifi: update contact email iwlwifi: enable tracing by default iwlwifi: mvm: remove PHY RX from handlers iwlwifi: op-mode API: add rx_rss method iwlwifi: transport: track number of allocated queues iwlwifi: mvm: stop using DEVICE_POWER_FLAGS_CAM_MSK iwlwifi: remove IWL3165_UCODE_API_OK and _MIN iwlwifi: mvm: minor rx code cleanup iwlwifi: mvm: fix signedness warnings in ToF debugfs iwlwifi: mvm: make threshold temperatures unsigned iwlwifi: size firmware flags memory correctly iwlwifi: mvm: add minimal multi-RXQ infrastructure Kalle Valo (4): ath10k: add ATH10K_FW_FEATURE_RAW_MODE_SUPPORT to ath10k_core_fw_feature_str[] Merge tag 'iwlwifi-next-for-kalle-2015-09-21' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Merge tag 'iwlwifi-next-for-kalle-2015-10-05' of git://git.kernel.org/.../iwlwifi/iwlwifi-next Liad Kaufman (4): iwlwifi: mvm: remove SCD_QUEUE_CONFIG TLV flag iwlwifi: mvm: fix default disabled aggs in sta iwlwifi: mvm: support using multiple ACs on single HW queue iwlwifi: mvm: support enabling a queue with a given ssn Luciano Coelho (2): iwlwifi: mvm: remove netdetect debugfs entry iwlwifi: mvm: make sure d0i3 exit work runs before suspending Manikanta Pubbisetty (1): ath10k: print invalid mcs reported in rx descriptor Miaoqing Pan (1): ath9k: enable hw manual peak calibration for QCA9561 Michal Kazior (4): ath10k: fix mu-mimo rx status reporting ath10k: move hw_scan worker queuing ath10k: split switch_vif_chanctx guts ath10k: handle IEEE80211_CHANCTX_CHANGE_WIDTH properly Moshe Harel (2): iwlwifi: nvm: force 1x1 antenna in Series 8000 iwlwifi: nvm: add nvm phy_sku section to debugfs Nicolas Iooss (1): iwlwifi: mvm: fix tof.h header guard Oleksij Rempel (1): ath9k_htc: introduce support for different fw versions Ondrej Zary (2): airo: fix IW_AUTH_ALG_OPEN_SYSTEM airo: Implement netif_carrier_on/off Peter Oh (2): ath: fix incorrect PPB on JAPAN chirp radar ath: use PRI value given by spec for fixed PRI Rafał Miłecki (4): ssb: unexport ssb_bus_pcibus_register ssb: make ssb_sdio_switch_core static ssb: drop declaration of non existing ssb_sdio_hardware_setup ssb: make ssb_pcmcia_switch_core static Rajkumar Manoharan (1): ath10k: fix ldpc param for fixed rate Sara Sharon (1): iwlwifi: mvm: fix statistics variables type Vasanthakumar Thiagarajan (1): ath10k: fix DMA alloc failure for target requested memory chunks Vivek Natarajan (1): ath10k: drop probe responses when too many are queued Xinming Hu (4): mwifiex: fix typo in del_virtual_intf() function mwifiex: minor corrections in multiport aggregation code mwifiex: fix driver init failure under memory pressure mwifiex: NULL check for cfg80211_inform_bss() Zhaoyang Liu (8): mwifiex: update amsdu tx packet time stamp mwifiex: correct paused tx data packet counter mwifiex: fix tx data_sent issue for usb interface mwifiex: move usb specific data_sent update to usb.c mwifiex: add usb multi
Re: ipw2100: fix timeout bug - always evaluated to 0
commit 2c86c275015c (Add ipw2100 wireless driver.) introduced HW_PHY_OFF_LOOP_DELAY (HZ / 5000) which always evaluated to 0. Clarified by Stanislav Yakovlev stas.yakov...@gmail.com that it should be 50 milliseconds thus fixed up to msecs_to_jiffies(50). Signed-off-by: Nicholas Mc Guire hof...@osadl.org Acked-by: Stanislav Yakovlev stas.yakov...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers-next 2015-08-26
Hi Dave, here's one more smaller pull request I would like to still get to 4.3. Nothing really special expect the new firmware API 17 support for iwlwifi and qca6164 support for ath10k which would be good to have in 4.3. Please let me know if you have any problems. Kalle The following changes since commit 4a89ba04ecc6377696e4e26c1abc1cb5764decb9: 3c59x: Add BQL support for 3c59x ethernet driver. (2015-08-24 12:20:58 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git tags/wireless-drivers-next-for-davem-2015-08-26 for you to fetch changes up to 0ba3ac03c1f38be17102d1c76c42a7c66a3e9ff2: Merge ath-next from ath.git (2015-08-26 12:40:23 +0300) Major changes: iwlwifi: * new Tx power firmware API * bump max firmware API to 17 * fix bug in debug prints * static checker fix * fix unused defines * fix command list on newest firmware brcmfmac: * support NVRAM loading for bcm47xx platform * new debugfs entry for msgbuf protocol layer used with PCIe devices ath10k: * add spectral scan support for qca99x0 * add qca6164 support Adrien Schildknecht (1): rtlwifi: rtl8192cu: Add new device ID Arend van Spriel (3): brcmfmac: correct interface combination info brcmfmac: make use of cfg80211_check_combinations() brcmfmac: bump highest event number for 4339 firmware Ayala Beker (1): iwlwifi: mvm: split debug message to avoid exceeding 110 characters Christian Engelmayer (1): rsi: Fix possible leak when loading firmware Dan Carpenter (1): iwlwifi: mvm: catch underflow error earlier Emmanuel Grumbach (1): iwlwifi: mvm: bump firmware API to 17 Franky Lin (2): brcmfmac: add debugfs entry for msgbuf statistics brcmfmac: block the correct flowring when backup queue overflow Hante Meuleman (1): brcmfmac: Add support for host platform NVRAM loading. Johannes Berg (2): iwlwifi: correctly size command string arrays iwlwifi: mvm: support new TX power command Kalle Valo (2): Merge tag 'iwlwifi-next-for-kalle-2015-08-23' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Merge ath-next from ath.git Michal Kazior (6): ath10k: wake up offchannel queue properly ath10k: wake up queue upon vif creation ath10k: split ap/ibss wep key install process ath10k: add missing mutex unlock on failpath ath10k: fix dma_mapping_error() handling ath10k: add qca6164 support Nicholas Mc Guire (1): wil6210: match wait_for_completion_timeout return type Oleksij Rempel (1): ath9k_htc: do ani shortcalibratio if we got -ETIMEDOUT Rafał Miłecki (1): brcmfmac: check all combinations when setting wiphy's addresses Raja Mani (6): ath10k: refactor phyerr event handlers ath10k: handle 10.4 firmware phyerr event ath10k: ensure pktlog disable cmd reaches fw before pdev suspend ath10k: free collected fw stats memory if .pull_fw_stats fails ath10k: add spectral scan support for 10.4 fw ath10k: fix compilation warnings in wmi phyerr pull function Sara Sharon (1): iwlwifi: mvm: update wakeup reason enum Vasanthakumar Thiagarajan (3): ath10k: fix invalid survey reporting for QCA99X0 ath10k: add cycle/rx_clear counters frequency to hw_params ath10k: fill in wmi 10.4 command handlers for addba/delba debug commands Wu Fengguang (1): rtlwifi: rtl8192ee: fix semicolon.cocci warnings drivers/net/wireless/ath/ath10k/core.c | 18 +- drivers/net/wireless/ath/ath10k/core.h |3 + drivers/net/wireless/ath/ath10k/debug.c|3 +- drivers/net/wireless/ath/ath10k/htc.c |4 +- drivers/net/wireless/ath/ath10k/htt_tx.c |8 +- drivers/net/wireless/ath/ath10k/hw.c |4 +- drivers/net/wireless/ath/ath10k/hw.h |3 +- drivers/net/wireless/ath/ath10k/mac.c | 54 +++-- drivers/net/wireless/ath/ath10k/pci.c | 21 +- drivers/net/wireless/ath/ath10k/spectral.c | 18 +- drivers/net/wireless/ath/ath10k/spectral.h |4 +- drivers/net/wireless/ath/ath10k/wmi-ops.h | 22 ++- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 17 +- drivers/net/wireless/ath/ath10k/wmi.c | 198 +++ drivers/net/wireless/ath/ath10k/wmi.h | 64 -- drivers/net/wireless/ath/ath9k/htc_drv_main.c | 13 +- drivers/net/wireless/ath/wil6210/wmi.c |2 +- drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 206 drivers/net/wireless/brcm80211/brcmfmac/firmware.c | 39 ++-- drivers/net/wireless/brcm80211/brcmfmac/flowring.c | 10 +- drivers/net/wireless/brcm80211/brcmfmac/fweh.h | 10 +- drivers/net/wireless
Re: rtlwifi: rtl8192ee: fix semicolon.cocci warnings
drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:856:2-3: Unneeded semicolon drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:492:3-4: Unneeded semicolon drivers/net/wireless/rtlwifi/rtl8192ee/phy.c:452:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Larry Finger larry.fin...@lwfinger.net Signed-off-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Larry Finger larry.fin...@lwfinger.net Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v2] rtlwifi: rtl8192cu: Add new device ID
The v2 of NetGear WNA1000M uses a different idProduct: USB ID 0846:9043 Signed-off-by: Adrien Schildknecht adrien+...@schischi.me Cc: Stable sta...@vger.kernel.org Acked-by: Larry Finger larry.fin...@lwfinger.net Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: rsi: Fix possible leak when loading firmware
Commit 5d5cd85ff441 (rsi: Fix failure to load firmware after memory leak fix and fix the leak) also added a check on the allocation of DMA-accessible memory that may directly return. In that case the already allocated firmware data is leaked. Make sure the data is always freed correctly. Detected by Coverity CID 1316519. Fixes: 5d5cd85ff441 (rsi: Fix failure to load firmware after memory leak fix and fix the leak) Signed-off-by: Christian Engelmayer cenge...@gmx.at Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [net] orinoco_usb:Fix error handling in ezusb_probe()
RUC_Soft_Sec <zy900...@163.com> writes:
> Current code assigns 0 to variable 'retval', which makes ezusb_probe() to
> return success even if alloc_orinocodev() fails.
>
> The related code snippets in mantis_dma_init() is as following.
>
> 1573 static int ezusb_probe(struct usb_interface *interface,
> 1574const struct usb_device_id *id)
> 1575 {
>
>
>
> 1583 int retval = 0;
> 1584 int i;
> 1585
> 1586 priv = alloc_orinocodev(sizeof(*upriv), >dev,
> 1587 ezusb_hard_reset, NULL);
> 1588 if (!priv) {
> 1589 err("Couldn't allocate orinocodev");
> 1590 goto exit;
> 1591 }
> ...
>
> 1729 exit:
> 1730 if (fw_entry) {
> 1731 firmware.code = NULL;
> 1732 firmware.size = 0;
> 1733 release_firmware(fw_entry);
> 1734 }
> 1735 usb_set_intfdata(interface, upriv);
> 1736 return retval;
> 1737 }
>
> Fix it by checking the return value from alloc_orinocodev() and assigns
> '-ENOMEM' to variable 'retval' in the case of error.
>
> Signed-off-by: Zhang Yan <zy900...@163.com>---
> orinoco_usb.c |1 +
> 1 file changed, 1 insertion(+)
> diff --git a/orinoco_usb.c b/orinoco_usb.c
The patch looks corrupted. And the from header doesn't contain a proper
name.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: mwifiex: Make mwifiex_dbg a function, reduce object size
> The mwifiex_dbg macro has two tests that could be consolidated > into a function reducing overall object size ~10KB (~4%). > > So convert the macro into a function. > > $ size drivers/net/wireless/mwifiex/built-in.o* (x86-64 defconfig) >text data bss dec hex filename > 233102 86284809 246539 3c30b > drivers/net/wireless/mwifiex/built-in.o.new > 243949 86284809 257386 3ed6a > drivers/net/wireless/mwifiex/built-in.o.old > > Signed-off-by: Joe Perches <j...@perches.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v3,1/2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM
> IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as > wpa_supplicant uses it for both no encryption and WEP open system. > Cache the last mode set (only of these two) and use it here. > > This allows wpa_supplicant to work with unencrypted APs. > > Signed-off-by: Ondrej Zary <li...@rainbow-software.org> Thanks, 2 patches applied to wireless-drivers-next.git: 4a0f2ea79797 airo: fix IW_AUTH_ALG_OPEN_SYSTEM 2b8fa9e870b7 airo: Implement netif_carrier_on/off Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers 2015-10-01
Hi Dave, few very small fixes I would like to get to 4.3, nothing really special. Please let me know if you have any problems. Kalle The following changes since commit bdb06cbf77cb01911694cc9076ffa8196b7b9b61: net: Fix panic in icmp_route_lookup (2015-09-25 21:44:02 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-10-01 for you to fetch changes up to 76d164f582150fd0259ec0fcbc485470bcd8033e: ath10k: fix DMA related firmware crashes on multiple devices (2015-09-26 20:48:25 +0300) ath9k: * declare required extra tx headroom ath10k: * fix DMA related firmware crashes on multiple devices rt2800usb: * add usb ID 1b75:3070 for Airlive WT-2000USB b43: * probe bcma core (device) rev 0x15 Felix Fietkau (2): ath9k: declare required extra tx headroom ath10k: fix DMA related firmware crashes on multiple devices Rafał Miłecki (1): b43: probe bcma core (device) rev 0x15 Stanislaw Gruszka (1): rt2800usb: add usb ID 1b75:3070 for Airlive WT-2000USB drivers/net/wireless/ath/ath10k/hw.h|4 ++-- drivers/net/wireless/ath/ath9k/init.c |1 + drivers/net/wireless/b43/main.c |1 + drivers/net/wireless/rt2x00/rt2800usb.c |1 + 4 files changed, 5 insertions(+), 2 deletions(-) -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2 v2] airo: fix IW_AUTH_ALG_OPEN_SYSTEM
Ondrej Zary <li...@rainbow-software.org> writes: > IW_AUTH_ALG_OPEN_SYSTEM is ambiguous in set_auth for WEP as > wpa_supplicant uses it for both no encryption and WEP open system. > Cache the last mode set (only of these two) and use it here. > > This allows wpa_supplicant to work with unencrypted APs. > > Signed-off-by: Ondrej Zary <li...@rainbow-software.org> > --- > drivers/net/wireless/airo.c | 33 - > 1 file changed, 24 insertions(+), 9 deletions(-) You should CC linux-wireless mailing list, otherwise patchwork won't see it and I will miss your patch: https://patchwork.kernel.org/project/linux-wireless/list/ -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [net] Fix error handling in ezusb_probe()
RUC_Soft_Sec <zy900...@163.com> writes: > Current code assigns 0 to variable 'retval', which makes ezusb_probe() > to return success even if alloc_orinocodev() fails. > > Fix it by checking the return value from alloc_orinocodev() and > assigns '-ENOMEM' to variable 'retval' in the case of error. > > > Signed-off-by: RUC_Soft_Sec <zy900...@163.com> Please use your real name both in From header and in Signed-off-by line. Also use "orinoco_usb:" as the prefix in the commit title. > --- > orinoco_usb.c |1 + > 1 file changed, 1 insertion(+) This is wrong, the patch should contain the full source path. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] cfg80211: drop unlikely behind WARN_ON()
Johannes Berg <johan...@sipsolutions.net> writes: > The subject is entirely wrong - this is not a cfg80211 patch. Yes, please use prefix "ath6kl: ". -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fixing full name in patchwork
Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: > On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote: >> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: >> >> > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: >> >> Hi Sudip, >> >> >> >> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: >> >> > >> > >> > I have also noticed the patch. Anyway, I have created a profile in >> > patchwork and given full name. Hopefully that should solve the problem. >> >> At least now your name in the patchwork link above looks correct: > > Yes, but I am still surprised why this happened for only this patch. I don't know what other patches you are referring to, but I download the patches I apply directly from patchwork. If other maintainers take the patch from a mail folder this issue would not happen. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Fixing full name in patchwork
Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote: >> Hi Sudip, >> >> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: >> >> > We were dereferencing cmd first and checking for NULL later. Lets first >> > check for NULL. >> > >> > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> >> >> I noticed that your name in git log is not your full name: >> >> commit 0a38c8e1b592c16d959da456f425053e323a5153 >> Author: sudip <sudipm.mukher...@gmail.com> >> Date: Tue Nov 24 13:51:38 2015 +0530 >> >> This is because for some reason in patchwork your fullname is just >> "sudip": >> >> https://patchwork.kernel.org/patch/7688171/ >> >> Could you please fix your name in patchwork so that in the future we can >> use your correct full name? The problem is that I don't know exactly how >> to do this but it should be possible because I remember someone else >> having a similar problem and he was able to fix it. > > I have also noticed the patch. Anyway, I have created a profile in > patchwork and given full name. Hopefully that should solve the problem. At least now your name in the patchwork link above looks correct: Sudip Mukherjee - Nov. 24, 2015, 8:21 a.m. Thanks for fixing this. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] rtlwifi: fix gigantic memleak in rtl_usb
Peter Wu <pe...@lekensteyn.nl> writes: > Originally I had the Cc: stable line added, but the SubmittingPatches > document seems to discourage that for networking. Added it again. Yeah, stable wireless patches are handled differently from rest of the networking subsystem. It would be great if somebody could update the documentation. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers-next 2015-12-07
ig default iwlwifi: trans: make various conversion macros inlines iwlwifi: dvm: remove stray debug code iwlwifi: pcie: remove ICT allocation message iwlwifi: mvm: use build-time assertion for fw trigger ID iwlwifi: clean up transport debugfs handling iwlwifi: pcie: remove pointer from debug message iwlwifi: mvm: use firmware station lookup, combine code iwlwifi: print index in api/capa flags parsing message iwlwifi: mvm: add 9000-series RX API Julia Lawall (1): brcmfmac: constify brcmf_bus_ops structures Kalle Valo (8): ath10k: fix otp board id error message ath10k: reorganise hardware and firmware info messages ath10k: always show bmi chip ids and subdevice ids ath10k: split driver info messages during device initialisation ath10k: print crc32 checksums for firmware and board files ath10k: implement fw_checksums debugfs file Merge ath-next from ath.git Merge tag 'iwlwifi-next-for-kalle-2015-12-01' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Luca Coelho (6): iwlwifi: mvm: ignore LMAC scan notifications when running UMAC scans iwlwifi: generalize d0i3_entry_timeout module parameter iwlwifi: mvm: remove redundant d0i3 flag from the config struct iwlwifi: mvm: remove stray nd_config element iwlwifi: mvm: flush all used TX queues before suspending iwlwifi: mvm: remove unnecessary check in iwl_mvm_is_d0i3_supported() Manikanta Pubbisetty (1): ath10k: consolidate if statements in ath10k_wmi_event_mgmt_rx Markus Elfring (2): brcm80211: Delete an unnecessary check before the function call "release_firmware" rtlwifi: Delete unnecessary checks before the function call "kfree_skb" Matti Gottlieb (2): iwlwifi: mvm: check FW's response for nvm access write cmd iwlwifi: mvm: ROC: Extend the ROC max delay duration & limit ROC duration Michal Kazior (9): ath10k: merge is_protected with nohwcrypt ath10k: rename function to adhere to naming convention ath10k: remove txmode from skb_cb ath10k: remove is_offchan ath10k: remove freq from skb_cb ath10k: pack up flags in skb_cb ath10k: fix tx header parsing ath10k: replace vdev_id and tid in skb cb ath10k: store msdu_id instead of txbuf pointers Mohammed Shafi Shajakhan (2): ath10k: Enable AP + STA interface combination support for 10.x ath10k: Fix write permission on few debugfs files Moshe Harel (2): iwlwifi: mvm: add bt settings to debugfs iwlwifi: mvm: add bt rrc and ttc to debugfs Nicholas Krause (1): iwlwifi: mvm: fix incorrect fallthrough in iwl_mvm_check_running_scans() Oren Givon (2): iwlwifi: Add PCI IDs for the new 3168 series iwlwifi: Add PCI IDs for the new series 8165 Peter Oh (4): ath10k: fix board data fetch error message ath10k: update WMI 10.x service map ath10k: introduce new subtypes for proxy STA and Mesh ath10k: apply Mesh subtype when Mesh interface created. Tamizh chelvam (3): ath10k: add abstraction layer for peer flags ath10k: set peer MFP flag in peer assoc command ath10k: add thermal throttling support for 10.4 firmware Vasanthakumar Thiagarajan (6): ath10k: add new service defines for 10.4 ath10k: add new WMI cmd/event defines for 10.4 ath10k: add new pdev params defines to 10.4 ath10k: fix peer assoc complete WMI command for 10.4 ath10k: rename the helper which is used for off-channel tx ath10k: fix peerid configuration in htt tx desc for htt version < 3.4 Vivek Natarajan (1): ath10k: add support for pktlog in QCA99X0 Vladimir Kondratiev (1): wil6210: hold wil->mutex while managing vrings Yanbo Li (3): ath10k: debugfs file to enable Bluetooth coexistence feature ath10k: fix the wrong RX rate idx report at 11G mode ath10k: adjust the RX packet pad offset at QCA99X0 4addr mode sudip (1): libertas: check for NULL before use drivers/net/wireless/ath/ath10k/Kconfig|1 + drivers/net/wireless/ath/ath10k/core.c | 16 +- drivers/net/wireless/ath/ath10k/core.h | 38 +- drivers/net/wireless/ath/ath10k/debug.c| 197 - drivers/net/wireless/ath/ath10k/debug.h|4 + drivers/net/wireless/ath/ath10k/htt.h | 15 +- drivers/net/wireless/ath/ath10k/htt_rx.c | 33 +- drivers/net/wireless/ath/ath10k/htt_tx.c | 130 ++-- drivers/net/wireless/ath/ath10k/hw.h | 15 + drivers/net/wireless/ath/ath10k/mac.c | 204 ++--- drivers/net/wireless/ath/ath10k/mac.h |3 +- drivers/net/wireless/ath/ath10k/pci.c | 11 + drivers/net/wireless/ath/ath10k/thermal.c |2 +- drivers/net/wireless/ath/ath10k/txrx.c | 15 +- drivers/net/wireless/ath/ath10k/
Fixing full name in patchwork
Hi Sudip, Sudip Mukherjee <sudipm.mukher...@gmail.com> writes: > We were dereferencing cmd first and checking for NULL later. Lets first > check for NULL. > > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> I noticed that your name in git log is not your full name: commit 0a38c8e1b592c16d959da456f425053e323a5153 Author: sudip <sudipm.mukher...@gmail.com> Date: Tue Nov 24 13:51:38 2015 +0530 This is because for some reason in patchwork your fullname is just "sudip": https://patchwork.kernel.org/patch/7688171/ Could you please fix your name in patchwork so that in the future we can use your correct full name? The problem is that I don't know exactly how to do this but it should be possible because I remember someone else having a similar problem and he was able to fix it. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v2] wlcore/wl12xx: spi: fix oops on firmware load
> The maximum chunks used by the function is > (SPI_AGGR_BUFFER_SIZE / WSPI_MAX_CHUNK_SIZE + 1). > The original commands array had space for > (SPI_AGGR_BUFFER_SIZE / WSPI_MAX_CHUNK_SIZE) commands. > When the last chunk is used (len > 4 * WSPI_MAX_CHUNK_SIZE), the last > command is stored outside the bounds of the commands array. > > Oops 5 (page fault) is generated during current wl1271 firmware load > attempt: > > root@debian-armhf:~# ifconfig wlan0 up > [ 294.312399] Unable to handle kernel paging request at virtual address > 00203fc4 > [ 294.320173] pgd = de528000 > [ 294.323028] [00203fc4] *pgd= > [ 294.326916] Internal error: Oops: 5 [#1] SMP ARM > [ 294.331789] Modules linked in: bnep rfcomm bluetooth ipv6 arc4 wl12xx > wlcore mac80211 musb_dsps cfg80211 musb_hdrc usbcore usb_common > wlcore_spi omap_rng rng_core musb_am335x omap_wdt cpufreq_dt thermal_sys > hwmon > [ 294.351838] CPU: 0 PID: 1827 Comm: ifconfig Not tainted > 4.2.0-2-g3e9ad27-dirty #78 > [ 294.360154] Hardware name: Generic AM33XX (Flattened Device Tree) > [ 294.366557] task: dc9d6d40 ti: de55 task.ti: de55 > [ 294.372236] PC is at __spi_validate+0xa8/0x2ac > [ 294.376902] LR is at __spi_sync+0x78/0x210 > [ 294.381200] pc : []lr : []psr: 6013 > [ 294.381200] sp : de551998 ip : de5519d8 fp : 0020 > [ 294.393242] r10: de551c8c r9 : de5519d8 r8 : de3a9000 > [ 294.398730] r7 : de3a9258 r6 : de3a9400 r5 : de551a48 r4 : > 00203fbc > [ 294.405577] r3 : r2 : r1 : r0 : > de3a9000 > [ 294.412420] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM > Segment user > [ 294.419918] Control: 10c5387d Table: 9e528019 DAC: 0015 > [ 294.425954] Process ifconfig (pid: 1827, stack limit = 0xde550218) > [ 294.432437] Stack: (0xde551998 to 0xde552000) > > ... > > [ 294.883613] [] (__spi_validate) from [] > (__spi_sync+0x78/0x210) > [ 294.891670] [] (__spi_sync) from [] > (wl12xx_spi_raw_write+0xfc/0x148 [wlcore_spi]) > [ 294.901661] [] (wl12xx_spi_raw_write [wlcore_spi]) from > [] (wlcore_boot_upload_firmware+0x1ec/0x458 [wlcore]) > [ 294.914038] [] (wlcore_boot_upload_firmware [wlcore]) from > [] (wl12xx_boot+0xc10/0xfac [wl12xx]) > [ 294.925161] [] (wl12xx_boot [wl12xx]) from [] > (wl1271_op_add_interface+0x5b0/0x910 [wlcore]) > [ 294.936364] [] (wl1271_op_add_interface [wlcore]) from > [] (ieee80211_do_open+0x44c/0xf7c [mac80211]) > [ 294.947963] [] (ieee80211_do_open [mac80211]) from > [] (__dev_open+0xa8/0x110) > [ 294.957307] [] (__dev_open) from [] > (__dev_change_flags+0x88/0x148) > [ 294.965713] [] (__dev_change_flags) from [] > (dev_change_flags+0x18/0x48) > [ 294.974576] [] (dev_change_flags) from [] > (devinet_ioctl+0x6b4/0x7d0) > [ 294.983191] [] (devinet_ioctl) from [] > (sock_ioctl+0x1e4/0x2bc) > [ 294.991244] [] (sock_ioctl) from [] > (do_vfs_ioctl+0x420/0x6b0) > [ 294.999208] [] (do_vfs_ioctl) from [] > (SyS_ioctl+0x6c/0x7c) > [ 295.006880] [] (SyS_ioctl) from [] > (ret_fast_syscall+0x0/0x54) > [ 295.014835] Code: e1550004 e2444034 0a7d e5953018 (e5942008) > [ 295.021544] ---[ end trace 66ed188198f4e24e ]--- > > Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il> > Acked-by: Igor Grinberg <grinb...@compulab.co.il> > Cc: sta...@vger.kernel.org Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: prism54: fix compare_const_fl.cocci warnings
> Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: mwifiex: fix semicolon.cocci warnings
> Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: brcm80211: fix compare_const_fl.cocci warnings
> Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu <fengguang...@intel.com> > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iwlegacy: mark il_adjust_beacon_interval as noinline
> With the new optimized do_div() code, some versions of gcc > produce obviously incorrect code that leads to a link error > in iwlegacy/common.o: > > drivers/built-in.o: In function `il_send_rxon_timing': > :(.text+0xa6b4d4): undefined reference to `ilog2_NaN' > :(.text+0xa6b4f0): undefined reference to `__aeabi_uldivmod' > > In a few thousand randconfig builds, I have seen this problem > a couple of times in this file, but never anywhere else in the > kernel, so we can try to work around this in the only file > that shows the behavior, by marking the il_adjust_beacon_interval > function as noinline, which convinces gcc to use the unoptimized > do_div() all the time. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Nicolas Pitre <n...@linaro.org> > Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: brcmfmac: only lock and unlock fws if fws is not null
> From: Colin Ian King <colin.k...@canonical.com> > > There is a null ptr check for fws to set bcmc_credit_check, however, > there a lock and unlock on fws should only performed if fwts is > also not null to also avoid a potential null pointer deference. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> > Acked-by: Arend van Spriel <ar...@broadcom.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v2] rtlwifi: fix memory leak for USB device
> Free skb for received frames with a wrong checksum. This can happen > pretty rapidly, exhausting all memory. > > This fixes a memleak (detected with kmemleak). Originally found while > using monitor mode, but it also appears during managed mode (once the > link is up). > > Cc: sta...@vger.kernel.org > Signed-off-by: Peter Wu <pe...@lekensteyn.nl> > ACKed-by: Larry Finger <larry.fin...@lwfinger.net> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ath9k: fix inconsistent indenting on return statement
Colin King <colin.k...@canonical.com> writes: > From: Colin Ian King <colin.k...@canonical.com> > > minor change, indenting is one tab out. > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Applied to ath.git, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers-next 2016-01-05
into next iwlwifi: mvm: close the SP if we send fewer frames than expected in SP Merge tag 'iwlwifi-for-kalle-2015-12-16' into next iwlwifi: change the Intel Wireless email address iwlwifi: pcie: allow to pretend to have Tx CSUM for debug iwlwifi: mvm: prepare the code towards TSO implementation iwlwifi: pcie: re-organize code towards TSO iwlwifi: clear ieee80211_tx_info->driver_data in the op_mode iwlwifi: pcie: build an A-MSDU using TSO core iwlwifi: 9000: increase the number of queues iwlwifi: mvm: small update in the firmware API iwlwifi: mvm: dump more registers upon error iwlwifi: remove unused parameter from grab_nic_access iwlwifi: fix printf specifier Eyal Shapira (1): iwlwifi: mvm: rs: fix a potential out of bounds access Felix Fietkau (1): ath10k: do not use coherent memory for allocated device memory chunks Golan Ben-Ami (2): iwlwifi: expose fw usniffer mode to more utilities iwlwifi: mvm: support description for user triggered fw dbg collection Gregory Greenman (1): iwlwifi: mvm: add an option to start rs from HT/VHT rates Guy Mishol (1): wlcore: split wl12xx/wl18xx sg parameters Hante Meuleman (9): brcmfmac: Simplify scan timing configuration brcmfmac: Use local storage for ssid iovar brcmfmac: Remove some redundant cfg80211 data brcmfmac: Cleanup pmksa cache handling code brcmfmac: Make TDLS a detectable feature brcmfmac: Add support for PCIE 4350 revision 5 device brcmfmac: Fix IBSS setup brcmfmac: Change error print in debug print brcmfmac: Move scheduled scan related interface layer structs Janusz Dziedzic (11): ath9k: add debug messages to aggr/chanctx funcs ath9k: print real timer value ath9k: queue null frames in case of MCC ath9k: P2P_CLIENT, send frames after 1ms AP/GO will aprear ath9k: use u32 when calculate tsf ath9k: setup correct skb priority for nullfunc ath9k: MCC enable Opportunistic Power Save ath9k: P2P_CLIENT, get/set NOA correctly ath9k: MCC, add NOA also in case of an AP ath9k: MCC, print time elapsed between events ath9k: remove ath9k_mod_tsf64_tu Johannes Berg (4): iwlwifi: mvm: advertise NETIF_F_SG iwlwifi: dvm: advertise NETIF_F_SG iwlwifi: mvm: change iwl_mvm_get_key_sta_id() to return the station iwlwifi: mvm: add 9000 series RX processing Julia Lawall (4): brcm80211: fix compare_const_fl.cocci warnings mwifiex: fix semicolon.cocci warnings prism54: fix compare_const_fl.cocci warnings iwlwifi: dvm: fix compare_const_fl.cocci warnings Kalle Valo (2): Merge ath-next from ath.git Merge tag 'iwlwifi-next-for-kalle-2015-12-21' of https://git.kernel.org/.../iwlwifi/iwlwifi-next Kosuke Tatsukawa (1): brcmfmac: fix waitqueue_active without memory barrier in brcmfmac driver Larry Finger (9): rtlwifi: rtl8723be: Fix module parameter initialization rtlwifi: rtl8723ae: Fix initialization of module parameters rtlwifi: rtl8821ae: Fix errors in parameter initialization rtlwifi: rtl8188ee: Fix module parameter initialization rtlwifi: rtl8192de: Fix incorrect module parameter descriptions rtlwifi: rtl8192se: Fix module parameter initialization rtlwifi: rtl8192ce: Fix handling of module parameters rtlwifi: rtl8192cu: Add missing parameter setup rtlwifi: rtl_pci: Fix kernel panic Liad Kaufman (1): iwlwifi: mvm: set default new STA as non-aggregated Luca Coelho (3): iwlwifi: mvm: don't keep an mvm ref when the interface is down iwlwifi: replace d0i3_mode and wowlan_d0i3 with more generic variables iwlwifi: mvm: refactor the way fw_key_table is handled Martin Blumenstingl (1): ath9k: Simplify and fix eeprom endianness swapping Maya Erez (1): wil6210: prevent external wmi commands during suspend flow Miaoqing Pan (2): ath9k: fix AR_RX_FILTER for ar9462/ar9565 when rx stopped ath9k: feeding entropy in kernel from ADC capture Mohammed Shafi Shajakhan (1): ath10k: remove unnecessary amsdu/ampdu assignment in debugfs Nicholas Mc Guire (2): rsi: consolidate kmalloc/memset 0 calls to kzalloc rsi: bool tests do not need comparison Oren Givon (1): iwlwifi: Update PCI IDs for 8000 and 9000 series Peter Oh (1): ath10k: allow Mesh Point to install peer security key Peter Wu (1): rtlwifi: fix memory leak for USB device Rafał Miłecki (2): ssb: pick SoC invariants code from MIPS BCM47xx arch bcma: use module_init for the main part of bus initialization Sara Sharon (3): iwlwifi: mvm: change protocol offload flows iwlwifi: mvm: enable L3 filtering iwlwifi: mvm: infrastructure for frame-release message Shahar Patury (1): wlcore/wl18xx: fw logger over sdio Sharon Dvir (1): iwlwifi: update host command messages
Re: [PATCH 5/9] ipw2x00: sdhci-pci: use to_pci_dev()
Geliang Tang <geliangt...@163.com> writes: > Use to_pci_dev() instead of open-coding it. > > Signed-off-by: Geliang Tang <geliangt...@163.com> The title is wrong, it should be just "ipw2x00: use to_pci_dev()". And please state clearly to what tree you are planning to submit these. I only saw this patch 5, not rest of the patches, so I have no clue what's going to happen with this patchset. Please resend. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)
> Fix the below Oops when trying to modprobe wlcore_spi.
> The oops occurs because the wl1271_power_{off,on}()
> function doesn't check the power() function pointer.
>
> [ 23.401447] Unable to handle kernel NULL pointer dereference at
> virtual address
> [ 23.409954] pgd = c0004000
> [ 23.412922] [] *pgd=
> [ 23.416693] Internal error: Oops: 8007 [#1] SMP ARM
> [ 23.422168] Modules linked in: wl12xx wlcore mac80211 cfg80211
> musb_dsps musb_hdrc usbcore usb_common snd_soc_simple_card evdev joydev
> omap_rng wlcore_spi snd_soc_tlv320aic23_i2c rng_core snd_soc_tlv320aic23
> c_can_platform c_can can_dev snd_soc_davinci_mcasp snd_soc_edma
> snd_soc_omap omap_wdt musb_am335x cpufreq_dt thermal_sys hwmon
> [ 23.453253] CPU: 0 PID: 36 Comm: kworker/0:2 Not tainted
> 4.2.0-2-g951efee-dirty #233
> [ 23.461720] Hardware name: Generic AM33XX (Flattened Device Tree)
> [ 23.468123] Workqueue: events request_firmware_work_func
> [ 23.473690] task: de32efc0 ti: de4ee000 task.ti: de4ee000
> [ 23.479341] PC is at 0x0
> [ 23.482112] LR is at wl12xx_set_power_on+0x28/0x124 [wlcore]
> [ 23.488074] pc : [<>]lr : []psr: 6013
> [ 23.488074] sp : de4efe50 ip : 0002 fp :
> [ 23.500162] r10: de7cdd00 r9 : dc848800 r8 : bf27af00
> [ 23.505663] r7 : bf27a1a8 r6 : dcbd8a80 r5 : dce0e2e0 r4 :
> dce0d2e0
> [ 23.512536] r3 : r2 : r1 : 0001 r0 :
> dc848810
> [ 23.519412] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM
> Segment kernel
> [ 23.527109] Control: 10c5387d Table: 9cb78019 DAC: 0015
> [ 23.533160] Process kworker/0:2 (pid: 36, stack limit = 0xde4ee218)
> [ 23.539760] Stack: (0xde4efe50 to 0xde4f)
>
> [...]
>
> [ 23.665030] [] (wl12xx_set_power_on [wlcore]) from
> [] (wlcore_nvs_cb+0x118/0xa4c [wlcore])
> [ 23.675604] [] (wlcore_nvs_cb [wlcore]) from []
> (request_firmware_work_func+0x30/0x58)
> [ 23.685784] [] (request_firmware_work_func) from
> [] (process_one_work+0x1b4/0x4b4)
> [ 23.695591] [] (process_one_work) from []
> (worker_thread+0x3c/0x4a4)
> [ 23.704124] [] (worker_thread) from []
> (kthread+0xd4/0xf0)
> [ 23.711747] [] (kthread) from []
> (ret_from_fork+0x14/0x3c)
> [ 23.719357] Code: bad PC value
> [ 23.722760] ---[ end trace 981be8510db9b3a9 ]---
>
> Prevent oops by validationg power() pointer value before
> calling the function.
>
> Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il>
> Cc: sta...@vger.kernel.org
> Acked-by: Igor Grinberg <grinb...@compulab.co.il>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: prism54: fix checks for dma mapping errors
> prism54 checks for dma mapping errors by comparison returned address > with zero, while pci_dma_mapping_error() should be used. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v2] mwifiex: correctly handling kzalloc
> Since kzalloc can be failed in memory pressure, > it needs to be handled, otherwise NULL dereference could be happened > > Signed-off-by: Insu Yun <wuni...@gmail.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: iwlegacy: 4965-mac: constify il_sensitivity_ranges structure
> The il_sensitivity_ranges is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > Acked-by: Stanislaw Gruszka <sgrus...@redhat.com> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate
Andrzej Hajda <a.ha...@samsung.com> writes: > The function can return negative values in case of error. > Its result should be then tested for such case. > > The problem has been detected using proposed semantic patch > scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. > > [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> Applied to ath.git, thanks. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
pull-request: wireless-drivers 2015-12-28
Hi Dave, here's one more pull request, a bit late due to holidays but I hope this still makes it to 4.4. Just two small fixes to iwlwifi, nothing else. Kalle The following changes since commit eeec5d0ef7ee54a75e09e861c3cc44177b8752c7: rtlwifi: rtl8821ae: Fix lockups on boot (2015-11-17 15:58:53 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git tags/wireless-drivers-for-davem-2015-12-28 for you to fetch changes up to 01d85b9b2b6bec2b0773cf2afc58699dc4b052f8: Merge tag 'iwlwifi-for-kalle-2015-12-16' of https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes (2015-12-18 14:57:02 +0200) iwlwifi * don't load firmware that won't exist for 7260 * fix RCU splat Johannes Berg (2): iwlwifi: separate firmware version for 7260 devices iwlwifi: mvm: protect RCU dereference in iwl_mvm_get_key_sta_id Kalle Valo (1): Merge tag 'iwlwifi-for-kalle-2015-12-16' of https://git.kernel.org/.../iwlwifi/iwlwifi-fixes drivers/net/wireless/iwlwifi/iwl-7000.c | 49 ++- drivers/net/wireless/iwlwifi/mvm/sta.c | 15 ++ 2 files changed, 44 insertions(+), 20 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method
Souptick Joarder <jrdr.li...@gmail.com> writes: > Hi Brent, > > On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor <moto...@gmail.com> wrote: >> On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder <jrdr.li...@gmail.com> >> wrote: >>> Hi Brent, >>> >>> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor <moto...@gmail.com> wrote: >>> >>>> --- a/drivers/net/wireless/ath/ath6kl/init.c >>>> +++ b/drivers/net/wireless/ath/ath6kl/init.c >>>> @@ -673,10 +673,15 @@ static int ath6kl_get_fw(struct ath6kl *ar, const >>>> char *filename, >>>> return ret; >>>> >>>> *fw_len = fw_entry->size; >>>> - *fw = kmemdup(fw_entry->data, fw_entry->size, GFP_KERNEL); >>>> + if (>fw == fw) >>>> + *fw = vmalloc(fw_entry->size); >>>> + else >>>> + *fw = kmalloc(fw_entry->size, GFP_KERNEL) >>> >>> Why vmalloc and kmalloc both are required? can't use either >>> vmalloc or kmalloc? >> >> My original problem was that kmemdup (which uses kmalloc) could not >> allocate enough memory > > If kmemdump ( which uses kmalloc) could not allocate memory then > using kmalloc again can lead to same problem. > I guess it will be correct to use > *fw = vmalloc(fw_entry->size); > Correct me if i am wrong. That sounds best. But remember take into account DMA requirements, IIRC you cannot DMA from vmalloc memory on all platforms. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] mwifiex: correctly handling kzalloc
Andy Shevchenko <andy.shevche...@gmail.com> writes: > On Tue, Dec 29, 2015 at 10:17 PM, Insu Yun <wuni...@gmail.com> wrote: > > Empty commit message? Yeah, no empty commit log, please. And then you submit a new version remember to add v2, v3 and so on: http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)
Uri Mashiach <uri.mashi...@compulab.co.il> writes:
> Fix the below Oops when trying to modprobe wlcore_spi.
> The oops occurs because the wl1271_power_{off,on}()
> function doesn't check the power() function pointer.
>
> [ 23.401447] Unable to handle kernel NULL pointer dereference at
> virtual address
> [ 23.409954] pgd = c0004000
> [ 23.412922] [] *pgd=
> [ 23.416693] Internal error: Oops: 8007 [#1] SMP ARM
> [ 23.422168] Modules linked in: wl12xx wlcore mac80211 cfg80211
> musb_dsps musb_hdrc usbcore usb_common snd_soc_simple_card evdev joydev
> omap_rng wlcore_spi snd_soc_tlv320aic23_i2c rng_core snd_soc_tlv320aic23
> c_can_platform c_can can_dev snd_soc_davinci_mcasp snd_soc_edma
> snd_soc_omap omap_wdt musb_am335x cpufreq_dt thermal_sys hwmon
> [ 23.453253] CPU: 0 PID: 36 Comm: kworker/0:2 Not tainted
> 4.2.0-2-g951efee-dirty #233
> [ 23.461720] Hardware name: Generic AM33XX (Flattened Device Tree)
> [ 23.468123] Workqueue: events request_firmware_work_func
> [ 23.473690] task: de32efc0 ti: de4ee000 task.ti: de4ee000
> [ 23.479341] PC is at 0x0
> [ 23.482112] LR is at wl12xx_set_power_on+0x28/0x124 [wlcore]
> [ 23.488074] pc : [<>]lr : []psr: 6013
> [ 23.488074] sp : de4efe50 ip : 0002 fp :
> [ 23.500162] r10: de7cdd00 r9 : dc848800 r8 : bf27af00
> [ 23.505663] r7 : bf27a1a8 r6 : dcbd8a80 r5 : dce0e2e0 r4 :
> dce0d2e0
> [ 23.512536] r3 : r2 : r1 : 0001 r0 :
> dc848810
> [ 23.519412] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM
> Segment kernel
> [ 23.527109] Control: 10c5387d Table: 9cb78019 DAC: 0015
> [ 23.533160] Process kworker/0:2 (pid: 36, stack limit = 0xde4ee218)
> [ 23.539760] Stack: (0xde4efe50 to 0xde4f)
>
> [...]
>
> [ 23.665030] [] (wl12xx_set_power_on [wlcore]) from
> [] (wlcore_nvs_cb+0x118/0xa4c [wlcore])
> [ 23.675604] [] (wlcore_nvs_cb [wlcore]) from []
> (request_firmware_work_func+0x30/0x58)
> [ 23.685784] [] (request_firmware_work_func) from
> [] (process_one_work+0x1b4/0x4b4)
> [ 23.695591] [] (process_one_work) from []
> (worker_thread+0x3c/0x4a4)
> [ 23.704124] [] (worker_thread) from []
> (kthread+0xd4/0xf0)
> [ 23.711747] [] (kthread) from []
> (ret_from_fork+0x14/0x3c)
> [ 23.719357] Code: bad PC value
> [ 23.722760] ---[ end trace 981be8510db9b3a9 ]---
>
> Prevent oops by validationg power() pointer value before
> calling the function.
>
> Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il>
> Cc: sta...@vger.kernel.org
> Acked-by: Igor Grinberg <grinb...@compulab.co.il>
Please always provide a changelog when you resend patches, I lost track
what I'm supposed to do with this. Should I apply or drop?
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: rsi: consolidate kmalloc/memset 0 calls to kzalloc
> This is an API consolidation only. The use of kmalloc + memset to 0 > is equivalent to kzalloc. > > Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: rsi: bool tests do not need comparison
> This is an API consolidation only. Bool initializations should > use true and false thus bool tests don't need an explicit comparison. > > Signed-off-by: Nicholas Mc Guire <hof...@osadl.org> Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
