rfc: Are any of the seq_pad() uses really necessary?

$ git grep -w seq_pad net net/ipv4/fib_trie.c:seq_pad(seq, '\n'); net/ipv4/ping.c:seq_pad(seq, '\n'); net/ipv4/tcp_ipv4.c:seq_pad(seq, '\n'); net/ipv4/udp.c: seq_pad(seq, '\n'); net/phonet/socket.c:seq_pad(seq, '\n'); net/phonet/socket.c:seq_pad(seq, '\n');

[PATCH net-next 3/3] bpf: add helper to invalidate hash

Add a small helper that complements 36bbef52c7eb ("bpf: direct packet write and access for helpers for clsact progs") for invalidating the current skb->hash after mangling on headers via direct packet write. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov

[PATCH net-next 2/3] bpf: use bpf_get_smp_processor_id_proto instead of raw one

Same motivation as in commit 80b48c445797 ("bpf: don't use raw processor id in generic helper"), but this time for XDP typed programs. Thus, allow for preemption checks when we have DEBUG_PREEMPT enabled, and otherwise use the raw variant. Signed-off-by: Daniel Borkmann

Re: [PATCH net-next 0/4] net: dsa: add port fast ageing

On Thu, Sep 22, 2016 at 04:49:20PM -0400, Vivien Didelot wrote: > Today the DSA drivers are in charge of flushing the MAC addresses > associated to a port when its STP state changes from Learning or > Forwarding, to Disabled or Blocking or Listening. > > This makes the drivers more complex and

Re: [PATCH v2] bpf: Set register type according to is_valid_access()

On Thu, Sep 22, 2016 at 09:56:47PM +0200, Mickaël Salaün wrote: > This fix a pointer leak when an unprivileged eBPF program read a pointer > value from the context. Even if is_valid_access() returns a pointer > type, the eBPF verifier replace it with UNKNOWN_VALUE. The register > value containing

[PATCH net-next] drivers: net: xgene: Fix MSS programming

Current driver programs static value of MSS in hardware register for TSO offload engine to segment the TCP payload regardless the MSS value provided by network stack. This patch fixes this by programming hardware registers with the stack provided MSS value. Since the hardware has the limitation

Re: [Patch net] sch_qfq: keep backlog updated with qlen

On 16-09-18 07:22 PM, Cong Wang wrote: Reported-by: Stas Nichiporovich Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang Acked-by: Jamal Hadi Salim

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

On 16-09-22 09:21 AM, Shmulik Ladkani wrote: From: Shmulik Ladkani Up until now, 'action mirred' supported only egress actions (either TCA_EGRESS_REDIR or TCA_EGRESS_MIRROR). This patch implements the corresponding ingress actions TCA_INGRESS_REDIR and

Re: [PATCH iproute2] ip: Use specific slave id

On Tue, 20 Sep 2016 18:02:12 +0800 Hangbin Liu wrote: > The original bond/bridge/vrf and slaves use same id, which make people > confused. Use bond/bridge/vrf_slave as id name will make code more clear. > > Acked-by: Phil Sutter > Signed-off-by:

Re: [PATCH] net: VRF: Fix receiving multicast traffic

On 09/23/2016 03:14 AM, David Ahern wrote: > > l3mdev devices do not support IPv4 multicast so checking mcast against that > device should not be working at all. For that reason I was fine with the > change in the previous patch. ie., you want the real ingress device there not > the vrf

Re: [PATCH net-next] tcp: add tcp_add_backlog()

On Thu, 2016-09-22 at 19:34 -0300, Marcelo Ricardo Leitner wrote: > On Sat, Aug 27, 2016 at 07:37:54AM -0700, Eric Dumazet wrote: > > +bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb) > > +{ > > + u32 limit = sk->sk_rcvbuf + sk->sk_sndbuf; > ^^^ > ... >

Re: [PATCH net-next] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

Date: Thu, 22 Sep 2016 19:48:47 +0300, Sergei Shtylyov wrote: >On 09/22/2016 07:16 PM, sean.w...@mediatek.com wrote: > >> From: Sean Wang >> >> fix typo in mediatek-net.txt and add phy-mode "trgmii" to ethernet.txt > >These changes

[PATCH 1/7] hv_netvsc: use consume_skb

From: Stephen Hemminger Packets that are transmitted in normal path should use consume_skb instead of kfree_skb. This allows for better tracing of packet drops. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c |4 ++-- 1

[PATCH 3/7] hv_netvsc: simplify callback event code

From: Stephen Hemminger The callback handler for netlink events can be simplified: * Consolidate check for netlink callback events about this driver itself. * Ignore non-Ethernet devices. Signed-off-by: Stephen Hemminger ---

[PATCH 7/7] hv_netvsc: count multicast packets received

From: Stephen Hemminger Useful for debugging issues with multicast and SR-IOV to keep track of number of received multicast packets. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |2 ++ drivers/net/hyperv/netvsc_drv.c

Re: [PATCH iproute2] misc/ss: tcp cwnd should be unsigned

On Thu, 22 Sep 2016 16:40:28 +0800 Hangbin Liu wrote: > tcp->snd_cwd is a u32, but ss treats it like a signed int. This may > results in negative bandwidth calculations. > > Signed-off-by: Hangbin Liu Sure applied.

Re: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

On 16-09-21 08:54 AM, Yotam Gigi wrote: Without that fix, the following could occur: - On encode ingress, the total amount of skb_pushes (in lines 751 and 753) was more than specified in cow. - On machines with hard_header_len > mac_len, the packet format was not Just curious: What

[PATCH net-next 1/3] bpf: use skb_to_full_sk helper in bpf_skb_under_cgroup

We need to use skb_to_full_sk() helper introduced in commit bd5eb35f16a9 ("xfrm: take care of request sockets") as otherwise we miss tcp synack messages, since ownership is on request socket and therefore it would miss the sk_fullsock() check. Use skb_to_full_sk() as also done similarly in the

Re: [Patch net] sch_sfb: keep backlog updated with qlen

On 16-09-18 07:22 PM, Cong Wang wrote: Fixes: 2f5fb43f ("net_sched: update hierarchical backlog too") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang Acked-by: Jamal Hadi Salim cheers, jamal

[PATCH net-next 0/3] Few minor BPF helper improvements

Just a few minor improvements around BPF helpers, first one is a fix but given this late stage and that it's not really a critical one, I think net-next is just fine. For details please see the individual patches. Thanks! Daniel Borkmann (3): bpf: use skb_to_full_sk helper in

[PATCH 2/7] hv_netvsc: dev hold/put reference to VF

From: Stephen Hemminger The netvsc driver holds a pointer to the virtual function network device if managing SR-IOV association. In order to ensure that the VF network device does not disappear, it should be using dev_hold/dev_put to get a reference count. Signed-off-by:

[PATCH 4/7] hv_netvsc: improve VF device matching

From: Stephen Hemminger The code to associate netvsc and VF devices can be made less error prone by using a better matching algorithms. On registration, use the permanent address which avoids any possible issues caused by device MAC address being changed. For all other

[PATCH 5/7] hv_netvsc: use RCU to protect vf_netdev

From: Stephen Hemminger The vf_netdev pointer in the netvsc device context can simply be protected by RCU because network device destruction is already RCU synchronized. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |2

[PATCH 6/7] hv_netvsc: remove VF in flight counters

From: Stephen Hemminger Since VF reference is now protected by RCU, no longer need the VF usage counter and can use device flags to see whether to inject or not. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h |3 +-

[PATCH net-next 0/7] hv_netvsc changes

From: Stephen Hemminger These are mostly about improving the handling of interaction between the virtual network device (netvsc) and the SR-IOV VF network device. Stephen Hemminger (7): hv_netvsc: use consume_skb hv_netvsc: dev hold/put reference to VF hv_netvsc:

Re: [PATCH net 1/2] act_ife: Fix external mac header on encode

On 16-09-22 08:55 AM, Yotam Gigi wrote: On ife encode side, external mac header is copied from the original packet and may be overridden if the user requests. Before, the mac header copy was done from memory region that might not be accessible anymore, as skb_cow_head might free it and copy the

Re: [Patch net-next] net_sched: check NULL on error path in route4_change()

On 16-09-18 06:52 PM, Cong Wang wrote: On error path in route4_change(), 'f' could be NULL, so we should check NULL before calling tcf_exts_destroy(). Fixes: b9a24bb76bf6 ("net_sched: properly handle failure case of tcf_exts_init()") Reported-by: kbuild test robot Cc:

Re: [PATCH net-next v2 0/3] add support for RGMII on GMAC0 through TRGMII hardware module

From: Sergei Shtylyov Date: Thu, 22 Sep 2016 20:08:47 +0300 >Despite my comments? Sigh... Sorry, I thought he had addressed your feedback in v2. I'll wait longer next time.

[PATCH net] tcp: fix a compile error in DBGUNDO()

From: Eric Dumazet If DBGUNDO() is enabled (FASTRETRANS_DEBUG > 1), a compile error will happen, since inet6_sk(sk)->daddr became sk->sk_v6_daddr Fixes: efe4208f47f9 ("ipv6: make lookups simpler and faster") Signed-off-by: Eric Dumazet ---

Re: [PATCH net-next] tcp: add tcp_add_backlog()

On Sat, Aug 27, 2016 at 07:37:54AM -0700, Eric Dumazet wrote: > +bool tcp_add_backlog(struct sock *sk, struct sk_buff *skb) > +{ > + u32 limit = sk->sk_rcvbuf + sk->sk_sndbuf; ^^^ ... > + if (!skb->data_len) > + skb->truesize =

Re: [PATCH] net: VRF: Fix receiving multicast traffic

On 9/22/16 4:10 PM, Mark Tomlinson wrote: > > On 09/23/2016 03:14 AM, David Ahern wrote: >> >> l3mdev devices do not support IPv4 multicast so checking mcast against that >> device should not be working at all. For that reason I was fine with the >> change in the previous patch. ie., you want

Re: [PATCH iproute2] ss: Support displaying and filtering on socket marks.

On Thu, 22 Sep 2016 01:02:50 +0900 Lorenzo Colitti wrote: > This allows the user to dump sockets with a given mark (via > "fwmark = 0x1234/0x1234" or "fwmark = 12345", etc.) , and to > display the socket marks of dumped sockets. > > The relevant kernel commits are:

Re: [PATCH iproute2 2/2] ip rule: add selector support

2016-09-22 16:45 GMT+08:00 Phil Sutter : > On Thu, Sep 22, 2016 at 02:28:49PM +0800, Hangbin Liu wrote: > [...] >> diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8 >> index 3508d80..ec0e31d 100644 >> --- a/man/man8/ip-rule.8 >> +++ b/man/man8/ip-rule.8 >> @@ -15,7 +15,8 @@ ip-rule

Re: [PATCH] net: VRF: Fix receiving multicast traffic

On 09/23/2016 10:41 AM, David Ahern wrote: > On 9/22/16 4:10 PM, Mark Tomlinson wrote: >> On 09/23/2016 03:14 AM, David Ahern wrote: >>> l3mdev devices do not support IPv4 multicast so checking mcast against that >>> device should not be working at all. For that reason I was fine with the >>>

Re: [PATCH net-next 0/4] net: dsa: add port fast ageing

On 09/22/2016 01:49 PM, Vivien Didelot wrote: > Today the DSA drivers are in charge of flushing the MAC addresses > associated to a port when its STP state changes from Learning or > Forwarding, to Disabled or Blocking or Listening. > > This makes the drivers more complex and hides this generic

[net-next v2 03/10] i40e: return correct opcode to VF

From: Mitch Williams This conditional is backward, so the driver responds back to the VF with the wrong opcode. Do the old switcheroo to fix this. Change-ID: I384035b0fef8a3881c176de4b4672009b3400b25 Signed-off-by: Mitch Williams

[net-next v2 07/10] i40evf: Fix link state event handling

From: Sridhar Samudrala Currently disabling the link state from PF via ip link set enp5s0f0 vf 0 state disable doesn't disable the CARRIER on the VF. This patch updates the carrier and starts/stops the tx queues based on the link state notification from PF.

[net-next v2 04/10] i40e: Fix to check for NULL

From: Carolyn Wyborny This patch fixes an issue in the virt channel code, where a return from i40e_find_vsi_from_id was not checked for NULL when applicable. Without this patch, there is a risk for panic and static analysis tools complain. This patch fixes the problem

[net-next v2 08/10] i40evf: remove unnecessary error checking against i40evf_up_complete

From: Bimmy Pujari Function i40evf_up_complete() always returns success. Changed this to a void type and removed the code that checks the return status and prints an error message. Change-ID: I8c400f174786b9c855f679e470f35af292fb50ad Signed-off-by: Bimmy Pujari

[net-next v2 01/10] i40e: fix setting user defined RSS hash key

From: Alan Brady Previously, when using ethtool to change the RSS hash key, ethtool would report back saying the old key was still being used and no error was reported. It was unclear whether it was being reported incorrectly or being set incorrectly. Debugging revealed

[net-next v2 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2016-09-22

This series contains updates to i40e and i40evf only. Sridhar fixes link state event handling by updating the carrier and starts/stops the Tx queues based on the link state notification from PF. Brady fixes an issue where a user defined RSS hash key was not being set because a user defined

[net-next v2 06/10] i40e: avoid potential null pointer dereference when assigning len

From: Colin Ian King There is a sanitcy check for desc being null in the first line of function i40evf_debug_aq. However, before that, aq_desc is cast from desc, and aq_desc is being dereferenced on the assignment of len, so this could be a potential null pointer

[net-next v2 09/10] i40e: Limit TX descriptor count in cases where frag size is greater than 16K

From: Alexander Duyck The i40e driver was incorrectly assuming that we would always be pulling no more than 1 descriptor from each fragment. It is in fact possible for us to end up with the case where 2 descriptors worth of data may be pulled when a frame is larger

[net-next v2 02/10] i40e: fix "dump port" command when NPAR enabled

From: Alan Brady When using the debugfs to issue the "dump port" command with NPAR enabled, the firmware reports back with invalid argument. The issue occurs because the pf->mac_seid was used to perform the query. This is fine when NPAR is disabled because the switch ID ==

[net-next v2 05/10] i40e: Fix for extra byte swap in tunnel setup

From: Carolyn Wyborny This patch fixes an issue where we were byte swapping the port parameter, then byte swapping it again in function execution. Obviously, that's unnecessary, so take it out of the function calls. Without this patch, the udp based tunnel

[net-next v2 10/10] i40evf: remove unnecessary error checking against i40e_shutdown_adminq

From: Lihong Yang The i40e_shutdown_adminq function never returns failure. There is no need to check the non-0 return value. Clean up the unnecessary error checking and warning against it. Change-ID: Ibb616f09cfb93bd1a872ebf3241a15fb8354b31b Signed-off-by: Lihong Yang

[PATCHv2 iproute2 2/2] ip rule: add selector support

Signed-off-by: Hangbin Liu --- ip/iprule.c| 180 +++-- man/man8/ip-rule.8 | 6 +- 2 files changed, 180 insertions(+), 6 deletions(-) diff --git a/ip/iprule.c b/ip/iprule.c index e18505f..42fb6af 100644 ---

[PATCHv2 iproute2 1/2] ip rule: merge ip rule flush and list, save together

iprule_flush() and iprule_list_or_save() both call function rtnl_wilddump_request() and rtnl_dump_filter(). So merge them together just like other files do. Signed-off-by: Hangbin Liu --- ip/iprule.c | 121 +++- 1

[PATCHv2 iproute2 0/2] ip rule: merger iprule_flush and add selector support

When merge iprule_flush() and iprule_list_or_save(). Renamed rtnl_filter_t filter to filter_fn because we want to use global variable 'filter' to filter nlmsg in the next patch. Hangbin Liu (2): ip rule: merge ip rule flush and list, save together ip rule: add selector support ip/iprule.c

Re: [PATCH net-next 4/4] net/sched: act_mirred: Implement ingress actions

Hi, On Thu, 22 Sep 2016 19:40:15 -0400 Jamal Hadi Salim wrote: > On 16-09-22 09:21 AM, Shmulik Ladkani wrote: > > From: Shmulik Ladkani > > > > Up until now, 'action mirred' supported only egress actions (either > > TCA_EGRESS_REDIR or

Re: [PATCH net-next v2 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

Date: Thu, 22 Sep 2016 14:30:53 +0300, Sergei Shtylyov wrote: >>Hello. > >On 9/22/2016 5:33 AM, sean.w...@mediatek.com wrote: > >> From: Sean Wang >> >> adds PHY-mode "trgmii" as an extension for the operation mode of the >> PHY

RE: [PATCH net] act_ife: Add support for machines with hard_header_len != mac_len

>-Original Message- >From: Jamal Hadi Salim [mailto:j...@mojatatu.com] >Sent: Friday, September 23, 2016 1:40 AM >To: Yotam Gigi ; da...@davemloft.net; >netdev@vger.kernel.org; Roman Mashak >Subject: Re: [PATCH net] act_ife: Add support for machines

[PATCH v2 net-next 0/2] bnx2x: page allocation failure

Hi, While configuring ~500 multicast addrs, we ran into high order page allocation failures. They don't need to be high order, and thus I'm proposing to split them into at most PAGE_SIZE allocations. Below is a sample failure. Thanks, -Jason [1201902.617882] bnx2x:

[PATCH v2 net-next 1/2] bnx2x: allocate mac filtering 'mcast_list' in PAGE_SIZE increments

From: Jason Baron Currently, we can have high order page allocations that specify GFP_ATOMIC when configuring multicast MAC address filters. For example, we have seen order 2 page allocation failures with ~500 multicast addresses configured. Convert the allocation for

[PATCH v2 net-next 2/2] bnx2x: allocate mac filtering pending list in PAGE_SIZE increments

From: Jason Baron Currently, we can have high order page allocations that specify GFP_ATOMIC when configuring multicast MAC address filters. For example, we have seen order 2 page allocation failures with ~500 multicast addresses configured. Convert the allocation for the

Re: [PATCH] L2TP:Adjust intf MTU, add underlay L3, overlay L2

On Thu, 22 Sep 2016, Derek Fawcus wrote: > On Wed, Sep 21, 2016 at 02:11:04pm -0700, R. Parameswaran wrote: > > > [snip] > > > @@ -206,6 +209,46 @@ static void l2tp_eth_show(struct seq_file *m, void > > *arg) > > } > > #endif > [snip] > > > + > > static int l2tp_eth_create(struct net

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

On (09/22/16 01:52), David Miller wrote: > Alternatively we can do Alexander Duyck's trick, by pushing > the headers into the frag list, forcing a pull and realignment > by the next protocol layer. What is the "Alexander Duyck trick" (hints about module or commit id, where this can be found,

[PATCH iproute2 1/2] ip rule: merge ip rule flush and list, save together

iprule_flush() and iprule_list_or_save() both call function rtnl_wilddump_request() and rtnl_dump_filter(). So merge them together just like other files do. Signed-off-by: Hangbin Liu --- ip/iprule.c | 121 +++- 1

[PATCH iproute2 2/2] ip rule: add selector support

Signed-off-by: Hangbin Liu --- ip/iprule.c| 180 +++-- man/man8/ip-rule.8 | 6 +- 2 files changed, 180 insertions(+), 6 deletions(-) diff --git a/ip/iprule.c b/ip/iprule.c index e18505f..42fb6af 100644 ---

[PATCH iproute2 0/2] ip rule: merger iprule_flush and add selector support

When merge iprule_flush() and iprule_list_or_save(). Renamed rtnl_filter_t filter to filter_fn because we want to use global variable 'filter' to filter nlmsg in the next patch. Hangbin Liu (2): ip rule: merge ip rule flush and list, save together ip rule: add selector support ip/iprule.c

RE: [RFC v2 06/12] qedr: Add support for QP verbs

> > Do you have a git tree? > We don't have a publicly accessible git tree.

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On Thu, 2016-09-22 at 15:14 +0200, Jesper Dangaard Brouer wrote: > On Wed, 21 Sep 2016 21:56:58 +0200 > Jesper Dangaard Brouer wrote: > > > > > I'm not opposed to running non-BPF code at XDP. I'm against adding > > > > a linked list of hook consumers. > > > > I also worry

Re: [PATCH net-next] net/vxlan: Avoid unaligned access in vxlan_build_skb()

From: Jiri Benc Date: Tue, 20 Sep 2016 19:09:29 +0200 > But the point stands, we have much greater problems here than VXLAN. > And I don't think that wrapping all IP address accesses into > get/put_unaligned all around the stack is the solution. Right, and I don't like marking

Re: [PATCH v2 0/2] make POSIX timers optional

From: Nicolas Pitre Date: Tue, 20 Sep 2016 15:56:38 -0400 > Many embedded systems don't need the full POSIX timer support. > Configuring them out provides a nice kernel image size reduction. > > When POSIX timers are configured out, the PTP clock subsystem should be >

Re: [PATCH net-next] MAINTAINERS: Update b44 maintainer.

From: Michael Chan Date: Tue, 20 Sep 2016 23:33:15 -0400 > Taking over as maintainer since Gary Zambrano is no longer working > for Broadcom. > > Signed-off-by: Michael Chan Applied, thanks.

Re: [PATCH net-next] tcp: implement TSQ for retransmits

From: Eric Dumazet Date: Tue, 20 Sep 2016 22:45:58 -0700 > From: Eric Dumazet > > We saw sch_fq drops caused by the per flow limit of 100 packets and TCP > when dealing with large cwnd and bursts of retransmits. > > Even after increasing the limit

Re: pull request (net): ipsec 2016-09-21

From: Steffen Klassert Date: Wed, 21 Sep 2016 13:05:42 +0200 > 1) Propagate errors on security context allocation. >From Mathias Krause. > > 2) Fix inbound policy checks for inter address family tunnels. >From Thomas Zeitlhofer. > > 3) Fix an old memory

Re: [PATCH net-next 0/9] rxrpc: Preparation for slow-start algorithm

I'm going to post a V2 for this. I've used a couple of 64-bit division operators rather than calling the appropriate function (which is fine on x86_64) and managed to transpose the last two patches (causing an undefined symbol in one of them). David

[PATCH net-next 0/9] rxrpc: Preparation for slow-start algorithm [ver #2]

ub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160922-v2 David --- David Howells (9): rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs rxrpc: Add re-sent Tx annotation rxrpc: Add per-peer RTT tracker rxrpc: Send pings to get RTT data

Re: [PATCHv3 net-next 0/2] Preparation for mv88e6390

From: Andrew Lunn Date: Wed, 21 Sep 2016 01:40:30 +0200 > These two patches are a couple of preparation steps for supporting the > the MV88E6390 family of chips. This is a new generation from Marvell, > and will need more feature flags than are currently available in an >

Re: pull-request: can 2016-09-21

From: Marc Kleine-Budde Date: Wed, 21 Sep 2016 10:43:54 +0200 > this is another pull request of one patch for the upcoming linux-4.8 release. > > Marek Vasut fixes the CAN-FD bit rate switch in the ifi driver by configuring > the transmitter delay. Pulled, thanks.

Re: [patch net-next 6/6] doc: update switchdev L3 section

On Wed, Sep 21, 2016 at 01:53:14PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > This is to reflect the change of FIB offload infrastructure from > switchdev objects to FIB notifier. > > Signed-off-by: Jiri Pirko > --- >

Re: [PATCH ipsec-next] xfrm: state lookup can be lockless

On Tue, Sep 20, 2016 at 03:45:26PM +0200, Florian Westphal wrote: > This is called from the packet input path, we get lock contention > if many cpus handle ipsec in parallel. > > After recent rcu conversion it is safe to call __xfrm_state_lookup > without the spinlock. > > Signed-off-by: Florian

[GIT] Networking

Mostly small bits scattered all over the place, which is usually how things go this late in the -rc series. 1) Proper driver init device resets in bnx2, from Baoquan He. 2) Fix accounting overflow in __tcp_retransmit_skb(), sk_forward_alloc, and ip_idents_reserve, from Eric Dumazet. 3) Fix

[PATCH nf v4] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

From: Gao Feng It is valid that the TCP RST packet which does not set ack flag, and bytes of ack number are zero. But current seqadj codes would adjust the "0" ack to invalid ack number. Actually seqadj need to check the ack flag before adjust it for these RST packets. The

[PATCH nf v5] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

From: Gao Feng It is valid that the TCP RST packet which does not set ack flag, and bytes of ack number are zero. But current seqadj codes would adjust the "0" ack to invalid ack number. Actually seqadj need to check the ack flag before adjust it for these RST packets. The

Re: [PATCH net-next V2 0/8] mlx5e XDP support

From: Tariq Toukan Date: Wed, 21 Sep 2016 12:19:41 +0300 > This series adds XDP support in mlx5e driver. > This includes the use cases: XDP_DROP, XDP_PASS, and XDP_TX. > > Single stream performance tests show 16.5 Mpps for XDP_DROP, > and 12.4 Mpps for XDP_TX, with nice

Re: [PATCH net-next v2 0/6] ftgmac100 support for ast2500

From: Joel Stanley Date: Thu, 22 Sep 2016 08:34:57 +0930 > Hello Dave, > > This series adds support to the ftgmac100 driver for the Aspeed ast2400 and > ast2500 SoCs. In particular, they ensure the driver works correctly on the > ast2500 where the MAC block has seen some changes

Re: [PATCH net-next] net: ethernet: mediatek: fix missing changes merged for conflicts overlapping commits

From: Date: Tue, 20 Sep 2016 23:53:24 +0800 > From: Sean Wang > > add the missing commits about > 1) > Commit d3bd1ce4db8e843dce421e2f8f123e5251a9c7d3 > ("remove redundant free_irq for devm_request_ir allocated irq") > 2) > Commit

Re: [PATCH 1/2] net: ethernet: hisilicon: hns: use phydev from struct net_device

From: Philippe Reynes Date: Tue, 20 Sep 2016 22:30:11 +0200 > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phydev in the private structure, and update the driver to use the > one

Re: [PATCH 2/2] net: ethernet: hisilicon: hns: use new api ethtool_{get|set}_link_ksettings

From: Philippe Reynes Date: Tue, 20 Sep 2016 22:30:12 +0200 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes Applied.

Re: [patch net-next 5/6] switchdev: remove FIB offload infrastructure

On Wed, Sep 21, 2016 at 01:53:13PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Since this is now taken care of by FIB notifier, remove the code, with > all unused dependencies. > > Signed-off-by: Jiri Pirko [...] > -static struct net_device

Re: [PATCH net] tcp: fix under-accounting retransmit SNMP counters

From: Yuchung Cheng Date: Wed, 21 Sep 2016 16:16:14 -0700 > This patch fixes these under-accounting SNMP rtx stats > LINUX_MIB_TCPFORWARDRETRANS > LINUX_MIB_TCPFASTRETRANS > LINUX_MIB_TCPSLOWSTARTRETRANS > when retransmitting TSO packets > > Fixes: 10d3be569243 ("tcp-tso: do

Re: [PATCH net] tcp: properly account Fast Open SYN-ACK retrans

From: Yuchung Cheng Date: Wed, 21 Sep 2016 16:16:15 -0700 > Since the TFO socket is accepted right off SYN-data, the socket > owner can call getsockopt(TCP_INFO) to collect ongoing SYN-ACK > retransmission or timeout stats (i.e., tcpi_total_retrans, > tcpi_retransmits).

Re: [PATCH nf v3] netfilter: seqadj: Fix the wrong ack adjust for the RST packet without ack

On top of Eric's comments. On Thu, Sep 22, 2016 at 10:22:45AM +0800, f...@ikuai8.com wrote: > diff --git a/net/netfilter/nf_conntrack_seqadj.c > b/net/netfilter/nf_conntrack_seqadj.c > index dff0f0c..3bd9c7e 100644 > --- a/net/netfilter/nf_conntrack_seqadj.c > +++

Re: [PATCH] ptp_clock: future-proofing drivers against PTP subsystem becoming optional

From: Nicolas Pitre Date: Tue, 20 Sep 2016 19:25:58 -0400 (EDT) > > Drivers must be ready to accept NULL from ptp_clock_register() if the > PTP clock subsystem is configured out. > > This patch documents that and ensures that all drivers cope well > with a NULL

Re: [patch net-next 3/6] mlxsw: spectrum_router: Use FIB notifications instead of switchdev calls

On Wed, Sep 21, 2016 at 01:53:11PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > Until now, in order to offload a FIB entry to HW we use switchdev op. > However that has limits. Mainly in case we need to make the HW aware of > all route prefixes configured in kernel. HW

Re: [PATCH next v3 0/2] Rename WORD_TRUNC/ROUND macros and use them

From: Marcelo Ricardo Leitner Date: Wed, 21 Sep 2016 08:45:54 -0300 > This patchset aims to rename these macros to a non-confusing name, as > reported by David Laight and David Miller, and to update all remaining > places to make use of it, which was 1 last remaining

Re: [PATCH -next] net: dsa: qca8k: fix non static symbol warning

From: Wei Yongjun Date: Wed, 21 Sep 2016 15:04:43 + > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/net/dsa/qca8k.c:259:22: warning: > symbol 'qca8k_regmap_config' was not declared. Should it be static? > >

Re: [PATCH -next] cxgb4: Convert to use simple_open()

From: Wei Yongjun Date: Wed, 21 Sep 2016 15:09:16 + > From: Wei Yongjun > > Remove an open coded simple_open() function and replace file > operations references to the function with simple_open() > instead. > > Generated by:

Re: [PATCH] net: fec: set mac address unconditionally

Hello, just a few nitpicks: On Wed, Sep 21, 2016 at 03:30:55PM +0200, Gavin Schenk wrote: > Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac > address") This line belongs to in the S-o-B area below. > If the mac address origin is not dt, you can only safe assign a

Re: [PATCH net] net: get rid of an signed integer overflow in ip_idents_reserve()

From: Eric Dumazet Date: Tue, 20 Sep 2016 18:06:17 -0700 > From: Eric Dumazet > > Jiri Pirko reported an UBSAN warning happening in ip_idents_reserve() > > [] UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:11 > [] signed integer

[PATCH net-next 7/9] rxrpc: Obtain RTT data by requesting ACKs on DATA packets [ver #2]

In addition to sending a PING ACK to gain RTT data, we can set the RXRPC_REQUEST_ACK flag on a DATA packet and get a REQUESTED-ACK ACK. The ACK packet contains the serial number of the packet it is in response to, so we can look through the Tx buffer for a matching DATA packet. This requires

[PATCH net-next 3/9] rxrpc: Add per-peer RTT tracker [ver #2]

Add a function to track the average RTT for a peer. Sources of RTT data will be added in subsequent patches. The RTT data will be useful in the future for determining resend timeouts and for handling the slow-start part of the Rx protocol. Also add a pair of tracepoints, one to log

[PATCH net-next 9/9] rxrpc: Reduce the number of PING ACKs sent [ver #2]

We don't want to send a PING ACK for every new incoming call as that just adds to the network traffic. Instead, we send a PING ACK to the first three that we receive and then once per second thereafter. This could probably be made adjustable in future. Signed-off-by: David Howells

[PATCH net-next 4/9] rxrpc: Send pings to get RTT data [ver #2]

Send a PING ACK packet to the peer when we get a new incoming call from a peer we don't have a record for. The PING RESPONSE ACK packet will tell us the following about the peer: (1) its receive window size (2) its MTU sizes (3) its support for jumbo DATA packets (4) if it supports slow

[PATCH net-next 5/9] rxrpc: Expedite ping response transmission [ver #2]

Expedite the transmission of a response to a PING ACK by sending it from sendmsg if one is pending. We're most likely to see a PING ACK during the client call Tx phase as the other side may use it to determine a number of parameters, such as the client's receive window size, the RTT and whether

[PATCH net-next 8/9] rxrpc: Reduce the number of ACK-Requests sent [ver #2]

Reduce the number of ACK-Requests we set on DATA packets that we're sending to reduce network traffic. We set the flag on odd-numbered DATA packets to start off the RTT cache until we have at least three entries in it and then probe once per second thereafter to keep it topped up. This could be

[PATCH net-next 1/9] rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs [ver #2]

Don't store the rxrpc protocol header in sk_buffs on the transmit queue, but rather generate it on the fly and pass it to kernel_sendmsg() as a separate iov. This reduces the amount of storage required. Note that the security header is still stored in the sk_buff as it may get encrypted along

[PATCH net-next] net: ethernet: mediatek: remove superfluous local variable for phy address

From: Sean Wang remove the unused variable for parsing PHY address and the related logic for sanity test which would be all already handled done when of_mdiobus_register was called Reported-by: Nelson Chang Signed-off-by: Sean Wang

  1   2   3   >