Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

On 17 October 2016 at 08:28, Johannes Berg wrote: > On Sat, 2016-10-15 at 18:16 +0100, Ard Biesheuvel wrote: >> The CCM code goes out of its way to perform the CTR encryption of the >> MAC using the subordinate CTR driver. To this end, it tweaks the >> input and output

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

On Mon, 2016-10-17 at 08:37 +0100, Ard Biesheuvel wrote: >  > Could we get a statement first whether it is supported to allocate > aead_req (and other crypto req structures) on the stack? Well, we haven't heard from Herbert :) > If not, then > we have our work cut out for us. But if it is, I'd

Re: hello

On Fri, Oct 14, 2016 at 05:18:10PM +0800, maowenan wrote: > i want to subscribe this mail, thank you very much. > Try sending subscribe netdev to majord...@vger.kernel.org

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

On Mon, 2016-10-17 at 08:50 +0100, Ard Biesheuvel wrote: > I just realised that patch should probably use > aead_request_alloc/aead_request_free [and drop the memset]. That also > fixes the latent bug where the alignment of the req ctx is not take > into account. Good point, I'll fix that up. >

Re: [PATCH v3] mac80211: move struct aead_req off the stack

On 17 October 2016 at 09:03, Johannes Berg wrote: > From: Johannes Berg > > Some crypto implementations (such as the generic CCM wrapper in crypto/) > use scatterlists to map fields of private data in their struct aead_req. > This means these

Re: net/ipv6: potential deadlock in do_ipv6_setsockopt

Applied the patch to my test tree. I will tell you the result a few days later. Thank you. On 2016/10/17 2:50, Cong Wang wrote: > On Sun, Oct 16, 2016 at 6:34 AM, Baozeng Ding wrote: >> Possible unsafe locking scenario: >> >>CPU0CPU1 >>

Re: [PATCH v4] mac80211: move extra crypto data off the stack

> > Well, if your other patch to make it OK to be on-stack would be > > applied instead, this wouldn't make much sense either :) > > > > Yes but that one only fixes ccm not gcm Yes, but we can do the same for GCM, no? > > In this particular patch, we could reduce the size of the struct, > >

[PATCH] net: hip04: Remove superfluous ether_setup after alloc_etherdev

There is no need to call ether_setup after alloc_ethdev since it was already called there. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/hisilicon/hip04_eth.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c

Re: [PATCH v4] mac80211: move extra crypto data off the stack

On 17 October 2016 at 09:33, Johannes Berg wrote: > From: Johannes Berg > > As the stack can (on x86-64) now be virtually mapped rather than > using "normal" kernel memory, Sergey noticed mac80211 isn't using > the SG APIs correctly by putting

Re: Need help with mdiobus_register and phy

On 10/15/2016 08:28 PM, Timur Tabi wrote: > Andrew Lunn wrote: >> 1) Take the SerDes power down out of the suspend code for the at803x. >> >> 2) Assume MII_PHYID1/2 registers are not guaranteed to be available >> when the PHY is powered down. So get_phy_id should first read >> MII_BMCR. If it gets

Re: [PATCH v4] mac80211: move extra crypto data off the stack

On 17 October 2016 at 10:23, Johannes Berg wrote: > >> Apologies for going back and forth on this, but it appears there may >> be another way to deal with this. >> >> First of all, we only need this handling for the authenticated data, > > Are you sure b_0/j_0 aren't

Re: [PATCH net-next 1/2] net: phy: Add Speed downshift set driver for Microsemi PHYs.

Hi Andrew, Thank you for code review and comments. On Fri, Oct 14, 2016 at 02:12:32PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > On Fri, Oct 14, 2016 at 05:10:32PM +0530, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > For operation in cabling

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

On 17 October 2016 at 08:47, Johannes Berg wrote: > On Mon, 2016-10-17 at 08:37 +0100, Ard Biesheuvel wrote: >> >> Could we get a statement first whether it is supported to allocate >> aead_req (and other crypto req structures) on the stack? > > Well, we haven't heard

[PATCH] mac80211: move struct aead_req off the stack

From: Johannes Berg Some crypto implementations (such as the generic CCM wrapper in crypto/) use scatterlists to map fields of private data in their struct aead_req. This means these data structures cannot live in the vmalloc area, which means that they cannot live on

Re: [PATCH v4] mac80211: move extra crypto data off the stack

> Apologies for going back and forth on this, but it appears there may > be another way to deal with this. > > First of all, we only need this handling for the authenticated data, Are you sure b_0/j_0 aren't needed? We pass those to aead_request_set_crypt(), and I wasn't sure what that really

Re: [PATCH 10/10] mm: replace access_process_vm() write parameter with gup_flags

On Thu, Oct 13, 2016 at 01:20:20AM +0100, Lorenzo Stoakes wrote: > This patch removes the write parameter from access_process_vm() and replaces > it > with a gup_flags parameter as use of this function previously _implied_ > FOLL_FORCE, whereas after this patch callers explicitly pass this flag.

Re: [PATCH] crypto: ccm - avoid scatterlist for MAC encryption

On Sat, 2016-10-15 at 18:16 +0100, Ard Biesheuvel wrote: > The CCM code goes out of its way to perform the CTR encryption of the > MAC using the subordinate CTR driver. To this end, it tweaks the > input and output scatterlists so the aead_req 'odata' and/or > 'auth_tag' fields [which may live on

[PATCH v3] mac80211: move extra crypto data off the stack

From: Johannes Berg As the stack can (on x86-64) now be virtually mapped rather than using "normal" kernel memory, Sergey noticed mac80211 isn't using the SG APIs correctly by putting on-stack buffers into SG tables. This leads to kernel crashes. Fix this by allocating

[PATCH v3] mac80211: move struct aead_req off the stack

From: Johannes Berg Some crypto implementations (such as the generic CCM wrapper in crypto/) use scatterlists to map fields of private data in their struct aead_req. This means these data structures cannot live in the vmalloc area, which means that they cannot live on

Re: [PATCH v3] mac80211: move extra crypto data off the stack

[snip] Sorry, this went out by mistake. johannes

Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags

On Thu, Oct 13, 2016 at 01:20:16AM +0100, Lorenzo Stoakes wrote: > This patch removes the write and force parameters from get_user_pages() and > replaces them with a gup_flags parameter to make the use of FOLL_FORCE > explicit > in callers as use of this flag can result in surprising behaviour

Re: [PATCH v4] mac80211: move extra crypto data off the stack

> On 17 Oct 2016, at 10:35, Johannes Berg wrote: > >> On Mon, 2016-10-17 at 10:30 +0100, Ard Biesheuvel wrote: >> >> Yes. But as I replied, setting the req size is not supported atm, >> although it is reasonable to demand a way to allocate additional data >> in the

Re: [PATCH v4] mac80211: move extra crypto data off the stack

> On 17 Oct 2016, at 10:54, Johannes Berg wrote: > > >>> Well, if your other patch to make it OK to be on-stack would be >>> applied instead, this wouldn't make much sense either :) >>> >> >> Yes but that one only fixes ccm not gcm > > Yes, but we can do the same

Re: Hello

On Fri, Oct 14, 2016 at 05:17:36PM +0800, yuehaibing wrote: > subscribe linux-kernel > Try sending subscribe linux-kernel to majord...@vger.kernel.org

Re: linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561: poor error checking ?

Hi David, On Mon, 2016-10-17 at 07:40 +, David Binderman wrote: > Hello there, > > linux-4.9-rc1/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c:1561]: (style) > Checking if unsigned variable 'len' is less than zero. > > Source code is > > len = min((size_t)le32_to_cpu(rsp->len) << 2,

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

Hi Andrew, Thank you for code review and comments. On Fri, Oct 14, 2016 at 02:02:28PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > On Fri, Oct 14, 2016 at 05:10:33PM +0530, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > VSC8531 Fast Link Failure 2

[PATCH v4] mac80211: move extra crypto data off the stack

From: Johannes Berg As the stack can (on x86-64) now be virtually mapped rather than using "normal" kernel memory, Sergey noticed mac80211 isn't using the SG APIs correctly by putting on-stack buffers into SG tables. This leads to kernel crashes. Fix this by allocating

introduce IPV6_PKTINFO_L2 socket-option?

Hi all, I am currently writing some userspace UDP Software for 6LoWPAN subsystem. It will use UDP IPv6 sockets, the 6LoWPAN adaptation will be done at kernelspace. My problem is currently the following: I need per recvmsg(2) the used source link-layer address for the incoming UDP packet which

Re: [PATCH v4] mac80211: move extra crypto data off the stack

On Mon, 2016-10-17 at 10:30 +0100, Ard Biesheuvel wrote: > Yes. But as I replied, setting the req size is not supported atm, > although it is reasonable to demand a way to allocate additional data > in the request specifically for this issue. So let's proceed with the > aead_request_alloc/free

[PATCH iproute2 1/2] tc filters: display handle in events when a filter is deleted

From: Jamal Hadi Salim An event being displayed via "tc mon" should display the filter handle. The filter handle is a required parameter when deleting a filter and therefore the delete event should mimic/mirror the command sent. A simple test, run tc monitor on one window, on

[PATCH iproute2 2/2] tc filters: fix filters to display handle when deleted even when no option

From: Jamal Hadi Salim Fix a few stylistic things that hurt my eyes while at it. Signed-off-by: Jamal Hadi Salim --- tc/f_basic.c| 6 +++--- tc/f_bpf.c | 6 +++--- tc/f_cgroup.c | 7 +++ tc/f_flow.c | 4 ++-- tc/f_flower.c | 5

Re: [PATCH v4] mac80211: move extra crypto data off the stack

> On 17 Oct 2016, at 10:35, Johannes Berg wrote: > >> On Mon, 2016-10-17 at 10:30 +0100, Ard Biesheuvel wrote: >> >> Yes. But as I replied, setting the req size is not supported atm, >> although it is reasonable to demand a way to allocate additional data >> in the

[PATCH] ethtool: add register dump support for fjes driver

From: Taku This patch adds the register dump format for FUJITSU Extended Network device like the following: # ethtool -d es0 0x: OWNER_EPID(Owner EPID) 0x0001 0x0004: MAX_EP(Maximum EP) 0x0008

[PATCH v2] mac80211: move struct aead_req off the stack

From: Johannes Berg Some crypto implementations (such as the generic CCM wrapper in crypto/) use scatterlists to map fields of private data in their struct aead_req. This means these data structures cannot live in the vmalloc area, which means that they cannot live on

Re: [PATCH v4] mac80211: move extra crypto data off the stack

On 17 October 2016 at 10:14, Ard Biesheuvel wrote: > On 17 October 2016 at 09:33, Johannes Berg wrote: >> From: Johannes Berg >> >> As the stack can (on x86-64) now be virtually mapped rather than >> using "normal"

Re: [PATCH] mac80211_hwsim: suggest nl80211 instead of wext driver in documentation

On Mon, 2016-10-17 at 00:39 +0200, Linus Lüssing wrote: > For mac80211_hwsim interfaces, suggest to use wpa_supplicant with the > more modern, netlink based driver instead of wext. Makes sense, applied. > Actually, I wasn't even able to make a connection with the > configuration > files and

Re: [patch net-next RFC 4/6] Introduce sample tc action

Some comments: IIUC, the main struggle seems to be whether the redirect to dummy0 is useful or not? i.e instead of just letting the packets go up the stack on eth1? It seems like sflowd needs to read off eth1 via packet socket? To be backward compatible - supporting that approach seems sensible.

Re: [patch net-next RFC 4/6] Introduce sample tc action

On 10/17/16, 3:10 AM, Jamal Hadi Salim wrote: > > Some comments: > IIUC, the main struggle seems to be whether the redirect to dummy0 > is useful or not? i.e instead of just letting the packets go up the > stack on eth1? yep, correct...given existing workflow for the non-offloaded case is to

[PATCH 00/28] Reenable maybe-uninitialized warnings

This is a set of patches that I hope to get into v4.9 in some form in order to turn on the -Wmaybe-uninitialized warnings again. After talking to Linus in person at Linaro Connect about this, I spent some time on finding all the remaining warnings, and this is the resulting patch series. More

[PATCH 01/28] [v2] netfilter: nf_tables: avoid uninitialized variable warning

The newly added nft_range_eval() function handles the two possible nft range operations, but as the compiler warning points out, any unexpected value would lead to the 'mismatch' variable being used without being initialized: net/netfilter/nft_range.c: In function 'nft_range_eval':

[PATCH 19/28] brcmfmac: avoid maybe-uninitialized warning in brcmf_cfg80211_start_ap

A bugfix added a sanity check around the assignment and use of the 'is_11d' variable, which looks correct to me, but as the function is rather complex already, this confuses the compiler to the point where it can no longer figure out if the variable is always initialized correctly:

[PATCH 28/28] Kbuild: bring back -Wmaybe-uninitialized warning

Traditionally, we have always had warnings about uninitialized variables enabled, as this is part of -Wall, and generally a good idea [1], but it also always produced false positives, mainly because this is a variation of the halting problem and provably impossible to get right in all cases [2].

Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

On Mon, 2016-10-17 at 18:47 -0400, Sowmini Varadhan wrote: > On (10/17/16 15:37), Jeff Kirsher wrote: > > > Reviewed-by: Alexander Duyck > >  > > Sowmini, can you re-submit this to intel-wired-lan but without the RFC > in > > the title? > > V4 resubmitted.. I think I

Re: [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

On 10/17/16 6:21 AM, Stephen Hemminger wrote: > > No if/else needed. No cast of void * ptr need. Use const if possible? > so much of the stack does not use const and trying to add it for this API does not work -- the upper or lower device is passed to the callbacks and those callbacks invoke

[PATCH 1/1] net: vlan: Use sizeof instead of literal number

From: Gao Feng Use sizeof variable instead of literal number to enhance the readability. Signed-off-by: Gao Feng --- net/8021q/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index

[PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number

From: Gao Feng Use sizeof variable instead of literal number to enhance the readability. Signed-off-by: Gao Feng --- net/8021q/vlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index

Re: [PATCH 1/1] net: vlan: Use sizeof instead of literal number

On Tue, Oct 18, 2016 at 8:44 AM, wrote: > From: Gao Feng > > Use sizeof variable instead of literal number to enhance the readability. > > Signed-off-by: Gao Feng > --- > net/8021q/vlan.c | 4 ++-- > 1 file changed, 2 insertions(+), 2

Re: [PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number

It never makes sense to send the same patch for both net and net-next. If it's a bug fix, it goes to 'net'. And it will be eventually be naturally merged into 'net-next'. Otherwise, if it's a new feature, cleanup, or optimization it goes to 'net-next'.

Re: [PATCH net-next 1/1] net: vlan: Use sizeof instead of literal number

Hi David, On Tue, Oct 18, 2016 at 9:36 AM, David Miller wrote: > > It never makes sense to send the same patch for both net and net-next. > > If it's a bug fix, it goes to 'net'. And it will be eventually > be naturally merged into 'net-next'. > > Otherwise, if it's a new

[PATCH net-next 09/11] net: Remove all_adj_list and its references

Only direct adjacencies are maintained. All upper or lower devices can be learned via the new walk API which recursively walks the adj_list for upper devices or lower devices. Signed-off-by: David Ahern --- include/linux/netdevice.h | 25 -- net/core/dev.c

[PATCH v3 net-next 00/11] net: Fix netdev adjacency tracking

The netdev adjacency tracking is failing to create proper dependencies for some topologies. For example this topology ++ | myvrf | ++ || | +-+ | | macvlan | | +-+ ||

[PATCH net-next 05/11] IB/ipoib: Flip to new dev walk API

Convert ipoib_get_net_dev_match_addr to the new upper device walk API. This is just a code conversion; no functional change is intended. v2 - removed typecast of data Signed-off-by: David Ahern --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 37

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

Yuchung and Eric, thank you for your comments. It looks like I need to think more about this patch. I was trying to reduce the likelihood of reordering (which seems even more important based on Eric¹s comment on pacing), but it seems like the only way to prevent reordering is to only re-hash

[PATCH net-next] r8152: add new products of Lenovo

Add the following four products of Lenovo and sort the order of the list. VID PID 0x17ef 0x3062 0x17ef 0x3069 0x17ef 0x720c 0x17ef 0x7214 Signed-off-by: Hayes Wang ---

[PATCH net-next 07/11] mlxsw: Flip to the new dev walk API

Convert mlxsw users to new dev walk API. This is just a code conversion; no functional change is intended. Signed-off-by: David Ahern --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 37 -- 1 file changed, 23 insertions(+), 14 deletions(-)

[PATCH net-next 08/11] rocker: Flip to the new dev walk API

Convert rocker to the new dev walk API. This is just a code conversion; no functional change is intended. v2 - removed typecast of data Signed-off-by: David Ahern --- drivers/net/ethernet/rocker/rocker_main.c | 31 --- 1 file changed, 24

[PATCH net-next 11/11] net: dev: Improve debug statements for adjacency tracking

Adjacency code only has debugs for the insert case. Add debugs for the remove path and make both consistently worded to make it easier to follow the insert and removal with reference counts. In addition, change the BUG to a WARN_ON. A missing adjacency at removal time is not cause for a panic.

[PATCH net-next 04/11] IB/core: Flip to the new dev walk API

Convert rdma_is_upper_dev_rcu, handle_netdev_upper and ipoib_get_net_dev_match_addr to the new upper device walk API. This is just a code conversion; no functional change is intended. v2 - removed typecast of data Signed-off-by: David Ahern ---

[PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

This patch introduces netdev_walk_all_upper_dev_rcu, netdev_walk_all_lower_dev and netdev_walk_all_lower_dev_rcu. These functions recursively walk the adj_list of devices to determine all upper and lower devices. The functions take a callback function that is invoked for each device in the list.

[PATCH net-next 03/11] net: bonding: Flip to the new dev walk API

Convert alb_send_learning_packets and bond_has_this_ip to use the new netdev_walk_all_upper_dev_rcu API. In both cases this is just a code conversion; no functional change is intended. v2 - removed typecast of data and simplified bond_upper_dev_walk Signed-off-by: David Ahern

[PATCH net-next 01/11] net: Remove refnr arg when inserting link adjacencies

Commit 93409033ae65 ("net: Add netdev all_adj_list refcnt propagation to fix panic") propagated the refnr to insert and remove functions tracking the netdev adjacency graph. However, for the insert path the refnr can only be 1. Accordingly, remove the refnr argument to make that clear. ie., the

[PATCH net-next 06/11] ixgbe: Flip to the new dev walk API

Convert ixgbe users to new dev walk API. This is just a code conversion; no functional change is intended. Signed-off-by: David Ahern --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 132 -- 1 file changed, 82 insertions(+), 50 deletions(-)

[PATCH net-next 10/11] net: Add warning if any lower device is still in adjacency list

Lower list should be empty just like upper. Signed-off-by: David Ahern --- net/core/dev.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index a9fe14908b44..c6bbf310d407 100644 --- a/net/core/dev.c +++

Re: [PATCH net-next] tcp: Change txhash on some non-RTO retransmits

On Mon, Oct 17, 2016 at 8:35 PM, Lawrence Brakmo wrote: > Yuchung and Eric, thank you for your comments. > > It looks like I need to think more about this patch. I was trying > to reduce the likelihood of reordering (which seems even more > important based on Eric¹s comment on

Re: [patch net-next RFC 4/6] Introduce sample tc action

On 10/17/16, 5:17 PM, Roopa Prabhu wrote: > On 10/17/16, 3:10 AM, Jamal Hadi Salim wrote: [snip] inline below more data/context.. + +struct sample_packet_metadata { +int sample_size; +int orig_size; +int ifindex; +}; + >>> This metadata does not

Useless debug warning "netlink: 16 bytes leftover after parsing attributes"

Hi, so lately I am seeing a bunch of these warnings: netlink: 16 bytes leftover after parsing attributes.. While they give you the process name, they are still useless to track down the message that causes them. I find them even more useless since an updated userspace on an older kernel can

Re: [PATCH 00/28] Reenable maybe-uninitialized warnings

On Tue, Oct 18, 2016 at 12:03:28AM +0200, Arnd Bergmann wrote: > This is a set of patches that I hope to get into v4.9 in some form > in order to turn on the -Wmaybe-uninitialized warnings again. Hi Arnd, I jsut complained to Geert that I was introducing way to many bugs or pointless warnings

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

+linux-pci On Mon, Oct 17, 2016 at 08:39:40AM -0700, Alexander Duyck wrote: > On Mon, Oct 17, 2016 at 8:00 AM, Koehrer Mathias (ETAS/ESW5) > wrote: > > Hi Julia! > >> > > Have you tested on a vanilla (non-RT) kernel? I doubt there is > >> > > anything RT specific about

Re: [PATCH 1/9] ipv6: implement dataplane support for rthdr type 4 (Segment Routing Header)

On Mon, Oct 17, 2016 at 7:42 AM, David Lebrun wrote: > Implement minimal support for processing of SR-enabled packets > as described in > https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-02. > > This patch implements the following operations: > -

RE: [ANNOUNCE] bridge-utils 1.6 release

Hi, Alexander, >This link seems to be broken. Seems that it should be: https://www.kernel.org/pub/linux/utils/net/bridge-utils/bridge-utils-1.6.tar.gz Instead of: > > http://www.kernel.org/pub/linux/utils/net/bridge-utils/bridge-utils.1.6.tar.gz Regards, Rami Rosen Intel Corporation

Re: Kernel 4.6.7-rt13: Intel Ethernet driver igb causes huge latencies in cyclictest

On Sat, Oct 15, 2016 at 12:06:33AM +0200, Richard Cochran wrote: > On Fri, Oct 14, 2016 at 08:58:22AM +, Koehrer Mathias (ETAS/ESW5) wrote: > > @@ -753,7 +756,9 @@ u32 igb_rd32(struct e1000_hw *hw, u32 re > > if (E1000_REMOVED(hw_addr)) > > return ~value; > > > > +

Re: [Intel-wired-lan] [PATCH V2 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

On Mon, Oct 17, 2016 at 10:25 AM, Sowmini Varadhan wrote: > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be > passed down an sk_buff that has the network and transport > header in the paged data, so it needs to make sure these > headers are available in the

[PATCH net] soreuseport: do not export reuseport_add_sock()

From: Eric Dumazet reuseport_add_sock() is not used from a module, no need to export it. Signed-off-by: Eric Dumazet --- net/core/sock_reuseport.c |1 - 1 file changed, 1 deletion(-) diff --git a/net/core/sock_reuseport.c

[PATCH 27/28] rocker: fix maybe-uninitialized warning

In some rare configurations, we get a warning about the 'index' variable being used without an initialization: drivers/net/ethernet/rocker/rocker_ofdpa.c: In function ‘ofdpa_port_fib_ipv4.isra.16.constprop’: drivers/net/ethernet/rocker/rocker_ofdpa.c:2425:92: warning: ‘index’ may be used

Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

On Mon, 2016-10-17 at 15:29 -0700, Alexander Duyck wrote: > On Mon, Oct 17, 2016 at 2:12 PM, Sowmini Varadhan > wrote: > > > > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be > > passed down an sk_buff that has the network and transport > > header in the

Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

On Mon, Oct 17, 2016 at 2:12 PM, Sowmini Varadhan wrote: > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be > passed down an sk_buff that has the network and transport > header in the paged data, so it needs to make sure these > headers are available in the

[PATCH 21/28] net/hyperv: avoid uninitialized variable

The hdr_offset variable is only if we deal with a TCP or UDP packet, but as the check surrounding its usage tests for skb_is_gso() instead, the compiler has no idea if the variable is initialized or not at that point: drivers/net/hyperv/netvsc_drv.c: In function ‘netvsc_start_xmit’:

[PATCH 20/28] net: bcm63xx: avoid referencing uninitialized variable

gcc found a reference to an uninitialized variable in the error handling of bcm_enet_open, introduced by a recent cleanup: drivers/net/ethernet/broadcom/bcm63xx_enet.c: In function 'bcm_enet_open' drivers/net/ethernet/broadcom/bcm63xx_enet.c:1129:2: warning: 'phydev' may be used uninitialized in

Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers

On (10/17/16 15:37), Jeff Kirsher wrote: > > Reviewed-by: Alexander Duyck > > Sowmini, can you re-submit this to intel-wired-lan but without the RFC in > the title? V4 resubmitted.. I think I just inadvertently forgot to add Alex as the reviewed-by.. could you

[PATCH 1/2] dwc_eth_qos: do not clear pause flags from phy_device->supported

From: Niklas Cassel phy_device->supported is originally set by the PHY driver. The ethernet driver should filter phy_device->supported to only contain flags supported by the IP. The IP supports setting rx and tx flow control independently, therefore SUPPORTED_Pause and

[PATCH 2/2] dwc_eth_qos: enable flow control by default

From: Niklas Cassel Allow autoneg to enable flow control by default. The behavior when autoneg is off has not changed. Signed-off-by: Niklas Cassel Signed-off-by: Lars Persson --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 1

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

Hi Andrew, Thank you for code review and valuable comments. On Wed, Sep 28, 2016 at 10:24:51PM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > + reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL); > > + if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) { > > + reg_val

Re: [PATCH net-next 2/2] net: phy: Add Fast Link Failure - 2 set driver for Microsemi PHYs.

On October 17, 2016 1:13:14 AM PDT, Raju Lakkaraju wrote: >Hi Andrew, > >Thank you for code review and comments. > >On Fri, Oct 14, 2016 at 02:02:28PM +0200, Andrew Lunn wrote: >> EXTERNAL EMAIL >> >> >> > On Fri, Oct 14, 2016 at 05:10:33PM +0530, Raju Lakkaraju

Re: [PATCH net-next 02/11] net: Introduce new api for walking upper and lower devices

On Fri, 14 Oct 2016 18:28:42 -0700 David Ahern wrote: > > /** > + * netdev_has_upper_dev_all - Check if device is linked to an upper device > + * @dev: device > + * @upper_dev: upper device to check > + * > + * Find out if a device is linked to specified upper device

[PATCH net-next 1/2] bpf: add various tests around spill/fill of regs

Add several spill/fill tests. Besides others, one that performs xadd on the spilled register, one ldx/stx test where different types are spilled from two branches and read out from common path. Verfier does handle all correctly. Signed-off-by: Daniel Borkmann ---

[PATCH net-next v12 2/9] openvswitch: add mac_proto field to the flow key

Use a hole in the structure. We support only Ethernet so far and will add a support for L2-less packets shortly. We could use a bool to indicate whether the Ethernet header is present or not but the approach with the mac_proto field is more generic and occupies the same number of bytes in the

[PATCH net-next v12 3/9] openvswitch: pass mac_proto to ovs_vport_send

We'll need it to alter packets sent to ARPHRD_NONE interfaces. Change do_output() to use the actual L2 header size of the packet when deciding on the minimum cutlen. The assumption here is that what matters is not the output interface hard_header_len but rather the L2 header of the particular

[PATCH net-next v12 9/9] openvswitch: use ipgre tunnel rather than gretap tunnel

From: Simon Horman This allows GRE tunnels to send and receive both layer 2 packets (packets with an ethernet header) and layer 3 packets (packets without an ethernet header). Signed-off-by: Simon Horman Signed-off-by: Jiri Benc

Re: [PATCH iproute2] devlink: Convert conditional in dl_argv_handle_port() to switch()

On Sun, 9 Oct 2016 10:14:18 +0800 Hangbin Liu wrote: > Discovered by Phil's covscan. The final return statement is never reached. > This is not inherently clear from looking at the code, so change the > conditional to a switch() statement which should clarify this. > >

[PATCH net-next v12 1/9] openvswitch: use hard_header_len instead of hardcoded ETH_HLEN

On tx, use hard_header_len while deciding whether to refragment or drop the packet. That way, all combinations are calculated correctly: * L2 packet going to L2 interface (the L2 header len is subtracted), * L2 packet going to L3 interface (the L2 header is included in the packet lenght), * L3

[PATCH net-next v12 7/9] openvswitch: add Ethernet push and pop actions

It's not allowed to push Ethernet header in front of another Ethernet header. It's not allowed to pop Ethernet header if there's a vlan tag. This preserves the invariant that L3 packet never has a vlan tag. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab

[PATCH net-next v12 8/9] openvswitch: allow L3 netdev ports

Allow ARPHRD_NONE interfaces to be added to ovs bridge. Based on previous versions by Lorand Jakab and Simon Horman. Signed-off-by: Lorand Jakab Signed-off-by: Simon Horman Signed-off-by: Jiri Benc ---

[PATCH net-next v12 6/9] openvswitch: netlink: support L3 packets

Extend the ovs flow netlink protocol to support L3 packets. Packets without OVS_KEY_ATTR_ETHERNET attribute specify L3 packets; for those, the OVS_KEY_ATTR_ETHERTYPE attribute is mandatory. Push/pop vlan actions are only supported for Ethernet packets. Based on previous versions by Lorand Jakab

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

Hi Florian/Andrew, Thank you for review comments. On Thu, Oct 06, 2016 at 03:57:32AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 09/28/2016 01:24 PM, Andrew Lunn wrote: > >> static int vsc85xx_wol_set(struct phy_device *phydev, > >> struct ethtool_wolinfo

Re: [PATCH iproute2] bridge: add support for the multicast flood flag

On Thu, 13 Oct 2016 17:54:20 +0200 Nikolay Aleksandrov wrote: > Recently a new per-port flag was added which controls the flooding of > unknown multicast, this patch adds support for controlling it via iproute2. > It also updates the man pages with information about

Re: [PATCH net-next 2/2] net: phy: Add PHY Auto/Mdi/Mdix set driver for Microsemi PHYs.

Hi Florian/Andrew, Thank you for review comments. On Thu, Oct 06, 2016 at 04:09:56AM -0700, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 10/05/2016 12:18 AM, Andrew Lunn wrote: > + phydev->mdix = ETH_TP_MDI_AUTO; > >>> > >>> Humm, interesting. The only other driver supporting

[PATCH net-next v12 0/9] openvswitch: support for layer 3 encapsulated packets

At the core of this patch set is removing the assumption in Open vSwitch datapath that all packets have Ethernet header. Support for layer 3 GRE tunnels is also added by this patchset. The implementation relies on the presence of pop_eth and push_eth actions in datapath flows to facilitate adding

[PATCH net-next v12 4/9] openvswitch: support MPLS push and pop for L3 packets

Update Ethernet header only if there is one. Signed-off-by: Jiri Benc --- net/openvswitch/actions.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index dc8bb97e2258..064cbcb7b0c5

[PATCH net-next v12 5/9] openvswitch: add processing of L3 packets

Support receiving, extracting flow key and sending of L3 packets (packets without an Ethernet header). Note that even after this patch, non-Ethernet interfaces are still not allowed to be added to bridges. Similarly, netlink interface for sending and receiving L3 packets to/from user space is not

Re: [PATCH 4/7] net: qcom/emac: Fix module autoload for OF registration

Javier Martinez Canillas wrote: If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro.

  1   2   3   >