Re: ss issue on arm not showing UDP listening ports

2018-02-22 Thread Guillaume Nault
On Wed, Feb 21, 2018 at 07:59:24PM -0600, Jesse Cooper wrote: > Thank you for the suggestions. This is on a raspberry pi 3 not sure if > that fact matters. I will notify Raspbian of the issue. > Does your kernel have CONFIG_INET_UDP_DIAG?

Re: [PATCH net-next v2 1/1] net: Allow a rule to track originating protocol

2018-02-22 Thread Ido Schimmel
Hi Donald, On Tue, Feb 20, 2018 at 08:55:58AM -0500, Donald Sharp wrote: > Allow a rule that is being added/deleted/modified or > dumped to contain the originating protocol's id. > > The protocol is handled just like a routes originating > protocol is. This is especially useful because there >

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-22 Thread Jiri Pirko
Wed, Feb 21, 2018 at 09:57:09PM CET, alexander.du...@gmail.com wrote: >On Wed, Feb 21, 2018 at 11:38 AM, Jiri Pirko wrote: >> Wed, Feb 21, 2018 at 06:56:35PM CET, alexander.du...@gmail.com wrote: >>>On Wed, Feb 21, 2018 at 8:58 AM, Jiri Pirko wrote: Wed,

Re: syzcaller patch postings...

2018-02-22 Thread Paolo Abeni
On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote: > I have to mention this now before it gets out of control. > > I would like to ask that syzkaller stop posting the patch it is > testing when it posts to netdev. There is an open issue on this topic:

Re: WARNING: refcount bug in sock_wfree

2018-02-22 Thread Xin Long
On Wed, Feb 21, 2018 at 9:59 PM, syzbot wrote: > Hello, > > syzbot hit the following crash on upstream commit > 79c0ef3e85c015b0921a8fd5dd539d1480e9cd6c (Mon Feb 19 19:58:19 2018 +) > Merge

Re: [PATCH net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-22 Thread Ido Schimmel
Hi David, On Wed, Feb 21, 2018 at 10:49:52AM -0800, David Ahern wrote: > Some operators prefer IPv6 path selection to use a standard 5-tuple > hash rather than just an L3 hash with the flow the label. To that end > add support to IPv6 for multipath hash policy similar to bf4e0a3db97eb > ("net:

[PATCH net] net: aquantia: Fix error handling in aq_pci_probe()

2018-02-22 Thread Dan Carpenter
We should check "self->aq_hw" for allocation failure, and also we should free it on the error paths. Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c

Re: [PATCH net v2 2/2] tuntap: correctly add the missing xdp flush

2018-02-22 Thread Jason Wang
On 2018年02月22日 15:54, Sergei Shtylyov wrote: Hello! On 2/22/2018 9:24 AM, Jason Wang wrote: Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds

Re: syzcaller patch postings...

2018-02-22 Thread Dmitry Vyukov
On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote: > On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote: >> I have to mention this now before it gets out of control. >> >> I would like to ask that syzkaller stop posting the patch it is >> testing when it posts to netdev. >

Re: [PATCH bpf] bpf, x64: implement retpoline for tail call

2018-02-22 Thread Daniel Borkmann
On 02/22/2018 04:53 AM, Eric Dumazet wrote: > On Wed, 2018-02-21 at 19:43 -0800, Alexei Starovoitov wrote: >> On Wed, Feb 21, 2018 at 07:04:02PM -0800, Eric Dumazet wrote: >>> On Thu, 2018-02-22 at 01:05 +0100, Daniel Borkmann wrote: >>> >>> ... >>> +/* Instead of plain jmp %rax, we emit a

Re: [PATCH iproute2 0/7] Add support for devlink resource abstraction

2018-02-22 Thread Arkadi Sharshevsky
On 02/15/2018 05:41 AM, David Ahern wrote: > On 2/14/18 1:55 AM, Arkadi Sharshevsky wrote: >> Add support for devlink resource abstraction. >> >> Arkadi Sharshevsky (7): >> devlink: Change empty line indication with indentations >> devlink: mnlg: Add support for extended ack >> devlink:

Re: Qualcomm rmnet driver and qmi_wwan

2018-02-22 Thread Daniele Palmas
Hi Subash, 2018-02-21 20:47 GMT+01:00 Subash Abhinov Kasiviswanathan : > On 2018-02-21 04:38, Daniele Palmas wrote: >> >> Hello, >> >> in rmnet kernel documentation I read: >> >> "This driver can be used to register onto any physical network device in >> IP mode. Physical

Your Consent

2018-02-22 Thread Mr.Lee
Important details to share with you, kindly email me for info: "peter.waddell...@gmail.com" Peter

[PATCH net v3 1/2] Revert "tuntap: add missing xdp flush"

2018-02-22 Thread Jason Wang
This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The reason is we try to batch packets for devmap which causes calling xdp_do_flush() in the process context. Simply disabling preemption may not work since process may move among processors which lead xdp_do_flush() to miss some flushes

[PATCH net v3 2/2] tuntap: correctly add the missing xdp flush

2018-02-22 Thread Jason Wang
Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or MSG_MORE is clear. This may lead to BUG() since xdp_do_flush() was called in the process

Re: syzcaller patch postings...

2018-02-22 Thread Florian Westphal
Dmitry Vyukov wrote: > On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote: > > On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote: > >> I have to mention this now before it gets out of control. > >> > >> I would like to ask that syzkaller stop posting

My Dear Friend.

2018-02-22 Thread abudu hassan
My Dear Friend. I have a transaction deal of (US$18mllion US Dollars). Contact me for more info. regard.Mr Abudu Hassan

Re: syzcaller patch postings...

2018-02-22 Thread Dmitry Vyukov
On Thu, Feb 22, 2018 at 11:03 AM, Florian Westphal wrote: > Dmitry Vyukov wrote: >> On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote: >> > On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote: >> >> I have to mention this now before it

Re: syzcaller patch postings...

2018-02-22 Thread Daniel Axtens
Dmitry Vyukov writes: > On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote: >> On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote: >>> I have to mention this now before it gets out of control. >>> >>> I would like to ask that syzkaller stop posting the

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-22 Thread Sowmini Varadhan
On (02/21/18 19:39), Willem de Bruijn wrote: > >> By the way, the put_cmsg is unconditional even if the caller did > >> not supply msg_control. So it is basically no longer safe to ever > >> call read, recv or recvfrom on a socket if zerocopy notifications > >> are outstanding. > > > > Wait, I

Re: syzcaller patch postings...

2018-02-22 Thread Dmitry Vyukov
On Thu, Feb 22, 2018 at 2:31 PM, Daniel Axtens wrote: > Dmitry Vyukov writes: > >> On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote: >>> On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote: I have to mention this now before it

[PATCH iproute2-next v3 2/8] iplink: Correctly report error when network device isn't found

2018-02-22 Thread Serhey Popovych
Distinguish cases when "dev" parameter isn't given from cases where no network device corresponding to "dev" is found. Do not check for index validity in xdp_parse(): caller should take care of this because has more information (e.g. when "dev" is given or not found) for this. Signed-off-by:

[PATCH iproute2-next v3 8/8] iplink: Reduce number of arguments to iplink_parse()

2018-02-22 Thread Serhey Popovych
Introduce new @struct iplink_parse_args data structure to consolidate arguments to iplink_parse(). This will reduce number of arguments passed to it. Pass this data structure to ->parse_opt() in iplink specific modules: it may be used to get network device name and other information.

[PATCH iproute2-next v3 7/8] iplink: Move data structures to block of their users

2018-02-22 Thread Serhey Popovych
This will consolidate data and code using it in single place and prepare for upcoming ->parse_opt() method change. Signed-off-by: Serhey Popovych --- ip/link_gre.c| 32 ip/link_gre6.c | 32

[PATCH iproute2-next v3 4/8] iplink: Follow documented behaviour when "index" is given

2018-02-22 Thread Serhey Popovych
Both ip-link(8) and error message when "index" parameter is given for set/delete case says that index can only be given during network device creation. Follow this documented behaviour and get rid of ambiguous behaviour in case of both "dev" and "index" specified for ip link delete scenario

[PATCH iproute2-next v3 0/8] iplink: Improve iplink_parse()

2018-02-22 Thread Serhey Popovych
This is main routine to parse ip-link(8) configuration parameters. Main reason to improve it is to pass network device @name, @dev and other parameters to kind specific ->parse_opt() function so they can use this information. For example later we will extend iplink_get() to parse netlink

[PATCH iproute2-next v3 5/8] veth,vxcan: Save/reinitialize/restore whole @struct ifinfomsg

2018-02-22 Thread Serhey Popovych
Now in iplink_parse() we use ->ifi_change and ->ifi_flags fields and plan to use ->ifi_index with upcoming change. Saving, restoring and reinitializing individual fields is error prone: using new field in iplink_parse() without updating callers in veth and vxcan will overwrite main device

[PATCH iproute2-next v3 6/8] iplink: Perform most of request buffer setups and checks in iplink_parse()

2018-02-22 Thread Serhey Popovych
To benefit other users (e.g. link_veth.c) of iplink_parse() from additional attribute checks and setups made in iplink_modify(). This catches most of weired cobination of parameters to peer device configuration. Drop @link, @group and @index from iplink_parse() parameters list: they are not

[PATCH iproute2-next v3 1/8] utils: Introduce and use nodev() helper routine

2018-02-22 Thread Serhey Popovych
There is a couple of places where we report error in case of no network device is found. In all of them we output message in the same format to stderr and either return -1 or 1 to the caller or exit with -1. Introduce new helper function nodev() that takes name of the network device caused error

[PATCH iproute2-next v3 3/8] iplink: Use "dev" and "name" parameters interchangeable when possible

2018-02-22 Thread Serhey Popovych
Both of them accept network device name as argument, but have different meaning: dev - is a device by it's name, name - name for specific device. The only case where they treated separately is network device rename case where need to specify both ifindex and new name. In rest of the cases

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-22 Thread Jiri Pirko
Thu, Feb 22, 2018 at 12:54:45PM CET, gerlitz...@gmail.com wrote: >On Thu, Feb 22, 2018 at 10:11 AM, Jiri Pirko wrote: >> Wed, Feb 21, 2018 at 09:57:09PM CET, alexander.du...@gmail.com wrote: > >>>The signaling isn't too much of an issue since we can just tweak the >>>link state

Re: [PATCH bpf] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread Eric Dumazet
On Wed, 2018-02-21 at 22:38 -0800, Yonghong Song wrote: > Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback > function") > fixed a memory leak and removed unnecessary locks in map_free callback > function. > Unfortrunately, it introduced a lockdep warning. When lockdep

[PATCH] dsa: ptp; mark dummy helpers as 'inline'

2018-02-22 Thread Arnd Bergmann
Declaring a static function in a header leads to a warning every time that header gets included without the function being used: In file included from drivers/net/dsa/mv88e6xxx/chip.c:42: drivers/net/dsa/mv88e6xxx/ptp.h:92:13: error: 'mv88e6xxx_hwtstamp_work' defined but not used

Re: [RFC][PATCH bpf v2 1/2] bpf: allow 64-bit offsets for bpf function calls

2018-02-22 Thread Michael Holzheu
Am Thu, 22 Feb 2018 13:06:40 +0100 schrieb Michael Holzheu : > Am Fri, 16 Feb 2018 21:20:09 +0530 > schrieb "Naveen N. Rao" : > > > Daniel Borkmann wrote: > > > On 02/15/2018 05:25 PM, Daniel Borkmann wrote: > > >> On 02/13/2018 05:05

Re: [PATCH] dsa: ptp; mark dummy helpers as 'inline'

2018-02-22 Thread Andrew Lunn
On Thu, Feb 22, 2018 at 12:44:40PM +0100, Arnd Bergmann wrote: > Declaring a static function in a header leads to a warning every > time that header gets included without the function being used: > > In file included from drivers/net/dsa/mv88e6xxx/chip.c:42: >

Re: [PATCH net-next 6/7] mlxsw: spectrum_router: Add support for ipv6 hash policy update

2018-02-22 Thread Ido Schimmel
On Wed, Feb 21, 2018 at 10:49:53AM -0800, David Ahern wrote: > Similar to 28678f07f127d ("mlxsw: spectrum_router: Update multipath hash > parameters upon netevents") for IPv4, make sure the kernel and asic are > using the same hash algorithm for path selection. > > Signed-off-by: David Ahern

Re: nft/bpf interpreters and spectre2. Was: [PATCH RFC 0/4] net: add bpfilter

2018-02-22 Thread Pablo Neira Ayuso
Hi Alexei, On Wed, Feb 21, 2018 at 06:20:37PM -0800, Alexei Starovoitov wrote: > On Wed, Feb 21, 2018 at 01:13:03PM +0100, Florian Westphal wrote: > > > > Obvious candidates are: meta, numgen, limit, objref, quota, reject. > > > > We should probably also consider removing > >

Re: [RFC][PATCH bpf v2 1/2] bpf: allow 64-bit offsets for bpf function calls

2018-02-22 Thread Michael Holzheu
Am Fri, 16 Feb 2018 21:20:09 +0530 schrieb "Naveen N. Rao" : > Daniel Borkmann wrote: > > On 02/15/2018 05:25 PM, Daniel Borkmann wrote: > >> On 02/13/2018 05:05 AM, Sandipan Das wrote: > >>> The imm field of a bpf_insn is a signed 32-bit integer. For > >>> JIT-ed

[PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-22 Thread Zong Li
Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig to ease disabling it all")', the make kselftest-merge cannot merge the config dependencies of kselftest to the existing .config file. These config dependencies of kselftest need to enable the 'CONFIG_RUNTIME_TESTING_MENU=y' at

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-22 Thread Or Gerlitz
On Thu, Feb 22, 2018 at 10:11 AM, Jiri Pirko wrote: > Wed, Feb 21, 2018 at 09:57:09PM CET, alexander.du...@gmail.com wrote: >>The signaling isn't too much of an issue since we can just tweak the >>link state of the VF or virtio manually to report the link up or down >>prior to

[Crypto v7 10/12] chtls: Inline crypto request Tx/Rx

2018-02-22 Thread Atul Gupta
TLS handler for record transmit and receive. Create Inline TLS work request and post to FW. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 1867 +++ 1 file changed, 1867 insertions(+) create mode 100644

[Crypto v7 05/12] cxgb4: Inline TLS FW Interface

2018-02-22 Thread Atul Gupta
Key area size in hw-config file. CPL struct for TLS request and response. Work request for Inline TLS. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 121 ++- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 +

[RFC PATCH V2] virtio_pci: Add SR-IOV support

2018-02-22 Thread Mark Rustad
Hardware-realized virtio-pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio-net PF and virtio-net VFs. These are hardware realizations of what has been up to now been a software interface. The device in

[Crypto v7 11/12] chtls: Register chtls Inline TLS with net tls

2018-02-22 Thread Atul Gupta
Register chtls as Inline TLS driver, chtls is ULD to cxgb4. Setsockopt to program (tx/rx) keys on chip. Support AES GCM of key size 128. Support both Inline Rx and Tx. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 600

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-22 Thread Denys Fedoryshchenko
On 2018-02-22 20:30, Guillaume Nault wrote: On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote: On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: >> On 2018-02-15 17:55, Guillaume Nault

Re: [RFC PATCH V2] virtio_pci: Add SR-IOV support

2018-02-22 Thread Christoph Hellwig
Can we move this into common code as a a generic_sriov_configure helper? Nothing is really virtio specific, and it seems like some other drivers could also use it, e.g. ena or nvme.

Re: ss issue on arm not showing UDP listening ports

2018-02-22 Thread jesse_cooper
Quoting Guillaume Nault : On Wed, Feb 21, 2018 at 07:59:24PM -0600, Jesse Cooper wrote: Thank you for the suggestions. This is on a raspberry pi 3 not sure if that fact matters. I will notify Raspbian of the issue. Does your kernel have CONFIG_INET_UDP_DIAG? grep

Re: [PATCH net v3 2/2] tuntap: correctly add the missing xdp flush

2018-02-22 Thread Jesper Dangaard Brouer
On Thu, 22 Feb 2018 17:36:46 +0800 Jason Wang wrote: > Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the > devmap stall caused by missed xdp flush by counting the pending xdp > redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or > MSG_MORE

Re: [PATCH v2 iproute2-next 1/3] ip: Use the `struct fib_rule_hdr` for rules

2018-02-22 Thread David Ahern
On 2/21/18 7:12 PM, Donald Sharp wrote: > @@ -577,21 +585,20 @@ static int iprule_modify(int cmd, int argc, char **argv) > __u32 tid = 0; > struct { > struct nlmsghdr n; > - struct rtmsgr; > + struct fib_rule_hdr frh; >

Re: [for-next 7/7] IB/mlx5: Implement fragmented completion queue (CQ)

2018-02-22 Thread Jason Gunthorpe
On Wed, Feb 21, 2018 at 12:13:54PM -0800, Saeed Mahameed wrote: > From: Yonatan Cohen > > The current implementation of create CQ requires contiguous > memory, such requirement is problematic once the memory is > fragmented or the system is low in memory, it causes for >

[Crypto v7 09/12] chtls: CPL handler definition

2018-02-22 Thread Atul Gupta
CPL handlers for TLS session, record transmit and receive. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2041 +++ net/ipv4/tcp_minisocks.c|1 + 2 files changed, 2042 insertions(+) create mode

[Crypto v7 07/12] chcr: Key Macro

2018-02-22 Thread Atul Gupta
Define macro for TLS Key context Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.h | 42 + drivers/crypto/chelsio/chcr_core.h | 55 +- 2 files changed, 96 insertions(+), 1 deletion(-) diff

[Crypto v7 04/12] chtls: structure and macro definiton

2018-02-22 Thread Atul Gupta
Inline TLS state, connection management. Supporting macros definition. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h| 487 drivers/crypto/chelsio/chtls/chtls_cm.h | 202 + 2 files changed, 689

[Crypto v7 03/12] tls: support for inline tls

2018-02-22 Thread Atul Gupta
Facility to register Inline TLS drivers to net/tls. Setup TLS_FULL_HW prot to listen on offload device. Cases handled 1. Inline TLS device exists, setup prot for TLS_FULL_HW 2. Atleast one Inline TLS exists, sets TLS_FULL_HW. If non-inline capable device establish connection, move to TLS_SW_TX 3.

Re: [PATCH bpf v2] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread Eric Dumazet
On Thu, 2018-02-22 at 10:10 -0800, Yonghong Song wrote: > Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback > function") > fixed a memory leak and removed unnecessary locks in map_free callback > function. > Unfortrunately, it introduced a lockdep warning. When lockdep

Re: [PATCH bpf v2] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread David Miller
From: Yonghong Song Date: Thu, 22 Feb 2018 10:10:35 -0800 > Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback > function") > fixed a memory leak and removed unnecessary locks in map_free callback > function. > Unfortrunately, it introduced a lockdep warning.

Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-22 Thread Eric Dumazet
On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote: ... > > This code is old, so Cc stable to make sure that we don't get the warning > for older kernels built with new gcc. > > Cc: sta...@vger.kernel.org This part makes little sense to me for two reasons. 1) David Miller handles stable

[RFC PATCH] lan743x: lan743x_csr_read() can be static

2018-02-22 Thread kbuild test robot
Fixes: 896121de80db ("lan743x: Add main source files for new lan743x driver") Signed-off-by: Fengguang Wu --- lan743x_main.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread kbuild test robot
Hi Bryan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Bryan-Whitehead/lan743x-Add-new-lan743x-driver/20180222-225510 reproduce: # apt-get install sparse make ARCH=x86_64

Re: nft/bpf interpreters and spectre2. Was: [PATCH RFC 0/4] net: add bpfilter

2018-02-22 Thread Alexei Starovoitov
On Thu, Feb 22, 2018 at 12:39:15PM +0100, Pablo Neira Ayuso wrote: > Hi Alexei, > > On Wed, Feb 21, 2018 at 06:20:37PM -0800, Alexei Starovoitov wrote: > > On Wed, Feb 21, 2018 at 01:13:03PM +0100, Florian Westphal wrote: > > > > > > Obvious candidates are: meta, numgen, limit, objref, quota,

[PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-22 Thread Arnd Bergmann
gcc-8 has a new warning that detects overlapping input and output arguments in memcpy(). It triggers for sit_init_net() calling ipip6_tunnel_clone_6rd(), which is actually correct: net/ipv6/sit.c: In function 'sit_init_net': net/ipv6/sit.c:192:3: error: 'memcpy' source argument is the same as

[PATCH] bpf: add schedule points in percpu arrays management

2018-02-22 Thread Eric Dumazet
From: Eric Dumazet syszbot managed to trigger RCU detected stalls in bpf_array_free_percpu() It takes time to allocate a huge percpu map, but even more time to free it. Since we run in process context, use cond_resched() to yield cpu if needed. Fixes: a10423b87a7e ("bpf:

Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-22 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 5:40 PM, Eric Dumazet wrote: > On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote: > > ... >> >> This code is old, so Cc stable to make sure that we don't get the warning >> for older kernels built with new gcc. >> >> Cc: sta...@vger.kernel.org

[PATCH] Remove useless assignment in ip_do_fragment

2018-02-22 Thread C0deAi
Hi my name is Benjamin Bales. I am the founder and creator of CodeAI, the first non-human contributor to your software project. CodeAI finds and fixes security defects for you. It fixed 327. It wants to merge a fix for a useless assignment. To view all 327 fixed issues from the run claim your

[Crypto v7 00/12] Chelsio Inline TLS

2018-02-22 Thread Atul Gupta
Series for Chelsio Inline TLS driver (chtls.ko) Use tls ULP infrastructure to register chtls as Inline TLS driver. Chtls use TCP Sockets to transmit and receive TLS record. TCP proto_ops is extended to offload TLS record. T6 adapter provides the following features: -TLS record offload,

[Crypto v7 02/12] ethtool: enable Inline TLS in HW

2018-02-22 Thread Atul Gupta
Signed-off-by: Atul Gupta --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c | 1 + 2 files changed, 3 insertions(+) diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index db84c51..aacabe2 100644 ---

Re: [PATCH bpf] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread Yonghong Song
On 2/22/18 5:37 AM, Eric Dumazet wrote: On Wed, 2018-02-21 at 22:38 -0800, Yonghong Song wrote: Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback function") fixed a memory leak and removed unnecessary locks in map_free callback function. Unfortrunately, it introduced a

[Crypto v7 01/12] tls: tls_device struct to register TLS drivers

2018-02-22 Thread Atul Gupta
tls_device structure to register Inline TLS drivers with net/tls Signed-off-by: Atul Gupta --- include/net/tls.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/include/net/tls.h b/include/net/tls.h index 4913430..e315bf9 100644 ---

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-22 Thread Guillaume Nault
On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote: > On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault > wrote: > > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: > >> On 2018-02-15 17:55, Guillaume Nault wrote: > >> > On Thu, Feb 15, 2018 at

[PATCH bpf v2] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread Yonghong Song
Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback function") fixed a memory leak and removed unnecessary locks in map_free callback function. Unfortrunately, it introduced a lockdep warning. When lockdep checking is turned on, running

Re: [PATCH net-next v2 1/1] net: Allow a rule to track originating protocol

2018-02-22 Thread David Ahern
On 2/22/18 1:23 AM, Ido Schimmel wrote: >> diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c >> index 98e1066c3d55..c1d4ab5b2d9f 100644 >> --- a/net/core/fib_rules.c >> +++ b/net/core/fib_rules.c >> @@ -51,6 +51,7 @@ int fib_default_rule_add(struct fib_rules_ops *ops, >> r->pref =

[Crypto v7 08/12] chtls: Key program

2018-02-22 Thread Atul Gupta
Program the tx and rx key on chip. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 394 1 file changed, 394 insertions(+) create mode 100644 drivers/crypto/chelsio/chtls/chtls_hw.c diff --git

[Crypto v7 12/12] Makefile Kconfig

2018-02-22 Thread Atul Gupta
Entry for Inline TLS as another driver dependent on cxgb4 and chcr Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/Kconfig| 11 +++ drivers/crypto/chelsio/Makefile | 1 + drivers/crypto/chelsio/chtls/Makefile | 4 3 files changed, 16

[Crypto v7 06/12] cxgb4: LLD driver changes to enable TLS

2018-02-22 Thread Atul Gupta
Read FW capability. Read key area size. Dump the TLS record count. Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32 +--- drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 ++ drivers/net/ethernet/chelsio/cxgb4/sge.c| 98

Re: [PATCH net-next 2/5] net/smc: fix structure size

2018-02-22 Thread David Miller
From: Ursula Braun Date: Wed, 21 Feb 2018 12:32:32 +0100 > diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h > index ab240b37ad11..d2012fd22100 100644 > --- a/net/smc/smc_cdc.h > +++ b/net/smc/smc_cdc.h > @@ -48,7 +48,7 @@ struct smc_cdc_msg { > struct

[PATCH next-queue 1/3] ixgbe: check for 128-bit authentication

2018-02-22 Thread Shannon Nelson
Make sure the Security Association is using a 128-bit authentication, since that's the only size that the hardware offload supports. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 16 +++-

[PATCH next-queue 0/3] ixgbe: ipsec fixups

2018-02-22 Thread Shannon Nelson
These are a couple of updates for the ixgbe IPsec offload support. Shannon Nelson (3): ixgbe: check for 128-bit authentication ixgbe: fix ipsec trailer length ixgbe: remove unneeded ipsec state free callback drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 53 +-

pull-request: mac80211 2018-02-22

2018-02-22 Thread Johannes Berg
Hi Dave, A bunch of fixes, including the nla_put_string() issue just in from Kees. Otherwise nothing really super urgent or interesting. Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit ba804bb4b72e57374b5f567b783aa0298fba0ce6: Merge

Re: pull-request: mac80211-next 2018-02-22

2018-02-22 Thread David Miller
From: Johannes Berg Date: Thu, 22 Feb 2018 21:16:18 +0100 > Wireless is slow ... but we're preparing for HE (802.11ax), > so I guess soon we'll have a big chunk of work coming :-) I wondered where you guys have been hiding :-) > Please pull and let me know if there's

[PATCH net-next] r8169: disable WOL per default

2018-02-22 Thread Heiner Kallweit
Currently, if BIOS enables WOL in the chip, settings are inconsistent because the device isn't marked as wakeup-enabled (if not done explicitly via userspace tools). This causes issues with suspend/ resume because mdio_bus_phy_may_suspend() checks whether device is wakeup-enabled. In detail MDIO

Re: pull-request: mac80211-next 2018-02-22

2018-02-22 Thread Johannes Berg
On Thu, 2018-02-22 at 15:19 -0500, David Miller wrote: > From: Johannes Berg > Date: Thu, 22 Feb 2018 21:16:18 +0100 > > > Wireless is slow ... but we're preparing for HE (802.11ax), > > so I guess soon we'll have a big chunk of work coming :-) > > I wondered where

Re: [PATCH bpf v2] bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 Thread Daniel Borkmann
On 02/22/2018 07:10 PM, Yonghong Song wrote: > Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback > function") > fixed a memory leak and removed unnecessary locks in map_free callback > function. > Unfortrunately, it introduced a lockdep warning. When lockdep checking is >

Re: [PATCH v2 iproute2-next 2/3] ip: Display ip rule protocol used

2018-02-22 Thread David Ahern
On 2/21/18 7:12 PM, Donald Sharp wrote: > diff --git a/ip/iprule.c b/ip/iprule.c > index 00a6c26a..39008768 100644 > --- a/ip/iprule.c > +++ b/ip/iprule.c > @@ -47,6 +47,7 @@ static void usage(void) > "[ iif STRING ] [ oif STRING ] [ pref NUMBER ] [ > l3mdev ]\n" >

Re: [PATCH v2 net-next] net: dsa: mv88e6xxx: scratch registers and external MDIO pins

2018-02-22 Thread David Miller
From: Andrew Lunn Date: Thu, 22 Feb 2018 01:51:49 +0100 > MV88E6352 and later switches support GPIO control through the "Scratch > & Misc" global2 register. Two of the pins controlled this way on the > mv88e6390 family are the external MDIO pins. They can either by used > as part

Re: nla_put_string() vs NLA_STRING

2018-02-22 Thread Johannes Berg
On Tue, 2018-02-20 at 22:00 -0800, Kees Cook wrote: > It seems that in at least one case[1], nla_put_string() is being used > on an NLA_STRING, which lacks a NULL terminator, which leads to > silliness when nla_put_string() uses strlen() to figure out the size: Fun! I'm not a big fan of the

Re: [PATCH net-next 0/3] nfp: build and FW initramfs updates

2018-02-22 Thread David Miller
From: Jakub Kicinski Date: Wed, 21 Feb 2018 19:50:04 -0800 > This set brings empty makefiles to allow building single object files > (useful for build-testing), Kbuild does not cater to this use case > too well. There are two ethernet drivers right now which suffer

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Florian Fainelli
On 02/22/2018 01:31 PM, bryan.whiteh...@microchip.com wrote: >>> +static void lan743x_intr_unregister_isr(struct lan743x_adapter *adapter, >>> + int vector_index) >>> +{ >>> + struct lan743x_vector *vector = >intr.vector_list >>> +

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-22 Thread David Miller
From: David Ahern Date: Wed, 21 Feb 2018 11:16:35 -0700 > On 2/20/18 12:45 AM, Jiri Pirko wrote: >> From: Ido Schimmel >> >> Up until now we only allowed VLAN devices to be put in a VLAN-unaware >> bridge, but some users need the ability to enslave

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-22 Thread David Ahern
On 2/22/18 11:58 AM, David Miller wrote: > From: David Ahern > Date: Wed, 21 Feb 2018 11:16:35 -0700 > >> On 2/20/18 12:45 AM, Jiri Pirko wrote: >>> From: Ido Schimmel >>> >>> Up until now we only allowed VLAN devices to be put in a VLAN-unaware >>>

Re: [PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-22 Thread David Miller
From: David Ahern Date: Wed, 21 Feb 2018 10:49:47 -0800 > Patch 5 adds the L4 hash support. Please address Ido's feedback about how the ports aren't actually being taken into consideration because they aren't present in the flow information being used. Thanks.

Re: [pull request][for-next 0/7] Mellanox, mlx5 shared code updates 2018-02-21

2018-02-22 Thread David Miller
From: Saeed Mahameed Date: Wed, 21 Feb 2018 12:13:47 -0800 > This series includes shared code updates for mlx5 core driver for both > netdev and rdma subsystems. This series should be pulled to both > trees so we can continue netdev and rdma specific submissions separately.

pull-request: mac80211-next 2018-02-22

2018-02-22 Thread Johannes Berg
Hi Dave, Wireless is slow ... but we're preparing for HE (802.11ax), so I guess soon we'll have a big chunk of work coming :-) Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit 91e6dd8284256ef62b43b78da6e7684e4f06ac2f: ipmr: Fix

Re: [PATCH] dsa: ptp; mark dummy helpers as 'inline'

2018-02-22 Thread David Miller
From: Arnd Bergmann Date: Thu, 22 Feb 2018 12:44:40 +0100 > Declaring a static function in a header leads to a warning every > time that header gets included without the function being used: > > In file included from drivers/net/dsa/mv88e6xxx/chip.c:42: >

RE: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Bryan.Whitehead
> > +static void lan743x_intr_unregister_isr(struct lan743x_adapter *adapter, > > + int vector_index) > > +{ > > + struct lan743x_vector *vector = >intr.vector_list > > + [vector_index]; > > + > > +

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-22 Thread David Ahern
On 2/22/18 1:55 PM, Ido Schimmel wrote: > On Thu, Feb 22, 2018 at 12:27:35PM -0700, David Ahern wrote: >> Ido: >> >> IPv4 works at boot; IPv6 requires the mcast snooping disable. For this >> vlan-unaware bridges can that be set automatically? > > Can you please try the following patch? > ... >

Re: [PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-22 Thread David Miller
From: David Ahern Date: Thu, 22 Feb 2018 12:31:01 -0700 > On 2/22/18 12:27 PM, David Miller wrote: >> From: David Ahern >> Date: Wed, 21 Feb 2018 10:49:47 -0800 >> >>> Patch 5 adds the L4 hash support. >> >> Please address Ido's feedback about how the

Re: [PATCH] bpf: add schedule points in percpu arrays management

2018-02-22 Thread Daniel Borkmann
[ +Dennis for mm/pcpu ] On 02/22/2018 05:33 PM, Eric Dumazet wrote: > From: Eric Dumazet > > syszbot managed to trigger RCU detected stalls in > bpf_array_free_percpu() > > It takes time to allocate a huge percpu map, but even more time to free > it. > > Since we run in

Re: [PATCH] selftest: fix kselftest-merge depend on 'RUNTIME_TESTING_MENU'

2018-02-22 Thread Luis R. Rodriguez
On Thu, Feb 22, 2018 at 07:53:07PM +0800, Zong Li wrote: > Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig > to ease disabling it all")', the make kselftest-merge cannot merge the > config dependencies of kselftest to the existing .config file. > > These config dependencies

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-22 Thread Alexander Duyck
On Thu, Feb 22, 2018 at 12:11 AM, Jiri Pirko wrote: > Wed, Feb 21, 2018 at 09:57:09PM CET, alexander.du...@gmail.com wrote: >>On Wed, Feb 21, 2018 at 11:38 AM, Jiri Pirko wrote: >>> Wed, Feb 21, 2018 at 06:56:35PM CET, alexander.du...@gmail.com wrote: On

Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-22 Thread Andrew Lunn
> Also I'm allocating interrupt resources on interface up, and freeing resources > on interface down. So if there is an up, down, up sequence then the driver > will allocate resources twice. In order for devm to work properly, should I > move all resource allocation into the probe function? Hi

  1   2   >