Distinguish cases when "dev" parameter isn't given from cases where no
network device corresponding to "dev" is found.
Do not check for index validity in xdp_parse(): caller should take care
of this because has more information (e.g. when "dev" is given or not
found) for this.
Signed-off-by: Serh
Introduce new @struct iplink_parse_args data structure to consolidate
arguments to iplink_parse(). This will reduce number of arguments
passed to it.
Pass this data structure to ->parse_opt() in iplink specific modules:
it may be used to get network device name and other information.
Signed-off-b
This will consolidate data and code using it in single place and prepare
for upcoming ->parse_opt() method change.
Signed-off-by: Serhey Popovych
---
ip/link_gre.c| 32
ip/link_gre6.c | 32
ip/link_ip6tnl.c | 32 ++
Both ip-link(8) and error message when "index" parameter is given for
set/delete case says that index can only be given during network
device creation.
Follow this documented behaviour and get rid of ambiguous behaviour in
case of both "dev" and "index" specified for ip link delete scenario
(actua
This is main routine to parse ip-link(8) configuration parameters.
Main reason to improve it is to pass network device @name, @dev and
other parameters to kind specific ->parse_opt() function so they can use
this information.
For example later we will extend iplink_get() to parse netlink
attribut
To benefit other users (e.g. link_veth.c) of iplink_parse() from
additional attribute checks and setups made in iplink_modify(). This
catches most of weired cobination of parameters to peer device
configuration.
Drop @link, @group and @index from iplink_parse() parameters list: they
are not needed
Now in iplink_parse() we use ->ifi_change and ->ifi_flags fields and
plan to use ->ifi_index with upcoming change.
Saving, restoring and reinitializing individual fields is error prone:
using new field in iplink_parse() without updating callers in veth and
vxcan will overwrite main device ifinfoms
Both of them accept network device name as argument, but have different
meaning:
dev - is a device by it's name,
name - name for specific device.
The only case where they treated separately is network device rename
case where need to specify both ifindex and new name. In rest of the
cases we
There is a couple of places where we report error in case of no network
device is found. In all of them we output message in the same format to
stderr and either return -1 or 1 to the caller or exit with -1.
Introduce new helper function nodev() that takes name of the network
device caused error a
Thu, Feb 22, 2018 at 12:54:45PM CET, gerlitz...@gmail.com wrote:
>On Thu, Feb 22, 2018 at 10:11 AM, Jiri Pirko wrote:
>> Wed, Feb 21, 2018 at 09:57:09PM CET, alexander.du...@gmail.com wrote:
>
>>>The signaling isn't too much of an issue since we can just tweak the
>>>link state of the VF or virtio
Dmitry Vyukov writes:
> On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote:
>> On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote:
>>> I have to mention this now before it gets out of control.
>>>
>>> I would like to ask that syzkaller stop posting the patch it is
>>> testing when it posts to
On (02/21/18 19:39), Willem de Bruijn wrote:
> >> By the way, the put_cmsg is unconditional even if the caller did
> >> not supply msg_control. So it is basically no longer safe to ever
> >> call read, recv or recvfrom on a socket if zerocopy notifications
> >> are outstanding.
> >
> > Wait, I thou
On Wed, 2018-02-21 at 22:38 -0800, Yonghong Song wrote:
> Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback
> function")
> fixed a memory leak and removed unnecessary locks in map_free callback
> function.
> Unfortrunately, it introduced a lockdep warning. When lockdep chec
On Thu, Feb 22, 2018 at 2:31 PM, Daniel Axtens wrote:
> Dmitry Vyukov writes:
>
>> On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote:
>>> On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote:
I have to mention this now before it gets out of control.
I would like to ask that syzk
Implement a retpoline [0] for the BPF tail call JIT'ing that converts
the indirect jump via jmp %rax that is used to make the long jump into
another JITed BPF image. Since this is subject to speculative execution,
we need to control the transient instruction sequence here as well
when CONFIG_RETPOL
Dmitry Vyukov writes:
> On Thu, Feb 22, 2018 at 2:31 PM, Daniel Axtens wrote:
>> Dmitry Vyukov writes:
>>
>>> On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote:
On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote:
> I have to mention this now before it gets out of control.
>
>>
On 02/22/2018 03:34 AM, Li Zhijian wrote:
> From: Li Zhijian
>
> test_maps contains a series of stress tests, and previously it will break the
> rest tests when it failed to alloc memory.
> ---
> Failed to create hashmap key=8 value=262144 'Cannot allocate memory'
> Failed to
From: Dmitry Vyukov
Date: Thu, 22 Feb 2018 10:58:07 +0100
> Do I understand it correctly that if syzbot replies to the CC list
> that was in the testing request, it will resolve the problem? So if
> netdev wasn't in CC, it will not be added to CC.
>
> I will go and fix it now.
I don't want syzb
All the kernel_sendmsg() calls in rxrpc_send_data_packet() need to send
both parts of the iov[] buffer, but one of them does not. Fix it so that
it does.
Without this, short IPv6 rxrpc DATA packets may be seen that have the rxrpc
header included, but no payload.
Fixes: 5a924b8951f8 ("rxrpc: Don'
On Thu, Feb 22, 2018 at 3:16 PM, Daniel Axtens wrote:
> Dmitry Vyukov writes:
>
>> On Thu, Feb 22, 2018 at 2:31 PM, Daniel Axtens wrote:
>>> Dmitry Vyukov writes:
>>>
On Thu, Feb 22, 2018 at 9:26 AM, Paolo Abeni wrote:
> On Wed, 2018-02-21 at 16:47 -0500, David Miller wrote:
>> I
On Thu, Feb 22, 2018 at 3:35 PM, David Miller wrote:
> From: Dmitry Vyukov
> Date: Thu, 22 Feb 2018 10:58:07 +0100
>
>> Do I understand it correctly that if syzbot replies to the CC list
>> that was in the testing request, it will resolve the problem? So if
>> netdev wasn't in CC, it will not be
Hi Yonghong,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf/master]
url:
https://github.com/0day-ci/linux/commits/Yonghong-Song/bpf-fix-rcu-lockdep-warning-for-lpm_trie-map_free-callback/20180222-202658
base: https://git.kernel.org/pub/scm/linux
On Thu, Feb 22, 2018 at 12:44:40PM +0100, Arnd Bergmann wrote:
> Declaring a static function in a header leads to a warning every
> time that header gets included without the function being used:
Acked-by: Richard Cochran
On 2/22/18 3:19 AM, Arkadi Sharshevsky wrote:
>
>
> On 02/15/2018 05:41 AM, David Ahern wrote:
>> On 2/14/18 1:55 AM, Arkadi Sharshevsky wrote:
>>> Add support for devlink resource abstraction.
>>>
>>> Arkadi Sharshevsky (7):
>>> devlink: Change empty line indication with indentations
>>> dev
Dmitry Vyukov writes:
> On Thu, Feb 22, 2018 at 3:35 PM, David Miller wrote:
>> From: Dmitry Vyukov
>> Date: Thu, 22 Feb 2018 10:58:07 +0100
>>
>>> Do I understand it correctly that if syzbot replies to the CC list
>>> that was in the testing request, it will resolve the problem? So if
>>> netd
The following use-after-free was reported by KASan when running
LTP macvtap01 test on 4.16-rc2:
[10642.528443] BUG: KASAN: use-after-free in
macvlan_common_newlink+0x12ef/0x14a0 [macvlan]
[10642.626607] Read of size 8 at addr 880ba49f2100 by task ip/18450
...
[10642.963873] Call
On Thu, Feb 22, 2018 at 5:07 AM, Jiri Pirko wrote:
> Thu, Feb 22, 2018 at 12:54:45PM CET, gerlitz...@gmail.com wrote:
>>On Thu, Feb 22, 2018 at 10:11 AM, Jiri Pirko wrote:
>>> Wed, Feb 21, 2018 at 09:57:09PM CET, alexander.du...@gmail.com wrote:
>>
The signaling isn't too much of an issue sin
gcc-8 has a new warning that detects overlapping input and output arguments
in memcpy(). It triggers for sit_init_net() calling ipip6_tunnel_clone_6rd(),
which is actually correct:
net/ipv6/sit.c: In function 'sit_init_net':
net/ipv6/sit.c:192:3: error: 'memcpy' source argument is the same as
des
From: Eric Dumazet
syszbot managed to trigger RCU detected stalls in
bpf_array_free_percpu()
It takes time to allocate a huge percpu map, but even more time to free
it.
Since we run in process context, use cond_resched() to yield cpu if
needed.
Fixes: a10423b87a7e ("bpf: introduce BPF_MAP_TYPE
On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote:
...
>
> This code is old, so Cc stable to make sure that we don't get the warning
> for older kernels built with new gcc.
>
> Cc: sta...@vger.kernel.org
This part makes little sense to me for two reasons.
1) David Miller handles stable
On Thu, Feb 22, 2018 at 5:40 PM, Eric Dumazet wrote:
> On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote:
>
> ...
>>
>> This code is old, so Cc stable to make sure that we don't get the warning
>> for older kernels built with new gcc.
>>
>> Cc: sta...@vger.kernel.org
>
>
> This part makes lit
On Thu, Feb 22, 2018 at 12:39:15PM +0100, Pablo Neira Ayuso wrote:
> Hi Alexei,
>
> On Wed, Feb 21, 2018 at 06:20:37PM -0800, Alexei Starovoitov wrote:
> > On Wed, Feb 21, 2018 at 01:13:03PM +0100, Florian Westphal wrote:
> > >
> > > Obvious candidates are: meta, numgen, limit, objref, quota, rej
Quoting Guillaume Nault :
On Wed, Feb 21, 2018 at 07:59:24PM -0600, Jesse Cooper wrote:
Thank you for the suggestions. This is on a raspberry pi 3 not sure if
that fact matters. I will notify Raspbian of the issue.
Does your kernel have CONFIG_INET_UDP_DIAG?
grep CONFIG_INET_UDP_DIAG kerne
Hi my name is Benjamin Bales.
I am the founder and creator of CodeAI,
the first non-human contributor to your software project. CodeAI finds
and fixes security defects for you. It fixed 327. It wants to merge a
fix for a useless assignment. To view all 327 fixed issues from the
run claim your free
On 2/22/18 1:23 AM, Ido Schimmel wrote:
>> diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
>> index 98e1066c3d55..c1d4ab5b2d9f 100644
>> --- a/net/core/fib_rules.c
>> +++ b/net/core/fib_rules.c
>> @@ -51,6 +51,7 @@ int fib_default_rule_add(struct fib_rules_ops *ops,
>> r->pref = pref;
On 2/21/18 7:12 PM, Donald Sharp wrote:
> @@ -577,21 +585,20 @@ static int iprule_modify(int cmd, int argc, char **argv)
> __u32 tid = 0;
> struct {
> struct nlmsghdr n;
> - struct rtmsgr;
> + struct fib_rule_hdr frh;
>
On Wed, Feb 21, 2018 at 12:13:54PM -0800, Saeed Mahameed wrote:
> From: Yonatan Cohen
>
> The current implementation of create CQ requires contiguous
> memory, such requirement is problematic once the memory is
> fragmented or the system is low in memory, it causes for
> failures in dma_zalloc_co
On Thu, 22 Feb 2018 17:36:46 +0800
Jason Wang wrote:
> Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the
> devmap stall caused by missed xdp flush by counting the pending xdp
> redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or
> MSG_MORE is clear. This may lead
Series for Chelsio Inline TLS driver (chtls.ko)
Use tls ULP infrastructure to register chtls as Inline TLS driver.
Chtls use TCP Sockets to transmit and receive TLS record. TCP proto_ops is
extended to offload TLS record.
T6 adapter provides the following features:
-TLS record offload, T
tls_device structure to register Inline TLS drivers
with net/tls
Signed-off-by: Atul Gupta
---
include/net/tls.h | 23 +++
1 file changed, 23 insertions(+)
diff --git a/include/net/tls.h b/include/net/tls.h
index 4913430..e315bf9 100644
--- a/include/net/tls.h
+++ b/include/
On 2/22/18 5:37 AM, Eric Dumazet wrote:
On Wed, 2018-02-21 at 22:38 -0800, Yonghong Song wrote:
Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback
function")
fixed a memory leak and removed unnecessary locks in map_free callback function.
Unfortrunately, it introduced a
Signed-off-by: Atul Gupta
---
include/linux/netdev_features.h | 2 ++
net/core/ethtool.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
index db84c51..aacabe2 100644
--- a/include/linux/netdev_features.h
+++ b/i
Facility to register Inline TLS drivers to net/tls. Setup
TLS_FULL_HW prot to listen on offload device.
Cases handled
1. Inline TLS device exists, setup prot for TLS_FULL_HW
2. Atleast one Inline TLS exists, sets TLS_FULL_HW. If
non-inline capable device establish connection, move to TLS_SW_TX
3.
Inline TLS state, connection management. Supporting macros definition.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls.h| 487
drivers/crypto/chelsio/chtls/chtls_cm.h | 202 +
2 files changed, 689 insertions(+)
create mode 100644
Define macro for TLS Key context
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chcr_algo.h | 42 +
drivers/crypto/chelsio/chcr_core.h | 55 +-
2 files changed, 96 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/chel
CPL handlers for TLS session, record transmit and receive.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls_cm.c | 2041 +++
net/ipv4/tcp_minisocks.c|1 +
2 files changed, 2042 insertions(+)
create mode 100644 drivers/crypto/chelsi
Hardware-realized virtio-pci devices can implement SR-IOV, so this
patch enables its use. The device in question is an upcoming Intel
NIC that implements both a virtio-net PF and virtio-net VFs. These
are hardware realizations of what has been up to now been a software
interface.
The device in que
Register chtls as Inline TLS driver, chtls is ULD to cxgb4.
Setsockopt to program (tx/rx) keys on chip. Support AES GCM
of key size 128. Support both Inline Rx and Tx.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls_main.c | 600 ++
include/uapi/linux
TLS handler for record transmit and receive.
Create Inline TLS work request and post to FW.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls_io.c | 1867 +++
1 file changed, 1867 insertions(+)
create mode 100644 drivers/crypto/chelsio/chtls/chtls_io.c
Key area size in hw-config file. CPL struct for TLS request
and response. Work request for Inline TLS.
Signed-off-by: Atul Gupta
---
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 121 ++-
drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 +
drivers/net/ethernet/chelsio/cxgb4/
Program the tx and rx key on chip.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls_hw.c | 394
1 file changed, 394 insertions(+)
create mode 100644 drivers/crypto/chelsio/chtls/chtls_hw.c
diff --git a/drivers/crypto/chelsio/chtls/chtls_hw.c
b/
Entry for Inline TLS as another driver dependent on cxgb4 and chcr
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/Kconfig| 11 +++
drivers/crypto/chelsio/Makefile | 1 +
drivers/crypto/chelsio/chtls/Makefile | 4
3 files changed, 16 insertions(+)
create mode 1
Read FW capability. Read key area size. Dump the TLS record count.
Signed-off-by: Atul Gupta
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32 +---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 ++
drivers/net/ethernet/chelsio/cxgb4/sge.c| 98 -
Fixes: 896121de80db ("lan743x: Add main source files for new lan743x driver")
Signed-off-by: Fengguang Wu
---
lan743x_main.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c
b/drivers/net/ethernet/microchip/lan743x_main.c
i
Hi Bryan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Bryan-Whitehead/lan743x-Add-new-lan743x-driver/20180222-225510
reproduce:
# apt-get install sparse
make ARCH=x86_64
Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback
function")
fixed a memory leak and removed unnecessary locks in map_free callback function.
Unfortrunately, it introduced a lockdep warning. When lockdep checking is
turned on,
running tools/testing/selftests/bpf/test_lpm_ma
On Thu, 2018-02-22 at 10:10 -0800, Yonghong Song wrote:
> Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback
> function")
> fixed a memory leak and removed unnecessary locks in map_free callback
> function.
> Unfortrunately, it introduced a lockdep warning. When lockdep chec
Can we move this into common code as a a generic_sriov_configure
helper? Nothing is really virtio specific, and it seems like
some other drivers could also use it, e.g. ena or nvme.
On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote:
> On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault
> wrote:
> > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote:
> >> On 2018-02-15 17:55, Guillaume Nault wrote:
> >> > On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys
From: Yonghong Song
Date: Thu, 22 Feb 2018 10:10:35 -0800
> Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback
> function")
> fixed a memory leak and removed unnecessary locks in map_free callback
> function.
> Unfortrunately, it introduced a lockdep warning. When lockdep
On 2018-02-22 20:30, Guillaume Nault wrote:
On Wed, Feb 21, 2018 at 12:04:30PM -0800, Cong Wang wrote:
On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault
wrote:
> On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote:
>> On 2018-02-15 17:55, Guillaume Nault wrote:
>> > On Thu, Fe
[resend as plaintext, apparently mobile gmail will send HTML mails]
On Thu, Feb 22, 2018 at 3:20 AM, Alexei Starovoitov
wrote:
> On Wed, Feb 21, 2018 at 01:13:03PM +0100, Florian Westphal wrote:
>>
>> Obvious candidates are: meta, numgen, limit, objref, quota, reject.
>>
>> We should probably als
From: David Ahern
Date: Wed, 21 Feb 2018 11:16:35 -0700
> On 2/20/18 12:45 AM, Jiri Pirko wrote:
>> From: Ido Schimmel
>>
>> Up until now we only allowed VLAN devices to be put in a VLAN-unaware
>> bridge, but some users need the ability to enslave physical ports as
>> well.
>>
>> This is achi
From: "Jason A. Donenfeld"
Date: Wed, 21 Feb 2018 04:41:59 +0100
> Before, if cb->start() failed, the module reference would never be put,
> because cb->cb_running is intentionally false at this point. Users are
> generally annoyed by this because they can no longer unload modules that
> leak ref
From: Eric Dumazet
Date: Tue, 20 Feb 2018 21:42:26 -0800
> From: Eric Dumazet
>
> If an attempt is made to disable RX checksums, USB adapter is changed
> but netdev->features is not, because smsc75xx_set_features() returns a
> non zero value.
>
> This throws errors from netdev_rx_csum_fault()
From: Denis Du
Date: Wed, 21 Feb 2018 03:35:31 + (UTC)
> How is your thinking about this patch?
I cannot apply a patch which has been corrupted by your email client like
this.
Please send it properly again, plain ASCII text, and no trasnformations
by your email client.
You should send the
Previously, buffer descriptors containing only the frame check sequence
(FCS) were skipped and not added to the skb. However, the page reference
count was still incremented, leading to a memory leak.
Fixing this inside gfar_add_rx_frag() is difficult due to reserved
memory handling and page reuse.
From: Kees Cook
Date: Tue, 20 Feb 2018 22:00:26 -0800
> So, this specific problem needs fixing (in at least two places calling
> nla_put_string(msg, NL80211_ATTR_REG_ALPHA2, ...)). While I suspect
> it's only ever written an extra byte from the following variable in
> the structure which is an en
From: Ursula Braun
Date: Wed, 21 Feb 2018 12:32:32 +0100
> diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h
> index ab240b37ad11..d2012fd22100 100644
> --- a/net/smc/smc_cdc.h
> +++ b/net/smc/smc_cdc.h
> @@ -48,7 +48,7 @@ struct smc_cdc_msg {
> struct smc_cdc_producer_flags prod_flags;
Make sure the Security Association is using
a 128-bit authentication, since that's the only
size that the hardware offload supports.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 16 +++-
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.h | 1 +
2 fi
These are a couple of updates for the ixgbe IPsec offload support.
Shannon Nelson (3):
ixgbe: check for 128-bit authentication
ixgbe: fix ipsec trailer length
ixgbe: remove unneeded ipsec state free callback
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 53 +-
dr
Fix up the Tx trailer length calculation. We can't believe the
trailer len from the xstate information because it was calculated
before the packet was put together and padding added. This bit
of code finds the padding value in the trailer, adds it to the
authentication length, and saves it so lat
From: Eric Dumazet
Date: Wed, 21 Feb 2018 06:43:03 -0800
> From: Eric Dumazet
>
> BBR uses tcp_tso_autosize() in an attempt to probe what would be the
> burst sizes and to adjust cwnd in bbr_target_cwnd() with following
> gold formula :
>
> /* Allow enough full-sized skbs in flight to utilize
From: David Ahern
Date: Wed, 21 Feb 2018 10:49:47 -0800
> Patch 5 adds the L4 hash support.
Please address Ido's feedback about how the ports aren't actually being
taken into consideration because they aren't present in the flow
information being used.
Thanks.
On 2/22/18 11:58 AM, David Miller wrote:
> From: David Ahern
> Date: Wed, 21 Feb 2018 11:16:35 -0700
>
>> On 2/20/18 12:45 AM, Jiri Pirko wrote:
>>> From: Ido Schimmel
>>>
>>> Up until now we only allowed VLAN devices to be put in a VLAN-unaware
>>> bridge, but some users need the ability to ens
On 2/22/18 12:27 PM, David Miller wrote:
> From: David Ahern
> Date: Wed, 21 Feb 2018 10:49:47 -0800
>
>> Patch 5 adds the L4 hash support.
>
> Please address Ido's feedback about how the ports aren't actually being
> taken into consideration because they aren't present in the flow
> information
From: David Ahern
Date: Wed, 21 Feb 2018 11:00:54 -0800
> The result of the skb flow dissect is copied from keys to hash_keys to
> ensure only the intended data is hashed. The original L4 hash patch
> overlooked setting the addr_type for this case; add it.
>
> Fixes: bf4e0a3db97eb ("net: ipv4: a
With commit 7f05b467a735 ("xfrm: check for xdo_dev_state_free")
we no longer need to add an empty callback function
to the driver, so now let's remove the useless code.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 13 -
1 file changed, 13 deletio
From: Saeed Mahameed
Date: Wed, 21 Feb 2018 12:13:47 -0800
> This series includes shared code updates for mlx5 core driver for both
> netdev and rdma subsystems. This series should be pulled to both
> trees so we can continue netdev and rdma specific submissions separately.
>
> For more informa
From: David Ahern
Date: Thu, 22 Feb 2018 12:31:01 -0700
> On 2/22/18 12:27 PM, David Miller wrote:
>> From: David Ahern
>> Date: Wed, 21 Feb 2018 10:49:47 -0800
>>
>>> Patch 5 adds the L4 hash support.
>>
>> Please address Ido's feedback about how the ports aren't actually being
>> taken into
From: Finn Thain
Date: Thu, 22 Feb 2018 09:24:59 +1100 (AEDT)
> AFAIK the only version of smc9194.c with Mac support is the one in the
> linux-mac68k CVS repo, which never made it to the mainline.
>
> Despite that, from v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194
> under CONFIG_MAC. This
From: Thomas Falcon
Date: Wed, 21 Feb 2018 18:21:10 -0600
> With the recent change, transmissions that only needed
> one descriptor were being missed. The result is that such
> packets were tracked as outstanding transmissions but never
> removed when its completion notification was received.
>
From: Thomas Falcon
Date: Wed, 21 Feb 2018 18:18:30 -0600
> The login buffer is released before the driver can perform
> sanity checks between resources the driver requested and what
> firmware will provide. Don't release the login buffer until
> the sanity check is performed.
>
> Fixes: 34f0f4e
From: Andrew Lunn
Date: Thu, 22 Feb 2018 01:51:49 +0100
> MV88E6352 and later switches support GPIO control through the "Scratch
> & Misc" global2 register. Two of the pins controlled this way on the
> mv88e6390 family are the external MDIO pins. They can either by used
> as part of the MII inter
On Thu, Feb 22, 2018 at 07:53:07PM +0800, Zong Li wrote:
> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig
> to ease disabling it all")', the make kselftest-merge cannot merge the
> config dependencies of kselftest to the existing .config file.
>
> These config dependencies
On Tue, 2018-02-20 at 22:00 -0800, Kees Cook wrote:
> It seems that in at least one case[1], nla_put_string() is being used
> on an NLA_STRING, which lacks a NULL terminator, which leads to
> silliness when nla_put_string() uses strlen() to figure out the size:
Fun! I'm not a big fan of the whole
On 22 February 2018 at 12:53, Zong Li wrote:
> Since the 'commit d3deafaa8b5c ("lib/: make RUNTIME_TESTS a menuconfig
> to ease disabling it all")', the make kselftest-merge cannot merge the
> config dependencies of kselftest to the existing .config file.
>
> These config dependencies of kselftest
From: Nathan Fontenot
Date: Wed, 21 Feb 2018 21:33:56 -0600
> The approach of one counter to rule them all when tracking the number
> of active sub-crqs, pools, and napi has problems handling some failover
> scenarios. This is due to the split in initializing the sub crqs,
> pools and napi in dif
Hi Dave,
A bunch of fixes, including the nla_put_string() issue
just in from Kees. Otherwise nothing really super urgent
or interesting.
Please pull and let me know if there's any problem.
Thanks,
johannes
The following changes since commit ba804bb4b72e57374b5f567b783aa0298fba0ce6:
Merge g
Hi Dave,
Wireless is slow ... but we're preparing for HE (802.11ax),
so I guess soon we'll have a big chunk of work coming :-)
Please pull and let me know if there's any problem.
Thanks,
johannes
The following changes since commit 91e6dd8284256ef62b43b78da6e7684e4f06ac2f:
ipmr: Fix ptrdiff
From: Johannes Berg
Date: Thu, 22 Feb 2018 21:08:39 +0100
> A bunch of fixes, including the nla_put_string() issue
> just in from Kees. Otherwise nothing really super urgent
> or interesting.
>
> Please pull and let me know if there's any problem.
Pulled.
Thanks for taking care of that NLA_STR
From: Johannes Berg
Date: Thu, 22 Feb 2018 21:16:18 +0100
> Wireless is slow ... but we're preparing for HE (802.11ax),
> so I guess soon we'll have a big chunk of work coming :-)
I wondered where you guys have been hiding :-)
> Please pull and let me know if there's any problem.
Pulled, thank
On Thu, 2018-02-22 at 15:19 -0500, David Miller wrote:
> From: Johannes Berg
> Date: Thu, 22 Feb 2018 21:16:18 +0100
>
> > Wireless is slow ... but we're preparing for HE (802.11ax),
> > so I guess soon we'll have a big chunk of work coming :-)
>
> I wondered where you guys have been hiding :-)
Currently, if BIOS enables WOL in the chip, settings are inconsistent
because the device isn't marked as wakeup-enabled (if not done
explicitly via userspace tools). This causes issues with suspend/
resume because mdio_bus_phy_may_suspend() checks whether device is
wakeup-enabled. In detail MDIO bu
From: Jakub Kicinski
Date: Wed, 21 Feb 2018 19:50:04 -0800
> This set brings empty makefiles to allow building single object files
> (useful for build-testing), Kbuild does not cater to this use case
> too well. There are two ethernet drivers right now which suffer
> from this (nfp, aquantia), b
On 02/22/2018 07:10 PM, Yonghong Song wrote:
> Commit 9a3efb6b661f ("bpf: fix memory leak in lpm_trie map_free callback
> function")
> fixed a memory leak and removed unnecessary locks in map_free callback
> function.
> Unfortrunately, it introduced a lockdep warning. When lockdep checking is
>
[ +Dennis for mm/pcpu ]
On 02/22/2018 05:33 PM, Eric Dumazet wrote:
> From: Eric Dumazet
>
> syszbot managed to trigger RCU detected stalls in
> bpf_array_free_percpu()
>
> It takes time to allocate a huge percpu map, but even more time to free
> it.
>
> Since we run in process context, use co
From: Dan Carpenter
Date: Thu, 22 Feb 2018 12:11:55 +0300
> We should check "self->aq_hw" for allocation failure, and also we should
> free it on the error paths.
>
> Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module")
> Signed-off-by: Dan Carpenter
Applied, thanks Dan.
r8168_check_dash() returns false anyway for all chip versions not
supporting dash. So we can simplify the check conditions.
In addition change the check functions to return bool instead of int,
because they actually return a bool value.
Signed-off-by: Heiner Kallweit
---
drivers/net/ethernet/re
From: Arnd Bergmann
Date: Thu, 22 Feb 2018 12:44:40 +0100
> Declaring a static function in a header leads to a warning every
> time that header gets included without the function being used:
>
> In file included from drivers/net/dsa/mv88e6xxx/chip.c:42:
> drivers/net/dsa/mv88e6xxx/ptp.h:92:13: e
1 - 100 of 170 matches
Mail list logo
