Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread joel jaeggli
On 3/6/18 3:29 AM, Lou Berger wrote: > Martin, > > > On March 6, 2018 4:44:47 AM Martin Bjorklund wrote: > >> Hi, >> >> After thinking some more about this, realizing that this document is >> in AUTH48, and looking at the first sentence in the Abstract: >> >>    This document

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Ladislav Lhotka
Juergen Schoenwaelder writes: > On Tue, Mar 06, 2018 at 10:44:11AM +0100, Martin Bjorklund wrote: >> >> OLD: >> >> is one of: >> rw for configuration data >> ro for non-configuration data, output parameters to rpcs >>

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Juergen Schoenwaelder
On Tue, Mar 06, 2018 at 03:45:49PM +0100, Martin Bjorklund wrote: > > I agree that using well defined terms add clarity. However, the > proposed text is not quite right. Possibly: > > rw for configuration data- and choice nodes > ro for non-configuration data- and choice

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Martin Bjorklund
Juergen Schoenwaelder wrote: > On Tue, Mar 06, 2018 at 02:00:23PM +0100, Martin Bjorklund wrote: > > Juergen Schoenwaelder wrote: > > > On Tue, Mar 06, 2018 at 10:44:11AM +0100, Martin Bjorklund wrote: > > > > > > > >

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Juergen Schoenwaelder
On Tue, Mar 06, 2018 at 02:00:23PM +0100, Martin Bjorklund wrote: > Juergen Schoenwaelder wrote: > > On Tue, Mar 06, 2018 at 10:44:11AM +0100, Martin Bjorklund wrote: > > > > > > OLD: > > > > > > is one of: > > > rw for configuration data

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Martin Bjorklund
Juergen Schoenwaelder wrote: > On Tue, Mar 06, 2018 at 10:44:11AM +0100, Martin Bjorklund wrote: > > > > OLD: > > > > is one of: > > rw for configuration data > > ro for non-configuration data, output parameters to rpcs > >

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Benoit Claise
On 3/6/2018 10:44 AM, Martin Bjorklund wrote: Hi, After thinking some more about this, realizing that this document is in AUTH48, and looking at the first sentence in the Abstract: This document captures the current syntax used in YANG module tree diagrams. I have reached the

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Juergen Schoenwaelder
On Tue, Mar 06, 2018 at 10:44:11AM +0100, Martin Bjorklund wrote: > > OLD: > > is one of: > rw for configuration data > ro for non-configuration data, output parameters to rpcs > and actions, and notification parameters > -w for input parameters

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Lou Berger
On 3/6/2018 7:10 AM, Martin Bjorklund wrote: Lou Berger wrote: Martin, On March 6, 2018 4:44:47 AM Martin Bjorklund wrote: Hi, After thinking some more about this, realizing that this document is in AUTH48, and looking at the first sentence in the

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Martin Bjorklund
Lou Berger wrote: > Martin, > > > On March 6, 2018 4:44:47 AM Martin Bjorklund wrote: > > > Hi, > > > > After thinking some more about this, realizing that this document is > > in AUTH48, and looking at the first sentence in the Abstract: > > > >This

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Lou Berger
Martin, On March 6, 2018 4:44:47 AM Martin Bjorklund wrote: Hi, After thinking some more about this, realizing that this document is in AUTH48, and looking at the first sentence in the Abstract: This document captures the current syntax used in YANG module tree

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Robert Wilton
+1 for this solution. Thanks, Rob On 06/03/2018 09:44, Martin Bjorklund wrote: Hi, After thinking some more about this, realizing that this document is in AUTH48, and looking at the first sentence in the Abstract: This document captures the current syntax used in YANG module tree

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Martin Bjorklund
Mahesh Jethanandani wrote: > > > > On Mar 5, 2018, at 6:27 AM, Martin Bjorklund wrote: > > > > Martin Bjorklund > wrote: > >> Juergen Schoenwaelder wrote: > >>> On Mon,

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Martin Bjorklund
Hi, After thinking some more about this, realizing that this document is in AUTH48, and looking at the first sentence in the Abstract: This document captures the current syntax used in YANG module tree diagrams. I have reached the conclusion that we probably shouldn't make any drastic

Re: [netmod] choice/case in tree diagrams

2018-03-06 Thread Vladimir Vassilev
On 03/05/2018 06:40 PM, Per Hedeland wrote: On 2018-03-05 16:06, Ladislav Lhotka wrote: On Mon, 2018-03-05 at 15:49 +0100, Per Hedeland wrote: On 2018-03-05 15:41, Ladislav Lhotka wrote: On Mon, 2018-03-05 at 15:26 +0100, Martin Bjorklund wrote: Juergen Schoenwaelder

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Mahesh Jethanandani
> On Mar 5, 2018, at 6:27 AM, Martin Bjorklund wrote: > > Martin Bjorklund > wrote: >> Juergen Schoenwaelder wrote: >>> On Mon, Mar 05, 2018 at 02:54:18PM +0100, Martin Bjorklund wrote: >

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Per Hedeland
On 2018-03-05 16:06, Ladislav Lhotka wrote: > On Mon, 2018-03-05 at 15:49 +0100, Per Hedeland wrote: >> On 2018-03-05 15:41, Ladislav Lhotka wrote: >>> On Mon, 2018-03-05 at 15:26 +0100, Martin Bjorklund wrote: Juergen Schoenwaelder wrote: > On Mon,

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Ladislav Lhotka
On Mon, 2018-03-05 at 15:49 +0100, Per Hedeland wrote: > On 2018-03-05 15:41, Ladislav Lhotka wrote: > > On Mon, 2018-03-05 at 15:26 +0100, Martin Bjorklund wrote: > > > Juergen Schoenwaelder wrote: > > > > On Mon, Mar 05, 2018 at 02:54:18PM +0100, Martin

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Per Hedeland
On 2018-03-05 15:41, Ladislav Lhotka wrote: > On Mon, 2018-03-05 at 15:26 +0100, Martin Bjorklund wrote: >> Juergen Schoenwaelder wrote: >>> On Mon, Mar 05, 2018 at 02:54:18PM +0100, Martin Bjorklund wrote: > > So it seems the running code got it

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Ladislav Lhotka
On Mon, 2018-03-05 at 15:26 +0100, Martin Bjorklund wrote: > Juergen Schoenwaelder wrote: > > On Mon, Mar 05, 2018 at 02:54:18PM +0100, Martin Bjorklund wrote: > > > > > > > > So it seems the running code got it right. ;-) > > > > > > As the author of that

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Martin Bjorklund
Juergen Schoenwaelder wrote: > On Mon, Mar 05, 2018 at 02:54:18PM +0100, Martin Bjorklund wrote: > > > > > > So it seems the running code got it right. ;-) > > > > As the author of that code, I think that was purely by accident... > > > > But I'm not

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Vladimir Vassilev
On 03/05/2018 02:54 PM, Martin Bjorklund wrote: Juergen Schoenwaelder wrote: On Mon, Mar 05, 2018 at 02:14:26PM +0100, Vladimir Vassilev wrote: On 03/05/2018 01:50 PM, Juergen Schoenwaelder wrote: I prefer that the choice/case nodes do not have any

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Juergen Schoenwaelder
On Mon, Mar 05, 2018 at 02:54:18PM +0100, Martin Bjorklund wrote: > > > > So it seems the running code got it right. ;-) > > As the author of that code, I think that was purely by accident... > > But I'm not convinced it is the correct solution. We have one example > in the other thread where

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Martin Bjorklund
Juergen Schoenwaelder wrote: > On Mon, Mar 05, 2018 at 02:14:26PM +0100, Vladimir Vassilev wrote: > > On 03/05/2018 01:50 PM, Juergen Schoenwaelder wrote: > > > > > I prefer that the choice/case nodes do not have any flags since they > > > are not having a

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Juergen Schoenwaelder
On Mon, Mar 05, 2018 at 02:14:26PM +0100, Vladimir Vassilev wrote: > On 03/05/2018 01:50 PM, Juergen Schoenwaelder wrote: > > > I prefer that the choice/case nodes do not have any flags since they > > are not having a config true/false property on their own. And less > > clutter is better. > >

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Vladimir Vassilev
On 03/05/2018 01:50 PM, Juergen Schoenwaelder wrote: I prefer that the choice/case nodes do not have any flags since they are not having a config true/false property on their own. And less clutter is better. 'choice' statements have 'config' substatement while 'case' do not. I myself figured

Re: [netmod] choice/case in tree diagrams

2018-03-05 Thread Juergen Schoenwaelder
I prefer that the choice/case nodes do not have any flags since they are not having a config true/false property on their own. And less clutter is better. /js On Mon, Mar 05, 2018 at 12:26:27PM +0100, Martin Bjorklund wrote: > Hi, > > Lifting this issue to its own thread. > > With this

[netmod] choice/case in tree diagrams

2018-03-05 Thread Martin Bjorklund
Hi, Lifting this issue to its own thread. With this snippet: choice subnet { case prefix-length { leaf prefix-length { type uint8; } } case netmask { leaf netmask { type yang:dotted-quad; } } } pyang prints