[GitHub] keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r158017438 ## File path:

[GitHub] milleruntime commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
milleruntime commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#issuecomment-353088473 Whoops sorry clicked "close and Comment" instead of comment. The only preference we have for working with pull

[jira] [Created] (ACCUMULO-4769) Sanity check for valid CryptoModule and KeyEncryptionStrategy in config

2017-12-20 Thread Nick Felts (JIRA)
Nick Felts created ACCUMULO-4769: Summary: Sanity check for valid CryptoModule and KeyEncryptionStrategy in config Key: ACCUMULO-4769 URL: https://issues.apache.org/jira/browse/ACCUMULO-4769 Project:

[GitHub] asfgit commented on issue #345: ACCUMULO-4769 Sanity check for valid CryptoModule and KeyEncryptionStrategy in config

2017-12-20 Thread GitBox
asfgit commented on issue #345: ACCUMULO-4769 Sanity check for valid CryptoModule and KeyEncryptionStrategy in config URL: https://github.com/apache/accumulo/pull/345#issuecomment-353105375 Can one of the admins verify this patch?

Accumulo-Pull-Requests - Build # 921 - Failure

2017-12-20 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #921) Status: Failure Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/921/ to view the results.

[jira] [Created] (ACCUMULO-4768) Monitor Look and Feel

2017-12-20 Thread Michael Miller (JIRA)
Michael Miller created ACCUMULO-4768: Summary: Monitor Look and Feel Key: ACCUMULO-4768 URL: https://issues.apache.org/jira/browse/ACCUMULO-4768 Project: Accumulo Issue Type: Improvement

Accumulo-Pull-Requests - Build # 922 - Fixed

2017-12-20 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #922) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/922/ to view the results.

Accumulo-Pull-Requests - Build # 923 - Failure

2017-12-20 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #923) Status: Failure Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/923/ to view the results.

[GitHub] PircDef opened a new pull request #345: ACCUMULO-4769 Sanity check for valid CryptoModule and KeyEncryptionStrategy in config

2017-12-20 Thread GitBox
PircDef opened a new pull request #345: ACCUMULO-4769 Sanity check for valid CryptoModule and KeyEncryptionStrategy in config URL: https://github.com/apache/accumulo/pull/345 Added a check to the ConfigSanityCheck to validate the cryptomodule and the keyencryptionstrategy Added unit

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r158041086 ## File path:

[GitHub] jkrdev commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
jkrdev commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#issuecomment-353078564 I did not mean to push those most recent commits, still making some changes.

[jira] [Assigned] (ACCUMULO-4768) Monitor Look and Feel

2017-12-20 Thread Michael Miller (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Miller reassigned ACCUMULO-4768: Assignee: Michael Miller > Monitor Look and Feel > - > >

[GitHub] jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
jmark99 commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r158021114 ## File path:

[GitHub] keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r158036209 ## File path:

[GitHub] jkrdev opened a new pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
jkrdev opened a new pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341 Many files were changed simply adding the close of the scanners that were initialized. If there is some convention about where the scanners should

[GitHub] milleruntime commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
milleruntime commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#issuecomment-353087570 No worries @jkrdev its your branch, do as you please! This

[GitHub] joshelser commented on issue #332: ACCUMULO-XXXX Use the hadoop3 shaded jars

2017-12-20 Thread GitBox
joshelser commented on issue #332: ACCUMULO- Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#issuecomment-353135042 > I don't know if these shaded jars are included in the standard Hadoop installation path (my hunch is not). Oh, they are included:

[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-XXXX Use the hadoop3 shaded jars

2017-12-20 Thread GitBox
joshelser commented on a change in pull request #332: ACCUMULO- Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r158085456 ## File path: server/base/pom.xml ## @@ -152,5 +148,40 @@ + + hadoop2 +

[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-XXXX Use the hadoop3 shaded jars

2017-12-20 Thread GitBox
joshelser commented on a change in pull request #332: ACCUMULO- Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r158086747 ## File path: start/pom.xml ## @@ -43,19 +43,14 @@ commons-vfs2 -

[GitHub] joshelser commented on issue #332: ACCUMULO-XXXX Use the hadoop3 shaded jars

2017-12-20 Thread GitBox
joshelser commented on issue #332: ACCUMULO- Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#issuecomment-353128702 >Would an Accumulo instance built against one work with the other? Unsure. >Do we need to have a different binary

[GitHub] bfach10 opened a new pull request #347: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
bfach10 opened a new pull request #347: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/347 This PR is incomplete. Requesting feedback on design to make sure this is a good direction for the Mutation API.

[GitHub] asfgit commented on issue #347: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
asfgit commented on issue #347: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/347#issuecomment-353140545 Can one of the admins verify this patch? This is an automated message from the

[jira] [Created] (ACCUMULO-4770) Accumulo monitor overview page is not listing all Zookeeper nodes

2017-12-20 Thread Mike Walch (JIRA)
Mike Walch created ACCUMULO-4770: Summary: Accumulo monitor overview page is not listing all Zookeeper nodes Key: ACCUMULO-4770 URL: https://issues.apache.org/jira/browse/ACCUMULO-4770 Project:

Accumulo-Pull-Requests - Build # 924 - Fixed

2017-12-20 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #924) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/924/ to view the results.

[GitHub] bfach10 closed pull request #346: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
bfach10 closed pull request #346: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/346 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[jira] [Updated] (ACCUMULO-4746) Create Builder for Mutation

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ACCUMULO-4746: - Labels: pull-request-available (was: ) > Create Builder for Mutation >

[jira] [Updated] (ACCUMULO-4769) Sanity check for valid CryptoModule and KeyEncryptionStrategy in config

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ACCUMULO-4769: - Labels: pull-request-available (was: ) > Sanity check for valid CryptoModule and

[GitHub] bfach10 opened a new pull request #346: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
bfach10 opened a new pull request #346: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/346 This PR is incomplete. Requesting feedback on design to make sure this is a good direction for the Mutation API.

Accumulo-Pull-Requests - Build # 925 - Failure

2017-12-20 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #925) Status: Failure Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/925/ to view the results.

[GitHub] joshelser commented on a change in pull request #332: ACCUMULO-XXXX Use the hadoop3 shaded jars

2017-12-20 Thread GitBox
joshelser commented on a change in pull request #332: ACCUMULO- Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r158085698 ## File path: pom.xml ## @@ -907,6 +922,10 @@ java17 1.0

[GitHub] jkrdev commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
jkrdev commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#issuecomment-353131598 Could I get some help with this error code? Where in the accumulo-test package is this? Or maybe I am just not understanding the

[GitHub] ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r158130885 ## File path: test/src/main/java/org/apache/accumulo/test/MetaGetsReadersIT.java ## @@ -112,6

[GitHub] ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r158129873 ## File path: test/src/main/java/org/apache/accumulo/test/ConditionalWriterIT.java ## @@

[GitHub] ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r158129512 ## File path: test/src/main/java/org/apache/accumulo/test/ClientSideIteratorIT.java ## @@

[GitHub] ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r158130498 ## File path: test/src/main/java/org/apache/accumulo/test/FileArchiveIT.java ## @@ -192,81

[GitHub] ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r158130696 ## File path: test/src/main/java/org/apache/accumulo/test/MetaGetsReadersIT.java ## @@ -68,6

[GitHub] ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#discussion_r158128286 ## File path: test/src/main/java/org/apache/accumulo/test/BatchWriterInTabletServerIT.java ##

Accumulo-Pull-Requests - Build # 926 - Fixed

2017-12-20 Thread Apache Jenkins Server
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #926) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/926/ to view the results.

[GitHub] mikewalch commented on a change in pull request #347: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
mikewalch commented on a change in pull request #347: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/347#discussion_r158152646 ## File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java ## @@ -772,6 +772,236 @@ public

[GitHub] mikewalch commented on a change in pull request #347: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
mikewalch commented on a change in pull request #347: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/347#discussion_r158153173 ## File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java ## @@ -772,6 +772,236 @@ public

[GitHub] mikewalch commented on a change in pull request #347: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
mikewalch commented on a change in pull request #347: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/347#discussion_r158098926 ## File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java ## @@ -772,6 +772,236 @@ public

[GitHub] ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r158156098 ## File path:

[GitHub] ctubbsii commented on a change in pull request #332: ACCUMULO-XXXX Use the hadoop3 shaded jars

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #332: ACCUMULO- Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r158135914 ## File path: pom.xml ## @@ -907,6 +922,10 @@ java17 1.0

[GitHub] keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
keith-turner commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-353191412 @ctubbsii are you finished looking at this?

[GitHub] ctubbsii commented on a change in pull request #332: ACCUMULO-XXXX Use the hadoop3 shaded jars

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #332: ACCUMULO- Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#discussion_r158136035 ## File path: start/pom.xml ## @@ -43,19 +43,14 @@ commons-vfs2 -

[GitHub] ctubbsii commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
ctubbsii commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-353205299 @keith-turner Yes. I'm finished now. I made one last comment up for discussion about the thrown

[GitHub] ctubbsii commented on issue #347: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
ctubbsii commented on issue #347: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/347#issuecomment-353181035 I haven't had time to do a full review of this yet, but wanted to remind that these new interfaces are necessarily in the public API, and we'll be

[jira] [Created] (ACCUMULO-4771) Replace tables in Monitor with DataTables

2017-12-20 Thread Michael Miller (JIRA)
Michael Miller created ACCUMULO-4771: Summary: Replace tables in Monitor with DataTables Key: ACCUMULO-4771 URL: https://issues.apache.org/jira/browse/ACCUMULO-4771 Project: Accumulo

[jira] [Commented] (ACCUMULO-4765) Improve sortTable js function

2017-12-20 Thread Michael Miller (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299207#comment-16299207 ] Michael Miller commented on ACCUMULO-4765: -- If we went with DataTables (ACCUMULO-4771) this

[GitHub] keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
keith-turner commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r158159801 ## File path:

[jira] [Commented] (ACCUMULO-4765) Improve sortTable js function

2017-12-20 Thread Christopher Tubbs (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299287#comment-16299287 ] Christopher Tubbs commented on ACCUMULO-4765: - Agreed. That would be a good solution. We

[GitHub] bfach10 commented on issue #346: ACCUMULO-4746 Fluent API for Mutation

2017-12-20 Thread GitBox
bfach10 commented on issue #346: ACCUMULO-4746 Fluent API for Mutation URL: https://github.com/apache/accumulo/pull/346#issuecomment-353117706 I chose the wrong branch :( This is an automated message from the Apache Git

[GitHub] jkrdev commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs

2017-12-20 Thread GitBox
jkrdev commented on issue #341: ACCUMULO-3902 Ensure [Batch]Scanners are closed in ITs URL: https://github.com/apache/accumulo/pull/341#issuecomment-353131598 Could I get some help with this error code? Where in the accumulo-test package is this? Or maybe I am just not understanding the

[GitHub] jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-353230116 I modified the exception from AccumuloException to IllegalArgumentException in the attachIterator method.

[GitHub] jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
jmark99 commented on issue #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#issuecomment-353230116 I modified the exception from AccumuloException to IllegalArgumentException in the attachIterator method.

[GitHub] ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables

2017-12-20 Thread GitBox
ctubbsii commented on a change in pull request #337: ACCUMULO-4732 No APIs to configure iterators or locality groups for new tables URL: https://github.com/apache/accumulo/pull/337#discussion_r158184648 ## File path: