GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-ets-lru/pull/6
Remove unused var in tests
Trivial fix to remove a variable in one of the tests' teardown function to
avoid "Unused variable" warning.
You can merge this pull request into a Git
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/72
Ported to apache/couchdb#488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user eiri closed the pull request at:
https://github.com/apache/couchdb-couch-mrview/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/73
Fix unused variables warning
This cleans up the artifacts left after [refactoring of
`couch_mrview_index:get/2`](https://github.com/apache/couchdb-couch-mrview/pull/65)
You can merge
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107330320
--- Diff: src/couch_mrview.erl ---
@@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) ->
end.
+get_total_rows(
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107325855
--- Diff: test/couch_mrview_local_docs_tests.erl ---
@@ -0,0 +1,134 @@
+% Licensed under the Apache License, Version 2.0 (the "License&q
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/72#discussion_r107318756
--- Diff: src/couch_mrview.erl ---
@@ -653,6 +653,18 @@ make_meta(Args, UpdateSeq, Base) ->
end.
+get_total_rows(
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/72
@davisp @iilyak Can you take a look, please, whenever you'll have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/239
Travis failed with infamous `gnutls_handshake() failed`, but fwiw local
tests all passed:
```
module 'chttpd_endpoints_tests
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/239
Prof looks promising. Can you add tests, just to be on a safe side? Feel
free to pull from here:
https://github.com/cloudant/couchdb-couch/commit/4358b8d678ab15d0153530a41f68ff7867b633a5
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/237
Looks good to me.
For a reference [here is what I came up
with](https://github.com/apache/couchdb-couch/compare/master...cloudant:add-lru-excluded-option)
---
If your project is set up
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/236
@davisp ok, I'm not talking about the issue we had, I'm talking about this
whole change - we effectively not using lru as eviction policy anymore, so
there are no point of tracking shards access
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/236
@davisp @nickva I think I haven't made myself clear. If we are closing
_everything_ idle, sys and none-sys, then that means when we are hitting
max_dbs_open we have max_dbs_open number of none
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/236
@davisp, @nickva I think I'm a bit confused here: if we don't use `lru` to
decide what to evict, what the point of having it? I mean, with this change we
indiscriminately removing anything
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/236
I ran some tests and this approach not working very well. Since
`close_db_if_idle` removes records from ets, but not from lru, "system" dbs
pushing "normal" dbs out of et
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/62#discussion_r105249451
--- Diff: src/couch_replicator_manager.erl ---
@@ -1005,6 +1013,38 @@ get_json_value(Key, Props, Default) when
is_binary(Key) ->
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-replicator/pull/62#discussion_r105246600
--- Diff: src/couch_replicator_manager.erl ---
@@ -1005,6 +1013,38 @@ get_json_value(Key, Props, Default) when
is_binary(Key) ->
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/232
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/227#discussion_r100148952
--- Diff: src/test_request.erl ---
@@ -51,6 +51,9 @@ delete(Url) ->
delete(Url, Opts) ->
request(delete, Url, [], [], Opts).
-
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/65#discussion_r100131808
--- Diff: src/couch_mrview_index.erl ---
@@ -23,84 +23,77 @@
-include_lib("couch_mrview/include/couch_mrview.hrl").
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/56
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/65#discussion_r99881145
--- Diff: src/couch_mrview_index.erl ---
@@ -23,84 +23,80 @@
-include_lib("couch_mrview/include/couch_mrview.hrl").
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/65
Refactor mrview_index get
This is a simple refactoring of mrview's `get/2` function that uses
function's pattern matching instead of staircase case.
Arguably this makes code
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/224
Don't crash on unexpected validation's error type
Validation function can throw JSON with error type different than forbidden
or unauthorized.
This patch makes couch return
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-replicator/pull/53
+1
note: the failing tests due to gnutls badness, `fatal: unable to access
'https://git-wip-us.apache.org/repos/asf/couchdb-couch-epi.git/':
gnutls_handshake() failed: A TLS
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-fabric/pull/85
Add admin ctx on open ddoc in group_info
Group info on ddocs in _users database require admin privileges.
COUCHDB-3279
You can merge this pull request into a Git repository by running
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb/pull/451
Updated couch dependencies
List of changes:
* Reset EOF if a partial write was possible
([COUCHDB-3274](https://issues.apache.org/jira/browse/COUCHDB-3274))
* Merge remote branch
Github user eiri closed the pull request at:
https://github.com/apache/couchdb/pull/450
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb/pull/450
Bump dependencies for couch, chttpd and fabric
List of changes:
chttpd: cb0f20..90648a
* allow w parameter for attachments
fabric: 205064..998cf2
* Handle no_pass message
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/221
@kxepal I agree on tests, but it's a bit awkward, with handler been here
and tests need to be in `chttpd`, so they guarantee to fail. I'll add them
after this get merged and added to rebar's
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/221
Improve errors on invalid "count" parameter in /_uuids
Added validation on "count" parameter to be positive and changed return
code for "count" exceeding ma
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/220
@iilyak yes, this seems to be a better approach, updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eiri closed the pull request at:
https://github.com/apache/couchdb-couch-mrview/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/64
All right, this is incorrect.
In `#mrview` record the fields `update_seq` and `purge_seq` should always
be set to the latest db update/purge seq that altered the view, because sole
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/64
Fix convertion of view states
It is possible to have one or multiple view states to be nil when their
views do not emit documents.
As a result update and purge sequences could
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb/pull/447
Bump dependencies
This update brings all the dependencies up to date. The commits are
grouping updates as they've been merged on according masters and done in
chronological order.
You can merge
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/63
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-mem3/pull/26
Chunk missing revisions before attempting to save on target
In cases with pathological documents revision patterns (e.g., 1 open
conflicts and tree depth of 30 on a single document
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/214
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/61
Remove side effect from accumulate_more
In mrview's updater we regulate the size of processed docs batch either by
number of items or by memory it allocates. We are comparing threshold
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/213
Add test for filter _changes by filters function
This adds tests for basic filtering of _changes feed by "filters" function
both for filtering by doc attributes and by passed in requ
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/150#discussion_r87641585
--- Diff: src/chttpd_db.erl ---
@@ -83,7 +83,8 @@
handle_changes_req(#httpd{path_parts=[_,<<"_changes">>]}=Req, _Db) ->
h
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/150
Include user_ctx in db open options
Previously original `Db` record was kept on `filter_fun` tuple in
`#changes_args` and passed to the filters. Now we are throwing it away and
including `Db
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/210
Not sure why travis is stuck here, but locally tests are passing. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/210#discussion_r86540764
--- Diff: src/couch_file.erl ---
@@ -625,10 +627,12 @@ read_raw_iolist_int(#file{fd = Fd, pread_limit =
Limit} = F, Pos, Len) ->
case
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch/pull/210#discussion_r86384849
--- Diff: src/couch_file.erl ---
@@ -625,10 +627,12 @@ read_raw_iolist_int(#file{fd = Fd, pread_limit =
Limit} = F, Pos, Len) ->
case
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/200
Passed locally. LGTM.
```
Compiled test/couchdb_mrview_tests.erl
EUnit
module 'couchdb_mrview_tests'
Check show
Github user eiri commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/140
Let's make the error "Invalid request body", to cover cases with
`max_document_size` exceeded and because we seems to use more verbose forms on
`bad_request` and +1
---
If your proj
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-replicator/pull/47
Validate boolean parameters in /_replicate payload
Unlike `/_replicator`, end-point `/_replicate` doesn't check type for the
boolean parameters in payload, which leads replicator
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/193
@rnewson I did it at first, but then decided to go with less confusing
error message for the users sake. If you think it's not a problem here then
sure, I'll use guards.
---
If your project
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/193
Fix validation for ddoc and _local id
Because binary match treats end of binary as `<<>>` we are validating
"_design/" and "_local/" as proper ids.
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/54
Tested and this is the correct fix +1. But can we wrap that line at 80
chars, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/190
Closing in favour of #191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eiri closed the pull request at:
https://github.com/apache/couchdb-couch/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/191
@davisp Here is the redo we talked about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/191
Reference on conversation about this change #190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/191
Simplify proc manager by moving assignment logic in one place
This changes how proc manager handles proc assignment. Instead of doing
this in three different places: `get_proc` call handler
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/190
Okey-dokey, I'll redo this with `maybe_teach_ddoc`.
Should I add a feature to disable hard limit as well? Right now it's not
possible, unless setting it to something with a lot of zeros
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/190
Well, my reasoning was that the waiters got into wait because hard limit
was reached, i.e. we haven't found idle process that already know about
requestor's ddoc, we haven't found idle process
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/190
@davisp Can you please take a look if this looks like a right solution for
you? I know it solves the issue with "query_protocol_error", doesn't lead to
waiters timeouts and doesn't
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/190
Unblock waiting processes during idle process remove
To clarify the description of the problem here is some terminology used in
the process manager:
- idle process - a running os
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/61#discussion_r70139806
--- Diff: src/fabric_group_info.erl ---
@@ -58,17 +58,23 @@ handle_message({rexi_EXIT, Reason}, Shard, {Counters,
Acc, Ushards}) ->
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/61#discussion_r70134251
--- Diff: src/fabric_group_info.erl ---
@@ -58,17 +58,23 @@ handle_message({rexi_EXIT, Reason}, Shard, {Counters,
Acc, Ushards}) ->
Github user eiri commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/126
Closing this, going to look into re-enabling temp views instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch/pull/181
@davisp here is the short fix we've discussed on Monday.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eiri commented on the issue:
https://github.com/apache/couchdb-chttpd/pull/125
@iilyak `design_doc_view` used with POST and keys and that I did check,
works fine. I haven't specially checked `all_docs_view`, but at first glance it
looks like it should be good: vacc
Github user eiri commented on the issue:
https://github.com/apache/couchdb-fabric/pull/58
@davisp check it out, I've noticed it by a chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-fabric/pull/58
Fix match in fabric_doc_open_revs reply
Message handler in `fabric_doc_open_revs` returns tagged with 'ok' list of
the replies and not expected `{ok, Reply}` tuple. This makes reply to go
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/48
@rnewson Changes it to use your suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/56#discussion_r2235
--- Diff: src/fabric_db_update_listener.erl ---
@@ -155,4 +162,11 @@ handle_message(done, _, _) ->
{stop,
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-fabric/pull/56#discussion_r66659877
--- Diff: src/fabric_db_update_listener.erl ---
@@ -155,4 +162,11 @@ handle_message(done, _, _) ->
{stop,
Github user eiri commented on the issue:
https://github.com/apache/couchdb-fabric/pull/56
it works. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eiri closed the pull request at:
https://github.com/apache/couchdb-couch-mrview/pull/47
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/47
Ah yes, I thought we are talking about this particular JSON_DECODE. So the
guard on `is_list` here is not to tell json from a term apart, but for
optimization reasons?
Passing
Github user eiri commented on the issue:
https://github.com/apache/couchdb-couch-mrview/pull/47
We are _not_ calling JSON_DECODE twice, this is not the problem here. We
are getting list of query attributes as a json payload, decoding it
[here](https://github.com/apache/couchdb-chttpd
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/47#discussion_r66324338
--- Diff: src/couch_mrview_http.erl ---
@@ -576,6 +576,9 @@ check_view_etag(Sig, Acc0, Req) ->
parse_json(V) when is_lis
Github user eiri commented on a diff in the pull request:
https://github.com/apache/couchdb-chttpd/pull/125#discussion_r66286884
--- Diff: src/chttpd_view.erl ---
@@ -33,8 +33,7 @@ multi_query_view(Req, Db, DDoc, ViewName, Queries) ->
Acc1
end, VA
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/126
Return error 400 on temporary view request
The request for temporary view is currently returning "403 Forbidden"
error, which is implying a permissions issue. Error "400 Bad
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/47
Don't try to decode non-stringified JSON in params
It is possible for the params "key", "keys", "startkey" and "endkey" to
receive already d
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/125
Don't expect #vacc as a response of end_delayed_json_response in
multi_query_view
When `multi_query_view` is calling `chttpd:end_delayed_json_response/1` it
is passing it the response
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/123
Fix _node/$node/_system endpoint
The endpoint is using the same handler as a backdoor interface, which only
works for the requests to a local $node. For rpc calls to the remote nodes, as
it's
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb/pull/421
Set default_security for the tests to everyone
This sets default security for the eunit tests to "everyone" to allow them
pass again
You can merge this pull request into a Git repository
Github user eiri commented on the pull request:
https://github.com/apache/couchdb/pull/420#issuecomment-221594599
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/46#issuecomment-221553269
nice findings! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user eiri commented on the pull request:
https://github.com/apache/couchdb/pull/419#issuecomment-221388487
+1
```bash
$ make check apps=couch_index skip_deps=couch_epi
< skip >
module 'couch_index'
Compaction tests
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/175
Fix vhosts oauth tests
In eunits the default security is "admin_local" and default security object
for it was recently changed. This sets default_security for oauth tests to
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-fabric/pull/51#issuecomment-220305078
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/28#issuecomment-220097203
@kxepal @davisp : Bump for a great justice.
*.d files in question appears to be "deps files" generated by rebar's
[port_compiler](https://github.com/r
Github user eiri commented on the pull request:
https://github.com/apache/couchdb/pull/416#issuecomment-220007461
@kxepal Yes, apache/couchdb-couch part got in rebar.config as it happened
to be downstream of admin_local work, so mrview's bit got left behind.
The test failures
Github user eiri commented on the pull request:
https://github.com/apache/couchdb/pull/416#issuecomment-219858120
@kxepal can you take a look, please? this bumps mrview up to HEAD and
should resolve one of those pesky test failures we have on travis.
---
If your project is set up
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/173#issuecomment-219835491
@davisp Can you take a quick look, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/173
Prevent reading beyond end of file and add config parameter to limit maxium
pread size
When a database file goes corrupt it is possible that pread will receive
bogus length and place a large
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb/pull/416
Update to the latest mrview
This includes all the changes made to couch_mrview since the last deps
update
You can merge this pull request into a Git repository by running:
$ git pull https
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/commit/78f575ec2cac823605561f1b38e0761d8170ac5f#commitcomment-17481247
@janl
Travis was throwing those errors because this change affects two repos -
#161 and
[couchdb-couch-mrview#44
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch/pull/169
Raise better exception on attempt to decompress corrupt binary
Right now when a binary without compression prefix passed on
`couch_compress:decompress/1` (for example if a database file got
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/161#issuecomment-214780198
Companion PR apache/couchdb-couch-mrview#44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user eiri opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/44
Use couch_file:delete/3 in views cleanup
Use `couch_file:delete/3` directly instead of one-op front function.
All the tests moved in `couch_file_tests`.
Depends on apache
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/161#issuecomment-211923314
@davisp I thought there are performance penalty on deleting a lot of files
in deep filesystem hierarchy, I remember @rnewson mentioned this while we've
been
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/161#issuecomment-209616524
@rnewson View compaction files handled in `couch_file:deleted/3` function
which does what the first PR comment describes and you are commenting
Github user eiri commented on the pull request:
https://github.com/apache/couchdb-couch/pull/161#issuecomment-207643204
@rnewson My goal was not change the delete process, but to preserve
existing behaviour and the code does _exactly_ what've been done here
previously. My
1 - 100 of 217 matches
Mail list logo
