[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...
Github user nickva commented on the issue: https://github.com/apache/couchdb-documentation/pull/83 Look great, @warmana Merged. Thank you again, for your contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #83: Describe selector objects as part of...
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-documentation/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-chttpd issue #147: Make auth handlers configurable.
Github user kocolosk commented on the issue: https://github.com/apache/couchdb-chttpd/pull/147 Nice @dmunch. This remains a somewhat janky part of our codebase and I think you were smart to do this in a minimally-invasive way. ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #761: New replication
Github user justin-mcdavid-ibm commented on the issue: https://github.com/apache/couchdb-fauxton/pull/761 Hey Garren-- This is coming along great. Comments below. # Activity Page: 1. When I click on the column header, it changes the active-state coloring to orange, but I need to click a second time for it to do the actual sorting. 2. Is it possible to just highlight the sorting triangle, rather than the entire column-header text? 3. Change the Activity tab label to "Replicator DB Activity." 4. Add some padding (try 8px?) between the funnel icon and the Filter Replications entry box 5. Increase the text size of and padding around action icons. Warehousing uses 16px for the icons. _all_dbs uses 19px (+enclosure box). I think 16px font and 8px left/right padding should suffice with our current information density. 6. Encoding for db names containing forward slashes still appears to be broken for source/target displays in Activity. The broken encoding also extends to the linking to the actual databases. 7. The action to edit the Replication document for a job listed in the activity section doesn't appear to be working yet. 8. Same with the action to view the Replication document. 9. The Verify Deletion dialogue does not differentiate between single-doc deletions, and multi-doc deletions (performed through the bulk-selector). It would probably be better if the dialogue triggered through the bulk selector had it's own (pluralized) text and could reference the actual number of documents being deleted. (Instead of "You are deleting a replication document." make it "You are deleting replication documents." 10. When does the Activity page refresh? I'm wondering if we should have polling/refresh controls on the page, similarly to how we have them for Monitoring and Active Tasks. 11. Replication jobs that fail to create a new local database still have active links to the non-existant database. # New Replication Page 1. The Start Replication button is not quite aligned with the field above it. If they could be left-aligned, it would be great. 2. Padding and password-entry-box length on the replication dialogue are broken. Also, what are requirements around this? How regularly should it be asking for password, if you're triggering multiple jobs. Can we have permission extend over a session? 3. Infield-text on the dialogue's password-entry box should be change to "Local-account password." Apologies for the confusion, but please remove the period from the end of the dialogue box's title, as well. 4. I got a "Database target may not start with an underscore." error when attempting to replicate to an existing db named "a_c." So it looks like the validation might be a bit overzealous there. Also, is that message new? And a way to prevent replicating system dbs? I'm a little gunshy to test this, but I see that the "Start Replication" button is active if I select my local _replicator as both source and target. Perhaps we can strip dbs starting with an underscore from the source/target dropdowns, as well? Also, now I'm still getting the underscore error, but none of the information in the form contains underscores, so it looks like something buggier might be afoot. 5. Related to above: Did you add validation to prevent replicating a database to itself? 6. Change the "Database target may not start with an underscore." message to "The names of database sources and targets cannot begin with underscores." (and then you can reuse this message for underscored sources, as well. 7. I can still use local -> new remote replication to replicate into an **existing** remote database. Same goes for replicating something to a "new" database that actually already exists. There should be an error for remote-instance-overwrite attempts, and validation for local-instance-overwrite attempts. 8. To reduce triggering of multiple jobs (and the errors that would arise), after a Replication is triggered, the "Start Replication" button should go into an inactive state until a change has been made to the form. 9. Can we implement the replication-doc conflicting handling described here: https://github.com/apache/couchdb-fauxton/pull/761#issuecomment-249692858 # General 1. The "Replication" breadcrumb for the replication section takes you to New Replication, rather than the Activity page; however, unless Advanced Replication is going to happen sometime soon (which it doesn't look like it will), I think it would be better to follow the same model we have for Warehousing, where there is a Create Replication button on the Activity page, and then the creation page has breadcrumbs and no tabs. 2. The message upon triggering a replication job is not quite correct. It states that "Replication from to has begun." which isn't actually the case if the job
[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...
Github user warmana commented on the issue: https://github.com/apache/couchdb-documentation/pull/83 Aha, apologies for both of those. I can and will fix them... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (COUCHDB-3202) do not allow empty field names
Tony Sun created COUCHDB-3202: - Summary: do not allow empty field names Key: COUCHDB-3202 URL: https://issues.apache.org/jira/browse/COUCHDB-3202 Project: CouchDB Issue Type: Bug Components: Mango Reporter: Tony Sun {"" : "foo} crashes our mango indexer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] couchdb-fauxton pull request #789: 3045 Replace safeURLName in code
GitHub user millayr opened a pull request: https://github.com/apache/couchdb-fauxton/pull/789 3045 Replace safeURLName in code **Task description from ticket:** We have a still some usages of safeURLName where we manually slice of the _design prefix for design docs. Later we glue the prefix on again. We have a helper function that handles that already, which is also available in the utils.js file. Task: find appearances of safeURLName with code search, understand how it is used, remove custom safeURLName shenanigans with their design doc handling and replace it with other helper function. **Change Description** I located two places where it made sense to update safeURLName to getSafeIdForDoc. While there were several places we use safeURLName in Fauxton, not all of them needed to be changed. I'm open to feedback, however, if others feel as though I missed some instances where it did make sense to update. You can merge this pull request into a Git repository by running: $ git pull https://github.com/millayr/couchdb-fauxton 3045-replace-safeURLName-in-code Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/789.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #789 commit 74ffea12742397ed60f85db04ec7f34bc57f2ee5 Author: Ryan MillayDate: 2016-10-18T19:51:01Z replacing safeURLName with getSafeIdForDoc where appropriate --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #82: Update unix.rst
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-documentation/pull/82 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #82: Update unix.rst
Github user nickva commented on the issue: https://github.com/apache/couchdb-documentation/pull/82 +1 Good find @elainexmas! Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #83: Describe selector objects as part of a repl...
Github user nickva commented on the issue: https://github.com/apache/couchdb-documentation/pull/83 Looks good @warmana . Thank you. One minor thing is some lines are two long and the make lint check target for documentation is failing (if you clink on the red X it shows some of the failing lines). Here is one example line: ``` python ext/linter.py src/ /home/travis/build/apache/couchdb-documentation/src/json-structure.rst line 246 : too long (86 > 80) line ++---+ line 247 : too long (86 > 80) line | Field | Description | ``` Also I see this for the main check: ``` /Users/nvatama/asf/couchdb/src/docs/src/replication/replicator.rst line 437 : too many empty lines line 437 : no empty last lines please ``` Would it be possible to make the lines shorter or it is part of the table, it would completely break the layout? If it is too hard, we can look at perhaps disabling the warning for that file. Let me know if you need help, I can try to do some of these cleanups if setting up the doc compilation chain is too tricky. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #80: welcome
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-documentation/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #80: welcome
Github user nickva commented on the issue: https://github.com/apache/couchdb-documentation/pull/80 @stleon Done. Sorry for the delay. Thank you for your help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #788: 3189 - Long database names overlap header
Github user millayr closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/788 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (COUCHDB-3189) Long database names overlap header
[ https://issues.apache.org/jira/browse/COUCHDB-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Kowalski resolved COUCHDB-3189. -- Resolution: Fixed fixed with https://github.com/apache/couchdb-fauxton/pull/788 > Long database names overlap header > -- > > Key: COUCHDB-3189 > URL: https://issues.apache.org/jira/browse/COUCHDB-3189 > Project: CouchDB > Issue Type: Bug > Components: Fauxton >Reporter: Robert Kowalski > Labels: beginner, newbie > Attachments: Screen Shot 2016-10-12 at 14.17.28.png > > > In the _all_docs list long database names overlap the middle section. > This is a task especially suitable for new CouchDB contributors. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] couchdb-fauxton issue #788: 3189 - Long database names overlap header
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/788 merged, you can close the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #788: 3189 - Long database names overlap header
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/788 +1 good work. waiting for testsuite to get green now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #788: 3189 - Long database names overlap header
GitHub user millayr opened a pull request: https://github.com/apache/couchdb-fauxton/pull/788 3189 - Long database names overlap header Tweaked CSS to truncate database names with an ellipsis on overflow. You can merge this pull request into a Git repository by running: $ git pull https://github.com/millayr/couchdb-fauxton 3189-long-database-names-overlap-header Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-fauxton/pull/788.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #788 commit adbcbef303deb2fdc4dc7a1a0ed4183129c743df Author: Ryan MillayDate: 2016-10-18T14:23:09Z updating overflow behavior for db name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation issue #80: welcome
Github user stleon commented on the issue: https://github.com/apache/couchdb-documentation/pull/80 @nickva can you merge new changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #782: Encoding blerg
Github user garrensmith commented on the issue: https://github.com/apache/couchdb-fauxton/pull/782 ok then I'm +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-documentation pull request #83: Describe selector objects as part of...
GitHub user warmana opened a pull request: https://github.com/apache/couchdb-documentation/pull/83 Describe selector objects as part of a replication document. Add material explaining what a selector object is, in the context of a replication document. Point out that it is one of three options for controlling replication. Point out that using a selector object is preferable to using a filter function. You can merge this pull request into a Git repository by running: $ git pull https://github.com/warmana/couchdb-documentation-fork describeSelectorInReplicationDocument Alternatively you can review and apply these changes as the patch at: https://github.com/apache/couchdb-documentation/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit c92f59ceee622ef64a658f0eb6c7f643539aff76 Author: Adrian WarmanDate: 2016-10-18T12:09:53Z Add material describing selector objects as part of a replication document. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton issue #782: Encoding blerg
Github user robertkowalski commented on the issue: https://github.com/apache/couchdb-fauxton/pull/782 @garrensmith yes, those are existing issues in the documents section we would have to fix in the future, too. they are also on master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] couchdb-fauxton pull request #787: Updating hover colors for notification ce...
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/787 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---