[GitHub] nickva commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

nickva commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#discussion_r232427519 ## File path: src/chttpd/src/chttpd_db.erl ## @@ -481,18 +482,62 @@

[GitHub] nickva commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

nickva commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#discussion_r232427519 ## File path: src/chttpd/src/chttpd_db.erl ## @@ -481,18 +482,62 @@

[Jenkins] FAILURE: CouchDB » master #391

Boo, we failed. https://builds.apache.org/job/CouchDB/job/master/391/

[GitHub] nickva closed pull request #1722: Retain replication stats between job runs

nickva closed pull request #1722: Retain replication stats between job runs URL: https://github.com/apache/couchdb/pull/1722 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] jaydoane commented on a change in pull request #1722: Retain replication stats between job runs

jaydoane commented on a change in pull request #1722: Retain replication stats between job runs URL: https://github.com/apache/couchdb/pull/1722#discussion_r232361229 ## File path: src/couch_replicator/src/couch_replicator_scheduler_job.erl ## @@ -159,16 +159,9 @@

[GitHub] wohali commented on issue #328: feat: update docs for new query server config

wohali commented on issue #328: feat: update docs for new query server config URL: https://github.com/apache/couchdb-documentation/pull/328#issuecomment-437497524 Think this needs updating for changes to SSL config still. We fully scrubbed out proxy stuff and os_daemons already.

[Jenkins] SUCCESS: CouchDB » master #390

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/390/

[GitHub] wohali commented on issue #1724: [Feature Proposal] Pull Request to add support for Erlang-only validate_doc_read functions

wohali commented on issue #1724: [Feature Proposal] Pull Request to add support for Erlang-only validate_doc_read functions URL: https://github.com/apache/couchdb/issues/1724#issuecomment-437473945 I'm -0.5 on the proposal. Concerns: 1) Overall throughput decrease if a

[GitHub] janl closed pull request #1723: feat: update couch-config to match #1602

janl closed pull request #1723: feat: update couch-config to match #1602 URL: https://github.com/apache/couchdb/pull/1723 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] Antonio-Maranhao opened a new issue #1156: Add Nightwatch tests to validated partitioned database functions

Antonio-Maranhao opened a new issue #1156: Add Nightwatch tests to validated partitioned database functions URL: https://github.com/apache/couchdb-fauxton/issues/1156 Currently there are no Nightwatch tests against partitioned databases because the feature is not yet available on the

[GitHub] Antonio-Maranhao opened a new pull request #1155: [partitioned dbs] Support partitioned mango queries and creating partitioned indexes

Antonio-Maranhao opened a new pull request #1155: [partitioned dbs] Support partitioned mango queries and creating partitioned indexes URL: https://github.com/apache/couchdb-fauxton/pull/1155 ## Overview Sixth in a series of PRs that will be submitted in support of the new

[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437447396 @nickva Thanks! Indeed it was some intermittent failure. All is good now. Let me know

[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437447396 @nickva Thanks! Indeed it was some sporadic fail. All is good now. Let me know if I need to

[GitHub] nickva commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

nickva commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437435048 Ah it's probably flaky, I'll try to restart it

[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5

[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5

[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5

[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5

[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437421418 @nickva I checked Travis logs and seemingly only one job `Job #6237.5` for OTP 17.5 failed for

[GitHub] zacharylawson commented on issue #323: Update purging.rst

zacharylawson commented on issue #323: Update purging.rst URL: https://github.com/apache/couchdb-documentation/pull/323#issuecomment-437414064 @jiangphcn my pleasure, updated the branch. This is an automated message from the

[GitHub] AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437410621 Valid point. `meck:unload()` has been incorporated. As for failed test this failure is

[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437410621 Valid point. `meck:unload()` has been incorporated. As for failing test this failure is due to

[GitHub] AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#discussion_r232308403 ## File path: src/chttpd/test/chttpd_db_bulk_get_multipart_test.erl

[GitHub] nickva edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

nickva edited a comment on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437400416 Looks much better. Nice work cleaning it up. I see eunit test failures locally and in Travis.

[GitHub] nickva commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

nickva commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437400416 Look better. Nice work cleaning it up. I see eunit test failures locally and in Travis. Not sure

[GitHub] nickva commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

nickva commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#discussion_r232297634 ## File path: src/chttpd/test/chttpd_db_bulk_get_multipart_test.erl ##

[GitHub] smithsz opened a new pull request #130: Only return Promise from `headDoc` when no callback is specified.

smithsz opened a new pull request #130: Only return Promise from `headDoc` when no callback is specified. URL: https://github.com/apache/couchdb-nano/pull/130 ## Overview Only return a `Promise` from `headDoc` when no user callback is specified. ## Testing

[Jenkins] SUCCESS: CouchDB » master #389

Yay, we passed. https://builds.apache.org/job/CouchDB/job/master/389/

[GitHub] janl opened a new pull request #1723: feat: update couch-config to match #1602

janl opened a new pull request #1723: feat: update couch-config to match #1602 URL: https://github.com/apache/couchdb/pull/1723 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] couchdb-config pull request #20: fix tests for #1602

Github user asfgit closed the pull request at: https://github.com/apache/couchdb-config/pull/20 ---

[GitHub] janl closed pull request #1602: Remove runtime configurability of core system components

janl closed pull request #1602: Remove runtime configurability of core system components URL: https://github.com/apache/couchdb/pull/1602 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov commented on issue #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#issuecomment-437357434 Hello @nickva Once again thank you for a thorough review and your comments. I've addressed

[GitHub] tudordumitriu commented on issue #1712: Validate Document Update oldDoc in ddoc is null after doc PUT for n=1 server

tudordumitriu commented on issue #1712: Validate Document Update oldDoc in ddoc is null after doc PUT for n=1 server URL: https://github.com/apache/couchdb/issues/1712#issuecomment-437343263 Here it is a clean log after enabling debug This problem occurs randomly and by chance I just

[GitHub] janl edited a comment on issue #1602: Remove runtime configurability of core system components

janl edited a comment on issue #1602: Remove runtime configurability of core system components URL: https://github.com/apache/couchdb/pull/1602#issuecomment-421311043 Depends on: https://github.com/apache/couchdb-config/pull/20 Docs PR:

[GitHub] janl commented on issue #1602: Remove runtime configurability of core system components

janl commented on issue #1602: Remove runtime configurability of core system components URL: https://github.com/apache/couchdb/pull/1602#issuecomment-437319020 Pending any test issues and/or review notes, this is good to go now. Thanks everyone for the input!

[GitHub] janl commented on issue #1602: Remove runtime configurability of core system components

janl commented on issue #1602: Remove runtime configurability of core system components URL: https://github.com/apache/couchdb/pull/1602#issuecomment-437317772 > @janl How is httpsd enabled in this new world? Previously that would have been: @wohali good one, I’ve made this

[GitHub] AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#discussion_r232206895 ## File path: src/chttpd/src/chttpd_db.erl ## @@ -476,19

[GitHub] AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#discussion_r232206895 ## File path: src/chttpd/src/chttpd_db.erl ## @@ -476,19

[GitHub] AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related"

AlexanderKaraberov commented on a change in pull request #1195: Add support for bulk get with Accept:"multipart/mixed" or "multipart/related" URL: https://github.com/apache/couchdb/pull/1195#discussion_r232206895 ## File path: src/chttpd/src/chttpd_db.erl ## @@ -476,19

[GitHub] janl edited a comment on issue #1602: Remove runtime configurability of core system components

janl edited a comment on issue #1602: Remove runtime configurability of core system components URL: https://github.com/apache/couchdb/pull/1602#issuecomment-437304265 > also noting that changing couchjs stack size is an important ability. Since query servers can still be setup using

[GitHub] janl commented on a change in pull request #1602: Remove runtime configurability of core system components

janl commented on a change in pull request #1602: Remove runtime configurability of core system components URL: https://github.com/apache/couchdb/pull/1602#discussion_r232193171 ## File path: src/couch/src/couch_secondary_sup.erl ## @@ -26,6 +26,16 @@ init([]) ->

[GitHub] janl commented on issue #1602: Remove runtime configurability of core system components

janl commented on issue #1602: Remove runtime configurability of core system components URL: https://github.com/apache/couchdb/pull/1602#issuecomment-437304265 > also noting that changing couchjs stack size is an important ability. Since query servers can still be setup using env

[GitHub] janl commented on issue #1602: Remove runtime configurability of core system components

janl commented on issue #1602: Remove runtime configurability of core system components URL: https://github.com/apache/couchdb/pull/1602#issuecomment-437303960 > I'm +1 on removing runtime configurability but would prefer that the configuration is expressed in the .app files of the