pivotal-jbarrett commented on code in PR #7740:
URL: https://github.com/apache/geode/pull/7740#discussion_r887358938
##
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java:
##
@@ -966,6 +965,16 @@ public void recoverPrimary(Set
nabarunnag commented on code in PR #7740:
URL: https://github.com/apache/geode/pull/7740#discussion_r887320991
##
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java:
##
@@ -862,8 +862,9 @@ public void recoverPrimary(Set
excludedServers) {
kirklund merged PR #7731:
URL: https://github.com/apache/geode/pull/7731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirklund merged PR #7748:
URL: https://github.com/apache/geode/pull/7748
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jchen21 merged PR #7730:
URL: https://github.com/apache/geode/pull/7730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mivanac opened a new pull request, #7749:
URL: https://github.com/apache/geode/pull/7749
### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [*] Has your PR been rebased against the latest commit
jchen21 commented on code in PR #7730:
URL: https://github.com/apache/geode/pull/7730#discussion_r887261495
##
geode-assembly/src/upgradeTest/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTestBase.java:
##
@@ -105,7 +108,10 @@ protected void
jchen21 commented on code in PR #7730:
URL: https://github.com/apache/geode/pull/7730#discussion_r887245832
##
geode-assembly/src/upgradeTest/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTestBase.java:
##
@@ -105,7 +108,10 @@ protected void
onichols-pivotal commented on PR #7748:
URL: https://github.com/apache/geode/pull/7748#issuecomment-1144087982
looks good syntactically, just need @dschneider-pivotal to approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pivotal-jbarrett commented on code in PR #7740:
URL: https://github.com/apache/geode/pull/7740#discussion_r887255651
##
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java:
##
@@ -862,8 +862,9 @@ public void recoverPrimary(Set
excludedServers)
kirklund opened a new pull request, #7748:
URL: https://github.com/apache/geode/pull/7748
Add Darrel to geode-dunit and geode-junit while Dale is unavailable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pivotal-jbarrett commented on code in PR #7740:
URL: https://github.com/apache/geode/pull/7740#discussion_r887249683
##
geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java:
##
@@ -862,8 +862,9 @@ public void recoverPrimary(Set
excludedServers)
nabarunnag merged PR #7375:
URL: https://github.com/apache/geode/pull/7375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pivotal-jbarrett commented on code in PR #6970:
URL: https://github.com/apache/geode/pull/6970#discussion_r887230861
##
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/HAOverflowMemObjectSizerDUnitTest.java:
##
@@ -95,13 +95,13 @@ public final void
pivotal-jbarrett commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r887221766
##
build-tools/geode-dependency-management/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy:
##
@@ -46,6 +46,7 @@ class
nabarunnag commented on code in PR #7744:
URL: https://github.com/apache/geode/pull/7744#discussion_r887227672
##
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionStatsDistributedTest.java:
##
@@ -109,109 +121,129 @@ public void
nabarunnag commented on code in PR #7744:
URL: https://github.com/apache/geode/pull/7744#discussion_r887220667
##
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionStatsDistributedTest.java:
##
@@ -220,45 +252,48 @@ private void
nabarunnag commented on code in PR #7744:
URL: https://github.com/apache/geode/pull/7744#discussion_r887220026
##
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionStatsDistributedTest.java:
##
@@ -51,55 +51,67 @@ public class
kirklund commented on PR #7731:
URL: https://github.com/apache/geode/pull/7731#issuecomment-1143980188
@dschneider-pivotal
`windows-unit-test-oopenjdk11` seems to have hit a concourse failure:
`geode-ci/ci/scripts/archive_results.sh: line 93: pushd:
DonalEvans commented on code in PR #7744:
URL: https://github.com/apache/geode/pull/7744#discussion_r887158208
##
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionStatsDistributedTest.java:
##
@@ -51,55 +51,67 @@ public class
dschneider-pivotal commented on PR #7731:
URL: https://github.com/apache/geode/pull/7731#issuecomment-1143954324
are the Windows failures known issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jchen21 merged PR #7739:
URL: https://github.com/apache/geode/pull/7739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rhoughton-pivot merged PR #7743:
URL: https://github.com/apache/geode/pull/7743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirklund commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r88702
##
geode-assembly/src/acceptanceTest/java/org/apache/geode/management/internal/rest/StandaloneClientManagementAPIAcceptanceTest.java:
##
@@ -115,14 +115,19 @@
albertogpz opened a new pull request, #7747:
URL: https://github.com/apache/geode/pull/7747
This is the implementation of the feature
described in RFC:
https://cwiki.apache.org/confluence/display/GEODE/Management+of+threads+stuck+for+a+long+time+in+Geode
### For
albertogpz opened a new pull request, #7746:
URL: https://github.com/apache/geode/pull/7746
The Geode documentation states on conflation:
"When an update is added to a queue that has conflation enabled,
if there is already an update message in the queue for the
entry key, then the
nabarunnag commented on PR #7375:
URL: https://github.com/apache/geode/pull/7375#issuecomment-1143099430
@boglesby I made sure that stacktrace is always printed in these changes
@dschneider-pivotal I switch to using .warn(String,Throwable) API which
ensures the stack is printed as per
jinmeiliao merged PR #7720:
URL: https://github.com/apache/geode/pull/7720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pivotal-jbarrett commented on code in PR #7738:
URL: https://github.com/apache/geode/pull/7738#discussion_r886192747
##
geode-core/src/integrationTest/java/org/apache/geode/cache/RetryPutIfAbsentIntegrationTest.java:
##
@@ -14,73 +14,94 @@
*/
package org.apache.geode.cache;
dschneider-pivotal commented on code in PR #7738:
URL: https://github.com/apache/geode/pull/7738#discussion_r886181394
##
geode-core/src/main/java/org/apache/geode/internal/cache/map/RegionMapPut.java:
##
@@ -430,6 +432,16 @@ private boolean checkCreatePreconditions() {
nabarunnag opened a new pull request, #7744:
URL: https://github.com/apache/geode/pull/7744
* Renamed to PartitionedRegionStatsDistributedTest
* Used the new test framework
* Compartmentalize the cluster members so that parallel tests do not
affect the individual tests.
pivotal-jbarrett commented on code in PR #7730:
URL: https://github.com/apache/geode/pull/7730#discussion_r886102240
##
geode-assembly/src/upgradeTest/java/org/apache/geode/session/tests/TomcatSessionBackwardsCompatibilityTestBase.java:
##
@@ -105,7 +108,10 @@ protected void
nabarunnag merged PR #7741:
URL: https://github.com/apache/geode/pull/7741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rhoughton-pivot opened a new pull request, #7743:
URL: https://github.com/apache/geode/pull/7743
Introduce parallelism to additional Windows tests, getting runtime down to
an hour or so
windows-acceptance-test is not applicable for port-usage reasons.
### For all
jinmeiliao commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r885894426
##
geode-common/src/main/java/org/apache/geode/util/internal/GeodeJsonMapper.java:
##
@@ -34,13 +36,21 @@ public class GeodeJsonMapper {
*/
public static
onichols-pivotal commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r885887287
##
geode-common/src/main/java/org/apache/geode/util/internal/GeodeJsonMapper.java:
##
@@ -34,13 +36,21 @@ public class GeodeJsonMapper {
*/
public static
onichols-pivotal commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r885881588
##
geode-common/src/main/java/org/apache/geode/util/internal/GeodeJsonMapper.java:
##
@@ -34,13 +36,21 @@ public class GeodeJsonMapper {
*/
public static
jinmeiliao commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r885884083
##
geode-common/src/main/java/org/apache/geode/util/internal/GeodeJsonMapper.java:
##
@@ -34,13 +36,21 @@ public class GeodeJsonMapper {
*/
public static
onichols-pivotal commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r885883301
##
geode-common/src/main/java/org/apache/geode/util/internal/GeodeJsonMapper.java:
##
@@ -34,13 +36,21 @@ public class GeodeJsonMapper {
*/
public static
onichols-pivotal commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r885881588
##
geode-common/src/main/java/org/apache/geode/util/internal/GeodeJsonMapper.java:
##
@@ -34,13 +36,21 @@ public class GeodeJsonMapper {
*/
public static
jinmeiliao commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r885876741
##
geode-common/src/main/java/org/apache/geode/util/internal/GeodeJsonMapper.java:
##
@@ -34,13 +36,21 @@ public class GeodeJsonMapper {
*/
public static
nabarunnag commented on PR #7741:
URL: https://github.com/apache/geode/pull/7741#issuecomment-1142364970
Failing regression tests, artifacts will be sent to the author
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
albertogpz opened a new pull request, #7742:
URL: https://github.com/apache/geode/pull/7742
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit
nabarunnag opened a new pull request, #7741:
URL: https://github.com/apache/geode/pull/7741
…endpoint (#7515)"
This reverts commit 18f0e9c55c3aeb14ceb3b1f07c07008b0126d6be.
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it
nabarunnag opened a new pull request, #7740:
URL: https://github.com/apache/geode/pull/7740
* Using queueConnection snapshot for multiple if checks
* As it is a volatile variable, the value may become null mid checks.
### For all changes:
- [ ] Is there a JIRA
nabarunnag merged PR #7722:
URL: https://github.com/apache/geode/pull/7722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jchen21 opened a new pull request, #7739:
URL: https://github.com/apache/geode/pull/7739
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit
onichols-pivotal merged PR #7736:
URL: https://github.com/apache/geode/pull/7736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pivotal-eshu opened a new pull request, #7738:
URL: https://github.com/apache/geode/pull/7738
* During putIfAbsent retry, comparing invalid token value when
putIfAbsent of a null value instead.
* Do not make putIfAbsent event to update event if current
entry value is null or
jmelchio opened a new pull request, #7737:
URL: https://github.com/apache/geode/pull/7737
Co-authored-by: Jinmei Liao
- include libraries so that end-users won't have to add them to the java
path
- ensure proper serialization in gfsh and pulse
--
This is an automated
onichols-pivotal merged PR #7735:
URL: https://github.com/apache/geode/pull/7735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
animatedmax opened a new pull request, #7734:
URL: https://github.com/apache/geode/pull/7734
For v1.12
GEODE-10341: add note that snapshot includes in-cache and overflow entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
animatedmax opened a new pull request, #7733:
URL: https://github.com/apache/geode/pull/7733
For v1.14
GEODE-10341: add note that snapshot includes in-cache and overflow entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
animatedmax opened a new pull request, #7732:
URL: https://github.com/apache/geode/pull/7732
For v1.15
GEODE-10341: add note that snapshot includes in-cache and overflow entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
davebarnes97 merged PR #7729:
URL: https://github.com/apache/geode/pull/7729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mivanac commented on PR #7664:
URL: https://github.com/apache/geode/pull/7664#issuecomment-1139687960
Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett
just a reminder,
could you review this PR.
This was reverted PR with modifications for failing internal test.
kirklund opened a new pull request, #7731:
URL: https://github.com/apache/geode/pull/7731
Please do not review yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jchen21 opened a new pull request, #7730:
URL: https://github.com/apache/geode/pull/7730
Instead of saving locator and server logs to a temp dir, which will be
deleted at the end of the tests, save the logs to a different dir, so that it
will collected in the final artifacts.
animatedmax opened a new pull request, #7729:
URL: https://github.com/apache/geode/pull/7729
GEODE-10341: add note that snapshot includes in-cache and overflow entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
demery-pivotal closed pull request #7723: GEODE-10321: Acceptance test for
Geode access to JDK internals
URL: https://github.com/apache/geode/pull/7723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
demery-pivotal commented on PR #7723:
URL: https://github.com/apache/geode/pull/7723#issuecomment-1139021427
Closing because it uses a test API that has been reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kirklund merged PR #7728:
URL: https://github.com/apache/geode/pull/7728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pivotal-jbarrett merged PR #169:
URL: https://github.com/apache/geode-benchmarks/pull/169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirklund opened a new pull request, #7728:
URL: https://github.com/apache/geode/pull/7728
…ifacts for failures (#7571)"
This reverts commit 774505e7c74cff8c572be1ec4f4bb2b0f3e1a091.
---
We are reverting to spend time on four acceptance tests that are now failing
on
jinmeiliao merged PR #7709:
URL: https://github.com/apache/geode/pull/7709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirklund commented on PR #7709:
URL: https://github.com/apache/geode/pull/7709#issuecomment-1138757643
The gradle daemon crashed in both stress-new-test jobs. Please make sure
those are healthy before merging. Thanks!
--
This is an automated message from the Apache Git Service.
To
DonalEvans commented on PR #7721:
URL: https://github.com/apache/geode/pull/7721#issuecomment-1138681241
The failing DUnit test is due to
https://issues.apache.org/jira/browse/GEODE-8411, which is a known flaky test
and unrelated to the changes in this PR.
--
This is an automated
albertogpz opened a new pull request, #7726:
URL: https://github.com/apache/geode/pull/7726
The following DiskStore stats are now published via JMX:
recoveredEntryCreates, recoveredEntryUpdates and recoveredEntryDestroys.
### For all changes:
- [ ] Is there a
jvarenina opened a new pull request, #7725:
URL: https://github.com/apache/geode/pull/7725
When a stop session is called on the LogWriterAppender, it closes the
ManagerLogWriter's files. Still, it does not release
ManagerLogWriter's reference, so the LogWriterAppender instance is
mivanac merged PR #7653:
URL: https://github.com/apache/geode/pull/7653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pivotal-jbarrett opened a new pull request, #169:
URL: https://github.com/apache/geode-benchmarks/pull/169
* Removes some untested JVM options leftover from Redis benchmarking.
* Adds per-role heap and GC project configurations.
--
This is an automated message from the Apache Git
jchen21 opened a new pull request, #7724:
URL: https://github.com/apache/geode/pull/7724
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit
agingade commented on PR #7653:
URL: https://github.com/apache/geode/pull/7653#issuecomment-1138004383
@mivanac It seems you can ignore LGTM analysis failure with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
demery-pivotal opened a new pull request, #7723:
URL: https://github.com/apache/geode/pull/7723
Add acceptance tests to demonstrate two ways to give Geode access to
encapsulated fields of a JDK 17 class:
- Tell Gfsh to open the class's package when starting a Geode member.
-
nabarunnag opened a new pull request, #7722:
URL: https://github.com/apache/geode/pull/7722
* DistributedMulticastRegionWithUDPSecurityDUnitTest ->
DistributedMulticastRegionWithUDPSecurityDistributedTest
* DistributedMulticastRegionDUnitTest ->
dschneider-pivotal commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r882117180
##
geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java:
##
@@ -12,604 +12,430 @@
* or implied. See the License for the specific
DonalEvans opened a new pull request, #7721:
URL: https://github.com/apache/geode/pull/7721
Do not throw RejectedExecutionException if the GMSHealthMonitor is
stopping
Authored-by: Donal Evans
### For all changes:
- [ ] Is there a JIRA ticket associated
kirklund merged PR #7571:
URL: https://github.com/apache/geode/pull/7571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirklund commented on PR #7571:
URL: https://github.com/apache/geode/pull/7571#issuecomment-1137655729
One precheckin run hit
[GEODE-10332](https://issues.apache.org/jira/browse/GEODE-10332)
(ClientAuthenticationDUnitTest) and it was determined to be unrelated to this
PR.
That same
albertogpz commented on code in PR #7493:
URL: https://github.com/apache/geode/pull/7493#discussion_r881357188
##
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/PRClientServerTestBase.java:
##
@@ -489,6 +525,22 @@ void
albertogpz commented on PR #7493:
URL: https://github.com/apache/geode/pull/7493#issuecomment-1136843816
> Can you change the JIRA to say that isHA has to be false for this behavior
to exist.
Done. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to
mivanac merged PR #7515:
URL: https://github.com/apache/geode/pull/7515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mivanac commented on PR #7323:
URL: https://github.com/apache/geode/pull/7323#issuecomment-1136758328
Hi @upthewaterspout, @agingade and @dschneider-pivotal
could you review this PR.
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
jvarenina commented on PR #7665:
URL: https://github.com/apache/geode/pull/7665#issuecomment-1136754745
@pivotal-jbarrett just a friendly reminder on a pending review of the change
request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
mivanac merged PR #7667:
URL: https://github.com/apache/geode/pull/7667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pivotal-jbarrett commented on code in PR #7262:
URL: https://github.com/apache/geode/pull/7262#discussion_r881053181
##
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientMetadataService.java:
##
@@ -98,11 +96,13 @@ public ClientMetadataService(Cache cache) {
Bill commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r881041522
##
geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java:
##
@@ -229,387 +235,209 @@ public class MessageType {
*
* @since GemFire 4.1.1
pivotal-jbarrett commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r881020969
##
geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java:
##
@@ -229,387 +235,209 @@ public class MessageType {
*
* @since
pivotal-jbarrett commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r881016433
##
geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java:
##
@@ -229,387 +235,209 @@ public class MessageType {
*
* @since
Bill commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r881011208
##
geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java:
##
@@ -229,387 +235,209 @@ public class MessageType {
*
* @since GemFire 4.1.1
Bill commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r880993237
##
geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java:
##
@@ -229,387 +235,209 @@ public class MessageType {
*
* @since GemFire 4.1.1
yozaner1324 opened a new pull request, #7720:
URL: https://github.com/apache/geode/pull/7720
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit
pivotal-jbarrett commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r880949086
##
geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/CqServiceImpl.java:
##
@@ -93,10 +101,10 @@
public class CqServiceImpl implements CqService {
pivotal-jbarrett commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r880946950
##
geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/CqServiceImpl.java:
##
@@ -93,10 +101,10 @@
public class CqServiceImpl implements CqService {
pivotal-jbarrett commented on PR #7688:
URL: https://github.com/apache/geode/pull/7688#issuecomment-1136429005
I can't believe that nobody called me out for not adding a new unit test.
Done and bugs fixed.
--
This is an automated message from the Apache Git Service.
To respond to the
DonalEvans commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r880890220
##
geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/CqServiceImpl.java:
##
@@ -93,10 +101,10 @@
public class CqServiceImpl implements CqService {
jinmeiliao commented on code in PR #7697:
URL: https://github.com/apache/geode/pull/7697#discussion_r880891160
##
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java:
##
@@ -1043,7 +1046,15 @@ public void waitToStop() throws InterruptedException
jinmeiliao commented on code in PR #7697:
URL: https://github.com/apache/geode/pull/7697#discussion_r880891160
##
geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java:
##
@@ -1043,7 +1046,15 @@ public void waitToStop() throws InterruptedException
Bill commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r880857614
##
geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java:
##
@@ -229,387 +235,209 @@ public class MessageType {
*
* @since GemFire 4.1.1
Bill commented on code in PR #7688:
URL: https://github.com/apache/geode/pull/7688#discussion_r880853138
##
geode-core/src/main/java/org/apache/geode/internal/cache/tier/MessageType.java:
##
@@ -229,387 +235,209 @@ public class MessageType {
*
* @since GemFire 4.1.1
501 - 600 of 19317 matches
Mail list logo
