[GitHub] [geode] jdeppe-pivotal opened a new pull request #5368: GEODE-8333: Fix pubsub hang during heavy subscription and publishing

jdeppe-pivotal opened a new pull request #5368: URL: https://github.com/apache/geode/pull/5368 - Introduce notion of a Subscription being 'active'. This flag is only set once a subscriber has been moved to the 'subscribers' EventLoopGroup. This avoids a subscriber processing a publ

[GitHub] [geode] lgtm-com[bot] commented on pull request #5357: GEODE-8067: ClassLoader Isolation

lgtm-com[bot] commented on pull request #5357: URL: https://github.com/apache/geode/pull/5357#issuecomment-65711 This pull request **introduces 2 alerts** and **fixes 2** when merging 591c7469807ff61ab71176003f906c986845957a into c41e3b4b559bfbc744c8c21844cd126de2ad2fb9 - [view on LGT

[GitHub] [geode] lgtm-com[bot] commented on pull request #5357: GEODE-8067: ClassLoader Isolation

lgtm-com[bot] commented on pull request #5357: URL: https://github.com/apache/geode/pull/5357#issuecomment-657836650 This pull request **fixes 2 alerts** when merging ff1286006fddc924485d7668155cc56c58a63933 into c41e3b4b559bfbc744c8c21844cd126de2ad2fb9 - [view on LGTM.com](https://lgtm.c

[GitHub] [geode] gesterzhou commented on a change in pull request #4848: GEODE-7670: Add Tests for PR clear

gesterzhou commented on a change in pull request #4848: URL: https://github.com/apache/geode/pull/4848#discussion_r453976769 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithConcurrentOperationsDUnitTest.java ## @@ -0,

[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

moleske commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r453958895 ## File path: cppcache/include/geode/DataInput.hpp ## @@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput { // empty string brea

[GitHub] [geode] lgtm-com[bot] commented on pull request #5357: GEODE-8067: ClassLoader Isolation

lgtm-com[bot] commented on pull request #5357: URL: https://github.com/apache/geode/pull/5357#issuecomment-657812961 This pull request **introduces 2 alerts** and **fixes 2** when merging 9cb762ed91581557c8c0fca0ac8983834a8e595c into c41e3b4b559bfbc744c8c21844cd126de2ad2fb9 - [view on LGT

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

pdxcodemonkey commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r453936057 ## File path: cppcache/include/geode/DataInput.hpp ## @@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput { // empty string

[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

moleske commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r453915203 ## File path: cppcache/include/geode/DataInput.hpp ## @@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput { // empty string brea

[GitHub] [geode] rhoughton-pivot merged pull request #5366: GEODE-8355: add `public: true` to the test job in long-running-test

rhoughton-pivot merged pull request #5366: URL: https://github.com/apache/geode/pull/5366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

pdxcodemonkey commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r453895218 ## File path: cppcache/include/geode/DataInput.hpp ## @@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput { // empty string

[GitHub] [geode-benchmarks] bschuchardt commented on a change in pull request #130: initial implementation of withClusterTopology

bschuchardt commented on a change in pull request #130: URL: https://github.com/apache/geode-benchmarks/pull/130#discussion_r453837947 ## File path: geode-benchmarks/src/test/java/org/apache/geode/benchmark/tests/GeodeBenchmarkTest.java ## @@ -36,46 +36,66 @@ */ class Geode

[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

moleske commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r453770010 ## File path: cppcache/src/TcrMessage.cpp ## @@ -1015,6 +1015,36 @@ void TcrMessage::processChunk(const std::vector& chunk, int32_t len, brea

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5358: GEODE-8326: remove 5 minutes wait to get stack dump

onichols-pivotal commented on a change in pull request #5358: URL: https://github.com/apache/geode/pull/5358#discussion_r453805506 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/partitioned/fixed/FixedPartitioningWithTransactionDistributedTest.java #

[GitHub] [geode] smgoller opened a new pull request #5367: GEODE-8348: Add benchmarks EC2 image builder job.

smgoller opened a new pull request #5367: URL: https://github.com/apache/geode/pull/5367 * Add EC2 builder job to images. * Benchmarks job uses branch-specific image. * Change benchmarks source repository location to the deployed fork's repo instead of forcing apache. * downlo

[GitHub] [geode] rhoughton-pivot opened a new pull request #5366: GEODE-8355: add `public: true` to the test job in long-running-test

rhoughton-pivot opened a new pull request #5366: URL: https://github.com/apache/geode/pull/5366 Authored-by: Robert Houghton Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following ste

[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

moleske commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r453775780 ## File path: cppcache/include/geode/DataInput.hpp ## @@ -313,7 +313,53 @@ class APACHE_GEODE_EXPORT DataInput { // empty string brea

[GitHub] [geode-benchmarks] smgoller opened a new pull request #131: GEODE-8348: Add support for customizable purpose tag.

smgoller opened a new pull request #131: URL: https://github.com/apache/geode-benchmarks/pull/131 Add the ability to choose what purpose tag is searched for when launching benchmarks. This is an automated message from the Ap

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5364: GEODE-8351: DUnit tests for Delta Propagation

sabbeyPivotal commented on a change in pull request #5364: URL: https://github.com/apache/geode/pull/5364#discussion_r453770437 ## File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/data/DeltaDUnitTest.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to

[GitHub] [geode-native] pdxcodemonkey merged pull request #626: GEODE-8342: Replace non-inclusive language.

pdxcodemonkey merged pull request #626: URL: https://github.com/apache/geode-native/pull/626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] pivotal-eshu merged pull request #5358: GEODE-8326: remove 5 minutes wait to get stack dump

pivotal-eshu merged pull request #5358: URL: https://github.com/apache/geode/pull/5358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

moleske commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r453770010 ## File path: cppcache/src/TcrMessage.cpp ## @@ -1015,6 +1015,36 @@ void TcrMessage::processChunk(const std::vector& chunk, int32_t len, brea

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

pdxcodemonkey commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r453764965 ## File path: cppcache/src/ExceptionTypes.cpp ## @@ -297,7 +297,25 @@ const std::string& getThreadLocalExceptionMessage(); PutAllPartialRe

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5364: GEODE-8351: DUnit tests for Delta Propagation

sabbeyPivotal commented on a change in pull request #5364: URL: https://github.com/apache/geode/pull/5364#discussion_r453718436 ## File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/data/DeltaDUnitTest.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to

[GitHub] [geode-benchmarks] bschuchardt commented on a change in pull request #130: initial implementation of withClusterTopology

bschuchardt commented on a change in pull request #130: URL: https://github.com/apache/geode-benchmarks/pull/130#discussion_r453713685 ## File path: geode-benchmarks/src/main/java/org/apache/geode/benchmark/tests/GeodeBenchmark.java ## @@ -45,11 +46,20 @@ public static TestCon

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5364: GEODE-8351: DUnit tests for Delta Propagation

sabbeyPivotal commented on a change in pull request #5364: URL: https://github.com/apache/geode/pull/5364#discussion_r453712504 ## File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/data/DeltaDUnitTest.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to

[GitHub] [geode-benchmarks] bschuchardt commented on a change in pull request #130: initial implementation of withClusterTopology

bschuchardt commented on a change in pull request #130: URL: https://github.com/apache/geode-benchmarks/pull/130#discussion_r453712325 ## File path: geode-benchmarks/build.gradle ## @@ -93,6 +93,7 @@ task benchmark(type: Test) { } systemProperty 'withSsl', project.hasProp

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5364: GEODE-8351: DUnit tests for Delta Propagation

sabbeyPivotal commented on a change in pull request #5364: URL: https://github.com/apache/geode/pull/5364#discussion_r453711863 ## File path: geode-redis/src/distributedTest/java/org/apache/geode/redis/internal/data/DeltaDUnitTest.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to

[GitHub] [geode-native] alb3rtobr opened a new pull request #627: Add GatewaySenderEventCallbackArgument class

alb3rtobr opened a new pull request #627: URL: https://github.com/apache/geode-native/pull/627 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [geode] jvarenina commented on a change in pull request #5360: GEODE-8329: Fix for durable CQ reqistration recovery

jvarenina commented on a change in pull request #5360: URL: https://github.com/apache/geode/pull/5360#discussion_r453489804 ## File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java ## @@ -1112,7 +1112,8 @@ private void recoverCqs(Conn

[GitHub] [geode] jvarenina commented on a change in pull request #5360: GEODE-8329: Fix for durable CQ reqistration recovery

jvarenina commented on a change in pull request #5360: URL: https://github.com/apache/geode/pull/5360#discussion_r453607399 ## File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java ## @@ -1112,7 +1112,8 @@ private void recoverCqs(Conn

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-657509799 > Hello @mkevo, > > This PR has been inactive for quite some time now, should we close it or are you planning to continue working on it?. Hi @jujoramos, I have some

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-657507636 Hello @mkevo, This PR has been inactive for quite some time now, should we close it or are you planning to continue working on it?. -

[GitHub] [geode] jvarenina commented on a change in pull request #5360: GEODE-8329: Fix for durable CQ reqistration recovery

jvarenina commented on a change in pull request #5360: URL: https://github.com/apache/geode/pull/5360#discussion_r453489804 ## File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/QueueManagerImpl.java ## @@ -1112,7 +1112,8 @@ private void recoverCqs(Conn