Thanks for submitting this, @ottenhoff! This repository is archived, could you
kindly reopen this over at [apache/jclouds](https://github.com/apache/jclouds)?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1284.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1284#event-3085649029
@YYTVicky Could you kindly move this to the apache/jclouds repo, as this one is
no longer active.
Also, could you add a few more details describing what the security
vulnerability is?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
Closed #1280.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1280#event-2837059639
Closed #1281.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1281#event-2837058748
[
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836091#comment-16836091
]
Andrew Phillips edited comment on JCLOUDS-1166 at 5/9/19 5:10 AM
[
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836091#comment-16836091
]
Andrew Phillips edited comment on JCLOUDS-1166 at 5/9/19 5:10 AM
[
https://issues.apache.org/jira/browse/JCLOUDS-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16836091#comment-16836091
]
Andrew Phillips commented on JCLOUDS-1166:
--
> Now jclouds-karaf and jclouds-
demobox commented on this pull request.
> @@ -1120,19 +1120,6 @@
http://download.oracle.com/javase/6/docs/api/
-
demobox commented on this pull request.
> @@ -148,8 +149,13 @@ public boolean blobExists(final String containerName,
> final String blobName) {
}
@Override
- public Iterable getBlobKeysInsideContainer(final String
containerName) {
- return
Is there anything about this change that would merit a test? I'm assuming "does
not open tons of file descriptors" is not something that's easy/feasible to
test for..?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Good to go from your perspectives?
@gaul @nacx Quick follow-up ping here...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1258#issuecomment-445684855
@gaul @nacx Good to go from your perspectives?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1258#issuecomment-443530176
Closed #1258.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1258#event-1981288517
Reopened #1258.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1258#event-1981288563
Closing and reopening to trigger Jenkins again
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1258#issuecomment-440845569
> Ubuntu
Ah, interesting - not obvious why Jenkins would fail, in that case. Let's try
that again.
Here two failures when running on Windows:
```
Tests run: 232, Failures: 2, Errors: 0, Skipped: 221, Time elapsed: 6.339 sec <<
< FAILURE! - in TestSuite
> Odd, all the apis/filesystem tests passed on my machine.
What OS are you running on?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1258#issuecomment-440843431
> Addressed comments, merged and published.
Thanks, Ignasi!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
demobox commented on this pull request.
> href="https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute;>How
> To Contribute Code
https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute+Documentation;>How
To
demobox commented on this pull request.
> {% comment %}
+{% include supportapache.html %}
No particular issue with hiding this, just curious about the reasoning? Is it
because we're now listing Apache events in the "community" menu?
--
You are receiving this because
Screenshot:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Error in the Jenkins Violations plugin?
```
java.lang.IllegalStateException: cannot change build result while in COMPLETED
at hudson.model.Run.setResult(Run.java:475)
at
hudson.plugins.violations.ViolationsReport.setBuildResult(ViolationsReport.java:542)
at
demobox commented on this pull request.
> .append("-")
.append(partsList.size())
.append("\"")
.toString();
assertThat(blob.getMetadata().getETag()).isEqualTo(expectedETag);
}
+ @Test(groups = { "integration", "live" })
+ public void
demobox commented on this pull request.
> .append("-")
.append(partsList.size())
.append("\"")
.toString();
assertThat(blob.getMetadata().getETag()).isEqualTo(expectedETag);
}
+ @Test(groups = { "integration", "live" })
+ public void
demobox commented on this pull request.
> + MultipartPart part1 = blobStore.uploadMultipartPart(mpu, 1,
> payload);
+ MultipartPart part2 = blobStore.uploadMultipartPart(mpu, 2, payload);
+
+ List parts = blobStore.listMultipartUpload(mpu);
+
demobox commented on this pull request.
Just a couple of minor questions; fine to proceed if someone with more
blobstore knowledge is good with this.
Thanks for submitting, @timuralp!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
demobox commented on this pull request.
> + MultipartPart part1 = blobStore.uploadMultipartPart(mpu, 1,
> payload);
+ MultipartPart part2 = blobStore.uploadMultipartPart(mpu, 2, payload);
+
+ List parts = blobStore.listMultipartUpload(mpu);
+
demobox commented on this pull request.
> .append("-")
.append(partsList.size())
.append("\"")
.toString();
assertThat(blob.getMetadata().getETag()).isEqualTo(expectedETag);
}
+ @Test(groups = { "integration", "live" })
+ public void
Thanks for the improvement, @trevorflanagan! Also looks good to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/95#issuecomment-431497688
Merged to
[2.0.x](https://github.com/jclouds/jclouds/commit/ae821a248fd8a899dedce4109c4a3d509b946261)
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1249#issuecomment-431194646
[
https://issues.apache.org/jira/browse/JCLOUDS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Phillips resolved JCLOUDS-1462.
--
Resolution: Fixed
Fix Version/s: 2.1.2
2.2.0
> Upgr
Closed #1248.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1248#event-1913470589
Merged to
[2.1.x](https://github.com/jclouds/jclouds/commit/9142af74b884cdae5cf025372aabb53b9af23528)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1248#issuecomment-431179642
[
https://issues.apache.org/jira/browse/JCLOUDS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Phillips updated JCLOUDS-1462:
-
Attachment: JCLOUDS-1462.patch
> Upgrade Apache Http driver in response to CVE-2
Reopened #1249.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1249#event-1913461610
> Likely a transient test failure in
> `org.jclouds.http.handlers.BackoffLimitedRetryHandlerTest.testExponentialBackoffDelaySmallInterval5`
Rebuilding
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1249.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1249#event-1913461434
In response to https://nvd.nist.gov/vuln/detail/CVE-2015-5262
See #1247
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1249
-- Commit Summary --
* JCLOUDS-1462: Upgrade Apache Http driver to 4.3.6
-- File Changes --
M
In response to https://nvd.nist.gov/vuln/detail/CVE-2015-5262
See #1247
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1248
-- Commit Summary --
* JCLOUDS-1462: Upgrade Apache Http driver to 4.3.6
-- File Changes --
M
Closed #1247.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1247#event-1913359114
Merged to
[master](https://github.com/jclouds/jclouds/commit/767240f360b0152e796772825a17c5c58e19179a).
Thanks for jumping on this so quickly, all!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Should we open an issue for this?
See https://issues.apache.org/jira/browse/JCLOUDS-1462
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1247#issuecomment-431154013
Andrew Phillips created JCLOUDS-1462:
Summary: Upgrade Apache Http driver in response to CVE-2015-5262
Key: JCLOUDS-1462
URL: https://issues.apache.org/jira/browse/JCLOUDS-1462
Project: jclouds
[
https://issues.apache.org/jira/browse/JCLOUDS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Phillips reassigned JCLOUDS-1462:
Assignee: Andrew Phillips
> Upgrade Apache Http driver in response to CVE-2
@nacx Should we consider adding any kinds of test(s) for this? Also, would a
JIRA issue for tracking make sense here?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
demobox approved this pull request.
If these changes pass tests reliably, +1 from me - thanks, @gaul!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Were the changes to the tests to fix flakiness?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1241#issuecomment-429520847
> NP, I'll do :)
Great, thanks!
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/219#issuecomment-427229456
Merged to master: b7e2ab4. Not yet published.
@nacx Lazy question: I'm wrestling a bit with the site deployment - any chance
you could briefly run that if you have an appropriate environment set up? Many
thanks if so, and thanks for taking a look at the PR, of course!
--
You are receiving
Screenshot:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Follow-up at #219
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/218#issuecomment-425747207
ApacheCon NA has ended
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/219
-- Commit Summary --
* Replace the ApacheCon banner with 'support the ASF'
-- File Changes --
M _layouts/home.html (6)
-- Patch Links --
ApacheCon NA has ended
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-site/pull/218
-- Commit Summary --
* Replace the ApacheCon banner with 'support the ASF'
-- File Changes --
M _layouts/home.html (6)
-- Patch Links --
demobox commented on this pull request.
> @@ -110,6 +122,27 @@ protected VirtualMachineInStatePredicateFactory
> provideNodeSuspendedPredicate(fi
timeouts.nodeTerminated, pollPeriod.pollInitialPeriod,
pollPeriod.pollMaxPeriod);
}
+ @Provides
+
demobox commented on this pull request.
> +import org.jclouds.azurecompute.arm.features.DiskApi;
+import org.jclouds.azurecompute.arm.features.NetworkInterfaceCardApi;
+import org.jclouds.azurecompute.arm.features.NetworkSecurityGroupApi;
+import
demobox commented on this pull request.
> logger.debug(">> the resource group %s is empty. Deleting...",
> group);
- deleted =
resourceDeleted.apply(api.getResourceGroupApi().delete(group));
+ URI uri = api.getResourceGroupApi().delete(group);
+ deleted = uri
demobox commented on this pull request.
> }
}
return deleted;
}
+ private void cleanupVirtualNetworks(String resourceGroupName) {
+ for (VirtualNetwork virtualNetwork :
api.getVirtualNetworkApi(resourceGroupName).list()) {
+ if
demobox commented on this pull request.
> @@ -121,7 +131,17 @@ public boolean cleanupVirtualMachineNICs(VirtualMachine
> virtualMachine) {
PublicIPAddress ip =
api.getPublicIPAddressApi(publicIpResourceGroup).get(publicIpName);
if (ip.tags() != null &&
demobox commented on this pull request.
> @@ -110,6 +122,27 @@ protected VirtualMachineInStatePredicateFactory
> provideNodeSuspendedPredicate(fi
timeouts.nodeTerminated, pollPeriod.pollInitialPeriod,
pollPeriod.pollMaxPeriod);
}
+ @Provides
+
> Thanks, @nakomis! And many thanks for taking care of adding new tests. It's
> highly appreciated!
+1 to that - many thanks!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
demobox commented on this pull request.
> @@ -763,6 +763,8 @@ private static void addHeader(Multimap
> headers, Headers header,
for (int i = 0; i < header.keys().length; i++) {
String value = header.values()[i];
value = replaceTokens(value, tokenValues);
+ if
demobox commented on this pull request.
> @@ -408,6 +408,21 @@ public void testCopyObject() throws Exception {
}
}
+ String sourceKeyRequiringEncoding = "apples#?:$&'\"<>čॐ";
+1 to move into the test, if possible
--
You are receiving this because you are subscribed to this
demobox approved this pull request.
Thanks for the fix! +1, looks good to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/217#pullrequestreview-146683006
demobox commented on this pull request.
>String invalidPathBlobKey = "Ahttps://github.com/jclouds/jclouds/blob/master/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java#L846)
is then empty, so the code that throws the error
demobox requested changes on this pull request.
Thanks for all the updates, @danielestevez! Just wanted to check on one more
possible typo in a link.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
demobox commented on this pull request.
> +## Credits
+
+jclouds would like to thank everyone who contributed time and effort in order
to make this release happen:
+
+* [Vikas Rangarajan](https://github.com/VRanga000) for his contribution to the
new instance types supported in the AWS ec2
demobox commented on this pull request.
> +* [JCLOUDS-1389] - Multipart upload to Google cloud storage failing with 400
> bad request
+* [JCLOUDS-1391] - Headers must be sorted by lowercase when calculating
signature
+* [JCLOUDS-1392] - When fetching blob metadata with details all folders are
demobox commented on this pull request.
> +1. [Credits](#credits)
+1. [Test Results](#test)
+
+## Introduction
+
+Apache jclouds 2.1.1 is the first bugfix release after jclouds 2.1 and comes
with several bugfixes and performance improvements.
+You can [read the official announcement
demobox commented on this pull request.
> +1. [Known Issues](#knownissues)
+1. [Credits](#credits)
+1. [Test Results](#test)
+
+## Introduction
+
+Apache jclouds 2.1.1 is the first bugfix release after jclouds 2.1 and comes
with several bugfixes and performance improvements.
+You can [read
demobox commented on this pull request.
> +1. [Introduction](#intro)
+1. [Release Highlights](#highlights)
+1. [Known Issues](#knownissues)
+1. [Credits](#credits)
+1. [Test Results](#test)
+
+## Introduction
+
+Apache jclouds 2.1.1 is the first bugfix release after jclouds 2.1 and comes
with
demobox commented on this pull request.
> +layout: releasenotes
+title: Release Notes for Version 2.1.1
+date: 2018-08-09 16:00:00
+release_notes: true
+permalink: /releasenotes/2.1.1/
+---
+
+1. [Introduction](#intro)
+1. [Release Highlights](#highlights)
+1. [Known Issues](#knownissues)
+1.
demobox commented on this pull request.
> @@ -1280,7 +1280,10 @@
org.gaul
modernizer-maven-plugin
+
> Adds minor improvements to readability
Looks good to me - many thanks, Daniel! Is this for 2.1.x only, or also for
master, incidentally?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
demobox commented on this pull request.
> + */
+@Singleton
+public class AzureNameValidator extends Validator {
+ private final int min = 2;
+ private final int max = 63;
+
+ public void validate(String name) {
+
+ if (name == null || name.length() < min || name.length() > max)
+
demobox commented on this pull request.
> +/**
+ * Validates name for azure entities
+ *
https://docs.microsoft.com/en-us/azure/architecture/best-practices/naming-conventions
+ *
+ * @see org.jclouds.predicates.Validator
+ */
+@Singleton
+public class AzureNameValidator extends Validator {
+
demobox commented on this pull request.
> +
+import org.jclouds.predicates.Validator;
+
+import com.google.common.base.CharMatcher;
+import com.google.inject.Singleton;
+
+/**
+ * Validates name for azure entities
+ *
> makes sense?
Yes, clear, thanks. Just wanted to make sure we weren't missing any code that
we were intending to add ;-)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> bump guava version to 21.0
@andreaturli Just to clarify: is this part of this PR? I didn't see any code
change related to that, but it may have been removed or after an underlying
merge.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
Thanks for taking care of the merging and cherry-picking, Ignasi!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1207#issuecomment-390093278
Thanks, Daniel!
@nacx You probably have a bit more context with regard to the overall change -
does this cover the cases that were discussed in the previous PR?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
demobox commented on this pull request.
Curious whether we need to extend the test coverage a bit here?
> @@ -103,7 +103,7 @@ public void simpleRootTestWithSudoPassword() {
expect(sshClient.getUsername()).andReturn("tester");
demobox commented on this pull request.
> @@ -112,7 +112,8 @@ protected ExecResponse runCommand(String command) {
public String execAsRoot(String command) {
if (node.getCredentials().identity.equals("root")) {
} else if (node.getCredentials().shouldAuthenticateSudo()) {
-
demobox approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/216#pullrequestreview-119628028
[Preview
here](http://9ee4695ccebd96b41334-2a21ba0b2756ec3f93728892323454a7.r87.cf5.rackcdn.com/guides/openstack/).
+1, looks good to me - thanks, Ignasi!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Added one minor comment - thanks for the contribution, Daniel!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1206#issuecomment-388558647
demobox commented on this pull request.
> @@ -90,6 +91,7 @@ public static Properties defaultProperties() {
properties.put(TIMEOUT_NODE_TERMINATED, 60 * 10 * 1000);
// Default max wait in rate limit: 5m30s
properties.put(PROPERTY_MAX_RATE_LIMIT_WAIT, 33);
+
> I will do it in a // PR (this one merged) after feedback on my remarks.
Thanks for taking a look! I should add that I think most of my comments are
minor, and it's also fine to leave things as they are unless we feel there's
really a good reason for a follow-up PR.
And thanks for helping
demobox commented on this pull request.
> @@ -146,6 +361,7 @@ public class JCloudsNova implements Closeable {
String identity = "demo:demo"; // tenantName:userName
String credential = "devstack";
+// Please refer to 'Keystone v2-v3 authentication' chapter for
demobox commented on this pull request.
> +{% highlight java %}
+final Properties overrides = new Properties();
+overrides.put(KeystoneProperties.KEYSTONE_VERSION, "2");
+overrides.put(KeystoneProperties.TENANT_NAME, "myTenant");
+
+ContextBuilder.newBuilder("openstack-nova")
+
demobox commented on this pull request.
> @@ -92,6 +93,220 @@ There are some differences in terminology between jclouds
> and OpenStack that sho
+## Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has
demobox commented on this pull request.
> @@ -92,6 +93,220 @@ There are some differences in terminology between jclouds
> and OpenStack that sho
+## Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has
demobox commented on this pull request.
> @@ -92,6 +93,220 @@ There are some differences in terminology between jclouds
> and OpenStack that sho
+## Keystone v2-v3 authentication
+
+Openstack Keystone (aka: [OpenStack Identity
Service](https://docs.openstack.org/keystone/latest/)) has
> I think this change is not safe
Thanks for catching this, @nacx! Are we perhaps missing a unit test somewhere
to ensure the cleanup method behaves as you described?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
demobox commented on this pull request.
> @@ -6,8 +6,11 @@
{% include navbar.html %}
-
+
+{% comment %}
Is this intended as a TODO to remove after the event?
--
You are receiving this because you modified the open/close state.
Reply to this
Thanks for taking care of this, @nacx!
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/213#issuecomment-380294501
demobox commented on this pull request.
> @@ -59,7 +59,7 @@
http://www.apache.org/licenses/;>License
http://www.apache.org/foundation/contributing.html;>Donations
Thanks for taking this on, @gaul and @nacx! Java 8 here we finally come... ;-)
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1193#issuecomment-380293707
Thanks for the update - looks good to me!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/212#issuecomment-375795601
> fix README.md
> clean up pom.xml
Thanks for adding those changes, Andrea. Looks good to me!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/92#issuecomment-375121157
1 - 100 of 4117 matches
Mail list logo
