Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1482887805 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java: ## @@ -56,50 +54,59 @@ public StatusConsoleListener(final Level level)

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1482856362 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java: ## @@ -56,50 +54,59 @@ public StatusConsoleListener(final Level level) {

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1482842721 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusConsoleListener.java: ## @@ -56,50 +54,59 @@ public StatusConsoleListener(final Level level)

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1470261975 ## log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/StatusLoggerAdmin.java: ## @@ -92,6 +80,50 @@ private static MBeanNotificationInfo

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1470220453 ## log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/StatusLoggerAdmin.java: ## @@ -92,6 +80,50 @@ private static MBeanNotificationInfo

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469479620 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -462,53 +718,30 @@ public boolean isEnabled( } @Override -

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469477755 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -462,53 +718,30 @@ public boolean isEnabled( } @Override -public

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469414965 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,590 @@ */ package org.apache.logging.log4j.status;

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469366415 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,590 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469354697 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/package-info.java: ## @@ -15,7 +15,7 @@ * limitations under the license. */ @Export

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469347266 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,590 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469347142 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -462,53 +718,30 @@ public boolean isEnabled( } @Override -

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469336334 ## log4j-core/src/main/java/org/apache/logging/log4j/core/jmx/StatusLoggerAdmin.java: ## @@ -92,6 +80,50 @@ private static MBeanNotificationInfo

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469321751 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,590 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469318683 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469312277 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#issuecomment-1914303543 @ppkarwasz, I have introduced the fallback listener concept back in cd3fadb3bc65e34e6fa7f53628bfd4f77f5824c2. Would you mind reviewing it, please? -- This is an automated message

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1469307304 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -462,53 +718,30 @@ public boolean isEnabled( } @Override -public

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1468085041 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,590 @@ */ package org.apache.logging.log4j.status;

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

jvz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1468034340 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

jvz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1468031713 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,590 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

jvz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1468029770 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,590 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

jvz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1468024863 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,590 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

jvz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1468019981 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusData.java: ## @@ -34,58 +36,93 @@ public class StatusData implements Serializable { private

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

jvz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1468018836 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/package-info.java: ## @@ -15,7 +15,7 @@ * limitations under the license. */ @Export

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467508691 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -462,53 +718,30 @@ public boolean isEnabled( } @Override -

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467502442 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status;

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467457061 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status;

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467455327 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/package-info.java: ## @@ -15,7 +15,7 @@ * limitations under the license. */ @Export

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467429128 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/package-info.java: ## @@ -15,7 +15,7 @@ * limitations under the license. */ @Export

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467428953 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

vy commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467428606 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status; -import

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467374859 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status;

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1467362529 ## log4j-api/src/main/java/org/apache/logging/log4j/status/StatusLogger.java: ## @@ -16,311 +16,567 @@ */ package org.apache.logging.log4j.status;

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

ppkarwasz commented on code in PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#discussion_r1466992477 ## log4j-api-test/src/main/java/org/apache/logging/log4j/test/junit/package-info.java: ## @@ -15,7 +15,7 @@ * limitations under the license. */ @Export

Re: [PR] Draft: Make `StatusLogger` self-contained and testable (logging-log4j2)

rgoers commented on PR #2249: URL: https://github.com/apache/logging-log4j2/pull/2249#issuecomment-1911061340 I will go through this as I can. It might take a couple of days depending on my available time. However, the description of the solution above seems to aim right on target. --