Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-23 Thread via GitHub
lkishalmi merged PR #7117: URL: https://github.com/apache/netbeans/pull/7117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-23 Thread via GitHub
lkishalmi commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536719255 ## ide/libs.flexmark/nbproject/project.properties: ## @@ -15,7 +15,7 @@ # specific language governing permissions and limitations # under the License.

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-23 Thread via GitHub
matthiasblaesing commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536671847 ## ide/libs.lucene/nbproject/project.properties: ## @@ -19,3 +19,8 @@ is.autoload=true javac.source=1.8 javac.compilerargs=-Xlint -Xlint:-serial

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-23 Thread via GitHub
matthiasblaesing commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536664968 ## enterprise/web.jsf12/nbproject/project.properties: ## @@ -17,3 +17,5 @@ release.external/jsf-api-1.2_05.jar=modules/ext/jsf-1_2/jsf-api.jar

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-23 Thread via GitHub
mbien commented on PR #7117: URL: https://github.com/apache/netbeans/pull/7117#issuecomment-2016458298 would it make sense to open a meta issue afterwards which has a list of all mods where sig tests are turned off so that we can look that up when needed? -- This is an automated message

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-22 Thread via GitHub
lkishalmi commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536484501 ## java/j2ee.eclipselink/nbproject/project.properties: ## @@ -38,3 +38,5 @@ release.external/jakarta.persistence-2.2.3.jar=modules/ext/eclipselink/jakarta.p

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-22 Thread via GitHub
lkishalmi commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536551680 ## enterprise/web.jsf12/nbproject/project.properties: ## @@ -17,3 +17,5 @@ release.external/jsf-api-1.2_05.jar=modules/ext/jsf-1_2/jsf-api.jar

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-22 Thread via GitHub
lkishalmi commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536551115 ## enterprise/web.jsf20/nbproject/project.properties: ## @@ -20,3 +20,5 @@ javac.source=1.8

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-22 Thread via GitHub
lkishalmi commented on PR #7117: URL: https://github.com/apache/netbeans/pull/7117#issuecomment-2016259213 @matthiasblaesing thanks for your feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-22 Thread via GitHub
lkishalmi commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536484501 ## java/j2ee.eclipselink/nbproject/project.properties: ## @@ -38,3 +38,5 @@ release.external/jakarta.persistence-2.2.3.jar=modules/ext/eclipselink/jakarta.p

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-22 Thread via GitHub
matthiasblaesing commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1536021017 ## enterprise/web.jsf20/nbproject/project.properties: ## @@ -20,3 +20,5 @@ javac.source=1.8

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-22 Thread via GitHub
lkishalmi commented on PR #7117: URL: https://github.com/apache/netbeans/pull/7117#issuecomment-2015612785 Anyone, a word? I'm about to merge this one today or tomorrow, as #7024 is depending on this one. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-20 Thread via GitHub
ebarboni commented on PR #7117: URL: https://github.com/apache/netbeans/pull/7117#issuecomment-2009453524 LGTM with my limited understanding -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-18 Thread via GitHub
lkishalmi commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1529660447 ## enterprise/j2eeapis/nbproject/project.properties: ## @@ -17,3 +17,5 @@ is.autoload=true

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-18 Thread via GitHub
mbien commented on code in PR #7117: URL: https://github.com/apache/netbeans/pull/7117#discussion_r1529647236 ## enterprise/j2eeapis/nbproject/project.properties: ## @@ -17,3 +17,5 @@ is.autoload=true release.external/deployment-api-1.2-rev-1.jar=modules/ext/jsr88javax.jar

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-18 Thread via GitHub
lkishalmi commented on PR #7117: URL: https://github.com/apache/netbeans/pull/7117#issuecomment-2005430717 Well the last commit forces to use sigtest to generate signatures without recursion. That behavior was fixed in the commit mentioned above, so that commit is just keeping the

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-03-06 Thread via GitHub
ebarboni commented on PR #7117: URL: https://github.com/apache/netbeans/pull/7117#issuecomment-1980912318 I think 1.4 was needed to build on jdk 11. As it was "working" did'nt think on upgrading. I'm always puzzled with sigtest as on jenkins we have issue In one there is 24 test

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-02-28 Thread via GitHub
matthiasblaesing commented on PR #7117: URL: https://github.com/apache/netbeans/pull/7117#issuecomment-1969894370 Not sure if it helps, but I think this causes the "error" in `libs.osgi`:

Re: [PR] Java 17 Support with Sigtest 2.2 from JakartaEE TCK Tools [netbeans]

2024-02-27 Thread via GitHub
lkishalmi commented on PR #7117: URL: https://github.com/apache/netbeans/pull/7117#issuecomment-1968119254 Well, this version seems to fail on `plarfom/libs.osgi` which shall generate an empty report. The new tool has some specific handling for Java 17. The old tool does something