[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2024-03-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828643#comment-17828643
 ] 

ASF subversion and git services commented on OFBIZ-9501:


Commit d400e0f41e51f4807828e4504f16cb859267d314 in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=d400e0f41 ]

Fixed: variant tree product features are being lost in product config
(OFBIZ-12020)

OFBIZ-10194 is not related at all. What makes me think so is that when you use
https://demo-next.ofbiz.apache.org/ecomseo/product/Scanning-book-service-CFSV1001.html
it's OK
But when you use
https://demo-trunk.ofbiz.apache.org/ecomseo/product/Scanning-book-service-CFSV1001.html
we have a problem.

I don't know what changed but it's not the rendering template
(ConfigProductDetail.ftl) last change was 6 years ago.
Nor the data used in the template (OrderDemoData.xml) which have not changed
since OFBIZ-9501. Maybe the FreeMarker version? But I quite doubt is that.

Anyway here is a fix with some help of FreeMarker advice in log.
I checked it had no bad influence on other services:
ecomseo/category/service-product-SERV-001.html


> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: 18.12.01
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-04-06 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428284#comment-16428284
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Comment for myself to work on this. Sorry somehow I missed to get back on 
problem reported by Taher.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-03-04 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385616#comment-16385616
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Taher,

Thanks for reporting this, yes we agree to move these data while working on 
this ticket. I'm not able to recall why Party component left. May be I missed 
this one, I'll take care of this soon and get back.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-03-04 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385114#comment-16385114
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Hi Rishi and everyone,

I just noticed while playing with data that some data in the datamodel 
component should not be there. Specifically, I'm talking about any data that 
has to do with portals like:
 * PortalPortlet
 * PortletPortletCategory
 * PortletCategory

This data is purely for the user interface creation in the party component for 
example. So it makes sense for this kind of data to live with the component, 
not the data model. I'm not sure if you have another Jira open for this, but I 
would recommend considering moving this type of data out of the data model.

Cheers

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-02-06 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16353695#comment-16353695
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Aside from the fact that I did not thank you enough for this work, everything 
seems to be fantastic from my point of view. Well done, this is a major move 
towards protecting the core of the framework from its applications. Hopefully 
next we will do something similar to consolidate all the services as well, and 
I will start a thread on that.

I feel it is relatively safe to close this Jira for now.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-02-05 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16352473#comment-16352473
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Thanks [~sourabh.jain] for your contribution. Your patch has been committed in 
revision 1823177, 1823182.

[~taher] / All do we have anything else we would like to address under this 
ticket?

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-01-27 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342148#comment-16342148
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Thank you [~sourabh.jain] for your patch, I'll review and commit it soon.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, OFBIZ-9501-DemoData.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-01-27 Thread sourabh jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16342127#comment-16342127
 ] 

sourabh jain commented on OFBIZ-9501:
-

Moved all 'demo' reader data to the 'datamodel' component. Attached 
'OFBIZ-9501-DemoData' patch for review.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-01-16 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327017#comment-16327017
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Taher,

Thank you for the details and everything making perfect sense to me to have 
all/most of the demo data in the data model component. I dig into it further 
and review the data for one component and back  with the data movement plan. 
Then will go for the final move.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-01-11 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323591#comment-16323591
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Hi Riahi

It seems to me that maybe all demo data might be better placed in the datamodel 
component. I could be wrong but here are my thoughts:

- first I think most of the demo data above populates entities defined in the 
data model component. It might be better for data to follow its entities 
location.
- the reason why this JIRA was created is becauae I suffered while 
disentangling application dependencies on ecommerce. I think my life would have 
been easier if everything was in one place.
- also demo data might be very useful even without the components. Demo data 
helps developers understand the entities by showing examples of populated data. 
Also if someone wants to develop their own custom accounting component for 
example then they can test it and check the interface using that demo data.

Do I make sense? Or did I misunderstand something? Either way I'd love to hear 
your thoughts. And hats off for the great work you've done already.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2018-01-11 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322334#comment-16322334
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

[~taher] and all,

I'm looking into it further and check that as per review comment from Taher 
that the data useless without that component then it should belongs to that 
component only. On this we were agree to leave some data in the component 
itself. Here I'm looking into demo data now and taking accounting component 
example for now. Below are the demo data files in the accounting component and 
I see most of the files data should belongs to component itself. So do we need 
to proceed further with this ticket or we should discuss the accounting 
component as example and try to move selective demo data as well. Like all 
seed-initial data belongs to component as per last discussion.
I think demo fall in the same category so no movement required. Also I'm open 
to discuss the part data which can be move and then will apply the patterns to 
other components. Here is the quick reference;

{code}













{code}

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: 17.12.01
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-18 Thread Swapnil M Mane (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296256#comment-16296256
 ] 

Swapnil M Mane commented on OFBIZ-9501:
---

Kudos team, thank to everyone who participated in this!! :-)


> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-16 Thread Michael Brohl (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293819#comment-16293819
 ] 

Michael Brohl commented on OFBIZ-9501:
--

+1

Great effort, thanks all who participated!

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-16 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293801#comment-16293801
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Fantastic work. You guys rock.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-16 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293777#comment-16293777
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

This is complete for all the components, and we have now single pattern for all 
the components. We can discuss it further demo data and the data we left in 
last effort on how to proceed.
Thank you [~taher] [~jacques.le.roux] [~swapnilmmane] [~sourabh.jain] 
[~prakhar.kumar] [~saurabh.dixit] and all for your support and help on this.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-12 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288078#comment-16288078
 ] 

Jacques Le Roux commented on OFBIZ-9501:


Thanks Rishi and Taher for this work!

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-12 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287762#comment-16287762
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Great work!

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-12 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287666#comment-16287666
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

As discussed I have moved all the possible data to data model for all 
components except CommonExt component. I'll move that data soon. After that all 
the discussed data which can be moved will be complete and code patterns for 
all component will follow the same practice.

After that this ticket won't block the release cut and we can plan the release 
cut on any date after 17th-Dec-2017. Thanks!


> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-12-02 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16275560#comment-16275560
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Committed changes for product, accounting and manufacturing components.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-11-28 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268958#comment-16268958
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

[~taher] [~jacques.le.roux],
Thanks for your inputs, I'll do the changes accordingly, that means keep 
configuration data in the same component and commit the changes after 
incorporating suggestion.
Coming back to clean up the things is always open for us. But I would prefer to 
go as discussed to minimize the cleanup work. Soon I'll come back on this 
ticket and do the changes.

Thanks again!

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-11-27 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16266691#comment-16266691
 ] 

Jacques Le Roux commented on OFBIZ-9501:


I agree Taher +1

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-11-26 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265970#comment-16265970
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


So I think it is more important for us to make progress on this issue than to 
set policy. We are thinking together here of the best approach, but if what I 
suggest is going to slow you down considerably then please disregard it. We can 
always go back and clean it up later. The most important thing right now is to 
move the data.

With that being said, I don't have a specific strategy in my mind but perhaps 
the below items are component-specific:
- Security data: user interface security or component access security
- Component help: help on how to use the interface of a certain component
- User interface: Portlets and interfaces in the database that belongs to a 
certain screen in a certain component

So from the above, maybe we can suggest that if a certain piece of data is 
useful on its own because it adds to the domain and knowledge of the system, 
then it fits better in the data-model component. If on the other hand, this 
data is useless without that component then perhaps it belongs in that 
component.

I hope this helps? Either way, great job you guys

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-11-25 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265927#comment-16265927
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Taher,
Thank you for your input, I also think on that data on the similar points. But 
while checking the dependencies I see the data is on seed reader and code will 
also have checks on those data to run the component. For the manufacturing help 
data is only uses the locale demonstration of manufacturing component only. For 
other components help data is only in US English, so I moved that data as well.

In my previous commits I moved the similar data for other components, so if we 
decide to keep such configuration data to the component specific location then 
I'll make changes in those files as well. I agree on the point that 
configuration data should be with component only. But code base uses that data 
in several conditions and seed reader direct me to move that data as well.

On the whole, we can rethink on this and keep the seed reader (for now) at 
component location. Then we can think on seed reader is appropriate for 
configuration data or not. Alternatively if we think seed reader is fine for 
configuration data then we can decide where to keep seed data. Like are we fine 
to have seed data of one component in data model as well as in some specific 
component (Party, Manufacturing etc.). Putting all this to maintain consistency 
and developers ease, because for me when I search for some data in files I 
usually expect that data to some location.

Please suggest how should we proceed, thanks again for your help on this. It 
really help to better understand the things you want to achieve from this 
ticket. Due to the same reason I first add the patch on the ticket and after 
feedback commit the changes.


> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-11-25 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265789#comment-16265789
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Hi Rishi,

As usual thank you for this great work.

I might be wrong as I did not do deep investigation like you probably did, but 
I find some data moved from strange files. For example:

- applications/accounting/data/AccountingHelpData.xml
- applications/accounting/data/AccountingSecurityPermissionSeedData.xml
- applications/manufacturing/data/ManufacturingHelpData_EN.xml
- applications/manufacturing/data/ManufacturingHelpData_NL.xml
- applications/manufacturing/data/ManufacturingSecurityPermissionSeedData.xml

The above files are for help and security permissions. I also saw some files 
for portlets.

Wouldn't it make more sense to move "domain data" instead of "configuration 
data" to the datamodel component? Again I could be wrong in my analysis so 
please forgive my short-sighted input

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated-2.patch, 
> OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-10-30 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224496#comment-16224496
 ] 

Jacques Le Roux commented on OFBIZ-9501:


Thanks for this remarkable effort Rishi!

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-10-29 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224364#comment-16224364
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Taher,
Thanks for your continuous support. I'll commit it by today once tests pass.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-10-28 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223713#comment-16223713
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Hello Rishi and everyone,

I see this patch is substantially large, which means a good amount of effort 
went into it. Thank you!

My recommendation is to go ahead and commit this. I took a quick glance and 
things seem to be in proper order, but it would be lengthy and difficult to 
review a patch of this size, and since multiple people worked on this I trust 
we're in good hands.

Well done folks, keep them coming!

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch, 
> OFBIZ-9501-WorkEffortSeedData.patch, OFBIZ-9501_Consolidated.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) Move all data in applications to the datamodel component

2017-08-26 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142670#comment-16142670
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Committed changes in revisions 1806258, 1806265 and 1806267. Thanks 
[~saurabh.dixit] [~saurabh.jain] and [~prakhar.kumar] for providing patch.

Thanks [~taher] [~swapnilmmane] for help and review.

> Move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Assignee: Rishi Solanki
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-08-24 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139640#comment-16139640
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

[~taher]: Thank you again :)

Only the patch attached by you is in the repository all other patches needs to 
be taken care. This is in my list, but I just wanted to put all seed data for 
one component in one patch. The patch will include all the conclusion Swapnil, 
you and me draw. Very soon (by this week) team will attach new patch for single 
component and will start committing the changes.

Thanks again for your help on this.

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-08-23 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138887#comment-16138887
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Hi Rishi and everyone,

Congratulations again on getting committer ranks. I got a little lost now in 
keeping track of which patch to commit. Are you interested in taking over the 
coordination of this JIRA? I'll try to help out as much as I can if you're 
interested in taking the lead on this.

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-25 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099578#comment-16099578
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Thanks Taher and Swapnil for your comment. My preference is same, will go with 
#1.

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-25 Thread Swapnil M Mane (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099552#comment-16099552
 ] 

Swapnil M Mane commented on OFBIZ-9501:
---

Thanks [~rishisolankii] for sharing your exploration, and [~taher] for your 
comment. 

I personally like the #1 proposal, since this will improved the readability of 
data file and will create a logical separation.

Here is my thought process for this, 
for e.g. StatusItem is different for Order and Content, so it will be nice to 
have them in separate OrderSeedData.xml and ContentSeedData.xml

{code}

{code}

{code}

{code}

Thanks!

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-24 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099519#comment-16099519
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Hi Rishi, I'm not sure but on first impression I think maybe this data should 
go into CommonData.xml file. This way we nicely layout fundamental data 
before higher order data. I'm not sure if this breaks anything though

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-24 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099512#comment-16099512
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

[~taher] / All,

While working and reviewing the work of moving some seed data to data model 
component. I observe few entities data is in all components. Below are few 
names;
- StatusType
- StatusItem
- StatusValidChange
- EnumerationType
- Enumeration
- CustomMethodType
- CustomMethod

Also observe some data which may belongs to other component and exists as seed 
data in other component. Below are few entity names wrt Party component data 
exists in other components;
- RoleType
- ContactMechType
- ContactMechPurposeType
- ContactMechTypePurpose

My question is how should we handle this while moving the data. I could think 
of two options;
1) Move the data as is, that means if any data exists in the Party component 
then we should move that data into PartySeedData.xml (for now considering only 
seed data and with mindset data must be loaded successfully). Later we can 
think if some more logical movements required Or may think to keep them as is 
so that component bifurcation per seed (any) data remains intact.
2) Move the data to relevant component file, for example in the above example 
we would move all role types in the PartySeedData.xml and in data comment we 
could mention the role types used for which component.


Please share you input on this, if we decide this then we will be able to move 
the data quickly. 


> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Prakhar Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097334#comment-16097334
 ] 

Prakhar Kumar commented on OFBIZ-9501:
--

Thanks [~taher] and [~rishisolankii] for reviewing the patch and providing 
inputs. I have updated the patch with the suggested changes. I will check for 
the possibility and dependencies to move same in the Project component and will 
submit a separate patch for that. 

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-002.patch, OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread sourabh jain (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097311#comment-16097311
 ] 

sourabh jain commented on OFBIZ-9501:
-

Moved product type data from product component to datamodel component. Attached 
fourth patch in the sequence for review. 

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Saurabh Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097308#comment-16097308
 ] 

Saurabh Dixit commented on OFBIZ-9501:
--

Attached the third patch in the sequence for review. Moved data from content 
component under applications to datamodel component. Although, I'm not sure if 
we should move some of them to demo instead of seed, like DataResource and its 
associated ElectronicText for rendering standard sub content?

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9051-004.patch, OFBIZ-9501-001.patch, 
> OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097270#comment-16097270
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

[~taher] Thanks for your review and input. Agree with your point, we should try 
to move this data to project component. [~prakhar.kumar] could you please 
remove the data Taher suggested and upload the patch again. After that check 
for the possibility and dependencies to move same in the Project component. And 
submit separate patch for that. Thanks!

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch, OFBIZ-9501-002.patch, 
> OFBIZ-9501-003.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097233#comment-16097233
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Hi Prakhar,

Thank you for your work, its really great to see people contributing to this 
JIRA.

I have a question: Aren't the below records from your patch belonging to the 
"project" component? If yes wouldn't it be better to move it to that component 
instead? I'm not sure if there are also more records, that was just a quick 
skim.

{code: xml}

















{code}

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch, OFBIZ-9501-002.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-22 Thread Prakhar Kumar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097232#comment-16097232
 ] 

Prakhar Kumar commented on OFBIZ-9501:
--

Attaching a patch for review. I have only moved the type data that belongs to 
the Work Effort component.

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch, OFBIZ-9501-002.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-21 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097116#comment-16097116
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Thank you for sharing the info rishi, that should come in handy. I suppose the 
component loading sequence might be helpful but we should not stick to it 
literally because what matters in the end is that all data loads succesfully.

Feel free to commit / submit patches folks. I don't have anything in the 
pipeline for now.

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-21 Thread Swapnil M Mane (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097115#comment-16097115
 ] 

Swapnil M Mane commented on OFBIZ-9501:
---

Thank you [~rishisolankii], this will be helpful! :) 

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-21 Thread Rishi Solanki (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097109#comment-16097109
 ] 

Rishi Solanki commented on OFBIZ-9501:
--

Just as additional information so that sync would be easy to go, here is 
sequence needs to be follow;

{code}
http://www.w3.org/2001/XMLSchema-instance;

xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/component-loader.xsd;>















{code}

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-21 Thread Swapnil M Mane (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096468#comment-16096468
 ] 

Swapnil M Mane commented on OFBIZ-9501:
---

Thank you [~taher]! :)

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-21 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096334#comment-16096334
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Thank you Swapnil, commit is applied in r1802603. I forgot to add the seed file 
in ofbiz-component so I took care of that before committing. All tests pass. 
Ok, one commit down, maybe another 100 to go :)

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-21 Thread Swapnil M Mane (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096153#comment-16096153
 ] 

Swapnil M Mane commented on OFBIZ-9501:
---

Thank you [~taher] for the patch. This will be helpful :)

For ContactMechTypePurpose, IMO it should be the part of seed data because it 
is the very rich defined list, applicable to most of the businesses in the 
world.
By keeping it in seed data, it will be available to all the users and they will 
not have overhead to copy-paste this for their custom development.



> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
> Attachments: OFBIZ-9501-001.patch
>
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-20 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094509#comment-16094509
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


After analyzing some of the data (I will get the first commit soon) I believe 
we should _not_ move any security or portlet data. These things are specific to 
widgets and applications, not the data model. The only data we should move is 
proper modeling data

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Release
>Reporter: Taher Alkhateeb
>Priority: Minor
>  Labels: application, data
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkEffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkEffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkEffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-20 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094380#comment-16094380
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


I've updated the filenames in the description to reflect the camel case and 
data suffix

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── AccountingDemoData.xml
> │   ├── CommonDemoData.xml
> │   ├── ContentDemoData.xml
> │   ├── HumanresDemo.xml
> │   ├── ManufacturingDemoData.xml
> │   ├── MarketingDemoData.xml
> │   ├── OrderDemoData.xml
> │   ├── PartyDemoData.xml
> │   ├── ProductDemoData.xml
> │   ├── ShipmentDemoData.xml
> │   └── WorkeffortDemoData.xml
> ├── seed
> │   ├── AccountingSeedData.xml
> │   ├── CommonSeedData.xml
> │   ├── ContentSeedData.xml
> │   ├── HumanresSeedData.xml
> │   ├── ManufacturingSeedData.xml
> │   ├── MarketingSeedData.xml
> │   ├── OrderSeedData.xml
> │   ├── PartySeedData.xml
> │   ├── ProductSeedData.xml
> │   ├── ShipmentSeedData.xml
> │   └── WorkeffortSeedData.xml
> └── seed-initial
> ├── AccountingSeedInitialData.xml
> ├── CommonSeedInitialData.xml
> ├── ContentSeedInitialData.xml
> ├── HumanresSeedInitialData.xml
> ├── ManufacturingSeedInitialData.xml
> ├── MarketingSeedInitialData.xml
> ├── OrderSeedInitialData.xml
> ├── PartySeedInitialData.xml
> ├── ProductSeedInitialData.xml
> ├── ShipmentSeedInitialData.xml
> └── WorkeffortSeedInitialData.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-20 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094360#comment-16094360
 ] 

Taher Alkhateeb commented on OFBIZ-9501:


Yeah, what you're saying makes sense. We can add the suffix to all data files. 
Maybe we can also use CamelCase instead of hyphenated-names to stay consistent 
with the rest of the framework. Good idea!

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── accounting-demo.xml
> │   ├── common-demo.xml
> │   ├── content-demo.xml
> │   ├── humanres-demo.xml
> │   ├── manufacturing-demo.xml
> │   ├── marketing-demo.xml
> │   ├── order-demo.xml
> │   ├── party-demo.xml
> │   ├── product-demo.xml
> │   ├── shipment-demo.xml
> │   └── workeffort-demo.xml
> ├── seed
> │   ├── accounting-seed.xml
> │   ├── common-seed.xml
> │   ├── content-seed.xml
> │   ├── humanres-seed.xml
> │   ├── manufacturing-seed.xml
> │   ├── marketing-seed.xml
> │   ├── order-seed.xml
> │   ├── party-seed.xml
> │   ├── product-seed.xml
> │   ├── shipment-seed.xml
> │   └── workeffort-seed.xml
> └── seed-initial
> ├── accounting-seed-initial.xml
> ├── common-seed-initial.xml
> ├── content-seed-initial.xml
> ├── humanres-seed-initial.xml
> ├── manufacturing-seed-initial.xml
> ├── marketing-seed-initial.xml
> ├── order-seed-initial.xml
> ├── party-seed-initial.xml
> ├── product-seed-initial.xml
> ├── shipment-seed-initial.xml
> └── workeffort-seed-initial.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9501) move all data in applications to the datamodel component

2017-07-20 Thread Devanshu Vyas (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094354#comment-16094354
 ] 

Devanshu Vyas commented on OFBIZ-9501:
--

Hello Taher,

Looking at your plan for naming the files, I feel that a suffix 'Data' should 
be added for all the data files.

> move all data in applications to the datamodel component
> 
>
> Key: OFBIZ-9501
> URL: https://issues.apache.org/jira/browse/OFBIZ-9501
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Taher Alkhateeb
>Priority: Minor
>
> As per a community [discussion 
> thread|https://lists.apache.org/thread.html/eb6ea79195204356a362dbf208c5dbb6d321d001bf2b79819dc45a24@%3Cdev.ofbiz.apache.org%3E]
>  we decided to move all data (seed, seed-initial, demo) to the datamodel 
> component. and to also reduce and cleanup this data to ease debugging and 
> maintenance.
> After moving all the data, the directory and file structure would be similar 
> to the below:
> data/
> ├── demo
> │   ├── accounting-demo.xml
> │   ├── common-demo.xml
> │   ├── content-demo.xml
> │   ├── humanres-demo.xml
> │   ├── manufacturing-demo.xml
> │   ├── marketing-demo.xml
> │   ├── order-demo.xml
> │   ├── party-demo.xml
> │   ├── product-demo.xml
> │   ├── shipment-demo.xml
> │   └── workeffort-demo.xml
> ├── seed
> │   ├── accounting-seed.xml
> │   ├── common-seed.xml
> │   ├── content-seed.xml
> │   ├── humanres-seed.xml
> │   ├── manufacturing-seed.xml
> │   ├── marketing-seed.xml
> │   ├── order-seed.xml
> │   ├── party-seed.xml
> │   ├── product-seed.xml
> │   ├── shipment-seed.xml
> │   └── workeffort-seed.xml
> └── seed-initial
> ├── accounting-seed-initial.xml
> ├── common-seed-initial.xml
> ├── content-seed-initial.xml
> ├── humanres-seed-initial.xml
> ├── manufacturing-seed-initial.xml
> ├── marketing-seed-initial.xml
> ├── order-seed-initial.xml
> ├── party-seed-initial.xml
> ├── product-seed-initial.xml
> ├── shipment-seed-initial.xml
> └── workeffort-seed-initial.xml



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)