[GitHub] [incubator-superset] mistercrunch merged pull request #9099: Moving away from using the root logger everywhere

2020-02-07 Thread GitBox
mistercrunch merged pull request #9099: Moving away from using the root logger everywhere URL: https://github.com/apache/incubator-superset/pull/9099 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-superset] stale[bot] commented on issue #8730: Fix error control label Metrics validator

2020-02-07 Thread GitBox
stale[bot] commented on issue #8730: Fix error control label Metrics validator URL: https://github.com/apache/incubator-superset/pull/8730#issuecomment-583708658 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further

[GitHub] [incubator-superset] nytai opened a new pull request #9102: don't use msgpack if using SQLLAB_BACKEND_PERSISTENCE and returning r…

2020-02-07 Thread GitBox
nytai opened a new pull request #9102: don't use msgpack if using SQLLAB_BACKEND_PERSISTENCE and returning r… URL: https://github.com/apache/incubator-superset/pull/9102 …esults ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) -

[GitHub] [incubator-superset] stale[bot] commented on issue #8638: superset-ui-plugins linking tool for local development

2020-02-07 Thread GitBox
stale[bot] commented on issue #8638: superset-ui-plugins linking tool for local development URL: https://github.com/apache/incubator-superset/pull/8638#issuecomment-583684968 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no

[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2020-02-07 Thread GitBox
robdiciuccio commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r376674992 ## File path: superset/sql_lab.py ## @@ -245,9 +245,6 @@ def execute_sql_statements(

[GitHub] [incubator-superset] stale[bot] closed issue #8701: Improve and fix portuguese translation

2020-02-07 Thread GitBox
stale[bot] closed issue #8701: Improve and fix portuguese translation URL: https://github.com/apache/incubator-superset/issues/8701 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-superset] stale[bot] closed issue #8717: hdp superset started error:'NoneType' object has no attribute 'name'

2020-02-07 Thread GitBox
stale[bot] closed issue #8717: hdp superset started error:'NoneType' object has no attribute 'name' URL: https://github.com/apache/incubator-superset/issues/8717 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] nytai commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
nytai commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-583652335 Would be great to use the same build/lint/test config that's used in `@superset-ui`

[GitHub] [incubator-superset] kristw commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
kristw commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-583651122 I agree with using `eslint` for both `js` and `ts`

[GitHub] [incubator-superset] kristw commented on issue #8865: deprecate tslint in favor of eslint w/ typescript support

2020-02-07 Thread GitBox
kristw commented on issue #8865: deprecate tslint in favor of eslint w/ typescript support URL: https://github.com/apache/incubator-superset/issues/8865#issuecomment-583650888 Those repositories use `eslint` with `typescript`.

[GitHub] [incubator-superset] kristw edited a comment on issue #8865: deprecate tslint in favor of eslint w/ typescript support

2020-02-07 Thread GitBox
kristw edited a comment on issue #8865: deprecate tslint in favor of eslint w/ typescript support URL: https://github.com/apache/incubator-superset/issues/8865#issuecomment-583650888 Those repositories use `eslint` with `typescript` support.

[GitHub] [incubator-superset] craig-rueda merged pull request #9081: [dashboard] Fix for dashboard edit modal, loading user list

2020-02-07 Thread GitBox
craig-rueda merged pull request #9081: [dashboard] Fix for dashboard edit modal, loading user list URL: https://github.com/apache/incubator-superset/pull/9081 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-superset] nytai edited a comment on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
nytai edited a comment on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-583650129 I've found some of the lint rules and general use of tslint to be less friendly than the linting rules for

[GitHub] [incubator-superset] nytai commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
nytai commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-583650129 I've found some of the lint rules and general use of tslint to be less friendly than the linting rules for regular js

[GitHub] [incubator-superset] ynohat commented on issue #9043: Add support for Cockroach DB

2020-02-07 Thread GitBox
ynohat commented on issue #9043: Add support for Cockroach DB URL: https://github.com/apache/incubator-superset/pull/9043#issuecomment-583645752 @derari thanks a lot for your work on this! I tried to apply the changes in this PR manually, and it didn't work OOTB with

[GitHub] [incubator-superset] etr2460 commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
etr2460 commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-583644282 Fair point about developer productivity, my perspective is that any short term decrease in velocity due to devs in

[GitHub] [incubator-superset] ali-bahjati commented on issue #8940: Add Iran to Country Visualization

2020-02-07 Thread GitBox
ali-bahjati commented on issue #8940: Add Iran to Country Visualization URL: https://github.com/apache/incubator-superset/pull/8940#issuecomment-583644110 My PR in superset-ui is merged now. I think you can merge this. I don't know should I increase superset-ui-plugins package version or

[GitHub] [incubator-superset] kristw edited a comment on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
kristw edited a comment on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-583637502 Agree with this direction. `@superset-ui` is already 100% typescript. New plugins should be written in

[GitHub] [incubator-superset] rusackas commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
rusackas commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-583637729 Just one small note of devil's advocacy: I agree with the "decrease in bugs" advantage, but I'm not 100% sure

[GitHub] [incubator-superset] kristw commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
kristw commented on issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101#issuecomment-583637502 Agree with this direction. `@superset-ui` is already 100% typescript.

[GitHub] [incubator-superset] mistercrunch merged pull request #9091: [datasources] Fix, Prevent gamma user's from accessing save datasources

2020-02-07 Thread GitBox
mistercrunch merged pull request #9091: [datasources] Fix, Prevent gamma user's from accessing save datasources URL: https://github.com/apache/incubator-superset/pull/9091 This is an automated message from the Apache Git

[GitHub] [incubator-superset] etr2460 opened a new issue #9101: [SIP-36] Proposal for standardizing use of TypeScript

2020-02-07 Thread GitBox
etr2460 opened a new issue #9101: [SIP-36] Proposal for standardizing use of TypeScript URL: https://github.com/apache/incubator-superset/issues/9101 ## [SIP-36] Proposal for standardizing use of TypeScript ### Motivation Since

[GitHub] [incubator-superset] sibblegp commented on issue #7336: default login/password not known after bringing up the Docker container

2020-02-07 Thread GitBox
sibblegp commented on issue #7336: default login/password not known after bringing up the Docker container URL: https://github.com/apache/incubator-superset/issues/7336#issuecomment-583608268 This should absolutely be documented. It's like hitting a brick wall.

[GitHub] [incubator-superset] stale[bot] closed issue #8695: "Custom OAuth2 configuration" docs should mention auth_user_oauth and relevant info in Flask-AppBuilder security

2020-02-07 Thread GitBox
stale[bot] closed issue #8695: "Custom OAuth2 configuration" docs should mention auth_user_oauth and relevant info in Flask-AppBuilder security URL: https://github.com/apache/incubator-superset/issues/8695 This is an

[GitHub] [incubator-superset] stale[bot] closed issue #8375: Finance Related Charts

2020-02-07 Thread GitBox
stale[bot] closed issue #8375: Finance Related Charts URL: https://github.com/apache/incubator-superset/issues/8375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-superset] stale[bot] closed issue #7887: Filtering data per user on DB table level (Customer or Tenant Support)

2020-02-07 Thread GitBox
stale[bot] closed issue #7887: Filtering data per user on DB table level (Customer or Tenant Support) URL: https://github.com/apache/incubator-superset/issues/7887 This is an automated message from the Apache Git Service.

[GitHub] [incubator-superset] suddjian commented on a change in pull request #9098: SIP-32: Moving frontend code to the base of the repo

2020-02-07 Thread GitBox
suddjian commented on a change in pull request #9098: SIP-32: Moving frontend code to the base of the repo URL: https://github.com/apache/incubator-superset/pull/9098#discussion_r376520288 ## File path: superset-frontend/package.json ## @@ -13,7 +13,7 @@ "cover":

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9099: Moving away from using the root logger everywhere

2020-02-07 Thread GitBox
dpgaspar commented on a change in pull request #9099: Moving away from using the root logger everywhere URL: https://github.com/apache/incubator-superset/pull/9099#discussion_r376515519 ## File path: superset/views/base_api.py ## @@ -62,7 +63,6 @@ class

[GitHub] [incubator-superset] stale[bot] commented on issue #8784: _get_slice_data fails to send slice data when Celery Workers are on another instance

2020-02-07 Thread GitBox
stale[bot] commented on issue #8784: _get_slice_data fails to send slice data when Celery Workers are on another instance URL: https://github.com/apache/incubator-superset/issues/8784#issuecomment-583444555 This issue has been automatically marked as stale because it has not had recent

[GitHub] [incubator-superset] stale[bot] commented on issue #8632: docker-compose failed to build

2020-02-07 Thread GitBox
stale[bot] commented on issue #8632: docker-compose failed to build URL: https://github.com/apache/incubator-superset/issues/8632#issuecomment-583365054 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity

[GitHub] [incubator-superset] stale[bot] closed issue #8696: PyPI page - broken link and gitter

2020-02-07 Thread GitBox
stale[bot] closed issue #8696: PyPI page - broken link and gitter URL: https://github.com/apache/incubator-superset/issues/8696 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-superset] stale[bot] closed issue #8700: I need help please , does the jquery affect the result of add database option,my version is the latest 0.35.1

2020-02-07 Thread GitBox
stale[bot] closed issue #8700: I need help please , does the jquery affect the result of add database option,my version is the latest 0.35.1 URL: https://github.com/apache/incubator-superset/issues/8700 This is an

[GitHub] [incubator-superset] dpugulo opened a new issue #9100: problem when running long query : MySQL server has gone away - Lost connection to MySQL server during query

2020-02-07 Thread GitBox
dpugulo opened a new issue #9100: problem when running long query : MySQL server has gone away - Lost connection to MySQL server during query URL: https://github.com/apache/incubator-superset/issues/9100 A clear and concise description of what the bug is. ### Expected results

[GitHub] [incubator-superset] AnkitSingh02 commented on issue #8877: Can't load plugin: sqlalchemy.dialects:snowflake error when testing connection while adding datasource

2020-02-07 Thread GitBox
AnkitSingh02 commented on issue #8877: Can't load plugin: sqlalchemy.dialects:snowflake error when testing connection while adding datasource URL: https://github.com/apache/incubator-superset/issues/8877#issuecomment-583282295 Have already installed the library sqlalchemy_clickhouse