[GitHub] [incubator-superset] serenajiang opened a new pull request #8139: [sqllab] add retries for stop_query
serenajiang opened a new pull request #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Added retries for `stop_query`, which was having lock timeout issues. Handle `DatabaseError`s. ### TEST PLAN tox passes. ### REVIEWERS @graceguo-supercat This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kristw opened a new pull request #8140: remove unused files
kristw opened a new pull request #8140: remove unused files URL: https://github.com/apache/incubator-superset/pull/8140 ### CATEGORY Choose one - [X] Build / Development Environment ### SUMMARY These files were migrated to `@superset-ui` and no longer used. ### TEST PLAN `npm run build` ### REVIEWERS This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8140: remove unused files
codecov-io commented on issue #8140: remove unused files URL: https://github.com/apache/incubator-superset/pull/8140#issuecomment-526075770 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8140?src=pr=h1) Report > Merging [#8140](https://codecov.io/gh/apache/incubator-superset/pull/8140?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.5%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/8140?src=pr=tree) ```diff @@Coverage Diff@@ ## master #8140 +/- ## = - Coverage 73.71% 66.2% -7.51% = Files 115 479 +364 Lines 12059 22947 +10888 Branches02527+2527 = + Hits 8889 15192+6303 - Misses 31707621+4451 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8140?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | | | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `81.81% <0%> (ø)` | | | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | | | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | | | [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VbmRvUmVkb0tleWxpc3RlbmVycy5qc3g=) | `9.52% <0%> (ø)` | | | [...ts/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUFjdGlvbkJ1dHRvbnMuanN4) | `100% <0%> (ø)` | | | ... and [355 more](https://codecov.io/gh/apache/incubator-superset/pull/8140/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8140?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8140?src=pr=footer). Last update [6aa10dc...10a971e](https://codecov.io/gh/apache/incubator-superset/pull/8140?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their own password without allowing `can edit on UserDBModelView`, by enabling only these permissions: `can this form post on ResetMyPasswordView, can this form get on ResetMyPasswordView, can userinfo on UserDBModelView, resetmypassword on UserDBModelView` Is there anything that I'm missing or a potential security issue with these enabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Giuzzilla commented on issue #2731: Give users the rights to change their password
Giuzzilla commented on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their own password without allowing `can edit on UserDBModelView`, by enabling only these permissions: `can this form post on ResetMyPasswordView can this form get on ResetMyPasswordView can userinfo on UserDBModelView resetmypassword on UserDBModelView` Is there anything that I'm missing or a potential security issue with these enabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8139: [sqllab] add retries for stop_query
codecov-io edited a comment on issue #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139#issuecomment-526066743 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=h1) Report > Merging [#8139](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.77%`. > The diff coverage is `10.52%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8139 +/- ## == - Coverage 73.71% 65.93% -7.78% == Files 115 486 +371 Lines 1205923043 +10984 Branches0 2541+2541 == + Hits 888915194+6305 - Misses 3170 7715+4545 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.95% <10.52%> (-0.52%)` | :arrow_down: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | | | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `81.81% <0%> (ø)` | | | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | | | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | | | [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VbmRvUmVkb0tleWxpc3RlbmVycy5qc3g=) | `9.52% <0%> (ø)` | | | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=footer). Last update [6aa10dc...6d0574a](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe,
[GitHub] [incubator-superset] syazwan0913 opened a new issue #8141: What is the CSV file limit size for upload?
syazwan0913 opened a new issue #8141: What is the CSV file limit size for upload? URL: https://github.com/apache/incubator-superset/issues/8141 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] malazbw opened a new issue #8142: Normal_distribution over bar chart
malazbw opened a new issue #8142: Normal_distribution over bar chart URL: https://github.com/apache/incubator-superset/issues/8142 Hi, is it possible, to draw normal_distribution over barchart by sperset ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8142: Normal_distribution over bar chart
issue-label-bot[bot] commented on issue #8142: Normal_distribution over bar chart URL: https://github.com/apache/incubator-superset/issues/8142#issuecomment-526132287 Issue Label Bot is not confident enough to auto-label this issue. See [dashboard](https://mlbot.net/data/apache/incubator-superset) for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8141: What is the CSV file limit size for upload?
issue-label-bot[bot] commented on issue #8141: What is the CSV file limit size for upload? URL: https://github.com/apache/incubator-superset/issues/8141#issuecomment-526105567 Issue Label Bot is not confident enough to auto-label this issue. See [dashboard](https://mlbot.net/data/apache/incubator-superset) for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] request-info[bot] commented on issue #8141: What is the CSV file limit size for upload?
request-info[bot] commented on issue #8141: What is the CSV file limit size for upload? URL: https://github.com/apache/incubator-superset/issues/8141#issuecomment-526105574 We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the `title` or `description` empty. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] syazwan0913 commented on issue #8141: What is the CSV file limit size for upload?
syazwan0913 commented on issue #8141: What is the CSV file limit size for upload? URL: https://github.com/apache/incubator-superset/issues/8141#issuecomment-526105894 Is there any limit for the CSV file size to be uploaded in Superset? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their own password without allowing `can edit on UserDBModelView` nor `* ResetPasswordView,` by enabling only these permissions: ``` can this form post on ResetMyPasswordView, can this form get on ResetMyPasswordView, can userinfo on UserDBModelView, resetmypassword on UserDBModelView ``` Is there anything that I'm missing or a potential security issue with these enabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their own password without allowing `can edit on UserDBModelView` or related to `ResetPasswordView,` by enabling only these permissions: ``` can this form post on ResetMyPasswordView, can this form get on ResetMyPasswordView, can userinfo on UserDBModelView, resetmypassword on UserDBModelView ``` Is there anything that I'm missing or a potential security issue with these enabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their own password without allowing `can edit on UserDBModelView` or related to `ResetPasswordView`, by enabling only these permissions: ``` can this form post on ResetMyPasswordView, can this form get on ResetMyPasswordView, can userinfo on UserDBModelView, resetmypassword on UserDBModelView ``` Is there anything that I'm missing or a potential security issue with these enabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] klazaj commented on issue #8127: Frontend not built after installing Superset with Docker
klazaj commented on issue #8127: Frontend not built after installing Superset with Docker URL: https://github.com/apache/incubator-superset/issues/8127#issuecomment-526211745 @dpgaspar updated the post with the logs after deleting the image and reinstalling This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed pull request #7757: Update druid.rst
stale[bot] closed pull request #7757: Update druid.rst URL: https://github.com/apache/incubator-superset/pull/7757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] smokemonster99 commented on issue #8102: Dashboard filters do not persist on page refresh
smokemonster99 commented on issue #8102: Dashboard filters do not persist on page refresh URL: https://github.com/apache/incubator-superset/issues/8102#issuecomment-52621 Yes but this does not work on v0.26.3. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] etr2460 opened a new pull request #8143: [Codemod] Rename react unsafe lifecycles
etr2460 opened a new pull request #8143: [Codemod] Rename react unsafe lifecycles URL: https://github.com/apache/incubator-superset/pull/8143 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Cleans up some of these console warnings:  Ran `npx react-codemod rename-unsafe-lifecycles` in `superset/assets/src` and `superset/assets/spec`. However, we still have a decent number of dependencies that we'll need to update prior to being able to use React 17. This can be pushed off for a while (because React 17 isn't even out yet), but at some point, we'll have to pay the piper and upgrade a bunch of stuff. This'll include (I think) moving to a newer version of Bootstrap and finding a new React virtualizable library, as well as a bunch of other changes. No actions needed yet, but we'll wanna keep this on the future radar. ### TEST PLAN Ensure dashboards, charts, and SQL Lab still work as expected. CI/Tests ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @graceguo-supercat @kristw @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8139: [sqllab] add retries for stop_query
codecov-io commented on issue #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139#issuecomment-526066743 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=h1) Report > Merging [#8139](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.77%`. > The diff coverage is `10.52%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8139 +/- ## == - Coverage 73.71% 65.93% -7.78% == Files 115 486 +371 Lines 1205923043 +10984 Branches0 2541+2541 == + Hits 888915194+6305 - Misses 3170 7715+4545 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `70.95% <10.52%> (-0.52%)` | :arrow_down: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | | | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `81.81% <0%> (ø)` | | | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | | | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | | | [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VbmRvUmVkb0tleWxpc3RlbmVycy5qc3g=) | `9.52% <0%> (ø)` | | | ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/8139/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=footer). Last update [6aa10dc...6d0574a](https://codecov.io/gh/apache/incubator-superset/pull/8139?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe,
[GitHub] [incubator-superset] Giuzzilla edited a comment on issue #2731: Give users the rights to change their password
Giuzzilla edited a comment on issue #2731: Give users the rights to change their password URL: https://github.com/apache/incubator-superset/issues/2731#issuecomment-526084006 It's possible to make them see their own profile + see the password change button + allowing them to change their own password without allowing `can edit on UserDBModelView`, by enabling only these permissions: ``` can this form post on ResetMyPasswordView, can this form get on ResetMyPasswordView, can userinfo on UserDBModelView, resetmypassword on UserDBModelView ``` Is there anything that I'm missing or a potential security issue with these enabled? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.59%`. > The diff coverage is `98.22%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8138 +/- ## == - Coverage 73.71% 66.11%-7.6% == Files 115 486 +371 Lines 1205923135 +11076 Branches0 2541+2541 == + Hits 888915296+6407 - Misses 3170 7705+4535 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.38% <100%> (+0.72%)` | :arrow_up: | | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <100%> (+22.22%)` | :arrow_up: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.99% <100%> (+0.94%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <94.44%> (+4.35%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.86% <98.52%> (+0.48%)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | ... and [369 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=footer). Last update [6aa10dc...4b50c18](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail:
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.59%`. > The diff coverage is `98.22%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8138 +/- ## == - Coverage 73.71% 66.11%-7.6% == Files 115 486 +371 Lines 1205923135 +11076 Branches0 2541+2541 == + Hits 888915296+6407 - Misses 3170 7705+4535 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.38% <100%> (+0.72%)` | :arrow_up: | | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <100%> (+22.22%)` | :arrow_up: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.99% <100%> (+0.94%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <94.44%> (+4.35%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.86% <98.52%> (+0.48%)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | ... and [369 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=footer). Last update [6aa10dc...4b50c18](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail:
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319264510 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@ class QueryObject: and druid. The query objects are constructed on the client. """ +granularity: str +from_dttm: datetime +to_dttm: datetime +is_timeseries: bool +time_shift: timedelta +groupby: List[str] +metrics: List[Union[Dict, str]] +row_limit: int +filter: List[str] +timeseries_limit: int +timeseries_limit_metric: Optional[Dict] +order_desc: bool +extras: Dict +columns: List[str] +orderby: List[List] + def __init__( self, granularity: str, metrics: List[Union[Dict, str]], -groupby: List[str] = None, -filters: List[str] = None, +groupby: Optional[List[str]] = None, Review comment: that's horrible... I'm going to go back to javascript and never return This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-526361104 I figured - yeah - it may have just slipped under his radar. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] kristw merged pull request #8140: remove unused files
kristw merged pull request #8140: remove unused files URL: https://github.com/apache/incubator-superset/pull/8140 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] stale[bot] closed pull request #7758: Update gallery.rst
stale[bot] closed pull request #7758: Update gallery.rst URL: https://github.com/apache/incubator-superset/pull/7758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-526388534 @etr2460, do you want to take another stab at reviewing this? I'm currently working on fixing the failing unit tests, but I'm suspecting they might be unrelated and I'm having a hard time reproing them locally. But while I figure out the problem, I appreciate if you could do another pass on reviewing it, since this is a big PR and there have been other changes to SQL Lab in the meantime. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319208187 ## File path: superset/common/query_context.py ## @@ -109,17 +114,17 @@ def get_query_result(self, query_object): "df": df, } -def df_metrics_to_num(self, df, query_object): +def df_metrics_to_num(self, df: pd.DataFrame, query_object: QueryObject) -> None: """Converting metrics to numeric when pandas.read_sql cannot""" metrics = [metric for metric in query_object.metrics] for col, dtype in df.dtypes.items(): if dtype.type == np.object_ and col in metrics: df[col] = pd.to_numeric(df[col], errors="coerce") -def get_data(self, df): +def get_data(self, df: pd.DataFrame) -> List[Dict]: Review comment: `orient=records` makes `DataFrame.to_dict` return a list of dicts. I, too, was very confused. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319210270 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@ class QueryObject: and druid. The query objects are constructed on the client. """ +granularity: str +from_dttm: datetime +to_dttm: datetime +is_timeseries: bool +time_shift: timedelta +groupby: List[str] +metrics: List[Union[Dict, str]] +row_limit: int +filter: List[str] +timeseries_limit: int +timeseries_limit_metric: Optional[Dict] +order_desc: bool +extras: Dict +columns: List[str] +orderby: List[List] + def __init__( self, granularity: str, metrics: List[Union[Dict, str]], -groupby: List[str] = None, -filters: List[str] = None, +groupby: Optional[List[str]] = None, Review comment: Setting default values to be mutable is tricky. Ex. ```python def f(lst=[]): return lst a = f() # a = [] a.append(3) # a = [3] print(f()) # prints [3] ohno ``` ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang commented on a change in pull request #8138: [typing] add typing
for superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r319224456
##
File path: superset/common/query_context.py
##
@@ -150,8 +155,8 @@ def cache_timeout(self):
return self.datasource.database.cache_timeout
return config.get("CACHE_DEFAULT_TIMEOUT")
Review comment:
Most of the code seems to assume that `config.get(KEY)` will never return
`None`, so I did typing under that assumption too. Not sure if that's ok? If we
are working under that assumption, could definitely change all
`config.get(KEY)` to `config[KEY]`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8143: [Codemod] Rename react unsafe lifecycles
codecov-io commented on issue #8143: [Codemod] Rename react unsafe lifecycles URL: https://github.com/apache/incubator-superset/pull/8143#issuecomment-526351465 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=h1) Report > Merging [#8143](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.88%`. > The diff coverage is `58.06%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8143 +/- ## == - Coverage 73.71% 65.82% -7.89% == Files 115 486 +371 Lines 1205923030 +10971 Branches0 2541+2541 == + Hits 888915160+6271 - Misses 3170 7736+4566 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=tree) | Coverage Δ | | |---|---|---| | [...erset/assets/src/visualizations/deckgl/factory.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvZmFjdG9yeS5qc3g=) | `0% <0%> (ø)` | | | [superset/assets/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0FuY2hvckxpbmsuanN4) | `83.33% <0%> (ø)` | | | [...t/assets/src/visualizations/deckgl/Multi/Multi.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvTXVsdGkvTXVsdGkuanN4) | `0% <0%> (ø)` | | | [...s/src/dashboard/components/gridComponents/Tabs.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9UYWJzLmpzeA==) | `61.11% <0%> (ø)` | | | [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9NYXJrZG93bi5qc3g=) | `91.3% <0%> (ø)` | | | [...explore/components/controls/AdhocFilterControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvQWRob2NGaWx0ZXJDb250cm9sLmpzeA==) | `65.43% <0%> (ø)` | | | [...uperset/assets/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9IZWFkZXIuanN4) | `42.2% <0%> (ø)` | | | [...sualizations/deckgl/CategoricalDeckGLContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvQ2F0ZWdvcmljYWxEZWNrR0xDb250YWluZXIuanN4) | `0% <0%> (ø)` | | | [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `49.63% <0%> (ø)` | | | [superset/assets/src/CRUD/CollectionTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9DUlVEL0NvbGxlY3Rpb25UYWJsZS5qc3g=) | `62.88% <0%> (ø)` | | | ... and [395 more](https://codecov.io/gh/apache/incubator-superset/pull/8143/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=footer). Last update [6aa10dc...deec08d](https://codecov.io/gh/apache/incubator-superset/pull/8143?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319220516 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@ class QueryObject: and druid. The query objects are constructed on the client. """ +granularity: str +from_dttm: datetime +to_dttm: datetime +is_timeseries: bool +time_shift: timedelta +groupby: List[str] +metrics: List[Union[Dict, str]] +row_limit: int +filter: List[str] +timeseries_limit: int +timeseries_limit_metric: Optional[Dict] +order_desc: bool +extras: Dict +columns: List[str] +orderby: List[List] + def __init__( self, granularity: str, metrics: List[Union[Dict, str]], -groupby: List[str] = None, -filters: List[str] = None, +groupby: Optional[List[str]] = None, Review comment: Well spotted @serenajiang , mutable default values in python are to be avoided at all cost This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
ericandrewmeadows commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-526340562 @dpgaspar / @villebro - what's the process for merging this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items
villebro commented on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-526347785 LGTM, but I don't feel comfortable merging before @dpgaspar approves this, as he is more knowledgeable on this topic than I am. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang opened a new pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang opened a new pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138 ### CATEGORY Choose one - [ ] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [X] Documentation ### SUMMARY Added typing to most of `superset/connectors` and `superset/common`. Fun stuff. I left a few of the more confusing methods untyped. Possible issues: * Occasionally treating sqlalchemy `Column`s as their corresponding python types. * `# noqa` in a number of places. Mostly issues with dicts and missing return statements. ### TEST PLAN tox passes for py36 and flake8. ### REVIEWERS @etr2460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang closed pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang closed pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319206814 ## File path: superset/common/query_context.py ## @@ -40,8 +42,13 @@ class QueryContext: to retrieve the data payload for a given viz. """ -cache_type = "df" -enforce_numerical_metrics = True +cache_type: str = "df" +enforce_numerical_metrics: bool = True + +datasource: BaseDatasource +queries: List[QueryObject] +force: bool +custom_cache_timeout: Optional[int] Review comment: In this case it's fine because I don't actually set a value for queries, so these are just here to enforce types so that statements like `a.queries.append(3)` will fail. The problem you described would happen if I had written something like `queries: List[QueryObject] = []`. ...which I just realized I probably did in other files. Thanks for alerting me about this issue! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
villebro commented on a change in pull request #8138: [typing] add typing for
superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r319226410
##
File path: superset/common/query_context.py
##
@@ -150,8 +155,8 @@ def cache_timeout(self):
return self.datasource.database.cache_timeout
return config.get("CACHE_DEFAULT_TIMEOUT")
Review comment:
I think anything that is defined with a default value other than `None` in
`config.py` can be assumed to never return `None`. So if it helps typing, I
think going with `config[key]` is ok.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database
villebro commented on issue #8074: Common Table Expressions (CTE's) do not work for Microsoft SQL Server database URL: https://github.com/apache/incubator-superset/issues/8074#issuecomment-526344999 Looking more closely at this problem, it seems MSSQL is one of the few engines that doesn't support wrapping CTEs in subqueries (even Oracle supports this). Furthermore, most engines do equal predicate pushdown for CTEs and subqueries, which means that wrapping SQL Lab queries in CTEs in most cases wouldn't have a significant positive performance impact (on Postgres 11 and below CTEs actually perform worse than subqueries!). As this problem seems to be mostly an MSSQL problem, I think I'll leave this on the backlog for now, as making this work correctly would require a rather significant development effort that's difficult to justify given other more pressing issues/features. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression
codecov-io edited a comment on issue #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression URL: https://github.com/apache/incubator-superset/pull/8080#issuecomment-526346690 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=h1) Report > Merging [#8080](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.74%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8080 +/- ## == - Coverage 73.71% 65.96% -7.75% == Files 115 486 +371 Lines 1205923032 +10973 Branches0 2541+2541 == + Hits 888915194+6305 - Misses 3170 7704+4534 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `89.39% <100%> (ø)` | :arrow_up: | | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.23% <100%> (+0.01%)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | | | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `81.81% <0%> (ø)` | | | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | | | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | | | ... and [364 more](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=footer). Last update [6aa10dc...b68f03e](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail:
[GitHub] [incubator-superset] codecov-io commented on issue #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression
codecov-io commented on issue #8080: [bugfix] Fix CTEs for engines that don't support LIMIT expression URL: https://github.com/apache/incubator-superset/pull/8080#issuecomment-526346690 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=h1) Report > Merging [#8080](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.74%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8080 +/- ## == - Coverage 73.71% 65.96% -7.75% == Files 115 486 +371 Lines 1205923032 +10973 Branches0 2541+2541 == + Hits 888915194+6305 - Misses 3170 7704+4534 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `89.39% <100%> (ø)` | :arrow_up: | | [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.23% <100%> (+0.01%)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | `0% <0%> (ø)` | | | [superset/assets/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0VkaXRhYmxlVGl0bGUuanN4) | `81.81% <0%> (ø)` | | | [superset/assets/src/setup/setupPlugins.js](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9zZXR1cC9zZXR1cFBsdWdpbnMuanM=) | `0% <0%> (ø)` | | | [...t/assets/src/components/InfoTooltipWithTrigger.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZm9Ub29sdGlwV2l0aFRyaWdnZXIuanN4) | `41.66% <0%> (ø)` | | | ... and [364 more](https://codecov.io/gh/apache/incubator-superset/pull/8080/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=footer). Last update [6aa10dc...b68f03e](https://codecov.io/gh/apache/incubator-superset/pull/8080?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail:
[GitHub] [incubator-superset] kuckjwi0928 commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
kuckjwi0928 commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-526408484 Default permissions will be created when superset init is performed. ~~~python def init(): """Inits the Superset application"" utils.get_or_create_main_db() utils.get_example_database() appbuilder.add_permissions(update_perms=True) security_manager.sync_role_definitions() ~~~ If you are using a single DB, have you modified the SQLALCHEMY_DATABASE_URI setting? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-526401610 I added new integration tests, but looks like Travis is not running them. I ran them locally and they passed: ```bash $ tox -e cypress-sqllab-backend-persist ... (Run Finished) SpecTests Passing Failing Pending Skipped ┌┐ │ ✔ sqllab/index.test.js 00:1154 -1- │ └┘ All specs passed! 00:1154 -1- real0m23.016s user0m27.370s sys 0m5.313s __ summary ___ cypress-sqllab-backend-persist: commands succeeded congratulations :) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8060: SIP-23: Persist SQL Lab state in the backend
codecov-io commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-526402924 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=h1) Report > Merging [#8060](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.71%`. > The diff coverage is `54.76%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8060 +/- ## == - Coverage 73.71% 65.99% -7.72% == Files 115 479 +364 Lines 1205923265 +11206 Branches0 2599+2599 == + Hits 888915354+6465 - Misses 3170 7767+4597 - Partials0 144 +144 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvQXBwLmpzeA==) | `0% <ø> (ø)` | | | [superset/assets/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9yZWR1eFV0aWxzLmpz) | `58.82% <0%> (ø)` | | | [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | | | [superset/assets/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvc3FsTGFiLmpz) | `41.2% <0%> (ø)` | | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.46% <100%> (ø)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `88.64% <100%> (ø)` | :arrow_up: | | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `84.16% <100%> (ø)` | | | [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `79.77% <100%> (ø)` | | | [superset/assets/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9mZWF0dXJlRmxhZ3MudHM=) | `90.9% <100%> (ø)` | | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.23% <28.57%> (-0.24%)` | :arrow_down: | | ... and [371 more](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=footer). Last update [6aa10dc...94d7634](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #8060: SIP-23: Persist SQL Lab state in the backend
codecov-io commented on issue #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#issuecomment-526402926 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=h1) Report > Merging [#8060](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.71%`. > The diff coverage is `54.76%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8060 +/- ## == - Coverage 73.71% 65.99% -7.72% == Files 115 479 +364 Lines 1205923265 +11206 Branches0 2599+2599 == + Hits 888915354+6465 - Misses 3170 7767+4597 - Partials0 144 +144 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/assets/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvQXBwLmpzeA==) | `0% <ø> (ø)` | | | [superset/assets/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9yZWR1eFV0aWxzLmpz) | `58.82% <0%> (ø)` | | | [...rset/assets/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0% <0%> (ø)` | | | [superset/assets/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvc3FsTGFiLmpz) | `41.2% <0%> (ø)` | | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `77.46% <100%> (ø)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `88.64% <100%> (ø)` | :arrow_up: | | [superset/assets/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL1RhYmxlU2VsZWN0b3IuanN4) | `84.16% <100%> (ø)` | | | [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `79.77% <100%> (ø)` | | | [superset/assets/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9mZWF0dXJlRmxhZ3MudHM=) | `90.9% <100%> (ø)` | | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.23% <28.57%> (-0.24%)` | :arrow_down: | | ... and [371 more](https://codecov.io/gh/apache/incubator-superset/pull/8060/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=footer). Last update [6aa10dc...94d7634](https://codecov.io/gh/apache/incubator-superset/pull/8060?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.36%`. > The diff coverage is `93.13%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8138 +/- ## == - Coverage 73.71% 66.35% -7.37% == Files 115 479 +364 Lines 1205923050 +10991 Branches0 2527+2527 == + Hits 888915294+6405 - Misses 3170 7622+4452 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <80%> (+22.22%)` | :arrow_up: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <85%> (+4.35%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.47% <94.87%> (+0.42%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.31% <96.29%> (+0.65%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.08% <98.14%> (+0.7%)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | ... and [361 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=footer). Last update [6aa10dc...921f960](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail:
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=h1) Report > Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr=desc) will **decrease** coverage by `7.36%`. > The diff coverage is `93.13%`. [](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) ```diff @@Coverage Diff @@ ## master#8138 +/- ## == - Coverage 73.71% 66.35% -7.37% == Files 115 479 +364 Lines 1205923050 +10991 Branches0 2527+2527 == + Hits 888915294+6405 - Misses 3170 7622+4452 - Partials0 134 +134 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <80%> (+22.22%)` | :arrow_up: | | [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <85%> (+4.35%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.47% <94.87%> (+0.42%)` | :arrow_up: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.31% <96.29%> (+0.65%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.08% <98.14%> (+0.7%)` | :arrow_up: | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | | | [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | | | [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | | | [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | `94.59% <0%> (ø)` | | | ... and [361 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=footer). Last update [6aa10dc...921f960](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail:
[GitHub] [incubator-superset] mistercrunch commented on issue #7611: [sqllab] Cancel database query on stop
mistercrunch commented on issue #7611: [sqllab] Cancel database query on stop URL: https://github.com/apache/incubator-superset/pull/7611#issuecomment-526408890 It'd be great to enable the true killing of queries, sorry I missed this back in May... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL
Lab state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#discussion_r319344408
##
File path: superset/assets/spec/javascripts/sqllab/reducers/sqlLab_spec.js
##
@@ -19,96 +19,119 @@
import sqlLabReducer from '../../../../src/SqlLab/reducers/sqlLab';
import * as actions from '../../../../src/SqlLab/actions/sqlLab';
import { table, initialState as mockState } from '../fixtures';
+import { now } from '../../../../src/modules/dates';
const initialState = mockState.sqlLab;
describe('sqlLabReducer', () => {
- describe('CLONE_QUERY_TO_NEW_TAB', () => {
-const testQuery = { sql: 'SELECT * FROM...', dbId: 1, id: 'flasj233' };
-let newState = {
- ...initialState,
- queries: { [testQuery.id]: testQuery },
-};
-beforeEach(() => {
- newState = sqlLabReducer(newState,
actions.cloneQueryToNewTab(testQuery));
-});
-
-it('should have at most one more tab', () => {
- expect(newState.queryEditors).toHaveLength(2);
-});
-
-it('should have the same SQL as the cloned query', () => {
- expect(newState.queryEditors[1].sql).toBe(testQuery.sql);
-});
-
-it('should prefix the new tab title with "Copy of"', () => {
- expect(newState.queryEditors[1].title).toContain('Copy of');
-});
-
-it('should push the cloned tab onto tab history stack', () => {
- expect(newState.tabHistory[1]).toBe(newState.queryEditors[1].id);
-});
- });
describe('Query editors actions', () => {
let newState;
let defaultQueryEditor;
let qe;
beforeEach(() => {
newState = { ...initialState };
defaultQueryEditor = newState.queryEditors[0];
- qe = Object.assign({}, defaultQueryEditor);
- newState = sqlLabReducer(newState, actions.addQueryEditor(qe));
- qe = newState.queryEditors[newState.queryEditors.length - 1];
+ const action = {
Review comment:
I changed a lot (all?) of the unit tests to be proper unit tests, removing
the call to `actions`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8130: removes unused state values and redundant presence checks
mistercrunch merged pull request #8130: removes unused state values and redundant presence checks URL: https://github.com/apache/incubator-superset/pull/8130 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL
Lab state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#discussion_r319344271
##
File path: superset/assets/spec/javascripts/sqllab/TabbedSqlEditors_spec.jsx
##
@@ -39,7 +39,7 @@ describe('TabbedSqlEditors', () => {
'newEditorId',
];
- const tables = [Object.assign({}, table[0], {
Review comment:
This was a bug, `table[0]` is undefined.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL
Lab state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#discussion_r319344326
##
File path: superset/assets/spec/javascripts/sqllab/reducers/sqlLab_spec.js
##
@@ -19,96 +19,119 @@
import sqlLabReducer from '../../../../src/SqlLab/reducers/sqlLab';
import * as actions from '../../../../src/SqlLab/actions/sqlLab';
import { table, initialState as mockState } from '../fixtures';
+import { now } from '../../../../src/modules/dates';
const initialState = mockState.sqlLab;
describe('sqlLabReducer', () => {
- describe('CLONE_QUERY_TO_NEW_TAB', () => {
Review comment:
This action was removed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL
Lab state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#discussion_r319344608
##
File path:
superset/migrations/versions/02f260780a2b_add_tables_for_sql_lab_state.py
##
@@ -0,0 +1,87 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""Add tables for SQL Lab state
+
+Revision ID: 02f260780a2b
+Revises: def97f26fdfb
+Create Date: 2019-08-12 14:50:49.204635
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "02f260780a2b"
+down_revision = "def97f26fdfb"
+
+from alembic import op
+import sqlalchemy as sa
+from sqlalchemy.dialects import mysql
+
+
+def upgrade():
+# ### commands auto generated by Alembic - please adjust! ###
+op.create_table(
+"tab_state",
+sa.Column("created_on", sa.DateTime(), nullable=True),
+sa.Column("changed_on", sa.DateTime(), nullable=True),
+sa.Column("extra_json", sa.Text(), nullable=True),
+sa.Column("id", sa.Integer(), nullable=False),
+sa.Column("user_id", sa.Integer(), nullable=True),
+sa.Column("label", sa.String(length=256), nullable=True),
+sa.Column("active", sa.Boolean(), nullable=True),
+sa.Column("database_id", sa.Integer(), nullable=True),
+sa.Column("schema", sa.String(length=256), nullable=True),
+sa.Column("query_id", sa.Integer(), nullable=True),
+sa.Column("query_limit", sa.Integer(), nullable=True),
+sa.Column("autorun", sa.Boolean(), nullable=True),
+sa.Column("template_params", sa.Text(), nullable=True),
+sa.Column("created_by_fk", sa.Integer(), nullable=True),
+sa.Column("changed_by_fk", sa.Integer(), nullable=True),
+sa.ForeignKeyConstraint(["changed_by_fk"], ["ab_user.id"]),
+sa.ForeignKeyConstraint(["created_by_fk"], ["ab_user.id"]),
+sa.ForeignKeyConstraint(["database_id"], ["dbs.id"]),
+sa.ForeignKeyConstraint(["query_id"], ["query.id"]),
+sa.ForeignKeyConstraint(["user_id"], ["ab_user.id"]),
+sa.PrimaryKeyConstraint("id"),
+)
+op.create_table(
+"table_schema",
+sa.Column("created_on", sa.DateTime(), nullable=True),
+sa.Column("changed_on", sa.DateTime(), nullable=True),
+sa.Column("extra_json", sa.Text(), nullable=True),
+sa.Column("id", sa.Integer(), nullable=False),
+sa.Column("tab_state_id", sa.Integer(), nullable=True),
+sa.Column("database_id", sa.Integer(), nullable=False),
+sa.Column("schema", sa.String(length=256), nullable=True),
+sa.Column("table", sa.String(length=256), nullable=True),
+sa.Column("description", sa.Text(), nullable=True),
Review comment:
@etr2460 I renamed `results` to `description`, since `metadata` is reserved
in SQLAlchemy.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] squalou commented on issue #7406: Pivot table null values in columns
squalou commented on issue #7406: Pivot table null values in columns URL: https://github.com/apache/incubator-superset/issues/7406#issuecomment-526441881 @ngritsuk : since #8040 , apparently the `dropna = False` option disappears enirely from viz.py You may want to check with master's HEAD after August 16, and see what happens. I'm also interested if these NaN "issues" in pivot table, so your feedback would be welcome This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #8136: Add duration formatter for numeric data
mistercrunch merged pull request #8136: Add duration formatter for numeric data URL: https://github.com/apache/incubator-superset/pull/8136 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #8139: [sqllab] add retries for stop_query
villebro commented on issue #8139: [sqllab] add retries for stop_query URL: https://github.com/apache/incubator-superset/pull/8139#issuecomment-526458368 @smacker is this related to #7611 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] tanmaykul commented on issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component
tanmaykul commented on issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component URL: https://github.com/apache/incubator-superset/issues/8091#issuecomment-526464279 This is done. Closing this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] tanmaykul closed issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component
tanmaykul closed issue #8091: I want to open a modal on click of slice of pie chart and render a dyanmic chart component URL: https://github.com/apache/incubator-superset/issues/8091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] squalou commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
squalou commented on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-526042035 Damn ! indeed. Must have forgotten it. (spent so long restarting different versions, obviously forgot it). Thank you ! Additionally : would it be safe to run 'superset init' at each startup of any occurrence of running container ? (lke, by putting it in entrypoint or something ?) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] squalou edited a comment on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
squalou edited a comment on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-526042035 Damn ! indeed. Must have forgotten it. (spent so long restarting different versions, obviously forgot it). Thank you ! it fixed the issue. Additionally : would it be safe to run 'superset init' at each startup of any occurrence of running container ? (lke, by putting it in entrypoint or something ?) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
[GitHub] [incubator-superset] squalou edited a comment on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard
squalou edited a comment on issue #8121: Error 401 : There was an issue fetching the favorite status of this dashboard URL: https://github.com/apache/incubator-superset/issues/8121#issuecomment-526042035 Damn ! indeed. Must have forgotten it. (spent so long restarting different versions, obviously forgot it). Thank you ! it fixed the issue. Additionally : would it be safe to run 'superset init' at each startup of any occurrence of running container ? (lke, by putting it in entrypoint or something ?) (I mean : I have several superset instances running, pointing on a single superset-database, and no idea what the 'superset init' does so ... I prefer ask) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
