[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321495974 ## File path: superset/connectors/druid/models.py ## @@ -146,53

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321472045 ## File path: superset/common/query_object.py ## @@ -72,15 +89,15 @@

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r321469672 ## File path: superset/common/query_context.py ## @@ -148,10 +153,10

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r320423101 ## File path: superset/connectors/druid/models.py ## @@ -146,53

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r320393779 ## File path: superset/connectors/druid/models.py ## @@ -146,53

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r320398039 ## File path: superset/connectors/base/models.py ## @@ -60,8 +60,8

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r320393779 ## File path: superset/connectors/druid/models.py ## @@ -146,53

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319224456 ## File path: superset/common/query_context.py ## @@ -150,8 +155,8

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319210270 ## File path: superset/common/query_object.py ## @@ -34,12 +35,28 @@

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319208187 ## File path: superset/common/query_context.py ## @@ -109,17 +114,17

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common

serenajiang commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r319206814 ## File path: superset/common/query_context.py ## @@ -40,8 +42,13 @@