worth it to copy
in/replace all Beta code in 1.8.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about
asfgit closed pull request #253: ACCUMULO-4086 Improve volume chooser fallback
URL: https://github.com/apache/accumulo/pull/253
This is an automated message from the Apache Git Service.
To respond to the message, please log
in Master.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Wi
is somehow written.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
g a small
range of key+val size that would only be caught later when encoding the block.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
-
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
. Also, Key.toString() truncates anything that is too long so we could
leverage that possibly include the key.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use th
ceeds " +
Integer.MAX_VALUE + " bytes.");
Review comment:
Would be nice to include the size. Also why not have the sanityCheck method
throw the exception?
This is an automated message from the Apache Git Service.
To respond to the
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
h would simplify these IllegalArgumentException checks and
throws.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this
:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
.MAX_VALUE) {
Review comment:
Same comment about casts.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For que
t time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apac
ngs.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With rega
we get this into
master, or you can base your changes on the 1.7 branch, and we can merge
forward onto 1.8 and master branches after merging it into 1.7. It's up to you.
This is an automated message from the Apache Git Service
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
key.getSize() +" " + (long) value.getSize())
```
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
up in the API if in Key.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
up in the API if in Key.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
int, but if implementation starts returning
some larger value (for whatever reason), we don't want to let that through
either.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
p" warning from initialize
Updated console message in the getRootPassword method to remove unnecessary
warning about the users security setup.
This is an automated message from the Apache Git Service.
To respond to the message,
ary, then a comment explaining that (eg. "arbitrary size in
the range of ... ") would be helpful.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
UR
Review comment:
I think this was intended to be placed in the main properties section, not
the one inside this profile. A simple mistake. :)
This is an automated message from the Apache Git Service.
To respond to the message
Review comment:
I think this was intended to be placed in the mail properties section, not
the one inside this profile. A simple mistake. :)
This is an automated message from the Apache Git Service.
To respond to the message
we're already checking that the
INSTANCE_ZK_TIMEOUT value is within an allowable range.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the sp
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
/
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
com.google.common.util.concurrent.RateLimiter, which is
annotated with @Beta At GuavaRateLimiter.java
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
com.google.common.util.concurrent.RateLimiter, which is
annotated with Beta At GuavaRateLimiter.java
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
com.google.common.io.Files
com.google.common.hash.HashCode;
com.google.common.hash.HashFunction;
com.google.common.hash.Hashing;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
s possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
utomated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
mikewalch closed pull request #25: Simplified documentation
URL: https://github.com/apache/accumulo-website/pull/25
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
ERHEAD`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure
nice to mention what the overhead is... its worst case serialization
overhead
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
milleruntime closed pull request #5: ACCUMULO-4717 Add checkstyle plugin to
check API
URL: https://github.com/apache/accumulo-testing/pull/5
This is an automated message from the Apache Git Service.
To respond
+// errors when allocating arrays - described in stackoverflow post:
https://stackoverflow.com/a/8381338
Review comment:
I like this comment.
This is an automated message from the Apache Git Service.
To respond to the message
value instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
ent:
Personally, I would make this a static constants because all caps usually
implies that by convention.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL ab
that in the case where the
key+value exceeds 2G but compresses to less than 2G that it may be ok. I need
to do more investigation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
mikewalch closed pull request #6: ACCUMULO-4516: TeraSortIngest splits argument
is ignored if less that 10
URL: https://github.com/apache/accumulo-examples/pull/6
This is an automated message from the Apache Git Service
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache
`pages/people.md`
[1]: http://accumulo.apache.org/people/
[2]: https://github.com/apache/accumulo-website
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
IN_VALUE) {
+if (range.getEndKey() != null) {
Key seekKey = new Key(seekRange.getEndKey());
Review comment:
will fix
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
it.init(null, is.getOptions(), null);
+
+Key startKey = new Key();
+Key endKey = new Key(row, colf, colq, cv, Long.MIN_VALUE);
+Range testRange = new Range(startKey, false, endKey, true);
Review comment:
will fix
---
keith-turner closed pull request #302: ACCUMULO-2968: Axe
TabletServer.majorCompactorDisabled
URL: https://github.com/apache/accumulo/pull/302
This is an automated message from the Apache Git Service.
To respond
111L);
+it.next();
+assertFalse(it.hasTop());
+ }
+
+ public class IteratorToSortedKeyValueIterator implements
SortedKeyValueIterator<Key,Value> {
Review comment:
I think I can rework this to use a deleted flag rather than the internal
class for testing. The important part was that
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AeHFYWkEVFD5CfiwwJ8NE_13k1H7to3Hks5so46igaJpZM4PrDna>
> .
>
----
This is an automated message from the Apache Git Service.
To respond to the message, ple
ing issues to work on let me know.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
use shorter subject lines in git log messages.
Can provide as much detail as needed in the commit log body, but the subject
should be short, or it messes up the readability of tons of git tooling. Here's
one (of many) guide which could be used:
https://chris.beams.io/posts/git-commit
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
use shorter subject lines in git log messages.
Can provide as much detail as needed in the commit log body, but the subject
should be short, or it messes up the readability of tons of git tooling. Here's
one (of many) guide which could be used:
https://chris.beams.io/posts/git-commit
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AeHFYUQTQ3iMtEQjNJj6DG2WPqtwQyUfks5so8PygaJpZM4PrDna>
> .
>
--------
This is an automated message from the Apache Git Service.
To respond to the m
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
are interested I just opened
[ACCUMULO-4716](https://issues.apache.org/jira/browse/ACCUMULO-4716). Its
something I ran into recently.
This is an automated message from the Apache Git Service.
To respond to the message, please log
was surprised the test with uncompressible data worked. I suspect it
created a compressed block larger than 2G which I was thinking would fail.
Need to dig and understand why it worked.
This is an automated message from the Apache Git
this comment can be omitted
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
eference to !isMajorCompactionDisabled
in return
Review comment:
I think this comment can be omitted
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL abo
: Removed if condition that always returned
false.
Review comment:
I think this comment can be omitted
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
log messages when we merge, if we want. I
wouldn't worry about it for this one, unless you really want to, in which case
a quick `git commit --amend` and force push to your branch would do it.
This is an automated message from
ed
here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Ap
,
personally I would combine the code somehow. Could have a function that each
test calls or a single test with a loop like :
```java
for(boolean endKeyInclusive : new boolean[]{false,true}){
//all test code here
}
---
hub.com/apache/accumulo/blob/rel/1.8.1/core/src/main/java/org/apache/accumulo/core/iterators/SortedMapIterator.java)?
It actually does something for seek, which seems like it would be better for
the test?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
section of the replication table.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
e use of the
java.util.Objects.equals method. Updated the test class to verify
several variations of the equals method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
OutofMemory error as described in StackOverflow post
https://stackoverflow.com/a/8381338
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
milleruntime closed pull request #27: Add FineAndDandy as contributor
URL: https://github.com/apache/accumulo-website/pull/27
This is an automated message from the Apache Git Service.
To respond to the message, please log
keith-turner closed pull request #307: ACCUMULO-4170 Clarify
ClientConfiguration javadocs
URL: https://github.com/apache/accumulo/pull/307
This is an automated message from the Apache Git Service.
To respond to the message
keith-turner closed pull request #306: ACCUMULO-4170 Clarify
ClientConfiguration javadocs
URL: https://github.com/apache/accumulo/pull/306
This is an automated message from the Apache Git Service.
To respond to the message
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
keith-turner closed pull request #308: ACCUMULO-4170 Clarify
ClientConfiguration javadocs
URL: https://github.com/apache/accumulo/pull/308
This is an automated message from the Apache Git Service.
To respond to the message
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
with the quick test I ran using: accumulo-testing
rw-yarn 1 Bulk.xml
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
mikewalch closed pull request #22: Adding draft release notes for 2.0.0
URL: https://github.com/apache/accumulo-website/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
irect,
rather than doing the substitution for `/1.8`. Perhaps @mikewalch can take a
look, as I think he's a bit more familiar with the redirection plugins.
This is an automated message from the Apache Git Service.
To respond to the me
,
rather than doing the substitution for `/1.8`. Perhaps @mikewalch can take a
look, as I think he's a bit more familiar with the redirection plugins.
This is an automated message from the Apache Git Service.
To respond to the message
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
it. Sorry.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
nk that I should write one myself for a
few weeks until I forget about it :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific commen
e fact that the majority of my interactions here are boiling down to
arguments over things other than code make me think I need to more aggressively
step away.
This is an automated message from the Apache Git Service.
To resp
for the trouble.
Please move on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastruct
for
the trouble. Please move on.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
h replication to take a look at it.
The only thing I was going to do further was to open up a JIRA ticket for
follow on work of creating a test if you thought it was needed.
This is an automated message from the Apache Git Servic
problem, but something to look for.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
mikewalch opened a new pull request #296: ACCUMULO-4700 Set log4j appender
threshold to ALL
URL: https://github.com/apache/accumulo/pull/296
This is an automated message from the Apache Git Service.
To respond
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
asfgit closed pull request #294: Accumulo 3652 sl4j refactoring
URL: https://github.com/apache/accumulo/pull/294
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
by setting it to ALL vs just removing it completely?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about
curious. Doesn't matter to me
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
confirming this but I think the default is ALL so it
could be removed. I left it to make it easy for users to change but I am OK
with it being removed.
This is an automated message from the Apache Git Service.
To respond
mit as-is.
:\
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
est. If you can describe the test, I will
create a follow on ticket.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comm
1 - 100 of 3299 matches
Mail list logo
