[GitHub] [geode] dschneider-pivotal merged pull request #5237: GEODE-8268: clean up ExecutionHandlerContext

dschneider-pivotal merged pull request #5237: URL: https://github.com/apache/geode/pull/5237 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] mivanac merged pull request #5182: GEODE-7591: Fix for hang in ClusterDistributionManager

mivanac merged pull request #5182: URL: https://github.com/apache/geode/pull/5182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] albertogpz commented on a change in pull request #5257: GEODE-8251: make sure Configuration can be deserialized post 1.12.

albertogpz commented on a change in pull request #5257: URL: https://github.com/apache/geode/pull/5257#discussion_r441382563 ## File path: geode-core/src/upgradeTest/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeWithGfshDUnitTest.java ## @@ -0,0 +1,160 @@

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5262: GEODE-8269: Improve test coverage

jdeppe-pivotal commented on a change in pull request #5262: URL: https://github.com/apache/geode/pull/5262#discussion_r441579410 ## File path: geode-redis/src/test/java/org/apache/geode/redis/internal/executor/key/ExpireAtExecutorJUnitTest.java ## @@ -34,30 +37,30 @@

[GitHub] [geode] mhansonp commented on a change in pull request #5249: Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441706637 ## File path: geode-management/src/main/java/org/apache/geode/management/operation/RestoreRedundancyRequest.java ## @@ -0,0 +1,123 @@ +/* + * Licensed to

[GitHub] [geode] mhansonp commented on a change in pull request #5249: Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441733613 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/operation/RestoreRedundancyPerformer.java ## @@ -0,0 +1,179 @@ +/* + *

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

alb3rtobr commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441715962 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool PdxType::operator<(const

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

pdxcodemonkey commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441751119 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool

[GitHub] [geode] DonalEvans commented on a change in pull request #5249: Refactor Restore Redundancy Command

DonalEvans commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441782824 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/operation/RestoreRedundancyPerformer.java ## @@ -0,0 +1,179 @@ +/* + *

[GitHub] [geode] bschuchardt opened a new pull request #5265: work in progress

bschuchardt opened a new pull request #5265: URL: https://github.com/apache/geode/pull/5265 Use of SSLEngine with NIO has proven to be less robust than using "old-io" SSLSockets. This draft PR reintroduces SSLSockets into cluster communications for performance and functional testing.

[GitHub] [geode] albertogpz commented on pull request #5257: GEODE-8251: make sure Configuration can be deserialized post 1.12.

albertogpz commented on pull request #5257: URL: https://github.com/apache/geode/pull/5257#issuecomment-645524694 > > > > What's the point for these changes? > > > > I have ran the test case without them and it passes. > > > > Also, I have searched in the Geode code for the use of

[GitHub] [geode] aaronlindsey commented on pull request #5236: GEODE-8241: Locator observes locator-wait-time

aaronlindsey commented on pull request #5236: URL: https://github.com/apache/geode/pull/5236#issuecomment-645549135 @Bill what do you think of mocking out calls to `System.currentTimeMillis()` in `GMSJoinLeave`? Allowing the test to control the clock might allow a more deterministic test.

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

pdxcodemonkey commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441749254 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool

[GitHub] [geode] dschneider-pivotal merged pull request #5263: GEODE-8270: Reorganize Redis API for Geode test packages to match main package structure

dschneider-pivotal merged pull request #5263: URL: https://github.com/apache/geode/pull/5263 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] pivotal-jbarrett opened a new pull request #5266: GEODE-8274: Improve readability of Version comparison.

pivotal-jbarrett opened a new pull request #5266: URL: https://github.com/apache/geode/pull/5266 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] jinmeiliao commented on a change in pull request #5257: GEODE-8251: make sure Configuration can be deserialized post 1.12.

jinmeiliao commented on a change in pull request #5257: URL: https://github.com/apache/geode/pull/5257#discussion_r441586414 ## File path: geode-core/src/upgradeTest/java/org/apache/geode/internal/cache/rollingupgrade/RollingUpgradeWithGfshDUnitTest.java ## @@ -0,0 +1,160 @@

[GitHub] [geode] sabbeyPivotal opened a new pull request #5263: GEODE-8270: Reorganize Redis API for Geode test packages to match main package structure

sabbeyPivotal opened a new pull request #5263: URL: https://github.com/apache/geode/pull/5263 Reorganize test packages to match main package structure so it's easier to find relevant tests This is an automated message from

[GitHub] [geode] sabbeyPivotal opened a new pull request #5262: GEODE-8269: Improve test coverage

sabbeyPivotal opened a new pull request #5262: URL: https://github.com/apache/geode/pull/5262 Analyzed test coverage via Intellij and by looking through all tests. There were some test cases missing. We either added them or created additional stories in Tracker.

[GitHub] [geode] jinmeiliao commented on pull request #5257: GEODE-8251: make sure Configuration can be deserialized post 1.12.

jinmeiliao commented on pull request #5257: URL: https://github.com/apache/geode/pull/5257#issuecomment-645408502 > What's the point for these changes? > I have ran the test case without them and it passes. > Also, I have searched in the Geode code for the use of this file and have

[GitHub] [geode-native] pdxcodemonkey merged pull request #620: GEODE-8262: Replace insensitive terms in dunit framework

pdxcodemonkey merged pull request #620: URL: https://github.com/apache/geode-native/pull/620 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] albertogpz commented on pull request #5257: GEODE-8251: make sure Configuration can be deserialized post 1.12.

albertogpz commented on pull request #5257: URL: https://github.com/apache/geode/pull/5257#issuecomment-645426599 > > What's the point for these changes? > > I have ran the test case without them and it passes. > > Also, I have searched in the Geode code for the use of this file and

[GitHub] [geode] jinmeiliao commented on pull request #5257: GEODE-8251: make sure Configuration can be deserialized post 1.12.

jinmeiliao commented on pull request #5257: URL: https://github.com/apache/geode/pull/5257#issuecomment-645455002 > > > What's the point for these changes? > > > I have ran the test case without them and it passes. > > > Also, I have searched in the Geode code for the use of this file

[GitHub] [geode] yozaner1324 opened a new pull request #5264: GEODE-8271 - Update Spring artifacts to latest patch versions.

yozaner1324 opened a new pull request #5264: URL: https://github.com/apache/geode/pull/5264 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] bschuchardt commented on a change in pull request #5253: GEODE-8259: DSFIDSerializerImpl should handle RTE the same as Exception

bschuchardt commented on a change in pull request #5253: URL: https://github.com/apache/geode/pull/5253#discussion_r441676962 ## File path: geode-core/src/main/java/org/apache/geode/cache/client/internal/OpExecutorImpl.java ## @@ -556,8 +556,8 @@ protected void

[GitHub] [geode] jinmeiliao commented on pull request #5257: GEODE-8251: make sure Configuration can be deserialized post 1.12.

jinmeiliao commented on pull request #5257: URL: https://github.com/apache/geode/pull/5257#issuecomment-645409764 @albertogpz the pipeline tests failed because we added GEODE_HOME environment variable in all tests environment, some tests are able to find the war files thus starting the

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5262: GEODE-8269: Improve test coverage

sabbeyPivotal commented on a change in pull request #5262: URL: https://github.com/apache/geode/pull/5262#discussion_r441615964 ## File path: geode-redis/src/test/java/org/apache/geode/redis/internal/executor/key/ExpireAtExecutorJUnitTest.java ## @@ -34,30 +37,30 @@

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5262: GEODE-8269: Improve test coverage

sabbeyPivotal commented on a change in pull request #5262: URL: https://github.com/apache/geode/pull/5262#discussion_r441615674 ## File path: geode-redis/src/test/java/org/apache/geode/redis/internal/executor/key/ExpireAtExecutorJUnitTest.java ## @@ -34,30 +37,30 @@

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

pivotal-jbarrett commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441805042 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool

[GitHub] [geode] DonalEvans commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

DonalEvans commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441860267 ## File path: geode-core/src/test/java/org/apache/geode/management/internal/functions/RestoreRedundancyFunctionTest.java ## @@ -0,0 +1,163 @@ +/* + *

[GitHub] [geode] davebarnes97 commented on pull request #5139: GEODE-8149: New parameter and property introduced

davebarnes97 commented on pull request #5139: URL: https://github.com/apache/geode/pull/5139#issuecomment-645594536 > OK, I will create sub-ticket to handle User Guide docs. I'm not finding the sub-ticket for docs. Please provide the ticket number - thanks.

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

pivotal-jbarrett commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441799345 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

alb3rtobr commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441801421 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool PdxType::operator<(const

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

pivotal-jbarrett commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441813608 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool

[GitHub] [geode] aaronlindsey commented on a change in pull request #5236: GEODE-8241: Locator observes locator-wait-time

aaronlindsey commented on a change in pull request #5236: URL: https://github.com/apache/geode/pull/5236#discussion_r441823755 ## File path: geode-membership/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/MembershipIntegrationTest.java ## @@

[GitHub] [geode] aaronlindsey commented on a change in pull request #5236: GEODE-8241: Locator observes locator-wait-time

aaronlindsey commented on a change in pull request #5236: URL: https://github.com/apache/geode/pull/5236#discussion_r441823437 ## File path: geode-membership/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/MembershipIntegrationTest.java ## @@

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

alb3rtobr commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441823764 ## File path: cppcache/src/PdxTypeRegistry.hpp ## @@ -53,7 +53,20 @@ typedef std::unordered_map, dereference_hash>,

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5271: Add Mass Test Run pipeline.

rhoughton-pivot commented on a change in pull request #5271: URL: https://github.com/apache/geode/pull/5271#discussion_r441861412 ## File path: ci/pipelines/meta/deploy_meta.sh ## @@ -256,6 +256,7 @@ set +x if [[ "${GEODE_FORK}" != "${UPSTREAM_FORK}" ]]; then echo

[GitHub] [geode] mhansonp edited a comment on pull request #5271: Add Mass Test Run pipeline.

mhansonp edited a comment on pull request #5271: URL: https://github.com/apache/geode/pull/5271#issuecomment-645653390 Shall I merge it? It seems like it didn't change much.. This is an automated message from the Apache Git

[GitHub] [geode] kirklund opened a new pull request #5267: GEODE-8273: Cleanup GfshExecution and GfshScript

kirklund opened a new pull request #5267: URL: https://github.com/apache/geode/pull/5267 * Use GeodeAwaitility timeout instead of hardcoded timeouts. * Use just one source for Charset. * Minor formatting changes.

[GitHub] [geode] kirklund opened a new pull request #5268: GEODE-8250: Create new custom log config acceptance tests

kirklund opened a new pull request #5268: URL: https://github.com/apache/geode/pull/5268 New tests to discover and verify that use of custom log configs works when using GFSH to start Locator and Server. This is an

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

alb3rtobr commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441808727 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool PdxType::operator<(const

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

alb3rtobr commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441807945 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool PdxType::operator<(const

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #611: GEODE-8213: lock-free SerializationRegistry

pivotal-jbarrett commented on pull request #611: URL: https://github.com/apache/geode-native/pull/611#issuecomment-645604306 I think we should close this PR and revisit if after the fixes in https://github.com/apache/geode-native/pull/619 to be merged. After that I think It might just be

[GitHub] [geode] aaronlindsey commented on pull request #5236: GEODE-8241: Locator observes locator-wait-time

aaronlindsey commented on pull request #5236: URL: https://github.com/apache/geode/pull/5236#issuecomment-645616125 I've been running this test in the background while I work and so far it has passed 300x in a row without failing. I will continue letting it run until it reaches 1000

[GitHub] [geode] mivanac opened a new pull request #5270: GEODE-6150: added test

mivanac opened a new pull request #5270: URL: https://github.com/apache/geode/pull/5270 WIP: Do not review Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [geode] lgtm-com[bot] commented on pull request #5270: GEODE-6150: added test

lgtm-com[bot] commented on pull request #5270: URL: https://github.com/apache/geode/pull/5270#issuecomment-645638238 This pull request **introduces 8 alerts** and **fixes 2** when merging 5ee88eb8a6ae6cf2113bfefd8d9d6f17dd6e3df9 into d1e857de0d32742f65768e246c49db88ba90cc47 - [view on

[GitHub] [geode] mhansonp commented on a change in pull request #5271: Add Mass Test Run pipeline.

mhansonp commented on a change in pull request #5271: URL: https://github.com/apache/geode/pull/5271#discussion_r441853889 ## File path: ci/bin/concourse_job_performance.py ## @@ -58,7 +60,7 @@ def main(url, team, pipeline, job, number_of_builds, authorization_cookie, threa

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5271: Add Mass Test Run pipeline.

onichols-pivotal commented on a change in pull request #5271: URL: https://github.com/apache/geode/pull/5271#discussion_r441869161 ## File path: ci/pipelines/shared/jinja.variables.yml ## @@ -67,6 +67,7 @@ java_test_versions: metadata: initial_version:

[GitHub] [geode] mhansonp commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441869114 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/functions/RestoreRedundancyFunction.java ## @@ -0,0 +1,105 @@ +/* + *

[GitHub] [geode] mhansonp commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441868918 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/operation/RestoreRedundancyPerformer.java ## @@ -0,0 +1,179 @@ +/* + *

[GitHub] [geode] mhansonp commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441875211 ## File path: geode-management/src/main/java/org/apache/geode/management/internal/operation/RegionRedundancyStatusImpl.java ## @@ -0,0 +1,103 @@ +/* + *

[GitHub] [geode] mhansonp commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441874934 ## File path: geode-management/src/main/java/org/apache/geode/management/internal/operation/RegionRedundancyStatusImpl.java ## @@ -0,0 +1,103 @@ +/* + *

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

alb3rtobr commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441807945 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool PdxType::operator<(const

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

alb3rtobr commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441807945 ## File path: cppcache/src/PdxType.cpp ## @@ -557,11 +557,30 @@ bool PdxType::Equals(std::shared_ptr otherObj) { } bool PdxType::operator<(const

[GitHub] [geode] Bill opened a new pull request #5269: new failing unit test for unknown version

Bill opened a new pull request #5269: URL: https://github.com/apache/geode/pull/5269 [GEODE-8240](https://issues.apache.org/jira/browse/GEODE-8240) Just getting started here. **Not ready for review yet** ### For all changes: - [x] Is there a JIRA ticket associated with this

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

pdxcodemonkey commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441812743 ## File path: cppcache/src/PdxTypeRegistry.hpp ## @@ -53,7 +53,20 @@ typedef std::unordered_map, dereference_hash>,

[GitHub] [geode-native] pdxcodemonkey merged pull request #618: GEODE-8246: Enforce No Shadow as error

pdxcodemonkey merged pull request #618: URL: https://github.com/apache/geode-native/pull/618 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] rhoughton-pivot opened a new pull request #5271: Add Mass Test Run pipeline.

rhoughton-pivot opened a new pull request #5271: URL: https://github.com/apache/geode/pull/5271 This commit includes: * Creating a new test run pipeline that runs the distributed test multiple number of times. * Update the meta pipeline to add mass test run pipeline. * Logs

[GitHub] [geode] DonalEvans commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

DonalEvans commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441873906 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/operation/RestoreRedundancyPerformer.java ## @@ -112,14 +114,14 @@ public

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #619: GEODE-8212: Reduce connections to server to get type id

alb3rtobr commented on a change in pull request #619: URL: https://github.com/apache/geode-native/pull/619#discussion_r441827458 ## File path: cppcache/src/PdxTypeRegistry.hpp ## @@ -53,7 +53,20 @@ typedef std::unordered_map, dereference_hash>,

[GitHub] [geode] mhansonp commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441858350 ## File path: geode-core/src/test/java/org/apache/geode/management/internal/functions/RestoreRedundancyFunctionTest.java ## @@ -0,0 +1,163 @@ +/* + *

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5271: Add Mass Test Run pipeline.

onichols-pivotal commented on a change in pull request #5271: URL: https://github.com/apache/geode/pull/5271#discussion_r441858177 ## File path: ci/pipelines/meta/deploy_meta.sh ## @@ -256,6 +256,7 @@ set +x if [[ "${GEODE_FORK}" != "${UPSTREAM_FORK}" ]]; then echo

[GitHub] [geode] dschneider-pivotal opened a new pull request #5272: GEODE-8276: fix KEYS command to handle non-ASCII keys

dschneider-pivotal opened a new pull request #5272: URL: https://github.com/apache/geode/pull/5272 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] mhansonp commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441871215 ## File path: geode-core/src/test/java/org/apache/geode/management/internal/functions/RestoreRedundancyFunctionTest.java ## @@ -0,0 +1,163 @@ +/* + *

[GitHub] [geode] mhansonp commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441876860 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/operation/RestoreRedundancyPerformer.java ## @@ -112,14 +114,14 @@ public

[GitHub] [geode] mhansonp commented on a change in pull request #5249: GEODE-8272 Refactor Restore Redundancy Command

mhansonp commented on a change in pull request #5249: URL: https://github.com/apache/geode/pull/5249#discussion_r441876791 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/operation/RestoreRedundancyPerformer.java ## @@ -112,14 +114,14 @@ public

[GitHub] [geode] pivotal-jbarrett merged pull request #5266: GEODE-8274: Improve readability of Version comparison.

pivotal-jbarrett merged pull request #5266: URL: https://github.com/apache/geode/pull/5266 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] mhansonp commented on a change in pull request #5271: Add Mass Test Run pipeline.

mhansonp commented on a change in pull request #5271: URL: https://github.com/apache/geode/pull/5271#discussion_r441907733 ## File path: ci/pipelines/shared/jinja.variables.yml ## @@ -67,6 +67,7 @@ java_test_versions: metadata: initial_version:

[GitHub] [geode] dschneider-pivotal commented on pull request #5258: GEODE-8263: KEEPTTL should fail on SET command

dschneider-pivotal commented on pull request #5258: URL: https://github.com/apache/geode/pull/5258#issuecomment-645685812 the dunit failure is a known flaky test This is an automated message from the Apache Git Service. To

[GitHub] [geode] dschneider-pivotal merged pull request #5258: GEODE-8263: KEEPTTL should fail on SET command

dschneider-pivotal merged pull request #5258: URL: https://github.com/apache/geode/pull/5258 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above