danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveToOuter` only resolves classes whose name does not contains `.`
and `resolveFromStaticInnerClasses` only resolves classes whose
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveToOuter` only resolves classes whose name does not contains `.`
and `resolveFromStaticInnerClasses` only resolves classes
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526532434
@blackdrag
Jochen, if you could set aside some time to review the PR too, that would be
great :-)
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveFromStaticInnerClasses` only resolves classes whose name contains
`.` and `resolveToOuter` only resolves classes whose
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveFromStaticInnerClasses` only resolves classes whose name contains
`.` and `resolveToOuter` only resolves classes whose
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526538718
As `resolveFromStaticInnerClasses` only resolves classes whose name contains
`.` and `resolveToOuter` only resolves classes whose
[
https://issues.apache.org/jira/browse/GROOVY-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919661#comment-16919661
]
Mauro Molinari commented on GROOVY-8329:
My 2 cents. I think Groovy will never go "static
Mauro Molinari created GROOVY-9240:
--
Summary: Better signature for ResourceGroovyMethods.traverse(File,
Map, Closure) (and overloadings)
Key: GROOVY-9240
URL: https://issues.apache.org/jira/browse/GROOVY-9240
[
https://issues.apache.org/jira/browse/GROOVY-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Sun closed GROOVY-9241.
--
Resolution: Fixed
> Bump gradle to 5.6.1
>
>
> Key: GROOVY-9241
danielsun1106 opened a new pull request #1000: GROOVY-9242: Bump picocli to
4.0.3
URL: https://github.com/apache/groovy/pull/1000
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919813#comment-16919813
]
Daniel Sun commented on GROOVY-9236:
FYI. The PR tries to fix the issues discussed in the following
[
https://issues.apache.org/jira/browse/GROOVY-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919719#comment-16919719
]
Eric Milles commented on GROOVY-8329:
-
I think two very common use cases for Groovy are 1)
[
https://issues.apache.org/jira/browse/GROOVY-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919740#comment-16919740
]
Eric Milles commented on GROOVY-9237:
-
I have had to patch back the constructor and replace checks
[
https://issues.apache.org/jira/browse/GROOVY-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919778#comment-16919778
]
Andrew Allen commented on GROOVY-9238:
--
There are additional constructors that are expected to be
[
https://issues.apache.org/jira/browse/GROOVY-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919750#comment-16919750
]
Eric Milles commented on GROOVY-9185:
-
{{RetentionPolicy.SOURCE}} is the JVM default. Is the
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919761#comment-16919761
]
Daniel Sun commented on GROOVY-9236:
As you can find, {{resolveFromStaticInnerClasses}} will only
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919766#comment-16919766
]
Eric Milles commented on GROOVY-9236:
-
Is there some measurement of the # of lookups reduced or time
[
https://issues.apache.org/jira/browse/GROOVY-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Milles resolved GROOVY-9089.
-
Fix Version/s: 3.0.0-beta-1
2.5.7
Resolution: Fixed
This was resolved
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Sun updated GROOVY-9236:
---
Description:
{{ResolveVisitor}}'s {{resolveFromStaticInnerClasses}},
{{resolveFromDefaultImports}}
[
https://issues.apache.org/jira/browse/GROOVY-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919704#comment-16919704
]
Daniel Sun commented on GROOVY-8329:
I do not think Groovy should enable STC by default because
[
https://issues.apache.org/jira/browse/GROOVY-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Sun updated GROOVY-9242:
---
Fix Version/s: 3.0.0-beta-4
> Bump picocli to 4.0.3
> -
>
>
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919797#comment-16919797
]
Daniel Sun edited comment on GROOVY-9236 at 8/30/19 6:03 PM:
-
Here is the
[
https://issues.apache.org/jira/browse/GROOVY-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Sun closed GROOVY-9242.
--
Resolution: Fixed
> Bump picocli to 4.0.3
> -
>
> Key:
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919825#comment-16919825
]
Eric Milles commented on GROOVY-9236:
-
Thanks for attaching the discussion. If an issue ticket is
[
https://issues.apache.org/jira/browse/GROOVY-9238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919739#comment-16919739
]
Eric Milles commented on GROOVY-9238:
-
What is the expectation that is missing from the bytecode?
>
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919797#comment-16919797
]
Daniel Sun commented on GROOVY-9236:
Here is the difference of classes to guess:
* After changes:
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919797#comment-16919797
]
Daniel Sun edited comment on GROOVY-9236 at 8/30/19 5:57 PM:
-
Here is the
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919797#comment-16919797
]
Daniel Sun edited comment on GROOVY-9236 at 8/30/19 6:00 PM:
-
Here is the
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919813#comment-16919813
]
Daniel Sun edited comment on GROOVY-9236 at 8/30/19 6:20 PM:
-
FYI. The PR
[
https://issues.apache.org/jira/browse/GROOVY-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919704#comment-16919704
]
Daniel Sun edited comment on GROOVY-8329 at 8/30/19 4:36 PM:
-
I do not think
Daniel Sun created GROOVY-9241:
--
Summary: Bump gradle to 5.6.1
Key: GROOVY-9241
URL: https://issues.apache.org/jira/browse/GROOVY-9241
Project: Groovy
Issue Type: Dependency upgrade
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919761#comment-16919761
]
Daniel Sun edited comment on GROOVY-9236 at 8/30/19 5:36 PM:
-
As you can
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919801#comment-16919801
]
Daniel Sun edited comment on GROOVY-9236 at 8/30/19 6:02 PM:
-
In order to
[
https://issues.apache.org/jira/browse/GROOVY-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919801#comment-16919801
]
Daniel Sun commented on GROOVY-9236:
In order to eliminate our worries, I add a test case to the PR
danielsun1106 merged pull request #1000: GROOVY-9242: Bump picocli to 4.0.3
URL: https://github.com/apache/groovy/pull/1000
This is an automated message from the Apache Git Service.
To respond to the message, please log on
eric-milles opened a new pull request #1001: GROOVY-9240: relax signature of
RGM.traverse(File, Map, ...)
URL: https://github.com/apache/groovy/pull/1001
This is an automated message from the Apache Git Service.
To respond
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526739881
I tried to compile the following code to verify whether the times of
guessing class names are reduced.
```
import
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526739881
I tried to compile the following code to verify whether the times of
guessing class names are reduced.
```groovy
blackdrag commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526744548
your change looks like progress no doubt, but why is there still
"groovy.lang.GroovyObject$groovy$transform$CompileStatic" in there? ideally
danielsun1106 edited a comment on issue #998: GROOVY-9236: Avoid unnecessary
resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526739881
I tried to compile the following code to verify whether the times of
guessing class names are reduced. Then I got the result:
danielsun1106 commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526793412
As we can see, STC is enabled by `@CompileStatic`.
`groovy.lang.GroovyObject$groovy$transform$CompileStatic` is guessed by
blackdrag commented on issue #998: GROOVY-9236: Avoid unnecessary resolving
URL: https://github.com/apache/groovy/pull/998#issuecomment-526738578
could you first show what you compiled with that? And I think we will need
more cases to for review. At the very least I would like to see the
42 matches
Mail list logo
