Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
> Yay! It worked just adding the feature Yayayay! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248728348
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Yay! It worked just adding the feature :) I've squashed the commits and merged to master as [b1152f3d](http://git-wip-us.apache.org/repos/asf/jclouds-karaf/commit/b1152f3d). Thanks for all the help @demobox! BTW, the ServiceMix bundles will be released by the end of this month, so perhaps we are on time to update and remove ours if we have not released 2.0 yet. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248549414
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Closed #84. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#event-796949828
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
@nacx pushed 1 commit. 3371b37 Added missing Azure ARM feature -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84/files/91f25d4305c928801fe980d98aee48fedd6406f6..3371b37b8403a3a61087e35b6477c75c37e3ebc4
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
@nacx: Aha! I think we might be missing an entry [in this section](https://github.com/jclouds/jclouds-karaf/blob/master/feature/pom.xml#L107-L161)... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248528092
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Sure :) I'll add it there and update the PR, and if it still fails I'll add the dependency to the root pom (I don't really know the details of how it works but I bet we'd need both)... And I'll try to cleanup my local env and see if I can make it fail the same way our CI builds fail! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248534770
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Makes sense. I copied how our jclouds oauth lib is configured, as they are the same kind of dependency, and I have not found any differences... Wait! Perhaps oauth works because our google-common is declared in the root pom.xml and it brings oauth as a transitive dependency? I'll try adding the okhttp driver there in a while (I'm in the train now :)) of you don't beat me! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248527257
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
> Will try again... Same failure again for me locally - probably something to do with my setup :-( From the PR build, I notice that the driver bundle doesn't seem to be installed in the features repo, which probably explains the error:  https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/ws/feature/target/features-repo/org/apache/jclouds/driver/ @nacx: I suspect if we can figure out what needs to be changed in the `features` subproject to ensure that bundle gets published should allow the tests to pass... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248458172
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
> Could you try the build locally with all tests
Hrm, am getting a different failure (first time around) locally:
```
Failed tests: testB2Feature:org.jclouds.karaf.itests.MiscFeaturesInstallationT
est.testB2Feature:KarafTestContainer{mvn:org.apache.karaf\/apache-karaf\/2.3.11\
/tar.gz}(org.jclouds.karaf.itests.MiscFeaturesInstallationTest): Expected jcloud
s-b2 feature to be installed.
```
Will try again...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248286996
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
I don't really know. It is not the build itself, but the karaf feature resolver the one that pulls the dependency. I've created a brand new build copied from jclouds-karaf called `jclouds-karaf-with-azure`, but it presents the same failure. Also tried changing the build to not use the local Maven repo, but with no success. Could you try the build locally with all tests, and give a try to the build I created in the Jenkins CI too? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248251639
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
> I'm out of ideas and wondering if it is a transient issue caused by the local > Maven repo in our Jenkins? @nacx Is it pulling these down from Maven, or using locally-published versions? Does deleting the workspace make any difference? The Maven repository settings in Jenkins may also be having an impact here... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248150211
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
@demobox All tests pass locally. Any idea why the PR build is failing to install the feature? The error is the following, but I've double-checked and the feature properly declares the dependency... I'm out of ideas and wondering if it is a transient issue caused by the local Maven repo in our Jenkins? features:install jclouds-azurecompute-arm java.lang.RuntimeException: URL [mvn:org.apache.jclouds.driver/jclouds-okhttp/2.0.0-SNAPSHOT] could not be resolved. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248024513
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Oh, looks like a transient failure. It is building now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248016009
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Reopened #84. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#event-794151123
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Looks liek teh close/reopen trick is no longer working? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248015778
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Closed #84. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#event-794151047
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Reopened #84. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#event-794079269
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Closed #84. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#event-794079225
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
rebuild please -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-248002751
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
> Added the comments and removed the unnecessary commits now that all > dependencies are in place. Great! +1 - looks good to me. Thanks for the cleanup, @nacx! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-247956950
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
Added the comments and removed the unnecessary commits now that all dependencies are in place. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-247944823
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
> I've already opened the issues and corresponding PRs: > apache/servicemix-bundles#85 & apache/servicemix-bundles#86 Ah, great - thanks, Ignasi! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-247842456
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
I've already opened the issues and corresponding PRs: https://github.com/apache/servicemix-bundles/pull/85 & https://github.com/apache/servicemix-bundles/pull/86 I've tried the change with the servicemix bundles and everything keeps working :) There is a version named `bundles-2016.09` so we can expect a new servicemix bundle release this month. Let's see if those PRs enter that release! Meanwhile, good to merge with the custom bundles, and update karaf to remove them once there is a servicemix release that includes them? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-247809619
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
> I wouldn't feel comfortable upgrading OkHttp. It is a great library, but that > kind of client validations, imposing strict restrictions on what they expect > from servers, can be a show stopper for some providers. Fair point - if that's something that we can't easily verify (e.g. via a PR) except by testing the providers live, then that would indeed seem like a bit of a big change given the current goal. "Option 2" (ServiceMix request) sounds like a good plan, in that case! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-247807927
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
I'm a bit hesitant to upgrade OkHttp. Some time ago I wanted to upgrade it to version 3.0.0, but there were several errors due to client validations. Looking at the changelog... it is significant, and there are changes such as this one in 2.4.0: >Forbid response bodies on HTTP 204 and 205 responses. Webservers that return >such malformed responses will now trigger a ProtocolException in the client. That introduces validations that may cause the driver to fail on certain providers (we know how tricky/far-from-the-spec-correctness many provider apis are), and that could be an issue since some of them (Docker, openstack-marconi, azure ARM, use OkHttp by default to leverage some features such as PATCH requests, etc. I wouldn't feel comfortable upgrading OkHttp. It is a great library, but that kind of client validations, imposing strict restrictions on what they expect from servers, can be a show stopper for some providers. > Failing that, we would want to open a ticket with Servicemix for them to > create a new bundle for the version we need, I'd say. Yep. I have it in my TODO list -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-247807072
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
PS: There appears to be a bundle for 2.7.5 (OkHttp) and its dependency, Okio 1.6.0: * http://search.maven.org/#artifactdetails%7Corg.apache.servicemix.bundles%7Corg.apache.servicemix.bundles.okhttp%7C2.7.5_1%7Cbundle * http://search.maven.org/#artifactdetails%7Corg.apache.servicemix.bundles%7Corg.apache.servicemix.bundles.okio%7C1.6.0_1%7Cbundle Have we tried upgrading to these versions to see if that might work? Still the same major version, so hopefully the changes required should be minimal? Haven't checked what the changes are from OkHttp 2.2.0 to 2.7.5, I hasten to add... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-247791079
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
> I'd like to focus on what we really need so we can include this as soon as > possible for the 2.0 release, and once that is done, take time to create > proper bundles for all OkHttp modules and move to servicemix. As a potentially temporary fix, this makes sense to me and looks good, assuming local testing works. In terms of what the best next step would be, I think we'd ideally like to upgrade OkHttp to a newer/the newest option for which a bundle exists - have we tested that? Failing that, we would want to open a ticket with Servicemix for them to create a new bundle for the version we need, I'd say. Thanks for taking this on, @nacx! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#issuecomment-247789834
Re: [jclouds/jclouds-karaf] Added Azure ARM (#84)
demobox commented on this pull request. > @@ -566,7 +566,7 @@ limitations under the License. - + Er...oops :-( Thanks for catching that! Mind changing the commit title to refer to the JIRA issue? Thanks, @nacx! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84#pullrequestreview-460129
[jclouds/jclouds-karaf] Added Azure ARM (#84)
This will allow to use the Azure ARM provider from the jclouds CLI (/cc @ ritazh) This PR depends on https://github.com/jclouds/jclouds-labs/pull/318 and includes the changes in https://github.com/jclouds/jclouds-karaf/pull/83. It should be merged once both PRs are merged (the build will fail until then). I'm submitting it for an early review. The `azurecompute-arm` provider depends on the OkHttp driver, but there are no OSGi bundles for the version of OkHttp we currently support and its transitive dependency, Okio. I've added the corresponding bundles here. There are bundles in servicemix for both libraries, but for newer verions. We should consider submitting a pull request there and replace our custom bundles. However, OkHttp comes with several module we don't use and a proper PR to servicemix should include those modules too. I'd like to focus on what we really need so we can include this as soon as possible for the 2.0 release, and once that is done, take time to create proper bundles for all OkHttp modules and move to servicemix. @demobox WDYT? You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-karaf/pull/84 -- Commit Summary -- * Fix OSGiScriptEngineManager package * JCLOUDS-664: Added Azure ARM to jclouds-karaf -- File Changes -- A bundles/okhttp/pom.xml (87) A bundles/okio/pom.xml (87) M bundles/pom.xml (2) M commands/src/main/resources/OSGI-INF/blueprint/jclouds-commands.xml (2) M feature/src/main/resources/feature.xml (10) M itests/src/test/java/org/jclouds/karaf/itests/MiscFeaturesInstallationTest.java (5) M pom.xml (2) -- Patch Links -- https://github.com/jclouds/jclouds-karaf/pull/84.patch https://github.com/jclouds/jclouds-karaf/pull/84.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-karaf/pull/84
