stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376894906
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,104 @@
+~~ Licensed to the Apache Software
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376884765
##
File path: src/test/cpp/net/socketserverstarter.cpp
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376848071
##
File path: src/test/java/CMakeLists.txt
##
@@ -0,0 +1,18 @@
+include(FetchContent)
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376844778
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,104 @@
+~~ Licensed to the Apache Software
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376843651
##
File path: src/test/cpp/net/socketserverstarter.cpp
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376840482
##
File path: src/test/cpp/net/socketservertestcase.cpp
##
@@ -478,4 +477,4 @@
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376748971
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376211434
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376210024
##
File path: src/site/apt/building/cmake.apt
##
@@ -0,0 +1,75 @@
+~~ Licensed to the Apache Software
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373754317
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373754082
##
File path: pom.xml
##
@@ -65,7 +65,7 @@
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373738203
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
Review comment:
I
stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r373737584
##
File path: CMakeLists.txt
##
@@ -0,0 +1,52 @@
+cmake_minimum_required(VERSION 3.13)
13 matches
Mail list logo