kezhenxu94 merged pull request #4317: Upgrade the bytebuddy to 1.10.7 for J9VM
URL: https://github.com/apache/skywalking/pull/4317
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 2e61761 Upgrade the bytebuddy for J9VM
wu-sheng commented on issue #4318: Reduce footprint via prototype pattern when
tagging spans
URL: https://github.com/apache/skywalking/pull/4318#issuecomment-581964295
I know as a major upgrade, we could remove some, but basically, it is not
necessary. So I want to keep them.
>
wu-sheng commented on issue #4318: Reduce footprint via prototype pattern when
tagging spans
URL: https://github.com/apache/skywalking/pull/4318#issuecomment-581966104
BTW, we should add a new check rule, `don't use Deprecated API`.
kezhenxu94 commented on issue #4318: Reduce footprint via prototype pattern
when tagging spans
URL: https://github.com/apache/skywalking/pull/4318#issuecomment-581961605
> Removing `AbstractSpan#tag(String, String)` is an incompatible change. I
don't know, but assuming many, it is widely
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374739055
##
File path: tools/dependencies/known-oap-backend-dependencies-es7.txt
##
@@ -159,3 +159,8 @@
kezhenxu94 commented on a change in pull request #4311: Provide the new version
upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#discussion_r374521678
##
File path: docs/en/FAQ/v6-version-upgrade.md
##
@@ -0,0 +1,30 @@
+# V6 upgrade
wu-sheng commented on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581792828
FYI @kezhenxu94 The whole profile should work for CLI too. We should add an
issue to track.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 421ba88 Provide the new version upgrade
wu-sheng merged pull request #4311: Provide the new version upgrade
documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng closed issue #4313: Agent Register fail
URL: https://github.com/apache/skywalking/issues/4313
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
codecov-io edited a comment on issue #4311: Provide the new version upgrade
documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#issuecomment-581785570
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr=h1)
Report
> Merging
ywf4026 opened a new issue #4313: Agent Register fail
URL: https://github.com/apache/skywalking/issues/4313
Please answer these questions before submitting your issue.
- Why do you submit this issue?
Question or discussion
___
### Question
- What do you want to
wu-sheng commented on a change in pull request #4311: Provide the new version
upgrade documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#discussion_r374522203
##
File path: docs/en/FAQ/v6-version-upgrade.md
##
@@ -0,0 +1,30 @@
+# V6 upgrade
+SkyWalking
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch upgrade-faq
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from e100194 Provide the new version upgrade documentation/FAQ.
add 68eb14a Make the sentence more
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #4311: Provide the new version upgrade
documentation/FAQ.
URL: https://github.com/apache/skywalking/pull/4311#issuecomment-581785570
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4311?src=pr=h1)
Report
> Merging
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from ef60cb2 mvnw proxy config (#4310)
add 30ebe1c provide thread stack analyzes (#4308)
No new revisions
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch upgrade-faq
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 68eb14a Make the sentence more clear.
add 30ebe1c provide thread stack analyzes (#4308)
add
wu-sheng merged pull request #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kezhenxu94 opened a new issue #4312: [CLI] Command to display thread profiling
result
URL: https://github.com/apache/skywalking/issues/4312
FYI @kezhenxu94 The whole profile should work for CLI too. We should add an
issue to track.
_Originally posted by @wu-sheng in
wu-sheng commented on issue #4313: Agent Register fail
URL: https://github.com/apache/skywalking/issues/4313#issuecomment-581823252
Your ES is not available.
This is an automated message from the Apache Git Service.
To
wu-sheng commented on issue #4314: How to get TraceId in PHP agent
URL: https://github.com/apache/skywalking/issues/4314#issuecomment-581864613
Request on php repo.
This is an automated message from the Apache Git Service.
To
wu-sheng closed issue #4314: How to get TraceId in PHP agent
URL: https://github.com/apache/skywalking/issues/4314
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Lovnx opened a new issue #4315: When will you release version 7.0.0
URL: https://github.com/apache/skywalking/issues/4315
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Lovnx opened a new issue #4314: How to get TraceId in PHP agent
URL: https://github.com/apache/skywalking/issues/4314
eg. Java:
org.apache.skywalking
apm-toolkit-trace
${skywalking.version}
TraceContext.traceId()
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374611296
##
File path:
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374597179
##
File path:
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374612571
##
File path:
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374619657
##
File path:
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374611069
##
File path: test/e2e/e2e-influxdb/src/docker/rc.d/rc0-prepare.sh
##
@@ -0,0 +1,21 @@
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374598967
##
File path: oap-server/server-storage-plugin/storage-influxdb-plugin/pom.xml
##
@@ -0,0 +1,50 @@
+
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374623410
##
File path:
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374601890
##
File path:
kezhenxu94 commented on a change in pull request #4239: Provide influxdb as a
new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374619003
##
File path: oap-server/server-storage-plugin/storage-influxdb-plugin/pom.xml
##
@@ -0,0 +1,50 @@
+
kezhenxu94 commented on issue #4239: Provide influxdb as a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-581870855
The corresponding `yml` in `docker-entrypoint.sh` should be also updated
arugal commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r375088433
##
File path: browser/BrowserPerf.proto
##
@@ -25,36 +25,56 @@ import "common/common.proto";
//
dmsolr commented on issue #4239: Provide influxdb as a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-582234659
> The corresponding `yml` in `docker-entrypoint.sh` should be also updated
Sorry, I don't understand. We need to update which file?
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r375072105
##
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##
@@ -75,29 +75,29 @@
Fine0830 commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r375086868
##
File path: browser/BrowserPerf.proto
##
@@ -25,36 +25,56 @@ import "common/common.proto";
Fine0830 commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r375086868
##
File path: browser/BrowserPerf.proto
##
@@ -25,36 +25,56 @@ import "common/common.proto";
Fine0830 commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r375087438
##
File path: browser/BrowserPerf.proto
##
@@ -25,36 +25,56 @@ import "common/common.proto";
Fine0830 commented on issue #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#issuecomment-582270415
Thanks. LGTM
This is an automated message from the Apache Git
wu-sheng merged pull request #18: Enhancement browser protocol
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/18
This is an automated message from the Apache Git Service.
To respond to the message,
arugal commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r375086744
##
File path: browser/BrowserPerf.proto
##
@@ -25,36 +25,56 @@ import "common/common.proto";
//
Fine0830 commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r375085592
##
File path: browser/BrowserPerf.proto
##
@@ -25,36 +25,56 @@ import "common/common.proto";
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git
The following commit(s) were added to refs/heads/master by this push:
new a2aaec5
AirTrioa opened a new pull request #4320: [BUG]Fix the bug of port
identification failure when connecting Oracle with Sid mode (JDBC: Oracle:
thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320
Please answer these questions before submitting pull
codecov-io commented on issue #4320: [BUG]Fix the bug of port identification
failure when connecting Oracle with Sid mode (JDBC: Oracle: thin: @ < host >: <
port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#issuecomment-582259358
#
EvanLjp opened a new issue #4319: telemetry module
URL: https://github.com/apache/skywalking/issues/4319
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
___
### Question
- What do you want to
wu-sheng closed issue #4319: telemetry module
URL: https://github.com/apache/skywalking/issues/4319
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wu-sheng commented on issue #4319: telemetry module
URL: https://github.com/apache/skywalking/issues/4319#issuecomment-582216755
What is your question?
This is an automated message from the Apache Git Service.
To respond to
kezhenxu94 commented on issue #4318: Reduce footprint via prototype pattern
when tagging spans
URL: https://github.com/apache/skywalking/pull/4318#issuecomment-582232541
> > BTW, we should add a new check rule, `don't use Deprecated API`.
>
> I don't think this is a good decision.
JohnNiang commented on issue #4318: Reduce footprint via prototype pattern when
tagging spans
URL: https://github.com/apache/skywalking/pull/4318#issuecomment-582244844
> Adding a new check rule is to avoid "future users use that method again",
so what's your suggestion?
We can't
kezhenxu94 merged pull request #4318: Reduce footprint via prototype pattern
when tagging spans
URL: https://github.com/apache/skywalking/pull/4318
This is an automated message from the Apache Git Service.
To respond to the
EvanLjp commented on issue #4319: telemetry module
URL: https://github.com/apache/skywalking/issues/4319#issuecomment-582224936
When do I need to use it, Is there an official introduction document? I
don't find it
This is an
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new fa1e60f Reduce footprint when tagging
wu-sheng commented on issue #4318: Reduce footprint via prototype pattern when
tagging spans
URL: https://github.com/apache/skywalking/pull/4318#issuecomment-582230371
@JohnNiang This is not a decision, suggest taking the discussion to the mail
list.
wu-sheng commented on issue #4319: telemetry module
URL: https://github.com/apache/skywalking/issues/4319#issuecomment-582257864
The document is in the backend setup already for a long time.
codecov-io edited a comment on issue #4320: [BUG]Fix the bug of port
identification failure when connecting Oracle with Sid mode (JDBC: Oracle:
thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#issuecomment-582259358
#
JohnNiang commented on issue #4318: Reduce footprint via prototype pattern when
tagging spans
URL: https://github.com/apache/skywalking/pull/4318#issuecomment-582227248
> BTW, we should add a new check rule, `don't use Deprecated API`.
I don't think this is a good decision.
wu-sheng commented on issue #4272: Codes clean up plan and set up more strict
code style rules
URL: https://github.com/apache/skywalking/issues/4272#issuecomment-582219971
Rule, `don't use Deprecated API`. From
https://github.com/apache/skywalking/pull/4318#issuecomment-581966104
wu-sheng commented on a change in pull request #4320: [BUG]Fix the bug of port
identification failure when connecting Oracle with Sid mode (JDBC: Oracle:
thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#discussion_r375071553
##
File path:
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-582253156
`docker-entrypoint.sh` files
This is an automated message from the Apache
wu-sheng commented on a change in pull request #4320: [BUG]Fix the bug of port
identification failure when connecting Oracle with Sid mode (JDBC: Oracle:
thin: @ < host >: < port > / < Sid >)
URL: https://github.com/apache/skywalking/pull/4320#discussion_r375071553
##
File path:
dmsolr commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374708505
##
File path: tools/dependencies/known-oap-backend-dependencies-es7.txt
##
@@ -159,3 +159,8 @@
dmsolr commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374708701
##
File path:
kezhenxu94 opened a new pull request #4318: Reduce footprint via prototype
pattern when tagging spans
URL: https://github.com/apache/skywalking/pull/4318
### Motivation:
Reduce footprint when tagging spans with the deprecated API:
`AbstractSpan#tag(String, String)`.
###
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch upgrade-byte-buddy
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 66da4dd32fff41c6113d863170007ec58257cf33
Author: Wu Sheng
AuthorDate: Tue Feb 4 21:53:50 2020 +0800
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch upgrade-byte-buddy
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 66da4dd Upgrade the bytebuddy for J9VM
This branch includes the following new commits:
new
wu-sheng opened a new pull request #4317: Upgrade the bytebuddy to 1.10.7 for
J9VM
URL: https://github.com/apache/skywalking/pull/4317
Following
1. https://twitter.com/rafaelcodes/status/1224692043068379139
1. https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.10.7
dmsolr commented on issue #4239: Provide influxdb as a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-581879651
Thanks for your review and reminder, @wu-sheng and @kezhenxu94
I will fix them later.
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374638027
##
File path:
wu-sheng closed issue #4315: When will you release version 7.0.0
URL: https://github.com/apache/skywalking/issues/4315
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wu-sheng commented on issue #4315: When will you release version 7.0.0
URL: https://github.com/apache/skywalking/issues/4315#issuecomment-581886425
Why do you ask this? What is the context?
This is an automated message from
EvanLjp opened a new issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
___
### Question1
- What
wu-sheng commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581909755
Which JDK are you using? `javax.annotation` belongs to JDK's `rt.jar`. It is
not SkyWalking's issue.
EvanLjp commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581909855
when I checkout java verison from jdk 11 to jdk8,i successed
This is an automated
EvanLjp removed a comment on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581911416
I found the oap module have some code about jdk9? what is the releationship
between oap and jdk9
arugal commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r374671974
##
File path: browser/BrowserPerf.proto
##
@@ -25,36 +25,56 @@ import "common/common.proto";
//
EvanLjp commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581911881
thanks for your helping ,I will remember this one,thankyou
This is an automated
wu-sheng commented on issue #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#issuecomment-581914775
@Fine0830 Please confirm
This is an automated message from the
wu-sheng commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581895820
I assume you download source codes from wrong place.
> how to run springboot ui module in idea ?
You can't.
wu-sheng closed issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
EvanLjp commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581896487
how to run ui module in local mode,the first question I will try agin
This is an
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374641089
##
File path: tools/dependencies/known-oap-backend-dependencies-es7.txt
##
@@ -159,3 +159,8 @@
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374654869
##
File path:
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374642128
##
File path:
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374659028
##
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##
@@ -98,33 +98,33 @@
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374653664
##
File path:
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374654305
##
File path:
wu-sheng commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581901880
Read UI document, https://github.com/apache/skywalking-rocketbot-ui#dev-build
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r374654620
##
File path:
EvanLjp commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581908298
arugal commented on issue #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#issuecomment-581910723
Please review @Fine0830 @wu-sheng
This is an automated message from
wu-sheng commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581910733
Step 1, Prepare git, JDK8 and maven3
SkyWalking requires compiling in JDK8, but you could run in JDK8-12
wu-sheng commented on a change in pull request #18: Enhancement browser protocol
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/18#discussion_r374671091
##
File path: browser/BrowserPerf.proto
##
@@ -25,36 +25,56 @@ import "common/common.proto";
EvanLjp commented on issue #4316: cannot compile with offical doc
URL: https://github.com/apache/skywalking/issues/4316#issuecomment-581911416
I found the oap module have some code about jdk9? what is the releationship
between oap and jdk9
98 matches
Mail list logo
