Re: [PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.

2011-06-02 Thread Dmitry Kurochkin
Hi Carl. On Wed, 01 Jun 2011 22:10:07 -0700, Carl Worth cwo...@cworth.org wrote: On Sat, 28 May 2011 14:51:49 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Hi Jamie, I've pushed the next few patches up to this point, (with only one functional change---I fixed a new test

Re: [python] get all messages of a thread

2011-06-02 Thread Sebastian Spaeth
On Wed, 1 Jun 2011 15:35:35 +1000, Brian May wrote: Oh, I see, for your code, there is a implied call to __len__, and the __len__ function is completely broken for the reasons described in the documentation: It seems to have been a bad idea to implement __len__ at all for the Messsages()

python: get_filenames()

2011-06-02 Thread Sebastian Spaeth
A head up for the distributed gits and python users: I just pushed a commit to cworth/master implementing Message().get_filenames(). This will return a generator of absolute filenames for a certain Message-ID. For further information I refer to

notmuch crashing on misformated emails

2011-06-02 Thread Sebastian Spaeth
in python: list(Threads()) leads to a program abortion (bombing out of python): Internal error: Failed to read timestamp value from document. (lib/message.cc:731). Can we not crash the app on misformated emails? Sebastian pgpj9XsvsvjQZ.pgp Description: PGP signature

Re: [python] get all messages of a thread

2011-06-02 Thread Brian May
On 2 June 2011 17:05, Sebastian Spaeth sebast...@sspaeth.de wrote: What would be the best way to solve this (besides fixing the C api to allow to reset the iterator ;-) ?) I am not really familiar with the code. So am I correct in making the following assumptions? * It is not easy to fix

[PATCH 0/4] set test prereqs (Emacs, GDB, GPG) v3

2011-06-02 Thread Pieter Praet
Rebased the set test prereqs (Emacs, GDB, GPG) [1] patch series to Jameson's release-candidate/0.6 branch (0c0b4172). The GDB dependency for the atomicity tests was dropped since Austin has already included this in his amdragon/atomic-new-v4 branch [2], which has been included in

[PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'gpg', and adds that test as a prereq to all subsequent tests that rely on GnuPG. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org --- test/crypto | 33 +++-- 1

[PATCH 2/4] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org --- test/crypto | 17 ++--- 1 files changed, 14

[PATCH 3/4] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet pie...@praet.org --- test/emacs | 43

Re: [PATCH 0/4] set test prereqs (Emacs, GDB, GPG) v3

2011-06-02 Thread Austin Clements
This looks good to me, and should be merged sooner rather than later because it touches a lot of lines. If atomic-new-v4 doesn't happen to get merged before this, then id:1305206080-17461-1-git-send-email-amdra...@mit.edu and id:1305206110-17511-1-git-send-email-amdra...@mit.edu should get

Re: [python] get all messages of a thread

2011-06-02 Thread Sebastian Spaeth
On Thu, 2 Jun 2011 19:43:29 +1000, Brian May wrote: On 2 June 2011 17:05, Sebastian Spaeth sebast...@sspaeth.de wrote: What would be the best way to solve this (besides fixing the C api to allow to reset the iterator ;-) ?) * It is not easy to fix the C api to reset the iterator (what

Re: [python] get all messages of a thread

2011-06-02 Thread Sebastian Spaeth
On Thu, 02 Jun 2011 16:20:14 +0200, Sebastian Spaeth wrote: I made the change, and implemented __nonzero__ and removed the len() method. It just doesn't make sense on 1-time iterators. (I documented the change in the API docs). Sorry if this breaks existing code. FYI OK, I just pushed a

Re: [python] get all messages of a thread

2011-06-02 Thread Austin Clements
On Thu, Jun 2, 2011 at 10:20 AM, Sebastian Spaeth sebast...@sspaeth.de wrote: On Thu, 2 Jun 2011 19:43:29 +1000, Brian May wrote: On 2 June 2011 17:05, Sebastian Spaeth sebast...@sspaeth.de wrote: What would be the best way to solve this (besides fixing the C api to allow to reset the

Re: notmuch crashing on misformated emails

2011-06-02 Thread Sebastian Spaeth
On Thu, 02 Jun 2011 09:16:33 +0200, Sebastian Spaeth sebast...@sspaeth.de wrote: in python: list(Threads()) leads to a program abortion (bombing out of python): Internal error: Failed to read timestamp value from document. (lib/message.cc:731). Can we not crash the app on misformated

Re: Decryption fails

2011-06-02 Thread Jameson Graef Rollins
On Tue, 31 May 2011 19:33:29 +0200, Felix Geller fgel...@gmail.com wrote: I get the following trace when using show --decrypt to decrypt a specific message (have to kill the process to actually get the trace): #0 0x0001006121a6 in poll () #1 0x00010006d3d2 in gpg_ctx_op_step () #2

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-02 Thread Jameson Graef Rollins
This was a minor oversite in checking of part type when outputing content raw. This was causing gmime was to throw an exception to stderr. Unfortunately the gmime exception was not being caught by notmuch, or the test suite. I'm not sure if notmuch should have done anything in this case, but

Re: Decryption fails

2011-06-02 Thread Felix Geller
On Thu, 02 Jun 2011 08:35:49 -0700, Jameson Graef Rollins jroll...@finestructure.net wrote: Non-text part: multipart/signed Hey, Felix. Yeah, I unfortunately don't have any other suggestions other than asking the gmime folks. Jeff replied and sent me a working patch :) Not sure yet how he

[PATCH] emacs: Fix handling of message/rfc822 parts.

2011-06-02 Thread Jameson Graef Rollins
After the recent part-handling overhaul, emacs handling of message/rfc822 parts broke, not outputting the message contents. This fixes then handling as is, but there are still problems with how notmuch is outputting message parts that needs to be addressed (for instance, message headers are not

Re: Fwd: Re: compile error of current git on F15

2011-06-02 Thread Daniel Kahn Gillmor
I got the following response off-list from the gmime lead, which he's ok with my re-posting here: On 06/02/2011 08:53 AM, Jeffrey Stedfast wrote: I don't know why Fedora 15 ships 2.5.x, that seems like a really silly thing to do. I think I recall the Balsa guys bringing this up in the past and

problems with message/rfc822 parts

2011-06-02 Thread Jameson Graef Rollins
Hey, folks. I've been noticing a couple of issues with message/rfc822 part handling in recent builds of notmuch/master. They are rooted in the new part handling rework that was done recently. I just want to mention them here, to make people aware of them, until we get a chance to address them.

Re: Decryption fails

2011-06-02 Thread Jameson Graef Rollins
On Thu, 02 Jun 2011 18:49:22 +0200, Felix Geller fgel...@gmail.com wrote: Jeff replied and sent me a working patch :) Not sure yet how he prefers to publish the patch, but the problem is fixed. That's great! What did Jeff say exactly? Is the patch to gmime 2.4? Did he mention that he was

Multiple sender identities (composing)

2011-06-02 Thread Brian May
s to work fine. -- Brian May -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/c7fceb25/attachment.html>

[PATCH 14/25] Fix old style notmuch-fcc-dirs configuration check.

2011-06-02 Thread Dmitry Kurochkin
Hi Carl. On Wed, 01 Jun 2011 22:10:07 -0700, Carl Worth wrote: > On Sat, 28 May 2011 14:51:49 -0700, Jameson Graef Rollins finestructure.net> wrote: > Hi Jamie, > > I've pushed the next few patches up to this point, (with only one > functional change---I fixed a new test case to correctly use

[python] get all messages of a thread

2011-06-02 Thread Sebastian Spaeth
non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/7c0dd31e/attachment.pgp>

python: get_filenames()

2011-06-02 Thread Sebastian Spaeth
ttp://notmuchmail.org/pipermail/notmuch/attachments/20110602/481666e2/attachment.pgp>

notmuch crashing on misformated emails

2011-06-02 Thread Sebastian Spaeth
was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/ca89b851/attachment.pgp>

[python] get all messages of a thread

2011-06-02 Thread Brian May
... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/9b854d5c/attachment.html>

[PATCH 0/4] set test prereqs (Emacs, GDB, GPG) v3

2011-06-02 Thread Pieter Praet
Rebased the "set test prereqs (Emacs, GDB, GPG)" [1] patch series to Jameson's release-candidate/0.6 branch (0c0b4172). The GDB dependency for the atomicity tests was dropped since Austin has already included this in his amdragon/atomic-new-v4 branch [2], which has been included in

[PATCH 1/4] test: add 'GnuPG' prereq to dependent 'crypto' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'gpg', and adds that test as a prereq to all subsequent tests that rely on GnuPG. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/crypto | 33 +++-- 1 files changed, 19

[PATCH 2/4] test: add 'Emacs' prereq to dependent 'crypto' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/crypto | 17 ++--- 1 files changed, 14 insertions(+),

[PATCH 3/4] test: add 'Emacs' prereq to dependent 'emacs' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/emacs | 43 --- 1 files

[PATCH 4/4] test: add 'Emacs' prereq to dependent 'emacs-large-search-buffer' tests

2011-06-02 Thread Pieter Praet
Adds a new test that checks for the presence of 'emacs', and adds that test as a prereq to all subsequent tests that rely on Emacs. This causes tests with unmet dependencies to be skipped. Signed-off-by: Pieter Praet --- test/emacs-large-search-buffer |9 +++-- 1 files changed, 7

[PATCH 0/4] set test prereqs (Emacs, GDB, GPG) v3

2011-06-02 Thread Austin Clements
This looks good to me, and should be merged sooner rather than later because it touches a lot of lines. If atomic-new-v4 doesn't happen to get merged before this, then id:"1305206080-17461-1-git-send-email-amdragon at mit.edu" and id:"1305206110-17511-1-git-send-email-amdragon at mit.edu" should

[python] get all messages of a thread

2011-06-02 Thread Sebastian Spaeth
ill of course not return until it is finished). Sebastian -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/924e2df9/attachment.pgp>

[python] get all messages of a thread

2011-06-02 Thread Sebastian Spaeth
results. Sebastian -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/055da5b8/attachment-0001.pgp>

[python] get all messages of a thread

2011-06-02 Thread Austin Clements
On Thu, Jun 2, 2011 at 10:20 AM, Sebastian Spaeth wrote: > On Thu, 2 Jun 2011 19:43:29 +1000, Brian May wrote: >> On 2 June 2011 17:05, Sebastian Spaeth wrote: >> >> > What would be the best way to solve this (besides fixing the C api to >> > allow to reset the iterator ;-) ?) > >> * It is not

notmuch crashing on misformated emails

2011-06-02 Thread Sebastian Spaeth
<http://notmuchmail.org/pipermail/notmuch/attachments/20110602/b1447f38/attachment.pgp>

Decryption fails

2011-06-02 Thread Jameson Graef Rollins
t looks like the trace that you show above definitely looks like gmime caught in a poll loop. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pi

[PATCH] Do not attept to output part raw if part is not GMimePart.

2011-06-02 Thread Jameson Graef Rollins
This was a minor oversite in checking of part type when outputing content raw. This was causing gmime was to throw an exception to stderr. Unfortunately the gmime exception was not being caught by notmuch, or the test suite. I'm not sure if notmuch should have done anything in this case, but

Decryption fails

2011-06-02 Thread Felix Geller
Name: crypto.txt URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/c80ad35b/attachment-0001.txt> -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 202 bytes Desc: not available URL: <http:/

[PATCH] emacs: Fix handling of message/rfc822 parts.

2011-06-02 Thread Jameson Graef Rollins
After the recent part-handling overhaul, emacs handling of message/rfc822 parts broke, not outputting the message contents. This "fixes" then handling as is, but there are still problems with how notmuch is outputting message parts that needs to be addressed (for instance, message headers are not

Fwd: Re: compile error of current git on F15

2011-06-02 Thread Daniel Kahn Gillmor
application/pgp-signature Size: 1030 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/1c576422/attachment.pgp>

problems with message/rfc822 parts

2011-06-02 Thread Jameson Graef Rollins
RL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/f0f869ca/attachment.pgp>

Decryption fails

2011-06-02 Thread Jameson Graef Rollins
you sure you haven't modified your source at all? jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/dc1c3afe/attachment.pgp>

notmuch crashing on misformated emails

2011-06-02 Thread Patrick Totzke
available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/94db5326/attachment.pgp> -- next part -- An embedded and charset-unspecified text was scrubbed... Name: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20110602/94db5326/attachment.ksh>