[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587982#comment-15587982 ] Thomas Mueller commented on OAK-4522: - http://svn.apache.org/r1765547 (fix test case, take 2) > Improve

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571155#comment-15571155 ] Thomas Mueller commented on OAK-4522: - http://svn.apache.org/r1764611 (fix test case) Actually the test

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551573#comment-15551573 ] Thomas Mueller commented on OAK-4522: - http://svn.apache.org/r1763550 > Improve CommitRateLimiter to

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548855#comment-15548855 ] Thomas Mueller commented on OAK-4522: - > this patch only works with documentMk > revisit the nature of

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420808#comment-15420808 ] Stefan Egli commented on OAK-4522: -- [~tmueller], did a review of [^OAK-4522-b.patch], looks good to me

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415031#comment-15415031 ] Thomas Mueller commented on OAK-4522: - I just noticed it (sometimes?) breaks the CommitRateLimiterTest

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413635#comment-15413635 ] Michael Dürig commented on OAK-4522: Some nit picking: please set the threads interrupt flag upon

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399412#comment-15399412 ] Thomas Mueller commented on OAK-4522: - One problem of the current behavior, to throw an exception

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399342#comment-15399342 ] Thomas Mueller commented on OAK-4522: - [~egli]'s patch uses a boolean to mark a thread non-blocking.

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399239#comment-15399239 ] Thomas Mueller commented on OAK-4522: - The patch from [~egli] looks good. It might be a bit problematic

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397550#comment-15397550 ] Thomas Mueller commented on OAK-4522: - The CommitRateLimiter currently only gets informed about added

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395791#comment-15395791 ] Thomas Mueller commented on OAK-4522: - In general I will try to find a simple solution, but test it

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382335#comment-15382335 ] Michael Dürig commented on OAK-4522: I think to come up with a proper "commit rate limiter" we need to

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375147#comment-15375147 ] Stefan Egli commented on OAK-4522: -- FYI: Added a 'prototype' to an oak fork

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374979#comment-15374979 ] Stefan Egli commented on OAK-4522: -- a stacktrace to illustrate the hard-to-find deadlock: stack 1: {code}

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15374972#comment-15374972 ] Stefan Egli commented on OAK-4522: -- there is one more aspect to take into account here: it's fine that the

[jira] [Commented] (OAK-4522) Improve CommitRateLimiter to optionally block some commits

[ https://issues.apache.org/jira/browse/OAK-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355408#comment-15355408 ] Stefan Egli commented on OAK-4522: -- yes, and from this I conclude that you can't have a hard limit on