Re: [PATCH v2] Skip unsolicied CREG/CGREG correctly while checking GPRS attach status

2010-12-11 Thread Denis Kenzior
Hi Tonny, In your proposed patch, it bypass the unsolicited response only if the 2nd number after +CGREG: is not single digit, however if the lac is single digit, we will still get the wrong state number. The lac is given as a 2 byte number and should always be printed as four hexadecimal

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

2010-12-11 Thread Denis Kenzior
Hi Tonny, But it seems to me the gprs context will be pass to modem plugins, so we need to set the vendor code for Huawei modems, because it sends unquoted strings. No, you don't. You are confusing gprs atom and the gprs-context atom. Grep for VENDOR in drivers/atmodem/gprs-context.c if you

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-11 Thread Marcel Holtmann
Hi Remi, Personally I think the every-10sec interval is too short. It's also highly system specific when wakeups start to get too costly, so picking up one value seems difficult. My take here is that a granularity of 1 minute is enough. There are definitely call

Re: [PATCH v2] Skip unsolicied CREG/CGREG correctly while checking GPRS attach status

2010-12-11 Thread Tonny Tzeng
Hi Denis, On Sat, Dec 11, 2010 at 10:52 PM, Denis Kenzior denk...@gmail.com wrote: Hi Tonny, In your proposed patch, it bypass the unsolicited response only if the 2nd number after +CGREG: is not single digit, however if the lac is single digit, we will still get the wrong state number.

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

2010-12-11 Thread Tonny Tzeng
Hi Denis, No, you don't. You are confusing gprs atom and the gprs-context atom. Grep for VENDOR in drivers/atmodem/gprs-context.c if you do not believe me. There is no vendor specific code in the atmodem gprs-context driver. Yes, my bad, I misunderstood the program flow... So, is

Re: [PATCH] Specify vendor ID for Huawei modem while creating GPRS context

2010-12-11 Thread Denis Kenzior
Hi Tonny, On 12/11/2010 10:37 AM, Tonny Tzeng wrote: Hi Denis, No, you don't. You are confusing gprs atom and the gprs-context atom. Grep for VENDOR in drivers/atmodem/gprs-context.c if you do not believe me. There is no vendor specific code in the atmodem gprs-context

RE: [PATCH] ifx: adding Infineon modem self test

2010-12-11 Thread Bastian, Waldo
Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. didn't we conclude that the modem should do all these by itself? My understanding is that the modem executes these.

RE: [PATCH] ifx: adding Infineon modem self test

2010-12-11 Thread Marcel Holtmann
Hi Waldo, Adding Infineon modem selftest to the plugin. It executes couple of AT commands, and based on the responses, it continues with ifx modem enabling or powers the modem down. didn't we conclude that the modem should do all these by itself? My understanding is that the