Re: [PATCH 3/6] gemalto: acquire the network technology

Hi Gabriel, Mariem, On 03/16/2018 07:59 AM, Gabriel Lucas wrote: From: Mariem Cherif --- drivers/atmodem/network-registration.c | 45 ++ 1 file changed, 45 insertions(+) When applying this patch I got: CC

Re: [PATCH 2/6] gemalto: support ALS3 in gemalto's plugin

Hi Gabriel,   { >>>   struct gemalto_data *data = ofono_modem_get_data(modem);   const char *app, *mdm;   -    DBG("%p", modem); +    /* Close devices */ +    g_at_chat_unref(data->mdm); +    g_at_chat_unref(data->app); + Why would you close both devices?  It is unnecessary,

Re: [PATCH 4/6] gemalto: handle sim is inserted or removed URCs

Hi Gabriel, On 03/16/2018 08:28 AM, Gabriel Lucas wrote: Hi Denis, On 15/03/2018 18:26, Denis Kenzior wrote: Hi Gabriel, On 03/15/2018 07:49 AM, Gabriel Lucas wrote: From: Mariem Cherif <mariem.che...@ardia.com.tn> +    g_at_result_iter_init(, result); + +    if (!g_at_result_ite

Re: [PATCH 6/6] gemalto: fix sim reinsertion issue

Hi Gabriel, On 03/15/2018 07:49 AM, Gabriel Lucas wrote: When the SIM card is reinserted in the holder, the IRC +CIEV: simstatus,1 is emitted. The problem is that the SIM isn't ready when it is received. Hence, Ofono fails on CPIN? command and the modem cannot be used. This patch make ofono

Re: [PATCH 5/6] sim: give access to the driver

Hi Gabriel, +const struct ofono_sim_driver* ofono_sim_get_driver(struct ofono_sim *sim); No, please don't do this. The driver should just issue the relevant command directly. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 4/6] gemalto: handle sim is inserted or removed URCs

Hi Gabriel, On 03/15/2018 07:49 AM, Gabriel Lucas wrote: From: Mariem Cherif --- plugins/gemalto.c | 37 + 1 file changed, 37 insertions(+) diff --git a/plugins/gemalto.c b/plugins/gemalto.c index 16ca463..c7fb783 100644 ---

Re: [PATCH 1/6] gemalto: add detection of ALS3 modem

Hi Gabriel, On 03/15/2018 07:49 AM, Gabriel Lucas wrote: The product ID is added to the list of modems to be detected by Ofono. The gemalto plugin is used to handle the ALS3 modem. --- plugins/udevng.c | 18 ++ 1 file changed, 18 insertions(+) Patch applied, thanks.

Re: [PATCH 1/1] SIM detection: Fixing the logical error in using the number of slot and number of application

Hi, On 03/12/2018 09:07 AM, Eswaran Vinothkumar (BEG/PJ-IOT-EL) wrote: From d1ec66c643f005d558c403a68c7df04b0819aa79 Mon Sep 17 00:00:00 2001 From: "Eswaran Vinothkumar (BEG-PT/PJ-IOT1)" Date: Mon, 12 Mar 2018 14:46:28 +0100 Subject: [PATCH] sim

Re: LTE atom support for gemalto modem

Hi Gabriel, I've been having a look at the recent LTE atom. I've noticed there was no vendor-specific parameter when registering it. I think we might have some problem with the atmodem driver as in the AT+CGDCONT=,... command, the context-id starts from 0 on some modems and from 1 on other

Re: Wierd behaviour of ofono on MC7455 and Verizon sim card

Hi, On 03/08/2018 11:47 AM, Eswaran Vinothkumar (BEG/PJ-IOT-EL) wrote: Mar 08 17:14:51 alen-eval-kit ofonod[175]: ../ofono-1.22/drivers/qmimodem/devinfo.c:string_cb() Mar 08 17:14:51 alen-eval-kit ofonod[175]: ../ofono-1.22/drivers/qmimodem/devinfo.c:qmi_query_serial() Mar 08 17:14:51

Re: [PATCH 0/3] QMI modem fixups

Hi Jonas, On 03/07/2018 08:55 AM, Jonas Bonn wrote: Here's a couple of fixups to the qmimodem atoms in order handle service lifetime. I've taken the first two patches, but the whole unregister_all thing has horrible side-effects since you're force un-registering notifications that you don't

Re: [PATCH v2 1/3] qmi: add LTE atom driver

Hi Reinhard, So this looks good to me. Since Reinhard has provided invaluable insight >> into how QMI works in the past and seems to have 'insider' knowledge, maybe we can get him to also comment on whether the approach is correct (e.g. whether querying / setting the default profile is

Re: [PATCH v3 0/3] LTE APN series

Hi Jonas, On 03/05/2018 06:31 AM, Jonas Bonn wrote: Here's v3 of the LTE APN series. This just fixes up some of the issues that Denis identified in the previous series. All cosmetic with the exception of a leaked QMI response parameter. Reinhard had some interesting insight into whence QMI

Re: Ofono LTE modems and connman services

Hi Jonas, On 03/02/2018 09:29 AM, Jonas Bonn wrote: On 03/01/2018 05:11 PM, Denis Kenzior wrote: Hi Jonas, Hi Denis, I've spent most of the day trying to make sense of this.  I'll send some new logs when I get a chance but I thought I'd just ask a couple of questions that popped up during

Re: [PATCH v2 3/3] qmimodem: get LTE default bearer APN from modem

Hi Jonas, On 03/02/2018 09:12 AM, Jonas Bonn wrote: When an LTE modem registers with the network, a default bearer is automatically established. The APN used for this bearer is taken from whatever default settings the modem has. The LTE atom takes cares of setting up the default

Re: [PATCH v2 1/3] qmi: add LTE atom driver

Hi Jonas, On 03/02/2018 09:12 AM, Jonas Bonn wrote: This patch adds an LTE atom for QMI modems. This atom sets the APN that the LTE default bearer should use when establishing its PDP context. This APN needs to be set on the 'default' profile so the atom queries which profile is the default

Re: Ofono LTE modems and connman services

Hi Jonas, This is an explicit UMTS to LTE transition: {RadioSettings} [/quectelqmi_0] TechnologyPreference = lte Okay, so you set the Technology preference and the modem goes into disconnect and search mode {ConnectionManager} [/quectelqmi_0] Attached = False {ConnectionContext}

Re: [PATCH 4/4] qmimodem: get LTE default bearer APN from modem

Hi Jonas, On 03/01/2018 09:20 AM, Jonas Bonn wrote: On 03/01/2018 04:02 PM, Denis Kenzior wrote: Hi Jonas, On 03/01/2018 04:48 AM, Jonas Bonn wrote: When an LTE modem registers with the network, a default bearer is automatically established.  The APN used for this bearer is taken from

Re: Ofono LTE modems and connman services

Hi Jonas, Ofono does something like this on a tech transition to LTE: Active: false Attached: false ... Attached: true Active: true This is from 3G to LTE or the initial registration to LTE? Do you have an ofono-monitor log handy? When ofono does Attached: true, connman starts trying to

Re: [PATCH 1/4] qmi: add LTE atom driver

Hi Jonas, Please merge patch 1 & 2 together, that's how we usually do it anyway. OK.  I broke those up because I thought you were super-pedantic about breaking out patches so they were per-file... what's the rule here? Per-directory? It is per-directory, with the build system being the

Re: [PATCH 4/4] qmimodem: get LTE default bearer APN from modem

Hi Jonas, On 03/01/2018 04:48 AM, Jonas Bonn wrote: When an LTE modem registers with the network, a default bearer is automatically established. The APN used for this bearer is taken from whatever default settings the modem has. In order to properly set up the ofono context, we need to find

Re: [PATCH 1/4] qmi: add LTE atom driver

Hi Jonas, On 03/01/2018 04:48 AM, Jonas Bonn wrote: This patch adds an LTE atom for QMI modems. This atom sets the APN that the LTE default bearer should use when establishing its PDP context. For the Quectel EC21 that I'm testing with, this is effected by setting the APN on profile ID 1 from

Re: Ofono crashes on SIM notifications

Hi Mattias, On 02/28/2018 04:01 AM, Mattias Månsson wrote: Hi! I'm working with integrating a new Gemalto modem with Ofono and is currently working with dynamic SIM card detection. This is not done by any included driver what I can see, so it is possible I have done something wrong.

Re: Ofono LTE modems and connman services

Hi Jonas, On 02/26/2018 08:37 AM, Jonas Bonn wrote: The following issue is causing us some grief and I really need some guidance on how to approach this.  This is being sent to both the ofono and connman mailing lists because it's not really clear to me who's doing the right/wrong thing

Re: [PATCH] phonebook: Fixed double deletion of merge_list

Hi Slava, On 02/22/2018 09:18 AM, Slava Monich wrote: --- src/phonebook.c | 1 - 1 file changed, 1 deletion(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH 0/3] Add SystemPath property to modem interface

Hi Christophe, On 02/19/2018 08:57 AM, Christophe Ronco wrote: Here is the patch serie as discussed in this thread of mails. Christophe Ronco (3): udevng: Add modem string SystemPath modem: Add SystemPath dbus property doc: Add SystemPath to Modem interface doc/modem-api.txt | 8

Re: [PATCH 3/3] doc: Add SystemPath to Modem interface

Hi, +    string SystemPath [readonly, optional] + +    String giving a consistent hardware path for the modem +    device. It will not change in case of reboot of modem +    or ofono. Given that many modems are USB devices, I don't think you can actually promise

Re: [PATCH] add syspath property to modem properties

Hi Christophe, No top posting please. On 02/16/2018 09:40 AM, Christophe Ronco wrote: Hi Denis, I didn't think this patch could be something used on Upstream Ofono. If it is, I also have remarks on my own patch:  - shouldn't it be two patches (one for plugin directory, another for src

Re: [PATCH] add syspath property to modem properties

Hi Christophe, On 02/15/2018 02:50 AM, Christophe Ronco wrote: --- plugins/udevng.c | 2 ++ src/modem.c | 74 2 files changed, 45 insertions(+), 31 deletions(-) diff --git a/plugins/udevng.c b/plugins/udevng.c index

Re: [PATCH] udevng: Add OFONO_PATHNAME property to set modem dbus path name

Hi Pau, As far as I understand the IMEI is available in org.ofono.Modem.GetProperties "Serial" property. To be able to access this information, I need to previously power on the modem (SetProperty Powered true), otherwise it doesn't show up. Which means that for an ofono user, it is a

Re: [PATCH] udevng: Add OFONO_PATHNAME property to set modem dbus path name

Hi Pau, On 02/13/2018 01:53 PM, Pau Espin Pedrol wrote: The current udevng.c implementation sets dbus path names for modems based on type and a number incremented seuqntially for each new modem found. As a result, the dbus path for a given device is non deterministic, since it depends on the

Re: GPRS Attach/Detach

Hi Nikolas, I had to remove the `else if (have_active_contexts(gprs) == TRUE) { ... }` block because when attached was TRUE i still had active context and i didn't want it to be deactivated. This particular logic was added in commit: 154f4aca65b3b419239be75d0def276bd7f4dc8e As the

Re: [PATCH 2/4] xmm7modem: drop executable bit from C source file

Hi Jonas, What about the other three patches?  Are they being silently rejected or did they just fall off the radar? In particular, patch 1/4 is important... They're not ignored, but I'm not competent enough to review the build system changes. They need to be acked by Marcel first who

Re: [PATCH 0/5] Add Bluetooth HFP memory index dialing V3

Hi Philippe, On 02/12/2018 12:37 PM, philippedesw...@gmail.com wrote: From: Philippe De Swert Hi, Finally got some time to redo the patches from last time after all the comments. So I renamed the functions to reflect clearly what they are for and avoid

Re: [PATCH 2/4] xmm7modem: drop executable bit from C source file

Hi Jonas, On 02/04/2018 04:55 PM, Jonas Bonn wrote: --- drivers/xmm7modem/ims.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 drivers/xmm7modem/ims.c Applied, thanks. Regards, -Denis ___ ofono mailing list

Re: Plugin infrastructure

Hi Jonas, On 02/04/2018 11:19 AM, Jonas Bonn wrote: Hi, I was reading through the ofono code and I see that there's a lot of code in place to support external plugins.  As things currently stand, however, ofono can only be built with _builtin_ modules, so all this plugin infrastructure is

Re: [PATCH] unit: fix test-simutil failure

Hi James, On 01/19/2018 12:29 PM, James Prestwood wrote: A fixup was made in simauth to fix the AUTS length and the simutil unit test was never updated to reflect the length change. --- unit/test-simutil.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks.

Re: Huawei MS2131

Hi Xingxing, root@iot2000-ebs:/usr/lib/ofono/test# ./activate-context Error activating /huawei_0/context1: org.ofono.Error.NotImplemented: Implementation not provided. This tells me that the gprs context driver has failed to initialize. Do you have TUN/TAP support enabled in your kernel?

Re: [PATCH] unit: Improve idmap.c unit test coverage

Hi Slava, On 01/18/2018 12:36 PM, Slava Monich wrote: This brings function, line and branch coverage for idmap.c to 100% --- unit/test-idmap.c | 24 1 file changed, 24 insertions(+) Applied, thanks. Regards, -Denis ___

Re: Huawei MS2131

Hi Daniel, On 01/18/2018 06:32 AM, Daniel Wagner wrote: [16:18:50.215180] ofonod[3277]: Modem: < \r\n+CGREG: 1,"03B8","0EA971F9"\r\n [16:18:50.315482] ofonod[3277]: Modem: < \r\n^SRVST: 2\r\n [16:18:50.498603] ofonod[3277]: Modem: < \r\n+CREG: 1,"03B8","0EA971F9"\r\n [16:19:39.357779]

Re: [PATCH] dbus: Use dbus_validate_path

Hi Slava, On 01/18/2018 10:47 AM, Slava Monich wrote: Instead of __ofono_dbus_valid_object_path --- plugins/push-notification.c | 2 +- plugins/smart-messaging.c | 2 +- src/dbus.c | 44 src/gnss.c | 2 +-

Re: [PATCH 2/2] qmi: add USSD support for MO services

Hi Alexander, On 01/16/2018 09:33 AM, Alexander Couzens wrote: --- drivers/qmimodem/ussd.c | 187 ++-- 1 file changed, 183 insertions(+), 4 deletions(-) diff --git a/drivers/qmimodem/ussd.c b/drivers/qmimodem/ussd.c index

Re: [PATCH 1/2] add qmimodem/voice.h to add USSD defines

Hi Alexander, On 01/16/2018 09:33 AM, Alexander Couzens wrote: USSD is part of the QMI voice service. --- drivers/qmimodem/voice.h | 62 1 file changed, 62 insertions(+) create mode 100644 drivers/qmimodem/voice.h Applied. I also added a

Re: Problem with dialstring ##21#

Hi Engelbert, Please no top-posting on this mailing list. On 01/16/2018 10:22 AM, Engelbert Torremans wrote: Denis, Thanks. The thing is that it does work when I am trying the same thing in my car :-) That is probably not based on ofono (I don't know what is used inside) but at least it

Re: Problem with dialstring ##21#

Hi Engelbert, On 01/16/2018 06:50 AM, Engelbert Torremans wrote: All, I am looking for some help in trying to fix this problem I am experiencing when using Ofono on a RaspberryPi in "carkit/HFP mode". Currently I can make calls (originate and terminate) and audio is fine in combination

Re: Vendor product extension thoughts

Hi Enrico, On 01/04/2018 07:01 AM, Enrico Sau wrote: ​Hello everyone, I'm facing what seems to be a limit in ofono implementation. I'm working with some Telit modems and some of them have reserved contexts which can't be used for data connection. Define 'reserved contexts'? Is it just

Re: [PATCH] qmimodem: fix roaming status report

Hi Christophe, On 12/15/2017 04:28 AM, Christophe Ronco wrote: It would be nice to have the information in the cover letter included in the commit description. --- drivers/qmimodem/network-registration.c | 50 - 1 file changed, 43 insertions(+), 7

Re: [PATCH] sim: Don't submit parallel EFpl reads

Hi Slava, On 12/08/2017 08:57 AM, Slava Monich wrote: In addition to not doing unnecessary SIM I/O, this fixes memory leaks like this one: ==10096== 74 (56 direct, 18 indirect) bytes in 2 blocks are definitely lost in loss record 1,252 of 1,342 ==10096==at 0x4841BF0: calloc

Re: [PATCH 5/7] voicecall.c : Add functionality to dial from a memory location.

Hi Philippe, On 12/06/2017 09:36 AM, Philippe De Swert wrote: Now we can also dial favourites/quick contacts over bluetooth. --- src/voicecall.c | 72 +++-- 1 file changed, 65 insertions(+), 7 deletions(-) diff --git a/src/voicecall.c

Re: [PATCH 4/7] voicecall: Fix issue with invalid dbus path

Hi Philippe, On 12/06/2017 09:36 AM, Philippe De Swert wrote: Fix an error message from dbus about the path supplied not being valid. Related to commit f58e7685b0078df470300b99cd89fb9b3c45d1c0 ofonod[19107]: src/voicecall.c:voicecall_dial_shortcut() check position ofonod[19107]:

Re: [PATCH 3/7] include/voicecall.h : Add support for dialing number at a given memory location

Hi Philippe, On 12/06/2017 09:36 AM, Philippe De Swert wrote: Add a new function to be able to dial numbers from memory/favourites. --- include/voicecall.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/voicecall.h b/include/voicecall.h index 79a64bb4..6c4f3f5f 100644 ---

Re: [PATCH 1/7] voicecall: Support clir for last call dialing

Hi Philippe, On 12/06/2017 09:35 AM, Philippe De Swert wrote: When dialing the last called number we also want to use the caller id (clir) settings that are currently used. --- doc/voicecallmanager-api.txt | 2 +- drivers/hfpmodem/voicecall.c | 4 ++-- include/voicecall.h | 3

Re: [PATCH] sim: Handle multiple EFpl read completions

Hi Slava, On 12/07/2017 11:09 AM, Slava Monich wrote: Since sim_efli_efpl_changed() can be invoked several times before completion of SIM reads (which are not cancellable), followed by multiple completions, it's not enough to free old sim->language_prefs in sim_efli_efpl_changed(). The same

Re: [PATCH 1/4] network: allow drivers to generate more specific error codes

Hi Alexander, On 12/05/2017 12:20 PM, Alexander Couzens wrote: For certain modems it's not clear if they support all actions or not. In such cases use CME errors which allows generate NotSupported messages. --- src/network.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) All 4

Re: [PATCH][v2 1/4] qmi/discovery: remove useless code

Hi Alexander, On 12/05/2017 11:52 AM, Alexander Couzens wrote: --- drivers/qmimodem/qmi.c | 7 --- 1 file changed, 7 deletions(-) All 4 applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] sim-auth: Avoid using dbus_message_iter_get_element_count

Hi Slava, On 11/27/2017 05:06 AM, Slava Monich wrote: It's the only thing in ofono that requires dbus 1.9.16 or later and it's not worth it. And don't leak DBusMessage on format error. --- src/sim-auth.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-)

Re: [PATCH 1/2] include: Add storage.h

Hi Slava, On 11/27/2017 04:31 AM, Slava Monich wrote: To expose ofono directories to dynamically loadable plugins. --- Makefile.am | 3 ++- include/storage.h | 32 2 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 include/storage.h

Re: [PATCH 1/3] simauth: remove driver API definitions from simauth include

Hi James, On 11/09/2017 11:52 AM, James Prestwood wrote: --- include/sim-auth.h | 38 +- 1 file changed, 1 insertion(+), 37 deletions(-) All three applied, thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH 1/6] atmodem: removed simauth init

Hi James, On 11/09/2017 11:17 AM, James Prestwood wrote: --- drivers/atmodem/atmodem.c | 2 -- 1 file changed, 2 deletions(-) Patch 1 - 3 applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 1/4] simfs: Added support for ISim file systems

Hi James, On 11/08/2017 11:23 AM, James Prestwood wrote: --- src/simfilesystem.cpp | 100 +++--- src/simfilesystem.h | 11 +- 2 files changed, 89 insertions(+), 22 deletions(-) All 4 applied, thanks. Regards, -Denis

Re: [PATCH] simauth: use new sim atom functionality for simauth

Hi James, On 11/08/2017 11:27 AM, James Prestwood wrote: All the functionality for the simauth driver was moved into the sim atom. This patch transitions the simauth atom to using those API's instead of the simauth driver API's. With this change it made more sense to store each AID as its own

Re: [PATCH 1/3] sim: logical access API

Hi James, On 11/07/2017 10:42 AM, James Prestwood wrote: Moved logical access API from simauth to sim atom. This removes the need for a simauth driver completely, as the rest of the functionality was moved in previous commits. --- include/sim.h | 10 ++ 1 file changed, 10

Re: [PATCH v2 2/2] gemalto: add PIN retries support in plugin

Hi Gabriel, On 11/06/2017 07:57 AM, Gabriel Lucas wrote: In SimManager, the Retries property isn't used for gemalto modems. The at command AT^SPIC is used to get the remaining retries left for the current required password type. This commit enable the use of the driver in the gemalto plugin

Re: [PATCH v2 1/2] gemalto: add PIN retries support in driver

Hi Gabriel, On 11/07/2017 03:53 AM, Gabriel Lucas wrote: In SimManager, the Retries property isn't used for gemalto modems. The at command AT^SPIC is used to get the remaining retries left for the current required password type. This commit adds the implementation in the SIM driver of the

Re: [PATCHv2] sim: added ImsPrivateIdentity to SimManager

Hi James, On 11/06/2017 04:37 PM, James Prestwood wrote: If the ISIM AID is found a new AID based context will be created and the EFIMPI file will be read from the SIM which contains the ImsPrivateIdentity. --- src/ofono.h | 2 ++ src/sim.c | 44

Re: [PATCH 4/5] sim: added ImsPrivateIdentity to SimManager

Hi James, On 11/06/2017 11:49 AM, James Prestwood wrote: If the ISIM AID is found a new AID based context will be created and the EFIMPI file will be read from the SIM which contains the ImsPrivateIdentity. --- src/ofono.h | 2 ++ src/sim.c | 44

Re: [PATCH 3/5] sim: implement create ISIM context

Hi James, On 11/06/2017 11:49 AM, James Prestwood wrote: API to create a sim context for the ISIM application, if found. During AID discovery, if an ISIM AID is found, a new fs object is initialized for the ISIM which will be used for any future ISIM context creation. --- src/sim.c | 41

Re: [PATCH v2 1/2] gemalto: add PIN retries support in driver

Hi Gabriel, On 11/06/2017 07:57 AM, Gabriel Lucas wrote: In SimManager, the Retries property isn't used for gemalto modems. The at command AT^SPIC is used to get the remaining retries left for the current required password type. This commit adds the implementation in the SIM driver of the

Re: [PATCH] atmodem: implement new driver APIs for AID sessions

Hi James, On 11/03/2017 06:30 PM, James Prestwood wrote: Implementation for open/close channel, list applications, and session based file read. --- drivers/atmodem/sim.c | 277 +- 1 file changed, 275 insertions(+), 2 deletions(-) Applied,

Re: [PATCHv2 1/4] sim: header definitions for AID session APIs

Hi James, On 11/03/2017 05:34 PM, James Prestwood wrote: ISIM and newer AID's require opening a logical channel to read their EF's. This requires new driver API's to discover AID's, open/close a channel, and reading the EF's from an opened channel. This functionality was moved from the simauth

Re: [PATCH 5/8] include/voicecall.h : Add support for dialing number at a given memory location

Hi Philippe, On 10/31/2017 03:39 AM, Philippe De Swert wrote: --- include/voicecall.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/voicecall.h b/include/voicecall.h index 6871a6b5..b3d5bc06 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -61,6 +61,11 @@

Re: [PATCH 6/8] voicecallmanager: Add DBUS method for dialing a memory index

Hi Philippe, On 10/31/2017 03:39 AM, Philippe De Swert wrote: Add a new method dial_memory to the voicecall manager interface --- src/voicecall.c | 106 1 file changed, 106 insertions(+) diff --git a/src/voicecall.c b/src/voicecall.c

Re: [PATCH V2 4/8] doc: Document the new DialLast voicecallmanager API addition

Hi Philippe, On 10/31/2017 03:39 AM, Philippe De Swert wrote: The new DialLast method to call the last dialled number for HFP needs to be added to the documentation. --- doc/voicecallmanager-api.txt | 10 ++ 1 file changed, 10 insertions(+) Applied, thanks. Regards, -Denis

Re: [PATCH V2 3/8] hfpmodem: Send last call dialled request

Hi Philippe, On 10/31/2017 03:39 AM, Philippe De Swert wrote: Handle the last call dialled request and send the required AT+BDLN command for bluetooth HFP profile. --- drivers/hfpmodem/voicecall.c | 20 1 file changed, 20 insertions(+) Applied with an amendment, see

Re: [PATCH V2 2/8] voicecallmanager: Handle last number dialled DBUS call

Hi Philippe, On 10/31/2017 03:39 AM, Philippe De Swert wrote: Handle the new DialLast method on the voicecallmanager interface --- src/voicecall.c | 87 + 1 file changed, 87 insertions(+) I went ahead and applied this patch, however:

Re: [PATCH V2 1/8] include/voicecall : update ofono_voicecall_driver to support call last dialled number

Hi Philippe, On 10/31/2017 03:39 AM, Philippe De Swert wrote: Add new DBUS method to enable calling the last dialled number. --- include/voicecall.h | 4 1 file changed, 4 insertions(+) Applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH] gemalto: add PIN retries support

Hi Gabriel, On 11/03/2017 07:06 AM, Gabriel LUCAS wrote: From 4157f3e7aa0eb16eec0b1ccf87946ecf53539090 Mon Sep 17 00:00:00 2001 From: Gabriel Lucas Date: Tue, 24 Oct 2017 11:15:58 +0200 Subject: [PATCH] gemalto: add PIN retries support Signed-off-by: Gabriel Lucas

Re: [PATCH 3/8] sim: AID session management

Hi James, On 11/01/2017 12:33 PM, James Prestwood wrote: Accessing an AID requires opening a channel to that application. This patch implements session management API's so that other atoms can access a given AID. Now any atom can get a session ID from the sim atom. This will either reuse an

Re: [PATCH 2/8] sim: header definitions for AID session APIs

Hi James, On 11/01/2017 12:33 PM, James Prestwood wrote: ISIM and newer AID's require opening a logical channel to read their EF's. This requires new driver API's to discover AID's, open/close a channel, and reading the EF's from an opened channel. This functionality was moved from the simauth

Re: [PATCH 1/8] simutil: Added ISIM elementary file ID's

Hi James, On 11/01/2017 12:33 PM, James Prestwood wrote: --- src/simutil.h | 11 +++ 1 file changed, 11 insertions(+) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] simutil: Made UMTS/GSM authenticate more consitent

Hi James, On 11/01/2017 12:32 PM, James Prestwood wrote: The Le parameter in the AUTHENTICATE command was not being set for GSM authentication. This did work, but explicitly setting it to 0 as UMTS does was more consitent. --- src/simutil.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH] qmi: remove request when it timeouts

Hi Christophe, On 10/27/2017 09:37 AM, Christophe Ronco wrote: When modem does not answer or answers slowly to a discovery request, a timeout occurs. In timeout callback, request should be removed from queues to avoid treating answer if it arrives later. --- drivers/qmimodem/qmi.c | 26

Re: [PATCH] sim: Move atom registration to the end of ofono_sim_register

Hi Slava, On 10/27/2017 08:15 AM, Slava Monich wrote: The state needs to be checked prior to calling __ofono_atom_register because atom registration calls OFONO_ATOM_WATCH_CONDITION_REGISTERED callbacks each of which may call ofono_sim_inserted_notify. Should that happen, by the time

Re: [PATCH] gatchat: Removed unused GAtPPP field

Hi Slava, On 10/26/2017 12:42 PM, Slava Monich wrote: --- gatchat/gatppp.c | 3 --- 1 file changed, 3 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono

Re: [PATCH 2/4] voicecallmanager: Handle last number dialled DBUS call

Hi Philippe, +    v = dial_handle_result(vc, error, NULL, _to_emit); dial_handle_result is a bit tricky because it handles situations where ATD returns immediately and then the call is notified via an unsolicited notification, or ATD returns first. In the case of +BLDN, I believe HFP spec

Re: Ofono 1.21 crashes with Sierra MC7455

Hi, On 10/25/2017 07:38 AM, Eswaran Vinothkumar (BEG/PJ-IOT-EL) wrote: Hello, For our next connectivity project we are planning to use Connman along with oFono The version being used are Connman :1.35 and oFono:1.21 After system start up, I am seeing that the oFono process gets exited,

Re: [PATCH v3] atmodem: Query the list of supported s from the modem

Hi Slava, On 10/23/2017 03:52 PM, Slava Monich wrote: Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 57 --- 1 file changed, 45 insertions(+), 12

Re: [PATCH] gatmux: Remove write watch source at shutdown

Hi Slava, On 10/23/2017 04:05 PM, Slava Monich wrote: Otherwise write_watcher_destroy_notify can be invoked after GAtMux has been deallocated which results in write after free: ==3952== Invalid write of size 4 ==3952==at 0xABF54: write_watcher_destroy_notify (gatmux.c:285) ==3952==by

Re: [PATCH v2] atmodem: Query the list of supported s from the modem

Hi Slava, On 10/23/2017 03:21 PM, Slava Monich wrote: Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 57 --- 1 file changed, 45 insertions(+), 12

Re: [PATCH] gatmux: Remove finalized watches from the list

Hi Slava, On 10/23/2017 04:17 AM, Slava Monich wrote: Leaving them there may result in invalid reads like this: ==2312== Invalid read of size 4 ==2312==at 0xAB8C0: dispatch_sources (gatmux.c:134) ==2312==by 0xAC5D3: channel_close (gatmux.c:479) ==2312==by 0x4AE8885:

Re: [PATCH] atmodem: Query the list of supported s from the modem

Hi Slava, On 10/23/2017 12:57 PM, Slava Monich wrote: Not all modems support all s (particularly, "PS"), let's be polite and not ask them for the ones they don't support. --- drivers/atmodem/sim.c | 69 ++- 1 file changed, 57 insertions(+), 12

Re: [PATCHv2] simauth: Update simauth to handle AUTS parameter

Hi James, On 10/20/2017 01:22 PM, James Prestwood wrote: The support for an invalid SQN number was incomplete in the simauth module. The SIM should have an internal SQN stored (default.xml now) and verify that the SQN in AUTN matches. If not, then generate AUTS and send that back. ---

Re: [PATCH] simauth: Fixed incorrect AUTS length

Hi James, On 10/20/2017 12:40 PM, James Prestwood wrote: The initial SimAuth implementation incorrectly parsed the AUTS value as 16 bytes, not 14. --- src/sim-auth.c | 2 +- src/simutil.c | 9 + 2 files changed, 6 insertions(+), 5 deletions(-) Applied, thanks. Regards, -Denis

Re: [PATCH 3/4] hfpmodem: Send last call dialled request

Hi Philippe, On 10/18/2017 09:04 AM, Philippe De Swert wrote: Handle the last call dialled request and send the required AT+BDLN command for bluetooth HFP profile. --- drivers/hfpmodem/voicecall.c | 22 ++ 1 file changed, 22 insertions(+) diff --git

Re: [PATCH 2/4] voicecallmanager: Handle last number dialled DBUS call

Hi Philippe, On 10/18/2017 09:04 AM, Philippe De Swert wrote: Handle the new DialLast method on the voicecallmanager interface --- src/voicecall.c | 89 + 1 file changed, 89 insertions(+) diff --git a/src/voicecall.c b/src/voicecall.c

Re: Running ofono on Raspberry Pi and SIM800

Hi Arsenijs, Just FYI, we don't top-post on this mailing list. On 10/18/2017 11:40 AM, Pičugins Arsenijs wrote: Thank you, that was a great answer. I'll focus on one part for now: Is it possible for me to run ofono from command-line, without involving udev? I'm asking this because, in my

Re: Running ofono on Raspberry Pi and SIM800

Hi Arsenijs, On 10/18/2017 04:49 AM, Pičugins Arsenijs wrote: Hi! I'm interested in running ofono on a Raspberry Pi (BCM2835, 1GHz), connected to a SIM800 modem over UART (the stable Pi UART, not the MiniUART). I also have RST, DTR and RESET signals connected to the Pi, and for sound I'm

Re: [PATCH 1/1] qmi: support SMS receive on Quectel EC21

On 10/17/2017 06:41 AM, Alexander Couzens wrote: Hi Jonas, Could you explain what you are trying to do here? Why would you clear the SMS storage every time the modem powers up? I also don't see that ofono actually supports deleting messages from the modem's storage... if you know how this is

Re: [PATCH 1/1] qmi: support SMS receive on Quectel EC21

Hi Jonas, On 10/16/2017 07:20 AM, Jonas Bonn wrote: The Quectel EC21 does not provide the SMS PDU on the message event notification. This patch adds a call to 'raw read' on the message ID from the event notification if the event notification does not already contain the message data. The

Re: [PATCHv2] simauth: fixup adding more dbus return checks

Hi James, On 10/16/2017 11:06 AM, James Prestwood wrote: --- src/sim-auth.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

<    3   4   5   6   7   8   9   10   11   12   >