[PATCH 3/4] build: Add n950 plugin to build

2012-05-14 Thread Aki Niemi
--- Makefile.am |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/Makefile.am b/Makefile.am index 9cb490d..2586f5d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -147,6 +147,9 @@ builtin_sources += plugins/isiusb.c builtin_modules += n900 builtin_sources += plugins/n900.c

[PATCH 2/4] n950: Add new plugin for Nokia N950

2012-05-14 Thread Aki Niemi
--- plugins/n950.c | 563 1 files changed, 563 insertions(+), 0 deletions(-) create mode 100644 plugins/n950.c diff --git a/plugins/n950.c b/plugins/n950.c new file mode 100644 index 000..6c9a9da --- /dev/null +++ b/plugins/n950.c @@

[PATCH 4/4] udev: Add bootstrapping for n950 plugin

2012-05-14 Thread Aki Niemi
--- plugins/udev.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 8cb87a5..fe18450 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -278,6 +278,8 @@ done: add_isi(modem, udev_device); else if (g_strcmp0(dri

[PATCH 1/4] n900: Use consistent naming in GPIO API

2012-05-14 Thread Aki Niemi
In addition, add header guards as the API can be used from more than one plugin. --- plugins/n900.c | 12 +++--- plugins/nokia-gpio.c | 106 ++ plugins/nokia-gpio.h | 37 +++-- 3 files changed, 85 insertions(+), 70 deletions(-)

Re: Anyone want to upstraem N950 patches from MeeGo/Mer?

2011-11-24 Thread Aki Niemi
Hi Marko, 2011/11/22 Marko Saukko : > there are some Nokia N950 related ofono patches that never made to the > upstream. I wonder if there is anyone that would be interested of fixing > and upstreaming these? > > The patches seem to apply with minor modification on top of 1.0 tree, > but I'm not s

Re: [PATCH 0/5] isimodem: Add functionality to UICC

2011-08-29 Thread Aki Niemi
Hi Iiro, 2011/8/3 : > This patch adds some functionality to UICC which has been pretty much dummy > so far. > >  Makefile.am  |    3 +- >  drivers/isimodem/debug.c |  121 + >  drivers/isimodem/debug.h |    2 + >  drivers/isimodem/uicc.c  | 1282 The set that I just pushed included

Re: [PATCH 0/3] isimodem: Allow network registration automatically

2011-08-29 Thread Aki Niemi
Hi Iiro, 2011/8/3 : > Network registration is disabled by default. Enable network registration and > roaming  when network is started. > >  drivers/isimodem/debug.c                |    5 ++ >  drivers/isimodem/network-registration.c |   85 > +++ >  drivers/isimodem/n

Re: [PATCH 2/3] isimodem: Allow network registration automatically

2011-08-05 Thread Aki Niemi
Hi Iiro, 2011/8/3 : > diff --git a/drivers/isimodem/network-registration.c > b/drivers/isimodem/network-registration.c > index cc48579..ffcfab4 100644 > --- a/drivers/isimodem/network-registration.c > +++ b/drivers/isimodem/network-registration.c > @@ -946,6 +946,84 @@ error: >        g_free(cbd

Re: Problems ofono 0.45 and Nokia 6760

2011-06-16 Thread Aki Niemi
On Thu, 2011-06-16 at 11:27 +0200, ext Claudio Degioanni wrote: > > So my advice is to simply use DUN via USB ACM interface. So I think the > > nokia driver might work better than the isiusb one in this case. > I'm using embedded tegra2 system, in the past i have tested the > connection on x86 mach

Re: Problems ofono 0.45 and Nokia 6760

2011-06-15 Thread Aki Niemi
Hi Claudio, On Wed, 2011-06-08 at 16:22 +0200, ext Claudio Degioanni wrote: > Error org.ofono.Error.NotAttached: GPRS is not attached Has this been working before? It looks like the network registration status query fails with a SERVICE_NOT_IDENTIFIED service type. My suspicion is that the phone

Re: [PATCH] isimodem: Improper handling of missed call

2011-06-14 Thread Aki Niemi
Hi Arun, 2011/5/30 Arun Ravindran : >> Can you post logs on such a successful case, if you have any around? >> > > tested once again, its working for me. I have attached the log here. > > But here i am using as n900 modem and not as isiusb . It seems to be working for me now using the isiusb plug

Re: build fail with --disable-atmodem

2011-06-01 Thread Aki Niemi
quired to build core, but gets disabled along with atmodem. Maybe Marcel or Denis could take a look at that patch (reattaching it here). Cheers, Aki >From 1920b813a4db120f0d6692e9d4d86f3fe313a263 Mon Sep 17 00:00:00 2001 From: Aki Niemi Date: Thu, 24 Mar 2011 17:30:12 +0200 Subject: [PATCH] bui

Re: [PATCH] isimodem: Improper handling of missed call

2011-05-30 Thread Aki Niemi
Hi Arun, 2011/5/23 Arun Ravindran : > @@ -548,9 +555,26 @@ static void isi_call_notify(struct ofono_voicecall *ovc, > struct isi_call *call) > >        case CALL_STATUS_MO_RELEASE: >        case CALL_STATUS_MT_RELEASE: > -       case CALL_STATUS_TERMINATED: > +               /* > +              

Re: [PATCH] isimodem: Improper handling of missed call

2011-05-19 Thread Aki Niemi
Hi Arun, 2011/5/18 Arun Ravindran : > +       case CALL_STATUS_MT_RELEASE: > +               if ((call->prev_status == CALL_STATUS_MT_ALERTING) || > +                               (call->prev_status == CALL_STATUS_COMING) || > +                               (call->prev_status == CALL_STATUS_WAIT

Re: [PATCH] isiusb: wait for MTC transitions, too

2011-04-19 Thread Aki Niemi
Hi Pekka, 2011/4/18 : > From: Pekka Pessi > > --- >  plugins/isiusb.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) Patch has been pushed, thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofon

Re: [PATCH] isimodem: notify sms-status-reports, too

2011-04-12 Thread Aki Niemi
Hi Pekka, 2011/4/12 : > From: Pekka Pessi > > --- >  drivers/isimodem/sms.c |   11 ++- >  1 files changed, 10 insertions(+), 1 deletions(-) I actually ended up pushing a fix for this as part of the wgmodem2.5 additions. Thanks anyway! Cheers, Aki ___

Re: [PATCH] isimodem: fix call_create_resp handling

2011-04-12 Thread Aki Niemi
Hi Pekka, 2011/4/12 : > From: Pekka Pessi > > In case of call creation failure modem may return a valid call id in > order to send CALL_SERVICE_DENIED_IND which we do not handle. > > Fixes MeeGo bug#15855. > --- >  drivers/isimodem/voicecall.c |   39 +-- >  1

Re: [PATCH] isimodem:Remove reporting active state wrongly

2011-04-07 Thread Aki Niemi
Hi Arun, 2011/4/5 : > From: Arun Ravindran > > --- >  drivers/isimodem/voicecall.c |    5 - >  1 files changed, 4 insertions(+), 1 deletions(-) Patch has been applied, with minor tweaks to the commit message. Thanks! Cheers, Aki ___ ofono mailing

Re: [PATCH] isimodem:hangupall failed for hold initiated call

2011-04-07 Thread Aki Niemi
Hi Arun, 2011/4/5 : > From: Arun Ravindran > > --- >  drivers/isimodem/voicecall.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) Patch has been applied with minor tweak to the commit message. Thanks! Cheers, Aki ___ ofono mailing list

[PATCH] build: Add gatchat to core sources

2011-03-24 Thread Aki Niemi
Otherwise, --disable-atmodem breaks build. --- Makefile.am |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/Makefile.am b/Makefile.am index b0cbcd7..39d8962 100644 --- a/Makefile.am +++ b/Makefile.am @@ -154,8 +154,7 @@ endif if ATMODEM builtin_modules += atmode

Re: [PATCH 1/2] isimodem/sim: added PIN and SIM state handling

2011-03-24 Thread Aki Niemi
Hi Pekka, 2011/3/24 : > From: Pekka Pessi > > Using PN_SECURITY resource to obtain PIN statuses. > > Using ofono_sim_ready_notify() aka __ofono_sim_recheck_pin() to report > the ready state. > --- >  drivers/isimodem/debug.c |   59 + >  drivers/isimodem/debug.h |    6 + >  drivers/isimodem/s

Re: [PATCH 1/1] isimodem: fix network registration for older modems

2011-03-24 Thread Aki Niemi
Hi Mika, 2011/3/24 Mika Liljeberg : > --- >  drivers/isimodem/network-registration.c |   10 -- >  1 files changed, 8 insertions(+), 2 deletions(-) Patch has been pushed. Thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.of

Re: [RESEND 3 PATCH 00/13] IPv6 Support

2011-03-21 Thread Aki Niemi
Hi Denis, 2011/3/18 Denis Kenzior : > Unfortunately that ship has sailed.  Every vendor except Nokia uses AT > command modems, or at least implements a (somewhat) full-featured AT > backend. Not quite the way I see things. There are notable exceptions to this, for example, Qualcomm modems don't u

Re: [PATCH] Isimodem: Crash while setting SCA

2011-03-14 Thread Aki Niemi
Hi Denis, 2011/3/11 Denis Kenzior : >> diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c >> index 957b342..c90c06d 100644 >> --- a/drivers/isimodem/sms.c >> +++ b/drivers/isimodem/sms.c >> @@ -292,7 +292,7 @@ static void isi_sca_set(struct ofono_sms *sms, >>               { &sd->params,

RE: [PATCH] atmodem: Enable network time for AT modem

2011-03-08 Thread Aki Niemi
Hi Jeevaka, On Tue, 2011-03-08 at 12:35 +0200, ext jeevaka.badrap...@elektrobit.com wrote: > This log is taken some time back. Possible that Network Daylight Saving > Time is received as part of the MM information message whereas > it may not be in your case. If my memory serves, DST is optional

Re: [PATCH] gisi: M6 coding style violation corrections

2011-03-04 Thread Aki Niemi
Hi Antti, 2011/3/4 Antti Paila : > --- >  gisi/iter.c |   16 >  1 files changed, 8 insertions(+), 8 deletions(-) Patch has been pushed. Thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/5] cell-info: Atom for neighbor cell info

2011-03-03 Thread Aki Niemi
Hi Antti, 2011/2/14 Antti Paila : > --- >  src/cell-info.c |  475 > +++ >  1 files changed, 475 insertions(+), 0 deletions(-) >  create mode 100644 src/cell-info.c > > diff --git a/src/cell-info.c b/src/cell-info.c > new file mode 100644 > index

Re: [PATCH v2] isimodem: removed unused NETWORK_TIMEOUT

2011-03-03 Thread Aki Niemi
Hi George, 2011/3/1 George Matveev : > --- >  drivers/isimodem/network.h |    1 - >  1 files changed, 0 insertions(+), 1 deletions(-) Patch has been applied. Thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofo

Re: [PATCH] isiusb: add message-waiting

2011-03-03 Thread Aki Niemi
Hi Jukka, 2011/3/3 Jukka Saunamaki : > --- >  plugins/isiusb.c |    5 + >  1 files changed, 5 insertions(+), 0 deletions(-) Pushed, thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] gisi: Consumer functions for ISI message iterator

2011-03-03 Thread Aki Niemi
Hi Antti, 2011/3/3 Antti Paila : >  struct _GIsiSubBlockIter { > +       uint8_t cursor; >        uint8_t *start; >        uint8_t *end; >        gboolean longhdr; The cursor actually needs to be 16 bits, because when the long header format is in use, that is what subblock length uses. I pushe

Re: [PATCH v2 13/18] isimodem: wgmodem2.5 added to call-forwarding

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/call-forwarding.c |   29 + >  1 files changed, 25 insertions(+), 4 deletions(-) Patch has been applied. Some refactoring after the fact, though. Cheers, Aki ___

Re: [PATCH v2 14/18] isimodem: wgmodem2.5 added to ssn

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/call-forwarding.c |    1 - >  drivers/isimodem/ssn.c             |  406 > +++- >  2 files changed, 401 insertions(+), 6 deletions(-) I applied this patch, but had to do some heavy

Re: [PATCH v2 12/18] isimodem: SS_GSM_BARRING_INFO added

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > SS_GSM_BSC_INFO added. > --- >  drivers/isimodem/call-barring.c |   99 ++ >  1 files changed, 88 insertions(+), 11 deletions(-) Patch was applied, with some refactoring done afterwards. Cheers, Aki __

Re: [PATCH v2 10/18] isimodem: wgmodem2.5 added to voicecall

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/call.h      |   82 - >  drivers/isimodem/voicecall.c |  218 > +- >  2 files changed, 253 insertions(+), 47 deletions(-) Patch was applied with some refactor

Re: [PATCH v2 11/18] isimodem: wgmodem2.5 support in USSD

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/ussd.c |   36 ++-- >  1 files changed, 30 insertions(+), 6 deletions(-) Patch has been pushed, with some refactoring done afterwards. The N900 modem handles padding fine, so might a

Re: [PATCH v2 09/18] isimodem: clip colp clir colr wgmodem2.5

2011-03-03 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/call-settings.c |  711 > +- >  drivers/isimodem/call.h          |    9 + >  drivers/isimodem/debug.c         |    4 + >  drivers/isimodem/ss.h            |   22 ++ >  4 files ch

Re: [PATCH 1/1] isimodem: group timeouts in enum, remove unused timeout

2011-03-01 Thread Aki Niemi
Hi George, 2011/2/6 George Matveev : > Introduce enum network_timeout for scan/registration timeouts, > remove unused NETWORK_TIMEOUT. > --- >  drivers/isimodem/network.h |    8 +--- >  1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/isimodem/network.h b/drivers/isimo

Re: ofono patch review policy?

2011-03-01 Thread Aki Niemi
Hi George, 2011/3/1 George Matveev : > on February 6, I submitted a patch (isimodem): > > http://lists.ofono.org/pipermail/ofono/2011-February/008635.html > > But it is already March and the patch has never been reviewed nor formally > rejected. Sorry, I had missed that. > Other people had asked

Re: [PATCH v2 15/18] isimodem: code points for sms wgmodem2.5

2011-02-25 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/debug.c |   56 > ++ >  drivers/isimodem/debug.h |    1 + >  drivers/isimodem/sms.h   |   34 >  3 files changed, 91 insertions(+), 0 deletion

Re: [PATCH v2 07/18] isimodem: code points uicc sim wgmodem2.5

2011-02-25 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  Makefile.am              |    4 +- >  drivers/isimodem/debug.c |   84 +++ >  drivers/isimodem/debug.h |    1 + >  drivers/isimodem/uicc.h  |  265 > ++ >  4 files changed, 353

Re: [PATCH v2 06/18] src: add missing SIM enum to simutil.h

2011-02-25 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  src/simutil.h |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) Applied this patch with minor tweak of the commit message. Cheers, Aki ___ ofono mailing list ofono@ofono.org

Re: [PATCH v2 04/18] plugins: add u8500 to udev

2011-02-25 Thread Aki Niemi
Hi, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  plugins/ofono.rules |    3 +++ >  plugins/udev.c      |    2 ++ >  2 files changed, 5 insertions(+), 0 deletions(-) Patch applied. Thanks! Cheers, Aki ___ ofono mailing list ofono@ofono

Re: [PATCH v2 03/18] plugins: add plugin for u8500

2011-02-23 Thread Aki Niemi
Hi Andreas, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  Makefile.am     |    3 + >  plugins/u8500.c |  708 > +++ >  2 files changed, 711 insertions(+), 0 deletions(-) >  create mode 100644 plugins/u8500.c I pushed this patch,

Re: [PATCH v2 02/18] isimodem: added codepoints for u8500

2011-02-23 Thread Aki Niemi
Hi Andreas, 2011/2/23 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/debug.c |    1 + >  drivers/isimodem/info.h  |    3 +++ >  2 files changed, 4 insertions(+), 0 deletions(-) Patch has been pushed. Thanks. Cheers, Aki ___ ofono

Re: [PATCH 11/18] isimodem: gprs-context updates wgmodem2.5

2011-02-18 Thread Aki Niemi
Hi, 2011/2/15 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/gprs-context.c |   95 +- >  1 files changed, 62 insertions(+), 33 deletions(-) > > diff --git a/drivers/isimodem/gprs-context.c b/drivers/isimodem/gprs-context.c > index 6d579d8.

Re: [PATCH 09/18] isimodem: clip colp clir colr wgmodem2.5

2011-02-18 Thread Aki Niemi
Hi Andreas, 2011/2/15 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/call-settings.c |  697 > +- >  drivers/isimodem/call.h          |    9 + >  drivers/isimodem/debug.c         |    4 + >  drivers/isimodem/ss.h            |   22 ++ >  4

Re: [PATCH 16/18] isimodem: sms updated with wgmodem2.5

2011-02-17 Thread Aki Niemi
Hi Andreas, 2011/2/16 Andreas WESTIN : >> This UICC stuff seems to be leftovers form patch 8/18. > > Well they are related to SMS, debug prints. But yes they are also UICC. Do > you want them in patch 8 ? That would be my preference. That is, a patch to bring in the PN_UICC codepoints and debugs,

Re: [PATCH 05/18] plugins: add plugin for u8500

2011-02-17 Thread Aki Niemi
Hi Andreas, 2011/2/16 Andreas WESTIN : >>> +       if (!g_isi_modem_set_version(isimodem, modemversion)) >>> +               return -EINVAL; >> >> I'm not going to add this API in GIsiModem. If we went this route, and >> used vendor quirks inside the isimodem driver, then it would make a >> whole

Re: [PATCH 05/18] plugins: add plugin for u8500

2011-02-16 Thread Aki Niemi
Hi, 2011/2/15 Andreas Westin : > +static int u8500_probe(struct ofono_modem *modem) > +{ > +       const char *ifname = ofono_modem_get_string(modem, "Interface"); > +       unsigned address = ofono_modem_get_integer(modem, "Address"); > +       GIsiModem *isimodem; > +       GIsiClient *client =

Re: [PATCH 16/18] isimodem: sms updated with wgmodem2.5

2011-02-16 Thread Aki Niemi
Hi, 2011/2/15 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/debug.c |   56 +++ >  drivers/isimodem/debug.h |    1 + >  drivers/isimodem/sms.c   |  972 > +++--- >  drivers/isimodem/sms.h   |   34 ++ >  4 files changed, 927 insertions(

Re: [PATCH 07/18] isimodem: add wgmodem2.5 to devinfo

2011-02-16 Thread Aki Niemi
Hi, 2011/2/15 Andreas Westin : > @@ -111,17 +115,22 @@ static void isi_query_manufacturer(struct ofono_devinfo > *info, >        struct devinfo_data *dev = ofono_devinfo_get_data(info); >        struct isi_cb_data *cbd = isi_cb_data_new(dev, cb, data); > > +       if (cbd == NULL || dev == NULL)

Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5

2011-02-16 Thread Aki Niemi
Hi Andreas, 2011/2/16 Andreas WESTIN : > Tested and works fine, will submit a new patch for the u8500 plugin. This is > not done in the n900 plugin though, perhaps not necessary ? The default is PN_DEV_HOST, which is what the N900 uses. Cheers, Aki ___

Re: [PATCH 03/18] isimodem: general build updates for wgmodem2.5

2011-02-16 Thread Aki Niemi
Hi, 2011/2/15 Andreas Westin : > From: Jessica Nilsson > > --- >  drivers/isimodem/debug.c |   48 > ++ >  drivers/isimodem/debug.h |    8 +++ >  drivers/isimodem/mtc.h   |   38 >  3 files changed, 94 insertions(

Re: [PATCH 04/18] gisi: fix subscription for wgmodem2.5

2011-02-16 Thread Aki Niemi
Hi Andreas, 2011/2/15 Andreas Westin : >                if (legacy) >                        msg[3 + count] = mux->resource; > -               else > +               else { >                        /* Resource field is 32bit and Little-endian */ >                        msg[4 + count * 4 + 3] = mu

Re: [PATCH] TODO: Add vCard export to SM/ME stores

2011-02-09 Thread Aki Niemi
Hi Marcel, 2010/11/23 Marcel Holtmann : >> So the aa{sv} parameter/return value would be of format: >> { >>   'name'    : string, >>   'group'   : string,   // optional, for eg. organization >>   'hidden'  : integer,  // boolean value: defaults to 0 >>   'numbers' : array of dict { >>     'number'

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-08 Thread Aki Niemi
Hi, 2011/2/1 Aki Niemi : > I'm starting to think me just saying this out loud is not concrete > enough, so I guess one way forward here could be for me to go ahead and > adapt e.g. the netreg driver to work with N900 and later ISI modems. The > netreg driver would make a good

Re: [PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

2011-02-07 Thread Aki Niemi
Hi, 2011/2/4 Aki Niemi : > This is problematic, since there is no version query by default for > the PN_COMMGR because creating the GIsiModem is not async. Also, even > the N900 modem supports both of these INDs, but the > PNS_SUBSCRIBED_RESOURCES_EXTEND_IND is blocked by a modem sid

[PATCH 1/2 v2] netreg: Add CPHS CSP implementation

2011-02-04 Thread Aki Niemi
--- src/network.c | 122 1 files changed, 96 insertions(+), 26 deletions(-) diff --git a/src/network.c b/src/network.c index bf61472..07f9cdf 100644 --- a/src/network.c +++ b/src/network.c @@ -42,7 +42,8 @@ enum network_registration_mod

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-04 Thread Aki Niemi
Hi Andreas, 2011/2/3 Andreas WESTIN : >> I don't see what that has to do with the device supporting the "PC >> suite" USB profile, which allows modem access using cdc_phonet. > > Currently our platform does not support this. Well, I know of platforms that do, and have different versions of ISI mo

Re: [PATCH 1/1] gisi: Updated subscriptions and pipe handling to accomodate additional isimodem versions

2011-02-04 Thread Aki Niemi
Hi Rémi, 2011/1/28 Rémi Denis-Courmont : > On Friday 28 January 2011 13:37:10 ext Jessica Nilsson, you wrote: >> diff --git a/gisi/common.h b/gisi/common.h >> index 83a8cf5..c78f893 100644 >> --- a/gisi/common.h >> +++ b/gisi/common.h >> @@ -26,6 +26,8 @@ >>  extern "C" { >>  #endif >> >> +#define

Re: [PATCH 1/2] netreg: Add CPHS CSP implementation

2011-02-03 Thread Aki Niemi
Hi Denis, 2011/2/3 Denis Kenzior : >> +     if (netreg->mode == NETWORK_REGISTRATION_MODE_AUTO_ONLY) >> +             return NULL; >> + > > So we might just return access_denied here as well. There is a reason for allowing this, namely that sometimes you want to re-run the logic for automatically

Re: [PATCH 2/6] smsutil: Remove dialect checks from caller

2011-02-03 Thread Aki Niemi
Hi Denis, 2011/2/3 Denis Kenzior : >>                       converted = convert_gsm_to_utf8_with_lang(buf, written, >>                                                               NULL, NULL, 0, >>                                                               locking_shift, > > I'm pretty sure yo

Re: [PATCH 1/4] nettime: Network time plugin implementation

2011-02-03 Thread Aki Niemi
Hi Antti, 2011/2/1 Antti Paila : > --- >  plugins/nettime.c |  326 > + >  1 files changed, 326 insertions(+), 0 deletions(-) >  create mode 100644 plugins/nettime.c > > diff --git a/plugins/nettime.c b/plugins/nettime.c > new file mode 100644 >

Re: [PATCHv2] doc: Assisted Satellite Navigation API and Agent API

2011-02-03 Thread Aki Niemi
Hi Sjur and Simon, 2011/1/30 Sjur Brændeland : > +PositioningRequestAgent hierarchy > +== > + > +Service                unique name > +Interface      org.ofono.PositioningRequestAgent > +Object path    freely definable > + > +Methods                void Request(stri

Re: [sim-ready-nofify-v4 PATCH 1/3] sim: add ofono_sim_ready_notify

2011-02-03 Thread Aki Niemi
Hi Pekka, 2011/1/12 : > @@ -1627,6 +1630,8 @@ static void sim_efphase_read_cb(int ok, int length, int > record, > >  static void sim_initialize_after_pin(struct ofono_sim *sim) >  { > +       sim->flags &= SIM_FLAG_WAIT_FOR_READY; > + You want to unset the flag here, no? Otherwise this looks g

[PATCH 1/2] netreg: Add CPHS CSP implementation

2011-02-03 Thread Aki Niemi
--- src/network.c | 121 1 files changed, 95 insertions(+), 26 deletions(-) diff --git a/src/network.c b/src/network.c index bf61472..ef0b37f 100644 --- a/src/network.c +++ b/src/network.c @@ -42,7 +42,8 @@ enum network_registration_mod

[PATCH 2/2] TODO: Remove completed CPHS CSP task

2011-02-03 Thread Aki Niemi
. Also to accommodate this, there - probably needs to be a new 'forced' mode to indicate that manual network - selection is disabled. - - Priority: Medium - Complexity: C1 - Owner: Aki Niemi - - Support SIM authentication: SIM and AKA suites. Priori

[PATCH 6/6] doc: Add documentation for Alphabet property

2011-02-03 Thread Aki Niemi
--- doc/message-api.txt | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/doc/message-api.txt b/doc/message-api.txt index 1c68aee..d5a7b15 100644 --- a/doc/message-api.txt +++ b/doc/message-api.txt @@ -24,3 +24,17 @@ Properties string State

[PATCH 5/6] sms: Add alphabet support to SMS atom

2011-02-03 Thread Aki Niemi
--- src/sms.c | 91 +++- 1 files changed, 89 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 73e067e..bb94b3d 100644 --- a/src/sms.c +++ b/src/sms.c @@ -77,6 +77,7 @@ struct ofono_sms { GKeyFile *settings;

[PATCH 2/6] smsutil: Remove dialect checks from caller

2011-02-03 Thread Aki Niemi
--- src/smsutil.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 1762391..5c1ae4c 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -2267,16 +2267,6 @@ char *sms_decode_text(GSList *sms_list) sms_extrac

[PATCH 4/6] smsutil: Add alphabet support to encoding

2011-02-03 Thread Aki Niemi
--- src/smsutil.c | 53 ++--- src/smsutil.h | 12 2 files changed, 58 insertions(+), 7 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 5c1ae4c..3fd3397 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -3514,9 +3514,10

[PATCH 3/6] util: Add best dialect picker API

2011-02-03 Thread Aki Niemi
--- src/util.c | 64 src/util.h |7 ++ 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/src/util.c b/src/util.c index 547f38c..e1e8a0a 100644 --- a/src/util.c +++ b/src/util.c @@ -788,6 +788,70 @@ unsigned char *

[PATCH 1/6] util: Refactor conversion table handling

2011-02-03 Thread Aki Niemi
--- src/util.c | 205 +--- src/util.h |1 - 2 files changed, 126 insertions(+), 80 deletions(-) diff --git a/src/util.c b/src/util.c index f63ce67..547f38c 100644 --- a/src/util.c +++ b/src/util.c @@ -3,6 +3,7 @@ * oFono - Open Sourc

[PATCH 0/6] Add alphabet support to SMS

2011-02-03 Thread Aki Niemi
Hi, This is a set resurrected from last year, adding support for different GSM alphabets or dialects when sending SMSs. The first two patches do some refactoring that allows buidling also custom GSM alphabets such as a combination of single shift and locking shift tables of different GSM alphabet

Re: [PATCH 1/2] isimodem: fix problems in call state reporting

2011-02-03 Thread Aki Niemi
Hi Pekka, 2011/2/2 : > From: Pekka Pessi > > Do not report early incoming calls. > > Report "disconnected" state separately. > > Call ofono_voicecall_disconnected() only after call id is released. > --- >  drivers/isimodem/voicecall.c |   84 > ++ >  1 fil

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-02 Thread Aki Niemi
On Wed, 2011-02-02 at 10:03 +0100, ext Andreas WESTIN wrote: > On 2011-02-01 20:32, Aki Niemi wrote: > > Like I replied earlier, I don't see the need for this. Also, it will not > > work well with the isiusb plugin, which has the potential to work with > > any ISI modem

Re: [PATCH] isimodem: fix crash in sms driver

2011-02-01 Thread Aki Niemi
Hi Pekka, On Tue, 2011-02-01 at 22:37 +0200, ext pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > drivers/isimodem/sms.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Pushed this patch, thanks for spotting the problem. Cheers, Aki ___

Re: [PATCH 0/3] EF-SPN API to sim-atom

2011-02-01 Thread Aki Niemi
Hi Denis, On Tue, 2011-02-01 at 09:14 -0600, ext Denis Kenzior wrote: > > does it really matter in the end? It gets read once and after that we > > are caching it on disk anyway. > > > > Of course it does, while SIM is initializing everything else is blocked. > Once we're in sim ready you can h

Re: Selecting multiple radio access technologies in oFono

2011-02-01 Thread Aki Niemi
Hi Paavo, On Mon, 2011-01-31 at 15:59 +0200, ext Paavo Leinonen wrote: > Could it be possible to extend current TechnologyPreference setting in > radio-settings-api in a way which would enable user to limit usage of > certain > radio accesses? For example user could choose to limit technology usa

Re: [PATCH] TODO: SMS Validity Period

2011-02-01 Thread Aki Niemi
Hi Marcel, On Mon, 2011-01-31 at 13:42 +0100, ext Marcel Holtmann wrote: > > > How does a normal user actually know what this means for him and the > > > network he is using? Is the network actually honoring these values at > > > all these days? > > > > These are not clear to me either, so I don'

RE: [PATCH 3/4] nettime: Documentation

2011-02-01 Thread Aki Niemi
Hi Jeevaka, On Tue, 2011-02-01 at 16:54 +0200, ext jeevaka.badrap...@elektrobit.com wrote: > > + int32 DST [optional] > > + Current daylight saving setting in > > + hours. > > few hours back I delivered a patch for converting t

Re: [PATCH v2 3/3] isimodem: header updates for ISI2.5

2011-02-01 Thread Aki Niemi
Hi Marcel, On Tue, 2011-02-01 at 16:43 +0100, ext Marcel Holtmann wrote: > > +enum isi_version { > > + ISI_20 = 0, > > + ISI_25 = 1 > > +}; > > so what is the final decision here now. ISI doing auto-detection and > this gets not exposed to the modem drivers or we do. Like I replied earlier,

Re: [PATCH] Phonesim HACKING updated to refer to phonesim.conf instead of modem.conf.

2011-02-01 Thread Aki Niemi
Hi Essi, 2011/2/1 Essi Vehmersalo : > -automatically includes this option. > +automatically includes this option. See phonesim.conf sample configuration > +under ofono/plugins on how to configure oFono to use phonesim. > >   Run phonesim in foreground using the following options >     # ./src/phon

Re: [PATCH] TODO: SMS Validity Period

2011-01-31 Thread Aki Niemi
Hi Marcel, 2011/1/31 Marcel Holtmann : > How does a normal user actually know what this means for him and the > network he is using? Is the network actually honoring these values at > all these days? These are not clear to me either, so I don't see the point in exposing this setting over the D-Bu

Re: [PATCH] n900: fix set online

2011-01-27 Thread Aki Niemi
Hi Kai, 2011/1/27 Kai Vehmanen : > Invalid MTC_STATE_REQ messages were sent, causing failures in going > online. > --- >  plugins/n900.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) Pushed, thanks! Cheers, Aki ___ ofono mailing list of

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann : > can you have a stab at this and check how a patch would look like if we > just add another mode. If I am not mistaken we only have the extra code > in the init_registration_status. I could be wrong here since I have not > looked through that code in a long

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann : >> That is how I originally had it, but this ends up being a bit less >> code. Also, I'd like to localize all of these constant strings into a >> single function and not sprinkle them across the code. > > so I am counting two callers to registration_mode_to_s

Re: [gprs-provision RFCPATCHv6 0/4] Plugin API for provisioning of GPRS context settings

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann : > lets get this merged without support for SPN for now. We can easily add > this later. So please fix Denis' comments and re-submit this without the > SPN change. > > Andrew is currently looking into fixing the SIM reading race. Once that > is done we can tac

Re: [PATCH 0/4] Add support for CPHS customer service profile

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann : >> > one open question here is still if we also have to disallow scanning >> > when this is set? >> > >> > So we might wanna update the Scan() and Register() method with the >> > proper error codes and put a note in there for mode = "auto-only". >> >> Good po

Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann : >> diff --git a/src/network.c b/src/network.c >> index b5450ee..64734d0 100644 >> --- a/src/network.c >> +++ b/src/network.c >> @@ -64,6 +64,7 @@ struct ofono_netreg { >>       int cellid; >>       int technology; >>       int mode; >> +     gboolean forced_a

Re: [PATCH 0/4] Add support for CPHS customer service profile

2011-01-26 Thread Aki Niemi
Hi Marcel, 2011/1/26 Marcel Holtmann : > one open question here is still if we also have to disallow scanning > when this is set? > > So we might wanna update the Scan() and Register() method with the > proper error codes and put a note in there for mode = "auto-only". Good point, it's also missi

[PATCH 4/4] TODO: Remove completed CPHS CSP task

2011-01-26 Thread Aki Niemi
. Also to accommodate this, there - probably needs to be a new 'forced' mode to indicate that manual network - selection is disabled. - - Priority: Medium - Complexity: C1 - Owner: Aki Niemi - - Support SIM authentication: SIM and AKA suites. Priori

[PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation

2011-01-26 Thread Aki Niemi
--- src/network.c | 75 ++-- 1 files changed, 72 insertions(+), 3 deletions(-) diff --git a/src/network.c b/src/network.c index b5450ee..64734d0 100644 --- a/src/network.c +++ b/src/network.c @@ -64,6 +64,7 @@ struct ofono_netreg { int

[PATCH 3/4] doc: Add documentation for 'auto-only' mode

2011-01-26 Thread Aki Niemi
--- doc/network-api.txt | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/doc/network-api.txt b/doc/network-api.txt index 75187cd..2f13a9c 100644 --- a/doc/network-api.txt +++ b/doc/network-api.txt @@ -69,18 +69,21 @@ Properties string Mode [readonly]

[PATCH 1/4] simutil: Add EFcsp file and service group IDs

2011-01-26 Thread Aki Niemi
--- src/simutil.h | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 463540b..a5a683b 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -37,6 +37,7 @@ enum sim_fileid { SIM_EFIMSI_FILEID = 0x6F07,

[PATCH 0/4] Add support for CPHS customer service profile

2011-01-26 Thread Aki Niemi
Hi all, This series adds support for CPHS CSP PLMN mode into the netreg atom. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[RFC 3/6] build: Add main.conf to the build

2011-01-26 Thread Aki Niemi
--- Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index f941a19..02ea2cb 100644 --- a/Makefile.am +++ b/Makefile.am @@ -35,7 +35,7 @@ endif confdir = $(sysconfdir)/ofono -conf_DATA = +conf_DATA = src/main.conf statedir = $

[RFC 4/6] conf: Add ref number setting for MessageManager

2011-01-26 Thread Aki Niemi
--- src/main.conf |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/main.conf b/src/main.conf index facb950..0b23998 100644 --- a/src/main.conf +++ b/src/main.conf @@ -2,3 +2,9 @@ # List of plugins that should not be loaded on oFono startup #DisablePlugins = + +

[RFC 6/6] sms: Use main configuration for 16bit ref number

2011-01-26 Thread Aki Niemi
--- src/sms.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7224bdf..48d2d81 100644 --- a/src/sms.c +++ b/src/sms.c @@ -842,7 +842,6 @@ static DBusMessage *sms_send_message(DBusConnection *conn, DBusMessage *msg, GSList *msg_list;

[RFC 2/6] conf: Add bare bones configuration file

2011-01-26 Thread Aki Niemi
--- src/main.conf |4 1 files changed, 4 insertions(+), 0 deletions(-) create mode 100644 src/main.conf diff --git a/src/main.conf b/src/main.conf new file mode 100644 index 000..facb950 --- /dev/null +++ b/src/main.conf @@ -0,0 +1,4 @@ +[General] + +# List of plugins that should no

  1   2   3   4   >