Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-20 Thread Larry Gritz
I think this will fix the buf.reset issue: https://github.com/OpenImageIO/oiio/pull/1492 > On Sep 20, 2016, at 11:37 AM, Larry Gritz wrote: > > My bad, I think the reset line, > > buf.reset ("myrawfile.cr2",

Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-20 Thread Larry Gritz
In that case -- and considering that the code is plainly setting the parameter passed to libraw and I don't know what else I would do -- I'm going to consider that a "LGTM" and merge the fix. > On Sep 20, 2016, at 1:12 PM, Haarm-Pieter Duiker > wrote: > > "they seem

Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-20 Thread Larry Gritz
My bad, I think the reset line, buf.reset ("myrawfile.cr2", config=cfg) will work if instead you write: buf.reset ("myrawfile.cr2", 0, 0, cfg) I think I neglected to add the right instructions to let it understand the default arguments and parameter names. I'll submit a separate patch

Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-19 Thread Larry Gritz
HP, does this look right to you? > On Sep 14, 2016, at 8:20 PM, Larry Gritz wrote: > > How does this look? https://github.com/OpenImageIO/oiio/pull/1490 > > > >> On Sep 13, 2016, at 9:41 PM, Haarm-Pieter Duiker

Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-14 Thread Larry Gritz
How does this look? https://github.com/OpenImageIO/oiio/pull/1490 > On Sep 13, 2016, at 9:41 PM, Haarm-Pieter Duiker > wrote: > > It looks like that 'adjust_maximum_thr' should be set to 0.0 generally. The > comment

Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-13 Thread Haarm-Pieter Duiker
It looks like that 'adjust_maximum_thr' should be set to 0.0 generally. The comment from the libRaw changelog is as follows: " * dcraw_emu's -c parameter now wants numeric (float) argument. This value is assigned to params.adjust_maximum_thr. Use -c 0.0 for

Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-13 Thread Kevin Wheatley
So here are the kinds of things we do... // Setup as much as possible to mean linear 16 bit RawProcessor.imgdata.params.output_bps = 16; RawProcessor.imgdata.params.gamm[0] = 1; RawProcessor.imgdata.params.gamm[1] = 1; RawProcessor.imgdata.params.no_auto_bright = 1;

Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-13 Thread Haarm-Pieter Duiker
After digging into a bit more, the dcraw flags that the current rawinput libRaw calls correspond to are: - -o - Choose the output colorspace - -6 - Set up 16 bit processing - -g 1 1 - Set the gamma curves to 1, 1 I'd suggest we add API calls corresponding to two more

Re: [Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-12 Thread Larry Gritz
There are certainly some things we want a reader to do automatically before the data is passed through OIIO to the calling app -- uncompress, de-bayerization, making equal resolution for all color channels, converting to some kind of RGB-based color space, converting to one of the standard

[Oiio-dev] libRaw/dcraw 'auto_bright' changing raw image exposure

2016-09-10 Thread Haarm-Pieter Duiker
Hello, I've been running into an issue with the OIIO libRaw support and wanted to see if anyone else had run into the same problem and found a workaround. The issue Raw files read and developed by OIIO using libRaw are automatically brightened. The potential cause tl;dr The RawInput::open