Re: [Oorexx-devel] dependency on svn

2019-09-17 Thread Enrico Sorichetti via Oorexx-devel 
As a temporary workaround for what I feel is a overly complicated repository 
setup

Subversion_WC_INFO(${PROJECT_SOURCE_DIR} ORX IGNORE_SVN_FAILURE )

Enrico

> On 17 Sep 2019, at 13:44, Rick McGuire  wrote:
> 
> I'm open to other suggestions. I at least solves part of the problem, but is 
> perhaps incomplete. Do you have another other suggestions on how to test for 
> this?
> 
> Rick
> 
> On Tue, Sep 17, 2019 at 6:51 AM Erich Steinböck  > wrote:
> > if( EXISTS ${CMAKE_SOURCE_DIR}/.svn )
> I don't think this is a good solution, as it depends on how you check out 
> sources.
> If you check out main/trunk, main/trunk/.svn will exist
> But if you check out main, no main/trunk/.svn will exist (only main/.svn)
> 
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net 
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel 
> 
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel

___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Re: [Oorexx-devel] dependency on svn

2019-09-17 Thread Rick McGuire 
I'm open to other suggestions. I at least solves part of the problem, but
is perhaps incomplete. Do you have another other suggestions on how to test
for this?

Rick

On Tue, Sep 17, 2019 at 6:51 AM Erich Steinböck 
wrote:

> > if( EXISTS ${CMAKE_SOURCE_DIR}/.svn )
> I don't think this is a good solution, as it depends on how you check out
> sources.
> If you check out main/trunk, main/trunk/.svn will exist
> But if you check out main, no main/trunk/.svn will exist (only main/.svn)
>
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>
___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Re: [Oorexx-devel] dependency on svn

2019-09-17 Thread Erich Steinböck 
> if( EXISTS ${CMAKE_SOURCE_DIR}/.svn )
I don't think this is a good solution, as it depends on how you check out
sources.
If you check out main/trunk, main/trunk/.svn will exist
But if you check out main, no main/trunk/.svn will exist (only main/.svn)
___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread Enrico Sorichetti via Oorexx-devel 
Hi René

Use

if( EXISTS ${CMAKE_SOURCE_DIR}/.svn )
find_package(Subversion)
if(SUBVERSION_FOUND)
set(ORX_WC_REVISION 0)
Subversion_WC_INFO(${PROJECT_SOURCE_DIR} ORX)
set(ORX_BLD_LVL ${ORX_WC_REVISION})
endif()
message(STATUS "SVN Revision Number is ${ORX_BLD_LVL}")
endif()



Best regards 
Enrico


> On 13 Sep 2019, at 16:59, René Jansen  wrote:
> 
> Hi Enrico,
> 
> can you make it so that cmake does not choke on an absent svn? Working 
> revisions on git is a bonus but I don’t really need that - and they are uuids.
> I’m all for git, in fact this is one of the last svn instances I pull from. 
> But I don’t want to start that discussion, I just want to get rid of the 
> dependency (which in my view, is wrong). 
> If you can make that happen, that would be great. For now, I just edit it out 
> but will leave it in the svn repo.
> 
> In NetRexx, we generate the revision as a timestamp, and a build number to a 
> file and pick that up, and we made the change to git some years ago without 
> even noticing.
> 
> best regards,
> 
> René

___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread René Jansen 
Hi Enrico,

can you make it so that cmake does not choke on an absent svn? Working 
revisions on git is a bonus but I don’t really need that - and they are uuids.
I’m all for git, in fact this is one of the last svn instances I pull from. But 
I don’t want to start that discussion, I just want to get rid of the dependency 
(which in my view, is wrong). 
If you can make that happen, that would be great. For now, I just edit it out 
but will leave it in the svn repo.

In NetRexx, we generate the revision as a timestamp, and a build number to a 
file and pick that up, and we made the change to git some years ago without 
even noticing.

best regards,

René

> On 13 Sep 2019, at 09:14, Enrico Sorichetti via Oorexx-devel 
>  wrote:
> 
> The test are coming out pretty well 
> Buillt from a SVN repo
> Open Object Rexx Version 5.0.0 r11911 Svn[11911+]
> Build date: Sep 13 2019
> Addressing mode: 64
> Copyright (c) 1995, 2004 IBM Corporation. All rights reserved.
> Copyright (c) 2005-2019 Rexx Language Association. All rights reserved.
> 
> The “+” tells that there are uncommitted changes
> 
> Built from a GIT Repo
> [enrico@enrico-imac ooRexx.trunk.bin]$/Users/enrico/ooRexx/bin/rexx -v
> Open Object Rexx Version 5.0.0 r1 Git[9e6661ee02d3]
> Build date: Sep 13 2019
> Addressing mode: 64
> Copyright (c) 1995, 2004 IBM Corporation. All rights reserved.
> Copyright (c) 2005-2019 Rexx Language Association. All rights reserved.
> 
> Enrico
> 
> PS.: If You want I can also do it for a mercurial repository
> 
> I know the nobody wants to hear about it, but having a GIT repo would make 
> collaboration MUCH MORE EASY
> 
> Fork the repo 
> Commit the proposed changes to the forked repository
> Create a pull request
> Process the pull request ( apply / reject )
> 
> 
>> On 13 Sep 2019, at 11:44, Rick McGuire > > wrote:
>> 
>> Yes, I object to the removal. Including the revision number information is a 
>> helpful tool for problem determination. I much prefer Enrico's suggestion to 
>> enhance this to obtain the revision number from other sources as well. 
>> 
>> Rick
>> 
>> On Fri, Sep 13, 2019 at 12:18 AM René Jansen > > wrote:
>> I am maintaining a docker image based on Arch linux that contains LSPF and 
>> ooRexx 5.0.0. I just tried to rebuild that because of the impending 
>> symposium and had spurious behavior from svn on SourceForge (truncated http 
>> response bodies blablabla) and I could not fix that quickly.
>> 
>> So I decided to put up a copy on Github which works brilliantly. But … and 
>> here it comes… CmakeLists.txt has a hard dependency on Subversion and does 
>> an 'svn info' which breaks the build from git, as that is not an svn working 
>> copy.
>> 
>> I cannot see the rationale for this. Took it out and the build succeeds. 
>> Does anybody mind if I take that out of the svn repository CMakeLists.txt 
>> also?
>> 
>> best regards,
>> 
>> René.
>> 
>> ___
>> Oorexx-devel mailing list
>> Oorexx-devel@lists.sourceforge.net 
>> 
>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel 
>> 
>> ___
>> Oorexx-devel mailing list
>> Oorexx-devel@lists.sourceforge.net 
>> 
>> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
> 
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel

___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread Enrico Sorichetti via Oorexx-devel 
The test are coming out pretty well 
Buillt from a SVN repo
Open Object Rexx Version 5.0.0 r11911 Svn[11911+]
Build date: Sep 13 2019
Addressing mode: 64
Copyright (c) 1995, 2004 IBM Corporation. All rights reserved.
Copyright (c) 2005-2019 Rexx Language Association. All rights reserved.

The “+” tells that there are uncommitted changes

Built from a GIT Repo
[enrico@enrico-imac ooRexx.trunk.bin]$/Users/enrico/ooRexx/bin/rexx -v
Open Object Rexx Version 5.0.0 r1 Git[9e6661ee02d3]
Build date: Sep 13 2019
Addressing mode: 64
Copyright (c) 1995, 2004 IBM Corporation. All rights reserved.
Copyright (c) 2005-2019 Rexx Language Association. All rights reserved.

Enrico

PS.: If You want I can also do it for a mercurial repository

I know the nobody wants to hear about it, but having a GIT repo would make 
collaboration MUCH MORE EASY

Fork the repo 
Commit the proposed changes to the forked repository
Create a pull request
Process the pull request ( apply / reject )


> On 13 Sep 2019, at 11:44, Rick McGuire  wrote:
> 
> Yes, I object to the removal. Including the revision number information is a 
> helpful tool for problem determination. I much prefer Enrico's suggestion to 
> enhance this to obtain the revision number from other sources as well. 
> 
> Rick
> 
> On Fri, Sep 13, 2019 at 12:18 AM René Jansen  > wrote:
> I am maintaining a docker image based on Arch linux that contains LSPF and 
> ooRexx 5.0.0. I just tried to rebuild that because of the impending symposium 
> and had spurious behavior from svn on SourceForge (truncated http response 
> bodies blablabla) and I could not fix that quickly.
> 
> So I decided to put up a copy on Github which works brilliantly. But … and 
> here it comes… CmakeLists.txt has a hard dependency on Subversion and does an 
> 'svn info' which breaks the build from git, as that is not an svn working 
> copy.
> 
> I cannot see the rationale for this. Took it out and the build succeeds. Does 
> anybody mind if I take that out of the svn repository CMakeLists.txt also?
> 
> best regards,
> 
> René.
> 
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net 
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel 
> 
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel

___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread Rick McGuire 
Yes, I object to the removal. Including the revision number information is
a helpful tool for problem determination. I much prefer Enrico's suggestion
to enhance this to obtain the revision number from other sources as well.

Rick

On Fri, Sep 13, 2019 at 12:18 AM René Jansen  wrote:

> I am maintaining a docker image based on Arch linux that contains LSPF and
> ooRexx 5.0.0. I just tried to rebuild that because of the impending
> symposium and had spurious behavior from svn on SourceForge (truncated http
> response bodies blablabla) and I could not fix that quickly.
>
> So I decided to put up a copy on Github which works brilliantly. But … and
> here it comes… CmakeLists.txt has a hard dependency on Subversion and does
> an 'svn info' which breaks the build from git, as that is not an svn
> working copy.
>
> I cannot see the rationale for this. Took it out and the build succeeds.
> Does anybody mind if I take that out of the svn repository CMakeLists.txt
> also?
>
> best regards,
>
> René.
>
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel
>
___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel

Re: [Oorexx-devel] dependency on svn

2019-09-13 Thread Enrico Sorichetti via Oorexx-devel 
If You want I can provide the code to extract the revision information from  
git and mercurial repositories also
The current bug is that the cmakelists does not check for the presence of the 
.svn hidden directory 
Best regards
Enrico

> On 13 Sep 2019, at 06:17, René Jansen  wrote:
> 
> I am maintaining a docker image based on Arch linux that contains LSPF and 
> ooRexx 5.0.0. I just tried to rebuild that because of the impending symposium 
> and had spurious behavior from svn on SourceForge (truncated http response 
> bodies blablabla) and I could not fix that quickly.
> 
> So I decided to put up a copy on Github which works brilliantly. But … and 
> here it comes… CmakeLists.txt has a hard dependency on Subversion and does an 
> 'svn info' which breaks the build from git, as that is not an svn working 
> copy.
> 
> I cannot see the rationale for this. Took it out and the build succeeds. Does 
> anybody mind if I take that out of the svn repository CMakeLists.txt also?
> 
> best regards,
> 
> René.
> 
> ___
> Oorexx-devel mailing list
> Oorexx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oorexx-devel



___
Oorexx-devel mailing list
Oorexx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/oorexx-devel