Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Hans de Goede
Bart Van Assche wrote: On Mon, Jan 19, 2009 at 4:35 PM, Hans de Goede hdego...@redhat.com wrote: - libiscsi_discover_sendtargets - maybe (very maybe) the int port could be dropped and const char *address could be of the form address_or_host[:port].

Q: CHAP and Linux

2009-01-20 Thread Ulrich Windl
Hello, this is a quote from HP StorageWorks EVA iSCSI Connectivity Option 7.1 release notes: mpx100 and CHAP security with Linux not supported The CHAP setup with the Linux iSCSI initiator 3.6.3 is not supported with the mpx100. The Linux iSCSI driver omits CHAP security negotiations at

[PATCH] iscsi tcp: bidi capable

2009-01-20 Thread Boaz Harrosh
From: Pete Wyckoff p...@padd.com Mark iscsi_tcp as being capable of bidirectional transfers. The bsg interface checks this bit before attempting any bidirectional commands. Signed-off-by: Pete Wyckoff p...@padd.com Signed-off-by: Boaz Harrosh bharr...@panasas.com --- drivers/scsi/iscsi_tcp.c

Re: [PATCH] iscsi tcp: bidi capable

2009-01-20 Thread Boaz Harrosh
Boaz Harrosh wrote: From: Pete Wyckoff p...@padd.com Mark iscsi_tcp as being capable of bidirectional transfers. The bsg interface checks this bit before attempting any bidirectional commands. Signed-off-by: Pete Wyckoff p...@padd.com Signed-off-by: Boaz Harrosh bharr...@panasas.com

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Konrad Rzeszutek
NACK. I presume you have run this program (and the test-code) through valgrind with no memory leaks? Please see my comments below. diff -urN open-iscsi-2.0-870.1.orig/libiscsi/libiscsi.c open-iscsi-2.0-870.1/libiscsi/libiscsi.c --- open-iscsi-2.0-870.1.orig/libiscsi/libiscsi.c

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Konrad Rzeszutek
I would recommend that you provide as the first variable in all of the structs an unsigned int called 'version'. This way if the structs are extended they would be backwards compatible and there is an easy way to identify which version of structs they are. Erm, given the amount

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Bart Van Assche
On Tue, Jan 20, 2009 at 7:20 PM, Konrad Rzeszutek kon...@virtualiron.com wrote: I would recommend that you provide as the first variable in all of the structs an unsigned int called 'version'. This way if the structs are extended they would be backwards compatible and there is an easy

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Hans de Goede
Hi, Konrad Rzeszutek wrote: Thanks for the review! I presume you have run this program (and the test-code) through valgrind with no memory leaks? Erm, no, has iscsiadm been run through valgrind? If not I'm not going to be running libiscsi through it either (sorry) libiscsi builds on

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Konrad Rzeszutek
On Tue, Jan 20, 2009 at 07:40:08PM +0100, Bart Van Assche wrote: On Tue, Jan 20, 2009 at 7:20 PM, Konrad Rzeszutek kon...@virtualiron.com wrote: I would recommend that you provide as the first variable in all of the structs an unsigned int called 'version'. This way if the structs

Re: Q: CHAP and Linux

2009-01-20 Thread Mike Christie
Ulrich Windl wrote: Hello, this is a quote from HP StorageWorks EVA iSCSI Connectivity Option 7.1 release notes: mpx100 and CHAP security with Linux not supported The CHAP setup with the Linux iSCSI initiator 3.6.3 is not supported with the mpx100. The Linux iSCSI driver omits

Re: Q: on ISIDs and TSIDs

2009-01-20 Thread Mike Christie
Ulrich Windl wrote: Hi, there are Initiator Session IDs (ISID) and Target Session IDs (TSID) in the iSCSI specification. iscsiadm -m session -i (from SLES10 SP1) displays: Session (sid 6): is that the ISID? No. It is just the kernel's identifier for the session. Host Number: 9 : is

Re: PATCH: make open-iscsi userspace tools functionality available as a library

2009-01-20 Thread Konrad Rzeszutek
On Tue, Jan 20, 2009 at 07:58:07PM +0100, Hans de Goede wrote: Hi, Konrad Rzeszutek wrote: Thanks for the review! I presume you have run this program (and the test-code) through valgrind with no memory leaks? Erm, no, has iscsiadm been run through valgrind? If not I'm not

[RFC] manage qla4xxx iscsi sessions with iscsiadm

2009-01-20 Thread Mike Christie
Hey Dave, In the qla4xxx branch of the iscsi git tree I added code so that iscsiadm can control sessions that are accessed through qla4xxx. The patches are here: http://git.kernel.org/?p=linux/kernel/git/mnc/linux-2.6-iscsi.git;a=commit;h=f95246f8e84a12267e3c9e811a94004f598ef285

RE: [RFC] manage qla4xxx iscsi sessions with iscsiadm

2009-01-20 Thread David Somayajulu
Mike Christie wrote: Thanks Mike. I will take review and get back. -david S. Hey Dave, In the qla4xxx branch of the iscsi git tree I added code so that iscsiadm can control sessions that are accessed through qla4xxx. The patches are here: