Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-10-03 Thread Mike Christie
On 09/08/2011 07:23 AM, Ankit Jain wrote: On Thu, Sep 8, 2011 at 2:26 PM, Aastha Mehta aasth...@gmail.com wrote: Sorry, please ignore the previous patch. There was some minor error in that. Re-attaching the patch here. +#includestdio.h +#includestdlib.h +#includestring.h +#include

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-10-03 Thread Aastha Mehta
Yeah, I am fine with adding the GPL2 headers. Thanks for the merging. Regards, Aastha. On 4 October 2011 06:44, Mike Christie micha...@cs.wisc.edu wrote: On 09/08/2011 07:23 AM, Ankit Jain wrote: On Thu, Sep 8, 2011 at 2:26 PM, Aastha Mehta aasth...@gmail.com wrote: Sorry, please ignore

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-08 Thread Aastha Mehta
this group at http://groups.google.com/group/open-iscsi?hl=en. From 22ca358914d43a489f23b4004c7743a7b28d0ae9 Mon Sep 17 00:00:00 2001 From: Aastha Mehta aasth...@gmail.com Date: Thu, 8 Sep 2011 22:25:44 -0700 Subject: [PATCH 1/1] added code to display verbose messages on session connection errors

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-08 Thread Aastha Mehta
Sorry, please ignore the previous patch. There was some minor error in that. Re-attaching the patch here. Thanks, Aastha. On 8 September 2011 01:44, Aastha Mehta aasth...@gmail.com wrote: Hi, Thanks for the feedback. I have included changes mentioned by different people. Attaching patch

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-08 Thread Ankit Jain
On Thu, Sep 8, 2011 at 2:26 PM, Aastha Mehta aasth...@gmail.com wrote: Sorry, please ignore the previous patch. There was some minor error in that. Re-attaching the patch here. +#includestdio.h +#includestdlib.h +#includestring.h +#include iscsi_if.h +#includekern_error_table.h +#define

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-08 Thread Ankit Jain
On Thu, Sep 8, 2011 at 2:26 PM, Aastha Mehta aasth...@gmail.com wrote: Sorry, please ignore the previous patch. There was some minor error in that. Re-attaching the patch here. +#includestdio.h +#includestdlib.h +#includestring.h +#include iscsi_if.h +#includekern_error_table.h +#define

Antw: Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-05 Thread Ulrich Windl
Aastha Mehta aasth...@gmail.com schrieb am 03.09.2011 um 07:50 in Nachricht caex9m45bx_tzjconvwdobqjjqzmuqqfpufc8rgjxdk+n52-...@mail.gmail.com: Hi, Thanks for the suggestions. There is already an enumeration of the error codes given in the iscsi_if.h. The #defines cannot use the same

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-03 Thread Mike Christie
On 08/31/2011 11:57 AM, Aastha Mehta wrote: Hello, Attached is the patch for the first kernel TODO item in the TODO list circulated earlier. I could not send the patch through git send-email, so have attached it here. Thanks, Aastha. - You do not need the changes to

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-03 Thread Aastha Mehta
Hi, I have not done any changes to prom_lex.c. The diff shows something because of difference in the two git sources downloaded. How do I drop the changes? Will git diff --check suffice? Please confirm if I should #define the error messages or not. If yes, will macro name pattern like

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-03 Thread Aastha Mehta
Before I patch again, would like to show you the files. Have added a default case in the err_code_to_string() function. Also removed the extra err_string variable I used previously in the function. Each case now directly returns the appropriate message from the table directly, as no other work is

Antw: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-02 Thread Ulrich Windl
Aastha Mehta aasth...@gmail.com schrieb am 31.08.2011 um 18:57 in Nachricht CAEx9m44_UGavmNQ-Z8gdutsk-ZRSFZ+nKeBG+YGSK=vxdnn...@mail.gmail.com: Hello, Attached is the patch for the first kernel TODO item in the TODO list circulated earlier. I could not send the patch through git

Re: [PATCH 1/1] added code to display verbose messages on session connection errors

2011-09-02 Thread Aastha Mehta
Hi, Thanks for the suggestions. There is already an enumeration of the error codes given in the iscsi_if.h. The #defines cannot use the same names, but it can be done with slightly different names. So I shall modify the following things in the code - 1. #define the error messages and use those 2.

[PATCH 1/1] added code to display verbose messages on session connection errors

2011-08-31 Thread Aastha Mehta
/group/open-iscsi?hl=en. From ef75092e47544e126b259114ce87cdf395ca3d9d Mon Sep 17 00:00:00 2001 From: Aastha Mehta aasth...@gmail.com Date: Mon, 29 Aug 2011 10:18:17 -0700 Subject: [PATCH 1/1] added code to display verbose messages on session connection errors --- usr/Makefile |2