Re: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

2010-03-23 Thread FUJITA Tomonori
On Mon, 22 Mar 2010 11:16:31 -0400 James Smart james.sm...@emulex.com wrote: About the implementation, I think that it's better to have the common library code rather than just copying the fs bsg code into iscsi. Note: I tried to library-ize the transport implementation on the first pass

Re: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

2010-03-22 Thread James Smart
FUJITA Tomonori wrote: If vendors use the common data structures via bsg, it's totally fine by me. I see why bsg is preferable. The only thing that I care about is managing any iSCSI HBA with iscsiadm instead of various vendor specific utilities. agreed About the implementation, I think

Re: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

2010-03-22 Thread FUJITA Tomonori
On Fri, 19 Mar 2010 08:56:30 -0400 James Smart james.sm...@emulex.com wrote: I still want to know why vendors can't do this via the existing netlink interface. open-iscsi uses the netlink interface for some pdu so I guess that having a different channel for management might be a good

Re: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

2010-03-19 Thread James Smart
FUJITA Tomonori wrote: On Thu, 18 Mar 2010 16:02:52 -0500 Mike Christie micha...@cs.wisc.edu wrote: On 03/18/2010 08:58 AM, FUJITA Tomonori wrote: - You invent your hardware specific data structure for the simplest operation such as setting IP address. I think this is what Jay is not

Re: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

2010-03-19 Thread FUJITA Tomonori
On Thu, 18 Mar 2010 16:02:52 -0500 Mike Christie micha...@cs.wisc.edu wrote: On 03/18/2010 08:58 AM, FUJITA Tomonori wrote: - You invent your hardware specific data structure for the simplest operation such as setting IP address. I think this is what Jay is not trying to do. I think

Re: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

2010-03-19 Thread Mike Christie
On 03/18/2010 06:10 PM, FUJITA Tomonori wrote: On Thu, 18 Mar 2010 16:02:52 -0500 Mike Christiemicha...@cs.wisc.edu wrote: On 03/18/2010 08:58 AM, FUJITA Tomonori wrote: - You invent your hardware specific data structure for the simplest operation such as setting IP address. I think

Re: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

2010-03-18 Thread FUJITA Tomonori
On Wed, 17 Mar 2010 23:37:07 +0530 Jayamohan Kallickal jayamoh...@serverengines.com wrote: This patch contains the necessary changes to support the bsg interface Signed-off-by: Jayamohan Kallickal jayamoh...@serverengines.com --- drivers/scsi/be2iscsi/be_cmds.h | 137

Re: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

2010-03-18 Thread Mike Christie
On 03/18/2010 08:58 AM, FUJITA Tomonori wrote: - You invent your hardware specific data structure for the simplest operation such as setting IP address. I think this is what Jay is not trying to do. I think the patch has some extra code like the ISCSI_BSG_HST_VENDOR parts that makes it